[jira] [Updated] (HBASE-23909) list_regions fails if table is under split

2020-03-05 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-23909:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Pushed to master, branch-2's and branch-1. Thanks for the review [~wchevreuil] 
[~psomogyi] [~janh]

> list_regions fails if table is under split
> --
>
> Key: HBASE-23909
> URL: https://issues.apache.org/jira/browse/HBASE-23909
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.6.0
>Reporter: Peter Somogyi
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.4, 2.1.10
>
>
> Shortly after executing split 'table' command from the shell the list_regions 
> 'table' fails with "ERROR: undefined method `toString' for nil:NilClass"
>  
> {noformat}
> hbase(main):002:0> list_regions 'cluster_test'
>  SERVER_NAME |
>REGION_NAME |  START_KEY |END_KEY |  SIZE |  REQ |   
> LOCALITY |
>  --- | 
> - | 
> -- | -- | - |  | -- |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.857a9b734a2f490e573ba20b1bbf99b3. ||  
>   |  3348 | 20408042 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.1749360028b3a5e76b5da1d1888e5b9d. |   
>  |    |  3321 | 20242123 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.1f1366aa0ee621d496103ac5a50bca77. |   
>  |    |  3316 | 20215774 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.ae95589c9498443a89aea4c42c199372. |   
>  |    |  3327 | 20285312 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.239647c37e27cbd3154180ce5004a1ea. |   
>  ||  3355 | 20451469 |0.0 |
>  5 rows
> hbase(main):003:0> split 'cluster_test'
> 0 row(s) in 0.2240 seconds
> hbase(main):004:0> list_regions 'cluster_test'
> ERROR: undefined method `toString' for nil:NilClass
> Here is some help for this command:
> List all regions for a particular table as an array and also filter 
> them by server name (optional) as prefix
> and maximum locality (optional). By default, it will return all the 
> regions for the table with any locality.
> The command displays server name, region name, start key, end key, 
> size of the region in MB, number of requests
> and the locality. The information can be projected out via an array 
> as third parameter. By default all these information
> is displayed. Possible array values are SERVER_NAME, REGION_NAME, 
> START_KEY, END_KEY, SIZE, REQ and LOCALITY. Values
> are not case sensitive. If you don't want to filter by server name, 
> pass an empty hash / string as shown below.
> Examples:
> hbase> list_regions 'table_name'
> hbase> list_regions 'table_name', 'server_name'
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', 
> LOCALITY_THRESHOLD => 0.8}
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', 
> LOCALITY_THRESHOLD => 0.8}, ['SERVER_NAME']
> hbase> list_regions 'table_name', {}, ['SERVER_NAME', 'start_key']
> hbase> list_regions 'table_name', '', ['SERVER_NAME', 'start_key']
> hbase(main):005:0> list_regions 'cluster_test'
>  SERVER_NAME |
>   REGION_NAME |   
> START_KEY | END_KEY |  SIZE |  
> REQ |   LOCALITY |
>  --- | 
> 
>  | --- | 
> --- | - |  | -- |
>  nokedli,34665,1582736360668 |
> cluster_test,,1582878981608.614acededc61f55a10816bb871d0421b. |   
>   | 197f83f2390a2a0c4104f4630982c585-461828 |  3348 | 
> 10204021 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,197f83f2390a2a0c4104f4630982c585-461828,1582878981608.5987f972793bd422564a0758e545caa5.
>  | 197f83f2390a2a0c4104f4630982c585-461828 |
>  |  3348 | 10204021 |0.0 |
>  nokedli,34665,1582736360668 |
> cluster_test,,1582878982425.a306381f3ee03161dc832eaca066131b. |   
>   

[jira] [Updated] (HBASE-23909) list_regions fails if table is under split

2020-03-05 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-23909:
-
Fix Version/s: (was: 1.6.1)
   1.7.0

> list_regions fails if table is under split
> --
>
> Key: HBASE-23909
> URL: https://issues.apache.org/jira/browse/HBASE-23909
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.6.0
>Reporter: Peter Somogyi
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.4, 2.1.10
>
>
> Shortly after executing split 'table' command from the shell the list_regions 
> 'table' fails with "ERROR: undefined method `toString' for nil:NilClass"
>  
> {noformat}
> hbase(main):002:0> list_regions 'cluster_test'
>  SERVER_NAME |
>REGION_NAME |  START_KEY |END_KEY |  SIZE |  REQ |   
> LOCALITY |
>  --- | 
> - | 
> -- | -- | - |  | -- |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.857a9b734a2f490e573ba20b1bbf99b3. ||  
>   |  3348 | 20408042 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.1749360028b3a5e76b5da1d1888e5b9d. |   
>  |    |  3321 | 20242123 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.1f1366aa0ee621d496103ac5a50bca77. |   
>  |    |  3316 | 20215774 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.ae95589c9498443a89aea4c42c199372. |   
>  |    |  3327 | 20285312 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.239647c37e27cbd3154180ce5004a1ea. |   
>  ||  3355 | 20451469 |0.0 |
>  5 rows
> hbase(main):003:0> split 'cluster_test'
> 0 row(s) in 0.2240 seconds
> hbase(main):004:0> list_regions 'cluster_test'
> ERROR: undefined method `toString' for nil:NilClass
> Here is some help for this command:
> List all regions for a particular table as an array and also filter 
> them by server name (optional) as prefix
> and maximum locality (optional). By default, it will return all the 
> regions for the table with any locality.
> The command displays server name, region name, start key, end key, 
> size of the region in MB, number of requests
> and the locality. The information can be projected out via an array 
> as third parameter. By default all these information
> is displayed. Possible array values are SERVER_NAME, REGION_NAME, 
> START_KEY, END_KEY, SIZE, REQ and LOCALITY. Values
> are not case sensitive. If you don't want to filter by server name, 
> pass an empty hash / string as shown below.
> Examples:
> hbase> list_regions 'table_name'
> hbase> list_regions 'table_name', 'server_name'
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', 
> LOCALITY_THRESHOLD => 0.8}
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', 
> LOCALITY_THRESHOLD => 0.8}, ['SERVER_NAME']
> hbase> list_regions 'table_name', {}, ['SERVER_NAME', 'start_key']
> hbase> list_regions 'table_name', '', ['SERVER_NAME', 'start_key']
> hbase(main):005:0> list_regions 'cluster_test'
>  SERVER_NAME |
>   REGION_NAME |   
> START_KEY | END_KEY |  SIZE |  
> REQ |   LOCALITY |
>  --- | 
> 
>  | --- | 
> --- | - |  | -- |
>  nokedli,34665,1582736360668 |
> cluster_test,,1582878981608.614acededc61f55a10816bb871d0421b. |   
>   | 197f83f2390a2a0c4104f4630982c585-461828 |  3348 | 
> 10204021 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,197f83f2390a2a0c4104f4630982c585-461828,1582878981608.5987f972793bd422564a0758e545caa5.
>  | 197f83f2390a2a0c4104f4630982c585-461828 |
>  |  3348 | 10204021 |0.0 |
>  nokedli,34665,1582736360668 |
> cluster_test,,1582878982425.a306381f3ee03161dc832eaca066131b. |   
>   | 4cdfa653a3843d49a62004a6e4e71636-501997 | 
>  3321 | 10121061 |0.0 |
>  

[jira] [Updated] (HBASE-23909) list_regions fails if table is under split

2020-03-05 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-23909:
-
Fix Version/s: 2.1.10

> list_regions fails if table is under split
> --
>
> Key: HBASE-23909
> URL: https://issues.apache.org/jira/browse/HBASE-23909
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.6.0
>Reporter: Peter Somogyi
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.1, 2.2.4, 2.1.10
>
>
> Shortly after executing split 'table' command from the shell the list_regions 
> 'table' fails with "ERROR: undefined method `toString' for nil:NilClass"
>  
> {noformat}
> hbase(main):002:0> list_regions 'cluster_test'
>  SERVER_NAME |
>REGION_NAME |  START_KEY |END_KEY |  SIZE |  REQ |   
> LOCALITY |
>  --- | 
> - | 
> -- | -- | - |  | -- |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.857a9b734a2f490e573ba20b1bbf99b3. ||  
>   |  3348 | 20408042 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.1749360028b3a5e76b5da1d1888e5b9d. |   
>  |    |  3321 | 20242123 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.1f1366aa0ee621d496103ac5a50bca77. |   
>  |    |  3316 | 20215774 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.ae95589c9498443a89aea4c42c199372. |   
>  |    |  3327 | 20285312 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.239647c37e27cbd3154180ce5004a1ea. |   
>  ||  3355 | 20451469 |0.0 |
>  5 rows
> hbase(main):003:0> split 'cluster_test'
> 0 row(s) in 0.2240 seconds
> hbase(main):004:0> list_regions 'cluster_test'
> ERROR: undefined method `toString' for nil:NilClass
> Here is some help for this command:
> List all regions for a particular table as an array and also filter 
> them by server name (optional) as prefix
> and maximum locality (optional). By default, it will return all the 
> regions for the table with any locality.
> The command displays server name, region name, start key, end key, 
> size of the region in MB, number of requests
> and the locality. The information can be projected out via an array 
> as third parameter. By default all these information
> is displayed. Possible array values are SERVER_NAME, REGION_NAME, 
> START_KEY, END_KEY, SIZE, REQ and LOCALITY. Values
> are not case sensitive. If you don't want to filter by server name, 
> pass an empty hash / string as shown below.
> Examples:
> hbase> list_regions 'table_name'
> hbase> list_regions 'table_name', 'server_name'
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', 
> LOCALITY_THRESHOLD => 0.8}
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', 
> LOCALITY_THRESHOLD => 0.8}, ['SERVER_NAME']
> hbase> list_regions 'table_name', {}, ['SERVER_NAME', 'start_key']
> hbase> list_regions 'table_name', '', ['SERVER_NAME', 'start_key']
> hbase(main):005:0> list_regions 'cluster_test'
>  SERVER_NAME |
>   REGION_NAME |   
> START_KEY | END_KEY |  SIZE |  
> REQ |   LOCALITY |
>  --- | 
> 
>  | --- | 
> --- | - |  | -- |
>  nokedli,34665,1582736360668 |
> cluster_test,,1582878981608.614acededc61f55a10816bb871d0421b. |   
>   | 197f83f2390a2a0c4104f4630982c585-461828 |  3348 | 
> 10204021 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,197f83f2390a2a0c4104f4630982c585-461828,1582878981608.5987f972793bd422564a0758e545caa5.
>  | 197f83f2390a2a0c4104f4630982c585-461828 |
>  |  3348 | 10204021 |0.0 |
>  nokedli,34665,1582736360668 |
> cluster_test,,1582878982425.a306381f3ee03161dc832eaca066131b. |   
>   | 4cdfa653a3843d49a62004a6e4e71636-501997 | 
>  3321 | 10121061 |0.0 |
>  nokedli,34665,1582736360668 | 
> 

[jira] [Updated] (HBASE-23909) list_regions fails if table is under split

2020-03-05 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-23909:
-
Fix Version/s: 2.2.4

> list_regions fails if table is under split
> --
>
> Key: HBASE-23909
> URL: https://issues.apache.org/jira/browse/HBASE-23909
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.6.0
>Reporter: Peter Somogyi
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.1, 2.2.4
>
>
> Shortly after executing split 'table' command from the shell the list_regions 
> 'table' fails with "ERROR: undefined method `toString' for nil:NilClass"
>  
> {noformat}
> hbase(main):002:0> list_regions 'cluster_test'
>  SERVER_NAME |
>REGION_NAME |  START_KEY |END_KEY |  SIZE |  REQ |   
> LOCALITY |
>  --- | 
> - | 
> -- | -- | - |  | -- |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.857a9b734a2f490e573ba20b1bbf99b3. ||  
>   |  3348 | 20408042 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.1749360028b3a5e76b5da1d1888e5b9d. |   
>  |    |  3321 | 20242123 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.1f1366aa0ee621d496103ac5a50bca77. |   
>  |    |  3316 | 20215774 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.ae95589c9498443a89aea4c42c199372. |   
>  |    |  3327 | 20285312 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,,1582736408029.239647c37e27cbd3154180ce5004a1ea. |   
>  ||  3355 | 20451469 |0.0 |
>  5 rows
> hbase(main):003:0> split 'cluster_test'
> 0 row(s) in 0.2240 seconds
> hbase(main):004:0> list_regions 'cluster_test'
> ERROR: undefined method `toString' for nil:NilClass
> Here is some help for this command:
> List all regions for a particular table as an array and also filter 
> them by server name (optional) as prefix
> and maximum locality (optional). By default, it will return all the 
> regions for the table with any locality.
> The command displays server name, region name, start key, end key, 
> size of the region in MB, number of requests
> and the locality. The information can be projected out via an array 
> as third parameter. By default all these information
> is displayed. Possible array values are SERVER_NAME, REGION_NAME, 
> START_KEY, END_KEY, SIZE, REQ and LOCALITY. Values
> are not case sensitive. If you don't want to filter by server name, 
> pass an empty hash / string as shown below.
> Examples:
> hbase> list_regions 'table_name'
> hbase> list_regions 'table_name', 'server_name'
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', 
> LOCALITY_THRESHOLD => 0.8}
> hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', 
> LOCALITY_THRESHOLD => 0.8}, ['SERVER_NAME']
> hbase> list_regions 'table_name', {}, ['SERVER_NAME', 'start_key']
> hbase> list_regions 'table_name', '', ['SERVER_NAME', 'start_key']
> hbase(main):005:0> list_regions 'cluster_test'
>  SERVER_NAME |
>   REGION_NAME |   
> START_KEY | END_KEY |  SIZE |  
> REQ |   LOCALITY |
>  --- | 
> 
>  | --- | 
> --- | - |  | -- |
>  nokedli,34665,1582736360668 |
> cluster_test,,1582878981608.614acededc61f55a10816bb871d0421b. |   
>   | 197f83f2390a2a0c4104f4630982c585-461828 |  3348 | 
> 10204021 |0.0 |
>  nokedli,34665,1582736360668 | 
> cluster_test,197f83f2390a2a0c4104f4630982c585-461828,1582878981608.5987f972793bd422564a0758e545caa5.
>  | 197f83f2390a2a0c4104f4630982c585-461828 |
>  |  3348 | 10204021 |0.0 |
>  nokedli,34665,1582736360668 |
> cluster_test,,1582878982425.a306381f3ee03161dc832eaca066131b. |   
>   | 4cdfa653a3843d49a62004a6e4e71636-501997 | 
>  3321 | 10121061 |0.0 |
>  nokedli,34665,1582736360668 | 
> 

[GitHub] [hbase] virajjasani merged pull request #1238: HBASE-23909 : list_regions raise correct error if it is being splitte…

2020-03-05 Thread GitBox
virajjasani merged pull request #1238: HBASE-23909 : list_regions raise correct 
error if it is being splitte…
URL: https://github.com/apache/hbase/pull/1238
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] nyl3532016 opened a new pull request #1243: HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr…

2020-03-05 Thread GitBox
nyl3532016 opened a new pull request #1243: HBASE-23944 The method 
setClusterLoad of SimpleLoadBalancer is incorr…
URL: https://github.com/apache/hbase/pull/1243
 
 
   …ect when balance by table


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread Michael Stack (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053095#comment-17053095
 ] 

Michael Stack commented on HBASE-23876:
---

Yeah, master and branch-2 have this yetus check failure since this patch went 
in.

> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to nightly job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-23944) The method setClusterLoad of SimpleLoadBalancer is incorrect when balance by table

2020-03-05 Thread niuyulin (Jira)
niuyulin created HBASE-23944:


 Summary: The method setClusterLoad of SimpleLoadBalancer is 
incorrect when balance by table 
 Key: HBASE-23944
 URL: https://issues.apache.org/jira/browse/HBASE-23944
 Project: HBase
  Issue Type: Bug
  Components: Balancer
Affects Versions: 2.2.2
Reporter: niuyulin
Assignee: niuyulin
 Fix For: 3.0.0, 2.2.2


now if in parameter clusterLoad is by table, for example
{code:java}
table1=>
     server1=>[table1,region1]
     server2=>[]
table2=>
    server1=>[table2,region1]
    server2=>[]
{code}
then, the member variable serverLoadList is:
{code:java}
[{server1, load 1}{server2, load 0}{server1, load 1} {server2, load 0}]
{code}
the cluster will be considered balanced  in method overallNeedsBalance



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread Michael Stack (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053093#comment-17053093
 ] 

Michael Stack commented on HBASE-23876:
---

Docker file complaints? 
[https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535/artifact/output-general/diff-patch-hadolint.txt|https://slack-redir.net/link?url=https%3A%2F%2Fbuilds.apache.org%2Fjob%2FHBase%2520Nightly%2Fjob%2Fbranch-2%2F2535%2Fartifact%2Foutput-general%2Fdiff-patch-hadolint.txt=3]
 
 
This Dockerfile changed in this jdk11 change... 
[https://github.com/apache/hbase/pull/1195/files|https://slack-redir.net/link?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F1195%2Ffiles=3]
 .. Could it be why?

> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to nightly job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052731#comment-17052731
 ] 

Hudson commented on HBASE-23876:


Results for branch master
[build #1655 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1655/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK8_Nightly_Build_Report_(Hadoop3)/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK11_Nightly_Build_Report/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to nightly job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23198) Documentation and release notes

2020-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052729#comment-17052729
 ] 

Hudson commented on HBASE-23198:


Results for branch master
[build #1655 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1655/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK8_Nightly_Build_Report_(Hadoop3)/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK11_Nightly_Build_Report/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Documentation and release notes
> ---
>
> Key: HBASE-23198
> URL: https://issues.apache.org/jira/browse/HBASE-23198
> Project: HBase
>  Issue Type: Sub-task
>  Components: community, documentation, mob
>Reporter: Vladimir Rodionov
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 3.0.0
>
>
> Document all the changes: algorithms, new configuration options, obsolete 
> configurations, upgrade procedure and possibility of downgrade.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23767) Add JDK11 compilation and unit test support to Github precommit

2020-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052730#comment-17052730
 ] 

Hudson commented on HBASE-23767:


Results for branch master
[build #1655 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1655/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK8_Nightly_Build_Report_(Hadoop3)/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1655//JDK11_Nightly_Build_Report/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add JDK11 compilation and unit test support to Github precommit
> ---
>
> Key: HBASE-23767
> URL: https://issues.apache.org/jira/browse/HBASE-23767
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to GitHub-based pre-commit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition 
when failed to insert procedur…
URL: https://github.com/apache/hbase/pull/1221#issuecomment-595581217
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 32s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 48s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 56s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 45s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |  61m 26s |  hbase-server in the patch passed.  
|
   |  |   |  87m 24s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1221 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux bbda1cc893c3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 4c9d14a788 |
   | Default Java | 1.8.0_232 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/testReport/
 |
   | Max. process+thread count | 8850 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1242: HBASE-23861. Reconcile Hadoop version.

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1242: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1242#issuecomment-595578583
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |  16m  3s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  7s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   7m 20s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m 52s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 31s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   4m 13s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   6m 29s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 41s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 41s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 27s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   4m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  15m  8s |  root in the patch failed.  |
   |  |   |  74m 49s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1242 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 8fa76f552582 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 9ff3fe11c4 |
   | Default Java | 1.8.0_232 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/testReport/
 |
   | Max. process+thread count | 813 (vs. ulimit of 1) |
   | modules | C: hbase-server . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-23767) Add JDK11 compilation and unit test support to Github precommit

2020-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052710#comment-17052710
 ] 

Hudson commented on HBASE-23767:


Results for branch branch-2
[build #2535 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535//JDK8_Nightly_Build_Report_(Hadoop3)/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535//JDK11_Nightly_Build_Report/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add JDK11 compilation and unit test support to Github precommit
> ---
>
> Key: HBASE-23767
> URL: https://issues.apache.org/jira/browse/HBASE-23767
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to GitHub-based pre-commit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052711#comment-17052711
 ] 

Hudson commented on HBASE-23876:


Results for branch branch-2
[build #2535 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535//JDK8_Nightly_Build_Report_(Hadoop3)/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2535//JDK11_Nightly_Build_Report/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to nightly job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-23743) Release 1.4.13

2020-03-05 Thread Sakthi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sakthi resolved HBASE-23743.

Resolution: Fixed

> Release 1.4.13
> --
>
> Key: HBASE-23743
> URL: https://issues.apache.org/jira/browse/HBASE-23743
> Project: HBase
>  Issue Type: Task
>  Components: build, community
>Affects Versions: 1.4.13
>Reporter: Sean Busbey
>Assignee: Sakthi
>Priority: Major
> Fix For: 1.4.13
>
>
> over due for 1.4.13. I'll try to use the release manager scripts this time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23743) Release 1.4.13

2020-03-05 Thread Sakthi (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052708#comment-17052708
 ] 

Sakthi commented on HBASE-23743:


Closing out the Jira as the announcement has been done.

> Release 1.4.13
> --
>
> Key: HBASE-23743
> URL: https://issues.apache.org/jira/browse/HBASE-23743
> Project: HBase
>  Issue Type: Task
>  Components: build, community
>Affects Versions: 1.4.13
>Reporter: Sean Busbey
>Assignee: Sakthi
>Priority: Major
> Fix For: 1.4.13
>
>
> over due for 1.4.13. I'll try to use the release manager scripts this time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-22827) Expose multi-region merge in shell and Admin API

2020-03-05 Thread Sakthi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sakthi updated HBASE-22827:
---
Fix Version/s: 2.1.10

> Expose multi-region merge in shell and Admin API
> 
>
> Key: HBASE-22827
> URL: https://issues.apache.org/jira/browse/HBASE-22827
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin, shell
>Reporter: Michael Stack
>Assignee: Sakthi
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4, 2.1.10
>
> Attachments: hbase-22827.branch-2.001.patch
>
>
> HBASE-22777 adds being able to merge more than two regions at once. It is 
> only available internally currently for use by hbck2 doing fixup of overlaps 
> in hbase:meta. This issue is about exposing it via the Admin Interface and in 
> turn, via the shell. Probably best if old two region merge method is 
> deprecated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-22827) Expose multi-region merge in shell and Admin API

2020-03-05 Thread Sakthi (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052707#comment-17052707
 ] 

Sakthi commented on HBASE-22827:


Sorry for the delay [~zghao]. Have updated the RN.

> Expose multi-region merge in shell and Admin API
> 
>
> Key: HBASE-22827
> URL: https://issues.apache.org/jira/browse/HBASE-22827
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin, shell
>Reporter: Michael Stack
>Assignee: Sakthi
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
> Attachments: hbase-22827.branch-2.001.patch
>
>
> HBASE-22777 adds being able to merge more than two regions at once. It is 
> only available internally currently for use by hbck2 doing fixup of overlaps 
> in hbase:meta. This issue is about exposing it via the Admin Interface and in 
> turn, via the shell. Probably best if old two region merge method is 
> deprecated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-22827) Expose multi-region merge in shell and Admin API

2020-03-05 Thread Sakthi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sakthi resolved HBASE-22827.

Resolution: Fixed

> Expose multi-region merge in shell and Admin API
> 
>
> Key: HBASE-22827
> URL: https://issues.apache.org/jira/browse/HBASE-22827
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin, shell
>Reporter: Michael Stack
>Assignee: Sakthi
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
> Attachments: hbase-22827.branch-2.001.patch
>
>
> HBASE-22777 adds being able to merge more than two regions at once. It is 
> only available internally currently for use by hbck2 doing fixup of overlaps 
> in hbase:meta. This issue is about exposing it via the Admin Interface and in 
> turn, via the shell. Probably best if old two region merge method is 
> deprecated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-22827) Expose multi-region merge in shell and Admin API

2020-03-05 Thread Sakthi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sakthi updated HBASE-22827:
---
Release Note: merge_region shell command can now be used to merge more than 
2 regions as well. It takes a list of regions as comma separated values or as 
an array of regions, and not just 2 regions. The full regionnames and encoded 
regionnames are continued to be accepted.

> Expose multi-region merge in shell and Admin API
> 
>
> Key: HBASE-22827
> URL: https://issues.apache.org/jira/browse/HBASE-22827
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin, shell
>Reporter: Michael Stack
>Assignee: Sakthi
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
> Attachments: hbase-22827.branch-2.001.patch
>
>
> HBASE-22777 adds being able to merge more than two regions at once. It is 
> only available internally currently for use by hbck2 doing fixup of overlaps 
> in hbase:meta. This issue is about exposing it via the Admin Interface and in 
> turn, via the shell. Probably best if old two region merge method is 
> deprecated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on issue #1242: HBASE-23861. Reconcile Hadoop version.

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1242: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1242#issuecomment-595572892
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m 32s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  7s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   9m 45s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   5m 15s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   7m  2s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 25s |  root in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 51s |  hbase-server in branch-2 failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   8m 47s |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 19s |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 19s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 25s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 51s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 22s |  root in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   2m 22s |  root in the patch failed.  |
   |  |   |  52m 26s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1242 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 743adc0109b9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 9ff3fe11c4 |
   | Default Java | 2020-01-14 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/testReport/
 |
   | Max. process+thread count | 394 (vs. ulimit of 1) |
   | modules | C: hbase-server . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition 
when failed to insert procedur…
URL: https://github.com/apache/hbase/pull/1221#issuecomment-595570842
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   9m  0s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   7m 43s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 19s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 44s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 46s |  hbase-server in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   7m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 15s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 15s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 34s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 40s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   6m 54s |  hbase-server in the patch failed.  |
   |  |   |  47m  6s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1221 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux e019c9fe0d1f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 4c9d14a788 |
   | Default Java | 2020-01-14 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/testReport/
 |
   | Max. process+thread count | 1027 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition when failed to insert procedur…

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1221: HBASE-23895 STUCK Region-In-Transition 
when failed to insert procedur…
URL: https://github.com/apache/hbase/pull/1221#issuecomment-595570766
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 51s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m 28s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m  9s |  master passed  |
   | +0 :ok: |  spotbugs  |   4m 41s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   3m 20s |  hbase-server in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m 15s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 18s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  17m 39s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | -1 :x: |  findbugs  |   2m 49s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 15s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  46m 37s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1221 |
   | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck 
hbaseanti checkstyle |
   | uname | Linux 24580b55838d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 4c9d14a788 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt
 |
   | Max. process+thread count | 93 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1221/9/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1242: HBASE-23861. Reconcile Hadoop version.

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1242: HBASE-23861. Reconcile Hadoop version.
URL: https://github.com/apache/hbase/pull/1242#issuecomment-595567442
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   6m 18s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  3s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  hadoopcheck  |  18m  9s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 27s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  32m 44s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1242 |
   | Optional Tests | dupname asflicense hadoopcheck xml |
   | uname | Linux 840f4abdb488 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 9ff3fe11c4 |
   | Max. process+thread count | 63 (vs. ulimit of 1) |
   | modules | C: . hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1242/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22827) Expose multi-region merge in shell and Admin API

2020-03-05 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052684#comment-17052684
 ] 

Guanghao Zhang commented on HBASE-22827:


ping [~sakthi]

> Expose multi-region merge in shell and Admin API
> 
>
> Key: HBASE-22827
> URL: https://issues.apache.org/jira/browse/HBASE-22827
> Project: HBase
>  Issue Type: Improvement
>  Components: Admin, shell
>Reporter: Michael Stack
>Assignee: Sakthi
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
> Attachments: hbase-22827.branch-2.001.patch
>
>
> HBASE-22777 adds being able to merge more than two regions at once. It is 
> only available internally currently for use by hbck2 doing fixup of overlaps 
> in hbase:meta. This issue is about exposing it via the Admin Interface and in 
> turn, via the shell. Probably best if old two region merge method is 
> deprecated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23827) [HBCK2] Add mergeRegions method to hbck service

2020-03-05 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052682#comment-17052682
 ] 

Guanghao Zhang commented on HBASE-23827:


Can we just add a boolean flag to MergeTableRegionsRequest? No need to add a 
new merge rpc method. [~sakthi]

> [HBCK2] Add mergeRegions method to hbck service
> ---
>
> Key: HBASE-23827
> URL: https://issues.apache.org/jira/browse/HBASE-23827
> Project: HBase
>  Issue Type: Task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4, 2.1.10
>
>
> Let's add the mergeRegions method to the hbck service so that hbck2 can use 
> it from the client side.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] jojochuang opened a new pull request #1242: HBASE-23861. Reconcile Hadoop version.

2020-03-05 Thread GitBox
jojochuang opened a new pull request #1242: HBASE-23861. Reconcile Hadoop 
version.
URL: https://github.com/apache/hbase/pull/1242
 
 
   Clean cherrypick from master branch to branch-2. See: #1179 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase-operator-tools] busbey commented on issue #54: HBASE-23934 [operator tools] Add forbiddennapis plugin to pom.xml so …

2020-03-05 Thread GitBox
busbey commented on issue #54: HBASE-23934 [operator tools] Add forbiddennapis 
plugin to pom.xml so …
URL: 
https://github.com/apache/hbase-operator-tools/pull/54#issuecomment-595557889
 
 
   Nah. We can circle back to it later


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-23788) ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking

2020-03-05 Thread Anoop Sam John (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anoop Sam John updated HBASE-23788:
---
Hadoop Flags: Reviewed
  Resolution: Fixed
  Status: Resolved  (was: Patch Available)

Pushed to branch-2 and master.  Thanks for the patch [~abhinaba.sarkar]

> ROW_INDEX_V1 encoder should consider the secondary index size with the 
> encoded data size tracking
> -
>
> Key: HBASE-23788
> URL: https://issues.apache.org/jira/browse/HBASE-23788
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Anoop Sam John
>Assignee: Abhinaba Sarkar
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Copied from parent issue comments
> "In case of Row Index this tracking is not accounting the row offsets index 
> being written. Because on the go these are kept in memory only and written at 
> the end of block write. This end block decision was based on size check only 
> which did NOT include this offsets index."



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23932) Region Normalizer is disruptive while running hbck2 fix meta

2020-03-05 Thread Lijin Bin (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052633#comment-17052633
 ] 

Lijin Bin commented on HBASE-23932:
---

[~ndimiduk] Looks like i make a mistake, thanks for the remind.

> Region Normalizer is disruptive while running hbck2 fix meta
> 
>
> Key: HBASE-23932
> URL: https://issues.apache.org/jira/browse/HBASE-23932
> Project: HBase
>  Issue Type: Improvement
>  Components: hbck2, master
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
>
> While hbck2 runs through fixes to meta, the Normalizer kicks in to "help". 
> Mostly this is fine, however, things get confused when {{fixMeta}} is action 
> on a region and then the normalizer decides to do something as well. Could be 
> we advise operators disable normalizer while running hbck2, but would be 
> better if the normalizer was less aggressive, so that there's fewer flags to 
> fiddle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HBASE-23932) Region Normalizer is disruptive while running hbck2 fix meta

2020-03-05 Thread Lijin Bin (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lijin Bin reassigned HBASE-23932:
-

Assignee: Nick Dimiduk  (was: Lijin Bin)

> Region Normalizer is disruptive while running hbck2 fix meta
> 
>
> Key: HBASE-23932
> URL: https://issues.apache.org/jira/browse/HBASE-23932
> Project: HBase
>  Issue Type: Improvement
>  Components: hbck2, master
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
>
> While hbck2 runs through fixes to meta, the Normalizer kicks in to "help". 
> Mostly this is fine, however, things get confused when {{fixMeta}} is action 
> on a region and then the normalizer decides to do something as well. Could be 
> we advise operators disable normalizer while running hbck2, but would be 
> better if the normalizer was less aggressive, so that there's fewer flags to 
> fiddle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-20952) Re-visit the WAL API

2020-03-05 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052620#comment-17052620
 ] 

Duo Zhang commented on HBASE-20952:
---

The old one has been archived...

> Re-visit the WAL API
> 
>
> Key: HBASE-20952
> URL: https://issues.apache.org/jira/browse/HBASE-20952
> Project: HBase
>  Issue Type: Improvement
>  Components: wal
>Reporter: Josh Elser
>Priority: Major
> Attachments: 20952.v1.txt
>
>
> Take a step back from the current WAL implementations and think about what an 
> HBase WAL API should look like. What are the primitive calls that we require 
> to guarantee durability of writes with a high degree of performance?
> The API needs to take the current implementations into consideration. We 
> should also have a mind for what is happening in the Ratis LogService (but 
> the LogService should not dictate what HBase's WAL API looks like RATIS-272).
> Other "systems" inside of HBase that use WALs are replication and 
> backup Replication has the use-case for "tail"'ing the WAL which we 
> should provide via our new API. B doesn't do anything fancy (IIRC). We 
> should make sure all consumers are generally going to be OK with the API we 
> create.
> The API may be "OK" (or OK in a part). We need to also consider other methods 
> which were "bolted" on such as {{AbstractFSWAL}} and 
> {{WALFileLengthProvider}}. Other corners of "WAL use" (like the 
> {{WALSplitter}} should also be looked at to use WAL-APIs only).
> We also need to make sure that adequate interface audience and stability 
> annotations are chosen.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] anoopsjohn merged pull request #1241: HBASE-23788 ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking

2020-03-05 Thread GitBox
anoopsjohn merged pull request #1241: HBASE-23788 ROW_INDEX_V1 encoder should 
consider the secondary index size with the encoded data size tracking
URL: https://github.com/apache/hbase/pull/1241
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1173: HBASE-23851 Log networks and bind addresses when multicast publisher/…

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1173: HBASE-23851 Log networks and bind 
addresses when multicast publisher/…
URL: https://github.com/apache/hbase/pull/1173#issuecomment-595502029
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 43s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 27s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 16s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 20s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m  2s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 48s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 48s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 16s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  6s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  |   2m  2s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |  62m 20s |  hbase-server in the patch passed.  
|
   |  |   |  95m 33s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1173 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 848786c4184b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 797a13436c |
   | Default Java | 1.8.0_232 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/testReport/
 |
   | Max. process+thread count | 8104 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1241: HBASE-23788 ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1241: HBASE-23788 ROW_INDEX_V1 encoder should 
consider the secondary index size with the encoded data size tracking
URL: https://github.com/apache/hbase/pull/1241#issuecomment-595499004
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m 18s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
1 new or modified test files.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 38s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 19s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 35s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 17s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  branch-2 passed  |
   | +0 :ok: |  spotbugs  |   3m 17s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   4m  3s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 56s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 23s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 23s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 24s |  The patch passed checkstyle 
in hbase-common  |
   | +1 :green_heart: |  checkstyle  |   1m 10s |  hbase-server: The patch 
generated 0 new + 15 unchanged - 1 fixed = 15 total (was 16)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   4m 16s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 36s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   4m 38s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  8s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  |  62m 19s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  asflicense  |   1m  4s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 125m 30s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1241/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1241 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 758b210b34fb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1241/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 4717eecd5b |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1241/1/testReport/
 |
   | Max. process+thread count | 7375 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1241/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1173: HBASE-23851 Log networks and bind addresses when multicast publisher/…

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1173: HBASE-23851 Log networks and bind 
addresses when multicast publisher/…
URL: https://github.com/apache/hbase/pull/1173#issuecomment-595488866
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 22s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   2m 10s |  branch-2 passed  |
   | +0 :ok: |  spotbugs  |   2m 58s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   4m 39s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 57s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 34s |  hbase-client: The patch 
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | -0 :warning: |  checkstyle  |   1m 10s |  hbase-server: The patch 
generated 1 new + 104 unchanged - 0 fixed = 105 total (was 104)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 49s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  findbugs  |   4m 58s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 38s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  48m 47s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1173 |
   | Optional Tests | dupname asflicense spotbugs findbugs hadoopcheck 
hbaseanti checkstyle |
   | uname | Linux 886f482a1e94 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 797a13436c |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 93 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1173: HBASE-23851 Log networks and bind addresses when multicast publisher/…

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1173: HBASE-23851 Log networks and bind 
addresses when multicast publisher/…
URL: https://github.com/apache/hbase/pull/1173#issuecomment-595488000
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 15s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   7m 25s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   2m 16s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 14s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 31s |  hbase-client in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 18s |  hbase-common in branch-2 failed.  |
   | -0 :warning: |  javadoc  |   0m 45s |  hbase-server in branch-2 failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   7m  9s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 16s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 16s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 11s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 17s |  hbase-common in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 28s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m 40s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   1m  2s |  hbase-common in the patch failed.  |
   | +1 :green_heart: |  unit  |   2m 14s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  |   6m 49s |  hbase-server in the patch failed.  |
   |  |   |  45m 54s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1173 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 9197c75c9172 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 797a13436c |
   | Default Java | 2020-01-14 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-common.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/testReport/
 |
   | Max. process+thread count | 661 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1173/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git 

[jira] [Resolved] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk resolved HBASE-23876.
--
Resolution: Fixed

> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to nightly job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-23767) Add JDK11 compilation and unit test support to Github precommit

2020-03-05 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk resolved HBASE-23767.
--
Resolution: Fixed

> Add JDK11 compilation and unit test support to Github precommit
> ---
>
> Key: HBASE-23767
> URL: https://issues.apache.org/jira/browse/HBASE-23767
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to GitHub-based pre-commit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-23876:
-
Fix Version/s: 2.3.0

> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to nightly job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23767) Add JDK11 compilation and unit test support to Github precommit

2020-03-05 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-23767:
-
Fix Version/s: 2.3.0

> Add JDK11 compilation and unit test support to Github precommit
> ---
>
> Key: HBASE-23767
> URL: https://issues.apache.org/jira/browse/HBASE-23767
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to GitHub-based pre-commit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] ndimiduk merged pull request #1240: Back-port HBASE-23767, HBASE-23876 Jenkins JDK11 to branch-2

2020-03-05 Thread GitBox
ndimiduk merged pull request #1240: Back-port HBASE-23767, HBASE-23876 Jenkins 
JDK11 to branch-2
URL: https://github.com/apache/hbase/pull/1240
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated 
setStopRow from Scan
URL: https://github.com/apache/hbase/pull/1184#issuecomment-595463618
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 41s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
12 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 23s |  master passed  |
   | +1 :green_heart: |  compile  |   4m  2s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   3m 50s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 54s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 49s |  master passed  |
   | +0 :ok: |  spotbugs  |   1m 34s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  10m 25s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 11s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m  2s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m  2s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 32s |  The patch passed checkstyle 
in hbase-client  |
   | +1 :green_heart: |  checkstyle  |   1m 10s |  hbase-server: The patch 
generated 0 new + 18 unchanged - 2 fixed = 18 total (was 20)  |
   | +1 :green_heart: |  checkstyle  |   0m 22s |  The patch passed checkstyle 
in hbase-mapreduce  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  The patch passed checkstyle 
in hbase-thrift  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  The patch passed checkstyle 
in hbase-backup  |
   | +1 :green_heart: |  checkstyle  |   0m 19s |  hbase-it: The patch 
generated 0 new + 33 unchanged - 1 fixed = 33 total (was 34)  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  The patch passed checkstyle 
in hbase-rest  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   4m 46s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  16m 12s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   2m 48s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |  11m  8s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 56s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  |  60m 32s |  hbase-server in the patch failed.  |
   | -1 :x: |  unit  |   6m 22s |  hbase-mapreduce in the patch failed.  |
   | +1 :green_heart: |  unit  |   2m 36s |  hbase-thrift in the patch passed.  
|
   | -1 :x: |  unit  |  16m 47s |  hbase-backup in the patch failed.  |
   | +1 :green_heart: |  unit  |   1m 20s |  hbase-it in the patch passed.  |
   | -1 :x: |  unit  |   3m 14s |  hbase-rest in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   4m 36s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 185m 34s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestTableSnapshotScanner |
   |   | hadoop.hbase.replication.TestNamespaceReplicationWithBulkLoadedData |
   |   | hadoop.hbase.regionserver.TestScanner |
   |   | hadoop.hbase.rsgroup.TestEnableRSGroupsCompatibility |
   |   | hadoop.hbase.replication.master.TestRecoverStandbyProcedure |
   |   | hadoop.hbase.replication.TestPerTableCFReplication |
   |   | hadoop.hbase.replication.TestNamespaceReplication |
   |   | hadoop.hbase.filter.TestFilter |
   |   | hadoop.hbase.replication.TestReplicationDroppedTables |
   |   | hadoop.hbase.replication.TestRemoveFromSerialReplicationPeer |
   |   | 
hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL
 |
   |   | hadoop.hbase.replication.TestReplicationSyncUpTool |
   |   | hadoop.hbase.rsgroup.TestRSGroupsBalance |
   |   | hadoop.hbase.replication.TestReplicationDisableInactivePeer |
   |   | 
hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy |
   |   | hadoop.hbase.replication.regionserver.TestReplicator |
   |   | 
hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote |
   |   | hadoop.hbase.replication.TestReplicationKillMasterRS |
   

[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-03-05 Thread Josh Elser (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052541#comment-17052541
 ] 

Josh Elser commented on HBASE-23881:


{quote}I'm still digging, but I think it has to do with the semantics of 
ConnectionImplementation in 2.x versus ConnectionOverAsyncConnection in master. 
ConnectionImplementation would make a call to {{isMasterRunning}} when creating 
the Master RPC stub. This ultimately triggers the above error, trying to parse 
the response, erroring out, and retrying the RPC. That is, it's circumstantial 
that we got an _unrelated to authentication error_ which caused branch 2.x to 
execute the retry logic.
{quote}

Yup, I think this is it. If I take out the call to {{isMasterRunning(stub)}} in 
{{ConnectionImplementation}}, we fall into the {{fail()}} in the test case 
itself (just like in Master).

I'm satisfied at this point. Will take a look at the Netty RPC impl -- should 
be straightforward to test/correct now that we know what's going on 
(SaslClient.isComplete() returns true "sooner" than we expect it to for PLAIN 
mechanism).

> TestShadeSaslAuthenticationProvider failures
> 
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the 
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception, 
> expected but 
> was
>   at 
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because 
> the RPCs are also a part of connection setup. We might need to rewrite the 
> test..  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052532#comment-17052532
 ] 

Hudson commented on HBASE-23876:


Results for branch HBASE-23876/jdk11-nightly-master
[build #25 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/25/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/25//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/25//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/25//JDK8_Nightly_Build_Report_(Hadoop3)/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-23876%252Fjdk11-nightly-master/25//JDK11_Nightly_Build_Report/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to nightly job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] abhinabasarkar opened a new pull request #1241: HBASE-23788 ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking

2020-03-05 Thread GitBox
abhinabasarkar opened a new pull request #1241: HBASE-23788 ROW_INDEX_V1 
encoder should consider the secondary index size with the encoded data size 
tracking
URL: https://github.com/apache/hbase/pull/1241
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures

2020-03-05 Thread Josh Elser (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052522#comment-17052522
 ] 

Josh Elser commented on HBASE-23881:


So, I'm pretty convinced of the problem in master. I'm currently trying to 
understand if branch-2 and master are failing in the same manner. I _think_ 
that they're just different on the surface because branch-2 still defaults to 
using NIO.

The curious bit is that we can see the same semantics – the sasl client thinks 
that the handshake is done, but the client doesn't barge forward as we see in 
master:
{noformat}
2020-03-05 15:36:54,484 WARN  [RS-EventLoopGroup-1-8] 
ipc.ServerRpcConnection(377): Auth failed for  192.168.2.28:60616: Unknown
2020-03-05 15:36:54,484 TRACE [Default-IPC-NioEventLoopGroup-4-10] 
ipc.NettyRpcDuplexHandler(131): got response header , totalSize: 1 bytes
2020-03-05 15:36:54,484 TRACE [RS-EventLoopGroup-1-8] 
ipc.NettyRpcServerRequestDecoder(76): Connection /192.168.2.28:60616; caught 
unexpected downstream exception.
org.apache.hadoop.security.token.SecretManager$InvalidToken: Authentication 
failed for user1
at 
org.apache.hadoop.hbase.security.provider.example.ShadeSaslServerAuthenticationProvider$ShadeSaslServerCallbackHandler.handle(ShadeSaslServerAuthenticationProvider.java:171)
at 
org.apache.hadoop.hbase.security.provider.example.SaslPlainServer.evaluateResponse(SaslPlainServer.java:108)
at 
org.apache.hadoop.hbase.security.HBaseSaslRpcServer.evaluateResponse(HBaseSaslRpcServer.java:65)
at 
org.apache.hadoop.hbase.ipc.ServerRpcConnection.saslReadAndProcess(ServerRpcConnection.java:359)
at 
org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:87)
at 
org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:73)
at 
org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:68)
at 
org.apache.hadoop.hbase.ipc.NettyRpcServerRequestDecoder.channelRead(NettyRpcServerRequestDecoder.java:62)
...
2020-03-05 15:36:54,485 TRACE [RS-EventLoopGroup-1-8] 
ipc.NettyRpcServerRequestDecoder(68): Disconnection /192.168.2.28:60616; # 
active connections=2
2020-03-05 15:36:54,486 INFO  [Default-IPC-NioEventLoopGroup-4-10] 
ipc.NettyRpcDuplexHandler(220): exceptionCaught 
org.apache.hbase.thirdparty.com.google.protobuf.UninitializedMessageException: 
Message missing required fields: is_master_running, {}
2020-03-05 15:36:54,488 INFO  [Default-IPC-NioEventLoopGroup-4-10] 
ipc.NettyRpcDuplexHandler(210): channelInactive 
ChannelHandlerContext(NettyRpcDuplexHandler#0, [id: 0x7e79684c, 
L:/192.168.2.28:60616 ! R:mizar.local/192.168.2.28:60555]), {}
{noformat}
I'm still digging, but I think it has to do with the semantics of 
ConnectionImplementation in 2.x versus ConnectionOverAsyncConnection in master. 
ConnectionImplementation would make a call to {{isMasterRunning}} when creating 
the Master RPC stub. This ultimately triggers the above error, trying to parse 
the response, erroring out, and retrying the RPC. That is, it's circumstantial 
that we got an _unrelated to authentication error_ which caused branch 2.x to 
execute the retry logic.

> TestShadeSaslAuthenticationProvider failures
> 
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the 
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception, 
> expected but 
> was
>   at 
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because 
> the RPCs are also a part of connection setup. We might need to rewrite the 
> test..  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 Jenkins JDK11 to branch-2

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 
Jenkins JDK11 to branch-2
URL: https://github.com/apache/hbase/pull/1240#issuecomment-595429200
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 52s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  8s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   2m 53s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1240 |
   | Optional Tests |  |
   | uname | Linux a446b1c46683 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4717eecd5b |
   | Max. process+thread count | 54 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 Jenkins JDK11 to branch-2

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 
Jenkins JDK11 to branch-2
URL: https://github.com/apache/hbase/pull/1240#issuecomment-595428312
 
 
   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/console 
in case of problems.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 Jenkins JDK11 to branch-2

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 
Jenkins JDK11 to branch-2
URL: https://github.com/apache/hbase/pull/1240#issuecomment-595428280
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 44s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   2m 50s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1240 |
   | Optional Tests |  |
   | uname | Linux 9a285dd43669 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4717eecd5b |
   | Max. process+thread count | 41 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 Jenkins JDK11 to branch-2

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 
Jenkins JDK11 to branch-2
URL: https://github.com/apache/hbase/pull/1240#issuecomment-595427513
 
 
   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/console 
in case of problems.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 Jenkins JDK11 to branch-2

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 
Jenkins JDK11 to branch-2
URL: https://github.com/apache/hbase/pull/1240#issuecomment-595426834
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  hadolint  |   0m  2s |  The patch generated 0 new + 0 
unchanged - 4 fixed = 0 total (was 4)  |
   | +1 :green_heart: |  shellcheck  |   0m  3s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 21s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   4m 26s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1240 |
   | Optional Tests | dupname asflicense hadolint shellcheck shelldocs |
   | uname | Linux 6d8e9b81d893 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4717eecd5b |
   | Max. process+thread count | 46 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 
hadolint=1.17.5-0-g443423c |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 Jenkins JDK11 to branch-2

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1240: Back-port HBASE-23767, HBASE-23876 
Jenkins JDK11 to branch-2
URL: https://github.com/apache/hbase/pull/1240#issuecomment-595425375
 
 
   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1240/1/console 
in case of problems.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1214: Demo PR for YETUS-943

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1214: Demo PR for YETUS-943
URL: https://github.com/apache/hbase/pull/1214#issuecomment-595424360
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m 25s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m 21s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 13s |  master passed with JDK 
AdoptOpenJDK-11.0.6+10  |
   | +1 :green_heart: |  compile  |   3m 26s |  master passed with JDK 
AdoptOpenJDK-1.8.0_232-b09  |
   | +1 :green_heart: |  shadedjars  |   5m 28s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | -1 :x: |  javadoc  |   0m 21s |  root in master failed with JDK 
AdoptOpenJDK-11.0.6+10.  |
   | +1 :green_heart: |  javadoc  |   2m 55s |  master passed with JDK 
AdoptOpenJDK-1.8.0_232-b09  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 41s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 15s |  the patch passed with JDK 
AdoptOpenJDK-11.0.6+10  |
   | +1 :green_heart: |  javac  |   4m 15s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 31s |  the patch passed with JDK 
AdoptOpenJDK-1.8.0_232-b09  |
   | +1 :green_heart: |  javac  |   3m 31s |  the patch passed  |
   | +1 :green_heart: |  hadolint  |   0m  2s |  The patch generated 0 new + 0 
unchanged - 4 fixed = 0 total (was 4)  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  shadedjars  |   5m 16s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  18m 37s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | -1 :x: |  javadoc  |   0m 20s |  root in the patch failed with JDK 
AdoptOpenJDK-11.0.6+10.  |
   | +1 :green_heart: |  javadoc  |   2m 56s |  the patch passed with JDK 
AdoptOpenJDK-1.8.0_232-b09  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 154m 58s |  root in the patch passed with JDK 
AdoptOpenJDK-1.8.0_232-b09.  |
   | +1 :green_heart: |  asflicense  |   0m 58s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 231m  9s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | JDK AdoptOpenJDK-11.0.6+10 Failed junit tests | 
hadoop.hbase.util.TestFutureUtils |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1214/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1214 |
   | Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac 
javadoc unit shadedjars hadoopcheck xml compile |
   | uname | Linux 8d4682083d90 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1214/out/precommit/personality/provided.sh
 |
   | git revision | master / 9bd39786df |
   | Default Java | AdoptOpenJDK-1.8.0_232-b09 |
   | Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:AdoptOpenJDK-11.0.6+10 
/usr/lib/jvm/jdk8u232-b09:AdoptOpenJDK-1.8.0_232-b09 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1214/2/artifact/out/branch-javadoc-root-jdkAdoptOpenJDK-11.0.6+10.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1214/2/artifact/out/patch-javadoc-root-jdkAdoptOpenJDK-11.0.6+10.txt
 |
   | JDK AdoptOpenJDK-1.8.0_232-b09  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1214/2/testReport/
 |
   | Max. process+thread count | 6573 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1214/2/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 
hadolint=1.17.5-0-g443423c |
   | Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


[GitHub] [hbase] Apache-HBase commented on issue #1239: HBASE-23939 Remove unused variables from HBaseSaslRpcServer

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1239: HBASE-23939 Remove unused variables from 
HBaseSaslRpcServer
URL: https://github.com/apache/hbase/pull/1239#issuecomment-595421873
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 12s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m  7s |  master passed  |
   | +1 :green_heart: |  compile  |   1m  3s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 16s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 12s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 37s |  master passed  |
   | +0 :ok: |  spotbugs  |   5m 44s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 40s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 35s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  1s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  1s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 18s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   5m 15s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  17m 44s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 51s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |  99m 21s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  asflicense  |   0m 27s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 165m 13s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1239/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1239 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux c4431e8a2e06 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1239/out/precommit/personality/provided.sh
 |
   | git revision | master / 9bd39786df |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1239/1/testReport/
 |
   | Max. process+thread count | 7359 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1239/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] ndimiduk opened a new pull request #1240: Back-port HBASE-23767, HBASE-23876 Jenkins JDK11 to branch-2

2020-03-05 Thread GitBox
ndimiduk opened a new pull request #1240: Back-port HBASE-23767, HBASE-23876 
Jenkins JDK11 to branch-2
URL: https://github.com/apache/hbase/pull/1240
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-23876) Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-23876:
-
Fix Version/s: 3.0.0

> Add JDK11 compilation and unit test support to nightly job
> --
>
> Key: HBASE-23876
> URL: https://issues.apache.org/jira/browse/HBASE-23876
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to nightly job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23767) Add JDK11 compilation and unit test support to Github precommit

2020-03-05 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-23767:
-
Fix Version/s: 3.0.0

> Add JDK11 compilation and unit test support to Github precommit
> ---
>
> Key: HBASE-23767
> URL: https://issues.apache.org/jira/browse/HBASE-23767
> Project: HBase
>  Issue Type: Sub-task
>  Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0
>
>
> We already test against multiple JDK versions in a handful of places. Let's 
> get JDK11 added to the mix. Applies to GitHub-based pre-commit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] ndimiduk closed pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit

2020-03-05 Thread GitBox
ndimiduk closed pull request #1183: HBASE-23767 Add JDK11 compilation and unit 
test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] ndimiduk merged pull request #1195: HBASE-23876 Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread GitBox
ndimiduk merged pull request #1195: HBASE-23876 Add JDK11 compilation and unit 
test support to nightly job
URL: https://github.com/apache/hbase/pull/1195
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-23942) [Jenkins Nightly] shelldocs executable unavailable within docker context

2020-03-05 Thread Sean Busbey (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052455#comment-17052455
 ] 

Sean Busbey commented on HBASE-23942:
-

precommit docker support doesn't mount the entire yetus assembly AFAIK. I 
believe the assumption is that you would either mount those bits beyond 
precommit that you want yourself or you would include them in your docker image.

> [Jenkins Nightly] shelldocs executable unavailable within docker context
> 
>
> Key: HBASE-23942
> URL: https://issues.apache.org/jira/browse/HBASE-23942
> Project: HBase
>  Issue Type: Test
>  Components: build
>Affects Versions: 3.0.0
>Reporter: Nick Dimiduk
>Priority: Minor
>
> I'm not sure if this is an HBase build bug or a Yetus bug. Looking more 
> closely at the yetus output, I noticed this in the general check section on 
> [nightlies/master|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1654/pipeline/96].
> {noformat}
> [2020-03-05T14:56:51.559Z] executable 
> '/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/yetus-0.11.1/bin/shelldocs'
>  for 'shelldocs' does not exist.
> {noformat}
> Of course the executable is available in the yetus distro unpacked into the 
> workspace. However, we're running in the docker context, and apparently the 
> yetus runtime does not make itself available to the running container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23942) [Jenkins Nightly] shelldocs executable unavailable within docker context

2020-03-05 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052452#comment-17052452
 ] 

Nick Dimiduk commented on HBASE-23942:
--

Or maybe this is a bug local to the shelldoc module in yetus? The 
{{shellcheck}} plugin seems to manage this scenario (not having Yetus mounted 
inside the docker container) just fine – it's able to work with scripts from 
the host environment.
{noformat}
[2020-03-05T15:40:23.561Z] 

[2020-03-05T15:40:23.561Z] 

[2020-03-05T15:40:23.561Z]   shellcheck plugin: full
[2020-03-05T15:40:23.561Z] 

[2020-03-05T15:40:23.561Z] 

[2020-03-05T15:40:23.561Z] 
[2020-03-05T15:40:23.561Z] 
[2020-03-05T15:40:23.561Z] Running shellcheck against all suspected shell 
scripts
[2020-03-05T15:40:23.561Z] 
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh:
 line 108: warning: command substitution: ignored null byte in input
[2020-03-05T15:40:23.561Z] 
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh:
 line 108: warning: command substitution: ignored null byte in input
[2020-03-05T15:40:23.561Z] 
/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/output-general/precommit/test-patch.d/shellcheck.sh:
 line 108: warning: command substitution: ignored null byte in input
{noformat}

> [Jenkins Nightly] shelldocs executable unavailable within docker context
> 
>
> Key: HBASE-23942
> URL: https://issues.apache.org/jira/browse/HBASE-23942
> Project: HBase
>  Issue Type: Test
>  Components: build
>Affects Versions: 3.0.0
>Reporter: Nick Dimiduk
>Priority: Minor
>
> I'm not sure if this is an HBase build bug or a Yetus bug. Looking more 
> closely at the yetus output, I noticed this in the general check section on 
> [nightlies/master|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1654/pipeline/96].
> {noformat}
> [2020-03-05T14:56:51.559Z] executable 
> '/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/yetus-0.11.1/bin/shelldocs'
>  for 'shelldocs' does not exist.
> {noformat}
> Of course the executable is available in the yetus distro unpacked into the 
> workspace. However, we're running in the docker context, and apparently the 
> yetus runtime does not make itself available to the running container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-23943) Rubocop configuration needs updated

2020-03-05 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-23943:


 Summary: Rubocop configuration needs updated
 Key: HBASE-23943
 URL: https://issues.apache.org/jira/browse/HBASE-23943
 Project: HBase
  Issue Type: Test
  Components: build
Affects Versions: 3.0.0
Reporter: Nick Dimiduk


Looking at the general check output on 
[nightly/master|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1654/pipeline/96/],
 it looks like our {{.rubocop.yaml}} configuration file has drifted from the 
syntax expected by our current version of the tool. Lots of errors like the 
following:

{noformat}
[2020-03-05T15:36:27.538Z] Running rubocop against identified ruby scripts.
[2020-03-05T15:36:27.538Z] .rubocop.yml: Metrics/LineLength has the wrong 
namespace - should be Layout
[2020-03-05T15:36:27.538Z] Error: The `Layout/IndentHeredoc` cop has been 
renamed to `Layout/HeredocIndentation`.
[2020-03-05T15:36:27.538Z] (obsolete configuration found in .rubocop.yml, 
please update it)
[2020-03-05T15:36:27.538Z] .rubocop.yml: Metrics/LineLength has the wrong 
namespace - should be Layout
[2020-03-05T15:36:27.538Z] Error: The `Layout/IndentHeredoc` cop has been 
renamed to `Layout/HeredocIndentation`.
[2020-03-05T15:36:27.538Z] (obsolete configuration found in .rubocop.yml, 
please update it)
...
{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23942) [Jenkins Nightly] shelldocs executable unavailable within docker context

2020-03-05 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052446#comment-17052446
 ] 

Nick Dimiduk commented on HBASE-23942:
--

I can imagine a handful of ways to address this within HBase's builds: cooking 
up additional docker steps or passing parameters to mount the local yetus path 
as a container volume. Neither of which I find palatable. Maybe we're just 
using Yetus wrong? Or is this a bug in Yetus's docker mode?

cc [~busbey], [~aw].

> [Jenkins Nightly] shelldocs executable unavailable within docker context
> 
>
> Key: HBASE-23942
> URL: https://issues.apache.org/jira/browse/HBASE-23942
> Project: HBase
>  Issue Type: Test
>  Components: build
>Affects Versions: 3.0.0
>Reporter: Nick Dimiduk
>Priority: Minor
>
> I'm not sure if this is an HBase build bug or a Yetus bug. Looking more 
> closely at the yetus output, I noticed this in the general check section on 
> [nightlies/master|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1654/pipeline/96].
> {noformat}
> [2020-03-05T14:56:51.559Z] executable 
> '/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/yetus-0.11.1/bin/shelldocs'
>  for 'shelldocs' does not exist.
> {noformat}
> Of course the executable is available in the yetus distro unpacked into the 
> workspace. However, we're running in the docker context, and apparently the 
> yetus runtime does not make itself available to the running container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-23942) [Jenkins Nightly] shelldocs executable unavailable within docker context

2020-03-05 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-23942:


 Summary: [Jenkins Nightly] shelldocs executable unavailable within 
docker context
 Key: HBASE-23942
 URL: https://issues.apache.org/jira/browse/HBASE-23942
 Project: HBase
  Issue Type: Test
  Components: build
Affects Versions: 3.0.0
Reporter: Nick Dimiduk


I'm not sure if this is an HBase build bug or a Yetus bug. Looking more closely 
at the yetus output, I noticed this in the general check section on 
[nightlies/master|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1654/pipeline/96].

{noformat}
[2020-03-05T14:56:51.559Z] executable 
'/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/yetus-0.11.1/bin/shelldocs'
 for 'shelldocs' does not exist.
{noformat}

Of course the executable is available in the yetus distro unpacked into the 
workspace. However, we're running in the docker context, and apparently the 
yetus runtime does not make itself available to the running container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on issue #1237: Demo PR for YETUS-943

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1237: Demo PR for YETUS-943
URL: https://github.com/apache/hbase/pull/1237#issuecomment-595399980
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m 14s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 59s |  master passed with JDK 
v2020-01-14  |
   | +1 :green_heart: |  compile  |   3m 22s |  master passed with JDK 
v1.8.0_232  |
   | +1 :green_heart: |  shadedjars  |   4m 57s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | -1 :x: |  javadoc  |   0m 22s |  root in master failed with JDK 
v2020-01-14.  |
   | +1 :green_heart: |  javadoc  |   2m 54s |  master passed with JDK 
v1.8.0_232  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 38s |  the patch passed with JDK 
v2020-01-14  |
   | +1 :green_heart: |  javac  |   3m 38s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  7s |  the patch passed with JDK 
v1.8.0_232  |
   | +1 :green_heart: |  javac  |   3m  7s |  the patch passed  |
   | +1 :green_heart: |  hadolint  |   0m  3s |  The patch generated 0 new + 0 
unchanged - 4 fixed = 0 total (was 4)  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  shadedjars  |   5m  1s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  17m 38s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | -1 :x: |  javadoc  |   0m 20s |  root in the patch failed with JDK 
v2020-01-14.  |
   | +1 :green_heart: |  javadoc  |   2m 54s |  the patch passed with JDK 
v1.8.0_232  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 107m 47s |  root in the patch failed with JDK 
v1.8.0_232.  |
   | +1 :green_heart: |  asflicense  |   0m 40s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 178m 14s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | JDK v2020-01-14 Failed junit tests | hadoop.hbase.util.TestFutureUtils |
   | JDK v1.8.0_232 Failed junit tests | 
hadoop.hbase.backup.TestIncrementalBackup |
   |   | hadoop.hbase.backup.TestBackupDescribe |
   |   | hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1237/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1237 |
   | Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac 
javadoc unit shadedjars hadoopcheck xml compile |
   | uname | Linux a3739896b385 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1237/out/precommit/personality/provided.sh
 |
   | git revision | master / 9bd39786df |
   | Default Java | 1.8.0_232 |
   | Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:2020-01-14 
/usr/lib/jvm/jdk8u232-b09:1.8.0_232 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1237/1/artifact/out/branch-javadoc-root-jdk2020-01-14.txt
 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1237/1/artifact/out/patch-javadoc-root-jdk2020-01-14.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1237/1/artifact/out/patch-unit-root-jdk1.8.0_232.txt
 |
   | JDK v1.8.0_232  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1237/1/testReport/
 |
   | Max. process+thread count | 9824 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1237/1/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 
hadolint=1.17.5-0-g443423c |
   | Powered by | Apache Yetus 0.11.1 

[jira] [Resolved] (HBASE-19168) Considering Java 10

2020-03-05 Thread Mike Drob (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-19168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob resolved HBASE-19168.
---
Fix Version/s: (was: 3.0.0)
   Resolution: Won't Fix

> Considering Java 10
> ---
>
> Key: HBASE-19168
> URL: https://issues.apache.org/jira/browse/HBASE-19168
> Project: HBase
>  Issue Type: New Feature
>  Components: dependencies, java
>Reporter: Mike Drob
>Priority: Critical
>
> JDK 10 Early Access builds are now available at: - jdk.java.net/10/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HBASE-19256) [hbase-thirdparty] shade jetty

2020-03-05 Thread Mike Drob (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-19256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Drob reassigned HBASE-19256:
-

Assignee: (was: Mike Drob)

> [hbase-thirdparty] shade jetty
> --
>
> Key: HBASE-19256
> URL: https://issues.apache.org/jira/browse/HBASE-19256
> Project: HBase
>  Issue Type: Task
>  Components: dependencies, thirdparty
>Reporter: Mike Drob
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and 
unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#issuecomment-595381220
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m 47s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  hadolint  |   0m  2s |  The patch generated 0 new + 0 
unchanged - 4 fixed = 0 total (was 4)  |
   | +1 :green_heart: |  shellcheck  |   0m  3s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 23s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   4m 50s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1195 |
   | Optional Tests | dupname asflicense hadolint shellcheck shelldocs |
   | uname | Linux 6e9b5efb5c34 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / aff0ff5d97 |
   | Max. process+thread count | 51 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 
hadolint=1.17.5-0-g443423c |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and 
unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#issuecomment-595380905
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   3m 12s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   4m 17s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1195 |
   | Optional Tests |  |
   | uname | Linux c14b7c27aaf6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / aff0ff5d97 |
   | Max. process+thread count | 52 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and 
unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#issuecomment-595380223
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 37s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   2m 43s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1195 |
   | Optional Tests |  |
   | uname | Linux a8ad6875fa65 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / aff0ff5d97 |
   | Max. process+thread count | 46 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/console |
   | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and 
unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#issuecomment-595379517
 
 
   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/console 
in case of problems.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and 
unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#issuecomment-595379402
 
 
   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/console 
in case of problems.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1195: HBASE-23876 Add JDK11 compilation and 
unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#issuecomment-595379385
 
 
   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1195/11/console 
in case of problems.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] ndimiduk commented on a change in pull request #1195: HBASE-23876 Add JDK11 compilation and unit test support to nightly job

2020-03-05 Thread GitBox
ndimiduk commented on a change in pull request #1195: HBASE-23876 Add JDK11 
compilation and unit test support to nightly job
URL: https://github.com/apache/hbase/pull/1195#discussion_r388467877
 
 

 ##
 File path: dev-support/Jenkinsfile
 ##
 @@ -49,6 +50,8 @@ pipeline {
 // These tests currently have known failures. Once they burn down to 0, 
remove from here so that new problems will cause a failure.
 TESTS_FILTER = 
'cc,checkstyle,javac,javadoc,pylint,shellcheck,whitespace,perlcritic,ruby-lint,rubocop,mvnsite'
 EXCLUDE_TESTS_URL = 
"${JENKINS_URL}/job/HBase-Find-Flaky-Tests/job/${BRANCH_NAME}/lastSuccessfulBuild/artifact/excludes"
+SHALLOW_CHECKS = 'all,-unit,-findbugs' // run by the 'yetus general check'
 
 Review comment:
   Oh, I see. Thanks for the pointer.
   
   Reading through the nightly code again, I'm back to believing that I'll 
break branch-1. Let me add back JDK7 to the docker file as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22978) Online slow response log

2020-03-05 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-22978:
-
Release Note: 
get_slowlog_responses and clear_slowlog_responses are used to retrieve and 
clear slow RPC logs from RingBuffer maintained by RegionServers.

New Admin APIs:
1.   List getSlowLogResponses(final Set serverNames,
  final SlowLogQueryFilter slowLogQueryFilter) throws IOException;

2.   List clearSlowLogResponses(final Set serverNames)
  throws IOException;

Configs:

1. hbase.regionserver.slowlog.ringbuffer.size:
Default size of ringbuffer to be maintained by each RegionServer in order to 
store online slowlog responses. This is an in-memory ring buffer of requests 
that were judged to be too slow in addition to the responseTooSlow logging. The 
in-memory representation would be complete. For more details, please look into 
Doc Section: Get Slow Response Log from shell

Default
256

2. hbase.regionserver.slowlog.buffer.enabled:
Indicates whether RegionServers have ring buffer running for storing Online 
Slow logs in FIFO manner with limited entries. The size of the ring buffer is 
indicated by config: hbase.regionserver.slowlog.ringbuffer.size The default 
value is false, turn this on and get latest slowlog responses with complete 
data.

Default
false


For more details, please look into "Get Slow Response Log from shell" section 
from HBase book.

  Resolution: Fixed
  Status: Resolved  (was: Patch Available)

> Online slow response log
> 
>
> Key: HBASE-22978
> URL: https://issues.apache.org/jira/browse/HBASE-22978
> Project: HBase
>  Issue Type: New Feature
>  Components: Admin, Operability, regionserver, shell
>Affects Versions: 3.0.0, 2.3.0, 1.5.1
>Reporter: Andrew Kyle Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Screen Shot 2019-10-19 at 2.31.59 AM.png, Screen Shot 
> 2019-10-19 at 2.32.54 AM.png, Screen Shot 2019-10-19 at 2.34.11 AM.png, 
> Screen Shot 2019-10-19 at 2.36.14 AM.png
>
>
> Today when an individual RPC exceeds a configurable time bound we log a 
> complaint by way of the logging subsystem. These log lines look like:
> {noformat}
> 2019-08-30 22:10:36,195 WARN [,queue=15,port=60020] ipc.RpcServer - 
> (responseTooSlow):
> {"call":"Scan(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1567203007549,
> "responsesize":6819737,
> "method":"Scan",
> "param":"region { type: REGION_NAME value: 
> \"tsdb,\\000\\000\\215\\f)o\\024\\302\\220\\000\\000\\000\\000\\000\\001\\000\\000\\000\\000\\000\\006\\000\\000\\000\\000\\000\\005\\000\\000",
> "processingtimems":28646,
> "client":"10.253.196.215:41116",
> "queuetimems":22453,
> "class":"HRegionServer"}
> {noformat}
> Unfortunately we often truncate the request parameters, like in the above 
> example. We do this because the human readable representation is verbose, the 
> rate of too slow warnings may be high, and the combination of these things 
> can overwhelm the log capture system. The truncation is unfortunate because 
> it eliminates much of the utility of the warnings. For example, the region 
> name, the start and end keys, and the filter hierarchy are all important 
> clues for debugging performance problems caused by moderate to low 
> selectivity queries or queries made at a high rate.
> We can maintain an in-memory ring buffer of requests that were judged to be 
> too slow in addition to the responseTooSlow logging. The in-memory 
> representation can be complete and compressed. A new admin API and shell 
> command can provide access to the ring buffer for online performance 
> debugging. A modest sizing of the ring buffer will prevent excessive memory 
> utilization for a minor performance debugging feature by limiting the total 
> number of retained records. There is some chance a high rate of requests will 
> cause information on other interesting requests to be overwritten before it 
> can be read. This is the nature of a ring buffer and an acceptable trade off.
> The write request types do not require us to retain all information submitted 
> in the request. We don't need to retain all key-values in the mutation, which 
> may be too large to comfortably retain. We only need a unique set of row 
> keys, or even a min/max range, and total counts.
> The consumers of this information will be debugging tools. We can afford to 
> apply fast compression to ring buffer entries (if codec support is 
> available), something like snappy or zstandard, and decompress on the fly 
> when servicing the retrieval API request. This will minimize the impact of 
> retaining more information about slow requests than we do today.
> This proposal is for retention of request information only, 

[jira] [Updated] (HBASE-23936) Thrift support for get and clear slow_log APIs

2020-03-05 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-23936:
-
Affects Version/s: 1.7.0
   2.3.0
   3.0.0

> Thrift support for get and clear slow_log APIs
> --
>
> Key: HBASE-23936
> URL: https://issues.apache.org/jira/browse/HBASE-23936
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
>
> Provide thrift support for get_slowlog_responses() and 
> clear_slowlog_responses() Admin APIs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23941) get_slowlog_responses filters with AND/OR operator support

2020-03-05 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-23941:
-
Affects Version/s: 1.7.0
   2.3.0
   3.0.0

> get_slowlog_responses filters with AND/OR operator support
> --
>
> Key: HBASE-23941
> URL: https://issues.apache.org/jira/browse/HBASE-23941
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
>
> As of now, get_slowlog_responses support filters for various fields but tries 
> to match either of multiple filters i.e. default operator is "OR". We can 
> support user provided "AND" operator so that only entries that match all the 
> filters can be returned as result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-23941) get_slowlog_responses filters with AND/OR operator support

2020-03-05 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-23941:


 Summary: get_slowlog_responses filters with AND/OR operator support
 Key: HBASE-23941
 URL: https://issues.apache.org/jira/browse/HBASE-23941
 Project: HBase
  Issue Type: Sub-task
Reporter: Viraj Jasani
Assignee: Viraj Jasani


As of now, get_slowlog_responses support filters for various fields but tries 
to match either of multiple filters i.e. default operator is "OR". We can 
support user provided "AND" operator so that only entries that match all the 
filters can be returned as result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-23198) Documentation and release notes

2020-03-05 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved HBASE-23198.
-
Fix Version/s: 3.0.0
   Resolution: Fixed

> Documentation and release notes
> ---
>
> Key: HBASE-23198
> URL: https://issues.apache.org/jira/browse/HBASE-23198
> Project: HBase
>  Issue Type: Sub-task
>  Components: community, documentation, mob
>Reporter: Vladimir Rodionov
>Assignee: Sean Busbey
>Priority: Blocker
> Fix For: 3.0.0
>
>
> Document all the changes: algorithms, new configuration options, obsolete 
> configurations, upgrade procedure and possibility of downgrade.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] asfgit closed pull request #1232: HBASE-23198 Update ref guide for distributed MOB compaction.

2020-03-05 Thread GitBox
asfgit closed pull request #1232: HBASE-23198 Update ref guide for distributed 
MOB compaction.
URL: https://github.com/apache/hbase/pull/1232
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22749) Distributed MOB compactions

2020-03-05 Thread Sean Busbey (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052371#comment-17052371
 ] 

Sean Busbey commented on HBASE-22749:
-

waiting on HBASE-23198 and HBASE-23723 for backport to branches-2

> Distributed MOB compactions 
> 
>
> Key: HBASE-22749
> URL: https://issues.apache.org/jira/browse/HBASE-22749
> Project: HBase
>  Issue Type: New Feature
>  Components: mob
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22749-branch-2.2-v4.patch, 
> HBASE-22749-master-v1.patch, HBASE-22749-master-v2.patch, 
> HBASE-22749-master-v3.patch, HBASE-22749-master-v4.patch, 
> HBASE-22749_nightly_Unit_Test_Results.csv, 
> HBASE-22749_nightly_unit_test_analyzer.pdf, HBase-MOB-2.0-v3.0.pdf
>
>
> There are several  drawbacks in the original MOB 1.0  (Moderate Object 
> Storage) implementation, which can limit the adoption of the MOB feature:  
> # MOB compactions are executed in a Master as a chore, which limits 
> scalability because all I/O goes through a single HBase Master server. 
> # Yarn/Mapreduce framework is required to run MOB compactions in a scalable 
> way, but this won’t work in a stand-alone HBase cluster.
> # Two separate compactors for MOB and for regular store files and their 
> interactions can result in a data loss (see HBASE-22075)
> The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible 
> implementation, which is free of the above drawbacks and can be used as a 
> drop in replacement in existing MOB deployments. So, these are design goals 
> of a MOB 2.0:
> # Make MOB compactions scalable without relying on Yarn/Mapreduce framework
> # Provide unified compactor for both MOB and regular store files
> # Make it more robust especially w.r.t. to data losses. 
> # Simplify and reduce the overall MOB code.
> # Provide 100% compatible implementation with MOB 1.0.
> # No migration of data should be required between MOB 1.0 and MOB 2.0 - just 
> software upgrade.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-22075) Potential data loss when MOB compaction fails

2020-03-05 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-22075:

Fix Version/s: (was: 2.0.7)

> Potential data loss when MOB compaction fails
> -
>
> Key: HBASE-22075
> URL: https://issues.apache.org/jira/browse/HBASE-22075
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 2.1.0, 2.0.0, 2.0.1, 2.1.1, 2.0.2, 2.0.3, 2.1.2, 2.0.4, 
> 2.1.3
>Reporter: Vladimir Rodionov
>Priority: Critical
>  Labels: compaction, mob
> Attachments: HBASE-22075-v1.patch, HBASE-22075-v2.patch, 
> HBASE-22075.test-only.0.patch, HBASE-22075.test-only.1.patch, 
> HBASE-22075.test-only.2.patch, ReproMOBDataLoss.java
>
>
> When MOB compaction fails during last step (bulk load of a newly created 
> reference file) there is a high chance of a data loss due to partially loaded 
> reference file, cells of which refer to (now) non-existent MOB file. The 
> newly created MOB file is deleted automatically in case of a MOB compaction 
> failure, but some cells with the references to this file might be loaded to 
> HBase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-22075) Potential data loss when MOB compaction fails

2020-03-05 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved HBASE-22075.
-
Fix Version/s: (was: 2.2.5)
   (was: 2.1.10)
 Release Note: Addressed by reimplementing compaction in HBASE-22749
 Assignee: (was: Vladimir Rodionov)
   Resolution: Won't Fix

(Updated status to reflect that the issue was obviated rather than fixing a 
root cause)

> Potential data loss when MOB compaction fails
> -
>
> Key: HBASE-22075
> URL: https://issues.apache.org/jira/browse/HBASE-22075
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 2.1.0, 2.0.0, 2.0.1, 2.1.1, 2.0.2, 2.0.3, 2.1.2, 2.0.4, 
> 2.1.3
>Reporter: Vladimir Rodionov
>Priority: Critical
>  Labels: compaction, mob
> Attachments: HBASE-22075-v1.patch, HBASE-22075-v2.patch, 
> HBASE-22075.test-only.0.patch, HBASE-22075.test-only.1.patch, 
> HBASE-22075.test-only.2.patch, ReproMOBDataLoss.java
>
>
> When MOB compaction fails during last step (bulk load of a newly created 
> reference file) there is a high chance of a data loss due to partially loaded 
> reference file, cells of which refer to (now) non-existent MOB file. The 
> newly created MOB file is deleted automatically in case of a MOB compaction 
> failure, but some cells with the references to this file might be loaded to 
> HBase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-22075) Potential data loss when MOB compaction fails

2020-03-05 Thread Sean Busbey (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey reopened HBASE-22075:
-

> Potential data loss when MOB compaction fails
> -
>
> Key: HBASE-22075
> URL: https://issues.apache.org/jira/browse/HBASE-22075
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 2.1.0, 2.0.0, 2.0.1, 2.1.1, 2.0.2, 2.0.3, 2.1.2, 2.0.4, 
> 2.1.3
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Critical
>  Labels: compaction, mob
> Fix For: 2.0.7, 2.1.10, 2.2.5
>
> Attachments: HBASE-22075-v1.patch, HBASE-22075-v2.patch, 
> HBASE-22075.test-only.0.patch, HBASE-22075.test-only.1.patch, 
> HBASE-22075.test-only.2.patch, ReproMOBDataLoss.java
>
>
> When MOB compaction fails during last step (bulk load of a newly created 
> reference file) there is a high chance of a data loss due to partially loaded 
> reference file, cells of which refer to (now) non-existent MOB file. The 
> newly created MOB file is deleted automatically in case of a MOB compaction 
> failure, but some cells with the references to this file might be loaded to 
> HBase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-23363) MobCompactionChore takes a long time to complete once job

2020-03-05 Thread Vladimir Rodionov (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Rodionov resolved HBASE-23363.
---
Resolution: Won't Fix

HBASE-22749 has introduced distributed MOB compaction, which significantly 
improves performance. Distributed MOB compaction will be back-ported to 2.x 
branches soon. 

> MobCompactionChore takes a long time to complete once job
> -
>
> Key: HBASE-23363
> URL: https://issues.apache.org/jira/browse/HBASE-23363
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 2.1.1, 2.2.2
>Reporter: Bo Cui
>Priority: Major
> Attachments: image-2019-12-04-11-01-20-352.png
>
>
> mob table compcation is done in master
>  poolSize of hbase choreService is 1
>  if hbase has 1000 mob table,MobCompactionChore takes a long time to complete 
> once job, other chore need to wait
> !image-2019-12-04-11-01-20-352.png!
> {code:java}
> MobCompactionChore#chore() {
>...
>for (TableDescriptor htd : map.values()) {
>   ...
>   for (ColumnFamilyDescriptor hcd : htd.getColumnFamilies()) {
>  if hcd is mob{
> MobUtils.doMobCompaction;
>  }
>   }
>   ...
>}
>...
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-22075) Potential data loss when MOB compaction fails

2020-03-05 Thread Vladimir Rodionov (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Rodionov updated HBASE-22075:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

This is problem has been addressed in HBASE-22749.

> Potential data loss when MOB compaction fails
> -
>
> Key: HBASE-22075
> URL: https://issues.apache.org/jira/browse/HBASE-22075
> Project: HBase
>  Issue Type: Bug
>  Components: mob
>Affects Versions: 2.1.0, 2.0.0, 2.0.1, 2.1.1, 2.0.2, 2.0.3, 2.1.2, 2.0.4, 
> 2.1.3
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Critical
>  Labels: compaction, mob
> Fix For: 2.1.10, 2.2.5, 2.0.7
>
> Attachments: HBASE-22075-v1.patch, HBASE-22075-v2.patch, 
> HBASE-22075.test-only.0.patch, HBASE-22075.test-only.1.patch, 
> HBASE-22075.test-only.2.patch, ReproMOBDataLoss.java
>
>
> When MOB compaction fails during last step (bulk load of a newly created 
> reference file) there is a high chance of a data loss due to partially loaded 
> reference file, cells of which refer to (now) non-existent MOB file. The 
> newly created MOB file is deleted automatically in case of a MOB compaction 
> failure, but some cells with the references to this file might be loaded to 
> HBase. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] wchevreuil opened a new pull request #1239: HBASE-23939 Remove unused variables from HBaseSaslRpcServer

2020-03-05 Thread GitBox
wchevreuil opened a new pull request #1239: HBASE-23939 Remove unused variables 
from HBaseSaslRpcServer
URL: https://github.com/apache/hbase/pull/1239
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (HBASE-23940) Dynamically turn on RingBuffer for slow/large RPC logs

2020-03-05 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-23940:


 Summary: Dynamically turn on RingBuffer for slow/large RPC logs
 Key: HBASE-23940
 URL: https://issues.apache.org/jira/browse/HBASE-23940
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 3.0.0, 2.3.0, 1.7.0
Reporter: Viraj Jasani
Assignee: Viraj Jasani


Make hbase.regionserver.slowlog.buffer.enabled dynamically configurable and 
accordingly turn on/off RingBuffer in RegionServers to start/stop storing 
complete slow RPC logs for operator to retrieve.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-23939) Remove unused variables from HBaseSaslRpcServer

2020-03-05 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-23939:


 Summary: Remove unused variables from HBaseSaslRpcServer
 Key: HBASE-23939
 URL: https://issues.apache.org/jira/browse/HBASE-23939
 Project: HBase
  Issue Type: Improvement
Reporter: Wellington Chevreuil
Assignee: Wellington Chevreuil


On *HBaseSaslRpcServer*, there's currently an unused _Logger_ variable, as well 
as an unused _Configuration_ parameter defined on *HBaseSaslRpcServer* 
constructor. *HBaseSaslRpcServer* is IA private, and its constructor is only 
referenced by *ServerRpcConnection,* so it should be fine to change constructor 
signature to get rid of the unused parameter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #1217: HBASE-23891: Add an option to Actions to filter out meta RS

2020-03-05 Thread GitBox
BukrosSzabolcs commented on a change in pull request #1217: HBASE-23891: Add an 
option to Actions to filter out meta RS
URL: https://github.com/apache/hbase/pull/1217#discussion_r388438164
 
 

 ##
 File path: 
hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBackupRestore.java
 ##
 @@ -139,7 +139,7 @@ public void tearDown() throws IOException {
   public void setUpMonkey() throws Exception {
 Policy p = new PeriodicRandomActionPolicy(sleepTime,
   new RestartRandomRsExceptMetaAction(sleepTime));
-this.monkey = new PolicyBasedChaosMonkey(util, p);
+this.monkey = new PolicyBasedChaosMonkey(null, util, p);
 
 Review comment:
   You are right, I'll fix this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1238: HBASE-23909 : list_regions raise correct error if it is being splitte…

2020-03-05 Thread GitBox
Apache-HBase commented on issue #1238: HBASE-23909 : list_regions raise correct 
error if it is being splitte…
URL: https://github.com/apache/hbase/pull/1238#issuecomment-595343241
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 20s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m  7s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 14s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 43s |  the patch passed  |
   | +1 :green_heart: |  rubocop  |   0m  4s |  There were no new rubocop 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m 12s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   7m  2s |  hbase-shell in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 13s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  22m  7s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.7 Server=19.03.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1238/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1238 |
   | Optional Tests | dupname asflicense javac javadoc unit rubocop |
   | uname | Linux 3eec8647ff74 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1238/out/precommit/personality/provided.sh
 |
   | git revision | master / 9bd39786df |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1238/1/testReport/
 |
   | Max. process+thread count | 3437 (vs. ulimit of 1) |
   | modules | C: hbase-shell U: hbase-shell |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1238/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.80.1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (HBASE-23938) Replicate slow/large RPC calls to HDFS

2020-03-05 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-23938:


 Summary: Replicate slow/large RPC calls to HDFS
 Key: HBASE-23938
 URL: https://issues.apache.org/jira/browse/HBASE-23938
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 3.0.0, 2.3.0, 1.7.0
Reporter: Viraj Jasani
Assignee: Viraj Jasani


We should provide capability to replicate complete slow and large RPC logs to 
HDFS or create new system table in addition to Ring Buffer. This way we don't 
lose any of slow logs and operator can retrieve all the slow/large logs. 
Replicating logs to HDFS / creating new system table should be configurable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-23937) Retrieve online large RPC logs

2020-03-05 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-23937:


 Summary: Retrieve online large RPC logs
 Key: HBASE-23937
 URL: https://issues.apache.org/jira/browse/HBASE-23937
 Project: HBase
  Issue Type: Sub-task
Affects Versions: 3.0.0, 2.3.0, 1.7.0
Reporter: Viraj Jasani
Assignee: Viraj Jasani


Similar to online slow RPC response logs, we should also provide get and clear 
of large RPC logs which should be stored in the online RingBuffer. Many of slow 
response logs would also turn out to be large response logs for RegionServers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-23936) Thrift support for get and clear slow_log APIs

2020-03-05 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-23936:


 Summary: Thrift support for get and clear slow_log APIs
 Key: HBASE-23936
 URL: https://issues.apache.org/jira/browse/HBASE-23936
 Project: HBase
  Issue Type: Sub-task
Reporter: Viraj Jasani
Assignee: Viraj Jasani


Provide thrift support for get_slowlog_responses() and 
clear_slowlog_responses() Admin APIs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase-operator-tools] wchevreuil commented on issue #54: HBASE-23934 [operator tools] Add forbiddennapis plugin to pom.xml so …

2020-03-05 Thread GitBox
wchevreuil commented on issue #54: HBASE-23934 [operator tools] Add 
forbiddennapis plugin to pom.xml so …
URL: 
https://github.com/apache/hbase-operator-tools/pull/54#issuecomment-595331645
 
 
   > I'm assuming there's not an easy thing we can do to just flag the 
IA.Private annotation?
   
   Not that I'm aware of. Any ideas, @busbey ?  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22978) Online slow response log

2020-03-05 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052326#comment-17052326
 ] 

Viraj Jasani commented on HBASE-22978:
--

{quote}Pushed on master and branch-2. Did not do branch-1 because this patch is 
not in branch-1 yet?
{quote}
Thanks [~stack] for the addendum. This is yet to be backported to branch-1, 
will do it with HBASE-23935 as I want to backport a couple of more subtask 
commits together in branch-1.

> Online slow response log
> 
>
> Key: HBASE-22978
> URL: https://issues.apache.org/jira/browse/HBASE-22978
> Project: HBase
>  Issue Type: New Feature
>  Components: Admin, Operability, regionserver, shell
>Affects Versions: 3.0.0, 2.3.0, 1.5.1
>Reporter: Andrew Kyle Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0
>
> Attachments: Screen Shot 2019-10-19 at 2.31.59 AM.png, Screen Shot 
> 2019-10-19 at 2.32.54 AM.png, Screen Shot 2019-10-19 at 2.34.11 AM.png, 
> Screen Shot 2019-10-19 at 2.36.14 AM.png
>
>
> Today when an individual RPC exceeds a configurable time bound we log a 
> complaint by way of the logging subsystem. These log lines look like:
> {noformat}
> 2019-08-30 22:10:36,195 WARN [,queue=15,port=60020] ipc.RpcServer - 
> (responseTooSlow):
> {"call":"Scan(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1567203007549,
> "responsesize":6819737,
> "method":"Scan",
> "param":"region { type: REGION_NAME value: 
> \"tsdb,\\000\\000\\215\\f)o\\024\\302\\220\\000\\000\\000\\000\\000\\001\\000\\000\\000\\000\\000\\006\\000\\000\\000\\000\\000\\005\\000\\000",
> "processingtimems":28646,
> "client":"10.253.196.215:41116",
> "queuetimems":22453,
> "class":"HRegionServer"}
> {noformat}
> Unfortunately we often truncate the request parameters, like in the above 
> example. We do this because the human readable representation is verbose, the 
> rate of too slow warnings may be high, and the combination of these things 
> can overwhelm the log capture system. The truncation is unfortunate because 
> it eliminates much of the utility of the warnings. For example, the region 
> name, the start and end keys, and the filter hierarchy are all important 
> clues for debugging performance problems caused by moderate to low 
> selectivity queries or queries made at a high rate.
> We can maintain an in-memory ring buffer of requests that were judged to be 
> too slow in addition to the responseTooSlow logging. The in-memory 
> representation can be complete and compressed. A new admin API and shell 
> command can provide access to the ring buffer for online performance 
> debugging. A modest sizing of the ring buffer will prevent excessive memory 
> utilization for a minor performance debugging feature by limiting the total 
> number of retained records. There is some chance a high rate of requests will 
> cause information on other interesting requests to be overwritten before it 
> can be read. This is the nature of a ring buffer and an acceptable trade off.
> The write request types do not require us to retain all information submitted 
> in the request. We don't need to retain all key-values in the mutation, which 
> may be too large to comfortably retain. We only need a unique set of row 
> keys, or even a min/max range, and total counts.
> The consumers of this information will be debugging tools. We can afford to 
> apply fast compression to ring buffer entries (if codec support is 
> available), something like snappy or zstandard, and decompress on the fly 
> when servicing the retrieval API request. This will minimize the impact of 
> retaining more information about slow requests than we do today.
> This proposal is for retention of request information only, the same 
> information provided by responseTooSlow warnings. Total size of response 
> serialization, possibly also total cell or row counts, should be sufficient 
> to characterize the response.
> Optionally persist new entries added to the ring buffer into one or more 
> files in HDFS in a write-behind manner. If the HDFS writer blocks or falls 
> behind and we are unable to persist an entry before it is overwritten, that 
> is fine. Response too slow logging is best effort. If we can detect this make 
> a note of it in the log file. Provide a tool for parsing, dumping, filtering, 
> and pretty printing the slow logs written to HDFS. The tool and the shell can 
> share and reuse some utility classes and methods for accomplishing that. 
> —
> New shell commands:
> {{get_slow_responses [  ... ,  ] [ , \{  
> } ]}}
> Retrieve, decode, and pretty print the contents of the too slow response ring 
> buffer maintained by the given list of servers; or all servers in the cluster 
> if no list is provided. Optionally 

[jira] [Updated] (HBASE-22978) Online slow response log

2020-03-05 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated HBASE-22978:
-
Fix Version/s: (was: 1.7.0)

> Online slow response log
> 
>
> Key: HBASE-22978
> URL: https://issues.apache.org/jira/browse/HBASE-22978
> Project: HBase
>  Issue Type: New Feature
>  Components: Admin, Operability, regionserver, shell
>Affects Versions: 3.0.0, 2.3.0, 1.5.1
>Reporter: Andrew Kyle Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Screen Shot 2019-10-19 at 2.31.59 AM.png, Screen Shot 
> 2019-10-19 at 2.32.54 AM.png, Screen Shot 2019-10-19 at 2.34.11 AM.png, 
> Screen Shot 2019-10-19 at 2.36.14 AM.png
>
>
> Today when an individual RPC exceeds a configurable time bound we log a 
> complaint by way of the logging subsystem. These log lines look like:
> {noformat}
> 2019-08-30 22:10:36,195 WARN [,queue=15,port=60020] ipc.RpcServer - 
> (responseTooSlow):
> {"call":"Scan(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1567203007549,
> "responsesize":6819737,
> "method":"Scan",
> "param":"region { type: REGION_NAME value: 
> \"tsdb,\\000\\000\\215\\f)o\\024\\302\\220\\000\\000\\000\\000\\000\\001\\000\\000\\000\\000\\000\\006\\000\\000\\000\\000\\000\\005\\000\\000",
> "processingtimems":28646,
> "client":"10.253.196.215:41116",
> "queuetimems":22453,
> "class":"HRegionServer"}
> {noformat}
> Unfortunately we often truncate the request parameters, like in the above 
> example. We do this because the human readable representation is verbose, the 
> rate of too slow warnings may be high, and the combination of these things 
> can overwhelm the log capture system. The truncation is unfortunate because 
> it eliminates much of the utility of the warnings. For example, the region 
> name, the start and end keys, and the filter hierarchy are all important 
> clues for debugging performance problems caused by moderate to low 
> selectivity queries or queries made at a high rate.
> We can maintain an in-memory ring buffer of requests that were judged to be 
> too slow in addition to the responseTooSlow logging. The in-memory 
> representation can be complete and compressed. A new admin API and shell 
> command can provide access to the ring buffer for online performance 
> debugging. A modest sizing of the ring buffer will prevent excessive memory 
> utilization for a minor performance debugging feature by limiting the total 
> number of retained records. There is some chance a high rate of requests will 
> cause information on other interesting requests to be overwritten before it 
> can be read. This is the nature of a ring buffer and an acceptable trade off.
> The write request types do not require us to retain all information submitted 
> in the request. We don't need to retain all key-values in the mutation, which 
> may be too large to comfortably retain. We only need a unique set of row 
> keys, or even a min/max range, and total counts.
> The consumers of this information will be debugging tools. We can afford to 
> apply fast compression to ring buffer entries (if codec support is 
> available), something like snappy or zstandard, and decompress on the fly 
> when servicing the retrieval API request. This will minimize the impact of 
> retaining more information about slow requests than we do today.
> This proposal is for retention of request information only, the same 
> information provided by responseTooSlow warnings. Total size of response 
> serialization, possibly also total cell or row counts, should be sufficient 
> to characterize the response.
> Optionally persist new entries added to the ring buffer into one or more 
> files in HDFS in a write-behind manner. If the HDFS writer blocks or falls 
> behind and we are unable to persist an entry before it is overwritten, that 
> is fine. Response too slow logging is best effort. If we can detect this make 
> a note of it in the log file. Provide a tool for parsing, dumping, filtering, 
> and pretty printing the slow logs written to HDFS. The tool and the shell can 
> share and reuse some utility classes and methods for accomplishing that. 
> —
> New shell commands:
> {{get_slow_responses [  ... ,  ] [ , \{  
> } ]}}
> Retrieve, decode, and pretty print the contents of the too slow response ring 
> buffer maintained by the given list of servers; or all servers in the cluster 
> if no list is provided. Optionally provide a map of parameters for filtering 
> as additional argument. The TABLE filter, which expects a string containing a 
> table name, will include only entries pertaining to that table. The REGION 
> filter, which expects a string containing an encoded region name, will 
> include only entries pertaining 

  1   2   >