[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-599015485 Thanks Nick Please review the patch @ndimiduk @saintstack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
Apache9 merged pull request #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288#issuecomment-599010550 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 35s | master passed | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | spotbugs | 1m 4s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 8s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 16m 17s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 1m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 38m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1288 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 0a99b430e763 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288#issuecomment-599009740 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 34s | master passed | | +1 :green_heart: | compile | 0m 30s | master passed | | +1 :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 29s | hbase-client in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 12s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | shadedjars | 4m 58s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 59s | hbase-client in the patch passed. | | | | 27m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1288 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8bbbc9728681 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/testReport/ | | Max. process+thread count | 451 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
Apache-HBase commented on issue #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288#issuecomment-599009559 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 38s | master passed | | +1 :green_heart: | compile | 0m 28s | master passed | | +1 :green_heart: | shadedjars | 4m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 14s | the patch passed | | +1 :green_heart: | compile | 0m 25s | the patch passed | | +1 :green_heart: | javac | 0m 25s | the patch passed | | +1 :green_heart: | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 54s | hbase-client in the patch passed. | | | | 24m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1288 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7d2969c8112d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/testReport/ | | Max. process+thread count | 602 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23955) Have test runs use less resources
[
https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059172#comment-17059172
]
Duo Zhang commented on HBASE-23955:
---
https://github.com/apache/hbase/pull/1288
> Have test runs use less resources
> -
>
> Key: HBASE-23955
> URL: https://issues.apache.org/jira/browse/HBASE-23955
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Michael Stack
>Priority: Major
>
> Our tests can create thousands of threads all up in the one JVM. Using less
> means less memory, less contention, and hopefully, likelier passes.
> I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to
> see what it does as it runs (this test puts up 4 clusters with replication
> between). It peaks at 2k threads. After some configuration and using less
> HDFS, can get it down to ~800 threads and about 1/2 the memory-used.
> (HDFS is a profligate offender. DataXceivers (Server and Client), jetty
> threads, Volume threads (async disk 'worker' then another for cleanup...),
> image savers, ipc clients -- new thread per incoming connection w/o bound (or
> reuse), block responder threads, anonymous threads, and so on. Many are not
> configurable or boundable or are hard-coded; e.g. each volume gets 4 workers.
> Biggest impact was to be had by downing the count of data nodes. TODO: a
> follow-on that turns down DN counts in all tests)
> I've been using Java Flight Recorder during this study. Here is how you get a
> flight recorder for the a single test run:
> {code:java}
> MAVEN_OPTS="
> -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"
> mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData
> -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 {code}
> i.e. start recording on mvn launch, bound the size of the recording, and have
> the test run in the mvn context (DON'T fork). Useful is connecting to the
> running test at the same time from JDK Mission Control. We do the latter
> because the thread reporting screen is overwhelmed by the count of running
> threads and if you connect live, you can at least get a 'live threads' graph
> w/ count as the test progresses. Useful.
> When the test finishes, it dumps a .jfr file which can be opened in JDK MC.
> I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC
> Version 7, the non-commercial latest. Works pretty well.
> Let me put up a patch for tests that cuts down thread counts where we can.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23955) Have test runs use less resources
[
https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059170#comment-17059170
]
Michael Stack commented on HBASE-23955:
---
How about this?
{code}
diff --git
a/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java
b/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java
index 6107183dd4..7fddbbc2b1 100644
---
a/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java
+++
b/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java
@@ -55,6 +55,8 @@ public final class NettyRpcClientConfigHelper {
private static final Map>>
EVENT_LOOP_CONFIG_MAP = new HashMap<>();
+ private static Pair>
DEFAULT_EVENTLOOPGROUP;
+
/**
* Shutdown constructor.
*/
@@ -63,7 +65,7 @@ public final class NettyRpcClientConfigHelper {
/**
* Set the EventLoopGroup and channel class for {@code AsyncRpcClient}.
*/
- public static void setEventLoopConfig(Configuration conf, EventLoopGroup
group,
+ public synchronized static void setEventLoopConfig(Configuration conf,
EventLoopGroup group,
Class channelClass) {
Preconditions.checkNotNull(group, "group is null");
Preconditions.checkNotNull(channelClass, "channel class is null");
@@ -75,21 +77,22 @@ public final class NettyRpcClientConfigHelper {
/**
* The {@code AsyncRpcClient} will create its own {@code NioEventLoopGroup}.
*/
- public static void createEventLoopPerClient(Configuration conf) {
+ public synchronized static void createEventLoopPerClient(Configuration conf)
{
conf.set(EVENT_LOOP_CONFIG, "");
EVENT_LOOP_CONFIG_MAP.clear();
}
- static Pair>
getEventLoopConfig(Configuration conf) {
+ static synchronized Pair>
getEventLoopConfig(
+ Configuration conf) {
String name = conf.get(EVENT_LOOP_CONFIG);
-if (name == null) {
- int threadCount =
conf.getInt(HBASE_NETTY_EVENTLOOP_RPCCLIENT_THREADCOUNT_KEY, 0);
- return new Pair<>(new NioEventLoopGroup(threadCount,
-new DefaultThreadFactory("RPCClient-NioEventLoopGroup", true,
- Thread.NORM_PRIORITY)), NioSocketChannel.class);
-}
-if (StringUtils.isBlank(name)) {
- return null;
+if (name == null || StringUtils.isBlank(name)) {
+ if (DEFAULT_EVENTLOOPGROUP == null) {
+int threadCount =
conf.getInt(HBASE_NETTY_EVENTLOOP_RPCCLIENT_THREADCOUNT_KEY, 0);
+DEFAULT_EVENTLOOPGROUP = new Pair<>(new NioEventLoopGroup(threadCount,
+ new DefaultThreadFactory("RPCClient-NioEventLoopGroup", true,
+Thread.NORM_PRIORITY)), NioSocketChannel.class);
+ }
+ return DEFAULT_EVENTLOOPGROUP;
}
return EVENT_LOOP_CONFIG_MAP.get(name);
}
{code}
> Have test runs use less resources
> -
>
> Key: HBASE-23955
> URL: https://issues.apache.org/jira/browse/HBASE-23955
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Michael Stack
>Priority: Major
>
> Our tests can create thousands of threads all up in the one JVM. Using less
> means less memory, less contention, and hopefully, likelier passes.
> I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to
> see what it does as it runs (this test puts up 4 clusters with replication
> between). It peaks at 2k threads. After some configuration and using less
> HDFS, can get it down to ~800 threads and about 1/2 the memory-used.
> (HDFS is a profligate offender. DataXceivers (Server and Client), jetty
> threads, Volume threads (async disk 'worker' then another for cleanup...),
> image savers, ipc clients -- new thread per incoming connection w/o bound (or
> reuse), block responder threads, anonymous threads, and so on. Many are not
> configurable or boundable or are hard-coded; e.g. each volume gets 4 workers.
> Biggest impact was to be had by downing the count of data nodes. TODO: a
> follow-on that turns down DN counts in all tests)
> I've been using Java Flight Recorder during this study. Here is how you get a
> flight recorder for the a single test run:
> {code:java}
> MAVEN_OPTS="
> -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"
> mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData
> -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 {code}
> i.e. start recording on mvn launch, bound the size of the recording, and have
> the test run in the mvn context (DON'T fork). Useful is connecting to the
> running test at the same time from JDK Mission Control. We do the latter
> because the thread reporting screen is overwhelmed by the count of running
> threads and if you connect live, you can at least get a
[GitHub] [hbase] Apache9 opened a new pull request #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
Apache9 opened a new pull request #1288: HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… URL: https://github.com/apache/hbase/pull/1288 …efault which is incorrect This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23955) Have test runs use less resources
[
https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059167#comment-17059167
]
Duo Zhang commented on HBASE-23955:
---
Created HBASE-23987. Patch will be read soon.
> Have test runs use less resources
> -
>
> Key: HBASE-23955
> URL: https://issues.apache.org/jira/browse/HBASE-23955
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Michael Stack
>Priority: Major
>
> Our tests can create thousands of threads all up in the one JVM. Using less
> means less memory, less contention, and hopefully, likelier passes.
> I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to
> see what it does as it runs (this test puts up 4 clusters with replication
> between). It peaks at 2k threads. After some configuration and using less
> HDFS, can get it down to ~800 threads and about 1/2 the memory-used.
> (HDFS is a profligate offender. DataXceivers (Server and Client), jetty
> threads, Volume threads (async disk 'worker' then another for cleanup...),
> image savers, ipc clients -- new thread per incoming connection w/o bound (or
> reuse), block responder threads, anonymous threads, and so on. Many are not
> configurable or boundable or are hard-coded; e.g. each volume gets 4 workers.
> Biggest impact was to be had by downing the count of data nodes. TODO: a
> follow-on that turns down DN counts in all tests)
> I've been using Java Flight Recorder during this study. Here is how you get a
> flight recorder for the a single test run:
> {code:java}
> MAVEN_OPTS="
> -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"
> mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData
> -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 {code}
> i.e. start recording on mvn launch, bound the size of the recording, and have
> the test run in the mvn context (DON'T fork). Useful is connecting to the
> running test at the same time from JDK Mission Control. We do the latter
> because the thread reporting screen is overwhelmed by the count of running
> threads and if you connect live, you can at least get a 'live threads' graph
> w/ count as the test progresses. Useful.
> When the test finishes, it dumps a .jfr file which can be opened in JDK MC.
> I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC
> Version 7, the non-commercial latest. Works pretty well.
> Let me put up a patch for tests that cuts down thread counts where we can.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23955) Have test runs use less resources
[
https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059166#comment-17059166
]
Michael Stack commented on HBASE-23955:
---
Thanks [~zhangduo]
This bit:
- return DefaultNettyEventLoopConfig.GROUP_AND_CHANNEL_CLASS;
+ int threadCount =
conf.getInt(HBASE_NETTY_EVENTLOOP_RPCCLIENT_THREADCOUNT_KEY, 0);
+ return new Pair<>(new NioEventLoopGroup(threadCount,
+new DefaultThreadFactory("RPCClient-NioEventLoopGroup", true,
+ Thread.NORM_PRIORITY)), NioSocketChannel.class);
I removed DefaultNettyEventLoopConfig so I should keep a static EventLoopConfig
in here that I return when the name is null?
(I've not spent much time studying this operation -- thanks).
> Have test runs use less resources
> -
>
> Key: HBASE-23955
> URL: https://issues.apache.org/jira/browse/HBASE-23955
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Michael Stack
>Priority: Major
>
> Our tests can create thousands of threads all up in the one JVM. Using less
> means less memory, less contention, and hopefully, likelier passes.
> I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to
> see what it does as it runs (this test puts up 4 clusters with replication
> between). It peaks at 2k threads. After some configuration and using less
> HDFS, can get it down to ~800 threads and about 1/2 the memory-used.
> (HDFS is a profligate offender. DataXceivers (Server and Client), jetty
> threads, Volume threads (async disk 'worker' then another for cleanup...),
> image savers, ipc clients -- new thread per incoming connection w/o bound (or
> reuse), block responder threads, anonymous threads, and so on. Many are not
> configurable or boundable or are hard-coded; e.g. each volume gets 4 workers.
> Biggest impact was to be had by downing the count of data nodes. TODO: a
> follow-on that turns down DN counts in all tests)
> I've been using Java Flight Recorder during this study. Here is how you get a
> flight recorder for the a single test run:
> {code:java}
> MAVEN_OPTS="
> -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"
> mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData
> -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 {code}
> i.e. start recording on mvn launch, bound the size of the recording, and have
> the test run in the mvn context (DON'T fork). Useful is connecting to the
> running test at the same time from JDK Mission Control. We do the latter
> because the thread reporting screen is overwhelmed by the count of running
> threads and if you connect live, you can at least get a 'live threads' graph
> w/ count as the test progresses. Useful.
> When the test finishes, it dumps a .jfr file which can be opened in JDK MC.
> I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC
> Version 7, the non-commercial latest. Works pretty well.
> Let me put up a patch for tests that cuts down thread counts where we can.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23987) NettyRpcClientConfigHelper will not share event loop by default which is incorrect
[ https://issues.apache.org/jira/browse/HBASE-23987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23987 started by Duo Zhang. - > NettyRpcClientConfigHelper will not share event loop by default which is > incorrect > -- > > Key: HBASE-23987 > URL: https://issues.apache.org/jira/browse/HBASE-23987 > Project: HBase > Issue Type: Bug > Components: Client, rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23987) NettyRpcClientConfigHelper will not share event loop by default which is incorrect
Duo Zhang created HBASE-23987: - Summary: NettyRpcClientConfigHelper will not share event loop by default which is incorrect Key: HBASE-23987 URL: https://issues.apache.org/jira/browse/HBASE-23987 Project: HBase Issue Type: Bug Components: Client, rpc Reporter: Duo Zhang Assignee: Duo Zhang Fix For: 3.0.0, 2.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23955) Have test runs use less resources
[
https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-23955.
---
Resolution: Duplicate
Oh, posted on the wrong issue...
> Have test runs use less resources
> -
>
> Key: HBASE-23955
> URL: https://issues.apache.org/jira/browse/HBASE-23955
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Michael Stack
>Priority: Major
>
> Our tests can create thousands of threads all up in the one JVM. Using less
> means less memory, less contention, and hopefully, likelier passes.
> I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to
> see what it does as it runs (this test puts up 4 clusters with replication
> between). It peaks at 2k threads. After some configuration and using less
> HDFS, can get it down to ~800 threads and about 1/2 the memory-used.
> (HDFS is a profligate offender. DataXceivers (Server and Client), jetty
> threads, Volume threads (async disk 'worker' then another for cleanup...),
> image savers, ipc clients -- new thread per incoming connection w/o bound (or
> reuse), block responder threads, anonymous threads, and so on. Many are not
> configurable or boundable or are hard-coded; e.g. each volume gets 4 workers.
> Biggest impact was to be had by downing the count of data nodes. TODO: a
> follow-on that turns down DN counts in all tests)
> I've been using Java Flight Recorder during this study. Here is how you get a
> flight recorder for the a single test run:
> {code:java}
> MAVEN_OPTS="
> -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"
> mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData
> -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 {code}
> i.e. start recording on mvn launch, bound the size of the recording, and have
> the test run in the mvn context (DON'T fork). Useful is connecting to the
> running test at the same time from JDK Mission Control. We do the latter
> because the thread reporting screen is overwhelmed by the count of running
> threads and if you connect live, you can at least get a 'live threads' graph
> w/ count as the test progresses. Useful.
> When the test finishes, it dumps a .jfr file which can be opened in JDK MC.
> I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC
> Version 7, the non-commercial latest. Works pretty well.
> Let me put up a patch for tests that cuts down thread counts where we can.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23955) Have test runs use less resources
[
https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059164#comment-17059164
]
Duo Zhang commented on HBASE-23955:
---
This is easy to introduce too many open files in tests...
> Have test runs use less resources
> -
>
> Key: HBASE-23955
> URL: https://issues.apache.org/jira/browse/HBASE-23955
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Michael Stack
>Priority: Major
>
> Our tests can create thousands of threads all up in the one JVM. Using less
> means less memory, less contention, and hopefully, likelier passes.
> I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to
> see what it does as it runs (this test puts up 4 clusters with replication
> between). It peaks at 2k threads. After some configuration and using less
> HDFS, can get it down to ~800 threads and about 1/2 the memory-used.
> (HDFS is a profligate offender. DataXceivers (Server and Client), jetty
> threads, Volume threads (async disk 'worker' then another for cleanup...),
> image savers, ipc clients -- new thread per incoming connection w/o bound (or
> reuse), block responder threads, anonymous threads, and so on. Many are not
> configurable or boundable or are hard-coded; e.g. each volume gets 4 workers.
> Biggest impact was to be had by downing the count of data nodes. TODO: a
> follow-on that turns down DN counts in all tests)
> I've been using Java Flight Recorder during this study. Here is how you get a
> flight recorder for the a single test run:
> {code:java}
> MAVEN_OPTS="
> -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"
> mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData
> -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 {code}
> i.e. start recording on mvn launch, bound the size of the recording, and have
> the test run in the mvn context (DON'T fork). Useful is connecting to the
> running test at the same time from JDK Mission Control. We do the latter
> because the thread reporting screen is overwhelmed by the count of running
> threads and if you connect live, you can at least get a 'live threads' graph
> w/ count as the test progresses. Useful.
> When the test finishes, it dumps a .jfr file which can be opened in JDK MC.
> I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC
> Version 7, the non-commercial latest. Works pretty well.
> Let me put up a patch for tests that cuts down thread counts where we can.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23955) Have test runs use less resources
[
https://issues.apache.org/jira/browse/HBASE-23955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059163#comment-17059163
]
Duo Zhang commented on HBASE-23955:
---
Hi sir, the implementation of NettyRpcClientConfigHelper is wrong, the behavior
when EVENT_LOOP_CONFIG name is null in getEventLoopConfig, is to return the
default event loop, but now we will create a new one every time...
> Have test runs use less resources
> -
>
> Key: HBASE-23955
> URL: https://issues.apache.org/jira/browse/HBASE-23955
> Project: HBase
> Issue Type: Improvement
> Components: test
>Reporter: Michael Stack
>Priority: Major
>
> Our tests can create thousands of threads all up in the one JVM. Using less
> means less memory, less contention, and hopefully, likelier passes.
> I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to
> see what it does as it runs (this test puts up 4 clusters with replication
> between). It peaks at 2k threads. After some configuration and using less
> HDFS, can get it down to ~800 threads and about 1/2 the memory-used.
> (HDFS is a profligate offender. DataXceivers (Server and Client), jetty
> threads, Volume threads (async disk 'worker' then another for cleanup...),
> image savers, ipc clients -- new thread per incoming connection w/o bound (or
> reuse), block responder threads, anonymous threads, and so on. Many are not
> configurable or boundable or are hard-coded; e.g. each volume gets 4 workers.
> Biggest impact was to be had by downing the count of data nodes. TODO: a
> follow-on that turns down DN counts in all tests)
> I've been using Java Flight Recorder during this study. Here is how you get a
> flight recorder for the a single test run:
> {code:java}
> MAVEN_OPTS="
> -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"
> mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData
> -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 {code}
> i.e. start recording on mvn launch, bound the size of the recording, and have
> the test run in the mvn context (DON'T fork). Useful is connecting to the
> running test at the same time from JDK Mission Control. We do the latter
> because the thread reporting screen is overwhelmed by the count of running
> threads and if you connect live, you can at least get a 'live threads' graph
> w/ count as the test progresses. Useful.
> When the test finishes, it dumps a .jfr file which can be opened in JDK MC.
> I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC
> Version 7, the non-commercial latest. Works pretty well.
> Let me put up a patch for tests that cuts down thread counts where we can.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23967) Improve the accuracy of the method sizeToString
[
https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059161#comment-17059161
]
Hudson commented on HBASE-23967:
Results for branch branch-2.1
[build #1834 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1834/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1834//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1834//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1834//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Improve the accuracy of the method sizeToString
> ---
>
> Key: HBASE-23967
> URL: https://issues.apache.org/jira/browse/HBASE-23967
> Project: HBase
> Issue Type: Improvement
>Affects Versions: master
>Reporter: xuqinya
>Assignee: xuqinya
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.1.10, 2.2.5
>
>
> In QuotaSettings，the method of sizeToString reserved integer. But, this is
> not very accurate.
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G',
> POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNERQUOTAS
>
>
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT =>
> 1T, VIOLATION_POLICY => NO_INSERTS
>
> 1 row(s) in 0.0340 seconds
> {code}
> after patch：
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G',
> POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNERQUOTAS
>
>
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT =>
> 1.95T, VIOLATION_POLICY => NO_INSERTS
> 1 row(s) in 0.0230 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-598998996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 59s | master passed | | +1 :green_heart: | compile | 6m 39s | master passed | | +1 :green_heart: | shadedjars | 7m 55s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 37s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 34s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 36s | hbase-rest in master failed. | | -0 :warning: | javadoc | 1m 2s | hbase-server in master failed. | | -0 :warning: | javadoc | 1m 23s | hbase-thrift in master failed. | | -0 :warning: | patch | 14m 24s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 10m 0s | the patch passed | | +1 :green_heart: | compile | 6m 23s | the patch passed | | +1 :green_heart: | javac | 6m 23s | the patch passed | | +1 :green_heart: | shadedjars | 7m 50s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 58s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 31s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 1m 16s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 33s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 34s | hbase-client in the patch passed. | | -0 :warning: | unit | 87m 13s | hbase-server in the patch failed. | | -0 :warning: | unit | 9m 3s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 32s | hbase-thrift in the patch passed. | | -0 :warning: | unit | 7m 35s | hbase-shell in the patch failed. | | +1 :green_heart: | unit | 3m 2s | hbase-endpoint in the patch passed. | | +1 :green_heart: | unit | 3m 4s | hbase-rest in the patch passed. | | | | 174m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4b1e472accfd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | javadoc |
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-598996755 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 30s | master passed | | +1 :green_heart: | compile | 3m 49s | master passed | | +1 :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 43s | master passed | | -0 :warning: | patch | 8m 52s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 26s | the patch passed | | +1 :green_heart: | compile | 3m 57s | the patch passed | | +1 :green_heart: | javac | 3m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 56s | hbase-client in the patch passed. | | -1 :x: | unit | 63m 54s | hbase-server in the patch failed. | | -1 :x: | unit | 29m 36s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 45s | hbase-thrift in the patch passed. | | -1 :x: | unit | 7m 41s | hbase-shell in the patch failed. | | +1 :green_heart: | unit | 3m 36s | hbase-endpoint in the patch passed. | | +1 :green_heart: | unit | 3m 17s | hbase-rest in the patch passed. | | | | 151m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cae4b6812f6e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-mapreduce.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/testReport/ | | Max. process+thread count | 7056 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23986) Bump hadoop-two.version to 2.10.0 on master and branch-2
[ https://issues.apache.org/jira/browse/HBASE-23986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23986: -- Description: See this discussion on mailing list > Bump hadoop-two.version to 2.10.0 on master and branch-2 > > > Key: HBASE-23986 > URL: https://issues.apache.org/jira/browse/HBASE-23986 > Project: HBase > Issue Type: Task > Components: build, dependencies, hadoop2 >Reporter: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > See this discussion on mailing list -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23986) Bump hadoop-two.version to 2.10.0 on master and branch-2
[ https://issues.apache.org/jira/browse/HBASE-23986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23986: -- Description: See this discussion on mailing list https://lists.apache.org/thread.html/rbab2e79f25b38c85fe205390b3fdbc6711984881a994a499c54aee97%40%3Cdev.hbase.apache.org%3E was:See this discussion on mailing list > Bump hadoop-two.version to 2.10.0 on master and branch-2 > > > Key: HBASE-23986 > URL: https://issues.apache.org/jira/browse/HBASE-23986 > Project: HBase > Issue Type: Task > Components: build, dependencies, hadoop2 >Reporter: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > See this discussion on mailing list > https://lists.apache.org/thread.html/rbab2e79f25b38c85fe205390b3fdbc6711984881a994a499c54aee97%40%3Cdev.hbase.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23986) Bump hadoop-two.version to 2.10.0 on master and branch-2
Duo Zhang created HBASE-23986: - Summary: Bump hadoop-two.version to 2.10.0 on master and branch-2 Key: HBASE-23986 URL: https://issues.apache.org/jira/browse/HBASE-23986 Project: HBase Issue Type: Task Components: build, dependencies, hadoop2 Reporter: Duo Zhang Fix For: 3.0.0, 2.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-598994263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 26s | master passed | | +1 :green_heart: | compile | 3m 47s | master passed | | +1 :green_heart: | shadedjars | 4m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 43s | master passed | | -0 :warning: | patch | 8m 41s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | compile | 3m 42s | the patch passed | | +1 :green_heart: | javac | 3m 41s | the patch passed | | +1 :green_heart: | shadedjars | 5m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 53s | hbase-client in the patch passed. | | -1 :x: | unit | 72m 17s | hbase-server in the patch failed. | | -1 :x: | unit | 27m 21s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 3m 43s | hbase-thrift in the patch passed. | | -1 :x: | unit | 8m 16s | hbase-shell in the patch failed. | | +1 :green_heart: | unit | 4m 42s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 2m 32s | hbase-examples in the patch passed. | | | | 158m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 933bfbc02108 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-mapreduce.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/testReport/ | | Max. process+thread count | 6848 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
Apache9 commented on a change in pull request #1287: HBASE-23983 Fixed Spotbugs
complaint in RegionStates related to ignored return value
URL: https://github.com/apache/hbase/pull/1287#discussion_r392545075
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java
##
@@ -130,8 +130,7 @@ RegionStateNode createRegionStateNode(RegionInfo
regionInfo) {
synchronized (regionsMapLock) {
RegionStateNode node =
regionsMap.computeIfAbsent(regionInfo.getRegionName(),
key -> new RegionStateNode(regionInfo, regionInTransition));
- encodedRegionsMap.putIfAbsent(regionInfo.getEncodedName(), node);
- return node;
+ return encodedRegionsMap.putIfAbsent(regionInfo.getEncodedName(), node);
Review comment:
This is not correct, if there is no value yet putIfAbsent will returns
null...
And here I think we could add an assert, that putIfAbsent should always
return null, and then return the node above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23982) Shell tests broken
[
https://issues.apache.org/jira/browse/HBASE-23982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059145#comment-17059145
]
Duo Zhang commented on HBASE-23982:
---
You need to check the output to find out the real reason. I guess maybe in
shell we reference several deprecated methods which have been removed recently?
> Shell tests broken
> --
>
> Key: HBASE-23982
> URL: https://issues.apache.org/jira/browse/HBASE-23982
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Priority: Major
>
> The shell tests in the master seem to be broken. When running {{mvn clean
> install -pl hbase-shell -PrunClientTests}} it reports the following errors:
> {code}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hadoop.hbase.client.TestTableShell
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 66.561 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestTableShell
> [ERROR] org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests Time
> elapsed: 63.222 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests(TestTableShell.java:40)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> [INFO] Running org.apache.hadoop.hbase.client.TestQuotasShell
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 362.723 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestQuotasShell
> [ERROR] org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests
> Time elapsed: 360.415 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests(TestQuotasShell.java:40)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> [INFO] Running org.apache.hadoop.hbase.client.TestRSGroupShell
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.653
> s - in org.apache.hadoop.hbase.client.TestRSGroupShell
> [INFO] Running org.apache.hadoop.hbase.client.TestAdminShell
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 155.249 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAdminShell
> [ERROR] org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests Time
> elapsed: 151.904 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests(TestAdminShell.java:40)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> [INFO] Running org.apache.hadoop.hbase.client.TestShellNoCluster
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.684
> s - in org.apache.hadoop.hbase.client.TestShellNoCluster
> [INFO] Running org.apache.hadoop.hbase.client.TestReplicationShell
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 113.892 s - in org.apache.hadoop.hbase.client.TestReplicationShell
> [INFO] Running org.apache.hadoop.hbase.client.TestShell
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 35.646 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestShell
> [ERROR] org.apache.hadoop.hbase.client.TestShell.testRunShellTests Time
> elapsed: 32.328 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.TestShell.testRunShellTests(TestShell.java:40)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> [INFO] Running org.apache.hadoop.hbase.client.TestAdminShell2
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 141.174 s - in org.apache.hadoop.hbase.client.TestAdminShell2
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestAdminShell.testRunShellTests:40 » EvalFailed (RuntimeError)
> Shell unit tes...
> [ERROR] TestQuotasShell.testRunShellTests:40 » EvalFailed (RuntimeError)
> Shell unit te...
> [ERROR] TestShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell
> unit tests fa...
> [ERROR] TestTableShell.testRunShellTests:40 » EvalFailed (RuntimeError)
> Shell unit tes...
> [INFO]
> [ERROR] Tests run: 8, Failures: 0,
[GitHub] [hbase] Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#issuecomment-598992197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 40s | master passed | | +1 :green_heart: | checkstyle | 1m 8s | master passed | | -1 :x: | spotbugs | 2m 4s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 13s | the patch passed | | +1 :green_heart: | checkstyle | 1m 6s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 58s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 10s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 40m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1287 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 3d9baa318057 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-598992263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 3s | master passed | | +1 :green_heart: | compile | 4m 5s | master passed | | +1 :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 54s | master passed | | -0 :warning: | patch | 9m 25s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 47s | the patch passed | | +1 :green_heart: | compile | 4m 11s | the patch passed | | +1 :green_heart: | javac | 4m 11s | the patch passed | | +1 :green_heart: | shadedjars | 5m 19s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 57s | hbase-client in the patch passed. | | -1 :x: | unit | 100m 8s | hbase-server in the patch failed. | | -1 :x: | unit | 20m 19s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 3m 7s | hbase-thrift in the patch passed. | | -1 :x: | unit | 10m 3s | hbase-backup in the patch failed. | | +1 :green_heart: | unit | 1m 8s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 3m 26s | hbase-rest in the patch passed. | | | | 181m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1213 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 10bf5eb53ab9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-mapreduce.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/testReport/ | | Max. process+thread count | 5723 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#issuecomment-598991980 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 17s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 5m 37s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 15s | the patch passed | | +1 :green_heart: | compile | 1m 16s | the patch passed | | +1 :green_heart: | javac | 1m 16s | the patch passed | | +1 :green_heart: | shadedjars | 5m 56s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 44s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 7m 32s | hbase-server in the patch failed. | | | | 39m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1287 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux db82e2641899 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/testReport/ | | Max. process+thread count | 592 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan
Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan URL: https://github.com/apache/hbase/pull/1208#issuecomment-598991818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 31s | master passed | | +1 :green_heart: | compile | 2m 17s | master passed | | +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 21s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | | -0 :warning: | patch | 7m 8s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 4s | the patch passed | | +1 :green_heart: | compile | 3m 23s | the patch passed | | +1 :green_heart: | javac | 3m 23s | the patch passed | | +1 :green_heart: | shadedjars | 8m 6s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 1m 1s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 31s | hbase-mapreduce in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 30s | hbase-client in the patch passed. | | -0 :warning: | unit | 107m 29s | hbase-server in the patch failed. | | -0 :warning: | unit | 8m 26s | hbase-mapreduce in the patch failed. | | | | 157m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1208 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d15da6551cd0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/testReport/ | | Max. process+thread count | 6215 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log
[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-598991733 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 31s | master passed | | +1 :green_heart: | compile | 4m 20s | master passed | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 19s | hbase-backup in master failed. | | -0 :warning: | javadoc | 0m 22s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 22s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 52s | hbase-thrift in master failed. | | -0 :warning: | patch | 9m 32s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 17s | the patch passed | | +1 :green_heart: | compile | 4m 29s | the patch passed | | +1 :green_heart: | javac | 4m 29s | the patch passed | | +1 :green_heart: | shadedjars | 5m 7s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 43s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 48s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-backup in the patch failed. | | -0 :warning: | javadoc | 0m 24s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 1s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 103m 18s | hbase-server in the patch passed. | | -0 :warning: | unit | 15m 4s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 3m 33s | hbase-thrift in the patch passed. | | -0 :warning: | unit | 4m 32s | hbase-backup in the patch failed. | | +1 :green_heart: | unit | 1m 52s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 4m 33s | hbase-rest in the patch passed. | | | | 177m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1213 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ecfc671f8018 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc |
[jira] [Commented] (HBASE-23985) [flakey test] TestZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-23985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059143#comment-17059143
]
Nick Dimiduk commented on HBASE-23985:
--
Ugh, this test has a [long
history|https://issues.apache.org/jira/issues/?jql=project%20%3D%20HBASE%20AND%20summary%20~%20TestZooKeeper%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC#]
of being troublesome.
> [flakey test] TestZooKeeper
> ---
>
> Key: HBASE-23985
> URL: https://issues.apache.org/jira/browse/HBASE-23985
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Nick Dimiduk
>Priority: Major
> Attachments: TEST-org.apache.hadoop.hbase.TestZooKeeper.xml
>
>
> I observed a test failure in {{TestZooKeeper#testMasterSessionExpired}} on my
> local rig. On a casual read of the logs from {{testMasterSessionExpired}}, it
> appears we have a faulty assumption related to master MTTR; the master abort
> is logged ~1250ms after ZK session close, which seems entirely too fast to
> me. Once the master aborts, the damage is done and the test cannot recover.
> The first re-run passes. Surefire does not keep logs of successful tests, so
> I don't know the timing between events in the successful run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23985) [flakey test] TestZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-23985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059142#comment-17059142
]
Nick Dimiduk commented on HBASE-23985:
--
Attaching log file from the run.
Perhaps noteworthy, {{testMasterZKSessionRecoveryFailure}} also fails during
this run -- all three attempts failed. It's possible that there is "cross-talk"
happening between the two tests. {{testMasterSessionExpired}} runs first,
perhaps leaves some garbage state, and then
{{testMasterZKSessionRecoveryFailure}} gets no where. I haven't looked into the
latter's logs yet.
> [flakey test] TestZooKeeper
> ---
>
> Key: HBASE-23985
> URL: https://issues.apache.org/jira/browse/HBASE-23985
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Nick Dimiduk
>Priority: Major
> Attachments: TEST-org.apache.hadoop.hbase.TestZooKeeper.xml
>
>
> I observed a test failure in {{TestZooKeeper#testMasterSessionExpired}} on my
> local rig. On a casual read of the logs from {{testMasterSessionExpired}}, it
> appears we have a faulty assumption related to master MTTR; the master abort
> is logged ~1250ms after ZK session close, which seems entirely too fast to
> me. Once the master aborts, the damage is done and the test cannot recover.
> The first re-run passes. Surefire does not keep logs of successful tests, so
> I don't know the timing between events in the successful run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
Apache-HBase commented on issue #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287#issuecomment-598990829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 43s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 4m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 18s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 4m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 5m 6s | hbase-server in the patch failed. | | | | 30m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1287 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 04c751f45e49 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/testReport/ | | Max. process+thread count | 960 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1287/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23985) [flakey test] TestZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-23985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-23985:
-
Attachment: TEST-org.apache.hadoop.hbase.TestZooKeeper.xml
> [flakey test] TestZooKeeper
> ---
>
> Key: HBASE-23985
> URL: https://issues.apache.org/jira/browse/HBASE-23985
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Nick Dimiduk
>Priority: Major
> Attachments: TEST-org.apache.hadoop.hbase.TestZooKeeper.xml
>
>
> I observed a test failure in {{TestZooKeeper#testMasterSessionExpired}} on my
> local rig. On a casual read of the logs from {{testMasterSessionExpired}}, it
> appears we have a faulty assumption related to master MTTR; the master abort
> is logged ~1250ms after ZK session close, which seems entirely too fast to
> me. Once the master aborts, the damage is done and the test cannot recover.
> The first re-run passes. Surefire does not keep logs of successful tests, so
> I don't know the timing between events in the successful run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23985) [flakey test] TestZooKeeper
Nick Dimiduk created HBASE-23985:
Summary: [flakey test] TestZooKeeper
Key: HBASE-23985
URL: https://issues.apache.org/jira/browse/HBASE-23985
Project: HBase
Issue Type: Test
Components: test
Affects Versions: 3.0.0
Reporter: Nick Dimiduk
Attachments: TEST-org.apache.hadoop.hbase.TestZooKeeper.xml
I observed a test failure in {{TestZooKeeper#testMasterSessionExpired}} on my
local rig. On a casual read of the logs from {{testMasterSessionExpired}}, it
appears we have a faulty assumption related to master MTTR; the master abort is
logged ~1250ms after ZK session close, which seems entirely too fast to me.
Once the master aborts, the damage is done and the test cannot recover.
The first re-run passes. Surefire does not keep logs of successful tests, so I
don't know the timing between events in the successful run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan
Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan URL: https://github.com/apache/hbase/pull/1208#issuecomment-598985699 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 40s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 59s | master passed | | +1 :green_heart: | compile | 2m 6s | master passed | | +1 :green_heart: | shadedjars | 6m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 27s | master passed | | -0 :warning: | patch | 8m 4s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 13s | the patch passed | | +1 :green_heart: | compile | 2m 2s | the patch passed | | +1 :green_heart: | javac | 2m 2s | the patch passed | | +1 :green_heart: | shadedjars | 6m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 26s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 44s | hbase-client in the patch failed. | | +1 :green_heart: | unit | 66m 15s | hbase-server in the patch passed. | | -1 :x: | unit | 18m 35s | hbase-mapreduce in the patch failed. | | | | 122m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1208 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 17aee835da0e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/testReport/ | | Max. process+thread count | 7361 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23983) Spotbugs warning complain on master build
[
https://issues.apache.org/jira/browse/HBASE-23983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-23983:
--
Status: Patch Available (was: In Progress)
> Spotbugs warning complain on master build
> -
>
> Key: HBASE-23983
> URL: https://issues.apache.org/jira/browse/HBASE-23983
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
>
> Spotbugs currently complains on every master build with an extant warning
> related:
> {code}
> Return value of putIfAbsent is ignored, but node is reused in
> org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] HorizonNet opened a new pull request #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value
HorizonNet opened a new pull request #1287: HBASE-23983 Fixed Spotbugs complaint in RegionStates related to ignored return value URL: https://github.com/apache/hbase/pull/1287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-598983102 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 48s | master passed | | +1 :green_heart: | checkstyle | 3m 28s | master passed | | -1 :x: | spotbugs | 2m 7s | hbase-server in master has 1 extant spotbugs warnings. | | -0 :warning: | patch | 2m 13s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 40s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 21s | hbase-server: The patch generated 0 new + 365 unchanged - 83 fixed = 365 total (was 448) | | +1 :green_heart: | checkstyle | 0m 18s | The patch passed checkstyle in hbase-mapreduce | | +1 :green_heart: | checkstyle | 0m 41s | The patch passed checkstyle in hbase-thrift | | +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-shell | | +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-endpoint | | +1 :green_heart: | checkstyle | 0m 20s | The patch passed checkstyle in hbase-rest | | +1 :green_heart: | rubocop | 0m 7s | There were no new rubocop issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 42s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 7m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 14s | The patch does not generate ASF License warnings. | | | | 62m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux 107e6064c567 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/5/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-23983) Spotbugs warning complain on master build
[
https://issues.apache.org/jira/browse/HBASE-23983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23983 started by Jan Hentschel.
-
> Spotbugs warning complain on master build
> -
>
> Key: HBASE-23983
> URL: https://issues.apache.org/jira/browse/HBASE-23983
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
>
> Spotbugs currently complains on every master build with an extant warning
> related:
> {code}
> Return value of putIfAbsent is ignored, but node is reused in
> org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23984) [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown
Michael Stack created HBASE-23984:
-
Summary: [Flakey Tests] TestMasterAbortAndRSGotKilled fails in
teardown
Key: HBASE-23984
URL: https://issues.apache.org/jira/browse/HBASE-23984
Project: HBase
Issue Type: Bug
Reporter: Michael Stack
Its failing with decent frequency of late in shutdown of cluster. Seems basic.
There is an unassign/move going on. Test just checks Master can come back up
after being killed. Does not check move is done. If on subsequent cluster
shutdown, if the move can't report the Master because its shutting down, then
the move fails, we abort the server, and then we get a wonky loop where we
can't close because server is aborting.
At the root, there is a misaccounting when the unassign close fails where we
don't cleanup references in the regionserver local RIT accounting. Deeper than
this, close code is duplicated in three places that I can see; in RegionServer,
in CloseRegionHandler, and in UnassignRegionHandler.
Let me fix this issue and the code dupe.
Details:
>From
>https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2/5733/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestMasterAbortAndRSGotKilled-output.txt
Here is the unassign handler failing because master went down earlier (Its
probably trying to talk to the old Master location)
{code}
* ABORTING region server asf905.gq1.ygridcore.net,32989,1584000644108:
Failed to close region ede67f9f661acc1241faf468b081d548 and can not recover
*
Cause:
java.io.IOException: Failed to report close to master:
ede67f9f661acc1241faf468b081d548
at
org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:125)
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
... then the cluster shutdown tries to close the same Region... but fails
because we are aborting because of above
{code}
2020-03-12 08:11:16,600 ERROR [RS_CLOSE_REGION-regionserver/asf905:0-0]
helpers.MarkerIgnoringBase(159): * ABORTING region server
asf905.gq1.ygridcore.net,32989,1584000644108: Unrecoverable exception while
closing region
hbase:namespace,,1584000652744.78f4ae5beda711a9bebad0b6b8376cc9., still
finishing close *
java.io.IOException: Aborting flush because server is aborted...
at
org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2545)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2530)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2504)
at
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2495)
at
org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1650)
at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1552)
at
org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:110)
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
And the RS keeps looping trying to close the Region even though we're aborted
and there is handling in RS close Regions to deal with abort.
Trouble seems to be because when UnassignRegionHandler fails its region close,
it does not unregister the Region with
rs.getRegionsInTransitionInRS().remove(encodedNameBytes, Boolean.FALSE);
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23983) Spotbugs warning complain on master build
Jan Hentschel created HBASE-23983:
-
Summary: Spotbugs warning complain on master build
Key: HBASE-23983
URL: https://issues.apache.org/jira/browse/HBASE-23983
Project: HBase
Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
Spotbugs currently complains on every master build with an extant warning
related:
{code}
Return value of putIfAbsent is ignored, but node is reused in
org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598979839 @virajjasani Sorry, yes, the utility method to which I refer is [`HBaseCommonTestingUtility#waitFor`](https://github.com/apache/hbase/blob/9cc7a711e616566ecedb8620a1c8b8a29c3d27b0/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java#L247) and friends. See the underlying `Waiter` class for implementation details. Give that a spin. Yes, there were recent changes in CI to support JDK11. The summary is posted on [this thread](https://lists.apache.org/thread.html/r8cb0c257be374b3f1b0d8caaa628eea874af77d2faae8c44918263d3%40%3Cdev.hbase.apache.org%3E). TL;DR, PR PreCommit now responds in 3 comments, not just one: "general checks", "JDK8", "JDK11". General checks has stuff like Findbugs/Spotbug and non-Java stuff. Look for unit test results the one with Java version 8, as I'm still working on the JDK11 harness. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-598978728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 25s | master passed | | +1 :green_heart: | compile | 4m 16s | master passed | | +1 :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 28s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 22s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 23s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 48s | hbase-thrift in master failed. | | -0 :warning: | patch | 9m 31s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 12s | the patch passed | | +1 :green_heart: | compile | 4m 13s | the patch passed | | +1 :green_heart: | javac | 4m 13s | the patch passed | | +1 :green_heart: | shadedjars | 4m 55s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 50s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 24s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 21s | hbase-examples in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 0m 45s | hbase-client in the patch failed. | | -0 :warning: | unit | 5m 2s | hbase-server in the patch failed. | | -0 :warning: | unit | 5m 56s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 17s | hbase-thrift in the patch passed. | | -0 :warning: | unit | 7m 21s | hbase-shell in the patch failed. | | +1 :green_heart: | unit | 2m 52s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 16s | hbase-examples in the patch passed. | | | | 67m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b1a569cde534 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc |
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-598978127 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 0s | master passed | | +1 :green_heart: | checkstyle | 3m 37s | master passed | | -1 :x: | spotbugs | 2m 21s | hbase-server in master has 1 extant spotbugs warnings. | | -0 :warning: | patch | 2m 19s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 39s | the patch passed | | +1 :green_heart: | checkstyle | 3m 40s | the patch passed | | +1 :green_heart: | rubocop | 0m 4s | There were no new rubocop issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 53s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 7m 51s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 13s | The patch does not generate ASF License warnings. | | | | 64m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux 7c75d182d48f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan
Apache-HBase commented on issue #1213: HBASE-23846 Removed deprecated setMaxVersions(int) from Scan URL: https://github.com/apache/hbase/pull/1213#issuecomment-598973110 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 5s | master passed | | +1 :green_heart: | checkstyle | 3m 51s | master passed | | -1 :x: | spotbugs | 2m 12s | hbase-server in master has 1 extant spotbugs warnings. | | -0 :warning: | patch | 2m 30s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 47s | the patch passed | | +1 :green_heart: | checkstyle | 3m 49s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 21m 10s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 11m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 48s | The patch does not generate ASF License warnings. | | | | 75m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1213 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 3afc1fe617d8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 84 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1213/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan
Apache-HBase commented on issue #1208: HBASE-23845 Removed deprecated setMaxVersions from Scan URL: https://github.com/apache/hbase/pull/1208#issuecomment-598972819 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 57s | master passed | | +1 :green_heart: | checkstyle | 2m 5s | master passed | | -1 :x: | spotbugs | 2m 8s | hbase-server in master has 1 extant spotbugs warnings. | | -0 :warning: | patch | 2m 30s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 47s | the patch passed | | +1 :green_heart: | checkstyle | 2m 13s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 25s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 4m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 54m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1208 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 21289979ee14 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1208/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23967) Improve the accuracy of the method sizeToString
[
https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059125#comment-17059125
]
Hudson commented on HBASE-23967:
Results for branch branch-2.2
[build #815 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/815/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/815//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/815//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/815//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Improve the accuracy of the method sizeToString
> ---
>
> Key: HBASE-23967
> URL: https://issues.apache.org/jira/browse/HBASE-23967
> Project: HBase
> Issue Type: Improvement
>Affects Versions: master
>Reporter: xuqinya
>Assignee: xuqinya
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.1.10, 2.2.5
>
>
> In QuotaSettings，the method of sizeToString reserved integer. But, this is
> not very accurate.
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G',
> POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNERQUOTAS
>
>
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT =>
> 1T, VIOLATION_POLICY => NO_INSERTS
>
> 1 row(s) in 0.0340 seconds
> {code}
> after patch：
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G',
> POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNERQUOTAS
>
>
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT =>
> 1.95T, VIOLATION_POLICY => NO_INSERTS
> 1 row(s) in 0.0230 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598959781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 49s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 48s | master passed | | +1 :green_heart: | compile | 1m 22s | master passed | | +1 :green_heart: | shadedjars | 5m 43s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 45s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 8s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 1m 6s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 158m 50s | hbase-server in the patch failed. | | | | 194m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1286 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ebc13981a419 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/testReport/ | | Max. process+thread count | 4819 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598957434 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 49s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 18s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 5m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 155m 32s | hbase-server in the patch failed. | | | | 185m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1286 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cd2d74d88077 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/testReport/ | | Max. process+thread count | 4536 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-598933669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 37s | master passed | | +1 :green_heart: | compile | 4m 33s | master passed | | +1 :green_heart: | shadedjars | 5m 15s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 21s | hbase-backup in master failed. | | -0 :warning: | javadoc | 0m 22s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 26s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 49s | hbase-thrift in master failed. | | -0 :warning: | patch | 9m 51s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 28s | the patch passed | | +1 :green_heart: | compile | 4m 27s | the patch passed | | +1 :green_heart: | javac | 4m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 54s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 1m 2s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 29s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 1m 26s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 27s | hbase-backup in the patch failed. | | -0 :warning: | javadoc | 0m 36s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 37s | hbase-client in the patch passed. | | -0 :warning: | unit | 113m 56s | hbase-server in the patch failed. | | -0 :warning: | unit | 11m 20s | hbase-mapreduce in the patch failed. | | -0 :warning: | unit | 13m 51s | hbase-thrift in the patch failed. | | -0 :warning: | unit | 4m 30s | hbase-backup in the patch failed. | | +1 :green_heart: | unit | 1m 34s | hbase-it in the patch passed. | | -0 :warning: | unit | 3m 17s | hbase-rest in the patch failed. | | | | 196m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1184 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7b7a7efb1847 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-backup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc |
[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-598931253 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 27s | master passed | | +1 :green_heart: | compile | 3m 51s | master passed | | +1 :green_heart: | shadedjars | 4m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 41s | master passed | | -0 :warning: | patch | 8m 42s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 18s | the patch passed | | +1 :green_heart: | compile | 3m 45s | the patch passed | | +1 :green_heart: | javac | 3m 45s | the patch passed | | +1 :green_heart: | shadedjars | 4m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 53s | hbase-client in the patch passed. | | -1 :x: | unit | 107m 36s | hbase-server in the patch failed. | | -1 :x: | unit | 23m 16s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 35s | hbase-thrift in the patch passed. | | -1 :x: | unit | 16m 38s | hbase-backup in the patch failed. | | +1 :green_heart: | unit | 1m 10s | hbase-it in the patch passed. | | -1 :x: | unit | 3m 31s | hbase-rest in the patch failed. | | | | 194m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1184 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ee41366cc663 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-mapreduce.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-backup.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rest.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/testReport/ | | Max. process+thread count | 7776 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan
Apache-HBase commented on issue #1184: HBASE-23848 Removed deprecated setStopRow from Scan URL: https://github.com/apache/hbase/pull/1184#issuecomment-59889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 13s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 51s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 46s | master passed | | +1 :green_heart: | checkstyle | 6m 11s | master passed | | -1 :x: | spotbugs | 3m 32s | hbase-server in master has 1 extant spotbugs warnings. | | -0 :warning: | patch | 4m 58s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 38s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 8s | the patch passed | | +1 :green_heart: | checkstyle | 0m 53s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 2m 11s | hbase-server: The patch generated 0 new + 9 unchanged - 2 fixed = 9 total (was 11) | | +1 :green_heart: | checkstyle | 0m 32s | The patch passed checkstyle in hbase-mapreduce | | +1 :green_heart: | checkstyle | 1m 8s | The patch passed checkstyle in hbase-thrift | | +1 :green_heart: | checkstyle | 0m 25s | The patch passed checkstyle in hbase-backup | | +1 :green_heart: | checkstyle | 0m 34s | hbase-it: The patch generated 0 new + 33 unchanged - 1 fixed = 33 total (was 34) | | +1 :green_heart: | checkstyle | 0m 29s | The patch passed checkstyle in hbase-rest | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 23m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 18m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 4m 13s | The patch does not generate ASF License warnings. | | | | 108m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1184 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 550dd7047e0a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1184/6/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598892947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 2s | master passed | | +1 :green_heart: | checkstyle | 1m 13s | master passed | | -1 :x: | spotbugs | 2m 11s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 35s | the patch passed | | +1 :green_heart: | checkstyle | 1m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 13s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 45m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1286 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 492902fbb377 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23887) BlockCache performance improve
[
https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danil Lipovoy updated HBASE-23887:
--
Description:
НГHi!
I first time here, correct me please if something wrong.
I want propose how to improve performance when data in HFiles much more than
BlockChache (usual story in BigData). The idea - caching only part of DATA
blocks. It is good becouse LruBlockCache starts to work and save huge amount of
GC. See the picture in attachment with test below. Requests per second is
higher, GC is lower.
The key point of the code:
Added the parameter: *hbase.lru.cache.data.block.percent* which by default = 100
But if we set it 0-99, then will work the next logic:
{code:java}
public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf, boolean inMemory)
{
if (cacheDataBlockPercent != 100 && buf.getBlockType().isData())
if (cacheKey.getOffset() % 100 >= cacheDataBlockPercent)
return;
...
// the same code as usual
}
{code}
Descriptions of the test:
4 nodes E5-2698 v4 @ 2.20GHz, 700 Gb Mem.
4 RegionServers
4 tables by 64 regions by 1.88 Gb data in each = 600 Gb total (only FAST_DIFF)
Total BlockCache Size = 48 Gb (8 % of data in HFiles)
Random read in 20 threads
I am going to make Pull Request, hope it is right way to make some contribution
in this cool product.
was:
Hi!
I first time here, correct me please if something wrong.
I want propose how to improve performance when data in HFiles much more than
BlockChache (usual story in BigData). The idea - caching only part of DATA
blocks. It is good becouse LruBlockCache starts to work and save huge amount of
GC. See the picture in attachment with test below. Requests per second is
higher, GC is lower.
The key point of the code:
Added the parameter: *hbase.lru.cache.data.block.percent* which by default = 100
But if we set it 0-99, then will work the next logic:
{code:java}
public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf, boolean inMemory)
{
if (cacheDataBlockPercent != 100 && buf.getBlockType().isData())
if (cacheKey.getOffset() % 100 >= cacheDataBlockPercent)
return;
...
// the same code as usual
}
{code}
Descriptions of the test:
4 nodes E5-2698 v4 @ 2.20GHz, 700 Gb Mem.
4 RegionServers
4 tables by 64 regions by 1.88 Gb data in each = 600 Gb total (only FAST_DIFF)
Total BlockCache Size = 48 Gb (8 % of data in HFiles)
Random read in 20 threads
I am going to make Pull Request, hope it is right way to make some contribution
in this cool product.
> BlockCache performance improve
> --
>
> Key: HBASE-23887
> URL: https://issues.apache.org/jira/browse/HBASE-23887
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, Performance
>Reporter: Danil Lipovoy
>Priority: Minor
> Attachments: 1582787018434_rs_metrics.jpg,
> 1582801838065_rs_metrics_new.png, BC_LongRun.png, cmp.png,
> evict_BC100_vs_BC23.png, read_requests_100pBC_vs_23pBC.png
>
>
> НГHi!
> I first time here, correct me please if something wrong.
> I want propose how to improve performance when data in HFiles much more than
> BlockChache (usual story in BigData). The idea - caching only part of DATA
> blocks. It is good becouse LruBlockCache starts to work and save huge amount
> of GC. See the picture in attachment with test below. Requests per second is
> higher, GC is lower.
>
> The key point of the code:
> Added the parameter: *hbase.lru.cache.data.block.percent* which by default =
> 100
>
> But if we set it 0-99, then will work the next logic:
>
>
> {code:java}
> public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf, boolean
> inMemory) {
> if (cacheDataBlockPercent != 100 && buf.getBlockType().isData())
> if (cacheKey.getOffset() % 100 >= cacheDataBlockPercent)
> return;
> ...
> // the same code as usual
> }
> {code}
>
>
> Descriptions of the test:
> 4 nodes E5-2698 v4 @ 2.20GHz, 700 Gb Mem.
> 4 RegionServers
> 4 tables by 64 regions by 1.88 Gb data in each = 600 Gb total (only FAST_DIFF)
> Total BlockCache Size = 48 Gb (8 % of data in HFiles)
> Random read in 20 threads
>
> I am going to make Pull Request, hope it is right way to make some
> contribution in this cool product.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598854018 Spotbug in this build has nothing to do with this patch: ``` Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo) ``` Also, I think moving to spotbugs is a recent change, but why unit test is missing from the QA results? @ndimiduk are you aware of any very recent change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598877228 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 53s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 15s | master passed | | +1 :green_heart: | compile | 1m 23s | master passed | | +1 :green_heart: | shadedjars | 5m 42s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 16s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 1m 4s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 158m 45s | hbase-server in the patch failed. | | | | 193m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1286 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4fa528267fe3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/testReport/ | | Max. process+thread count | 4775 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598874977 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 48s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 5m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 5m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 156m 50s | hbase-server in the patch failed. | | | | 187m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1286 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4694ef855af4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/testReport/ | | Max. process+thread count | 4532 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790942 btw I am returning true in `waitFor()` because `confirmPayloadParams` is anyways going to throw AssertError if match is not found This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#issuecomment-598866258 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 2s | master passed | | +1 :green_heart: | compile | 4m 4s | master passed | | +1 :green_heart: | shadedjars | 6m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 26s | the patch passed | | +1 :green_heart: | compile | 4m 17s | the patch passed | | +1 :green_heart: | javac | 4m 17s | the patch passed | | +1 :green_heart: | shadedjars | 5m 21s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 47s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 0s | hbase-client in the patch passed. | | -1 :x: | unit | 100m 26s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 5m 9s | hbase-endpoint in the patch passed. | | +1 :green_heart: | unit | 3m 16s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 8m 51s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 4m 22s | hbase-examples in the patch passed. | | | | 172m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1280 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d70ff6769535 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/testReport/ | | Max. process+thread count | 3954 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-it hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23295) hbase-connectors HBaseContext should use most recent delegation token
[ https://issues.apache.org/jira/browse/HBASE-23295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058998#comment-17058998 ] Sakthi commented on HBASE-23295: Closing out the jira. > hbase-connectors HBaseContext should use most recent delegation token > - > > Key: HBASE-23295 > URL: https://issues.apache.org/jira/browse/HBASE-23295 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: István Adamcsik >Assignee: István Adamcsik >Priority: Major > Fix For: connector-1.0.1 > > Attachments: HBASE-23295.patch > > > For a long-running HBaseContext, it keeps referring to the persisting > credential instead of the most recent token. This would cause the Spark job > failed due to "token has expired" issue if the HBaseContext's lifetime is > longer than the token's lifetime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23295) hbase-connectors HBaseContext should use most recent delegation token
[ https://issues.apache.org/jira/browse/HBASE-23295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi resolved HBASE-23295. Resolution: Fixed > hbase-connectors HBaseContext should use most recent delegation token > - > > Key: HBASE-23295 > URL: https://issues.apache.org/jira/browse/HBASE-23295 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: István Adamcsik >Assignee: István Adamcsik >Priority: Major > Fix For: connector-1.0.1 > > Attachments: HBASE-23295.patch > > > For a long-running HBaseContext, it keeps referring to the persisting > credential instead of the most recent token. This would cause the Spark job > failed due to "token has expired" issue if the HBaseContext's lifetime is > longer than the token's lifetime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23295) hbase-connectors HBaseContext should use most recent delegation token
[ https://issues.apache.org/jira/browse/HBASE-23295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-23295: --- Fix Version/s: connector-1.0.1 > hbase-connectors HBaseContext should use most recent delegation token > - > > Key: HBASE-23295 > URL: https://issues.apache.org/jira/browse/HBASE-23295 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: István Adamcsik >Assignee: István Adamcsik >Priority: Major > Fix For: connector-1.0.1 > > Attachments: HBASE-23295.patch > > > For a long-running HBaseContext, it keeps referring to the persisting > credential instead of the most recent token. This would cause the Spark job > failed due to "token has expired" issue if the HBaseContext's lifetime is > longer than the token's lifetime. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23861) Reconcile Hadoop version
[
https://issues.apache.org/jira/browse/HBASE-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058984#comment-17058984
]
Hudson commented on HBASE-23861:
Results for branch branch-2
[build #2551 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Reconcile Hadoop version
>
>
> Key: HBASE-23861
> URL: https://issues.apache.org/jira/browse/HBASE-23861
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Affects Versions: 3.0.0
> Environment: Apache Maven 3.6.1
> Hadoop 3.2.0 and above.
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> I followed the HBase book
> http://hbase.apache.org/book.html#maven.build.hadoop and wanted to build
> HBase (master) on top of Hadoop 3.2/3.3 but tests failed right away.
> Build:
> {code}
> mvn clean install -Dhadoop.profile=3.0 -Dhadoop-three.version=3.2.1
> -DskipTests
> {code}
> Test:
> {code}
> mvn test -Dtest=TestHelloHBase -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.2.1
> {code}
> {noformat}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.296
> s <<< FAILURE! - in
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase
> [ERROR] org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase
> Time elapsed: 1.284 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> org/apache/hadoop/hdfs/protocol/HdfsConstants$StoragePolicySatisfierMode
> at
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.hadoop.hdfs.protocol.HdfsConstants$StoragePolicySatisfierMode
> at
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54)
> {noformat}
> Adding mvn -X parameter, I was able to tell that it was because the
> hbase-server module includes hadoop-distcp and hadoop-dfs-client 3.1.2 (the
> default Hadoop 3 dependency version) while it uses version 3.2.1 of other
> hadoop jars . The classpath conflict (the storage policy satisfier is a new
> feature in Hadoop 3.2) failed the test.
> This is reproducible on any Hadoop version 3.2 and above. It looks to me the
> version of hadoop-distcp and hadoop-hdfs-client should be specified at the
> top level pom (they are specified in hbase-server/pom.xml).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#issuecomment-59886 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 8s | master passed | | +1 :green_heart: | compile | 4m 45s | master passed | | +1 :green_heart: | shadedjars | 5m 29s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 22s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-examples in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 6s | the patch passed | | +1 :green_heart: | compile | 4m 46s | the patch passed | | +1 :green_heart: | javac | 4m 46s | the patch passed | | +1 :green_heart: | shadedjars | 5m 33s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 22s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-examples in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | -0 :warning: | unit | 99m 44s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 2m 54s | hbase-endpoint in the patch passed. | | +1 :green_heart: | unit | 1m 4s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 3m 18s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 42s | hbase-examples in the patch passed. | | | | 155m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1280 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 99123227e423 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/testReport/ | | Max. process+thread count | 4167 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded
[jira] [Commented] (HBASE-23077) move entirely to spotbugs
[
https://issues.apache.org/jira/browse/HBASE-23077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058983#comment-17058983
]
Hudson commented on HBASE-23077:
Results for branch branch-2
[build #2551 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> move entirely to spotbugs
> -
>
> Key: HBASE-23077
> URL: https://issues.apache.org/jira/browse/HBASE-23077
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Sean Busbey
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> we've been relying on spotbugs definitions with findbugs tooling for awhile
> now. I think spotbugs now provides its own versions of everything we need
> (and Yetus supports spotbugs directly).
> Do a pass removing findbugs tooling from all branches in favor of spotbugs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23967) Improve the accuracy of the method sizeToString
[
https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058985#comment-17058985
]
Hudson commented on HBASE-23967:
Results for branch branch-2
[build #2551 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2551//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Improve the accuracy of the method sizeToString
> ---
>
> Key: HBASE-23967
> URL: https://issues.apache.org/jira/browse/HBASE-23967
> Project: HBase
> Issue Type: Improvement
>Affects Versions: master
>Reporter: xuqinya
>Assignee: xuqinya
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.1.10, 2.2.5
>
>
> In QuotaSettings，the method of sizeToString reserved integer. But, this is
> not very accurate.
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G',
> POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNERQUOTAS
>
>
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT =>
> 1T, VIOLATION_POLICY => NO_INSERTS
>
> 1 row(s) in 0.0340 seconds
> {code}
> after patch：
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G',
> POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNERQUOTAS
>
>
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT =>
> 1.95T, VIOLATION_POLICY => NO_INSERTS
> 1 row(s) in 0.0230 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598854018 Spotbug in this build has nothing to do with this patch: ``` Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo) ``` Also, I think moving to spotbugs is a recent change, but why unit test is missing from the QA results? @ndimiduk are you aware of any very recent change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23982) Shell tests broken
[
https://issues.apache.org/jira/browse/HBASE-23982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-23982:
--
Issue Type: Bug (was: Improvement)
> Shell tests broken
> --
>
> Key: HBASE-23982
> URL: https://issues.apache.org/jira/browse/HBASE-23982
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Priority: Major
>
> The shell tests in the master seem to be broken. When running {{mvn clean
> install -pl hbase-shell -PrunClientTests}} it reports the following errors:
> {code}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hadoop.hbase.client.TestTableShell
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 66.561 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestTableShell
> [ERROR] org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests Time
> elapsed: 63.222 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests(TestTableShell.java:40)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> [INFO] Running org.apache.hadoop.hbase.client.TestQuotasShell
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 362.723 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestQuotasShell
> [ERROR] org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests
> Time elapsed: 360.415 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests(TestQuotasShell.java:40)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> [INFO] Running org.apache.hadoop.hbase.client.TestRSGroupShell
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.653
> s - in org.apache.hadoop.hbase.client.TestRSGroupShell
> [INFO] Running org.apache.hadoop.hbase.client.TestAdminShell
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 155.249 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAdminShell
> [ERROR] org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests Time
> elapsed: 151.904 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests(TestAdminShell.java:40)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> [INFO] Running org.apache.hadoop.hbase.client.TestShellNoCluster
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.684
> s - in org.apache.hadoop.hbase.client.TestShellNoCluster
> [INFO] Running org.apache.hadoop.hbase.client.TestReplicationShell
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 113.892 s - in org.apache.hadoop.hbase.client.TestReplicationShell
> [INFO] Running org.apache.hadoop.hbase.client.TestShell
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 35.646 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestShell
> [ERROR] org.apache.hadoop.hbase.client.TestShell.testRunShellTests Time
> elapsed: 32.328 s <<< ERROR!
> org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
> Check output file for details.
> at
> org.apache.hadoop.hbase.client.TestShell.testRunShellTests(TestShell.java:40)
> Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit
> tests failed. Check output file for details.
> [INFO] Running org.apache.hadoop.hbase.client.TestAdminShell2
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> 141.174 s - in org.apache.hadoop.hbase.client.TestAdminShell2
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestAdminShell.testRunShellTests:40 » EvalFailed (RuntimeError)
> Shell unit tes...
> [ERROR] TestQuotasShell.testRunShellTests:40 » EvalFailed (RuntimeError)
> Shell unit te...
> [ERROR] TestShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell
> unit tests fa...
> [ERROR] TestTableShell.testRunShellTests:40 » EvalFailed (RuntimeError)
> Shell unit tes...
> [INFO]
> [ERROR] Tests run: 8, Failures: 0, Errors: 4, Skipped: 0
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#issuecomment-598823501 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. | | +0 :ok: | prototool | 0m 2s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 14s | master passed | | +1 :green_heart: | checkstyle | 3m 19s | master passed | | -1 :x: | spotbugs | 2m 1s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-protocol-shaded | | +1 :green_heart: | checkstyle | 0m 41s | hbase-client: The patch generated 0 new + 414 unchanged - 24 fixed = 414 total (was 438) | | +1 :green_heart: | checkstyle | 1m 24s | hbase-server: The patch generated 0 new + 655 unchanged - 30 fixed = 655 total (was 685) | | +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-endpoint | | +1 :green_heart: | checkstyle | 0m 18s | The patch passed checkstyle in hbase-it | | +1 :green_heart: | checkstyle | 0m 16s | The patch passed checkstyle in hbase-rest | | +1 :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-examples | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 16m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 3m 50s | the patch passed | | +1 :green_heart: | spotbugs | 8m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 23s | The patch does not generate ASF License warnings. | | | | 65m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1280 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml cc hbaseprotoc prototool | | uname | Linux 9ef9a8e056c5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-endpoint hbase-it hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23982) Shell tests broken
Jan Hentschel created HBASE-23982:
-
Summary: Shell tests broken
Key: HBASE-23982
URL: https://issues.apache.org/jira/browse/HBASE-23982
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 3.0.0
Reporter: Jan Hentschel
The shell tests in the master seem to be broken. When running {{mvn clean
install -pl hbase-shell -PrunClientTests}} it reports the following errors:
{code}
[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running org.apache.hadoop.hbase.client.TestTableShell
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 66.561
s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestTableShell
[ERROR] org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests Time
elapsed: 63.222 s <<< ERROR!
org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
Check output file for details.
at
org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests(TestTableShell.java:40)
Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests
failed. Check output file for details.
[INFO] Running org.apache.hadoop.hbase.client.TestQuotasShell
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 362.723
s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestQuotasShell
[ERROR] org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests Time
elapsed: 360.415 s <<< ERROR!
org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
Check output file for details.
at
org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests(TestQuotasShell.java:40)
Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests
failed. Check output file for details.
[INFO] Running org.apache.hadoop.hbase.client.TestRSGroupShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.653 s
- in org.apache.hadoop.hbase.client.TestRSGroupShell
[INFO] Running org.apache.hadoop.hbase.client.TestAdminShell
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 155.249
s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAdminShell
[ERROR] org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests Time
elapsed: 151.904 s <<< ERROR!
org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
Check output file for details.
at
org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests(TestAdminShell.java:40)
Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests
failed. Check output file for details.
[INFO] Running org.apache.hadoop.hbase.client.TestShellNoCluster
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.684 s
- in org.apache.hadoop.hbase.client.TestShellNoCluster
[INFO] Running org.apache.hadoop.hbase.client.TestReplicationShell
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 113.892
s - in org.apache.hadoop.hbase.client.TestReplicationShell
[INFO] Running org.apache.hadoop.hbase.client.TestShell
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 35.646
s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestShell
[ERROR] org.apache.hadoop.hbase.client.TestShell.testRunShellTests Time
elapsed: 32.328 s <<< ERROR!
org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed.
Check output file for details.
at
org.apache.hadoop.hbase.client.TestShell.testRunShellTests(TestShell.java:40)
Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests
failed. Check output file for details.
[INFO] Running org.apache.hadoop.hbase.client.TestAdminShell2
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 141.174
s - in org.apache.hadoop.hbase.client.TestAdminShell2
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] TestAdminShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell
unit tes...
[ERROR] TestQuotasShell.testRunShellTests:40 » EvalFailed (RuntimeError)
Shell unit te...
[ERROR] TestShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell unit
tests fa...
[ERROR] TestTableShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell
unit tes...
[INFO]
[ERROR] Tests run: 8, Failures: 0, Errors: 4, Skipped: 0
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598816816 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 2s | master passed | | +1 :green_heart: | checkstyle | 1m 7s | master passed | | -1 :x: | spotbugs | 1m 58s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | checkstyle | 1m 6s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 39m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1286 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux dc55ad896bbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b9e74e0b0a | | spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] jojochuang commented on issue #1284: HBASE-22103. HDFS-13209 in Hadoop 3.3.0 breaks asyncwal.
jojochuang commented on issue #1284: HBASE-22103. HDFS-13209 in Hadoop 3.3.0 breaks asyncwal. URL: https://github.com/apache/hbase/pull/1284#issuecomment-598811004 @Apache9 would you like to review this one? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23861) Reconcile Hadoop version
[
https://issues.apache.org/jira/browse/HBASE-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058903#comment-17058903
]
Wei-Chiu Chuang commented on HBASE-23861:
-
I think it depends on the support matrix you guys want for HBase 2.2/2.1.
If you want to support Hadoop 3.2 and above, this is a must.
If the community decide not to cherry pick this bug fix into 2.2/2.1, I'd
suggest to update the hbase user guide http://hbase.apache.org/book.html#hadoop
to indicate Hadoop 3.2 is known to break for HBase 2.2/2.1.
> Reconcile Hadoop version
>
>
> Key: HBASE-23861
> URL: https://issues.apache.org/jira/browse/HBASE-23861
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Affects Versions: 3.0.0
> Environment: Apache Maven 3.6.1
> Hadoop 3.2.0 and above.
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> I followed the HBase book
> http://hbase.apache.org/book.html#maven.build.hadoop and wanted to build
> HBase (master) on top of Hadoop 3.2/3.3 but tests failed right away.
> Build:
> {code}
> mvn clean install -Dhadoop.profile=3.0 -Dhadoop-three.version=3.2.1
> -DskipTests
> {code}
> Test:
> {code}
> mvn test -Dtest=TestHelloHBase -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.2.1
> {code}
> {noformat}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.296
> s <<< FAILURE! - in
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase
> [ERROR] org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase
> Time elapsed: 1.284 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> org/apache/hadoop/hdfs/protocol/HdfsConstants$StoragePolicySatisfierMode
> at
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.hadoop.hdfs.protocol.HdfsConstants$StoragePolicySatisfierMode
> at
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54)
> {noformat}
> Adding mvn -X parameter, I was able to tell that it was because the
> hbase-server module includes hadoop-distcp and hadoop-dfs-client 3.1.2 (the
> default Hadoop 3 dependency version) while it uses version 3.2.1 of other
> hadoop jars . The classpath conflict (the storage policy satisfier is a new
> feature in Hadoop 3.2) failed the test.
> This is reproducible on any Hadoop version 3.2 and above. It looks to me the
> version of hadoop-distcp and hadoop-hdfs-client should be specified at the
> top level pom (they are specified in hbase-server/pom.xml).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:
[
https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-23977:
-
Fix Version/s: 2.3.0
3.0.0
Affects Version/s: 2.3.0
3.0.0
Status: Patch Available (was: In Progress)
> [Flakey Tests]
> TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97
> expected: but was:
> -
>
> Key: HBASE-23977
> URL: https://issues.apache.org/jira/browse/HBASE-23977
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Michael Stack
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> I see this occasionally on a linux vm. [~vjasani] .. you might have an idea
> why this is going on (this is your test I believe and a recent addition). If
> you have stuff I can try, shout.
> Here is fail:
> {code}
> org.junit.ComparisonFailure: expected: but was:
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.confirmPayloadParams(TestSlowLogRecorder.java:97)
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.testOnlieSlowLogConsumption(TestSlowLogRecorder.java:178)
> {code}
> Here is log:
> {code}
> 2020-03-12 17:02:06,266 INFO [Time-limited test] hbase.ResourceChecker(179):
> after:
> regionserver.slowlog.TestSlowLogRecorder#testOnlineSlowLogWithDisableConfig
> Thread=7 (was 7), OpenFileDescriptor=226 (was 226),
> MaxFileDescriptor=131072 (was 131072), SystemLoadAverage=353 (was 353),
> ProcessCount=195 (was 195), AvailableMemoryMB=7037 (was 7027) -
> AvailableMemoryMB LEAK? -
> 2020-03-12 17:02:06,281 INFO [Time-limited test]
> hbase.ResourceChecker(151): before:
> regionserver.slowlog.TestSlowLogRecorder#testOnlieSlowLogConsumption
> Thread=7, OpenFileDescriptor=226, MaxFileDescriptor=131072,
> SystemLoadAverage=353, ProcessCount=195, AvailableMemoryMB=7036
> 2020-03-12 17:02:06,317 DEBUG [Time-limited test]
> slowlog.TestSlowLogRecorder(111): Initially ringbuffer of Slow Log records is
> empty
> 2020-03-12 17:02:06,326 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,528 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,630 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,732 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598796148
> There's a utility method `waitUntil` that lets you wait for a condition to
occur, or timeout. Check it's return value for the timeout case.
Public methods related to `waitUntil` also seem to be waiting till specific
duration.
e.g
```
public void waitUntilNoRegionsInTransition() throws IOException {
waitUntilNoRegionsInTransition(15 * 6);
}
```
May be better to use `waitFor` directly?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23861) Reconcile Hadoop version
[
https://issues.apache.org/jira/browse/HBASE-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058868#comment-17058868
]
Viraj Jasani commented on HBASE-23861:
--
oops, yes if transitive dependency is changing, agree on not pushing out to
patch releases.
[~weichiu]
> Reconcile Hadoop version
>
>
> Key: HBASE-23861
> URL: https://issues.apache.org/jira/browse/HBASE-23861
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Affects Versions: 3.0.0
> Environment: Apache Maven 3.6.1
> Hadoop 3.2.0 and above.
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> I followed the HBase book
> http://hbase.apache.org/book.html#maven.build.hadoop and wanted to build
> HBase (master) on top of Hadoop 3.2/3.3 but tests failed right away.
> Build:
> {code}
> mvn clean install -Dhadoop.profile=3.0 -Dhadoop-three.version=3.2.1
> -DskipTests
> {code}
> Test:
> {code}
> mvn test -Dtest=TestHelloHBase -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.2.1
> {code}
> {noformat}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.296
> s <<< FAILURE! - in
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase
> [ERROR] org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase
> Time elapsed: 1.284 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> org/apache/hadoop/hdfs/protocol/HdfsConstants$StoragePolicySatisfierMode
> at
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.hadoop.hdfs.protocol.HdfsConstants$StoragePolicySatisfierMode
> at
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54)
> {noformat}
> Adding mvn -X parameter, I was able to tell that it was because the
> hbase-server module includes hadoop-distcp and hadoop-dfs-client 3.1.2 (the
> default Hadoop 3 dependency version) while it uses version 3.2.1 of other
> hadoop jars . The classpath conflict (the storage policy satisfier is a new
> feature in Hadoop 3.2) failed the test.
> This is reproducible on any Hadoop version 3.2 and above. It looks to me the
> version of hadoop-distcp and hadoop-hdfs-client should be specified at the
> top level pom (they are specified in hbase-server/pom.xml).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790942 btw I am returning true in `waitFor()` because `confirmPayloadParams` is anyways going to throw AssertError if match is not found This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790294 > Maybe try inserting an intentional delay into the machinery around the ringbuffer, so as to tease out a timing bug? It's not timing bug actually, it's happening asynchronously and we are expecting records in one order before they are even processed. I just tried `waitFor`, how does it look? @ndimiduk @saintstack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598783297 Maybe try inserting an intentional delay into the machinery around the ringbuffer, so as to tease out a timing bug? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598783017 There's a utility method `waitUntil` that lets you wait for a condition to occur, or timeout. Check it's return value for the timeout case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286#issuecomment-598782970 Yeah agree, let me quickly try it. Thanks @saintstack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23861) Reconcile Hadoop version
[
https://issues.apache.org/jira/browse/HBASE-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058852#comment-17058852
]
Nick Dimiduk commented on HBASE-23861:
--
If this changes the transitive dependencies from a client application point of
view, it is technically a binary interface incompatible change and should not
be shipped as a patch release. However, the current behavior is a bug.
I think it's acceptable to fix a bug, so long as it does not adversely impact
users of earlier versions of Hadoop. Can you show how this change impacts a
client application's transitive dependencies?
What do [~zghao], [~zhangduo], [~busbey] think?
> Reconcile Hadoop version
>
>
> Key: HBASE-23861
> URL: https://issues.apache.org/jira/browse/HBASE-23861
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Affects Versions: 3.0.0
> Environment: Apache Maven 3.6.1
> Hadoop 3.2.0 and above.
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> I followed the HBase book
> http://hbase.apache.org/book.html#maven.build.hadoop and wanted to build
> HBase (master) on top of Hadoop 3.2/3.3 but tests failed right away.
> Build:
> {code}
> mvn clean install -Dhadoop.profile=3.0 -Dhadoop-three.version=3.2.1
> -DskipTests
> {code}
> Test:
> {code}
> mvn test -Dtest=TestHelloHBase -Dhadoop.profile=3.0
> -Dhadoop-three.version=3.2.1
> {code}
> {noformat}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.296
> s <<< FAILURE! - in
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase
> [ERROR] org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase
> Time elapsed: 1.284 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> org/apache/hadoop/hdfs/protocol/HdfsConstants$StoragePolicySatisfierMode
> at
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.hadoop.hdfs.protocol.HdfsConstants$StoragePolicySatisfierMode
> at
> org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54)
> {noformat}
> Adding mvn -X parameter, I was able to tell that it was because the
> hbase-server module includes hadoop-distcp and hadoop-dfs-client 3.1.2 (the
> default Hadoop 3 dependency version) while it uses version 3.2.1 of other
> hadoop jars . The classpath conflict (the storage policy satisfier is a new
> feature in Hadoop 3.2) failed the test.
> This is reproducible on any Hadoop version 3.2 and above. It looks to me the
> version of hadoop-distcp and hadoop-hdfs-client should be specified at the
> top level pom (they are specified in hbase-server/pom.xml).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:
[
https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23977 started by Viraj Jasani.
> [Flakey Tests]
> TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97
> expected: but was:
> -
>
> Key: HBASE-23977
> URL: https://issues.apache.org/jira/browse/HBASE-23977
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Michael Stack
>Assignee: Viraj Jasani
>Priority: Major
>
> I see this occasionally on a linux vm. [~vjasani] .. you might have an idea
> why this is going on (this is your test I believe and a recent addition). If
> you have stuff I can try, shout.
> Here is fail:
> {code}
> org.junit.ComparisonFailure: expected: but was:
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.confirmPayloadParams(TestSlowLogRecorder.java:97)
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.testOnlieSlowLogConsumption(TestSlowLogRecorder.java:178)
> {code}
> Here is log:
> {code}
> 2020-03-12 17:02:06,266 INFO [Time-limited test] hbase.ResourceChecker(179):
> after:
> regionserver.slowlog.TestSlowLogRecorder#testOnlineSlowLogWithDisableConfig
> Thread=7 (was 7), OpenFileDescriptor=226 (was 226),
> MaxFileDescriptor=131072 (was 131072), SystemLoadAverage=353 (was 353),
> ProcessCount=195 (was 195), AvailableMemoryMB=7037 (was 7027) -
> AvailableMemoryMB LEAK? -
> 2020-03-12 17:02:06,281 INFO [Time-limited test]
> hbase.ResourceChecker(151): before:
> regionserver.slowlog.TestSlowLogRecorder#testOnlieSlowLogConsumption
> Thread=7, OpenFileDescriptor=226, MaxFileDescriptor=131072,
> SystemLoadAverage=353, ProcessCount=195, AvailableMemoryMB=7036
> 2020-03-12 17:02:06,317 DEBUG [Time-limited test]
> slowlog.TestSlowLogRecorder(111): Initially ringbuffer of Slow Log records is
> empty
> 2020-03-12 17:02:06,326 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,528 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,630 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,732 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:
[
https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058849#comment-17058849
]
Viraj Jasani commented on HBASE-23977:
--
[~stack] Please review [https://github.com/apache/hbase/pull/1286]
I ran flaky tests 30 and 50 times in loop with this patch and all are passed.
The issue seemed mostly due to consumer of ringbuffer being slow (expected), by
the time some events are processed, we expect specific ordered events (which
would be overridden sometimes)
> [Flakey Tests]
> TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97
> expected: but was:
> -
>
> Key: HBASE-23977
> URL: https://issues.apache.org/jira/browse/HBASE-23977
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Michael Stack
>Assignee: Viraj Jasani
>Priority: Major
>
> I see this occasionally on a linux vm. [~vjasani] .. you might have an idea
> why this is going on (this is your test I believe and a recent addition). If
> you have stuff I can try, shout.
> Here is fail:
> {code}
> org.junit.ComparisonFailure: expected: but was:
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.confirmPayloadParams(TestSlowLogRecorder.java:97)
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.testOnlieSlowLogConsumption(TestSlowLogRecorder.java:178)
> {code}
> Here is log:
> {code}
> 2020-03-12 17:02:06,266 INFO [Time-limited test] hbase.ResourceChecker(179):
> after:
> regionserver.slowlog.TestSlowLogRecorder#testOnlineSlowLogWithDisableConfig
> Thread=7 (was 7), OpenFileDescriptor=226 (was 226),
> MaxFileDescriptor=131072 (was 131072), SystemLoadAverage=353 (was 353),
> ProcessCount=195 (was 195), AvailableMemoryMB=7037 (was 7027) -
> AvailableMemoryMB LEAK? -
> 2020-03-12 17:02:06,281 INFO [Time-limited test]
> hbase.ResourceChecker(151): before:
> regionserver.slowlog.TestSlowLogRecorder#testOnlieSlowLogConsumption
> Thread=7, OpenFileDescriptor=226, MaxFileDescriptor=131072,
> SystemLoadAverage=353, ProcessCount=195, AvailableMemoryMB=7036
> 2020-03-12 17:02:06,317 DEBUG [Time-limited test]
> slowlog.TestSlowLogRecorder(111): Initially ringbuffer of Slow Log records is
> empty
> 2020-03-12 17:02:06,326 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,528 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,630 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,732 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani opened a new pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
virajjasani opened a new pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder URL: https://github.com/apache/hbase/pull/1286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23970) TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
[
https://issues.apache.org/jira/browse/HBASE-23970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058842#comment-17058842
]
Nick Dimiduk commented on HBASE-23970:
--
I authenticate myself to a kerberos authority and have a local ticket issued,
then run the test; the test fails. When i forcefully expire said ticket, and
the output of {{klist}} is empty, the test passes.
> TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
>
>
> Key: HBASE-23970
> URL: https://issues.apache.org/jira/browse/HBASE-23970
> Project: HBase
> Issue Type: Test
> Components: security, test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
>
> {{TestUsersOperationsWithSecureHadoop}} makes assumptions about the state of
> the machine environment. When i have an existing ticket issued and active
> (shown via {{klist}}), this test fails. Signing out of all active sessions
> allows the test to again pass.
> {noformat}
> Caused by:
> org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule:
> No rules applied to m...@example.com
> at
> org.apache.hadoop.hbase.security.TestUsersOperationsWithSecureHadoop.testAuthUtilLogin(TestUsersOperationsWithSecureHadoop.java:146)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:
[
https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058838#comment-17058838
]
Michael Stack commented on HBASE-23977:
---
Thank you [~vjasani]. If you want me to try anything, just put up a patch (add
as much debug as you want) and I'll run it here locally on my test machine set.
> [Flakey Tests]
> TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97
> expected: but was:
> -
>
> Key: HBASE-23977
> URL: https://issues.apache.org/jira/browse/HBASE-23977
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Michael Stack
>Assignee: Viraj Jasani
>Priority: Major
>
> I see this occasionally on a linux vm. [~vjasani] .. you might have an idea
> why this is going on (this is your test I believe and a recent addition). If
> you have stuff I can try, shout.
> Here is fail:
> {code}
> org.junit.ComparisonFailure: expected: but was:
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.confirmPayloadParams(TestSlowLogRecorder.java:97)
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.testOnlieSlowLogConsumption(TestSlowLogRecorder.java:178)
> {code}
> Here is log:
> {code}
> 2020-03-12 17:02:06,266 INFO [Time-limited test] hbase.ResourceChecker(179):
> after:
> regionserver.slowlog.TestSlowLogRecorder#testOnlineSlowLogWithDisableConfig
> Thread=7 (was 7), OpenFileDescriptor=226 (was 226),
> MaxFileDescriptor=131072 (was 131072), SystemLoadAverage=353 (was 353),
> ProcessCount=195 (was 195), AvailableMemoryMB=7037 (was 7027) -
> AvailableMemoryMB LEAK? -
> 2020-03-12 17:02:06,281 INFO [Time-limited test]
> hbase.ResourceChecker(151): before:
> regionserver.slowlog.TestSlowLogRecorder#testOnlieSlowLogConsumption
> Thread=7, OpenFileDescriptor=226, MaxFileDescriptor=131072,
> SystemLoadAverage=353, ProcessCount=195, AvailableMemoryMB=7036
> 2020-03-12 17:02:06,317 DEBUG [Time-limited test]
> slowlog.TestSlowLogRecorder(111): Initially ringbuffer of Slow Log records is
> empty
> 2020-03-12 17:02:06,326 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,528 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,630 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,732 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23841) Remove deprecated methods from Scan
[
https://issues.apache.org/jira/browse/HBASE-23841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058780#comment-17058780
]
Jan Hentschel commented on HBASE-23841:
---
[~zhangduo] Already working on resolving the merge conflicts for the open PRs.
> Remove deprecated methods from Scan
> ---
>
> Key: HBASE-23841
> URL: https://issues.apache.org/jira/browse/HBASE-23841
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> Umbrella ticket for handling the deprecations of {{Scan}} for version 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:
[
https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HBASE-23977:
Assignee: Viraj Jasani
> [Flakey Tests]
> TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97
> expected: but was:
> -
>
> Key: HBASE-23977
> URL: https://issues.apache.org/jira/browse/HBASE-23977
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Michael Stack
>Assignee: Viraj Jasani
>Priority: Major
>
> I see this occasionally on a linux vm. [~vjasani] .. you might have an idea
> why this is going on (this is your test I believe and a recent addition). If
> you have stuff I can try, shout.
> Here is fail:
> {code}
> org.junit.ComparisonFailure: expected: but was:
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.confirmPayloadParams(TestSlowLogRecorder.java:97)
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.testOnlieSlowLogConsumption(TestSlowLogRecorder.java:178)
> {code}
> Here is log:
> {code}
> 2020-03-12 17:02:06,266 INFO [Time-limited test] hbase.ResourceChecker(179):
> after:
> regionserver.slowlog.TestSlowLogRecorder#testOnlineSlowLogWithDisableConfig
> Thread=7 (was 7), OpenFileDescriptor=226 (was 226),
> MaxFileDescriptor=131072 (was 131072), SystemLoadAverage=353 (was 353),
> ProcessCount=195 (was 195), AvailableMemoryMB=7037 (was 7027) -
> AvailableMemoryMB LEAK? -
> 2020-03-12 17:02:06,281 INFO [Time-limited test]
> hbase.ResourceChecker(151): before:
> regionserver.slowlog.TestSlowLogRecorder#testOnlieSlowLogConsumption
> Thread=7, OpenFileDescriptor=226, MaxFileDescriptor=131072,
> SystemLoadAverage=353, ProcessCount=195, AvailableMemoryMB=7036
> 2020-03-12 17:02:06,317 DEBUG [Time-limited test]
> slowlog.TestSlowLogRecorder(111): Initially ringbuffer of Slow Log records is
> empty
> 2020-03-12 17:02:06,326 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,528 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,630 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,732 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23977) [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:
[
https://issues.apache.org/jira/browse/HBASE-23977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058771#comment-17058771
]
Viraj Jasani commented on HBASE-23977:
--
Let me take this up. Thanks [~stack]
> [Flakey Tests]
> TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97
> expected: but was:
> -
>
> Key: HBASE-23977
> URL: https://issues.apache.org/jira/browse/HBASE-23977
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Michael Stack
>Priority: Major
>
> I see this occasionally on a linux vm. [~vjasani] .. you might have an idea
> why this is going on (this is your test I believe and a recent addition). If
> you have stuff I can try, shout.
> Here is fail:
> {code}
> org.junit.ComparisonFailure: expected: but was:
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.confirmPayloadParams(TestSlowLogRecorder.java:97)
>at
> org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.testOnlieSlowLogConsumption(TestSlowLogRecorder.java:178)
> {code}
> Here is log:
> {code}
> 2020-03-12 17:02:06,266 INFO [Time-limited test] hbase.ResourceChecker(179):
> after:
> regionserver.slowlog.TestSlowLogRecorder#testOnlineSlowLogWithDisableConfig
> Thread=7 (was 7), OpenFileDescriptor=226 (was 226),
> MaxFileDescriptor=131072 (was 131072), SystemLoadAverage=353 (was 353),
> ProcessCount=195 (was 195), AvailableMemoryMB=7037 (was 7027) -
> AvailableMemoryMB LEAK? -
> 2020-03-12 17:02:06,281 INFO [Time-limited test]
> hbase.ResourceChecker(151): before:
> regionserver.slowlog.TestSlowLogRecorder#testOnlieSlowLogConsumption
> Thread=7, OpenFileDescriptor=226, MaxFileDescriptor=131072,
> SystemLoadAverage=353, ProcessCount=195, AvailableMemoryMB=7036
> 2020-03-12 17:02:06,317 DEBUG [Time-limited test]
> slowlog.TestSlowLogRecorder(111): Initially ringbuffer of Slow Log records is
> empty
> 2020-03-12 17:02:06,326 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,528 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,630 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> 2020-03-12 17:02:06,732 INFO [Time-limited test] hbase.Waiter(183): Waiting
> up to [3,000] milli-secs(wait.for.ratio=[1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23967) Improve the accuracy of the method sizeToString
[
https://issues.apache.org/jira/browse/HBASE-23967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani resolved HBASE-23967.
--
Fix Version/s: 2.2.5
2.1.10
1.7.0
2.3.0
3.0.0
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to master, branch-2's and branch-1. Thanks for the patch [~xu qinya]
> Improve the accuracy of the method sizeToString
> ---
>
> Key: HBASE-23967
> URL: https://issues.apache.org/jira/browse/HBASE-23967
> Project: HBase
> Issue Type: Improvement
>Affects Versions: master
>Reporter: xuqinya
>Assignee: xuqinya
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.1.10, 2.2.5
>
>
> In QuotaSettings，the method of sizeToString reserved integer. But, this is
> not very accurate.
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G',
> POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNERQUOTAS
>
>
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT =>
> 1T, VIOLATION_POLICY => NO_INSERTS
>
> 1 row(s) in 0.0340 seconds
> {code}
> after patch：
> {code:java}
> hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G',
> POLICY => NO_INSERTS
> hbase(main):002:0> list_quotas
> OWNERQUOTAS
>
>
> TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT =>
> 1.95T, VIOLATION_POLICY => NO_INSERTS
> 1 row(s) in 0.0230 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani merged pull request #1273: HBASE-23967 Improve the accuracy of the method sizeToString
virajjasani merged pull request #1273: HBASE-23967 Improve the accuracy of the method sizeToString URL: https://github.com/apache/hbase/pull/1273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
Apache-HBase commented on issue #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#issuecomment-598706498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 11s | master passed | | +1 :green_heart: | compile | 4m 48s | master passed | | +1 :green_heart: | shadedjars | 5m 36s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 22s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 22s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 14s | the patch passed | | +1 :green_heart: | compile | 4m 54s | the patch passed | | +1 :green_heart: | javac | 4m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 38s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 24s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-examples in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 13s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 99m 58s | hbase-server in the patch passed. | | -0 :warning: | unit | 2m 57s | hbase-endpoint in the patch failed. | | +1 :green_heart: | unit | 1m 4s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 3m 5s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 43s | hbase-examples in the patch passed. | | | | 156m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1280 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7cefc4f4cd09 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1b163d98b9 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-endpoint.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1280/3/testReport/ | | Max. process+thread count | 4391 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded
[jira] [Commented] (HBASE-23979) Disable TestSlowLogRecorder until parent addressed
[
https://issues.apache.org/jira/browse/HBASE-23979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058669#comment-17058669
]
Hudson commented on HBASE-23979:
Results for branch master
[build #1665 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1665/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Disable TestSlowLogRecorder until parent addressed
> --
>
> Key: HBASE-23979
> URL: https://issues.apache.org/jira/browse/HBASE-23979
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23978) Dockerfiles reusing stale apt sources info
[
https://issues.apache.org/jira/browse/HBASE-23978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058668#comment-17058668
]
Hudson commented on HBASE-23978:
Results for branch master
[build #1665 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1665/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Dockerfiles reusing stale apt sources info
> --
>
> Key: HBASE-23978
> URL: https://issues.apache.org/jira/browse/HBASE-23978
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We're seeing failed builds on jenkins that look like
> {noformat}
> [2020-03-12T21:27:06.369Z] ---> 368a6d22e8da
> [2020-03-12T21:27:06.369Z] Step 41/62 : RUN DEBIAN_FRONTEND=noninteractive
> apt-get -qq install --no-install-recommends -y bash=4.4.18-2ubuntu1.2
> build-essential=12.4ubuntu1 curl=7.58.0-2ubuntu3.8 diffutils=1:3.6-1
> git=1:2.17.1-1ubuntu0.5 rsync=3.1.2-2.1ubuntu1 tar=1.29b-2ubuntu0.1
> wget=1.19.4-1ubuntu2.2
> [2020-03-12T21:27:12.818Z] ---> Running in fe5d7602e278
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/gcc-7-base_7.4.0-1ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/cpp-7_7.4.0-1ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libcc1-0_8.3.0-6ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libgomp1_8.3.0-6ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libitm1_8.3.0-6ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libatomic1_8.3.0-6ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libasan4_7.4.0-1ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/liblsan0_8.3.0-6ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libtsan0_8.3.0-6ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libubsan0_7.4.0-1ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libcilkrts5_7.4.0-1ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libmpx2_8.3.0-6ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libquadmath0_8.3.0-6ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
> http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libgcc-7-dev_7.4.0-1ubuntu1~18.04.1_amd64.deb
> 404 Not Found [IP: 91.189.88.174 80]
> [2020-03-12T21:27:20.643Z] E: Failed to fetch
>
[jira] [Commented] (HBASE-23077) move entirely to spotbugs
[
https://issues.apache.org/jira/browse/HBASE-23077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058670#comment-17058670
]
Hudson commented on HBASE-23077:
Results for branch master
[build #1665 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1665/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> move entirely to spotbugs
> -
>
> Key: HBASE-23077
> URL: https://issues.apache.org/jira/browse/HBASE-23077
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Sean Busbey
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> we've been relying on spotbugs definitions with findbugs tooling for awhile
> now. I think spotbugs now provides its own versions of everything we need
> (and Yetus supports spotbugs directly).
> Do a pass removing findbugs tooling from all branches in favor of spotbugs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23847) Remove deprecated setStartRow(byte[]) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058671#comment-17058671
]
Hudson commented on HBASE-23847:
Results for branch master
[build #1665 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1665/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove deprecated setStartRow(byte[]) from Scan
> ---
>
> Key: HBASE-23847
> URL: https://issues.apache.org/jira/browse/HBASE-23847
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0
>
>
> {{setStartRow(byte[]}} in {{Scan}} was deprecated back in 2.0.0 and should be
> removed in 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23971) protoc warns: "no protobuf syntax specified"
[
https://issues.apache.org/jira/browse/HBASE-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058667#comment-17058667
]
Hudson commented on HBASE-23971:
Results for branch master
[build #1665 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1665/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1665//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> protoc warns: "no protobuf syntax specified"
>
>
> Key: HBASE-23971
> URL: https://issues.apache.org/jira/browse/HBASE-23971
> Project: HBase
> Issue Type: Task
> Components: Protobufs
>Reporter: Nick Dimiduk
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0
>
>
> This comes up in a couple places.
> {noformat}
> [INFO] --- protobuf-maven-plugin:0.6.1:compile (compile-protoc) @
> hbase-protocol-shaded ---
> [INFO] Compiling 37 proto file(s) to
> /Users/ndimiduk/repos/apache/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java
> [WARNING] PROTOC: [libprotobuf WARNING
> google/protobuf/compiler/parser.cc:546] No syntax specified for the proto
> file: RSGroupAdmin.proto. Please use 'syntax = "proto2";' or 'syntax =
> "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax
> specified for the proto file: RSGroup.proto. Please use 'syntax = "proto2";'
> or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2
> syntax.)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase-connectors] LB-Yu opened a new pull request #63: Solve the ambiguous reference for scala 2.12
LB-Yu opened a new pull request #63: Solve the ambiguous reference for scala 2.12 URL: https://github.com/apache/hbase-connectors/pull/63 When the `hbase-spark` module is compiled under the scala 2.12 environment, the following error appears in line 216 of the `org.apache.hadoop.hbase.spark.datasources.HBaseTableScanRDD` class: ```shell [ERROR] [Error] /path/hbase-connectors/spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/datasources/HBaseTableScanRDD.scala:216: ambiguous reference to overloaded definition, both method addTaskCompletionListener in class TaskContext of type [U](f: org.apache.spark.TaskContext => U)org.apache.spark.TaskContext and method addTaskCompletionListener in class TaskContext of type (listener: org.apache.spark.util.TaskCompletionListener)org.apache.spark.TaskContext match argument types (org.apache.spark.TaskContext => Unit) ``` I solve this bug by changing the origin line: ```scala context.addTaskCompletionListener(context => close()) ``` To: ```scala context.addTaskCompletionListener[Unit](context => close()) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1285: HBASE-23971 protoc warns: "no protobuf syntax specified"
Apache-HBase commented on issue #1285: HBASE-23971 protoc warns: "no protobuf syntax specified" URL: https://github.com/apache/hbase/pull/1285#issuecomment-598683961 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.2 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 11s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 42s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hbaseprotoc | 2m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 28s | hbase-protocol in the patch passed. | | +1 :green_heart: | unit | 2m 57s | hbase-rsgroup in the patch passed. | | +1 :green_heart: | unit | 3m 48s | hbase-endpoint in the patch passed. | | +1 :green_heart: | unit | 5m 31s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 42s | hbase-examples in the patch passed. | | +1 :green_heart: | asflicense | 1m 5s | The patch does not generate ASF License warnings. | | | | 30m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1285/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1285 | | Optional Tests | dupname asflicense cc unit hbaseprotoc prototool | | uname | Linux f8e7501650c5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1285/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 67779d1a32 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1285/1/testReport/ | | Max. process+thread count | 4375 (vs. ulimit of 1) | | modules | C: hbase-protocol hbase-rsgroup hbase-endpoint hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1285/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
