[GitHub] [hbase] Apache-HBase commented on pull request #2364: HBASE-24998 Introduce a ReplicationSourceController interface …
Apache-HBase commented on pull request #2364: URL: https://github.com/apache/hbase/pull/2364#issuecomment-689323965 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 21s | HBASE-24666 passed | | +1 :green_heart: | compile | 1m 38s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 6m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 14s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | compile | 1m 38s | the patch passed | | +1 :green_heart: | javac | 1m 38s | the patch passed | | +1 :green_heart: | shadedjars | 6m 28s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 20s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 0m 26s | hbase-replication in the patch passed. | | -1 :x: | unit | 140m 13s | hbase-server in the patch failed. | | | | 171m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2364 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 62b118e258b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Default Java | 1.8.0_232 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/3/testReport/ | | Max. process+thread count | (vs. ulimit of 12500) | | modules | C: hbase-common hbase-replication hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2367: HBASE-24994 Add hedgedReadOpsInCurThread metric
Apache-HBase commented on pull request #2367: URL: https://github.com/apache/hbase/pull/2367#issuecomment-689323956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 30s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 4s | branch-2 passed | | +0 :ok: | refguide | 7m 0s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotbugs | 10m 47s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 13s | the patch passed | | -0 :warning: | checkstyle | 2m 3s | root: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 6m 54s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 11m 36s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 11m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. | | | | 69m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2367/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2367 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide | | uname | Linux 424024f415d0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 6a05eaf7d5 | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2367/1/artifact/yetus-general-check/output/branch-site/book.html | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2367/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2367/1/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2367/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24995) MetaFixer fails to fix overlaps when multiple tables have overlaps
[ https://issues.apache.org/jira/browse/HBASE-24995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192632#comment-17192632 ] Mohammad Arshad commented on HBASE-24995: - Thanks [~stack] for reviewing and merging the fix. > MetaFixer fails to fix overlaps when multiple tables have overlaps > -- > > Key: HBASE-24995 > URL: https://issues.apache.org/jira/browse/HBASE-24995 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > MetaFixer fails to fix overlaps when multiple tables have overlaps > *Steps to reproduce from UT.* > # Create table t1 and t2 with split keys, ["bbb", "ccc", "ddd", "eee"] > # Create extra region in both t1 and t2 with start key "bbb" and end key "ddd" > # Run catalog janitor, It will report total 4 overlaps, 2 from each table. > # Run MetaFixer, wait for merges to finish. > # Run the catalog janitor again and verify report, there should not be any > overlap > # Overlap still exists. Reproduced!!! > *Analysis.* > * When I run the same scenario for just one table t1, overlaps are fixed > successfully. > * Seems problem with MetaFixer#calculateMerges. > * I think merges should be calculated within a table. Across the table merge > does not have significance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] arshadmohammad commented on a change in pull request #2361: HBASE-24995: MetaFixer fails to fix overlaps when multiple tables hav…
arshadmohammad commented on a change in pull request #2361:
URL: https://github.com/apache/hbase/pull/2361#discussion_r485344280
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
##
@@ -231,16 +235,18 @@ private static RegionInfo buildRegionInfo(TableName tn,
byte [] start, byte [] e
/**
* Fix overlaps noted in CJ consistency report.
*/
- void fixOverlaps(CatalogJanitor.Report report) throws IOException {
+ List fixOverlaps(CatalogJanitor.Report report) throws IOException {
+List pidList = new ArrayList<>();
Review comment:
Yes, to make the fix more testable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-24950) Another solution for Splittable Meta
[ https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24950: -- Summary: Another solution for Splittable Meta (was: Alternate solution for Splittable Meta) > Another solution for Splittable Meta > > > Key: HBASE-24950 > URL: https://issues.apache.org/jira/browse/HBASE-24950 > Project: HBase > Issue Type: Umbrella > Components: meta, Region Assignment >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > For implementing splittable meta with a master local region to store the > 'root table'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-689305595 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 40s | master passed | | +1 :green_heart: | compile | 1m 23s | master passed | | +1 :green_heart: | shadedjars | 7m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 58s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | compile | 1m 24s | the patch passed | | +1 :green_heart: | javac | 1m 24s | the patch passed | | +1 :green_heart: | shadedjars | 6m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 3s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 140m 32s | hbase-server in the patch passed. | | | | 171m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1994 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e80ef5c24774 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e96a5b2d3 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/2/testReport/ | | Max. process+thread count | 5004 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25002) Create simple pattern matching query for retrieving metrics matching the pattern
[ https://issues.apache.org/jira/browse/HBASE-25002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-25002: --- Description: Currently we allow querying a metric with a specific metric name. But generally say under the MBean sub=Tables under a server we might have 'n' number of tables and we might be interested in a specific metric across all tables. So in such cases giving a simple pattern based query will help so that we can retrieve all metrics that follow that pattern. The other side effect is that we can also reduce the size of the json we pull from the server to the querying client. Which are generally smaller scripts which might not be able to process the big sized response JSON. Thanks [~anoopsamjohn] for the suggestion. was: Currently we allow querying a metric with a specific metric name. But generally say under the MBean sub=Tables under a server we might have 'n' number of tables and we might be interested in a specific metric across all tables. So in such cases giving a simple pattern based query will help so that we can retrieve all metrics that follow that pattern. The other side effect is that we can also reduce the size of the json we pull from the server to the querying client. Which are generally smaller scripts which might not be able to process the big sized response JSON. > Create simple pattern matching query for retrieving metrics matching the > pattern > > > Key: HBASE-25002 > URL: https://issues.apache.org/jira/browse/HBASE-25002 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.5 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.6 > > > Currently we allow querying a metric with a specific metric name. But > generally say under the MBean sub=Tables under a server we might have 'n' > number of tables and we might be interested in a specific metric across all > tables. > So in such cases giving a simple pattern based query will help so that we can > retrieve all metrics that follow that pattern. > The other side effect is that we can also reduce the size of the json we pull > from the server to the querying client. Which are generally smaller scripts > which might not be able to process the big sized response JSON. > Thanks [~anoopsamjohn] for the suggestion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25002) Create simple pattern matching query for retrieving metrics matching the pattern
ramkrishna.s.vasudevan created HBASE-25002: -- Summary: Create simple pattern matching query for retrieving metrics matching the pattern Key: HBASE-25002 URL: https://issues.apache.org/jira/browse/HBASE-25002 Project: HBase Issue Type: Improvement Affects Versions: 2.2.5 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.6 Currently we allow querying a metric with a specific metric name. But generally say under the MBean sub=Tables under a server we might have 'n' number of tables and we might be interested in a specific metric across all tables. So in such cases giving a simple pattern based query will help so that we can retrieve all metrics that follow that pattern. The other side effect is that we can also reduce the size of the json we pull from the server to the querying client. Which are generally smaller scripts which might not be able to process the big sized response JSON. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2360: HBASE-24982 Disassemble the method replicateWALEntry from AdminServic…
Apache-HBase commented on pull request #2360: URL: https://github.com/apache/hbase/pull/2360#issuecomment-689304292 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 28s | HBASE-24666 passed | | +1 :green_heart: | compile | 2m 25s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 6m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 29s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 2m 27s | the patch passed | | +1 :green_heart: | javac | 2m 27s | the patch passed | | +1 :green_heart: | shadedjars | 6m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 46s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 4s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 26s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 141m 20s | hbase-server in the patch passed. | | | | 176m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2360 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux aa834864deaf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/testReport/ | | Max. process+thread count | 4314 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24994) Add hedgedReadOpsInCurThread metric
[ https://issues.apache.org/jira/browse/HBASE-24994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192627#comment-17192627 ] Javier Akira Luca de Tena commented on HBASE-24994: --- branch-1: [https://github.com/apache/hbase/pull/2368] branch-2: [https://github.com/apache/hbase/pull/2367] > Add hedgedReadOpsInCurThread metric > --- > > Key: HBASE-24994 > URL: https://issues.apache.org/jira/browse/HBASE-24994 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Javier Akira Luca de Tena >Assignee: Javier Akira Luca de Tena >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > When adding Hedged Reads metrics at > https://issues.apache.org/jira/browse/HBASE-12220, hedgedReadOpsInCurThread > was not included. > I wonder if there was any reason to not include them. If not, I will provide > pull request to include them soon. > > Hedged reads use same thread pool for the original read: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1349-L1357] > When the executor is full and rejects the task, it will be executed in > current thread, increasing this metric: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java#L2913-L2918] > This metric is very useful to determine if the hedged reads thread pool > (dfs.client.hedged.read.threadpool.size) is undersized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2360: HBASE-24982 Disassemble the method replicateWALEntry from AdminServic…
Apache-HBase commented on pull request #2360: URL: https://github.com/apache/hbase/pull/2360#issuecomment-689302627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 57s | HBASE-24666 passed | | +1 :green_heart: | compile | 2m 51s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in HBASE-24666 failed. | | -0 :warning: | javadoc | 0m 16s | hbase-replication in HBASE-24666 failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in HBASE-24666 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 2m 48s | the patch passed | | +1 :green_heart: | javac | 2m 48s | the patch passed | | +1 :green_heart: | shadedjars | 6m 35s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-replication in the patch failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 58s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 134m 5s | hbase-server in the patch passed. | | | | 170m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2360 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a2ba5316efc5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-replication.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-replication.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/testReport/ | | Max. process+thread count | 4204 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] javierluca opened a new pull request #2368: HBASE-24994 Add hedgedReadOpsInCurThread metric
javierluca opened a new pull request #2368: URL: https://github.com/apache/hbase/pull/2368 https://issues.apache.org/jira/browse/HBASE-24994 master PR (merged): #2365 branch-2 PR: https://github.com/apache/hbase/pull/2367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[
https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192625#comment-17192625
]
Michael Stack commented on HBASE-24950:
---
{quote}Yes, in the design doc for HBASE-11288.
{quote}
I had the impression that you abandoned HBASE-11288 and came here to do an
'alternate solution'. I would not expect to find the description of this
'alternate solution' over in the Jira in which this issue is an alternate too;
I would expect to find it here.
On the rest, you are just messing with me.
> Alternate solution for Splittable Meta
> --
>
> Key: HBASE-24950
> URL: https://issues.apache.org/jira/browse/HBASE-24950
> Project: HBase
> Issue Type: Umbrella
> Components: meta, Region Assignment
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> For implementing splittable meta with a master local region to store the
> 'root table'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] javierluca opened a new pull request #2367: HBASE-24994 Add hedgedReadOpsInCurThread metric
javierluca opened a new pull request #2367: URL: https://github.com/apache/hbase/pull/2367 https://issues.apache.org/jira/browse/HBASE-24994 master PR (merged): https://github.com/apache/hbase/pull/2365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24606) Implement meta merge
[ https://issues.apache.org/jira/browse/HBASE-24606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24606. --- Fix Version/s: HBASE-24950 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch HBASE-24950. Thanks [~zghao] for reviewing. > Implement meta merge > > > Key: HBASE-24606 > URL: https://issues.apache.org/jira/browse/HBASE-24606 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: HBASE-24950 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #2311: HBASE-24606 Implement meta merge
Apache9 merged pull request #2311: URL: https://github.com/apache/hbase/pull/2311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24993) Remove OfflineMetaRebuildTestCore
[ https://issues.apache.org/jira/browse/HBASE-24993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24993: -- Fix Version/s: 2.4.0 > Remove OfflineMetaRebuildTestCore > - > > Key: HBASE-24993 > URL: https://issues.apache.org/jira/browse/HBASE-24993 > Project: HBase > Issue Type: Task > Components: test >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > Maybe it is used to test HBCK but is useless now. Let's remove it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[
https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192616#comment-17192616
]
Duo Zhang commented on HBASE-24950:
---
Yes, in the design doc for HBASE-11288.
{quote}
The design is not for 'me'.
{quote}
I do not get your point here. I said we already have a design doc. You said it
is unfinished, then I asked what you want to know, i.e, what is the missing
part. Is this question offend you or? I really can not understand why you keep
refusing to answer the question. To be honest, your answers here do not help
anything, I just got nothing input here.
I sincerely ask again, please give some positive advices? If you still keep
saying the same words, the only way for me is to just ignore your comments here.
Thanks.
> Alternate solution for Splittable Meta
> --
>
> Key: HBASE-24950
> URL: https://issues.apache.org/jira/browse/HBASE-24950
> Project: HBase
> Issue Type: Umbrella
> Components: meta, Region Assignment
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> For implementing splittable meta with a master local region to store the
> 'root table'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[
https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192610#comment-17192610
]
Michael Stack commented on HBASE-24950:
---
{quote}I've added a Implementation section in the design doc. Could you please
see if it could help?
{quote}
The one on HBASE-11288?
{quote}But at least you can tell me what you want to know?
{quote}
The design is not for 'me'.
{quote}Please do not just tell me you just want a design doc, that's really not
help...
{quote}
I have not told you anything. I just asked a question.
> Alternate solution for Splittable Meta
> --
>
> Key: HBASE-24950
> URL: https://issues.apache.org/jira/browse/HBASE-24950
> Project: HBase
> Issue Type: Umbrella
> Components: meta, Region Assignment
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> For implementing splittable meta with a master local region to store the
> 'root table'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2364: HBASE-24998 Introduce a ReplicationSourceController interface …
Apache-HBase commented on pull request #2364: URL: https://github.com/apache/hbase/pull/2364#issuecomment-689282310 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 49s | HBASE-24666 passed | | +1 :green_heart: | checkstyle | 1m 43s | HBASE-24666 passed | | +1 :green_heart: | spotbugs | 3m 13s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 48s | the patch passed | | -0 :warning: | checkstyle | 1m 9s | hbase-server: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 24s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. | | | | 42m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2364 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 3b14ed64d217 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-replication hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[ https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192600#comment-17192600 ] Duo Zhang commented on HBASE-24950: --- But at least you can tell me what you want to know? Please do not just tell me you just want a design doc, that's really not help... Thanks. > Alternate solution for Splittable Meta > -- > > Key: HBASE-24950 > URL: https://issues.apache.org/jira/browse/HBASE-24950 > Project: HBase > Issue Type: Umbrella > Components: meta, Region Assignment >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > For implementing splittable meta with a master local region to store the > 'root table'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[ https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192599#comment-17192599 ] Duo Zhang commented on HBASE-24950: --- I've added a Implementation section in the design doc. Could you please see if it could help? Thanks. > Alternate solution for Splittable Meta > -- > > Key: HBASE-24950 > URL: https://issues.apache.org/jira/browse/HBASE-24950 > Project: HBase > Issue Type: Umbrella > Components: meta, Region Assignment >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > For implementing splittable meta with a master local region to store the > 'root table'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[
https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192598#comment-17192598
]
Michael Stack commented on HBASE-24950:
---
{quote}To me, the discussion is like this
{quote}
The discussion here so far is not as you represent it. Rather:
I asked if you were going to put up a design here.
You reply, don't we have a design already?
I say no, we do not. We have the start of a design on HBASE-11288.
Unfortunately it stalled on a design point. Unfinished.
I cannot tell you what to write in your design doc because the design is yours,
not mine.
> Alternate solution for Splittable Meta
> --
>
> Key: HBASE-24950
> URL: https://issues.apache.org/jira/browse/HBASE-24950
> Project: HBase
> Issue Type: Umbrella
> Components: meta, Region Assignment
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> For implementing splittable meta with a master local region to store the
> 'root table'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-25001) Backport HBASE-16283 to branch-1
wenbang created HBASE-25001: --- Summary: Backport HBASE-16283 to branch-1 Key: HBASE-25001 URL: https://issues.apache.org/jira/browse/HBASE-25001 Project: HBase Issue Type: Bug Affects Versions: 1.4.13, 1.5.0 Reporter: wenbang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24994) Add hedgedReadOpsInCurThread metric
[ https://issues.apache.org/jira/browse/HBASE-24994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192595#comment-17192595 ] Javier Akira Luca de Tena commented on HBASE-24994: --- Thank you! Will do very soon. > Add hedgedReadOpsInCurThread metric > --- > > Key: HBASE-24994 > URL: https://issues.apache.org/jira/browse/HBASE-24994 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Javier Akira Luca de Tena >Assignee: Javier Akira Luca de Tena >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > When adding Hedged Reads metrics at > https://issues.apache.org/jira/browse/HBASE-12220, hedgedReadOpsInCurThread > was not included. > I wonder if there was any reason to not include them. If not, I will provide > pull request to include them soon. > > Hedged reads use same thread pool for the original read: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1349-L1357] > When the executor is full and rejects the task, it will be executed in > current thread, increasing this metric: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java#L2913-L2918] > This metric is very useful to determine if the hedged reads thread pool > (dfs.client.hedged.read.threadpool.size) is undersized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24979) Include batch mutatations in client operation timeout tests
[ https://issues.apache.org/jira/browse/HBASE-24979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192593#comment-17192593 ] Guanghao Zhang commented on HBASE-24979: Please wait me roll a new RC. Thanks. > Include batch mutatations in client operation timeout tests > --- > > Key: HBASE-24979 > URL: https://issues.apache.org/jira/browse/HBASE-24979 > Project: HBase > Issue Type: Test >Affects Versions: 1.7.0, 2.4.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2 > > > While put, get and scan operations are included in client operation timeout > test, we should also include batch requests. batch() has different way of > handling operation timeout by passing it to AsyncProcessTask and then waiting > on async future response. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24992) log after Generator success when running ITBLL
[ https://issues.apache.org/jira/browse/HBASE-24992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24992: --- Fix Version/s: 2.4.0 > log after Generator success when running ITBLL > -- > > Key: HBASE-24992 > URL: https://issues.apache.org/jira/browse/HBASE-24992 > Project: HBase > Issue Type: Improvement >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Trivial > Fix For: 3.0.0-alpha-1, 2.4.0 > > > When I was running ITBLL, there is no output after the Generator finished. We > should log this just as the verify stage. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[
https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192589#comment-17192589
]
Duo Zhang commented on HBASE-24950:
---
To me, the discussion is like this
{noformat}
Please provide a design doc.
I already posted the design doc?
It is not a design doc.
Then what you want to know?
You should know what should be in a design doc.
{noformat}
Dang. I do not know what to do here...
Please treat me like an idiot, please. Just tell me what to write in the design
doc. I'm really confused here...
> Alternate solution for Splittable Meta
> --
>
> Key: HBASE-24950
> URL: https://issues.apache.org/jira/browse/HBASE-24950
> Project: HBase
> Issue Type: Umbrella
> Components: meta, Region Assignment
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> For implementing splittable meta with a master local region to store the
> 'root table'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2360: HBASE-24982 Disassemble the method replicateWALEntry from AdminServic…
Apache-HBase commented on pull request #2360: URL: https://github.com/apache/hbase/pull/2360#issuecomment-689271341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 7s | HBASE-24666 passed | | +1 :green_heart: | checkstyle | 1m 59s | HBASE-24666 passed | | +1 :green_heart: | spotbugs | 7m 13s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 50s | the patch passed | | +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-protocol-shaded | | +1 :green_heart: | checkstyle | 0m 29s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-replication | | +1 :green_heart: | checkstyle | 1m 15s | hbase-server: The patch generated 0 new + 45 unchanged - 2 fixed = 45 total (was 47) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 55s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 55s | the patch passed | | +1 :green_heart: | spotbugs | 9m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. | | | | 59m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2360 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux d64d22924190 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[
https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192584#comment-17192584
]
Michael Stack commented on HBASE-24950:
---
{quote}We already have a design doc for both solutions?
{quote}
Nah. Whats attached to HBASE-11288 got stuck on a decision point and then made
no more progress. Doesn't describe either approach. Unfinished.
{quote}To be honest I'm not usre what you want to know.
{quote}
Not about me (though I did ask a question above).
On why generally design ahead of impl., easy to find whys/benefits (I linked
one from google engs to HBASE-11288). Maybe you just doing w/o?
> Alternate solution for Splittable Meta
> --
>
> Key: HBASE-24950
> URL: https://issues.apache.org/jira/browse/HBASE-24950
> Project: HBase
> Issue Type: Umbrella
> Components: meta, Region Assignment
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> For implementing splittable meta with a master local region to store the
> 'root table'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-689267586 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 47s | master passed | | +1 :green_heart: | checkstyle | 1m 33s | master passed | | +1 :green_heart: | spotbugs | 2m 57s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | checkstyle | 1m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 14s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. | | | | 37m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1994 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 2c3163c37a4c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e96a5b2d3 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #2364: HBASE-24998 Introduce a ReplicationSourceOverallController interface …
infraio commented on a change in pull request #2364:
URL: https://github.com/apache/hbase/pull/2364#discussion_r485303630
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RecoveredReplicationSource.java
##
@@ -45,18 +46,15 @@
private static final Logger LOG =
LoggerFactory.getLogger(RecoveredReplicationSource.class);
- private Path walDir;
-
private String actualPeerId;
@Override
- public void init(Configuration conf, FileSystem fs, Path walDir,
ReplicationSourceManager manager,
-ReplicationQueueStorage queueStorage, ReplicationPeer replicationPeer,
Server server,
-String peerClusterZnode, UUID clusterId, WALFileLengthProvider
walFileLengthProvider,
-MetricsSource metrics) throws IOException {
-super.init(conf, fs, walDir, manager, queueStorage, replicationPeer,
server, peerClusterZnode,
- clusterId, walFileLengthProvider, metrics);
-this.walDir = walDir;
+ public void init(Configuration conf, FileSystem fs, Path walDir,
+ReplicationSourceOverallController overallController,
ReplicationQueueStorage queueStorage,
Review comment:
Yes. Only one ReplicationSourceManager and only one Controller, too.
Only pass Controller to ReplicationSource. Then decouple
ReplicationSourceManager and ReplicationSource.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #2364: HBASE-24998 Introduce a ReplicationSourceOverallController interface …
infraio commented on a change in pull request #2364:
URL: https://github.com/apache/hbase/pull/2364#discussion_r485303114
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationSourceOverallController.java
##
@@ -0,0 +1,31 @@
+package org.apache.hadoop.hbase.replication;
+
+import
org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationGlobalSourceSource;
+import
org.apache.hadoop.hbase.replication.regionserver.RecoveredReplicationSource;
+import org.apache.yetus.audience.InterfaceAudience;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+/**
+ * Used to control all replication sources inside one RegionServer or
ReplicationServer.
+ * Used by {@link ReplicationSource} or {@link RecoveredReplicationSource}.
+ */
+@InterfaceAudience.Private
+public interface ReplicationSourceOverallController {
+
+ /**
+ * Returns the maximum size in bytes of edits held in memory which are
pending replication
+ * across all sources inside this RegionServer or ReplicationServer.
+ */
+ long getTotalBufferLimit();
Review comment:
This was copied from the ReplicationSourceManager. And it is the total
limit, not the currently size.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #2364: HBASE-24998 Introduce a ReplicationSourceOverallController interface …
infraio commented on a change in pull request #2364:
URL: https://github.com/apache/hbase/pull/2364#discussion_r485303149
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationSourceOverallController.java
##
@@ -0,0 +1,31 @@
+package org.apache.hadoop.hbase.replication;
+
+import
org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationGlobalSourceSource;
+import
org.apache.hadoop.hbase.replication.regionserver.RecoveredReplicationSource;
+import org.apache.yetus.audience.InterfaceAudience;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+/**
+ * Used to control all replication sources inside one RegionServer or
ReplicationServer.
+ * Used by {@link ReplicationSource} or {@link RecoveredReplicationSource}.
+ */
+@InterfaceAudience.Private
+public interface ReplicationSourceOverallController {
+
+ /**
+ * Returns the maximum size in bytes of edits held in memory which are
pending replication
+ * across all sources inside this RegionServer or ReplicationServer.
+ */
+ long getTotalBufferLimit();
+
+ AtomicLong getTotalBufferUsed();
+
+ MetricsReplicationGlobalSourceSource getGlobalMetrics();
Review comment:
Yes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #2364: HBASE-24998 Introduce a ReplicationSourceOverallController interface …
infraio commented on a change in pull request #2364: URL: https://github.com/apache/hbase/pull/2364#discussion_r485302618 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -979,6 +979,8 @@ /* * cluster replication constants. */ + public static final String REPLICATION_OFFLOAD_ENABLE_KEY = "hbase.replication.offload.enabled"; + public static final boolean REPLICATION_OFFLOAD_ENABLE_DEFAULT = false; Review comment: In the next patches, this may be used in other place, too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] ZhaoBQ commented on a change in pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
ZhaoBQ commented on a change in pull request #75:
URL:
https://github.com/apache/hbase-operator-tools/pull/75#discussion_r485298853
##
File path: hbase-tools/src/test/java/org/apache/hbase/TestRegionsMerger.java
##
@@ -132,6 +138,27 @@ public void testMergeRegionsInvalidParams() throws
Exception {
originalCount, TEST_UTIL.countRows(table));
}
+ @Test
+ public void testRegionHasNoState() throws Exception {
+// Turn on the replication of the table, and then merge two regions, the
parent regions will
+// not have the column info:state in the meta table, only the column
+// rep_barrier:seqnumDuringOpen is left. And we should skip the parent
regions.
+TableDescriptor tableDesc = TEST_UTIL.getAdmin().getDescriptor(TABLE_NAME);
+
TEST_UTIL.getAdmin().modifyTable(TableDescriptorBuilder.newBuilder(tableDesc).
Review comment:
Yes, I only found that after setting replication scope, there will be
regions without info:state in meta.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (HBASE-24993) Remove OfflineMetaRebuildTestCore
[ https://issues.apache.org/jira/browse/HBASE-24993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin resolved HBASE-24993. -- Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed > Remove OfflineMetaRebuildTestCore > - > > Key: HBASE-24993 > URL: https://issues.apache.org/jira/browse/HBASE-24993 > Project: HBase > Issue Type: Task > Components: test >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Major > Fix For: 3.0.0-alpha-1 > > > Maybe it is used to test HBCK but is useless now. Let's remove it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[ https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192565#comment-17192565 ] Duo Zhang commented on HBASE-24950: --- We already have a design doc for both solutions? To be honest I'm not usre what you want to know. Maybe just show your questions and I will answer them, then maybe I will know what you want me to write up on the design doc. Thanks. > Alternate solution for Splittable Meta > -- > > Key: HBASE-24950 > URL: https://issues.apache.org/jira/browse/HBASE-24950 > Project: HBase > Issue Type: Umbrella > Components: meta, Region Assignment >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > For implementing splittable meta with a master local region to store the > 'root table'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #2359: HBASE-24993 Remove OfflineMetaRebuildTestCore
Apache9 merged pull request #2359: URL: https://github.com/apache/hbase/pull/2359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24994) Add hedgedReadOpsInCurThread metric
[ https://issues.apache.org/jira/browse/HBASE-24994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192564#comment-17192564 ] Duo Zhang commented on HBASE-24994: --- Merged to master. Please open new PRS against other branches. Thanks [~akiraluca]. > Add hedgedReadOpsInCurThread metric > --- > > Key: HBASE-24994 > URL: https://issues.apache.org/jira/browse/HBASE-24994 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Javier Akira Luca de Tena >Assignee: Javier Akira Luca de Tena >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > When adding Hedged Reads metrics at > https://issues.apache.org/jira/browse/HBASE-12220, hedgedReadOpsInCurThread > was not included. > I wonder if there was any reason to not include them. If not, I will provide > pull request to include them soon. > > Hedged reads use same thread pool for the original read: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1349-L1357] > When the executor is full and rejects the task, it will be executed in > current thread, increasing this metric: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java#L2913-L2918] > This metric is very useful to determine if the hedged reads thread pool > (dfs.client.hedged.read.threadpool.size) is undersized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #2365: HBASE-24994 Add hedgedReadOpsInCurThread metric
Apache9 merged pull request #2365: URL: https://github.com/apache/hbase/pull/2365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24994) Add hedgedReadOpsInCurThread metric
[ https://issues.apache.org/jira/browse/HBASE-24994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24994: -- Fix Version/s: (was: 2.4.0) > Add hedgedReadOpsInCurThread metric > --- > > Key: HBASE-24994 > URL: https://issues.apache.org/jira/browse/HBASE-24994 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Javier Akira Luca de Tena >Assignee: Javier Akira Luca de Tena >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > When adding Hedged Reads metrics at > https://issues.apache.org/jira/browse/HBASE-12220, hedgedReadOpsInCurThread > was not included. > I wonder if there was any reason to not include them. If not, I will provide > pull request to include them soon. > > Hedged reads use same thread pool for the original read: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1349-L1357] > When the executor is full and rejects the task, it will be executed in > current thread, increasing this metric: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java#L2913-L2918] > This metric is very useful to determine if the hedged reads thread pool > (dfs.client.hedged.read.threadpool.size) is undersized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24994) Add hedgedReadOpsInCurThread metric
[ https://issues.apache.org/jira/browse/HBASE-24994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24994: -- Fix Version/s: 2.4.0 3.0.0-alpha-1 > Add hedgedReadOpsInCurThread metric > --- > > Key: HBASE-24994 > URL: https://issues.apache.org/jira/browse/HBASE-24994 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Javier Akira Luca de Tena >Assignee: Javier Akira Luca de Tena >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > When adding Hedged Reads metrics at > https://issues.apache.org/jira/browse/HBASE-12220, hedgedReadOpsInCurThread > was not included. > I wonder if there was any reason to not include them. If not, I will provide > pull request to include them soon. > > Hedged reads use same thread pool for the original read: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1349-L1357] > When the executor is full and rejects the task, it will be executed in > current thread, increasing this metric: > > [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java#L2913-L2918] > This metric is very useful to determine if the hedged reads thread pool > (dfs.client.hedged.read.threadpool.size) is undersized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] javierluca commented on pull request #2365: HBASE-24994 Add hedgedReadOpsInCurThread metric
javierluca commented on pull request #2365: URL: https://github.com/apache/hbase/pull/2365#issuecomment-689243780 It seems that failed Tests below are not related to this patch. (and not reproduced in my local test) | Test name | Duration | Age | | - | - | - | | precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor5.testScanMetrics[1] | 8.6 sec | 1 | | precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot. | 0.26 sec | 1 | | precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot. | 0.25 sec | 1 | @Apache9 Could you take a look at this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] javierluca edited a comment on pull request #2365: HBASE-24994 Add hedgedReadOpsInCurThread metric
javierluca edited a comment on pull request #2365: URL: https://github.com/apache/hbase/pull/2365#issuecomment-689243780 It seems that failed Tests below are not related to this patch. (and not reproduced in my local test) https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/testReport/ | Test name | Duration | Age | | - | - | - | | precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor5.testScanMetrics[1] | 8.6 sec | 1 | | precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot. | 0.26 sec | 1 | | precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot. | 0.25 sec | 1 | @Apache9 Could you take a look at this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] javierluca removed a comment on pull request #2365: HBASE-24994 Add hedgedReadOpsInCurThread metric
javierluca removed a comment on pull request #2365: URL: https://github.com/apache/hbase/pull/2365#issuecomment-689240094 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] javierluca commented on pull request #2365: HBASE-24994 Add hedgedReadOpsInCurThread metric
javierluca commented on pull request #2365: URL: https://github.com/apache/hbase/pull/2365#issuecomment-689240094 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.
infraio commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r485272081
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##
@@ -968,6 +968,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ private void takeUserRegionLock() throws IOException {
+try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
+ if (!userRegionLock.tryLock(waitTime, TimeUnit.MILLISECONDS)) {
Review comment:
bq. There is one retry loop here which will retry if exception is not
TNFE or retries are not exhausted.
Please check the code. The LockTimeoutException will be throwed out and
terminate the loop. It is not in the try...catch code block.
bq. IIUC the code, callable.prepare will never throw LockTimeoutException.
callable.prepare will call locateRegionInMeta inside. So locateRegionInMeta
throw LockTimeoutException, then it will throw this exception out.
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24602) Add Increment and Append support to CheckAndMutate
[
https://issues.apache.org/jira/browse/HBASE-24602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192546#comment-17192546
]
Hudson commented on HBASE-24602:
Results for branch master
[build #38 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add Increment and Append support to CheckAndMutate
> --
>
> Key: HBASE-24602
> URL: https://issues.apache.org/jira/browse/HBASE-24602
> Project: HBase
> Issue Type: New Feature
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Currently, CheckAndMutate supports only Put and Delete. Supporting Increment
> and Append would be helpful for some use cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24992) log after Generator success when running ITBLL
[
https://issues.apache.org/jira/browse/HBASE-24992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192545#comment-17192545
]
Hudson commented on HBASE-24992:
Results for branch master
[build #38 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> log after Generator success when running ITBLL
> --
>
> Key: HBASE-24992
> URL: https://issues.apache.org/jira/browse/HBASE-24992
> Project: HBase
> Issue Type: Improvement
>Reporter: Junhong Xu
>Assignee: Junhong Xu
>Priority: Trivial
> Fix For: 3.0.0-alpha-1
>
>
> When I was running ITBLL, there is no output after the Generator finished. We
> should log this just as the verify stage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24979) Include batch mutatations in client operation timeout tests
[
https://issues.apache.org/jira/browse/HBASE-24979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192547#comment-17192547
]
Hudson commented on HBASE-24979:
Results for branch master
[build #38 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/38//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Include batch mutatations in client operation timeout tests
> ---
>
> Key: HBASE-24979
> URL: https://issues.apache.org/jira/browse/HBASE-24979
> Project: HBase
> Issue Type: Test
>Affects Versions: 1.7.0, 2.4.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2
>
>
> While put, get and scan operations are included in client operation timeout
> test, we should also include batch requests. batch() has different way of
> handling operation timeout by passing it to AsyncProcessTask and then waiting
> on async future response.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978 with subtasks & HBASE-24718 to branch-1
Apache-HBase commented on pull request #2312: URL: https://github.com/apache/hbase/pull/2312#issuecomment-689190018 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 2m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 9s | branch-1 passed | | +1 :green_heart: | compile | 1m 48s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.7.0_272 | | +1 :green_heart: | checkstyle | 12m 34s | branch-1 passed | | +0 :ok: | refguide | 4m 9s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 3m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 35s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 6m 2s | branch-1 passed with JDK v1.7.0_272 | | +0 :ok: | spotbugs | 2m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 19m 13s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 3s | the patch passed | | +1 :green_heart: | compile | 1m 48s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | cc | 1m 48s | the patch passed | | +1 :green_heart: | javac | 1m 48s | the patch passed | | +1 :green_heart: | compile | 1m 57s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | cc | 1m 57s | the patch passed | | -1 :x: | javac | 1m 57s | root-jdk1.7.0_272 with JDK v1.7.0_272 generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154) | | -1 :x: | checkstyle | 0m 47s | hbase-client: The patch generated 1 new + 628 unchanged - 0 fixed = 629 total (was 628) | | -1 :x: | checkstyle | 1m 52s | hbase-server: The patch generated 6 new + 524 unchanged - 0 fixed = 530 total (was 524) | | -1 :x: | checkstyle | 6m 16s | root: The patch generated 7 new + 1161 unchanged - 0 fixed = 1168 total (was 1161) | | -1 :x: | rubocop | 0m 15s | The patch generated 19 new + 829 unchanged - 1 fixed = 848 total (was 830) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 2 ill-formed XML file(s). | | +0 :ok: | refguide | 3m 12s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 3m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 51s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | hbaseprotoc | 4m 32s | the patch passed | | +1 :green_heart: | javadoc | 3m 39s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 5m 55s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | findbugs | 20m 32s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 175m 47s | root in the patch failed. | | +1 :green_heart: | asflicense | 2m 10s | The patch does not generate ASF License warnings. | | | | 323m 25s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | hbase-common/src/main/resources/hbase-default.xml | | | hbase-protocol/pom.xml | | Failed junit tests | hadoop.hbase.procedure.TestFailedProcCleanup | | | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2312/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2312 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool
[GitHub] [hbase] Apache-HBase commented on pull request #2357: HBASE-24991 Replace MovedRegionsCleaner with guava cache
Apache-HBase commented on pull request #2357: URL: https://github.com/apache/hbase/pull/2357#issuecomment-689160960 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 33s | master passed | | +1 :green_heart: | compile | 1m 8s | master passed | | +1 :green_heart: | shadedjars | 7m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 7m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 206m 32s | hbase-server in the patch failed. | | | | 236m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2357 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6116cadc902a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/testReport/ | | Max. process+thread count | 2918 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-689159519 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | compile | 1m 27s | master passed | | +1 :green_heart: | shadedjars | 7m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 3s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | +1 :green_heart: | shadedjars | 7m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 21s | hbase-client in the patch passed. | | -1 :x: | unit | 218m 23s | hbase-server in the patch failed. | | | | 251m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1994 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3c40f87f011c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/testReport/ | | Max. process+thread count | 3406 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.
shahrs87 commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r485216698
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##
@@ -968,6 +968,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ private void takeUserRegionLock() throws IOException {
+try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
+ if (!userRegionLock.tryLock(waitTime, TimeUnit.MILLISECONDS)) {
Review comment:
> If callable.prepare throw the LockTimeoutException,
IIUC the code, callable.prepare will never throw LockTimeoutException. We
throw LockTimeoutException
[here](https://github.com/apache/hbase/blob/f3210c8908809fa154118454e6a23f57bc222db1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L866)
At this place we haven't created ReversedClientScanner object also. There is
one retry loop
[here](https://github.com/apache/hbase/blob/f3210c8908809fa154118454e6a23f57bc222db1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L848)
which will retry if exception is not TNFE or retries are not exhausted.
@infraio please correct me if I misunderstood anything.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 umbrella PR
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-689151514 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 13m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 37 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 2m 46s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 7s | branch-1 passed | | +1 :green_heart: | compile | 1m 49s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | compile | 1m 55s | branch-1 passed with JDK v1.7.0_272 | | +1 :green_heart: | checkstyle | 13m 25s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 54s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 6m 8s | branch-1 passed with JDK v1.7.0_272 | | +0 :ok: | spotbugs | 3m 2s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 20m 20s | branch-1 passed | | -0 :warning: | patch | 3m 43s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 1m 51s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | cc | 1m 51s | the patch passed | | +1 :green_heart: | javac | 1m 51s | the patch passed | | +1 :green_heart: | compile | 2m 3s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | cc | 2m 3s | the patch passed | | +1 :green_heart: | javac | 2m 3s | the patch passed | | -1 :x: | checkstyle | 0m 49s | hbase-client: The patch generated 16 new + 732 unchanged - 34 fixed = 748 total (was 766) | | -1 :x: | checkstyle | 2m 24s | hbase-server: The patch generated 99 new + 2098 unchanged - 51 fixed = 2197 total (was 2149) | | -1 :x: | checkstyle | 6m 57s | root: The patch generated 113 new + 2846 unchanged - 83 fixed = 2959 total (was 2929) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). | | +1 :green_heart: | shadedjars | 3m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 39s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | hbaseprotoc | 5m 5s | the patch passed | | +1 :green_heart: | javadoc | 4m 13s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 6m 23s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | findbugs | 22m 20s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 201m 4s | root in the patch failed. | | +1 :green_heart: | asflicense | 2m 24s | The patch does not generate ASF License warnings. | | | | 352m 54s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | pom.xml | | Failed junit tests | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint | | | hadoop.hbase.util.TestHBaseFsck | | | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory | | | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL | | | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationEndpoint | | | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/21/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2280 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc
[jira] [Commented] (HBASE-24979) Include batch mutatations in client operation timeout tests
[
https://issues.apache.org/jira/browse/HBASE-24979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192486#comment-17192486
]
Hudson commented on HBASE-24979:
Results for branch branch-2.3
[build #33 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/33/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/33/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/33/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/33/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/33/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Include batch mutatations in client operation timeout tests
> ---
>
> Key: HBASE-24979
> URL: https://issues.apache.org/jira/browse/HBASE-24979
> Project: HBase
> Issue Type: Test
>Affects Versions: 1.7.0, 2.4.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2
>
>
> While put, get and scan operations are included in client operation timeout
> test, we should also include batch requests. batch() has different way of
> handling operation timeout by passing it to AsyncProcessTask and then waiting
> on async future response.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] liuml07 commented on pull request #2163: HBASE-24789 When table level quota is set and violated, pre existing …
liuml07 commented on pull request #2163: URL: https://github.com/apache/hbase/pull/2163#issuecomment-689133805 @sanjeetnishad95 I do not have commit access. We can tag some committers to have a 2nd review. CC: @saintstack @ndimiduk This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2357: HBASE-24991 Replace MovedRegionsCleaner with guava cache
Apache-HBase commented on pull request #2357: URL: https://github.com/apache/hbase/pull/2357#issuecomment-689130065 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 18s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 6m 40s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 135m 11s | hbase-server in the patch passed. | | | | 163m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2357 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 938a7f376670 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/testReport/ | | Max. process+thread count | 4300 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-689125597 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 27s | master passed | | +1 :green_heart: | compile | 1m 44s | master passed | | +1 :green_heart: | shadedjars | 6m 45s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 28s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | +1 :green_heart: | compile | 1m 39s | the patch passed | | +1 :green_heart: | javac | 1m 39s | the patch passed | | +1 :green_heart: | shadedjars | 6m 41s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 130m 3s | hbase-server in the patch passed. | | | | 162m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1994 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux efdf0d7bef1b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/testReport/ | | Max. process+thread count | 4260 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-18070) Enable memstore replication for meta replica
[
https://issues.apache.org/jira/browse/HBASE-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192463#comment-17192463
]
Michael Stack commented on HBASE-18070:
---
{quote}Only introducing the new approach for meta table will make more
duplicated code as the old read replica code are still there...
{quote}
Sounds good as a phase 2 after the outline approach proves itself for the
simpler meta table case.
> Enable memstore replication for meta replica
>
>
> Key: HBASE-18070
> URL: https://issues.apache.org/jira/browse/HBASE-18070
> Project: HBase
> Issue Type: New Feature
>Reporter: Hua Xiang
>Assignee: Huaxiang Sun
>Priority: Major
>
> Based on the current doc, memstore replication is not enabled for meta
> replica. Memstore replication will be a good improvement for meta replica.
> Create jira to track this effort (feasibility, design, implementation, etc).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2012: HBASE-24670 KeyPrefix related split policies should exends SteppingSp…
Apache-HBase commented on pull request #2012: URL: https://github.com/apache/hbase/pull/2012#issuecomment-689121498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | master passed | | +1 :green_heart: | compile | 1m 22s | master passed | | +1 :green_heart: | shadedjars | 8m 20s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 51s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 17s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 8m 12s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 47s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 143m 27s | hbase-server in the patch passed. | | | | 177m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2012 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f81cfce4da70 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/testReport/ | | Max. process+thread count | 3854 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2012: HBASE-24670 KeyPrefix related split policies should exends SteppingSp…
Apache-HBase commented on pull request #2012: URL: https://github.com/apache/hbase/pull/2012#issuecomment-689109349 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 6m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 6m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 137m 20s | hbase-server in the patch passed. | | | | 163m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2012 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 62425546e593 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/testReport/ | | Max. process+thread count | 4942 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…
Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-68913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 9s | HBASE-24666 passed | | +1 :green_heart: | compile | 3m 34s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 8m 12s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 29s | hbase-client in HBASE-24666 failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in HBASE-24666 failed. | | -0 :warning: | javadoc | 0m 54s | hbase-thrift in HBASE-24666 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 23s | the patch passed | | +1 :green_heart: | compile | 3m 40s | the patch passed | | +1 :green_heart: | javac | 3m 40s | the patch passed | | +1 :green_heart: | shadedjars | 7m 50s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 30s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 44s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 58s | hbase-thrift in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 10s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 16s | hbase-client in the patch passed. | | -1 :x: | unit | 155m 6s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 4m 40s | hbase-thrift in the patch passed. | | | | 203m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2077 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b4a9665b4994 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/testReport/ | | Max. process+thread count | 3980 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,
[jira] [Commented] (HBASE-24925) SCP reduce unnecessary get requests
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192415#comment-17192415 ] Michael Stack commented on HBASE-24925: --- So, 170+seconds if no thread pool, and if there is a thread pool, how long does it take? > SCP reduce unnecessary get requests > --- > > Key: HBASE-24925 > URL: https://issues.apache.org/jira/browse/HBASE-24925 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > Attachments: image-2020-08-29-17-46-00-900.png > > > SCP should reduce unnecessary Get request > [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L520] > during startup， the tableNam2State of tableStateManager is not loading > tableState data form metaTable yet. if procThread num is 50 and hbase has > 10K tables, in the worst case, the master needs to query meta table 500K > times(50*10K. and the regions that all SCPs simultaneously check tableState > belong to the same table ) > > i think master can reduce Get request, and AM#loadMeta can load regions and > all tables through asynchronous threads. > [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1532] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…
Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-689082504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 28s | HBASE-24666 passed | | +1 :green_heart: | compile | 2m 45s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 6m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 45s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 2m 39s | the patch passed | | +1 :green_heart: | javac | 2m 39s | the patch passed | | +1 :green_heart: | shadedjars | 6m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 46s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 2s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 141m 28s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 4m 0s | hbase-thrift in the patch passed. | | | | 180m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2077 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dd2b640ed7eb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/testReport/ | | Max. process+thread count | 4637 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24995) MetaFixer fails to fix overlaps when multiple tables have overlaps
[ https://issues.apache.org/jira/browse/HBASE-24995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24995. --- Fix Version/s: 2.3.2 2.4.0 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.3+ (wouldn't go back to branch-2.2 as is). Thanks for digging in here [~arshad.mohammad] > MetaFixer fails to fix overlaps when multiple tables have overlaps > -- > > Key: HBASE-24995 > URL: https://issues.apache.org/jira/browse/HBASE-24995 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > MetaFixer fails to fix overlaps when multiple tables have overlaps > *Steps to reproduce from UT.* > # Create table t1 and t2 with split keys, ["bbb", "ccc", "ddd", "eee"] > # Create extra region in both t1 and t2 with start key "bbb" and end key "ddd" > # Run catalog janitor, It will report total 4 overlaps, 2 from each table. > # Run MetaFixer, wait for merges to finish. > # Run the catalog janitor again and verify report, there should not be any > overlap > # Overlap still exists. Reproduced!!! > *Analysis.* > * When I run the same scenario for just one table t1, overlaps are fixed > successfully. > * Seems problem with MetaFixer#calculateMerges. > * I think merges should be calculated within a table. Across the table merge > does not have significance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #2361: HBASE-24995: MetaFixer fails to fix overlaps when multiple tables hav…
saintstack merged pull request #2361: URL: https://github.com/apache/hbase/pull/2361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2361: HBASE-24995: MetaFixer fails to fix overlaps when multiple tables hav…
saintstack commented on a change in pull request #2361:
URL: https://github.com/apache/hbase/pull/2361#discussion_r485131713
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
##
@@ -231,16 +235,18 @@ private static RegionInfo buildRegionInfo(TableName tn,
byte [] start, byte [] e
/**
* Fix overlaps noted in CJ consistency report.
*/
- void fixOverlaps(CatalogJanitor.Report report) throws IOException {
+ List fixOverlaps(CatalogJanitor.Report report) throws IOException {
+List pidList = new ArrayList<>();
Review comment:
This change is just to make your fix more testable? If so, that is fine.
I wasn't expecting it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2365: HBASE-24994 Add hedgedReadOpsInCurThread metric
Apache-HBase commented on pull request #2365: URL: https://github.com/apache/hbase/pull/2365#issuecomment-689067261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 19s | master passed | | +1 :green_heart: | compile | 2m 23s | master passed | | +1 :green_heart: | shadedjars | 6m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 57s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 2m 17s | the patch passed | | +1 :green_heart: | javac | 2m 17s | the patch passed | | +1 :green_heart: | shadedjars | 6m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 54s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 295m 34s | root in the patch failed. | | | | 330m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2365 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 73b1b58900ba 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/testReport/ | | Max. process+thread count | 4131 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2364: HBASE-24998 Introduce a ReplicationSourceOverallController interface …
saintstack commented on a change in pull request #2364:
URL: https://github.com/apache/hbase/pull/2364#discussion_r485115878
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##
@@ -979,6 +979,8 @@
/*
* cluster replication constants.
*/
+ public static final String REPLICATION_OFFLOAD_ENABLE_KEY =
"hbase.replication.offload.enabled";
+ public static final boolean REPLICATION_OFFLOAD_ENABLE_DEFAULT = false;
Review comment:
Only used in ReplicationSourceManager so define these there?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationSourceOverallController.java
##
@@ -0,0 +1,31 @@
+package org.apache.hadoop.hbase.replication;
+
+import
org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationGlobalSourceSource;
+import
org.apache.hadoop.hbase.replication.regionserver.RecoveredReplicationSource;
+import org.apache.yetus.audience.InterfaceAudience;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+/**
+ * Used to control all replication sources inside one RegionServer or
ReplicationServer.
+ * Used by {@link ReplicationSource} or {@link RecoveredReplicationSource}.
+ */
+@InterfaceAudience.Private
+public interface ReplicationSourceOverallController {
Review comment:
Can it just be ReplicationSoruceController? Drop the 'Overall'?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##
@@ -244,7 +286,7 @@ private void adoptAbandonedQueues() {
*
* @param peerId the id of replication peer
*/
- public void addPeer(String peerId) throws IOException {
+ void addPeer(String peerId) throws IOException {
Review comment:
Funny, I want it to stay public in my current work (meta region
replicas). Can move it back in my patch.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##
@@ -268,7 +310,7 @@ public void addPeer(String peerId) throws IOException {
*
* @param peerId the id of the replication peer
*/
- public void removePeer(String peerId) {
+ void removePeer(String peerId) {
Review comment:
Ditto
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##
@@ -186,12 +188,11 @@ public ReplicationSourceManager(ReplicationQueueStorage
queueStorage,
this.latestPaths = new HashMap<>();
this.replicationForBulkLoadDataEnabled = conf.getBoolean(
HConstants.REPLICATION_BULKLOAD_ENABLE_KEY,
HConstants.REPLICATION_BULKLOAD_ENABLE_DEFAULT);
-this.sleepForRetries =
this.conf.getLong("replication.source.sync.sleepforretries", 1000);
-this.maxRetriesMultiplier =
- this.conf.getInt("replication.source.sync.maxretriesmultiplier", 60);
this.totalBufferLimit =
conf.getLong(HConstants.REPLICATION_SOURCE_TOTAL_BUFFER_KEY,
HConstants.REPLICATION_SOURCE_TOTAL_BUFFER_DFAULT);
this.globalMetrics = globalMetrics;
+this.replicationOffload =
conf.getBoolean(HConstants.REPLICATION_OFFLOAD_ENABLE_KEY,
Review comment:
I should go back to the design but we can't just have the offload be a
ReplicationSource implementation? Because you need to span all
ReplicationSources?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##
@@ -92,7 +93,8 @@
*
*/
@InterfaceAudience.Private
-public class ReplicationSourceManager implements ReplicationListener {
+public class ReplicationSourceManager implements ReplicationListener,
+ ReplicationSourceOverallController {
Review comment:
Yeah, if this implements Controller, you have to pass it in to
ReplicationSource #Init as a distinct arg?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationSourceOverallController.java
##
@@ -0,0 +1,31 @@
+package org.apache.hadoop.hbase.replication;
+
+import
org.apache.hadoop.hbase.replication.regionserver.MetricsReplicationGlobalSourceSource;
+import
org.apache.hadoop.hbase.replication.regionserver.RecoveredReplicationSource;
+import org.apache.yetus.audience.InterfaceAudience;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+/**
+ * Used to control all replication sources inside one RegionServer or
ReplicationServer.
+ * Used by {@link ReplicationSource} or {@link RecoveredReplicationSource}.
+ */
+@InterfaceAudience.Private
+public interface ReplicationSourceOverallController {
+
+ /**
+ * Returns the maximum size in bytes of edits held in memory which are
pending replication
+ * across all sources inside this RegionServer or ReplicationServer.
+ */
+ long getTotalBufferLimit();
+
+ AtomicLong getTotalBufferUsed();
+
+ MetricsReplicationGlobalSourceSource getGlobalMetrics();
Review comment:
[GitHub] [hbase] Apache-HBase commented on pull request #2357: HBASE-24991 Replace MovedRegionsCleaner with guava cache
Apache-HBase commented on pull request #2357: URL: https://github.com/apache/hbase/pull/2357#issuecomment-689061399 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | master passed | | +1 :green_heart: | checkstyle | 1m 12s | master passed | | +1 :green_heart: | spotbugs | 2m 9s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | -0 :warning: | checkstyle | 1m 4s | hbase-server: The patch generated 1 new + 41 unchanged - 4 fixed = 42 total (was 45) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 32s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 34m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2357 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux c557a2059faf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-689060772 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 16s | master passed | | +1 :green_heart: | checkstyle | 2m 8s | master passed | | +1 :green_heart: | spotbugs | 4m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 37s | the patch passed | | +1 :green_heart: | checkstyle | 2m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 5s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 4m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 48m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1994 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 8660c9131c7a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-1994/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2311: HBASE-24606 Implement meta merge
Apache-HBase commented on pull request #2311: URL: https://github.com/apache/hbase/pull/2311#issuecomment-689045566 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24950 Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 3s | HBASE-24950 passed | | +1 :green_heart: | compile | 1m 17s | HBASE-24950 passed | | +1 :green_heart: | shadedjars | 7m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 50s | HBASE-24950 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 50s | the patch passed | | +1 :green_heart: | compile | 1m 16s | the patch passed | | +1 :green_heart: | javac | 1m 16s | the patch passed | | +1 :green_heart: | shadedjars | 7m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 21s | hbase-balancer in the patch passed. | | +1 :green_heart: | unit | 212m 46s | hbase-server in the patch passed. | | | | 243m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2311/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2311 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 36825b442333 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24950 / d95ab70649 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2311/5/testReport/ | | Max. process+thread count | 2788 (vs. ulimit of 12500) | | modules | C: hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2311/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-23963) Split TestFromClientSide; it takes too long to complete timing out
[ https://issues.apache.org/jira/browse/HBASE-23963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-23963: - Affects Version/s: 1.7.0 > Split TestFromClientSide; it takes too long to complete timing out > -- > > Key: HBASE-23963 > URL: https://issues.apache.org/jira/browse/HBASE-23963 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 1.7.0 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > Attachments: Screen Shot 2020-03-11 at 7.43.27 AM.png > > > The TestFromClientSide test was parameterized recently so we'd run full sweet > with one of three registries. Test now often takes longer than max 13 minutes > allowed. Split the test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2012: HBASE-24670 KeyPrefix related split policies should exends SteppingSp…
Apache-HBase commented on pull request #2012: URL: https://github.com/apache/hbase/pull/2012#issuecomment-689043329 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 57s | master passed | | +1 :green_heart: | checkstyle | 1m 13s | master passed | | +1 :green_heart: | spotbugs | 2m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | the patch passed | | +1 :green_heart: | checkstyle | 1m 6s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 2s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 34m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2012 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux cd5e529eedb3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2012/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-23963) Split TestFromClientSide; it takes too long to complete timing out
[ https://issues.apache.org/jira/browse/HBASE-23963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192362#comment-17192362 ] Bharath Vissapragada edited comment on HBASE-23963 at 9/8/20, 5:55 PM: --- Re-opening for branch-1 back port. TestFromClientSide is now heavy given it will be parameterized to run with multiple registry implementations. [~apurtell] was (Author: bharathv): Re-opening for branch-1 back port. TestFromClientSide is not heavy given it will be parameterized to run with multiple registry implementations. [~apurtell] > Split TestFromClientSide; it takes too long to complete timing out > -- > > Key: HBASE-23963 > URL: https://issues.apache.org/jira/browse/HBASE-23963 > Project: HBase > Issue Type: Test > Components: test >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > Attachments: Screen Shot 2020-03-11 at 7.43.27 AM.png > > > The TestFromClientSide test was parameterized recently so we'd run full sweet > with one of three registries. Test now often takes longer than max 13 minutes > allowed. Split the test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (HBASE-23963) Split TestFromClientSide; it takes too long to complete timing out
[ https://issues.apache.org/jira/browse/HBASE-23963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada reopened HBASE-23963: -- Re-opening for branch-1 back port. TestFromClientSide is not heavy given it will be parameterized to run with multiple registry implementations. [~apurtell] > Split TestFromClientSide; it takes too long to complete timing out > -- > > Key: HBASE-23963 > URL: https://issues.apache.org/jira/browse/HBASE-23963 > Project: HBase > Issue Type: Test > Components: test >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > Attachments: Screen Shot 2020-03-11 at 7.43.27 AM.png > > > The TestFromClientSide test was parameterized recently so we'd run full sweet > with one of three registries. Test now often takes longer than max 13 minutes > allowed. Split the test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24950) Alternate solution for Splittable Meta
[ https://issues.apache.org/jira/browse/HBASE-24950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192360#comment-17192360 ] Michael Stack commented on HBASE-24950: --- Any design? In particular, interested in how issues that came up on HBASE-11288 are being addressed here? Thanks. > Alternate solution for Splittable Meta > -- > > Key: HBASE-24950 > URL: https://issues.apache.org/jira/browse/HBASE-24950 > Project: HBase > Issue Type: Umbrella > Components: meta, Region Assignment >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > For implementing splittable meta with a master local region to store the > 'root table'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
[
https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192357#comment-17192357
]
Bharath Vissapragada commented on HBASE-23792:
--
Re-opening for branch-1 back-port. There are a lot of commits related to this
(some debugging, some refactoring etc). It is not exactly clear to me what
fixed the problem, need to take a closer look. The issue now happens
consistently in branch-1 too. [~apurtell] FYI.
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> ---
>
> Key: HBASE-23792
> URL: https://issues.apache.org/jira/browse/HBASE-23792
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0, 1.7.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.1.9, 2.2.4
>
> Attachments:
> TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS:
> file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1,
> expected: hdfs://localhost:44609
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
[
https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharath Vissapragada updated HBASE-23792:
-
Affects Version/s: 1.7.0
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> ---
>
> Key: HBASE-23792
> URL: https://issues.apache.org/jira/browse/HBASE-23792
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0, 1.7.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.1.9, 2.2.4
>
> Attachments:
> TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS:
> file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1,
> expected: hdfs://localhost:44609
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
[
https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharath Vissapragada reopened HBASE-23792:
--
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> ---
>
> Key: HBASE-23792
> URL: https://issues.apache.org/jira/browse/HBASE-23792
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.1.9, 2.2.4
>
> Attachments:
> TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS:
> file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1,
> expected: hdfs://localhost:44609
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2365: HBASE-24994 Add hedgedReadOpsInCurThread metric
Apache-HBase commented on pull request #2365: URL: https://github.com/apache/hbase/pull/2365#issuecomment-689035054 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 9s | master passed | | +1 :green_heart: | compile | 3m 21s | master passed | | +1 :green_heart: | shadedjars | 8m 2s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | root in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-hadoop-compat in master failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 49s | the patch passed | | +1 :green_heart: | compile | 3m 38s | the patch passed | | +1 :green_heart: | javac | 3m 38s | the patch passed | | +1 :green_heart: | shadedjars | 7m 48s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 15s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 227m 53s | root in the patch failed. | | | | 267m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2365 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 133819aaed9d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/testReport/ | | Max. process+thread count | 3222 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2366: HBASE-25000 Move delete region info related methods to RegionStateStore
Apache-HBase commented on pull request #2366: URL: https://github.com/apache/hbase/pull/2366#issuecomment-689031178 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 43s | master passed | | +1 :green_heart: | compile | 1m 16s | master passed | | +1 :green_heart: | shadedjars | 6m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 55s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | shadedjars | 6m 34s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 38s | hbase-server generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 23s | hbase-balancer in the patch passed. | | +1 :green_heart: | unit | 145m 1s | hbase-server in the patch passed. | | | | 174m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2366 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f8d0dc535a1a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 1.8.0_232 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/testReport/ | | Max. process+thread count | 4309 (vs. ulimit of 12500) | | modules | C: hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2366: HBASE-25000 Move delete region info related methods to RegionStateStore
Apache-HBase commented on pull request #2366: URL: https://github.com/apache/hbase/pull/2366#issuecomment-689024945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 28s | master passed | | +1 :green_heart: | compile | 1m 33s | master passed | | +1 :green_heart: | shadedjars | 7m 5s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | hbase-balancer in master failed. | | -0 :warning: | javadoc | 0m 48s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 26s | the patch passed | | +1 :green_heart: | compile | 1m 33s | the patch passed | | +1 :green_heart: | javac | 1m 33s | the patch passed | | +1 :green_heart: | shadedjars | 7m 18s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-balancer in the patch failed. | | -0 :warning: | javadoc | 0m 43s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 24s | hbase-balancer in the patch passed. | | +1 :green_heart: | unit | 129m 25s | hbase-server in the patch passed. | | | | 161m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2366 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 69c924edc0c0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-balancer.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/testReport/ | | Max. process+thread count | 4118 (vs. ulimit of 12500) | | modules | C: hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…
Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-689007122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 30s | HBASE-24666 passed | | +1 :green_heart: | checkstyle | 3m 15s | HBASE-24666 passed | | +1 :green_heart: | spotbugs | 9m 7s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-protocol-shaded | | +1 :green_heart: | checkstyle | 0m 27s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 4s | hbase-server: The patch generated 0 new + 187 unchanged - 2 fixed = 187 total (was 189) | | +1 :green_heart: | checkstyle | 0m 39s | The patch passed checkstyle in hbase-thrift | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 25s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 27s | the patch passed | | +1 :green_heart: | spotbugs | 8m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 49s | The patch does not generate ASF License warnings. | | | | 55m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2077 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 89958bb6ff35 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/8/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2361: HBASE-24995: MetaFixer fails to fix overlaps when multiple tables hav…
Apache-HBase commented on pull request #2361: URL: https://github.com/apache/hbase/pull/2361#issuecomment-688991108 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 6m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 140m 40s | hbase-server in the patch passed. | | | | 166m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2361/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2361 | | JIRA Issue | HBASE-24995 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ab805d28e53d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2361/2/testReport/ | | Max. process+thread count | 4660 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2361/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2361: HBASE-24995: MetaFixer fails to fix overlaps when multiple tables hav…
Apache-HBase commented on pull request #2361: URL: https://github.com/apache/hbase/pull/2361#issuecomment-688984813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 6m 44s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 6m 39s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 128m 42s | hbase-server in the patch passed. | | | | 156m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2361/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2361 | | JIRA Issue | HBASE-24995 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e16439f5bc9d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2361/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2361/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2361/2/testReport/ | | Max. process+thread count | 4530 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2361/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24979) Include batch mutatations in client operation timeout tests
[ https://issues.apache.org/jira/browse/HBASE-24979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192291#comment-17192291 ] Viraj Jasani commented on HBASE-24979: -- [~zghao] would you prefer having this land on branch-2.2 now? or only after 2.6 is released? Thanks > Include batch mutatations in client operation timeout tests > --- > > Key: HBASE-24979 > URL: https://issues.apache.org/jira/browse/HBASE-24979 > Project: HBase > Issue Type: Test >Affects Versions: 1.7.0, 2.4.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2 > > > While put, get and scan operations are included in client operation timeout > test, we should also include batch requests. batch() has different way of > handling operation timeout by passing it to AsyncProcessTask and then waiting > on async future response. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2364: HBASE-24998 Introduce a ReplicationSourceOverallController interface …
Apache-HBase commented on pull request #2364: URL: https://github.com/apache/hbase/pull/2364#issuecomment-688964217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 41s | HBASE-24666 passed | | +1 :green_heart: | compile | 1m 38s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 6m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 16s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | compile | 1m 37s | the patch passed | | +1 :green_heart: | javac | 1m 37s | the patch passed | | -1 :x: | shadedjars | 5m 13s | patch has 10 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 21s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 0m 26s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 139m 37s | hbase-server in the patch passed. | | | | 169m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2364 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e1a5a9d86a6a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Default Java | 1.8.0_232 | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/testReport/ | | Max. process+thread count | 4278 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-replication hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2364: HBASE-24998 Introduce a ReplicationSourceOverallController interface …
Apache-HBase commented on pull request #2364: URL: https://github.com/apache/hbase/pull/2364#issuecomment-688961042 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 55s | HBASE-24666 passed | | +1 :green_heart: | compile | 1m 48s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 6m 34s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in HBASE-24666 failed. | | -0 :warning: | javadoc | 0m 17s | hbase-replication in HBASE-24666 failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in HBASE-24666 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 1m 49s | the patch passed | | +1 :green_heart: | javac | 1m 49s | the patch passed | | -1 :x: | shadedjars | 5m 26s | patch has 10 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-replication in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 33s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 133m 2s | hbase-server in the patch passed. | | | | 164m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2364 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a8f3649c8a65 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-replication.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-replication.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/testReport/ | | Max. process+thread count | 3931 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-replication hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2364/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2366: HBASE-25000 Move delete region info related methods to RegionStateStore
Apache-HBase commented on pull request #2366: URL: https://github.com/apache/hbase/pull/2366#issuecomment-688952013 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 0s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 45s | master passed | | +1 :green_heart: | checkstyle | 1m 19s | master passed | | +1 :green_heart: | spotbugs | 2m 35s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | checkstyle | 1m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 40m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2366 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 0d9ea3b69007 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2366: HBASE-25000 Move delete region info related methods to RegionStateStore
Apache9 opened a new pull request #2366: URL: https://github.com/apache/hbase/pull/2366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2311: HBASE-24606 Implement meta merge
Apache-HBase commented on pull request #2311: URL: https://github.com/apache/hbase/pull/2311#issuecomment-688921609 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24950 Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 34s | HBASE-24950 passed | | +1 :green_heart: | checkstyle | 1m 17s | HBASE-24950 passed | | +1 :green_heart: | spotbugs | 2m 31s | HBASE-24950 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | checkstyle | 1m 19s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 42s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 36m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2311/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2311 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 7f1e197d52bd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24950 / d95ab70649 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2311/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25000) Move delete region info related methods to RegionStateStore
Duo Zhang created HBASE-25000: - Summary: Move delete region info related methods to RegionStateStore Key: HBASE-25000 URL: https://issues.apache.org/jira/browse/HBASE-25000 Project: HBase Issue Type: Sub-task Components: meta Reporter: Duo Zhang Assignee: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24992) log after Generator success when running ITBLL
[ https://issues.apache.org/jira/browse/HBASE-24992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-24992: -- Fix Version/s: 3.0.0-alpha-1 > log after Generator success when running ITBLL > -- > > Key: HBASE-24992 > URL: https://issues.apache.org/jira/browse/HBASE-24992 > Project: HBase > Issue Type: Improvement >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Trivial > Fix For: 3.0.0-alpha-1 > > > When I was running ITBLL, there is no output after the Generator finished. We > should log this just as the verify stage. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24979) Include batch mutatations in client operation timeout tests
[ https://issues.apache.org/jira/browse/HBASE-24979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24979: - Fix Version/s: 2.3.2 2.2.7 2.4.0 3.0.0-alpha-1 > Include batch mutatations in client operation timeout tests > --- > > Key: HBASE-24979 > URL: https://issues.apache.org/jira/browse/HBASE-24979 > Project: HBase > Issue Type: Test >Affects Versions: 1.7.0, 2.4.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2 > > > While put, get and scan operations are included in client operation timeout > test, we should also include batch requests. batch() has different way of > handling operation timeout by passing it to AsyncProcessTask and then waiting > on async future response. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24979) Include batch mutatations in client operation timeout tests
[ https://issues.apache.org/jira/browse/HBASE-24979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24979: - Status: Patch Available (was: In Progress) > Include batch mutatations in client operation timeout tests > --- > > Key: HBASE-24979 > URL: https://issues.apache.org/jira/browse/HBASE-24979 > Project: HBase > Issue Type: Test >Affects Versions: 1.7.0, 2.4.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2 > > > While put, get and scan operations are included in client operation timeout > test, we should also include batch requests. batch() has different way of > handling operation timeout by passing it to AsyncProcessTask and then waiting > on async future response. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2360: HBASE-24982 Disassemble the method replicateWALEntry from AdminServic…
Apache-HBase commented on pull request #2360: URL: https://github.com/apache/hbase/pull/2360#issuecomment-688910793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 44s | HBASE-24666 passed | | +1 :green_heart: | compile | 2m 58s | HBASE-24666 passed | | +1 :green_heart: | shadedjars | 7m 22s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 24s | hbase-client in HBASE-24666 failed. | | -0 :warning: | javadoc | 0m 15s | hbase-replication in HBASE-24666 failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in HBASE-24666 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 35s | the patch passed | | +1 :green_heart: | compile | 2m 59s | the patch passed | | +1 :green_heart: | javac | 2m 59s | the patch passed | | +1 :green_heart: | shadedjars | 7m 16s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-replication in the patch failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 2s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 17s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 37s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 196m 3s | hbase-server in the patch passed. | | | | 236m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2360 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 65aee09ce29c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / e053a00b9b | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-replication.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-replication.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/testReport/ | | Max. process+thread count | 3193 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2360/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2365: HBASE-24994 Add hedgedReadOpsInCurThread metric
Apache-HBase commented on pull request #2365: URL: https://github.com/apache/hbase/pull/2365#issuecomment-688910211 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 44s | master passed | | +1 :green_heart: | checkstyle | 1m 58s | master passed | | +0 :ok: | refguide | 4m 52s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotbugs | 11m 13s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | -0 :warning: | checkstyle | 1m 53s | root: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 4m 59s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 11m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 11m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 42s | The patch does not generate ASF License warnings. | | | | 65m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2365 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide | | uname | Linux a2ee2c335c82 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d95a8f91b | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-general-check/output/branch-site/book.html | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2365/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
