[GitHub] [hbase] robin7roy opened a new pull request #2926: HBASE-25546 PerfTestCompactionPolicies is failing because of NPE (addendum)
robin7roy opened a new pull request #2926: URL: https://github.com/apache/hbase/pull/2926 Added HBaseClassTestRule for PerfTestCompactionPolicies This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2925: HBASE-25550 More readable Competition Time
Apache-HBase commented on pull request #2925: URL: https://github.com/apache/hbase/pull/2925#issuecomment-773099628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 48s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 11m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2925/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2925 | | Optional Tests | dupname asflicense javac | | uname | Linux 0ad110761f98 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2925/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2924: HBASE-25549 A new hbase shell command: 'alter_lazy'
Apache-HBase commented on pull request #2924: URL: https://github.com/apache/hbase/pull/2924#issuecomment-773098547 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 2s | master passed | | +1 :green_heart: | compile | 3m 23s | master passed | | +1 :green_heart: | shadedjars | 7m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 52s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 1s | the patch passed | | +1 :green_heart: | compile | 3m 29s | the patch passed | | +1 :green_heart: | javac | 3m 29s | the patch passed | | +1 :green_heart: | shadedjars | 7m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 48s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 18m 48s | root in the patch failed. | | | | 67m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2924/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2924 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1f861fa7d4e4 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2924/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2924/1/testReport/ | | Max. process+thread count | 584 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2924/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] GeorryHuang opened a new pull request #2925: HBASE-25550 More readable Competition Time
GeorryHuang opened a new pull request #2925: URL: https://github.com/apache/hbase/pull/2925 Should add duration to Completion Time. Make it more readable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25550) More readable Competition Time
[ https://issues.apache.org/jira/browse/HBASE-25550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25550: -- Summary: More readable Competition Time (was: More readable Competition time) > More readable Competition Time > -- > > Key: HBASE-25550 > URL: https://issues.apache.org/jira/browse/HBASE-25550 > Project: HBase > Issue Type: Sub-task > Components: UI >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Minor > Fix For: 3.0.0-alpha-1 > > Attachments: image-2021-02-04-15-21-00-019.png > > > Should add duration to Completion Time. Make it more readable > !https://internal-api-lark-file.f.mioffice.cn/api/image/keys/img_44a98ccd-4576-4971-900e-3d27dd1263el?message_id=6925292609535492204! > to > !image-2021-02-04-15-21-00-019.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25550) More readable Competition time
Zhuoyue Huang created HBASE-25550: - Summary: More readable Competition time Key: HBASE-25550 URL: https://issues.apache.org/jira/browse/HBASE-25550 Project: HBase Issue Type: Sub-task Components: UI Reporter: Zhuoyue Huang Assignee: Zhuoyue Huang Fix For: 3.0.0-alpha-1 Attachments: image-2021-02-04-15-21-00-019.png Should add duration to Completion Time. Make it more readable !https://internal-api-lark-file.f.mioffice.cn/api/image/keys/img_44a98ccd-4576-4971-900e-3d27dd1263el?message_id=6925292609535492204! to !image-2021-02-04-15-21-00-019.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25546) PerfTestCompactionPolicies is failing because of NPE
[
https://issues.apache.org/jira/browse/HBASE-25546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278595#comment-17278595
]
Pankaj Kumar commented on HBASE-25546:
--
[~robin7roy], do you mind raising addendum PR with above changes?
> PerfTestCompactionPolicies is failing because of NPE
>
>
> Key: HBASE-25546
> URL: https://issues.apache.org/jira/browse/HBASE-25546
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0-alpha-1
>Reporter: Robin Roy
>Assignee: Robin Roy
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> PerfTestCompactionPolicies is failing because of NPE as
> {code:java}
> s.getRegionInfo(){code}
> mock is missing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25546) PerfTestCompactionPolicies is failing because of NPE
[
https://issues.apache.org/jira/browse/HBASE-25546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278588#comment-17278588
]
Michael Stack commented on HBASE-25546:
---
Still not showing [~pankajkumar] ?
https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/202/testReport/org.apache.hadoop.hbase.regionserver.compactions/
This stuff is missing... could try adding it in...
{code}
$ git diff
diff --git
a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/PerfTestCompactionPolicies.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/PerfTestCompactionPolicies.java
index 0c84507c95..af484a1b50 100644
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/PerfTestCompactionPolicies.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/PerfTestCompactionPolicies.java
@@ -28,6 +28,7 @@ import java.util.Collection;
import java.util.List;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
import org.apache.hadoop.hbase.HBaseConfiguration;
import org.apache.hadoop.hbase.client.RegionInfoBuilder;
import org.apache.hadoop.hbase.regionserver.HStore;
@@ -36,6 +37,7 @@ import
org.apache.hadoop.hbase.regionserver.StoreConfigInformation;
import org.apache.hadoop.hbase.testclassification.MediumTests;
import org.apache.hadoop.hbase.testclassification.RegionServerTests;
import org.apache.hadoop.hbase.util.ReflectionUtils;
+import org.junit.ClassRule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
@@ -44,6 +46,9 @@ import org.junit.runners.Parameterized;
@Category({RegionServerTests.class, MediumTests.class})
@RunWith(Parameterized.class)
public class PerfTestCompactionPolicies extends MockStoreFileGenerator {
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(PerfTestCompactionPolicies.class);
private final RatioBasedCompactionPolicy cp;
private final StoreFileListGenerator generator;
{code}
> PerfTestCompactionPolicies is failing because of NPE
>
>
> Key: HBASE-25546
> URL: https://issues.apache.org/jira/browse/HBASE-25546
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0-alpha-1
>Reporter: Robin Roy
>Assignee: Robin Roy
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> PerfTestCompactionPolicies is failing because of NPE as
> {code:java}
> s.getRegionInfo(){code}
> mock is missing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] GeorryHuang opened a new pull request #2924: HBASE-25549 A new hbase shell command: 'alter_lazy'
GeorryHuang opened a new pull request #2924: URL: https://github.com/apache/hbase/pull/2924 'alter_lazy' is a new command to modify a table without reopening any online regions except those regions were assigned by other threads or split etc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25549) A new hbase shell command: 'alter_lazy'
[ https://issues.apache.org/jira/browse/HBASE-25549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25549: -- Description: Under normal circumstances, modifying a table will cause all regions belonging to the table to enter RIT. Imagine the following two scenarios： # Someone entered the wrong configuration （e.g. negative 'hbase.busy.wait.multiplier.max' value） when altering the table, causing thousands of online regions to fail to open, leading to online accidents. # Modify the configuration of a table, but this modification is not urgent, the regions are not expected to enter RIT immediately. 'alter_lazy' is a new command to modify a table without reopening any online regions except those regions were assigned by other threads or split etc. was: Under normal circumstances, modifying a table will cause all regions belonging to the table to enter RIT. Imagine the following two scenarios： # Someone entered the wrong configuration （e.g. negative 'hbase.busy.wait.multiplier.max' value） when altering the table, causing thousands of online regions to fail to open, leading to online accidents. # Modify the configuration of a table, but this modification is not urgent, the regions are not expected to enter RIT immediately. 'lazy_alter' is a new command to modify a table without reopening any online regions except those regions were assigned by other threads or split etc. > A new hbase shell command: 'alter_lazy' > --- > > Key: HBASE-25549 > URL: https://issues.apache.org/jira/browse/HBASE-25549 > Project: HBase > Issue Type: Improvement > Components: master, shell >Affects Versions: 3.0.0-alpha-1 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > Under normal circumstances, modifying a table will cause all regions > belonging to the table to enter RIT. Imagine the following two scenarios： > # Someone entered the wrong configuration （e.g. negative > 'hbase.busy.wait.multiplier.max' value） when altering the table, causing > thousands of online regions to fail to open, leading to online accidents. > # Modify the configuration of a table, but this modification is not urgent, > the regions are not expected to enter RIT immediately. > 'alter_lazy' is a new command to modify a table without reopening any online > regions except those regions were assigned by other threads or split etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25549) A new hbase shell command: 'alter_lazy'
[ https://issues.apache.org/jira/browse/HBASE-25549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25549: -- Summary: A new hbase shell command: 'alter_lazy' (was: A new hbase shell command: 'lazy_alter') > A new hbase shell command: 'alter_lazy' > --- > > Key: HBASE-25549 > URL: https://issues.apache.org/jira/browse/HBASE-25549 > Project: HBase > Issue Type: Improvement > Components: master, shell >Affects Versions: 3.0.0-alpha-1 >Reporter: Zhuoyue Huang >Assignee: Zhuoyue Huang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > Under normal circumstances, modifying a table will cause all regions > belonging to the table to enter RIT. Imagine the following two scenarios： > # Someone entered the wrong configuration （e.g. negative > 'hbase.busy.wait.multiplier.max' value） when altering the table, causing > thousands of online regions to fail to open, leading to online accidents. > # Modify the configuration of a table, but this modification is not urgent, > the regions are not expected to enter RIT immediately. > 'lazy_alter' is a new command to modify a table without reopening any online > regions except those regions were assigned by other threads or split etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25549) A new hbase shell command: 'lazy_alter'
Zhuoyue Huang created HBASE-25549: - Summary: A new hbase shell command: 'lazy_alter' Key: HBASE-25549 URL: https://issues.apache.org/jira/browse/HBASE-25549 Project: HBase Issue Type: Improvement Components: master, shell Affects Versions: 3.0.0-alpha-1 Reporter: Zhuoyue Huang Assignee: Zhuoyue Huang Fix For: 3.0.0-alpha-1 Under normal circumstances, modifying a table will cause all regions belonging to the table to enter RIT. Imagine the following two scenarios： # Someone entered the wrong configuration （e.g. negative 'hbase.busy.wait.multiplier.max' value） when altering the table, causing thousands of online regions to fail to open, leading to online accidents. # Modify the configuration of a table, but this modification is not urgent, the regions are not expected to enter RIT immediately. 'lazy_alter' is a new command to modify a table without reopening any online regions except those regions were assigned by other threads or split etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25546) PerfTestCompactionPolicies is failing because of NPE
[
https://issues.apache.org/jira/browse/HBASE-25546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278505#comment-17278505
]
Pankaj Kumar commented on HBASE-25546:
--
Not sure, how this is ignored in our nightly build.
> PerfTestCompactionPolicies is failing because of NPE
>
>
> Key: HBASE-25546
> URL: https://issues.apache.org/jira/browse/HBASE-25546
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0-alpha-1
>Reporter: Robin Roy
>Assignee: Robin Roy
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> PerfTestCompactionPolicies is failing because of NPE as
> {code:java}
> s.getRegionInfo(){code}
> mock is missing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23044) CatalogJanitor#cleanMergeQualifier may clean wrong parent regions
[
https://issues.apache.org/jira/browse/HBASE-23044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278456#comment-17278456
]
Guanghao Zhang commented on HBASE-23044:
Sorry to hear that..
> CatalogJanitor#cleanMergeQualifier may clean wrong parent regions
> -
>
> Key: HBASE-23044
> URL: https://issues.apache.org/jira/browse/HBASE-23044
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.6, 2.2.1, 2.1.6
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.1.7, 2.2.2
>
>
> 2019-09-17,19:42:40,539 INFO [PEWorker-1]
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=1223589,
> state=SUCCESS; GCMultipleMergedRegionsProcedure
> child={color:red}647600d28633bb2fe06b40682bab0593{color},
> parents:[81b6fc3c560a00692bc7c3cd266a626a],
> [472500358997b0dc8f0002ec86593dcf] in 2.6470sec
> 2019-09-17,19:59:54,179 INFO [PEWorker-6]
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=1223651,
> state=SUCCESS; GCMultipleMergedRegionsProcedure
> child={color:red}647600d28633bb2fe06b40682bab0593{color},
> parents:[9c52f24e0a9cc9b4959c1ebdfea29d64],
> [a623f298870df5581bcfae7f83311b33] in 1.0340sec
> The child is same region {color:red}647600d28633bb2fe06b40682bab0593{color}
> but the parent regions are different.
> MergeTableRegionProcedure#prepareMergeRegion will try to cleanMergeQualifier
> for the regions to merge.
> {code:java}
> for (RegionInfo ri: this.regionsToMerge) {
> if (!catalogJanitor.cleanMergeQualifier(ri)) {
> String msg = "Skip merging " +
> RegionInfo.getShortNameToLog(regionsToMerge) +
> ", because parent " + RegionInfo.getShortNameToLog(ri) + " has a
> merge qualifier";
> LOG.warn(msg);
> throw new MergeRegionException(msg);
> }
> {code}
> If region A and B merge to C, region D and E merge to F. When merge C and F,
> it will try to cleanMergeQualifier for C and F.
> catalogJanitor.cleanMergeQualifier for region C succeed but
> catalogJanitor.cleanMergeQualifier for region F failed as there are
> references in region F.
> When merge C and F again, it will try to cleanMergeQualifier for C and F
> again. But MetaTableAccessor.getMergeRegions will get wrong parents now. It
> use scan with filter to scan result. But region C's MergeQualifier already
> was deleted before. Then the scan will return a wrong result, may be anther
> region..
> {code:java}
> public boolean cleanMergeQualifier(final RegionInfo region) throws
> IOException {
> // Get merge regions if it is a merged region and already has merge
> qualifier
> List parents =
> MetaTableAccessor.getMergeRegions(this.services.getConnection(),
> region.getRegionName());
> if (parents == null || parents.isEmpty()) {
> // It doesn't have merge qualifier, no need to clean
> return true;
> }
> return cleanMergeRegion(region, parents);
> }
> public static List getMergeRegions(Connection connection, byte[]
> regionName)
> throws IOException {
> return getMergeRegions(getMergeRegionsRaw(connection, regionName));
> }
> private static Cell [] getMergeRegionsRaw(Connection connection, byte []
> regionName)
> throws IOException {
> Scan scan = new Scan().withStartRow(regionName).
> setOneRowLimit().
> readVersions(1).
> addFamily(HConstants.CATALOG_FAMILY).
> setFilter(new QualifierFilter(CompareOperator.EQUAL,
> new RegexStringComparator(HConstants.MERGE_QUALIFIER_PREFIX_STR+
> ".*")));
> try (Table m = getMetaHTable(connection); ResultScanner scanner =
> m.getScanner(scan)) {
> // Should be only one result in this scanner if any.
> Result result = scanner.next();
> if (result == null) {
> return null;
> }
> // Should be safe to just return all Cells found since we had filter in
> place.
> // All values should be RegionInfos or something wrong.
> return result.rawCells();
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2922: HBASE-25547: Thread pools should release unused resources
Apache-HBase commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-772946914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 38s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 7m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 33s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | +1 :green_heart: | shadedjars | 7m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 195m 27s | hbase-server in the patch passed. | | | | 226m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2922 | | JIRA Issue | HBASE-25547 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ae0297d0bdff 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/testReport/ | | Max. process+thread count | 2614 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2922: HBASE-25547: Thread pools should release unused resources
Apache-HBase commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-772916861 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 6m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 37s | hbase-server generated 5 new + 16 unchanged - 0 fixed = 21 total (was 16) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 140m 58s | hbase-server in the patch passed. | | | | 167m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2922 | | JIRA Issue | HBASE-25547 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2e96d2d5de8d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/testReport/ | | Max. process+thread count | 4101 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23044) CatalogJanitor#cleanMergeQualifier may clean wrong parent regions
[
https://issues.apache.org/jira/browse/HBASE-23044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278417#comment-17278417
]
Karthik Palanisamy commented on HBASE-23044:
Yes [~rsanwal] . Sometimes silent data-loss. Two users reported this issue
recently but we somehow recovered data from archive.
We requested users to disable NORMALIZATION or any aggressive manual region
merge.
> CatalogJanitor#cleanMergeQualifier may clean wrong parent regions
> -
>
> Key: HBASE-23044
> URL: https://issues.apache.org/jira/browse/HBASE-23044
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.6, 2.2.1, 2.1.6
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.1.7, 2.2.2
>
>
> 2019-09-17,19:42:40,539 INFO [PEWorker-1]
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=1223589,
> state=SUCCESS; GCMultipleMergedRegionsProcedure
> child={color:red}647600d28633bb2fe06b40682bab0593{color},
> parents:[81b6fc3c560a00692bc7c3cd266a626a],
> [472500358997b0dc8f0002ec86593dcf] in 2.6470sec
> 2019-09-17,19:59:54,179 INFO [PEWorker-6]
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=1223651,
> state=SUCCESS; GCMultipleMergedRegionsProcedure
> child={color:red}647600d28633bb2fe06b40682bab0593{color},
> parents:[9c52f24e0a9cc9b4959c1ebdfea29d64],
> [a623f298870df5581bcfae7f83311b33] in 1.0340sec
> The child is same region {color:red}647600d28633bb2fe06b40682bab0593{color}
> but the parent regions are different.
> MergeTableRegionProcedure#prepareMergeRegion will try to cleanMergeQualifier
> for the regions to merge.
> {code:java}
> for (RegionInfo ri: this.regionsToMerge) {
> if (!catalogJanitor.cleanMergeQualifier(ri)) {
> String msg = "Skip merging " +
> RegionInfo.getShortNameToLog(regionsToMerge) +
> ", because parent " + RegionInfo.getShortNameToLog(ri) + " has a
> merge qualifier";
> LOG.warn(msg);
> throw new MergeRegionException(msg);
> }
> {code}
> If region A and B merge to C, region D and E merge to F. When merge C and F,
> it will try to cleanMergeQualifier for C and F.
> catalogJanitor.cleanMergeQualifier for region C succeed but
> catalogJanitor.cleanMergeQualifier for region F failed as there are
> references in region F.
> When merge C and F again, it will try to cleanMergeQualifier for C and F
> again. But MetaTableAccessor.getMergeRegions will get wrong parents now. It
> use scan with filter to scan result. But region C's MergeQualifier already
> was deleted before. Then the scan will return a wrong result, may be anther
> region..
> {code:java}
> public boolean cleanMergeQualifier(final RegionInfo region) throws
> IOException {
> // Get merge regions if it is a merged region and already has merge
> qualifier
> List parents =
> MetaTableAccessor.getMergeRegions(this.services.getConnection(),
> region.getRegionName());
> if (parents == null || parents.isEmpty()) {
> // It doesn't have merge qualifier, no need to clean
> return true;
> }
> return cleanMergeRegion(region, parents);
> }
> public static List getMergeRegions(Connection connection, byte[]
> regionName)
> throws IOException {
> return getMergeRegions(getMergeRegionsRaw(connection, regionName));
> }
> private static Cell [] getMergeRegionsRaw(Connection connection, byte []
> regionName)
> throws IOException {
> Scan scan = new Scan().withStartRow(regionName).
> setOneRowLimit().
> readVersions(1).
> addFamily(HConstants.CATALOG_FAMILY).
> setFilter(new QualifierFilter(CompareOperator.EQUAL,
> new RegexStringComparator(HConstants.MERGE_QUALIFIER_PREFIX_STR+
> ".*")));
> try (Table m = getMetaHTable(connection); ResultScanner scanner =
> m.getScanner(scan)) {
> // Should be only one result in this scanner if any.
> Result result = scanner.next();
> if (result == null) {
> return null;
> }
> // Should be safe to just return all Cells found since we had filter in
> place.
> // All values should be RegionInfos or something wrong.
> return result.rawCells();
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on a change in pull request #2917: HBASE-25534 Improve the configuration of Normalizer
ndimiduk commented on a change in pull request #2917:
URL: https://github.com/apache/hbase/pull/2917#discussion_r569816933
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##
@@ -254,41 +255,38 @@ private boolean isMasterSwitchEnabled(final
MasterSwitchType masterSwitchType) {
return masterServices.isSplitOrMergeEnabled(masterSwitchType);
}
- private boolean proceedWithSplitPlanning() {
-return isSplitEnabled() && isMasterSwitchEnabled(MasterSwitchType.SPLIT);
+ private boolean proceedWithSplitPlanning(TableDescriptor tableDescriptor) {
+String value = tableDescriptor.getValue(SPLIT_ENABLED_KEY);
+return (value == null ? isSplitEnabled() : Boolean.parseBoolean(value)) &&
+ isMasterSwitchEnabled(MasterSwitchType.SPLIT);
}
- private boolean proceedWithMergePlanning() {
-return isMergeEnabled() && isMasterSwitchEnabled(MasterSwitchType.MERGE);
+ private boolean proceedWithMergePlanning(TableDescriptor tableDescriptor) {
+String value = tableDescriptor.getValue(MERGE_ENABLED_KEY);
+return (value == null ? isMergeEnabled() : Boolean.parseBoolean(value)) &&
+ isMasterSwitchEnabled(MasterSwitchType.MERGE);
}
/**
* @param tableRegions regions of table to normalize
+ * @param tableDescriptor the TableDescriptor
* @return average region size depending on
* @see
org.apache.hadoop.hbase.client.TableDescriptor#getNormalizerTargetRegionCount()
* Also make sure tableRegions contains regions of the same table
*/
- private double getAverageRegionSizeMb(final List tableRegions) {
+ private double getAverageRegionSizeMb(final List tableRegions,
+final TableDescriptor tableDescriptor) {
if (isEmpty(tableRegions)) {
throw new IllegalStateException(
"Cannot calculate average size of a table without any regions.");
}
-TableName table = tableRegions.get(0).getTable();
-int targetRegionCount = -1;
-long targetRegionSize = -1;
+TableName table = tableDescriptor.getTableName();
double avgRegionSize;
-try {
- TableDescriptor tableDescriptor =
masterServices.getTableDescriptors().get(table);
- if (tableDescriptor != null) {
-targetRegionCount = tableDescriptor.getNormalizerTargetRegionCount();
-targetRegionSize = tableDescriptor.getNormalizerTargetRegionSize();
-LOG.debug("Table {} configured with target region count {}, target
region size {}", table,
- targetRegionCount, targetRegionSize);
- }
-} catch (IOException e) {
- LOG.warn("TableDescriptor for {} unavailable, table-level target region
count and size"
-+ " configurations cannot be considered.", table, e);
-}
+long targetRegionCount = tableDescriptor.getNormalizerTargetRegionCount();
Review comment:
nit: no need to promote this to a `long`.
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java
##
@@ -292,12 +293,28 @@ public void testHonorsSplitEnabled() {
createRegionSizesMap(regionInfos, 5, 5, 20, 5, 5);
setupMocksForNormalizer(regionSizes, regionInfos);
assertThat(
- normalizer.computePlansForTable(tableName),
+ normalizer.computePlansForTable(tableDescriptor),
contains(instanceOf(SplitNormalizationPlan.class)));
conf.setBoolean(SPLIT_ENABLED_KEY, false);
setupMocksForNormalizer(regionSizes, regionInfos);
-assertThat(normalizer.computePlansForTable(tableName), empty());
+assertThat(normalizer.computePlansForTable(tableDescriptor), empty());
+ }
+
+ @Test
+ public void testHonorsSplitEnabledInTD() {
Review comment:
These tests `*EnabledInTD` are good for confirming that the split/merge
will not happen when disabled in table descriptor. Please also add coverage of
when split/merge is disabled in configuration but enabled in table descriptor.
I believe this should be supported, given the new implementations of
`proceedWith{Split,Merge}Planning`.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##
@@ -316,10 +314,10 @@ private double getAverageRegionSizeMb(final
List tableRegions) {
*/
private boolean skipForMerge(
final NormalizerConfiguration normalizerConfiguration,
-final RegionStates regionStates,
+final NormalizeContext ctx,
Review comment:
good.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##
@@ -592,5 +621,14 @@ public RegionStates getRegionStates() {
public double getAverageRegionSizeMb() {
return averageRegionSizeMb;
}
+
+public T getOrDefault(String key, Function function, T
defaultValue) {
Review comment:
nice.
Maybe this method returns an `Object`/`null` and the caller handles the
[GitHub] [hbase] Apache-HBase commented on pull request #2922: HBASE-25547: Thread pools should release unused resources
Apache-HBase commented on pull request #2922: URL: https://github.com/apache/hbase/pull/2922#issuecomment-772859689 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 37s | master passed | | +1 :green_heart: | compile | 3m 7s | master passed | | +1 :green_heart: | checkstyle | 1m 7s | master passed | | +1 :green_heart: | spotbugs | 1m 59s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 3m 8s | the patch passed | | +1 :green_heart: | javac | 3m 8s | the patch passed | | -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 2 new + 163 unchanged - 0 fixed = 165 total (was 163) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 20s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 45m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2922 | | JIRA Issue | HBASE-25547 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux e19783f96501 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2922/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25547) Thread pools should release unused resources
[ https://issues.apache.org/jira/browse/HBASE-25547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25547: - Status: Patch Available (was: Open) > Thread pools should release unused resources > > > Key: HBASE-25547 > URL: https://issues.apache.org/jira/browse/HBASE-25547 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 3.0.0-alpha-1, 1.7.0, 2.5.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Minor > > On this [PR|https://github.com/apache/hbase/pull/2909] [~stack] rightly > pointed out that the thread pool just spins up threads that remain idle for > 99.999% of time. Java's > [ThreadPoolExecutor|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/concurrent/ThreadPoolExecutor.html] > lets us tune some configurations like the following for releasing the unused > resources > * corePoolSize > * keepAliveTimeMs > * allowCoreThreadTimeOut > Current code makes it difficult to pass along these configurations to the > executor service. Refactor and fix the defaults for low-priority thread pools > to release resources quicker. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2923: HBASE-25548 Optionally allow snapshots to preserve cluster's max file…
Apache-HBase commented on pull request #2923: URL: https://github.com/apache/hbase/pull/2923#issuecomment-772794214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 6m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 6m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 148m 54s | hbase-server in the patch failed. | | | | 175m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2923 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 80072e5c5c14 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/testReport/ | | Max. process+thread count | 3755 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2923: HBASE-25548 Optionally allow snapshots to preserve cluster's max file…
Apache-HBase commented on pull request #2923: URL: https://github.com/apache/hbase/pull/2923#issuecomment-772787869 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 44s | master passed | | +1 :green_heart: | compile | 1m 19s | master passed | | +1 :green_heart: | shadedjars | 7m 33s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | +1 :green_heart: | shadedjars | 6m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 135m 16s | hbase-server in the patch failed. | | | | 165m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2923 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0682cccdf06c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-11.0.6+10 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/testReport/ | | Max. process+thread count | 4320 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25546) PerfTestCompactionPolicies is failing because of NPE
[
https://issues.apache.org/jira/browse/HBASE-25546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278326#comment-17278326
]
Hudson commented on HBASE-25546:
Results for branch master
[build #202 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/202/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/202/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/202/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/202/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> PerfTestCompactionPolicies is failing because of NPE
>
>
> Key: HBASE-25546
> URL: https://issues.apache.org/jira/browse/HBASE-25546
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0-alpha-1
>Reporter: Robin Roy
>Assignee: Robin Roy
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> PerfTestCompactionPolicies is failing because of NPE as
> {code:java}
> s.getRegionInfo(){code}
> mock is missing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25249) Adding StoreContext
[ https://issues.apache.org/jira/browse/HBASE-25249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278322#comment-17278322 ] Tanuj Khurana commented on HBASE-25249: --- Thanks [~taklwu] > Adding StoreContext > --- > > Key: HBASE-25249 > URL: https://issues.apache.org/jira/browse/HBASE-25249 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1, 2.4.0, 2.3.4 >Reporter: Abhishek Khanna >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > > Adding StoreContext which contains the metadata about the HStore. This meta > data can be used across the HFileWriter/Readers and other HStore consumers > without the need of passing around the complete store and exposing its > internals. This is a refactoring change which cleans up the existing code so > that the following commits can leverage the context for a more maintainable > code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25249) Adding StoreContext
[ https://issues.apache.org/jira/browse/HBASE-25249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278289#comment-17278289 ] Tak-Lon (Stephen) Wu commented on HBASE-25249: -- Thanks [~vjasani] To [~tkhurana] , it's a minor change and you can use StoreUtils ([see the changes in PR as example)|https://github.com/apache/hbase/pull/2800/files#diff-7ae1bdb47789f509c71be0964985591dc1f67cc61bcb86d87e9fc561bbe07665R373-R374] and replace HStore in that [two lines|https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/mapreduce/MultiHfileOutputFormat.java#L261-L262] > Adding StoreContext > --- > > Key: HBASE-25249 > URL: https://issues.apache.org/jira/browse/HBASE-25249 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1, 2.4.0, 2.3.4 >Reporter: Abhishek Khanna >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > > Adding StoreContext which contains the metadata about the HStore. This meta > data can be used across the HFileWriter/Readers and other HStore consumers > without the need of passing around the complete store and exposing its > internals. This is a refactoring change which cleans up the existing code so > that the following commits can leverage the context for a more maintainable > code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2923: HBASE-25548 Optionally allow snapshots to preserve cluster's max file…
Apache-HBase commented on pull request #2923: URL: https://github.com/apache/hbase/pull/2923#issuecomment-772712261 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | master passed | | +1 :green_heart: | compile | 3m 34s | master passed | | +1 :green_heart: | checkstyle | 1m 10s | master passed | | +1 :green_heart: | spotbugs | 2m 9s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 46s | the patch passed | | +1 :green_heart: | compile | 3m 17s | the patch passed | | +1 :green_heart: | javac | 3m 17s | the patch passed | | -0 :warning: | checkstyle | 1m 1s | hbase-server: The patch generated 6 new + 17 unchanged - 0 fixed = 23 total (was 17) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 18m 1s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 48m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2923 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux ebb9649cf031 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2923/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil opened a new pull request #2923: HBASE-25548 Optionally allow snapshots to preserve cluster's max file…
wchevreuil opened a new pull request #2923: URL: https://github.com/apache/hbase/pull/2923 …size config by setting it into table descriptor This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-25548) Optionally allow snapshots to preserve cluster's max filesize config by setting it into table descriptor
Wellington Chevreuil created HBASE-25548: Summary: Optionally allow snapshots to preserve cluster's max filesize config by setting it into table descriptor Key: HBASE-25548 URL: https://issues.apache.org/jira/browse/HBASE-25548 Project: HBase Issue Type: Improvement Reporter: Wellington Chevreuil Assignee: Wellington Chevreuil While using snapshots for data migration, if the source cluster has non-default definition for *hbase.hregion.max.filesize*, table being snapshotted doesn't have *MAX_FILESIZE* attribute set, then if snapshot is exported to a separate cluster with different value for *hbase.hregion.max.filesize*, any cloned table will not respect the original value. In cases where the original cluster had a much larger value set to *hbase.hregion.max.filesize* then the destination cluster, restoring snapshot can trigger a storm of splits. This Jira introduces an optional configuration (disabled by default) that allows for the *hbase.hregion.max.filesize* value to be saved within the table *MAX_FILESIZE* descriptor at snapshot creation time. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25545) Fix the build problem for branch-2.2
[ https://issues.apache.org/jira/browse/HBASE-25545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-25545: --- Fix Version/s: 2.2.7 > Fix the build problem for branch-2.2 > > > Key: HBASE-25545 > URL: https://issues.apache.org/jira/browse/HBASE-25545 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.2.7 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 2.2.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25545) Fix the build problem for branch-2.2
[ https://issues.apache.org/jira/browse/HBASE-25545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25545. Resolution: Fixed Pushed to branch-2.2. Thanks [~meiyi] for reviewing. > Fix the build problem for branch-2.2 > > > Key: HBASE-25545 > URL: https://issues.apache.org/jira/browse/HBASE-25545 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.2.7 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25528) Dedicated merge dispatch threadpool on master
[
https://issues.apache.org/jira/browse/HBASE-25528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277969#comment-17277969
]
Hudson commented on HBASE-25528:
Results for branch branch-1
[build #81 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/81/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/81//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/81//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/81//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Dedicated merge dispatch threadpool on master
> -
>
> Key: HBASE-25528
> URL: https://issues.apache.org/jira/browse/HBASE-25528
> Project: HBase
> Issue Type: Improvement
> Components: master
>Affects Versions: 3.0.0-alpha-1, 1.7.0, 2.5.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> Over the weekend we ran into an issue of running normalizer on a table with
> ~400k regions and we noticed the master was bottlenecked on merge dispatcher
> code that runs on a single threaded thread-pool that was meant for all master
> table operations (opcode: MASTER_TABLE_OPERATIONS). Having a dedicated
> thread-pool helped us dispatch merges at a faster rate.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2919: HBASE-25543 When configuration "hadoop.security.authorization" is set to false, the system will still try to authorize an RPC and raise A
Apache-HBase commented on pull request #2919: URL: https://github.com/apache/hbase/pull/2919#issuecomment-772339687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 6m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 6m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 145m 21s | hbase-server in the patch passed. | | | | 173m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2919 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 60b1dc6285e5 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/3/testReport/ | | Max. process+thread count | 3918 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2919: HBASE-25543 When configuration "hadoop.security.authorization" is set to false, the system will still try to authorize an RPC and raise A
Apache-HBase commented on pull request #2919: URL: https://github.com/apache/hbase/pull/2919#issuecomment-772336632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 6m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 6m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 140m 23s | hbase-server in the patch passed. | | | | 168m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2919 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9d47e213ce2e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6d67d1e9f | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/3/testReport/ | | Max. process+thread count | 4500 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean edited a comment on pull request #2919: HBASE-25543 When configuration "hadoop.security.authorization" is set to false, the system will still try to authorize an RPC and raise
YutSean edited a comment on pull request #2919: URL: https://github.com/apache/hbase/pull/2919#issuecomment-772326682 > Thanks @YutSean . Can you confirm if QA failure for test is relevant: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/2/testReport/org.apache.hadoop.hbase.client/TestFromClientSideWithCoprocessor5/precommit_checks___yetus_jdk8_Hadoop3_checks___testAppendWithoutWAL_1_/ From the out put, the QA failure results from a wrong version of HDFS. That is not relevant. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #2919: HBASE-25543 When configuration "hadoop.security.authorization" is set to false, the system will still try to authorize an RPC and raise Access
YutSean commented on pull request #2919: URL: https://github.com/apache/hbase/pull/2919#issuecomment-772326682 > Thanks @YutSean . Can you confirm if QA failure for test is relevant: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/2/testReport/org.apache.hadoop.hbase.client/TestFromClientSideWithCoprocessor5/precommit_checks___yetus_jdk8_Hadoop3_checks___testAppendWithoutWAL_1_/ From the out put, the QA failure is a wrong version of HDFS. That is not relevant. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2919: HBASE-25543 When configuration "hadoop.security.authorization" is set to false, the system will still try to authorize an RPC and raise Ac
virajjasani commented on pull request #2919: URL: https://github.com/apache/hbase/pull/2919#issuecomment-772322189 Thanks @YutSean . Can you confirm if QA failure for test is relevant: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2919/2/testReport/org.apache.hadoop.hbase.client/TestFromClientSideWithCoprocessor5/precommit_checks___yetus_jdk8_Hadoop3_checks___testAppendWithoutWAL_1_/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-25249) Adding StoreContext
[ https://issues.apache.org/jira/browse/HBASE-25249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277783#comment-17277783 ] Viraj Jasani edited comment on HBASE-25249 at 2/3/21, 8:06 AM: --- [~tkhurana] HStore is IA.Private and patch releases can remove/refactor IA.Private APIs, only if IA.Public/IA.LP APIs are removed in patch release, they are considered incompatible. For Phoenix, new module is required to support HBase 4.1+ releases as long as these IA.Private APIs are being used. was (Author: vjasani): [~tkhurana] HStore is IA.Private and patch releases can remove/refactor IA.Private APIs, only if IA.Public/IA.LP APIs are removed in patch release, they are considered backward compatibility issue. For Phoenix, new module is required to support HBase 4.1+ releases as long as these IA.Private APIs are being used. > Adding StoreContext > --- > > Key: HBASE-25249 > URL: https://issues.apache.org/jira/browse/HBASE-25249 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1, 2.4.0, 2.3.4 >Reporter: Abhishek Khanna >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > > Adding StoreContext which contains the metadata about the HStore. This meta > data can be used across the HFileWriter/Readers and other HStore consumers > without the need of passing around the complete store and exposing its > internals. This is a refactoring change which cleans up the existing code so > that the following commits can leverage the context for a more maintainable > code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] YutSean commented on pull request #2919: HBASE-25543 When configuration "hadoop.security.authorization" is set to false, the system will still try to authorize an RPC and raise Access
YutSean commented on pull request #2919: URL: https://github.com/apache/hbase/pull/2919#issuecomment-772315076 > Test failure doesn't seem relevant, re-triggered the build. I tried to write the test but it is a bit difficult for me. But we have used it in our live cluster and works fine. There is the log information of our cluster before: 2021-01-19 18:41:40,043 DEBUG [RpcServer.reader=11,bindAddress=*] ipc.RpcServer : Connection authorization failed: User: AA is not allowed to impersonate BB org.apache.hadoop.security.authorize.AuthorizationException: User: AA is not allowed to impersonate BB After this patching, it works fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25249) Adding StoreContext
[ https://issues.apache.org/jira/browse/HBASE-25249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277783#comment-17277783 ] Viraj Jasani commented on HBASE-25249: -- [~tkhurana] HStore is IA.Private and patch releases can remove/refactor IA.Private APIs, only if IA.Public/IA.LP APIs are removed in patch release, they are considered backward compatibility issue. For Phoenix, new module is required to support HBase 4.1+ releases as long as these IA.Private APIs are being used. > Adding StoreContext > --- > > Key: HBASE-25249 > URL: https://issues.apache.org/jira/browse/HBASE-25249 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1, 2.4.0, 2.3.4 >Reporter: Abhishek Khanna >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1 > > > Adding StoreContext which contains the metadata about the HStore. This meta > data can be used across the HFileWriter/Readers and other HStore consumers > without the need of passing around the complete store and exposing its > internals. This is a refactoring change which cleans up the existing code so > that the following commits can leverage the context for a more maintainable > code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
