[jira] [Commented] (HBASE-25904) Client integration test is failing on master and branch-2

2021-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351504#comment-17351504
 ] 

Hudson commented on HBASE-25904:


Results for branch HBASE-25904
[build #5 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/HBASE-25904/5/]:
 (x) *{color:red}-1 overall{color}*

details (if available):











(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/HBASE-25904/5//console].


> Client integration test is failing on master and branch-2
> -
>
> Key: HBASE-25904
> URL: https://issues.apache.org/jira/browse/HBASE-25904
> Project: HBase
>  Issue Type: Task
>  Components: integration tests
>Reporter: Duo Zhang
>Assignee: Nick Dimiduk
>Priority: Major
>
> {noformat}
> Starting up HBase
> 127.0.0.1: Host key verification failed.
> running master, logging to 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase7.out
> 2021-05-22T04:16:40,142 INFO  [main] master.HMaster: STARTING service HMaster
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Source code repository 
> file:///home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/unpacked_src_tarball
>  revision=Unknown
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Compiled by jenkins on 
> Sat May 22 04:07:41 UTC 2021
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: From source with 
> checksum 
> b6959885410c34f4458efd580213907ca50e84a0a900ea1d465d04a1a9480e520419d51da933547e3f517850a2913a8e8aefbcd6ba9e12589fced980910fb941
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh:
>  line 539:  3122 Terminated  sleep "${sleep_time}"
> Shutting down HBase
> no hbase master found
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3124:
URL: https://github.com/apache/hbase/pull/3124#issuecomment-848476718


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 34s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 45s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 49s |  master passed  |
   | +1 :green_heart: |  shadedjars  |  10m 46s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 13s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 46s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |  10m 46s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 26s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 156m  5s |  hbase-server in the patch passed.  
|
   |  |   | 199m  6s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3124 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux da98b9c0d1f4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/testReport/
 |
   | Max. process+thread count | 4068 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848459191


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 29s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 54s |  master passed  |
   | +1 :green_heart: |  compile  |   6m 41s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m  5s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m  7s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 35s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 38s |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 38s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m  9s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m  6s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 48s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  |   1m 11s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |   0m 47s |  hbase-zookeeper in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 42s |  hbase-balancer in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 48s |  hbase-http in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 51s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 155m  5s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |  12m 17s |  hbase-mapreduce in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   7m 42s |  hbase-thrift in the patch passed.  
|
   | +1 :green_heart: |  unit  |   3m  8s |  hbase-endpoint in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  10m 26s |  hbase-backup in the patch passed.  
|
   | +1 :green_heart: |  unit  |   1m 25s |  hbase-it in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 38s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   2m 27s |  hbase-examples in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 53s |  hbase-hbtop in the patch passed.  |
   |  |   | 264m 41s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3302 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 3b082b4b4cef 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | unit | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/testReport/
 |
   | Max. process+thread count | 5110 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer 
hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift 
hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . 
|
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848453843


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  1s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   7m 15s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 15s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m 54s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 13s |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 12s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m  7s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m 48s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 51s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  |   1m 18s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |   0m 46s |  hbase-zookeeper in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 58s |  hbase-balancer in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 47s |  hbase-http in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 46s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 145m 48s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |  10m 33s |  hbase-mapreduce in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   7m 27s |  hbase-thrift in the patch passed.  
|
   | +1 :green_heart: |  unit  |   2m 56s |  hbase-endpoint in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   8m 55s |  hbase-backup in the patch passed.  
|
   | +1 :green_heart: |  unit  |   1m 15s |  hbase-it in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m  9s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 59s |  hbase-examples in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m 56s |  hbase-hbtop in the patch passed.  |
   |  |   | 254m 33s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3302 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 51029fb4b05a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | unit | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/testReport/
 |
   | Max. process+thread count | 5050 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer 
hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift 
hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . 
|
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3311: Backport "HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`" to branch

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3311:
URL: https://github.com/apache/hbase/pull/3311#issuecomment-848452774


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  3s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  1s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 16s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   4m 26s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 35s |  branch-2 passed  |
   | +0 :ok: |  refguide  |   4m 11s |  branch has no errors when building the 
reference guide. See footer for rendered docs, which you should manually 
inspect.  |
   | +1 :green_heart: |  spotbugs  |   3m  1s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 41s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 29s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 29s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   1m 13s |  hbase-server: The patch 
generated 2 new + 11 unchanged - 2 fixed = 13 total (was 13)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML 
file.  |
   | +0 :ok: |  refguide  |   3m 38s |  patch has no errors when building the 
reference guide. See footer for rendered docs, which you should manually 
inspect.  |
   | +1 :green_heart: |  hadoopcheck  |  13m  1s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1.  |
   | +1 :green_heart: |  spotbugs  |   3m 36s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 26s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  58m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3311/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3311 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
checkstyle compile refguide xml |
   | uname | Linux d22cc198889e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / f7358cd618 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | refguide | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3311/1/artifact/yetus-general-check/output/branch-site/book.html
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3311/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | refguide | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3311/1/artifact/yetus-general-check/output/patch-site/book.html
 |
   | Max. process+thread count | 96 (vs. ulimit of 12500) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3311/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (HBASE-25918) Upgrade hbase-thirdparty dependency to 3.5.0

2021-05-25 Thread Pankaj Kumar (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pankaj Kumar updated HBASE-25918:
-
Issue Type: Task  (was: Bug)

> Upgrade hbase-thirdparty dependency to 3.5.0
> 
>
> Key: HBASE-25918
> URL: https://issues.apache.org/jira/browse/HBASE-25918
> Project: HBase
>  Issue Type: Task
>  Components: dependencies
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> Recently we have fixed multiple CVEs from jetty & netty as part of 
> HBASE-25728 & HBASE-25746.  This Jira is to upgrade hbase-thirdparty jar 
> version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25745) Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`

2021-05-25 Thread Baiqiang Zhao (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351469#comment-17351469
 ] 

Baiqiang Zhao commented on HBASE-25745:
---

Put up a PR for branch-2.

> Deprecate/Rename config `hbase.normalizer.min.region.count` to 
> `hbase.normalizer.merge.min.region.count`
> 
>
> Key: HBASE-25745
> URL: https://issues.apache.org/jira/browse/HBASE-25745
> Project: HBase
>  Issue Type: Improvement
>  Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Baiqiang Zhao
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> After HBASE-24416, {{hbase.normalizer.min.region.count}} only applies to 
> merge plans. Let's deprecate/rename the configuration key so that it is clear 
> in what context it applies, and so that it matches the configuration 
> structure of related keys.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] ZhaoBQ opened a new pull request #3311: Backport "HBASE-25745 Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`" to branch-2

2021-05-25 Thread GitBox


ZhaoBQ opened a new pull request #3311:
URL: https://github.com/apache/hbase/pull/3311


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-operator-tools] joshelser commented on a change in pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread GitBox


joshelser commented on a change in pull request #88:
URL: 
https://github.com/apache/hbase-operator-tools/pull/88#discussion_r639381306



##
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java
##
@@ -1535,7 +1535,7 @@ private void loadHdfsRegioninfo(HbckInfo hbi) throws 
IOException {
   return;
 }
 
-FileSystem fs = FileSystem.get(getConf());
+FileSystem fs = FSUtils.getCurrentFileSystem(getConf());

Review comment:
   In master, it looks like FSUtils no longer extends CommonFSUtils and 
thus, I don't think this would compile. Glancing over branches, I think you 
could make this `CommonFSUtils.getCurrentFileSystem(Configuration)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3310:
URL: https://github.com/apache/hbase/pull/3310#issuecomment-848432677


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  8s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 34s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 51s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 17s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 57s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 58s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  5s |  root in master failed.  |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  6s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  5s |  root in the patch failed.  |
   | -0 :warning: |  javac  |   0m  5s |  root in the patch failed.  |
   | -1 :x: |  shadedjars  |   0m  3s |  patch has 12 errors when building our 
shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m  6s |  root in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  5s |  hbase-common in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  6s |  hbase-shaded in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  5s |  hbase-shaded-client in the patch 
failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m  5s |  root in the patch failed.  |
   |  |   |  25m 10s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3310 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux a0bd6513624d 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
 |
   | shadedjars | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-shaded.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-shaded_hbase-shaded-client.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/testReport/
 |
   | Max. process+thread count | 125 (vs. ulimit of 3) |
   | modules | C: . hbase-common hbase-shaded hbase-shaded/hbase-shaded-client 
U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3310:
URL: https://github.com/apache/hbase/pull/3310#issuecomment-848431709


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 26s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 54s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 33s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 13s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 57s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  6s |  root in master failed.  |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  6s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  6s |  root in the patch failed.  |
   | -0 :warning: |  javac  |   0m  6s |  root in the patch failed.  |
   | -1 :x: |  shadedjars  |   0m  4s |  patch has 12 errors when building our 
shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m  6s |  root in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  6s |  hbase-common in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  6s |  hbase-shaded in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  6s |  hbase-shaded-client in the patch 
failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m  6s |  root in the patch failed.  |
   |  |   |  21m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3310 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux fe073420444f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt
 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
 |
   | shadedjars | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-root.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-common.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-shaded.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-shaded_hbase-shaded-client.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/testReport/
 |
   | Max. process+thread count | 132 (vs. ulimit of 3) |
   | modules | C: . hbase-common hbase-shaded hbase-shaded/hbase-shaded-client 
U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above 

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #88:
URL: 
https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-848431044


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  spotbugs  |   0m  0s |  spotbugs executables are not available. 
 |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
2 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 53s |  master passed  |
   | +1 :green_heart: |  compile  |   0m  9s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m  7s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m  8s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m  9s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m  9s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m  4s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m  5s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   4m 44s |  hbase-hbck2 in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m  6s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   7m 17s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-88/2/artifact/yetus-precommit-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/88 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
checkstyle compile |
   | uname | Linux 9c82051cd414 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 
23:32:25 UTC 2021 x86_64 GNU/Linux |
   | Build tool | maven |
   | git revision | master / 33d4c31 |
   | Default Java | Oracle Corporation-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-88/2/testReport/
 |
   | Max. process+thread count | 970 (vs. ulimit of 5000) |
   | modules | C: hbase-hbck2 U: hbase-hbck2 |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-88/2/console
 |
   | versions | git=2.20.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3309: HBASE-25758 Move MetaTableAccessor out of hbase-balancer module

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3309:
URL: https://github.com/apache/hbase/pull/3309#issuecomment-848431088


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m  1s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 49s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 23s |  master passed  |
   | +1 :green_heart: |  spotbugs  |   2m 46s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 49s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 50s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 30s |  hbase-balancer generated 0 new + 
19 unchanged - 11 fixed = 19 total (was 30)  |
   | +1 :green_heart: |  javac  |   3m 19s |  hbase-server in the patch passed. 
 |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  hbase-balancer: The patch 
generated 0 new + 20 unchanged - 16 fixed = 20 total (was 36)  |
   | -0 :warning: |  checkstyle  |   1m  5s |  hbase-server: The patch 
generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  19m 52s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | +1 :green_heart: |  spotbugs  |   3m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 25s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  54m 26s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3309/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3309 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
checkstyle compile |
   | uname | Linux 5c3fac18e54d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3309/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 96 (vs. ulimit of 3) |
   | modules | C: hbase-balancer hbase-server U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3309/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3310:
URL: https://github.com/apache/hbase/pull/3310#issuecomment-848430748


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  7s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 17s |  master passed  |
   | +1 :green_heart: |  compile  |   8m 49s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  5s |  root in master failed.  |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  6s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  5s |  root in the patch failed.  |
   | -0 :warning: |  javac  |   0m  5s |  root in the patch failed.  |
   | -0 :warning: |  whitespace  |   0m  0s |  The patch 2 line(s) with tabs.  |
   | -1 :x: |  xml  |   0m  5s |  The patch has 1 ill-formed XML file(s).  |
   | -1 :x: |  hadoopcheck  |   0m  3s |  The patch causes 12 errors with 
Hadoop v3.1.2.  |
   | -1 :x: |  hadoopcheck  |   0m  6s |  The patch causes 12 errors with 
Hadoop v3.2.1.  |
   | -1 :x: |  hadoopcheck  |   0m  9s |  The patch causes 12 errors with 
Hadoop v3.3.0.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m 21s |  ASF License check generated no 
output?  |
   |  |   |  17m 22s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | XML | Parsing Error(s): |
   |   | pom.xml |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3310 |
   | Optional Tests | dupname asflicense javac hadoopcheck xml compile |
   | uname | Linux dba965a5ca56 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 
06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-compile-root.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-compile-root.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/whitespace-tabs.txt
 |
   | xml | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/xml.txt
 |
   | hadoopcheck | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
 |
   | hadoopcheck | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
 |
   | hadoopcheck | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
 |
   | Max. process+thread count | 126 (vs. ulimit of 3) |
   | modules | C: . hbase-common hbase-shaded hbase-shaded/hbase-shaded-client 
U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3310/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-operator-tools] taklwu commented on pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread GitBox


taklwu commented on pull request #88:
URL: 
https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-848429515


   @jojochuang you got me lol, I was wondered if I can create directly but I go 
back to create a JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-operator-tools] taklwu edited a comment on pull request #88: HBASE-25921 Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread GitBox


taklwu edited a comment on pull request #88:
URL: 
https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-848429515


   @jojochuang you got me lol, I was wondered if I can create the PR directly 
but I go back to create a JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (HBASE-25921) Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread Tak-Lon (Stephen) Wu (Jira)
Tak-Lon (Stephen) Wu created HBASE-25921:


 Summary: Fix Wrong FileSystem when running `filesystem` on 
non-HDFS storage
 Key: HBASE-25921
 URL: https://issues.apache.org/jira/browse/HBASE-25921
 Project: HBase
  Issue Type: Bug
  Components: hbase-operator-tools
Affects Versions: 1.2.0, 1.1.0, 1.0.0
Reporter: Tak-Lon (Stephen) Wu
Assignee: Tak-Lon (Stephen) Wu


recently we found a bug that when running {{hbck filesystem -f}} on a non-HDFS 
and caused {{Wrong FS}} error and cannot move forward.

this change fix this problem and use {{FSUtils.getCurrentFileSystem}} to 
respect the root directory of what we set with {{hbase.rootdir}} in stead of 
just using {{fs.defaultFS}}




e.g. this is one of the captured ERROR message


 {code}
Exception in thread "main" java.lang.IllegalArgumentException: Wrong FS: 
s3://xyz/data/default/abc, expected: hdfs://xyz/
at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:737)
at 
org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:233)
at 
org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:1045)
at 
org.apache.hadoop.hdfs.DistributedFileSystem.access$1000(DistributedFileSystem.java:131)
at 
org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1112)
at 
org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1109)
at 
org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
at 
org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:1119)
at 
org.apache.hadoop.hbase.util.FSUtils.listStatusWithStatusFilter(FSUtils.java:1530)
at 
org.apache.hbase.hbck1.HFileCorruptionChecker.checkTableDir(HFileCorruptionChecker.java:320)
at 
org.apache.hbase.hbck1.HFileCorruptionChecker.checkTables(HFileCorruptionChecker.java:431)
at org.apache.hbase.FileSystemFsck.fsck(FileSystemFsck.java:87)
at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:721)
at org.apache.hbase.HBCK2.run(HBCK2.java:631)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
at org.apache.hbase.HBCK2.main(HBCK2.java:865)

 {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #88: Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #88:
URL: 
https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-848426118


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  1s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  spotbugs  |   0m  0s |  spotbugs executables are not available. 
 |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
2 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 46s |  master passed  |
   | +1 :green_heart: |  compile  |   0m  9s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m  7s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m  7s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m  8s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m  8s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m  4s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   0m  5s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   4m 34s |  hbase-hbck2 in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m  6s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   7m 26s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-88/1/artifact/yetus-precommit-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/88 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
checkstyle compile |
   | uname | Linux 7cc0cbb4d9d4 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 
23:32:25 UTC 2021 x86_64 GNU/Linux |
   | Build tool | maven |
   | git revision | master / 33d4c31 |
   | Default Java | Oracle Corporation-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-88/1/testReport/
 |
   | Max. process+thread count | 951 (vs. ulimit of 5000) |
   | modules | C: hbase-hbck2 U: hbase-hbck2 |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-88/1/console
 |
   | versions | git=2.20.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] jojochuang opened a new pull request #3310: HBASE-25920 WIP. Test patch for Hadoop 3.3.1 support

2021-05-25 Thread GitBox


jojochuang opened a new pull request #3310:
URL: https://github.com/apache/hbase/pull/3310


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3124:
URL: https://github.com/apache/hbase/pull/3124#issuecomment-848425588


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 32s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 57s |  master passed  |
   | +1 :green_heart: |  compile  |   2m  4s |  master passed  |
   | +1 :green_heart: |  shadedjars  |  10m 13s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 19s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 48s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 11s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 11s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   9m 59s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 19s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 52s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  |  13m 13s |  hbase-server in the patch failed.  |
   |  |   |  58m  9s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3124 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux e322167d90c3 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | unit | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/testReport/
 |
   | Max. process+thread count | 668 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-operator-tools] taklwu edited a comment on pull request #88: Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread GitBox


taklwu edited a comment on pull request #88:
URL: 
https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-848424321


   e.g. this is one of the captured ERROR message 
   
   ```
   Exception in thread "main" java.lang.IllegalArgumentException: Wrong FS: 
s3://xyz/data/default/abc, expected: hdfs://xyz/
   at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:737)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:233)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:1045)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem.access$1000(DistributedFileSystem.java:131)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1112)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1109)
   at 
org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:1119)
   at 
org.apache.hadoop.hbase.util.FSUtils.listStatusWithStatusFilter(FSUtils.java:1530)
   at 
org.apache.hbase.hbck1.HFileCorruptionChecker.checkTableDir(HFileCorruptionChecker.java:320)
   at 
org.apache.hbase.hbck1.HFileCorruptionChecker.checkTables(HFileCorruptionChecker.java:431)
   at org.apache.hbase.FileSystemFsck.fsck(FileSystemFsck.java:87)
   at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:721)
   at org.apache.hbase.HBCK2.run(HBCK2.java:631)
   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
   at org.apache.hbase.HBCK2.main(HBCK2.java:865)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3124:
URL: https://github.com/apache/hbase/pull/3124#issuecomment-848424370


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 26s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 52s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 15s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 32s |  master passed  |
   | +1 :green_heart: |  spotbugs  |   3m  4s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 37s |  the patch passed  |
   | -1 :x: |  compile  |   0m 43s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javac  |   0m 43s |  hbase-client in the patch failed.  |
   | -0 :warning: |  checkstyle  |   0m 28s |  hbase-client: The patch 
generated 4 new + 55 unchanged - 1 fixed = 59 total (was 56)  |
   | -0 :warning: |  checkstyle  |   1m  4s |  hbase-server: The patch 
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  19m  0s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | +1 :green_heart: |  spotbugs  |   3m 47s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 24s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  54m 22s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3124 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
checkstyle compile |
   | uname | Linux 9e190936a932 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | compile | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 96 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3124/5/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-operator-tools] taklwu commented on pull request #88: Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread GitBox


taklwu commented on pull request #88:
URL: 
https://github.com/apache/hbase-operator-tools/pull/88#issuecomment-848424321


   e.g you this is one of the captured ERROR message 
   
   ```
   Exception in thread "main" java.lang.IllegalArgumentException: Wrong FS: 
s3://xyz/data/default/abc, expected: hdfs://xyz/
   at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:737)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:233)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:1045)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem.access$1000(DistributedFileSystem.java:131)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1112)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1109)
   at 
org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
   at 
org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:1119)
   at 
org.apache.hadoop.hbase.util.FSUtils.listStatusWithStatusFilter(FSUtils.java:1530)
   at 
org.apache.hbase.hbck1.HFileCorruptionChecker.checkTableDir(HFileCorruptionChecker.java:320)
   at 
org.apache.hbase.hbck1.HFileCorruptionChecker.checkTables(HFileCorruptionChecker.java:431)
   at org.apache.hbase.FileSystemFsck.fsck(FileSystemFsck.java:87)
   at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:721)
   at org.apache.hbase.HBCK2.run(HBCK2.java:631)
   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
   at org.apache.hbase.HBCK2.main(HBCK2.java:865)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase-operator-tools] taklwu opened a new pull request #88: Fix Wrong FileSystem when running `filesystem` on non-HDFS storage

2021-05-25 Thread GitBox


taklwu opened a new pull request #88:
URL: https://github.com/apache/hbase-operator-tools/pull/88


   recently we found a bug that when running `hbck filesystem -f` on a non-HDFS 
and caused `Wrong FS` error and cannot move forward. 
   
   this change fix this problem and use `FSUtils.getCurrentFileSystem` to 
respect the root directory of what we set with `hbase.rootdir` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-25 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25890.
---
Resolution: Fixed

> [branch-1] add -U for maven build to force a check for updated releases and 
> snapshots on remote repositories
> 
>
> Key: HBASE-25890
> URL: https://issues.apache.org/jira/browse/HBASE-25890
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Blocker
> Fix For: 1.7.0
>
>
> {code}
> [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve 
> dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Could not 
> find artifact org.apache.hbase:hbase-thrift:jar:1.7.0 in apache release 
> (https://repository.apache.org/content/repositories/releases/) -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :hbase-assembly
> {code}
> {code}
> [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve 
> dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Failure 
> to find org.apache.hbase:hbase-thrift:jar:1.7.0 in 
> https://repository.apache.org/content/repositories/releases/ was cached in 
> the local repository, resolution will not be reattempted until the update 
> interval of apache release has elapsed or updates are forced -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :hbase-assembly
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-25890) [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories

2021-05-25 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-25890:
--
 Component/s: build
Release Note: 
To fix this, I defined two profiles for jdk7 & jdk8. The latter one includes 
hbase-assembly, the others not. So we could avoid when building with jdk7 will 
include hbase-thrift which built by jdk8.

Therefore, if any client requires hbase-thrift module, should download source 
codes and build it with jdk8.

> [branch-1] add -U for maven build to force a check for updated releases and 
> snapshots on remote repositories
> 
>
> Key: HBASE-25890
> URL: https://issues.apache.org/jira/browse/HBASE-25890
> Project: HBase
>  Issue Type: Task
>  Components: build
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Blocker
> Fix For: 1.7.0
>
>
> {code}
> [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve 
> dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Could not 
> find artifact org.apache.hbase:hbase-thrift:jar:1.7.0 in apache release 
> (https://repository.apache.org/content/repositories/releases/) -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :hbase-assembly
> {code}
> {code}
> [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve 
> dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Failure 
> to find org.apache.hbase:hbase-thrift:jar:1.7.0 in 
> https://repository.apache.org/content/repositories/releases/ was cached in 
> the local repository, resolution will not be reattempted until the update 
> interval of apache release has elapsed or updates are forced -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :hbase-assembly
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25887) Corrupt wal while region server is aborting.

2021-05-25 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan resolved HBASE-25887.
---
Hadoop Flags: Reviewed
  Resolution: Fixed

> Corrupt wal while region server is aborting.
> 
>
> Key: HBASE-25887
> URL: https://issues.apache.org/jira/browse/HBASE-25887
> Project: HBase
>  Issue Type: Improvement
>  Components: regionserver, wal
>Affects Versions: 1.6.0
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 1.7.0
>
>
> We have seen a case in our production cluster where we ended up in corrupt 
> wal. WALSplitter logged the below error
> {noformat}
> 2021-05-12 00:42:46,786 FATAL [:60020-1] regionserver.HRegionServer - 
> ABORTING region server HOST-B,60020,16207794418
> 88: Caught throwable while processing event RS_LOG_REPLAY
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:411)
> at 
> org.apache.hadoop.hbase.regionserver.wal.WALEdit.isMetaEditFamily(WALEdit.java:145)
> at 
> org.apache.hadoop.hbase.regionserver.wal.WALEdit.isMetaEdit(WALEdit.java:150)
> at 
> org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:408)
> at 
> org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:261)
> at 
> org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:105)
> at 
> org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:72)
> at 
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> Looking at the raw wal file, we could see that the last WALEdit contains the 
> region id, tablename and sequence number but cells were not persisted.
>  Looking at the logs of the RS that generated that corrupt wal file,
> {noformat}
> 2021-05-11 23:29:22,114 DEBUG [/HOST-A:60020] wal.FSHLog - Closing WAL writer 
> in /hbase/WALs/HOST-A,60020,1620774393046
> 2021-05-11 23:29:22,196 DEBUG [/HOST-A:60020] ipc.AbstractRpcClient - 
> Stopping rpc client
> 2021-05-11 23:29:22,198 INFO  [/HOST-A:60020] regionserver.Leases - 
> regionserver/HOST-A/:60020 closing leases
> 2021-05-11 23:29:22,198 INFO  [/HOST-A:60020] regionserver.Leases - 
> regionserver/HOST-A:/HOST-A:60020 closed leases
> 2021-05-11 23:29:22,198 WARN  [0020.append-pool8-t1] wal.FSHLog - Append 
> sequenceId=7147823, requesting roll of WAL
> java.nio.channels.ClosedChannelException
> at 
> org.apache.hadoop.hdfs.DataStreamer$LastExceptionInStreamer.throwException4Close(DataStreamer.java:331)
> at 
> org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:151)
> at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:105)
> at 
> org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:58)
> at java.io.DataOutputStream.write(DataOutputStream.java:107)
> at org.apache.hadoop.hbase.KeyValue.write(KeyValue.java:2543)
> at 
> org.apache.phoenix.hbase.index.wal.KeyValueCodec.write(KeyValueCodec.java:104)
> at 
> org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec$IndexKeyValueEncoder.write(IndexedWALEditCodec.java:218)
> at 
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.append(ProtobufLogWriter.java:128)
> at 
> org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.append(FSHLog.java:2083)
> at 
> org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1941)
> at 
> org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1857)
> at 
> com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:129)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> These 2 lines are interesting.
> {quote}2021-05-11 23:29:22,114 DEBUG [/HOST-A:60020] wal.FSHLog - Closing WAL 
> writer in /hbase/WALs/HOST-A,60020,1620774393046
>  
>  
>  2021-05-11 23:29:22,198 WARN [0020.append-pool8-t1] wal.FSHLog - Append 
> sequenceId=7147823, requesting roll of WAL
>  java.nio.channels.ClosedChannelException
> {quote}
> The append thread encountered java.nio.channels.ClosedChannelException while 
> writing to wal file because the wal file was already 

[GitHub] [hbase] Reidddddd merged pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-25 Thread GitBox


Reidd merged pull request #3264:
URL: https://github.com/apache/hbase/pull/3264


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3308:
URL: https://github.com/apache/hbase/pull/3308#issuecomment-848415187


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  8s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 18s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 23s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 13s |  master passed  |
   | +1 :green_heart: |  spotbugs  |   2m 12s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  1s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 21s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 21s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   1m 10s |  hbase-server: The patch 
generated 2 new + 44 unchanged - 0 fixed = 46 total (was 44)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  20m  5s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | +1 :green_heart: |  spotbugs  |   2m 21s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 13s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  51m 49s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3308/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3308 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
checkstyle compile |
   | uname | Linux 683b5caa4ca7 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3308/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 85 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3308/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache9 opened a new pull request #3309: HBASE-25758 Move MetaTableAccessor out of hbase-balancer module

2021-05-25 Thread GitBox


Apache9 opened a new pull request #3309:
URL: https://github.com/apache/hbase/pull/3309


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848410480


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 35s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  4s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m  4s |  master passed  |
   | +1 :green_heart: |  compile  |  12m 58s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   6m  2s |  master passed  |
   | +1 :green_heart: |  spotbugs  |  12m 18s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 55s |  the patch passed  |
   | +1 :green_heart: |  compile  |  13m  6s |  the patch passed  |
   | +1 :green_heart: |  javac  |  13m  6s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   1m 31s |  hbase-server: The patch 
generated 2 new + 1256 unchanged - 6 fixed = 1258 total (was 1262)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  19m 32s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | +1 :green_heart: |  spotbugs  |  15m  0s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   3m  0s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 110m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3302 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
checkstyle compile |
   | uname | Linux 68f17e7937aa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 19fd42b1dc |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 96 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-zookeeper hbase-balancer 
hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift 
hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-hbtop U: . 
|
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3302/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] chrajeshbabu commented on a change in pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…

2021-05-25 Thread GitBox


chrajeshbabu commented on a change in pull request #3124:
URL: https://github.com/apache/hbase/pull/3124#discussion_r639357057



##
File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/util/ColumnFamilyAttributeValidator.java
##
@@ -0,0 +1,102 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.util;
+
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.BLOCKSIZE;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.BLOOMFILTER;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.COMPRESSION;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.COMPRESSION_COMPACT;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.DATA_BLOCK_ENCODING;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.DFS_REPLICATION;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.IN_MEMORY_COMPACTION;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.KEEP_DELETED_CELLS;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.MAX_VERSIONS;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.MIN_VERSIONS;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.MOB_COMPACT_PARTITION_POLICY;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.MOB_THRESHOLD;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.REPLICATION_SCOPE;
+import static org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.TTL;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.function.Function;
+import org.apache.hadoop.hbase.KeepDeletedCells;
+import org.apache.hadoop.hbase.MemoryCompactionPolicy;
+import org.apache.hadoop.hbase.client.MobCompactPartitionPolicy;
+import org.apache.hadoop.hbase.io.compress.Compression;
+import org.apache.hadoop.hbase.io.encoding.DataBlockEncoding;
+import org.apache.hadoop.hbase.regionserver.BloomType;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@InterfaceAudience.Private
+public class ColumnFamilyAttributeValidator {
+  private static final Logger LOG = 
LoggerFactory.getLogger(ColumnFamilyAttributeValidator.class);
+  private final static Map> ATTRIBUTE_VALIDATOR 
= new HashMap<>();
+
+  static {
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(DATA_BLOCK_ENCODING)),
+  (d) -> DataBlockEncoding.valueOf(d.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(COMPRESSION)),
+  (ca) -> Compression.Algorithm.valueOf(ca.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(BLOOMFILTER)),
+  (bl) -> BloomType.valueOf(bl.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(REPLICATION_SCOPE)),
+  (rs) -> Integer.valueOf(rs.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(MIN_VERSIONS)),
+  (min) -> Integer.valueOf(min.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(MAX_VERSIONS)),
+  (max) -> Integer.valueOf(max.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(BLOCKSIZE)),
+  (bs) -> Integer.valueOf(bs.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(KEEP_DELETED_CELLS)),
+  (k) -> KeepDeletedCells.valueOf(k.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(TTL)),
+  (ttl) -> Integer.valueOf(ttl.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(DFS_REPLICATION)),
+  (dr) -> Integer.valueOf(dr.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(MOB_THRESHOLD)),
+  (mt) -> Long.valueOf(mt.toString()));
+ATTRIBUTE_VALIDATOR.put(new 
Bytes(Bytes.toBytes(MOB_COMPACT_PARTITION_POLICY)),
+  (mc) -> MobCompactPartitionPolicy.valueOf(mc.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(IN_MEMORY_COMPACTION)),
+  (im) -> MemoryCompactionPolicy.valueOf(im.toString().toUpperCase()));
+

[GitHub] [hbase] chrajeshbabu commented on a change in pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…

2021-05-25 Thread GitBox


chrajeshbabu commented on a change in pull request #3124:
URL: https://github.com/apache/hbase/pull/3124#discussion_r639357005



##
File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/util/ColumnFamilyAttributeValidator.java
##
@@ -0,0 +1,102 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.util;
+
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.BLOCKSIZE;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.BLOOMFILTER;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.COMPRESSION;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.COMPRESSION_COMPACT;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.DATA_BLOCK_ENCODING;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.DFS_REPLICATION;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.IN_MEMORY_COMPACTION;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.KEEP_DELETED_CELLS;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.MAX_VERSIONS;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.MIN_VERSIONS;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.MOB_COMPACT_PARTITION_POLICY;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.MOB_THRESHOLD;
+import static 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.REPLICATION_SCOPE;
+import static org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.TTL;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.function.Function;
+import org.apache.hadoop.hbase.KeepDeletedCells;
+import org.apache.hadoop.hbase.MemoryCompactionPolicy;
+import org.apache.hadoop.hbase.client.MobCompactPartitionPolicy;
+import org.apache.hadoop.hbase.io.compress.Compression;
+import org.apache.hadoop.hbase.io.encoding.DataBlockEncoding;
+import org.apache.hadoop.hbase.regionserver.BloomType;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@InterfaceAudience.Private
+public class ColumnFamilyAttributeValidator {
+  private static final Logger LOG = 
LoggerFactory.getLogger(ColumnFamilyAttributeValidator.class);
+  private final static Map> ATTRIBUTE_VALIDATOR 
= new HashMap<>();
+
+  static {
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(DATA_BLOCK_ENCODING)),
+  (d) -> DataBlockEncoding.valueOf(d.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(COMPRESSION)),
+  (ca) -> Compression.Algorithm.valueOf(ca.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(BLOOMFILTER)),
+  (bl) -> BloomType.valueOf(bl.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(REPLICATION_SCOPE)),
+  (rs) -> Integer.valueOf(rs.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(MIN_VERSIONS)),
+  (min) -> Integer.valueOf(min.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(MAX_VERSIONS)),
+  (max) -> Integer.valueOf(max.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(BLOCKSIZE)),
+  (bs) -> Integer.valueOf(bs.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(KEEP_DELETED_CELLS)),
+  (k) -> KeepDeletedCells.valueOf(k.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(TTL)),
+  (ttl) -> Integer.valueOf(ttl.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(DFS_REPLICATION)),
+  (dr) -> Integer.valueOf(dr.toString()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(MOB_THRESHOLD)),
+  (mt) -> Long.valueOf(mt.toString()));
+ATTRIBUTE_VALIDATOR.put(new 
Bytes(Bytes.toBytes(MOB_COMPACT_PARTITION_POLICY)),
+  (mc) -> MobCompactPartitionPolicy.valueOf(mc.toString().toUpperCase()));
+ATTRIBUTE_VALIDATOR.put(new Bytes(Bytes.toBytes(IN_MEMORY_COMPACTION)),
+  (im) -> MemoryCompactionPolicy.valueOf(im.toString().toUpperCase()));
+

[jira] [Commented] (HBASE-25920) Support Hadoop 3.3.1

2021-05-25 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351439#comment-17351439
 ] 

Duo Zhang commented on HBASE-25920:
---

Ping [~ndimiduk]. Seems something related to jersey.

> Support Hadoop 3.3.1
> 
>
> Key: HBASE-25920
> URL: https://issues.apache.org/jira/browse/HBASE-25920
> Project: HBase
>  Issue Type: Task
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
>
> The Hadoop 3.3.1 is a big release, quite different from 3.3.0.
> File this jira to track the support for Hadoop 3.3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25910) Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.

2021-05-25 Thread Victor Li (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351437#comment-17351437
 ] 

Victor Li commented on HBASE-25910:
---

This is the PR for the fix: https://github.com/apache/hbase/pull/3308/files

> Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.
> --
>
> Key: HBASE-25910
> URL: https://issues.apache.org/jira/browse/HBASE-25910
> Project: HBase
>  Issue Type: Test
>  Components: flakies, test
>Reporter: Victor Li
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> This test assigned with random unused ports for master and region server 
> ports and start a cluster, however it can fail as the previously unsigned 
> port might be taken by other application at the moment when cluster start to 
> bind the ports.
> Server has an option to allow auto assign an port if the port is unavailable. 
> This option needs to be disabled in this test in order to test explicit port 
> assignment.
> The exception for the failure of starting server needs to change to 
> IOException and there is a need to set a retry count instead of infinite 
> retry.
> Related ticket: https://issues.apache.org/jira/browse/HBASE-24342



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25920) Support Hadoop 3.3.1

2021-05-25 Thread Wei-Chiu Chuang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351436#comment-17351436
 ] 

Wei-Chiu Chuang commented on HBASE-25920:
-

I am tracking 4 test failures. Some of them require HBase side of change.

[INFO] Running org.apache.hadoop.hbase.rest.TestRESTServerSSL
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.019 s 
<<< FAILURE! - in org.apache.hadoop.hbase.rest.TestRESTServerSSL
[ERROR] org.apache.hadoop.hbase.rest.TestRESTServerSSL  Time elapsed: 0.006 s  
<<< ERROR!
java.security.KeyStoreException: Key protection  algorithm not found: 
java.security.UnrecoverableKeyException: Encrypt Private Key failed: 
unrecognized algorithm name: PBEWithSHA1AndDESede
at 
org.apache.hadoop.hbase.rest.TestRESTServerSSL.generateKeyStore(TestRESTServerSSL.java:153)
at 
org.apache.hadoop.hbase.rest.TestRESTServerSSL.beforeClass(TestRESTServerSSL.java:73)
Caused by: java.security.UnrecoverableKeyException: Encrypt Private Key failed: 
unrecognized algorithm name: PBEWithSHA1AndDESede
at 
org.apache.hadoop.hbase.rest.TestRESTServerSSL.generateKeyStore(TestRESTServerSSL.java:153)
at 
org.apache.hadoop.hbase.rest.TestRESTServerSSL.beforeClass(TestRESTServerSSL.java:73)
Caused by: java.security.NoSuchAlgorithmException: unrecognized algorithm name: 
PBEWithSHA1AndDESede
at 
org.apache.hadoop.hbase.rest.TestRESTServerSSL.generateKeyStore(TestRESTServerSSL.java:153)
at org.apache.hadoop.hbase.rest.TestRESTServerSSL.b

This one appears to be a JDK bug with my jdk8u292. 
https://github.com/bcgit/bc-java/issues/941

[INFO] Running org.apache.hadoop.hbase.backup.TestBackupSmallTests
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s 
<<< FAILURE! - in org.apache.hadoop.hbase.backup.TestBackupSmallTests
[ERROR] org.apache.hadoop.hbase.backup.TestBackupSmallTests  Time elapsed: 
0.007 s  <<< ERROR!
java.lang.NoClassDefFoundError: org/bouncycastle/asn1/edec/EdECObjectIdentifiers
Caused by: java.lang.ClassNotFoundException: 
org.bouncycastle.asn1.edec.EdECObjectIdentifiers


—> it requires updating org.bouncycastle:bcprov-jdk15on to 1.68
  

[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.901 s 
<<< FAILURE! - in org.apache.hadoop.hbase.util.TestCompressionTest
[ERROR] org.apache.hadoop.hbase.util.TestCompressionTest.testTestCompression  
Time elapsed: 0.419 s  <<< FAILURE!
java.lang.AssertionError
at 
org.apache.hadoop.hbase.util.TestCompressionTest.testTestCompression(TestCompressionTest.java:89)

Hadoop replaced lz4 and lzo codec. The lz4-java is declared in provided scope, 
so downstreamers need to declare it explicitly.


Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.125 s <<< 
FAILURE! - in org.apache.hadoop.hbase.TestHBaseConfiguration
org.apache.hadoop.hbase.TestHBaseConfiguration.testDeprecatedConfigurations  
Time elapsed: 0.02 s  <<< FAILURE!
java.lang.AssertionError: expected null, but was:<1000>
at 
org.apache.hadoop.hbase.TestHBaseConfiguration.testDeprecatedConfigurations(TestHBaseConfiguration.java:150)

No idea at this point.

> Support Hadoop 3.3.1
> 
>
> Key: HBASE-25920
> URL: https://issues.apache.org/jira/browse/HBASE-25920
> Project: HBase
>  Issue Type: Task
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
>
> The Hadoop 3.3.1 is a big release, quite different from 3.3.0.
> File this jira to track the support for Hadoop 3.3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] vli02 opened a new pull request #3308: HBASE-25910 - Fix port assignment test

2021-05-25 Thread GitBox


vli02 opened a new pull request #3308:
URL: https://github.com/apache/hbase/pull/3308


   Disabled port auto assignment when port is in use.
   Disabled hdfs cache as restart mini cluster will fail in one jvm if hdfs 
cache is enabled.
   Use exception root case to determine address/port in use with BindException.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (HBASE-25904) Client integration test is failing on master and branch-2

2021-05-25 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351433#comment-17351433
 ] 

Duo Zhang commented on HBASE-25904:
---

Thanks [~ndimiduk] for the quick fix. Let's wait for the result of the newest 
master build.

> Client integration test is failing on master and branch-2
> -
>
> Key: HBASE-25904
> URL: https://issues.apache.org/jira/browse/HBASE-25904
> Project: HBase
>  Issue Type: Task
>  Components: integration tests
>Reporter: Duo Zhang
>Assignee: Nick Dimiduk
>Priority: Major
>
> {noformat}
> Starting up HBase
> 127.0.0.1: Host key verification failed.
> running master, logging to 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase7.out
> 2021-05-22T04:16:40,142 INFO  [main] master.HMaster: STARTING service HMaster
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Source code repository 
> file:///home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/unpacked_src_tarball
>  revision=Unknown
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Compiled by jenkins on 
> Sat May 22 04:07:41 UTC 2021
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: From source with 
> checksum 
> b6959885410c34f4458efd580213907ca50e84a0a900ea1d465d04a1a9480e520419d51da933547e3f517850a2913a8e8aefbcd6ba9e12589fced980910fb941
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh:
>  line 539:  3122 Terminated  sleep "${sleep_time}"
> Shutting down HBase
> no hbase master found
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25920) Support Hadoop 3.3.1

2021-05-25 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351427#comment-17351427
 ] 

Duo Zhang commented on HBASE-25920:
---

Emmm

We introduce big differece with just a patch release? Why?

> Support Hadoop 3.3.1
> 
>
> Key: HBASE-25920
> URL: https://issues.apache.org/jira/browse/HBASE-25920
> Project: HBase
>  Issue Type: Task
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
>
> The Hadoop 3.3.1 is a big release, quite different from 3.3.0.
> File this jira to track the support for Hadoop 3.3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25919) Support Hadoop 3.3.1

2021-05-25 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-25919.
---
Resolution: Duplicate

> Support Hadoop 3.3.1
> 
>
> Key: HBASE-25919
> URL: https://issues.apache.org/jira/browse/HBASE-25919
> Project: HBase
>  Issue Type: Task
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
>
> The Hadoop 3.3.1 is a big release, quite different from 3.3.0.
> File this jira to track the support for Hadoop 3.3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25919) Support Hadoop 3.3.1

2021-05-25 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HBASE-25919:
---

 Summary: Support Hadoop 3.3.1
 Key: HBASE-25919
 URL: https://issues.apache.org/jira/browse/HBASE-25919
 Project: HBase
  Issue Type: Task
Reporter: Wei-Chiu Chuang
Assignee: Wei-Chiu Chuang


The Hadoop 3.3.1 is a big release, quite different from 3.3.0.

File this jira to track the support for Hadoop 3.3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25920) Support Hadoop 3.3.1

2021-05-25 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HBASE-25920:
---

 Summary: Support Hadoop 3.3.1
 Key: HBASE-25920
 URL: https://issues.apache.org/jira/browse/HBASE-25920
 Project: HBase
  Issue Type: Task
Reporter: Wei-Chiu Chuang
Assignee: Wei-Chiu Chuang


The Hadoop 3.3.1 is a big release, quite different from 3.3.0.

File this jira to track the support for Hadoop 3.3.1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25906) UI of master-status to show recent history of balancer desicion

2021-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351421#comment-17351421
 ] 

Hudson commented on HBASE-25906:


Results for branch branch-2
[build #260 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for 
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260//artifact/output-integration/hadoop-2.log].
 (note that this means we didn't run on Hadoop 3)


> UI of master-status to show recent history of balancer desicion
> ---
>
> Key: HBASE-25906
> URL: https://issues.apache.org/jira/browse/HBASE-25906
> Project: HBase
>  Issue Type: Improvement
>  Components: Balancer, master, UI
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.4
>
> Attachments: screenshot-1.png
>
>
> HBASE-24528 provide ‘Balancer Decision’ to display the history that includes 
> decision factor details and weights and costs while running balancer.
> This issue  implement 'Balancer Decision' UI web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25513) When the table is turned on normalize, the first region may not be merged even the size is 0

2021-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351420#comment-17351420
 ] 

Hudson commented on HBASE-25513:


Results for branch branch-2
[build #260 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for 
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/260//artifact/output-integration/hadoop-2.log].
 (note that this means we didn't run on Hadoop 3)


> When the table is turned on normalize, the first region may not be merged 
> even the size is 0
> 
>
> Key: HBASE-25513
> URL: https://issues.apache.org/jira/browse/HBASE-25513
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.4.1
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2
>
>
> Suppose a table has 8 regions, the sizes are [0, 10, 1, 0, 9, 0, 12, 0], the 
> average region size is 4, and split is disabled.
> The current Normalizer can only get three merge plans (use size to represent 
> region):
> [1, 0], [9, 0],[12, 0]
> It can not merge the first region, even it's size is 0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-25 Thread GitBox


apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848374865


   Update fixes TestSimpleRpcScheduler and TestBackupDelete and checkstyle and 
javadoc nits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-25 Thread Bharath Vissapragada (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351369#comment-17351369
 ] 

Bharath Vissapragada commented on HBASE-25913:
--

Looks like we are discussing the exact same thing here and HBASE-24440 
(parent). Posting so that watchers are aware of the discussion there, it's easy 
to do it in one place.

> Introduce EnvironmentEdge.currentTimeAdvancing
> --
>
> Key: HBASE-25913
> URL: https://issues.apache.org/jira/browse/HBASE-25913
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures that 
> when the current time is returned, it is the current time in a different 
> clock tick from the last time the {{EnvironmentEdge}} was used to get the 
> current time.
> When processing mutations we substitute the {{Long.MAX_VALUE}} timestamp 
> placeholder with a real placeholder just before committing the mutation. The 
> current code gets the current time for timestamp substitution while under row 
> lock and mvcc. We will simply use {{EnvironmentEdge#currentTimeAdvancing}} 
> instead of {{EnvironmentEdge#currentTime}} at this point in the code to 
> ensure we have seen the clock tick over. When processing a batch of mutations 
> (doMiniBatchMutation etc) we will call {{currentTimeAdvancing}} only once. 
> This means the client cannot bundle cells with wildcard timestamps into a 
> batch where those cells must be committed with different timestamps. Clients 
> must simply not submit mutations that must be committed with guaranteed 
> distinct timestamps in the same batch. Easy to understand, easy to document, 
> and it aligns with our design philosophy of the client knows best.
> It is not required to handle batches as proposed. We could guarantee a 
> distinct timestamp for every mutation in a batch. Count the number of 
> mutations, call this M. Acquire all row locks and get the current time. Then, 
> wait for at least M milliseconds. Then, set the first mutation timestamp with 
> this value and increment by 1 for all remaining. Then, do the rest of 
> mutation processing as normal. I don't think this extra waiting to reserve 
> the range of timestamps is necessary. See reasoning in above paragraph. 
> Mentioned here for sake of discussion.
> It will be fine to continue to use {{EnvironmentEdge#currentTime}} everywhere 
> else. In this way we will only potentially spin wait where it matters, and 
> won't suffer serious overheads during batch processing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25865) Visualize current state of region assignment

2021-05-25 Thread Bharath Vissapragada (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351368#comment-17351368
 ] 

Bharath Vissapragada commented on HBASE-25865:
--

thanks, lgtm. 

> Visualize current state of region assignment
> 
>
> Key: HBASE-25865
> URL: https://issues.apache.org/jira/browse/HBASE-25865
> Project: HBase
>  Issue Type: New Feature
>  Components: master, Operability, Usability
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image1.png, image2.png
>
>
> After several months of debugging and tuning the balancer and normalizer on a 
> large production cluster, we found that working from visualizations of the 
> current region state was very useful for understanding behaviors and 
> quantifying improvements we made along the way. Specifically, we found that a 
> chart of total assigned region count and total assigned region store files 
> size per table per host was immensely useful for tuning the balancer. 
> Histograms of store file size made understanding normalizer activity much 
> more intuitive.
> Our scripts would parse the output of the shell's {{status 'detailed'}} 
> command, extract the desired metric, and produce charts. I'd like to build 
> into the master UI the equivalent functionality, with data coming directly 
> from the {{ClusterMetrics object}}, and data rendered into an interactive 
> chart rendered in the browser.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3298:
URL: https://github.com/apache/hbase/pull/3298#issuecomment-848219329


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  7s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ HBASE-24749 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 12s |  HBASE-24749 passed  |
   | +1 :green_heart: |  compile  |   1m  4s |  HBASE-24749 passed  |
   | +1 :green_heart: |  shadedjars  |   8m 58s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  HBASE-24749 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  1s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  5s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  5s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   9m  2s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 221m 20s |  hbase-server in the patch failed.  |
   |  |   | 253m 45s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3298 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux f3d5b6e667fd 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-24749 / 77a272609d |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | unit | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/testReport/
 |
   | Max. process+thread count | 3096 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (HBASE-25918) Upgrade hbase-thirdparty dependency to 3.5.0

2021-05-25 Thread Pankaj Kumar (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pankaj Kumar updated HBASE-25918:
-
Description: Recently we have fixed multiple CVEs from jetty & netty as 
part of HBASE-25728 & HBASE-25746.  This Jira is to upgrade hbase-thirdparty 
jar version.  (was: Recently we have fixed multiple CVEs from jetty & netty as 
part of HBASE-25728 & HBASE-25746.  This Jira is to upgrade hbase-thirdpaty jar 
version.)

> Upgrade hbase-thirdparty dependency to 3.5.0
> 
>
> Key: HBASE-25918
> URL: https://issues.apache.org/jira/browse/HBASE-25918
> Project: HBase
>  Issue Type: Bug
>  Components: dependencies
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> Recently we have fixed multiple CVEs from jetty & netty as part of 
> HBASE-25728 & HBASE-25746.  This Jira is to upgrade hbase-thirdparty jar 
> version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] apurtell commented on pull request #3302: HBASE-25911 Replace calls to System.currentTimeMillis with EnvironmentEdgeManager.currentTime

2021-05-25 Thread GitBox


apurtell commented on pull request #3302:
URL: https://github.com/apache/hbase/pull/3302#issuecomment-848192638


   Two test failures were relevant. Updating patch soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (HBASE-25910) Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.

2021-05-25 Thread Victor Li (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351305#comment-17351305
 ] 

Victor Li commented on HBASE-25910:
---

I can take this ticket and make a fix soon, can anyone help assign this ticket 
to me? It will be great if anyone can give me the permission to assign a ticket 
to myself. Thanks!

> Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.
> --
>
> Key: HBASE-25910
> URL: https://issues.apache.org/jira/browse/HBASE-25910
> Project: HBase
>  Issue Type: Test
>  Components: flakies, test
>Reporter: Victor Li
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> This test assigned with random unused ports for master and region server 
> ports and start a cluster, however it can fail as the previously unsigned 
> port might be taken by other application at the moment when cluster start to 
> bind the ports.
> Server has an option to allow auto assign an port if the port is unavailable. 
> This option needs to be disabled in this test in order to test explicit port 
> assignment.
> The exception for the failure of starting server needs to change to 
> IOException and there is a need to set a retry count instead of infinite 
> retry.
> Related ticket: https://issues.apache.org/jira/browse/HBASE-24342



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25918) Upgrade hbase-thirdparty dependency to 3.5.0

2021-05-25 Thread Pankaj Kumar (Jira)
Pankaj Kumar created HBASE-25918:


 Summary: Upgrade hbase-thirdparty dependency to 3.5.0
 Key: HBASE-25918
 URL: https://issues.apache.org/jira/browse/HBASE-25918
 Project: HBase
  Issue Type: Bug
  Components: dependencies
Reporter: Pankaj Kumar
Assignee: Pankaj Kumar


Recently we have fixed multiple CVEs from jetty & netty as part of HBASE-25728 
& HBASE-25746.  This Jira is to upgrade hbase-thirdpaty jar version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-25 Thread Pankaj Kumar (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pankaj Kumar resolved HBASE-25875.
--
Resolution: Fixed

> RegionServer failed to start due to IllegalThreadStateException in 
> AuthenticationTokenSecretManager.start
> -
>
> Key: HBASE-25875
> URL: https://issues.apache.org/jira/browse/HBASE-25875
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> RegionServer failed to complete initialization and aborted during 
> AuthenticationTokenSecretManager#leaderElector start.
> Observed following WARN log,
> {noformat}
> 2021-05-03 07:59:01,848 | WARN  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153)
> 2021-05-03 07:59:01,848 | INFO  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector [ZKSecretWatcher-leaderElector:56] is started | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156)
> 2021-05-03 07:59:01,854 | INFO  | ZKSecretWatcher-leaderElector | Found 
> existing leader with ID: RS-IP-PORT-StartCode | 
> org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130)
> {noformat}
> As per the code, AuthenticationTokenSecretManager#leaderElector is started 
> while retrieving password before AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155]
> So IllegalThreadStateException occured during 
> AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107]
> {noformat}
> 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775)
> java.lang.IllegalThreadStateException
>   at java.lang.Thread.start(Thread.java:708)
>   at 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107)
>   at 
> org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-25 Thread Pankaj Kumar (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pankaj Kumar updated HBASE-25875:
-
Fix Version/s: 2.4.4

> RegionServer failed to start due to IllegalThreadStateException in 
> AuthenticationTokenSecretManager.start
> -
>
> Key: HBASE-25875
> URL: https://issues.apache.org/jira/browse/HBASE-25875
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> RegionServer failed to complete initialization and aborted during 
> AuthenticationTokenSecretManager#leaderElector start.
> Observed following WARN log,
> {noformat}
> 2021-05-03 07:59:01,848 | WARN  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153)
> 2021-05-03 07:59:01,848 | INFO  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector [ZKSecretWatcher-leaderElector:56] is started | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156)
> 2021-05-03 07:59:01,854 | INFO  | ZKSecretWatcher-leaderElector | Found 
> existing leader with ID: RS-IP-PORT-StartCode | 
> org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130)
> {noformat}
> As per the code, AuthenticationTokenSecretManager#leaderElector is started 
> while retrieving password before AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155]
> So IllegalThreadStateException occured during 
> AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107]
> {noformat}
> 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775)
> java.lang.IllegalThreadStateException
>   at java.lang.Thread.start(Thread.java:708)
>   at 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107)
>   at 
> org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-25 Thread Pankaj Kumar (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351295#comment-17351295
 ] 

Pankaj Kumar commented on HBASE-25875:
--

Pushed to branch-2.4. Thank you [~apurtell]

> RegionServer failed to start due to IllegalThreadStateException in 
> AuthenticationTokenSecretManager.start
> -
>
> Key: HBASE-25875
> URL: https://issues.apache.org/jira/browse/HBASE-25875
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6
>
>
> RegionServer failed to complete initialization and aborted during 
> AuthenticationTokenSecretManager#leaderElector start.
> Observed following WARN log,
> {noformat}
> 2021-05-03 07:59:01,848 | WARN  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153)
> 2021-05-03 07:59:01,848 | INFO  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector [ZKSecretWatcher-leaderElector:56] is started | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156)
> 2021-05-03 07:59:01,854 | INFO  | ZKSecretWatcher-leaderElector | Found 
> existing leader with ID: RS-IP-PORT-StartCode | 
> org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130)
> {noformat}
> As per the code, AuthenticationTokenSecretManager#leaderElector is started 
> while retrieving password before AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155]
> So IllegalThreadStateException occured during 
> AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107]
> {noformat}
> 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775)
> java.lang.IllegalThreadStateException
>   at java.lang.Thread.start(Thread.java:708)
>   at 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107)
>   at 
> org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3264:
URL: https://github.com/apache/hbase/pull/3264#issuecomment-848159316


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 14s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch.  |
   ||| _ branch-1 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  10m  0s |  branch-1 passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  branch-1 passed with JDK Azul 
Systems, Inc.-1.8.0_262-b19  |
   | +1 :green_heart: |  compile  |   0m 47s |  branch-1 passed with JDK Azul 
Systems, Inc.-1.7.0_272-b10  |
   | +1 :green_heart: |  checkstyle  |   1m 54s |  branch-1 passed  |
   | +1 :green_heart: |  shadedjars  |   3m 22s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 48s |  branch-1 passed with JDK Azul 
Systems, Inc.-1.8.0_262-b19  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  branch-1 passed with JDK Azul 
Systems, Inc.-1.7.0_272-b10  |
   | +0 :ok: |  spotbugs  |   3m 18s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   3m 15s |  branch-1 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  the patch passed with JDK Azul 
Systems, Inc.-1.8.0_262-b19  |
   | +1 :green_heart: |  javac  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 46s |  the patch passed with JDK Azul 
Systems, Inc.-1.7.0_272-b10  |
   | +1 :green_heart: |  javac  |   0m 46s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 45s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   3m  6s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |   4m 46s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2.  |
   | +1 :green_heart: |  javadoc  |   0m 32s |  the patch passed with JDK Azul 
Systems, Inc.-1.8.0_262-b19  |
   | +1 :green_heart: |  javadoc  |   0m 44s |  the patch passed with JDK Azul 
Systems, Inc.-1.7.0_272-b10  |
   | +1 :green_heart: |  findbugs  |   3m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 162m 51s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 33s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 207m 11s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
   |   | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
   |   | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/9/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3264 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 5da61e626e7b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3264/out/precommit/personality/provided.sh
 |
   | git revision | branch-1 / c0ee153 |
   | Default Java | Azul Systems, Inc.-1.7.0_272-b10 |
   | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, 
Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 |
   | unit | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/9/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/9/testReport/
 |
   | Max. process+thread count | 5026 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3264/9/console
 |
   | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.12.0 

[GitHub] [hbase] Apache-HBase commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3298:
URL: https://github.com/apache/hbase/pull/3298#issuecomment-848131768


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 29s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ HBASE-24749 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 28s |  HBASE-24749 passed  |
   | +1 :green_heart: |  compile  |   1m 18s |  HBASE-24749 passed  |
   | +1 :green_heart: |  shadedjars  |   8m 10s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 46s |  HBASE-24749 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 37s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 22s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 22s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m 14s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 142m 37s |  hbase-server in the patch passed.  
|
   |  |   | 174m 48s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3298 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux b8a02b1bf48d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-24749 / 77a272609d |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/testReport/
 |
   | Max. process+thread count | 4566 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-25 Thread Andrew Kyle Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351285#comment-17351285
 ] 

Andrew Kyle Purtell edited comment on HBASE-25913 at 5/25/21, 6:38 PM:
---

{quote}Since HBase doesn't provide any RS-level atomicity guarantees that I'm 
aware of, should this be done at the Region level rather than RS to allow more 
throughput?
{quote}
EnvironmentEdge provides a convenient an existing place to track the 'last 
observed time'. It is already in use, just not universally as it is supposed to 
be (which we can fix). That is the thought. It is a process singleton, though.

Although, we will only use {{EnvironmentEdge#currentTimeAdvancing}} in a few 
places for a very specific reason. This could be augmented to track the last 
observed time in a table keyed by something like region name. Imagine an API 
like long {{EnvironmentEdge#currentTimeAdvancing(String clockName)}} . Not sure 
if this will work out, just spitballing here. We can try it. There is now more 
overhead, but is it significantly more. Perhaps not. 

 

EnvironmentEdge#addClock(String name) – called when region is opened

EnvironmentEdge#removeClock(String name) – called when region is closed

EnvironmentEdge#currentTime() – just the System.currentTimeMillis we have now

EnvironmentEdge#currentTime(String name) – track the last seen time with 'name'

EnvironmentEdge#currentTimeAdvancing)(String name) – don't return until the 
current clock value is more recent than the last seen time tracked with 'name'


was (Author: apurtell):
{quote}Since HBase doesn't provide any RS-level atomicity guarantees that I'm 
aware of, should this be done at the Region level rather than RS to allow more 
throughput?
{quote}
EnvironmentEdge provides a convenient an existing place to track the 'last 
observed time'. It is already in use, just not universally as it is supposed to 
be (which we can fix). That is the thought. It is a process singleton, though.

Although, we will only use {{EnvironmentEdge#currentTimeAdvancing}} in a few 
places for a very specific reason. This could be augmented to track the last 
observed time in a table keyed by something like region name. Imagine an API 
like long {{EnvironmentEdge#currentTimeAdvancing(String clockName)}} . Not sure 
if this will work out, just spitballing here. We can try it. There is now more 
overhead, but is it significantly more. Perhaps not. 

> Introduce EnvironmentEdge.currentTimeAdvancing
> --
>
> Key: HBASE-25913
> URL: https://issues.apache.org/jira/browse/HBASE-25913
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures that 
> when the current time is returned, it is the current time in a different 
> clock tick from the last time the {{EnvironmentEdge}} was used to get the 
> current time.
> When processing mutations we substitute the {{Long.MAX_VALUE}} timestamp 
> placeholder with a real placeholder just before committing the mutation. The 
> current code gets the current time for timestamp substitution while under row 
> lock and mvcc. We will simply use {{EnvironmentEdge#currentTimeAdvancing}} 
> instead of {{EnvironmentEdge#currentTime}} at this point in the code to 
> ensure we have seen the clock tick over. When processing a batch of mutations 
> (doMiniBatchMutation etc) we will call {{currentTimeAdvancing}} only once. 
> This means the client cannot bundle cells with wildcard timestamps into a 
> batch where those cells must be committed with different timestamps. Clients 
> must simply not submit mutations that must be committed with guaranteed 
> distinct timestamps in the same batch. Easy to understand, easy to document, 
> and it aligns with our design philosophy of the client knows best.
> It is not required to handle batches as proposed. We could guarantee a 
> distinct timestamp for every mutation in a batch. Count the number of 
> mutations, call this M. Acquire all row locks and get the current time. Then, 
> wait for at least M milliseconds. Then, set the first mutation timestamp with 
> this value and increment by 1 for all remaining. Then, do the rest of 
> mutation processing as normal. I don't think this extra waiting to reserve 
> the range of timestamps is necessary. See reasoning in above paragraph. 
> Mentioned here for sake of discussion.
> It will be fine to continue to use {{EnvironmentEdge#currentTime}} everywhere 
> else. In this way we will only potentially spin wait where it matters, and 
> won't suffer serious overheads during batch processing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-25 Thread Andrew Kyle Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351286#comment-17351286
 ] 

Andrew Kyle Purtell commented on HBASE-25875:
-

Yes, this must be pushed back to branch-2.4 now.

> RegionServer failed to start due to IllegalThreadStateException in 
> AuthenticationTokenSecretManager.start
> -
>
> Key: HBASE-25875
> URL: https://issues.apache.org/jira/browse/HBASE-25875
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6
>
>
> RegionServer failed to complete initialization and aborted during 
> AuthenticationTokenSecretManager#leaderElector start.
> Observed following WARN log,
> {noformat}
> 2021-05-03 07:59:01,848 | WARN  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153)
> 2021-05-03 07:59:01,848 | INFO  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector [ZKSecretWatcher-leaderElector:56] is started | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156)
> 2021-05-03 07:59:01,854 | INFO  | ZKSecretWatcher-leaderElector | Found 
> existing leader with ID: RS-IP-PORT-StartCode | 
> org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130)
> {noformat}
> As per the code, AuthenticationTokenSecretManager#leaderElector is started 
> while retrieving password before AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155]
> So IllegalThreadStateException occured during 
> AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107]
> {noformat}
> 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775)
> java.lang.IllegalThreadStateException
>   at java.lang.Thread.start(Thread.java:708)
>   at 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107)
>   at 
> org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-25 Thread Andrew Kyle Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351285#comment-17351285
 ] 

Andrew Kyle Purtell commented on HBASE-25913:
-

{quote}Since HBase doesn't provide any RS-level atomicity guarantees that I'm 
aware of, should this be done at the Region level rather than RS to allow more 
throughput?
{quote}
EnvironmentEdge provides a convenient an existing place to track the 'last 
observed time'. It is already in use, just not universally as it is supposed to 
be (which we can fix). That is the thought. It is a process singleton, though.

Although, we will only use {{EnvironmentEdge#currentTimeAdvancing}} in a few 
places for a very specific reason. This could be augmented to track the last 
observed time in a table keyed by something like region name. Imagine an API 
like long {{EnvironmentEdge#currentTimeAdvancing(String clockName)}} . Not sure 
if this will work out, just spitballing here. We can try it. There is now more 
overhead, but is it significantly more. Perhaps not. 

> Introduce EnvironmentEdge.currentTimeAdvancing
> --
>
> Key: HBASE-25913
> URL: https://issues.apache.org/jira/browse/HBASE-25913
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures that 
> when the current time is returned, it is the current time in a different 
> clock tick from the last time the {{EnvironmentEdge}} was used to get the 
> current time.
> When processing mutations we substitute the {{Long.MAX_VALUE}} timestamp 
> placeholder with a real placeholder just before committing the mutation. The 
> current code gets the current time for timestamp substitution while under row 
> lock and mvcc. We will simply use {{EnvironmentEdge#currentTimeAdvancing}} 
> instead of {{EnvironmentEdge#currentTime}} at this point in the code to 
> ensure we have seen the clock tick over. When processing a batch of mutations 
> (doMiniBatchMutation etc) we will call {{currentTimeAdvancing}} only once. 
> This means the client cannot bundle cells with wildcard timestamps into a 
> batch where those cells must be committed with different timestamps. Clients 
> must simply not submit mutations that must be committed with guaranteed 
> distinct timestamps in the same batch. Easy to understand, easy to document, 
> and it aligns with our design philosophy of the client knows best.
> It is not required to handle batches as proposed. We could guarantee a 
> distinct timestamp for every mutation in a batch. Count the number of 
> mutations, call this M. Acquire all row locks and get the current time. Then, 
> wait for at least M milliseconds. Then, set the first mutation timestamp with 
> this value and increment by 1 for all remaining. Then, do the rest of 
> mutation processing as normal. I don't think this extra waiting to reserve 
> the range of timestamps is necessary. See reasoning in above paragraph. 
> Mentioned here for sake of discussion.
> It will be fine to continue to use {{EnvironmentEdge#currentTime}} everywhere 
> else. In this way we will only potentially spin wait where it matters, and 
> won't suffer serious overheads during batch processing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25906) UI of master-status to show recent history of balancer desicion

2021-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351282#comment-17351282
 ] 

Hudson commented on HBASE-25906:


Results for branch branch-2.4
[build #126 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> UI of master-status to show recent history of balancer desicion
> ---
>
> Key: HBASE-25906
> URL: https://issues.apache.org/jira/browse/HBASE-25906
> Project: HBase
>  Issue Type: Improvement
>  Components: Balancer, master, UI
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.4
>
> Attachments: screenshot-1.png
>
>
> HBASE-24528 provide ‘Balancer Decision’ to display the history that includes 
> decision factor details and weights and costs while running balancer.
> This issue  implement 'Balancer Decision' UI web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25898) RS getting aborted due to NPE in Replication WALEntryStream

2021-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351281#comment-17351281
 ] 

Hudson commented on HBASE-25898:


Results for branch branch-2.4
[build #126 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/126/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> RS getting aborted due to NPE in Replication WALEntryStream
> ---
>
> Key: HBASE-25898
> URL: https://issues.apache.org/jira/browse/HBASE-25898
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> Below sequence of events happened in a customer cluster
> An empty WAL file got roll req.
> The close of file failed at HDFS side but as there  file had all edits 
> synced, we continue.
> New WAL file is created and old rolled.
> This old WAL file got archived to oldWAL 
> {code}
> 2021-05-13 13:38:46.000   Riding over failed WAL close of 
> hdfs://xxx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620910673678,
>  cause="Unexpected EOF while trying to read response from server", errors=1; 
> THIS FILE WAS NOT CLOSED BUT ALL EDITS SYNCED SO SHOULD BE OK
> 2021-05-13 13:38:46.000   Rolled WAL 
> /xx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620910673678 
> with entries=0, filesize=90 B; new WAL 
> /xx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620913126549
> 2021-05-13 13:38:46.000Archiving 
> hdfs://xxx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620910673678
>  to hdfs://xxx/oldWALs/xxxt%2C16020%2C1620828102351.1620910673678
> 2021-05-13 13:38:46.000   Log 
> hdfs://xxx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620910673678
>  was moved to hdfs://xxx/oldWALs/xxx%2C16020%2C1620828102351.1620910673678
> {code}
> As there was move of file, the WALEntryStream got IOE and we will recreate 
> the stream .
> {code}
> ReplicationSourceWALReader#run
> while (isReaderRunning()) {
>   try {
> entryStream =
>   new WALEntryStream(logQueue, conf, currentPosition, 
> source.getWALFileLengthProvider(),
> source.getServerWALsBelongTo(), source.getSourceMetrics(), 
> walGroupId);
> while (isReaderRunning()) { 
> ...
> ...
> } catch (IOException e) { // stream related
> if (handleEofException(e, batch)) {
>   sleepMultiplier = 1;
> } else {
>   LOG.warn("Failed to read stream of replication entries", e);
>   if (sleepMultiplier < maxRetriesMultiplier) {
> sleepMultiplier++;
>   }
>   Threads.sleep(sleepForRetries * sleepMultiplier);
> }
> }
> {code}
> eofAutoRecovery is turned off anyways.  So it will go to outer while loop and 
> create new WALEntryStream object
> Then we do readWALEntries
> {code}
> protected WALEntryBatch readWALEntries(WALEntryStream entryStream,
>   WALEntryBatch batch) throws IOException, InterruptedException {
> Path currentPath = entryStream.getCurrentPath();
> if (!entryStream.hasNext()) {
> {code}
> Here the currentPath will be still null. 
> WALEntryStream#hasNext -> tryAdvanceEntry -> checkReader -> openNextLog
> {code}
> private boolean openNextLog() throws IOException {
> PriorityBlockingQueue queue = logQueue.getQueue(walGroupId);
> Path nextPath = queue.peek();
> if (nextPath != null) {
>   openReader(nextPath);
> 
> private void openReader(Path path) throws IOException {
> try {
>   // Detect if this is a new file, if so get a new reader else
>   // reset the 

[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-25 Thread Pankaj Kumar (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351267#comment-17351267
 ] 

Pankaj Kumar commented on HBASE-25875:
--

Agree [~ndimiduk], this Jira was reverted from branch-2.4 after nightly build 
failure in branch-2.3. which is stable now after  HBASE-25032 revert. So I want 
to push this change in branch-2.4 now. 

> RegionServer failed to start due to IllegalThreadStateException in 
> AuthenticationTokenSecretManager.start
> -
>
> Key: HBASE-25875
> URL: https://issues.apache.org/jira/browse/HBASE-25875
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6
>
>
> RegionServer failed to complete initialization and aborted during 
> AuthenticationTokenSecretManager#leaderElector start.
> Observed following WARN log,
> {noformat}
> 2021-05-03 07:59:01,848 | WARN  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153)
> 2021-05-03 07:59:01,848 | INFO  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector [ZKSecretWatcher-leaderElector:56] is started | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156)
> 2021-05-03 07:59:01,854 | INFO  | ZKSecretWatcher-leaderElector | Found 
> existing leader with ID: RS-IP-PORT-StartCode | 
> org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130)
> {noformat}
> As per the code, AuthenticationTokenSecretManager#leaderElector is started 
> while retrieving password before AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155]
> So IllegalThreadStateException occured during 
> AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107]
> {noformat}
> 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775)
> java.lang.IllegalThreadStateException
>   at java.lang.Thread.start(Thread.java:708)
>   at 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107)
>   at 
> org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25865) Visualize current state of region assignment

2021-05-25 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351263#comment-17351263
 ] 

Nick Dimiduk commented on HBASE-25865:
--

Attached examples of this region visualizer as implemented, generated from a 
large cluster with two primary tables. Top chart is interactive, as you can see 
from the mouse-over. Selecting a legend item will also cause that table's data 
to be in focus (not shown). The bottom chart is an interactive element used for 
zooming in the top chart, in that selecting a length of the bottom chart clips 
the viewport of the top chart, demonstrated in the second screenshot.

> Visualize current state of region assignment
> 
>
> Key: HBASE-25865
> URL: https://issues.apache.org/jira/browse/HBASE-25865
> Project: HBase
>  Issue Type: New Feature
>  Components: master, Operability, Usability
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image1.png, image2.png
>
>
> After several months of debugging and tuning the balancer and normalizer on a 
> large production cluster, we found that working from visualizations of the 
> current region state was very useful for understanding behaviors and 
> quantifying improvements we made along the way. Specifically, we found that a 
> chart of total assigned region count and total assigned region store files 
> size per table per host was immensely useful for tuning the balancer. 
> Histograms of store file size made understanding normalizer activity much 
> more intuitive.
> Our scripts would parse the output of the shell's {{status 'detailed'}} 
> command, extract the desired metric, and produce charts. I'd like to build 
> into the master UI the equivalent functionality, with data coming directly 
> from the {{ClusterMetrics object}}, and data rendered into an interactive 
> chart rendered in the browser.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-25865) Visualize current state of region assignment

2021-05-25 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-25865:
-
Attachment: image2.png

> Visualize current state of region assignment
> 
>
> Key: HBASE-25865
> URL: https://issues.apache.org/jira/browse/HBASE-25865
> Project: HBase
>  Issue Type: New Feature
>  Components: master, Operability, Usability
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image1.png, image2.png
>
>
> After several months of debugging and tuning the balancer and normalizer on a 
> large production cluster, we found that working from visualizations of the 
> current region state was very useful for understanding behaviors and 
> quantifying improvements we made along the way. Specifically, we found that a 
> chart of total assigned region count and total assigned region store files 
> size per table per host was immensely useful for tuning the balancer. 
> Histograms of store file size made understanding normalizer activity much 
> more intuitive.
> Our scripts would parse the output of the shell's {{status 'detailed'}} 
> command, extract the desired metric, and produce charts. I'd like to build 
> into the master UI the equivalent functionality, with data coming directly 
> from the {{ClusterMetrics object}}, and data rendered into an interactive 
> chart rendered in the browser.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-25865) Visualize current state of region assignment

2021-05-25 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-25865:
-
Attachment: image1.png

> Visualize current state of region assignment
> 
>
> Key: HBASE-25865
> URL: https://issues.apache.org/jira/browse/HBASE-25865
> Project: HBase
>  Issue Type: New Feature
>  Components: master, Operability, Usability
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image1.png, image2.png
>
>
> After several months of debugging and tuning the balancer and normalizer on a 
> large production cluster, we found that working from visualizations of the 
> current region state was very useful for understanding behaviors and 
> quantifying improvements we made along the way. Specifically, we found that a 
> chart of total assigned region count and total assigned region store files 
> size per table per host was immensely useful for tuning the balancer. 
> Histograms of store file size made understanding normalizer activity much 
> more intuitive.
> Our scripts would parse the output of the shell's {{status 'detailed'}} 
> command, extract the desired metric, and produce charts. I'd like to build 
> into the master UI the equivalent functionality, with data coming directly 
> from the {{ClusterMetrics object}}, and data rendered into an interactive 
> chart rendered in the browser.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-25 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351255#comment-17351255
 ] 

Nick Dimiduk commented on HBASE-25875:
--

FYI [~pankajkumar] it is our project to apply changes to master and work our 
way backwards. To that effect, in order for a change to release on branch-2.3, 
it must be on branch-2.4. The only exceptions we have to this practice are for 
changes that are not applicable to the newer release lines, for example, bug 
fixes to features that have been removed in newer versions.

> RegionServer failed to start due to IllegalThreadStateException in 
> AuthenticationTokenSecretManager.start
> -
>
> Key: HBASE-25875
> URL: https://issues.apache.org/jira/browse/HBASE-25875
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6
>
>
> RegionServer failed to complete initialization and aborted during 
> AuthenticationTokenSecretManager#leaderElector start.
> Observed following WARN log,
> {noformat}
> 2021-05-03 07:59:01,848 | WARN  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153)
> 2021-05-03 07:59:01,848 | INFO  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector [ZKSecretWatcher-leaderElector:56] is started | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156)
> 2021-05-03 07:59:01,854 | INFO  | ZKSecretWatcher-leaderElector | Found 
> existing leader with ID: RS-IP-PORT-StartCode | 
> org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130)
> {noformat}
> As per the code, AuthenticationTokenSecretManager#leaderElector is started 
> while retrieving password before AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155]
> So IllegalThreadStateException occured during 
> AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107]
> {noformat}
> 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775)
> java.lang.IllegalThreadStateException
>   at java.lang.Thread.start(Thread.java:708)
>   at 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107)
>   at 
> org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-25 Thread Pankaj Kumar (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351236#comment-17351236
 ] 

Pankaj Kumar commented on HBASE-25875:
--

[~apurtell]  Should I cherry-pick this to branch-2.4?

> RegionServer failed to start due to IllegalThreadStateException in 
> AuthenticationTokenSecretManager.start
> -
>
> Key: HBASE-25875
> URL: https://issues.apache.org/jira/browse/HBASE-25875
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6
>
>
> RegionServer failed to complete initialization and aborted during 
> AuthenticationTokenSecretManager#leaderElector start.
> Observed following WARN log,
> {noformat}
> 2021-05-03 07:59:01,848 | WARN  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153)
> 2021-05-03 07:59:01,848 | INFO  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector [ZKSecretWatcher-leaderElector:56] is started | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156)
> 2021-05-03 07:59:01,854 | INFO  | ZKSecretWatcher-leaderElector | Found 
> existing leader with ID: RS-IP-PORT-StartCode | 
> org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130)
> {noformat}
> As per the code, AuthenticationTokenSecretManager#leaderElector is started 
> while retrieving password before AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155]
> So IllegalThreadStateException occured during 
> AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107]
> {noformat}
> 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775)
> java.lang.IllegalThreadStateException
>   at java.lang.Thread.start(Thread.java:708)
>   at 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107)
>   at 
> org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-25 Thread Pankaj Kumar (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351235#comment-17351235
 ] 

Pankaj Kumar commented on HBASE-25875:
--

Branch-2.3 nightly build is fine now, let me close this JIRA.

 

> RegionServer failed to start due to IllegalThreadStateException in 
> AuthenticationTokenSecretManager.start
> -
>
> Key: HBASE-25875
> URL: https://issues.apache.org/jira/browse/HBASE-25875
> Project: HBase
>  Issue Type: Bug
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6
>
>
> RegionServer failed to complete initialization and aborted during 
> AuthenticationTokenSecretManager#leaderElector start.
> Observed following WARN log,
> {noformat}
> 2021-05-03 07:59:01,848 | WARN  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153)
> 2021-05-03 07:59:01,848 | INFO  | RS-EventLoopGroup-1-6 | Thread 
> leaderElector [ZKSecretWatcher-leaderElector:56] is started | 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156)
> 2021-05-03 07:59:01,854 | INFO  | ZKSecretWatcher-leaderElector | Found 
> existing leader with ID: RS-IP-PORT-StartCode | 
> org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130)
> {noformat}
> As per the code, AuthenticationTokenSecretManager#leaderElector is started 
> while retrieving password before AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155]
> So IllegalThreadStateException occured during 
> AuthenticationTokenSecretManager#start, 
>  
> [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107]
> {noformat}
> 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775)
> java.lang.IllegalThreadStateException
>   at java.lang.Thread.start(Thread.java:708)
>   at 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107)
>   at 
> org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131)
>   at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756)
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63)
>   at 
> org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25904) Client integration test is failing on master and branch-2

2021-05-25 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351214#comment-17351214
 ] 

Nick Dimiduk commented on HBASE-25904:
--

Pushed addendums for HBASE-25841. Will monitor the builds and resolve this one 
accordingly.

> Client integration test is failing on master and branch-2
> -
>
> Key: HBASE-25904
> URL: https://issues.apache.org/jira/browse/HBASE-25904
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Reporter: Duo Zhang
>Assignee: Nick Dimiduk
>Priority: Major
>
> {noformat}
> Starting up HBase
> 127.0.0.1: Host key verification failed.
> running master, logging to 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase7.out
> 2021-05-22T04:16:40,142 INFO  [main] master.HMaster: STARTING service HMaster
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Source code repository 
> file:///home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/unpacked_src_tarball
>  revision=Unknown
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Compiled by jenkins on 
> Sat May 22 04:07:41 UTC 2021
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: From source with 
> checksum 
> b6959885410c34f4458efd580213907ca50e84a0a900ea1d465d04a1a9480e520419d51da933547e3f517850a2913a8e8aefbcd6ba9e12589fced980910fb941
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh:
>  line 539:  3122 Terminated  sleep "${sleep_time}"
> Shutting down HBase
> no hbase master found
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-25904) Client integration test is failing on master and branch-2

2021-05-25 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-25904:
-
Issue Type: Task  (was: Bug)

> Client integration test is failing on master and branch-2
> -
>
> Key: HBASE-25904
> URL: https://issues.apache.org/jira/browse/HBASE-25904
> Project: HBase
>  Issue Type: Task
>  Components: integration tests
>Reporter: Duo Zhang
>Assignee: Nick Dimiduk
>Priority: Major
>
> {noformat}
> Starting up HBase
> 127.0.0.1: Host key verification failed.
> running master, logging to 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase7.out
> 2021-05-22T04:16:40,142 INFO  [main] master.HMaster: STARTING service HMaster
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Source code repository 
> file:///home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/unpacked_src_tarball
>  revision=Unknown
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Compiled by jenkins on 
> Sat May 22 04:07:41 UTC 2021
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: From source with 
> checksum 
> b6959885410c34f4458efd580213907ca50e84a0a900ea1d465d04a1a9480e520419d51da933547e3f517850a2913a8e8aefbcd6ba9e12589fced980910fb941
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh:
>  line 539:  3122 Terminated  sleep "${sleep_time}"
> Shutting down HBase
> no hbase master found
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25841) Add basic jshell support

2021-05-25 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk resolved HBASE-25841.
--
Resolution: Fixed

Pushed addendums to both branches.

> Add basic jshell support
> 
>
> Key: HBASE-25841
> URL: https://issues.apache.org/jira/browse/HBASE-25841
> Project: HBase
>  Issue Type: New Feature
>  Components: shell, Usability
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> Let's make it easy to start a {{jshell}} session that includes HBase jars and 
> dependencies on the class path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] ndimiduk merged pull request #3307: Backport "HBASE-25841 Add basic jshell support (addendum)" to branch-2

2021-05-25 Thread GitBox


ndimiduk merged pull request #3307:
URL: https://github.com/apache/hbase/pull/3307


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3300: HBASE-25898 RS getting aborted due to NPE in Replication WALEntryStream

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3300:
URL: https://github.com/apache/hbase/pull/3300#issuecomment-848055834


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 22s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch.  |
   ||| _ branch-1 Compile Tests _ |
   | -1 :x: |  mvninstall  |   9m 45s |  root in branch-1 failed.  |
   | +1 :green_heart: |  compile  |   0m 42s |  branch-1 passed with JDK Azul 
Systems, Inc.-1.8.0_262-b19  |
   | +1 :green_heart: |  compile  |   0m 47s |  branch-1 passed with JDK Azul 
Systems, Inc.-1.7.0_272-b10  |
   | +1 :green_heart: |  checkstyle  |   1m 55s |  branch-1 passed  |
   | +1 :green_heart: |  shadedjars  |   3m 22s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 49s |  branch-1 passed with JDK Azul 
Systems, Inc.-1.8.0_262-b19  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  branch-1 passed with JDK Azul 
Systems, Inc.-1.7.0_272-b10  |
   | +0 :ok: |  spotbugs  |   3m 16s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   3m 14s |  branch-1 passed  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   2m  0s |  root in the patch failed.  |
   | +1 :green_heart: |  compile  |   0m 41s |  the patch passed with JDK Azul 
Systems, Inc.-1.8.0_262-b19  |
   | +1 :green_heart: |  javac  |   0m 41s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 47s |  the patch passed with JDK Azul 
Systems, Inc.-1.7.0_272-b10  |
   | +1 :green_heart: |  javac  |   0m 47s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 44s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   3m  8s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | -1 :x: |  hadoopcheck  |   1m 45s |  The patch causes 10 errors with 
Hadoop v2.8.5.  |
   | -1 :x: |  hadoopcheck  |   4m 18s |  The patch causes 10 errors with 
Hadoop v2.9.2.  |
   | +1 :green_heart: |  javadoc  |   0m 32s |  the patch passed with JDK Azul 
Systems, Inc.-1.8.0_262-b19  |
   | +1 :green_heart: |  javadoc  |   0m 43s |  the patch passed with JDK Azul 
Systems, Inc.-1.7.0_272-b10  |
   | +1 :green_heart: |  findbugs  |   3m  8s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 166m 14s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 32s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 208m 13s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles |
   |   | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
   |   | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
   |   | hadoop.hbase.client.TestAdmin1 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3300/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3300 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux d5b250596139 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 
10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3300/out/precommit/personality/provided.sh
 |
   | git revision | branch-1 / 3cff107 |
   | Default Java | Azul Systems, Inc.-1.7.0_272-b10 |
   | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, 
Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3300/2/artifact/out/branch-mvninstall-root.txt
 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3300/2/artifact/out/patch-mvninstall-root.txt
 |
   | hadoopcheck | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3300/2/artifact/out/patch-javac-2.8.5.txt
 |
   | hadoopcheck | 

[jira] [Resolved] (HBASE-25791) UI of master-status to show a recent history of that why balancer was rejected to run

2021-05-25 Thread Peter Somogyi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi resolved HBASE-25791.
---
Resolution: Fixed

> UI of master-status to show a recent history of  that why balancer  was 
> rejected to run
> ---
>
> Key: HBASE-25791
> URL: https://issues.apache.org/jira/browse/HBASE-25791
> Project: HBase
>  Issue Type: Sub-task
>  Components: Balancer, master, UI
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.4
>
> Attachments: image-2021-05-18-11-31-21-001.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-25791) UI of master-status to show a recent history of that why balancer was rejected to run

2021-05-25 Thread Peter Somogyi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi reopened HBASE-25791:
---

> UI of master-status to show a recent history of  that why balancer  was 
> rejected to run
> ---
>
> Key: HBASE-25791
> URL: https://issues.apache.org/jira/browse/HBASE-25791
> Project: HBase
>  Issue Type: Sub-task
>  Components: Balancer, master, UI
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.4
>
> Attachments: image-2021-05-18-11-31-21-001.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on pull request #3307: Backport "HBASE-25841 Add basic jshell support (addendum)" to branch-2

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3307:
URL: https://github.com/apache/hbase/pull/3307#issuecomment-848050861


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 53s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 18s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   3m 50s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3307/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3307 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 57befcee23e8 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 
01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 563ebc214a |
   | Max. process+thread count | 46 (vs. ulimit of 12500) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3307/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3307: Backport "HBASE-25841 Add basic jshell support (addendum)" to branch-2

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3307:
URL: https://github.com/apache/hbase/pull/3307#issuecomment-848049913


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 52s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  7s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   2m 25s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3307/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3307 |
   | Optional Tests |  |
   | uname | Linux 0250fde2da40 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 563ebc214a |
   | Max. process+thread count | 53 (vs. ulimit of 12500) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3307/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3307: Backport "HBASE-25841 Add basic jshell support (addendum)" to branch-2

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3307:
URL: https://github.com/apache/hbase/pull/3307#issuecomment-848049592


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 35s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   1m 54s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3307/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3307 |
   | Optional Tests |  |
   | uname | Linux 1a8cdccb4b84 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 563ebc214a |
   | Max. process+thread count | 48 (vs. ulimit of 12500) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3307/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk opened a new pull request #3307: Backport "HBASE-25841 Add basic jshell support (addendum)" to branch-2

2021-05-25 Thread GitBox


ndimiduk opened a new pull request #3307:
URL: https://github.com/apache/hbase/pull/3307


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk merged pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


ndimiduk merged pull request #3306:
URL: https://github.com/apache/hbase/pull/3306


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk commented on pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


ndimiduk commented on pull request #3306:
URL: https://github.com/apache/hbase/pull/3306#issuecomment-848044212


   Pipeline test passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (HBASE-25904) Client integration test is failing on master and branch-2

2021-05-25 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351195#comment-17351195
 ] 

Hudson commented on HBASE-25904:


Results for branch HBASE-25904
[build #4 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/HBASE-25904/4/]:
 (/) *{color:green}+1 overall{color}*

details (if available):











(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Client integration test is failing on master and branch-2
> -
>
> Key: HBASE-25904
> URL: https://issues.apache.org/jira/browse/HBASE-25904
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Reporter: Duo Zhang
>Assignee: Nick Dimiduk
>Priority: Major
>
> {noformat}
> Starting up HBase
> 127.0.0.1: Host key verification failed.
> running master, logging to 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase7.out
> 2021-05-22T04:16:40,142 INFO  [main] master.HMaster: STARTING service HMaster
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Source code repository 
> file:///home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/unpacked_src_tarball
>  revision=Unknown
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Compiled by jenkins on 
> Sat May 22 04:07:41 UTC 2021
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: From source with 
> checksum 
> b6959885410c34f4458efd580213907ca50e84a0a900ea1d465d04a1a9480e520419d51da933547e3f517850a2913a8e8aefbcd6ba9e12589fced980910fb941
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh:
>  line 539:  3122 Terminated  sleep "${sleep_time}"
> Shutting down HBase
> no hbase master found
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-05-25 Thread Geoffrey Jacoby (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351194#comment-17351194
 ] 

Geoffrey Jacoby commented on HBASE-25913:
-

[~apurtell] - Interesting. If I'm understanding properly, that's actually a 
stronger guarantee than what Phoenix currently provides (or requires) when 
doing global indexes. 

(Phoenix, IIRC, guarantees that each mutation of a given row key will get a 
distinct timestamp, but two batch mutations done in parallel on disjoint sets 
of row keys might get the same mutation ts.) This proposal sounds like it gives 
each mutation on a given RS a distinct timestamp, leading to a total ordering 
of all mutations on a RS at the cost of limiting RS throughput to 1 batch 
mutation / ms. 

Since HBase doesn't provide any RS-level atomicity guarantees that I'm aware 
of, should this be done at the Region level rather than RS to allow more 
throughput? (Which would still be more than Phoenix needs, but probably useful 
for other use cases.) 

> Introduce EnvironmentEdge.currentTimeAdvancing
> --
>
> Key: HBASE-25913
> URL: https://issues.apache.org/jira/browse/HBASE-25913
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures that 
> when the current time is returned, it is the current time in a different 
> clock tick from the last time the {{EnvironmentEdge}} was used to get the 
> current time.
> When processing mutations we substitute the {{Long.MAX_VALUE}} timestamp 
> placeholder with a real placeholder just before committing the mutation. The 
> current code gets the current time for timestamp substitution while under row 
> lock and mvcc. We will simply use {{EnvironmentEdge#currentTimeAdvancing}} 
> instead of {{EnvironmentEdge#currentTime}} at this point in the code to 
> ensure we have seen the clock tick over. When processing a batch of mutations 
> (doMiniBatchMutation etc) we will call {{currentTimeAdvancing}} only once. 
> This means the client cannot bundle cells with wildcard timestamps into a 
> batch where those cells must be committed with different timestamps. Clients 
> must simply not submit mutations that must be committed with guaranteed 
> distinct timestamps in the same batch. Easy to understand, easy to document, 
> and it aligns with our design philosophy of the client knows best.
> It is not required to handle batches as proposed. We could guarantee a 
> distinct timestamp for every mutation in a batch. Count the number of 
> mutations, call this M. Acquire all row locks and get the current time. Then, 
> wait for at least M milliseconds. Then, set the first mutation timestamp with 
> this value and increment by 1 for all remaining. Then, do the rest of 
> mutation processing as normal. I don't think this extra waiting to reserve 
> the range of timestamps is necessary. See reasoning in above paragraph. 
> Mentioned here for sake of discussion.
> It will be fine to continue to use {{EnvironmentEdge#currentTime}} everywhere 
> else. In this way we will only potentially spin wait where it matters, and 
> won't suffer serious overheads during batch processing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3306:
URL: https://github.com/apache/hbase/pull/3306#issuecomment-848027576






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3306:
URL: https://github.com/apache/hbase/pull/3306#issuecomment-848027162


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   1m 33s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3306/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3306 |
   | Optional Tests |  |
   | uname | Linux 5a4b1d73018f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 76fbb8b965 |
   | Max. process+thread count | 46 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3306/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3298: HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3298:
URL: https://github.com/apache/hbase/pull/3298#issuecomment-848026515


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ HBASE-24749 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 59s |  HBASE-24749 passed  |
   | +1 :green_heart: |  compile  |   3m 10s |  HBASE-24749 passed  |
   | +1 :green_heart: |  checkstyle  |   1m  5s |  HBASE-24749 passed  |
   | +1 :green_heart: |  spotbugs  |   2m  4s |  HBASE-24749 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 35s |  the patch passed  |
   | -1 :x: |  compile  |   1m 22s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   1m 22s |  hbase-server in the patch failed.  |
   | -0 :warning: |  checkstyle  |   1m  0s |  hbase-server: The patch 
generated 12 new + 4 unchanged - 1 fixed = 16 total (was 5)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  18m  9s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | +1 :green_heart: |  spotbugs  |   2m 19s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 16s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  45m 21s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3298 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
checkstyle compile |
   | uname | Linux 0479cf901cdc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-24749 / 77a272609d |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | compile | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 96 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3305: HBASE-25915 ‘mobdir’ overlaps in HFileLink.mobPath

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3305:
URL: https://github.com/apache/hbase/pull/3305#issuecomment-848025108


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  3s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m  0s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 28s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 58s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 53s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m  5s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 29s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 29s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   9m  2s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 54s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 215m 52s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  unit  |  14m 22s |  hbase-mapreduce in the patch 
passed.  |
   |  |   | 264m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3305/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3305 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 0c29d73398e6 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 6a77872879 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3305/2/testReport/
 |
   | Max. process+thread count | 2767 (vs. ulimit of 3) |
   | modules | C: hbase-server hbase-mapreduce U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3305/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3306:
URL: https://github.com/apache/hbase/pull/3306#issuecomment-848025104


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 10s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   2m 19s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3306/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3306 |
   | Optional Tests |  |
   | uname | Linux 09b3c9338e9f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 76fbb8b965 |
   | Max. process+thread count | 52 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3306/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3306:
URL: https://github.com/apache/hbase/pull/3306#issuecomment-848024995


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 17s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   2m  9s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3306/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3306 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 6d91394aeebc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 76fbb8b965 |
   | Max. process+thread count | 48 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3306/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] Apache-HBase commented on pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


Apache-HBase commented on pull request #3306:
URL: https://github.com/apache/hbase/pull/3306#issuecomment-848024718


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   1m 39s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3306/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3306 |
   | Optional Tests |  |
   | uname | Linux 684bb646b108 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 76fbb8b965 |
   | Max. process+thread count | 47 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3306/1/console
 |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (HBASE-25904) Client integration test is failing on master and branch-2

2021-05-25 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351184#comment-17351184
 ] 

Nick Dimiduk commented on HBASE-25904:
--

PR with fix posted as addendum: https://github.com/apache/hbase/pull/3306
Testing via feature branch: 
https://ci-hadoop.apache.org/blue/organizations/jenkins/HBase%2FHBase%20Nightly/detail/HBASE-25904/4/pipeline/

Thanks for setting it up, [~zhangduo].

> Client integration test is failing on master and branch-2
> -
>
> Key: HBASE-25904
> URL: https://issues.apache.org/jira/browse/HBASE-25904
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Reporter: Duo Zhang
>Assignee: Nick Dimiduk
>Priority: Major
>
> {noformat}
> Starting up HBase
> 127.0.0.1: Host key verification failed.
> running master, logging to 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase7.out
> 2021-05-22T04:16:40,142 INFO  [main] master.HMaster: STARTING service HMaster
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Source code repository 
> file:///home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/unpacked_src_tarball
>  revision=Unknown
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Compiled by jenkins on 
> Sat May 22 04:07:41 UTC 2021
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: From source with 
> checksum 
> b6959885410c34f4458efd580213907ca50e84a0a900ea1d465d04a1a9480e520419d51da933547e3f517850a2913a8e8aefbcd6ba9e12589fced980910fb941
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh:
>  line 539:  3122 Terminated  sleep "${sleep_time}"
> Shutting down HBase
> no hbase master found
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] ndimiduk commented on pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


ndimiduk commented on pull request #3306:
URL: https://github.com/apache/hbase/pull/3306#issuecomment-848023158


   Testing on 
https://ci-hadoop.apache.org/blue/organizations/jenkins/HBase%2FHBase%20Nightly/detail/HBASE-25904/4/pipeline


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk opened a new pull request #3306: HBASE-25841 Add basic jshell support (adendum)

2021-05-25 Thread GitBox


ndimiduk opened a new pull request #3306:
URL: https://github.com/apache/hbase/pull/3306


   Fixes issue where master fails to start.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Work started] (HBASE-25904) Client integration test is failing on master and branch-2

2021-05-25 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-25904 started by Nick Dimiduk.

> Client integration test is failing on master and branch-2
> -
>
> Key: HBASE-25904
> URL: https://issues.apache.org/jira/browse/HBASE-25904
> Project: HBase
>  Issue Type: Bug
>  Components: integration tests
>Reporter: Duo Zhang
>Assignee: Nick Dimiduk
>Priority: Major
>
> {noformat}
> Starting up HBase
> 127.0.0.1: Host key verification failed.
> running master, logging to 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase7.out
> 2021-05-22T04:16:40,142 INFO  [main] master.HMaster: STARTING service HMaster
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Source code repository 
> file:///home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/unpacked_src_tarball
>  revision=Unknown
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: Compiled by jenkins on 
> Sat May 22 04:07:41 UTC 2021
> 2021-05-22T04:16:40,149 INFO  [main] util.VersionInfo: From source with 
> checksum 
> b6959885410c34f4458efd580213907ca50e84a0a900ea1d465d04a1a9480e520419d51da933547e3f517850a2913a8e8aefbcd6ba9e12589fced980910fb941
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
> cat: 
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers:
>  No such file or directory
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
>   retry waiting for hbase to come up.
> /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh:
>  line 539:  3122 Terminated  sleep "${sleep_time}"
> Shutting down HBase
> no hbase master found
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (HBASE-25841) Add basic jshell support

2021-05-25 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk reopened HBASE-25841:
--

This breaks master process startup.

> Add basic jshell support
> 
>
> Key: HBASE-25841
> URL: https://issues.apache.org/jira/browse/HBASE-25841
> Project: HBase
>  Issue Type: New Feature
>  Components: shell, Usability
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> Let's make it easy to start a {{jshell}} session that includes HBase jars and 
> dependencies on the class path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25916) Move FavoredNodeLoadBalancer to hbase-balancer module

2021-05-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25916:
-

 Summary: Move FavoredNodeLoadBalancer to hbase-balancer module
 Key: HBASE-25916
 URL: https://issues.apache.org/jira/browse/HBASE-25916
 Project: HBase
  Issue Type: Sub-task
  Components: Balancer, FavoredNodes
Reporter: Duo Zhang






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25917) Move RSGroupBasedLoadBalancer to hbase-balancer

2021-05-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25917:
-

 Summary: Move RSGroupBasedLoadBalancer to hbase-balancer
 Key: HBASE-25917
 URL: https://issues.apache.org/jira/browse/HBASE-25917
 Project: HBase
  Issue Type: Sub-task
Reporter: Duo Zhang






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (HBASE-25818) Move StochasticLoadBalancer to hbase-balancer module

2021-05-25 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-25818.
---
Fix Version/s: 3.0.0-alpha-1
 Hadoop Flags: Reviewed
   Resolution: Fixed

Merged to master.

Thanks [~meiyi] for reviewing.

> Move StochasticLoadBalancer to hbase-balancer module
> 
>
> Key: HBASE-25818
> URL: https://issues.apache.org/jira/browse/HBASE-25818
> Project: HBase
>  Issue Type: Sub-task
>  Components: Balancer
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-25534) Honor TableDescriptor settings earlier in normalization

2021-05-25 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-25534:
-
Fix Version/s: 2.5.0

> Honor TableDescriptor settings earlier in normalization
> ---
>
> Key: HBASE-25534
> URL: https://issues.apache.org/jira/browse/HBASE-25534
> Project: HBase
>  Issue Type: Improvement
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.4.2
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.2
>
>
> -Table can be enabled and disabled merge/split in TableDescriptor, we should 
> judge before calculating the plan.-
> The normalizer configuration can be set by table level. For example, 
> hbase.normalizer.min.region.count can be set by "alter ‘table’, 
> CONFIGURATION=>\{'hbase.normalizer.min.region.count' => '5'}". If the table 
> is not set, then use the global configuration which is set in hbase-site.xml.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >