[GitHub] [hbase] virajjasani commented on a change in pull request #3972: HBASE-26596 region_mover should gracefully ignore null response from RSGroupAdmin#getRSGroupOfServer
virajjasani commented on a change in pull request #3972: URL: https://github.com/apache/hbase/pull/3972#discussion_r777078839 ## File path: bin/region_mover.rb ## @@ -493,11 +493,30 @@ def getFilename(options, targetServer, port) return filename end +def getServersRSGroup(servers, rsgroup_admin, hostname, port) + rsgroup = rsgroup_admin.getRSGroupOfServer(Address.fromParts(hostname, + java.lang.Integer.parseInt(port))) + return rsgroup unless rsgroup.nil? + begin +server_name = getServerName(servers, hostname, port) +regions = getRegions(getConfiguration(), server_name) +if !regions.nil? && regions.empty? Review comment: Sounds good. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3986: HBASE-26635 Optimize decodeNumeric in OrderedBytes
Apache-HBase commented on pull request #3986: URL: https://github.com/apache/hbase/pull/3986#issuecomment-1003489580 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 37s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | checkstyle | 0m 27s | master passed | | +1 :green_heart: | spotbugs | 0m 51s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 18s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | -0 :warning: | checkstyle | 0m 25s | hbase-common: The patch generated 1 new + 37 unchanged - 3 fixed = 38 total (was 40) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 22m 22s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 0m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 45m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3986 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 44e7e5740f49 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3984: HBASE-26629 Add expiration for long time vacant scanners in Thrift2
Apache-HBase commented on pull request #3984: URL: https://github.com/apache/hbase/pull/3984#issuecomment-1003489486 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | compile | 1m 9s | master passed | | +1 :green_heart: | checkstyle | 0m 45s | master passed | | +1 :green_heart: | spotbugs | 1m 41s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | -0 :warning: | checkstyle | 0m 45s | hbase-thrift: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 51s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 1m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 45m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3984 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux d50c57e45d99 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-thrift U: hbase-thrift | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3984: HBASE-26629 Add expiration for long time vacant scanners in Thrift2
Apache-HBase commented on pull request #3984: URL: https://github.com/apache/hbase/pull/3984#issuecomment-1003489410 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 14s | master passed | | +1 :green_heart: | compile | 0m 49s | master passed | | +1 :green_heart: | shadedjars | 11m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 9s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 20s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed | | +1 :green_heart: | javac | 0m 45s | the patch passed | | +1 :green_heart: | shadedjars | 9m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 26s | hbase-thrift in the patch passed. | | | | 44m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3984 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 847de4043e02 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/testReport/ | | Max. process+thread count | 2085 (vs. ulimit of 3) | | modules | C: hbase-thrift U: hbase-thrift | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3986: HBASE-26635 Optimize decodeNumeric in OrderedBytes
Apache-HBase commented on pull request #3986: URL: https://github.com/apache/hbase/pull/3986#issuecomment-1003488850 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | master passed | | +1 :green_heart: | compile | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 9m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 3s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 9m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 34s | hbase-common in the patch passed. | | | | 35m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3986 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fcb0130ce3e0 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/testReport/ | | Max. process+thread count | 233 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3986: HBASE-26635 Optimize decodeNumeric in OrderedBytes
Apache-HBase commented on pull request #3986: URL: https://github.com/apache/hbase/pull/3986#issuecomment-1003488720 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 36s | master passed | | +1 :green_heart: | compile | 0m 28s | master passed | | +1 :green_heart: | shadedjars | 9m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 21s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 9m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 3s | hbase-common in the patch passed. | | | | 34m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3986 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5c59c042ceee 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/testReport/ | | Max. process+thread count | 227 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3984: HBASE-26629 Add expiration for long time vacant scanners in Thrift2
Apache-HBase commented on pull request #3984: URL: https://github.com/apache/hbase/pull/3984#issuecomment-1003488665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | master passed | | +1 :green_heart: | compile | 0m 34s | master passed | | +1 :green_heart: | shadedjars | 8m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 55s | the patch passed | | +1 :green_heart: | compile | 0m 33s | the patch passed | | +1 :green_heart: | javac | 0m 33s | the patch passed | | +1 :green_heart: | shadedjars | 8m 21s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 45s | hbase-thrift in the patch passed. | | | | 34m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3984 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c0539434f8ac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/testReport/ | | Max. process+thread count | 2238 (vs. ulimit of 3) | | modules | C: hbase-thrift U: hbase-thrift | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3984/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on a change in pull request #3984: HBASE-26629 Add expiration for long time vacant scanners in Thrift2
YutSean commented on a change in pull request #3984:
URL: https://github.com/apache/hbase/pull/3984#discussion_r777072649
##
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
##
@@ -160,7 +162,12 @@ public int hashCode() {
public ThriftHBaseServiceHandler(final Configuration conf,
final UserProvider userProvider) throws IOException {
super(conf, userProvider);
+long cacheTimeout = conf.getLong(HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD,
Review comment:
Agree. Fixed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3986: HBASE-26635 Optimize decodeNumeric in OrderedBytes
Apache-HBase commented on pull request #3986: URL: https://github.com/apache/hbase/pull/3986#issuecomment-1003473140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | checkstyle | 0m 25s | master passed | | +1 :green_heart: | spotbugs | 0m 48s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 20s | the patch passed | | +1 :green_heart: | compile | 0m 50s | the patch passed | | +1 :green_heart: | javac | 0m 50s | the patch passed | | +1 :green_heart: | checkstyle | 0m 25s | hbase-common: The patch generated 0 new + 37 unchanged - 3 fixed = 37 total (was 40) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 22m 12s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 0m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 45m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3986 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux cb4204befac0 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3986: HBASE-26635 Optimize decodeNumeric in OrderedBytes
Apache-HBase commented on pull request #3986: URL: https://github.com/apache/hbase/pull/3986#issuecomment-1003471657 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | master passed | | +1 :green_heart: | compile | 0m 27s | master passed | | +1 :green_heart: | shadedjars | 9m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 9m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 36s | hbase-common in the patch passed. | | | | 35m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3986 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4f52c601f6c9 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/testReport/ | | Max. process+thread count | 208 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3986: HBASE-26635 Optimize decodeNumeric in OrderedBytes
Apache-HBase commented on pull request #3986: URL: https://github.com/apache/hbase/pull/3986#issuecomment-1003471304 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 33s | master passed | | +1 :green_heart: | compile | 0m 28s | master passed | | +1 :green_heart: | shadedjars | 9m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 23s | the patch passed | | +1 :green_heart: | compile | 0m 25s | the patch passed | | +1 :green_heart: | javac | 0m 25s | the patch passed | | +1 :green_heart: | shadedjars | 9m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 3s | hbase-common in the patch passed. | | | | 33m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3986 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 59436618def1 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/testReport/ | | Max. process+thread count | 238 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3986/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26523) Upgrade hbase-thirdparty dependency to 4.0.1
[
https://issues.apache.org/jira/browse/HBASE-26523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467347#comment-17467347
]
Hudson commented on HBASE-26523:
Results for branch master
[build #482 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/482/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/482/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/482/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/482/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade hbase-thirdparty dependency to 4.0.1
>
>
> Key: HBASE-26523
> URL: https://issues.apache.org/jira/browse/HBASE-26523
> Project: HBase
> Issue Type: Task
> Components: thirdparty
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26636) Update the ref guide upgrading section to mention that the master issue when upgrading to 2.3
[
https://issues.apache.org/jira/browse/HBASE-26636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467346#comment-17467346
]
Hudson commented on HBASE-26636:
Results for branch master
[build #482 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/482/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/482/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/482/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/482/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update the ref guide upgrading section to mention that the master issue when
> upgrading to 2.3
> -
>
> Key: HBASE-26636
> URL: https://issues.apache.org/jira/browse/HBASE-26636
> Project: HBase
> Issue Type: Task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> Since we migrate the procedure store while upgrading the active master, if
> there are backup masters which are still on the old version should not become
> active any more, otherwise it may cause problems.
> We should mention this in the ref guide.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] joshelser commented on a change in pull request #3969: HBASE-26614 Refactor code related to "dump"ing ZK nodes
joshelser commented on a change in pull request #3969:
URL: https://github.com/apache/hbase/pull/3969#discussion_r777047437
##
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKDump.java
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.zookeeper;
+
+import java.io.BufferedReader;
+import java.io.BufferedWriter;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
+import java.io.PrintWriter;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.UnknownHostException;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.LinkedList;
+import java.util.List;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.exceptions.DeserializationException;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.zookeeper.KeeperException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import
org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ReplicationProtos;
+
+/**
+ * Builds a string containing everything in ZooKeeper. This is inherently
invasive into the
+ * structures of other components' logical responsibilities.
+ */
+@InterfaceAudience.Private
+public final class ZKDump {
+ private static final Logger LOG = LoggerFactory.getLogger(ZKDump.class);
+
+ private ZKDump() {}
+
+ public static String dump(final ZKWatcher zkWatcher) {
+final int zkDumpConnectionTimeOut = zkWatcher.getConfiguration()
+ .getInt("zookeeper.dump.connection.timeout", 1000);
+StringBuilder sb = new StringBuilder();
+try {
+ sb.append("HBase is rooted at
").append(zkWatcher.getZNodePaths().baseZNode);
+ sb.append("\nActive master address: ");
+ try {
+sb.append("\n
").append(MasterAddressTracker.getMasterAddress(zkWatcher));
+ } catch (IOException e) {
+sb.append("<>");
+ }
+ sb.append("\nBackup master addresses:");
+ final List backupMasterChildrenNoWatchList =
ZKUtil.listChildrenNoWatch(zkWatcher,
+zkWatcher.getZNodePaths().backupMasterAddressesZNode);
+ if (backupMasterChildrenNoWatchList != null) {
+for (String child : backupMasterChildrenNoWatchList) {
+ sb.append("\n ").append(child);
+}
+ }
+ sb.append("\nRegion server holding hbase:meta:");
+ sb.append("\n
").append(MetaTableLocator.getMetaRegionLocation(zkWatcher));
+ int numMetaReplicas = zkWatcher.getMetaReplicaNodes().size();
+ for (int i = 1; i < numMetaReplicas; i++) {
+sb.append("\n")
+ .append(" replica").append(i).append(": ")
+ .append(MetaTableLocator.getMetaRegionLocation(zkWatcher, i));
+ }
+ sb.append("\nRegion servers:");
+ final List rsChildrenNoWatchList =
+ZKUtil.listChildrenNoWatch(zkWatcher,
zkWatcher.getZNodePaths().rsZNode);
+ if (rsChildrenNoWatchList != null) {
+for (String child : rsChildrenNoWatchList) {
+ sb.append("\n ").append(child);
+}
+ }
+ try {
+getReplicationZnodesDump(zkWatcher, sb);
Review comment:
Would recommend printing some header here like for the other sections.
##
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKDump.java
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS"
[GitHub] [hbase] Apache-HBase commented on pull request #3969: HBASE-26614 Refactor code related to "dump"ing ZK nodes
Apache-HBase commented on pull request #3969: URL: https://github.com/apache/hbase/pull/3969#issuecomment-1003439169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 14s | master passed | | +1 :green_heart: | compile | 2m 17s | master passed | | +1 :green_heart: | shadedjars | 9m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 18s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 7s | the patch passed | | +1 :green_heart: | compile | 2m 17s | the patch passed | | +1 :green_heart: | javac | 2m 17s | the patch passed | | +1 :green_heart: | shadedjars | 9m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 53s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 206m 11s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 1m 9s | hbase-it in the patch passed. | | | | 247m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3969 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d55b042a6c96 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/testReport/ | | Max. process+thread count | 2795 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server hbase-it U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3983: HBASE-26494 Using RefCnt to fix the flawed MemStoreLABImpl
Apache-HBase commented on pull request #3983: URL: https://github.com/apache/hbase/pull/3983#issuecomment-1003438808 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 9m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 17s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 9m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 216m 8s | hbase-server in the patch failed. | | | | 249m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3983 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9f9570a427ef 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/testReport/ | | Max. process+thread count | 2653 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26523) Upgrade hbase-thirdparty dependency to 4.0.1
[
https://issues.apache.org/jira/browse/HBASE-26523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467299#comment-17467299
]
Hudson commented on HBASE-26523:
Results for branch branch-2
[build #429 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/429/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/429/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/429/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/429/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/429/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade hbase-thirdparty dependency to 4.0.1
>
>
> Key: HBASE-26523
> URL: https://issues.apache.org/jira/browse/HBASE-26523
> Project: HBase
> Issue Type: Task
> Components: thirdparty
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Blocker
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #3969: HBASE-26614 Refactor code related to "dump"ing ZK nodes
Apache-HBase commented on pull request #3969: URL: https://github.com/apache/hbase/pull/3969#issuecomment-1003431171 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 28s | master passed | | +1 :green_heart: | compile | 1m 53s | master passed | | +1 :green_heart: | shadedjars | 8m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 1m 55s | the patch passed | | +1 :green_heart: | javac | 1m 55s | the patch passed | | +1 :green_heart: | shadedjars | 8m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 48s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 150m 55s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 1m 19s | hbase-it in the patch passed. | | | | 188m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3969 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1cdfd3be0446 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/testReport/ | | Max. process+thread count | 3674 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server hbase-it U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3983: HBASE-26494 Using RefCnt to fix the flawed MemStoreLABImpl
Apache-HBase commented on pull request #3983: URL: https://github.com/apache/hbase/pull/3983#issuecomment-1003429067 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 8m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 34s | the patch passed | | +1 :green_heart: | compile | 1m 15s | the patch passed | | +1 :green_heart: | javac | 1m 15s | the patch passed | | +1 :green_heart: | shadedjars | 8m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 145m 15s | hbase-server in the patch passed. | | | | 179m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3983 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6de2d0ca9b3c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/testReport/ | | Max. process+thread count | 3740 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3991: HBASE-26637 Add more information to release manager table in our ref …
Apache-HBase commented on pull request #3991: URL: https://github.com/apache/hbase/pull/3991#issuecomment-1003413246 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | master passed | | +0 :ok: | refguide | 3m 43s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 3m 43s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 18m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3991 | | Optional Tests | dupname asflicense refguide | | uname | Linux 13e1d7d320bc 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | refguide | https://nightlies.apache.org/hbase/HBase/HBase-PreCommit-GitHub-PR/PR-3991/2/yetus-general-check/output/branch-site/book.html | | refguide | https://nightlies.apache.org/hbase/HBase/HBase-PreCommit-GitHub-PR/PR-3991/2/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3641: HBASE-26006 Update ref guide about the 2.4.x release line
Apache9 commented on pull request #3641: URL: https://github.com/apache/hbase/pull/3641#issuecomment-1003410169 #3989 has already been merged, where we mention the possible problem when upgrading to 2.3. Will open another PR to for updating ref guide about 2.4.x release line. Shout if you guys still want to work on this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3969: HBASE-26614 Refactor code related to "dump"ing ZK nodes
Apache-HBase commented on pull request #3969: URL: https://github.com/apache/hbase/pull/3969#issuecomment-1003409905 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 54s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 51s | master passed | | +1 :green_heart: | compile | 4m 29s | master passed | | +1 :green_heart: | checkstyle | 1m 34s | master passed | | +1 :green_heart: | spotbugs | 3m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | -1 :x: | compile | 0m 22s | hbase-zookeeper in the patch failed. | | -0 :warning: | javac | 0m 22s | hbase-zookeeper in the patch failed. | | +1 :green_heart: | checkstyle | 1m 34s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 38s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 3m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 39s | The patch does not generate ASF License warnings. | | | | 59m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3969 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7866dba057a4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/artifact/yetus-general-check/output/patch-compile-hbase-zookeeper.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/artifact/yetus-general-check/output/patch-compile-hbase-zookeeper.txt | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server hbase-it U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3969/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3991: HBASE-26637 Add more information to release manager table in our ref …
Apache-HBase commented on pull request #3991: URL: https://github.com/apache/hbase/pull/3991#issuecomment-1003409871 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3991 | | Optional Tests | | | uname | Linux af4fdaa9cef7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Max. process+thread count | 51 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3991: HBASE-26637 Add more information to release manager table in our ref …
Apache-HBase commented on pull request #3991: URL: https://github.com/apache/hbase/pull/3991#issuecomment-1003409831 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3991 | | Optional Tests | | | uname | Linux ad137819bf3d 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Max. process+thread count | 43 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3983: HBASE-26494 Using RefCnt to fix the flawed MemStoreLABImpl
Apache-HBase commented on pull request #3983: URL: https://github.com/apache/hbase/pull/3983#issuecomment-1003407508 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | compile | 3m 30s | master passed | | +1 :green_heart: | checkstyle | 1m 8s | master passed | | +1 :green_heart: | spotbugs | 2m 19s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 10s | the patch passed | | +1 :green_heart: | compile | 3m 33s | the patch passed | | +1 :green_heart: | javac | 3m 33s | the patch passed | | +1 :green_heart: | checkstyle | 1m 7s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 38s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 2m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 52m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3983 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux be9efbb75dc0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 96 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3983/5/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3991: HBASE-26637 Add more information to release manager table in our ref …
Apache-HBase commented on pull request #3991: URL: https://github.com/apache/hbase/pull/3991#issuecomment-1003401193 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 34s | master passed | | +0 :ok: | refguide | 4m 4s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 3m 45s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 19m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3991 | | Optional Tests | dupname asflicense refguide | | uname | Linux 8bcef144a82c 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | refguide | https://nightlies.apache.org/hbase/HBase/HBase-PreCommit-GitHub-PR/PR-3991/1/yetus-general-check/output/branch-site/book.html | | refguide | https://nightlies.apache.org/hbase/HBase/HBase-PreCommit-GitHub-PR/PR-3991/1/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26631) Upgrade junit to 4.13.2
[ https://issues.apache.org/jira/browse/HBASE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467273#comment-17467273 ] Duo Zhang commented on HBASE-26631: --- Assigned the issue to you. Please open a PR for this change. Thanks. > Upgrade junit to 4.13.2 > --- > > Key: HBASE-26631 > URL: https://issues.apache.org/jira/browse/HBASE-26631 > Project: HBase > Issue Type: Task > Components: security, test >Reporter: Duo Zhang >Assignee: 范成波 >Priority: Major > > There is a CVE-2020-15250 of 4.13, not very critical but let's fix it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (HBASE-26631) Upgrade junit to 4.13.2
[ https://issues.apache.org/jira/browse/HBASE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26631: - Assignee: 范成波 > Upgrade junit to 4.13.2 > --- > > Key: HBASE-26631 > URL: https://issues.apache.org/jira/browse/HBASE-26631 > Project: HBase > Issue Type: Task > Components: security, test >Reporter: Duo Zhang >Assignee: 范成波 >Priority: Major > > There is a CVE-2020-15250 of 4.13, not very critical but let's fix it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #3991: HBASE-26637 Add more information to release manager table in our ref …
Apache-HBase commented on pull request #3991: URL: https://github.com/apache/hbase/pull/3991#issuecomment-1003398733 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 7m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3991 | | Optional Tests | | | uname | Linux efba8c76e605 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Max. process+thread count | 43 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3984: HBASE-26629 Add expiration for long time vacant scanners in Thrift2
Apache9 commented on a change in pull request #3984:
URL: https://github.com/apache/hbase/pull/3984#discussion_r777021051
##
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
##
@@ -160,7 +162,12 @@ public int hashCode() {
public ThriftHBaseServiceHandler(final Configuration conf,
final UserProvider userProvider) throws IOException {
super(conf, userProvider);
+long cacheTimeout = conf.getLong(HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD,
Review comment:
We should close the scanner when expiring it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3991: HBASE-26637 Add more information to release manager table in our ref …
Apache-HBase commented on pull request #3991: URL: https://github.com/apache/hbase/pull/3991#issuecomment-1003397619 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3991 | | Optional Tests | | | uname | Linux bfea20774a5f 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e469e4a2a | | Max. process+thread count | 51 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3991/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26631) Upgrade junit to 4.13.2
[ https://issues.apache.org/jira/browse/HBASE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467271#comment-17467271 ] 范成波 commented on HBASE-26631: - i want to try > Upgrade junit to 4.13.2 > --- > > Key: HBASE-26631 > URL: https://issues.apache.org/jira/browse/HBASE-26631 > Project: HBase > Issue Type: Task > Components: security, test >Reporter: Duo Zhang >Priority: Major > > There is a CVE-2020-15250 of 4.13, not very critical but let's fix it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache9 commented on pull request #3986: HBASE-26635 Optimize decodeNumeric in OrderedBytes
Apache9 commented on pull request #3986: URL: https://github.com/apache/hbase/pull/3986#issuecomment-1003397453 Please fix the checkstyle issue? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26632) Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md
[ https://issues.apache.org/jira/browse/HBASE-26632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467270#comment-17467270 ] 范成波 commented on HBASE-26632: - i want to try > Should use downloads.apache.org for checksum, signature, changes.md and > releasenote.md > -- > > Key: HBASE-26632 > URL: https://issues.apache.org/jira/browse/HBASE-26632 > Project: HBase > Issue Type: Task > Components: website >Reporter: Duo Zhang >Priority: Major > > We still use dist.apache.org for some releases, should change them too. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache9 opened a new pull request #3991: HBASE-26637 Add more information to release manager table in our ref …
Apache9 opened a new pull request #3991: URL: https://github.com/apache/hbase/pull/3991 …guide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26634) Upgrade log4j to 2.17.1
[ https://issues.apache.org/jira/browse/HBASE-26634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467269#comment-17467269 ] 范成波 commented on HBASE-26634: - i want to try > Upgrade log4j to 2.17.1 > --- > > Key: HBASE-26634 > URL: https://issues.apache.org/jira/browse/HBASE-26634 > Project: HBase > Issue Type: Task > Components: logging, security >Reporter: Duo Zhang >Priority: Major > > For addressing CVE-2021-44832. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-25283) Undo meta replica specialization inside of the region replica framework
[
https://issues.apache.org/jira/browse/HBASE-25283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-25283.
---
Resolution: Fixed
HBASE-26233 has been merged.
Resolve this one.
> Undo meta replica specialization inside of the region replica framework
> ---
>
> Key: HBASE-25283
> URL: https://issues.apache.org/jira/browse/HBASE-25283
> Project: HBase
> Issue Type: Improvement
> Components: read replicas
>Reporter: Michael Stack
>Priority: Major
>
> Filing an issue to capture a [~zhangduo] suggestion made in PR that was then
> carried to a comment over in the design document attached to HBASE-18070 only
> it is deserving of its own issue.
> {quote}
> I do not like that we have a specialized implementation for meta replica
> inside the region replica framework. They are almost the same so they should
> share the same code base. I think this enhancement could also be applied to
> normal RegionReplicaReplicationEndpoint, what we need is the config for the
> max distance between different secondary replicas. For normal region
> replicas, the value will be small, which means we will soon block the
> replication if any replicas are slow, to save memory. For meta replicas, we
> could have a large default value to let the good replicas catch up fast.
> {quote}
>
> Lets use this issue to fill out more on what [~zhangduo] suggests above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (HBASE-26233) The region replication framework should not be built upon the general replication framework
[ https://issues.apache.org/jira/browse/HBASE-26233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26233. --- Fix Version/s: 3.0.0-alpha-3 Hadoop Flags: Reviewed Resolution: Fixed Merged the feature branch to master. Thanks all for helping! > The region replication framework should not be built upon the general > replication framework > --- > > Key: HBASE-26233 > URL: https://issues.apache.org/jira/browse/HBASE-26233 > Project: HBase > Issue Type: Umbrella > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > At least, at the source path, where we track the edits, we should not make > region replication rely on general replication framework. > The difficulty here for switching to a table based storage is that, the WAL > system and replication system highly depend on each other. There will be > cyclic dependency if we want to store replication peer and queue data in a > hbase table. > And after HBASE-18070, even meta wal provider will be integrated together > with replication system, which makes things more difficult. > But in general, for region replication, it is not a big deal to lose some > edits, a flush can fix everything, which means we do not so heavy tracking > system in the general replication system. > We should find a more light-weighted way to do region replication. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26412) Handle sink failure in RegionReplicationSink
[ https://issues.apache.org/jira/browse/HBASE-26412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26412: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Handle sink failure in RegionReplicationSink > > > Key: HBASE-26412 > URL: https://issues.apache.org/jira/browse/HBASE-26412 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26487) Run some tests to verify the new region replication framework
[ https://issues.apache.org/jira/browse/HBASE-26487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26487: -- Fix Version/s: 3.0.0-alpha-3 > Run some tests to verify the new region replication framework > - > > Key: HBASE-26487 > URL: https://issues.apache.org/jira/browse/HBASE-26487 > Project: HBase > Issue Type: Sub-task > Components: integration tests, test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > Make sure there is no big bugs before merging back. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26457) Should not always clear all the failed replicas when getting a flush all request
[ https://issues.apache.org/jira/browse/HBASE-26457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26457: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Should not always clear all the failed replicas when getting a flush all > request > > > Key: HBASE-26457 > URL: https://issues.apache.org/jira/browse/HBASE-26457 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > As described in this section in the design doc: > https://docs.google.com/document/d/1WPSBwRqIPgTrPRM2wtzAe-3XUvA9S7auWy3Fy8xuZLc/edit#heading=h.8nfip05gosr > We need to make sure that all the edits which have been sent to the broken > replica must have a less sequence id than the flush sequence number of the > commit flush edit, then we are safe to recover it. Otherwise we may miss some > edit. > The current implementation is not enough, we need to improve it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26417) Remove NoopReplicationQueueStorage
[ https://issues.apache.org/jira/browse/HBASE-26417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26417: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Remove NoopReplicationQueueStorage > -- > > Key: HBASE-26417 > URL: https://issues.apache.org/jira/browse/HBASE-26417 > Project: HBase > Issue Type: Sub-task > Components: meta replicas, read replicas, Replication >Reporter: Duo Zhang >Assignee: linshangquan >Priority: Major > Fix For: 3.0.0-alpha-3 > > > It is not used any more since we removed CatalogReplicationSource. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26486) Attach the new region replication framework design doc to git repo
[ https://issues.apache.org/jira/browse/HBASE-26486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26486: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Attach the new region replication framework design doc to git repo > -- > > Key: HBASE-26486 > URL: https://issues.apache.org/jira/browse/HBASE-26486 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26478) Update ref guide about the new region replication framework
[ https://issues.apache.org/jira/browse/HBASE-26478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26478: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Update ref guide about the new region replication framework > --- > > Key: HBASE-26478 > URL: https://issues.apache.org/jira/browse/HBASE-26478 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > About the basic design, how to use it, and how to upgrade from old framework. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26449) The way we add or clear failedReplicas may have race
[ https://issues.apache.org/jira/browse/HBASE-26449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26449: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > The way we add or clear failedReplicas may have race > > > Key: HBASE-26449 > URL: https://issues.apache.org/jira/browse/HBASE-26449 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > We will add a replica to failedReplicas in the callback of the replay method > call, and we will clear the failedReplicas in add method when we meet a flush > all edit. > They are in different threads, so it is possible that, we have already clear > the failedReplicas due to a flush all edit, then in the callback of replay, > we add a replica to the failedReplicas because of a failure of replicating, > although the failure is actually before the flush all edit. > We should find a way to fix this. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26481) Consider rolling upgrading from old region replication framework
[ https://issues.apache.org/jira/browse/HBASE-26481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26481: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Consider rolling upgrading from old region replication framework > > > Key: HBASE-26481 > URL: https://issues.apache.org/jira/browse/HBASE-26481 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > In the old implementation, we will cerate a replication peer for region > replication. And in the new framework, we do not need the peer any more, so > we have deleted the RegionReplicaReplicationEndpoint class. > But when rolling upgrading, the peer is still there so we will try to load it > and it will lead to a class not found exception. We need to handle it. > And during the upgrading, some of the region servers may not have the correct > replicateToReplica method yet. Maybe we could try to catch the no such method > error and try to fallback to use replay method. Although it is not perfect, > but finally a flush can fix everything. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26540) Implement a tool to verify the lag of region replication
[ https://issues.apache.org/jira/browse/HBASE-26540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26540: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Implement a tool to verify the lag of region replication > > > Key: HBASE-26540 > URL: https://issues.apache.org/jira/browse/HBASE-26540 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > The new region replication framework is expected to have a smaller lag when > replicating, as it uses an in memory queue. > We should implement a tool to see if it works as expected. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26413) Limit the total size of buffered region replication entries
[ https://issues.apache.org/jira/browse/HBASE-26413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26413: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Limit the total size of buffered region replication entries > --- > > Key: HBASE-26413 > URL: https://issues.apache.org/jira/browse/HBASE-26413 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26448) Make sure we do not flush a region too frequently
[ https://issues.apache.org/jira/browse/HBASE-26448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26448: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Make sure we do not flush a region too frequently > - > > Key: HBASE-26448 > URL: https://issues.apache.org/jira/browse/HBASE-26448 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > In HBASE-26412, once we found there is an error replicating the edits, we > will trigger a flush, and in HBASE-26413, we are likely to also trigger a > flush when the pending edits are too large. > We should find a way to avoid flushing the region too much. > And a failure of replicating usually means the region is moved or the target > region server is crashed, only a flush after the secondary replica is online > will be useful, so flushing the region lots of times before the scedondary > replica online is just useless. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26456) Limit the size for one replicating
[ https://issues.apache.org/jira/browse/HBASE-26456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26456: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Limit the size for one replicating > -- > > Key: HBASE-26456 > URL: https://issues.apache.org/jira/browse/HBASE-26456 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > Now we will always try to replicate all the pending entries, which could be > too large. We should have a size/count limit, to avoid putting too much > pressure to the target region server for some extreme cases. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26538) Should find a way to clear the replication queue for a legacy region_replica_replication peer
[ https://issues.apache.org/jira/browse/HBASE-26538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26538: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Should find a way to clear the replication queue for a legacy > region_replica_replication peer > - > > Key: HBASE-26538 > URL: https://issues.apache.org/jira/browse/HBASE-26538 > Project: HBase > Issue Type: Sub-task > Components: read replicas, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > When rolling upgrading, we will delete the legacy region_replica_replication > peer. But since the old region servers still use this peer for replicating, > we can not delete all the replication queues. > We need to find a way to deal with these legacy replication queues after > upgrading. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26539) The default rpc timeout 200ms is too small for replicating meta edits
[ https://issues.apache.org/jira/browse/HBASE-26539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26539: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > The default rpc timeout 200ms is too small for replicating meta edits > - > > Key: HBASE-26539 > URL: https://issues.apache.org/jira/browse/HBASE-26539 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > For most meta edits, we will call refreshStoreFiles, which is time consuming. > When running tests in HBASE-26487, it is very easy to timeout and cause the > replicating to pause for a while. > I think for replicating meta edits, we should have a larger timeout value. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26416) Implement a new method for region replication instead of using replay
[ https://issues.apache.org/jira/browse/HBASE-26416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26416: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Implement a new method for region replication instead of using replay > - > > Key: HBASE-26416 > URL: https://issues.apache.org/jira/browse/HBASE-26416 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > The replay method is design to be used for DLR, which has been removed for a > long time. > We should have our own version for replay the edits for region replication, > which could be more flexible. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26407) Introduce a region replication sink for sinking WAL edits to secondary replicas directly
[ https://issues.apache.org/jira/browse/HBASE-26407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26407: -- Fix Version/s: 3.0.0-alpha-3 (was: HBASE-26233) > Introduce a region replication sink for sinking WAL edits to secondary > replicas directly > > > Key: HBASE-26407 > URL: https://issues.apache.org/jira/browse/HBASE-26407 > Project: HBase > Issue Type: Sub-task > Components: read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > Without reading the WAL file. > This could decouple the dependency between WAL and replication a bit, and > also it will have a much lower latency. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26233) The region replication framework should not be built upon the general replication framework
[
https://issues.apache.org/jira/browse/HBASE-26233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467260#comment-17467260
]
Hudson commented on HBASE-26233:
Results for branch HBASE-26233
[build #15 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/HBASE-26233/15/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/HBASE-26233/15/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/HBASE-26233/15/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/HBASE-26233/15/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> The region replication framework should not be built upon the general
> replication framework
> ---
>
> Key: HBASE-26233
> URL: https://issues.apache.org/jira/browse/HBASE-26233
> Project: HBase
> Issue Type: Umbrella
> Components: read replicas
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> At least, at the source path, where we track the edits, we should not make
> region replication rely on general replication framework.
> The difficulty here for switching to a table based storage is that, the WAL
> system and replication system highly depend on each other. There will be
> cyclic dependency if we want to store replication peer and queue data in a
> hbase table.
> And after HBASE-18070, even meta wal provider will be integrated together
> with replication system, which makes things more difficult.
> But in general, for region replication, it is not a big deal to lose some
> edits, a flush can fix everything, which means we do not so heavy tracking
> system in the general replication system.
> We should find a more light-weighted way to do region replication.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
[
https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-23792.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Please open a backport issue for backporting to branch-1 as the issue has been
resolved long ago.
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> ---
>
> Key: HBASE-23792
> URL: https://issues.apache.org/jira/browse/HBASE-23792
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0, 1.7.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.3.0, 3.0.0-alpha-1
>
> Attachments:
> TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS:
> file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1,
> expected: hdfs://localhost:44609
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
[
https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23792:
--
Fix Version/s: 2.2.4
2.1.9
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> ---
>
> Key: HBASE-23792
> URL: https://issues.apache.org/jira/browse/HBASE-23792
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0, 1.7.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.1.9, 2.2.4
>
> Attachments:
> TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS:
> file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1,
> expected: hdfs://localhost:44609
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
[
https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23792:
--
Fix Version/s: 3.0.0-alpha-1
(was: 3.0.0-alpha-3)
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> ---
>
> Key: HBASE-23792
> URL: https://issues.apache.org/jira/browse/HBASE-23792
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0, 1.7.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
> Attachments:
> TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS:
> file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1,
> expected: hdfs://localhost:44609
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
[
https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23792:
--
Fix Version/s: 2.3.0
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> ---
>
> Key: HBASE-23792
> URL: https://issues.apache.org/jira/browse/HBASE-23792
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0, 1.7.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.3.0, 3.0.0-alpha-3
>
> Attachments:
> TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS:
> file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1,
> expected: hdfs://localhost:44609
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
[
https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23792:
--
Fix Version/s: (was: 2.2.4)
(was: 2.3.0)
(was: 2.1.9)
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> ---
>
> Key: HBASE-23792
> URL: https://issues.apache.org/jira/browse/HBASE-23792
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0, 1.7.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
> Attachments:
> TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}}
> fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS:
> file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1,
> expected: hdfs://localhost:44609
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-25094) Improve HBase MultiTablieInputFormat support MapReduce multi Scan
[ https://issues.apache.org/jira/browse/HBASE-25094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25094: -- Fix Version/s: (was: 2.1.7) > Improve HBase MultiTablieInputFormat support MapReduce multi Scan > - > > Key: HBASE-25094 > URL: https://issues.apache.org/jira/browse/HBASE-25094 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Affects Versions: 2.1.7 >Reporter: Jeff Chen >Priority: Minor > > test -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException
[ https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467254#comment-17467254 ] Duo Zhang commented on HBASE-23669: --- The tablesOnMaster flag has been removed on master. We do not allow master to carry regions any more. But maybe we should still fix it for 2.x. Mind opening a PR against branch-2? [~gk_coder]? Now we use github PR for reviewing. Thanks. > ZNodeClearer#clear() throws IllegalArgumentException > - > > Key: HBASE-23669 > URL: https://issues.apache.org/jira/browse/HBASE-23669 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.5 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Major > Attachments: HBASE-23669.branch-2.1.0001.patch, > HBASE-23669.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by > regionserver process in HRegionServer#handleReportForDutyResponse() here is > how it looks on master server: > [hadoop@master-node data]$ cat hbase-hadoop-master.znode > /hbase/rs/master-node,16000,1578371505720 > When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of > the file, causing an exception： > java.lang.IllegalArgumentException: Invalid path string > "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node > name specified @10 > at > org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) > at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251) > at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) > at > org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) > at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117) > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException
[ https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23669: -- Fix Version/s: (was: 2.1.5) (was: 2.1.6) (was: 2.1.8) > ZNodeClearer#clear() throws IllegalArgumentException > - > > Key: HBASE-23669 > URL: https://issues.apache.org/jira/browse/HBASE-23669 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.5 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Major > Attachments: HBASE-23669.branch-2.1.0001.patch, > HBASE-23669.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by > regionserver process in HRegionServer#handleReportForDutyResponse() here is > how it looks on master server: > [hadoop@master-node data]$ cat hbase-hadoop-master.znode > /hbase/rs/master-node,16000,1578371505720 > When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of > the file, causing an exception： > java.lang.IllegalArgumentException: Invalid path string > "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node > name specified @10 > at > org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) > at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251) > at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) > at > org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) > at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117) > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26495) Limit the length of initial resultSets for HBase thrift service
[
https://issues.apache.org/jira/browse/HBASE-26495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26495:
--
Fix Version/s: 1.7.2
> Limit the length of initial resultSets for HBase thrift service
> ---
>
> Key: HBASE-26495
> URL: https://issues.apache.org/jira/browse/HBASE-26495
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Affects Versions: 1.4.14
>Reporter: wangjingying
>Priority: Major
> Fix For: 1.7.2
>
>
> When the client requests getScannerResults or getScannerRows, set up a large
> numRows will cause ArrayIndexOutOfBoundsException ，and may cause OOM.
> For example
> {code:java}
> conn := cli.(*hbase.THBaseServiceClient)
> tscan := {
>StartRow: []byte("prefix_1"),
>StopRow: []byte("prefix_2"),
>Columns: []*hbase.TColumn{
> {
> Family:[]byte("N"),
> Qualifier: []byte("title"),
> },
>},
> }
> scanresult, err := conn.GetScannerResults([]byte("rowkey1"), tscan,
> 1000){code}
> Here initialize the length of resultSets using the minimum value of
> "hbase.thrift.max.scanner.results.init.length" and numRows。
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26495) Limit the length of initial resultSets for HBase thrift service
[
https://issues.apache.org/jira/browse/HBASE-26495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26495:
--
Fix Version/s: (was: 1.4.14)
> Limit the length of initial resultSets for HBase thrift service
> ---
>
> Key: HBASE-26495
> URL: https://issues.apache.org/jira/browse/HBASE-26495
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Affects Versions: 1.4.14
>Reporter: wangjingying
>Priority: Major
>
> When the client requests getScannerResults or getScannerRows, set up a large
> numRows will cause ArrayIndexOutOfBoundsException ，and may cause OOM.
> For example
> {code:java}
> conn := cli.(*hbase.THBaseServiceClient)
> tscan := {
>StartRow: []byte("prefix_1"),
>StopRow: []byte("prefix_2"),
>Columns: []*hbase.TColumn{
> {
> Family:[]byte("N"),
> Qualifier: []byte("title"),
> },
>},
> }
> scanresult, err := conn.GetScannerResults([]byte("rowkey1"), tscan,
> 1000){code}
> Here initialize the length of resultSets using the minimum value of
> "hbase.thrift.max.scanner.results.init.length" and numRows。
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26067) Change the way on how we track store file list
[ https://issues.apache.org/jira/browse/HBASE-26067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467252#comment-17467252 ] Josh Elser commented on HBASE-26067: [~zhangduo] I started fixing conflicts on the first commit but that was as far as I got before the holidays here in the US. If you have the cycles to work on it, that's fine by me. > Change the way on how we track store file list > -- > > Key: HBASE-26067 > URL: https://issues.apache.org/jira/browse/HBASE-26067 > Project: HBase > Issue Type: Umbrella > Components: HFile >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > Open a separated jira to track the work since it can not be fully included in > HBASE-24749. > I think this could be a landed prior to HBASE-24749, as if this works, we > could have different implementations for tracking store file list. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-23650) lack of HMaster parameters in the SnapshotLogCleaner leads to NLP
[
https://issues.apache.org/jira/browse/HBASE-23650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467253#comment-17467253
]
Duo Zhang commented on HBASE-23650:
---
Is this problem 1.2 only or we still have this bug on other branches?
> lack of HMaster parameters in the SnapshotLogCleaner leads to NLP
> -
>
> Key: HBASE-23650
> URL: https://issues.apache.org/jira/browse/HBASE-23650
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.11
>Reporter: sangjiaqi
>Priority: Major
> Attachments: HBASE-23650.patch
>
>
> NullPointException occurs when the SnapshotCleaner calls the init function to
> initialize the HMaster parameter. Similar to the construction method of
> HFileCleaner, because the construction method of LogCleaner did not have
> HMaster parameter, leading to errors. Therefore, the construction method of
> LogCleaner solves the problem by adding HMaster parameters.
> The Log:
> {code:java}
> java.lang.NullPointerExceptionjava.lang.NullPointerException at
> org.apache.hadoop.hbase.master.snapshot.SnapshotLogCleaner.init(SnapshotLogCleaner.java:74)
> at
> org.apache.hadoop.hbase.master.cleaner.TestSnapshotAndLogCleaner.testSnapshotLogCleaning(TestSnapshotAndLogCleaner.java:68){code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-23650) lack of HMaster parameters in the SnapshotLogCleaner leads to NLP
[
https://issues.apache.org/jira/browse/HBASE-23650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23650:
--
Fix Version/s: (was: 1.2.11)
> lack of HMaster parameters in the SnapshotLogCleaner leads to NLP
> -
>
> Key: HBASE-23650
> URL: https://issues.apache.org/jira/browse/HBASE-23650
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.11
>Reporter: sangjiaqi
>Priority: Major
> Attachments: HBASE-23650.patch
>
>
> NullPointException occurs when the SnapshotCleaner calls the init function to
> initialize the HMaster parameter. Similar to the construction method of
> HFileCleaner, because the construction method of LogCleaner did not have
> HMaster parameter, leading to errors. Therefore, the construction method of
> LogCleaner solves the problem by adding HMaster parameters.
> The Log:
> {code:java}
> java.lang.NullPointerExceptionjava.lang.NullPointerException at
> org.apache.hadoop.hbase.master.snapshot.SnapshotLogCleaner.init(SnapshotLogCleaner.java:74)
> at
> org.apache.hadoop.hbase.master.cleaner.TestSnapshotAndLogCleaner.testSnapshotLogCleaning(TestSnapshotAndLogCleaner.java:68){code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.
[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24298: -- Component/s: Performance > Reduce cpu load of locating region especially in batch mode. > > > Key: HBASE-24298 > URL: https://issues.apache.org/jira/browse/HBASE-24298 > Project: HBase > Issue Type: Bug > Components: Performance >Affects Versions: 1.2.12 >Reporter: star >Assignee: star >Priority: Major > Attachments: HBASE-24298.patch, locating region.svg > > > Binary search is used to speedup the process of locating region. It is > already fast enough, while cpu of HBASE client becomes the bottleneck when > doing TCSB benchmark. We can make the process of locating region faster to > reduce cpu load in some special cases , which however is our common case in > production environment. It is the case: > 1. Predefined splits in uniform distribution. > > 2. Load data in batch mode. > The optimization is very simple, just to contract range of binary search. > Initially, record all startIndex and endIndex of first or two bytes of keys. > When a region key comes, find the contracted startIndex and endIndex of the > key. Then return to normal binary search process with the specified > startIndex and endIndex. > Then we can ideally reduce cpu to 1/8 with 1 byte or 1/16 with 2 bytes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.
[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24298: -- Fix Version/s: (was: 1.2.12) > Reduce cpu load of locating region especially in batch mode. > > > Key: HBASE-24298 > URL: https://issues.apache.org/jira/browse/HBASE-24298 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.12 >Reporter: star >Assignee: star >Priority: Major > Attachments: HBASE-24298.patch, locating region.svg > > > Binary search is used to speedup the process of locating region. It is > already fast enough, while cpu of HBASE client becomes the bottleneck when > doing TCSB benchmark. We can make the process of locating region faster to > reduce cpu load in some special cases , which however is our common case in > production environment. It is the case: > 1. Predefined splits in uniform distribution. > > 2. Load data in batch mode. > The optimization is very simple, just to contract range of binary search. > Initially, record all startIndex and endIndex of first or two bytes of keys. > When a region key comes, find the contracted startIndex and endIndex of the > key. Then return to normal binary search process with the specified > startIndex and endIndex. > Then we can ideally reduce cpu to 1/8 with 1 byte or 1/16 with 2 bytes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26347) Support detect and exclude slow DNs in fan-out of WAL
[
https://issues.apache.org/jira/browse/HBASE-26347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467248#comment-17467248
]
Hudson commented on HBASE-26347:
Results for branch master
[build #481 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/481/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/481/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/481/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/481/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Support detect and exclude slow DNs in fan-out of WAL
> -
>
> Key: HBASE-26347
> URL: https://issues.apache.org/jira/browse/HBASE-26347
> Project: HBase
> Issue Type: New Feature
> Components: wal
>Affects Versions: 2.0.0, 3.0.0-alpha-2
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> We all knows the WAL sync performance directly affects the RPC process time.
> And we use self-designed FanOutOneBlockAsyncDFSOutput to sync WAL entries,
> which connect straightly to all the block located DNs. But when even one DN
> of the locations is slow, e.g. some disk hardware failures, the WAL syncs
> slow. And what's more, the hardware failure detected by the lower layer HDFS
> system is not so sensitive.
> We can detect slow DNs by the ACK time of packets in
> FanOutOneBlockAsyncDFSOutput, and exclude them when add new blocks after log
> rolled(rolling log can also be triggered by slow syncs). And shows this info
> in UI. We can also invalid these excluded DN cache after a duration, to aware
> the recovery of those DNs.
> I think this idea can quickly reduce the influence of slow DNs, and improve
> the service availability.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
