[GitHub] [hbase] Apache9 merged pull request #4102: HBASE-26747 Use python2 instead of python in our python scripts
Apache9 merged pull request #4102: URL: https://github.com/apache/hbase/pull/4102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-26746) Update protobuf-java to 3.19.4
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489237#comment-17489237 ] Pankaj Kumar edited comment on HBASE-26746 at 2/9/22, 4:43 AM: --- Thanks [~busbey] for taking this up. This issue is applicable for branch-2 as well where we have depependecy, see . was (Author: pankajkumar): This issue is applicable for branch-2 as well where we have depependecy, see . > Update protobuf-java to 3.19.4 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Assignee: Sean Busbey >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26746) Update protobuf-java to 3.19.4
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489237#comment-17489237 ] Pankaj Kumar commented on HBASE-26746: -- This issue is applicable for branch-2 as well where we have depependecy, see . > Update protobuf-java to 3.19.4 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Assignee: Sean Busbey >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-26702) Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain histogram.
[
https://issues.apache.org/jira/browse/HBASE-26702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-26702.
---
Fix Version/s: 2.5.0
1.7.2
3.0.0-alpha-3
2.4.10
Hadoop Flags: Reviewed
Resolution: Fixed
> Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain
> histogram.
> --
>
> Key: HBASE-26702
> URL: https://issues.apache.org/jira/browse/HBASE-26702
> Project: HBase
> Issue Type: Improvement
> Components: metrics, Replication
>Affects Versions: 1.7.1, 2.3.7, 3.0.0-alpha-3
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Minor
> Fix For: 2.5.0, 1.7.2, 3.0.0-alpha-3, 2.4.10
>
>
> Currently age of last ship metric is an instance of an Histogram type.
> [Here|https://github.com/apache/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSourceImpl.java#L58]
> {quote}
>ageOfLastShippedOpHist =
> rms.getMetricsRegistry().getHistogram(SOURCE_AGE_OF_LAST_SHIPPED_OP);
> {quote}
> We can change it to TimeHistogram so that we get the range information also.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4102: HBASE-26747 Use python2 instead of python in our python scripts
Apache-HBase commented on pull request #4102: URL: https://github.com/apache/hbase/pull/4102#issuecomment-1033275277 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | pylint | 0m 21s | There were no new pylint issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 8m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4102/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4102 | | Optional Tests | dupname asflicense pylint | | uname | Linux d8ab4463d478 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / da9b5c01ab | | Max. process+thread count | 51 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4102/1/console | | versions | git=2.17.1 maven=3.6.3 pylint=2.4.4 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4102: HBASE-26747 Use python2 instead of python in our python scripts
Apache-HBase commented on pull request #4102: URL: https://github.com/apache/hbase/pull/4102#issuecomment-1033269711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4099: HBASE-26702 Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain histogram.
Apache9 merged pull request #4099: URL: https://github.com/apache/hbase/pull/4099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4098: HBASE-26702 Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain histogram.
Apache9 merged pull request #4098: URL: https://github.com/apache/hbase/pull/4098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4057: HBASE-26702 Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain histogram.
Apache9 merged pull request #4057: URL: https://github.com/apache/hbase/pull/4057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-26747) Use python2 instead of python in our python scripts
[ https://issues.apache.org/jira/browse/HBASE-26747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26747 started by Duo Zhang. - > Use python2 instead of python in our python scripts > --- > > Key: HBASE-26747 > URL: https://issues.apache.org/jira/browse/HBASE-26747 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > According to the suggestion from INFRA team, let's specify python2 directly. > Later we could see if we can migrate to python3. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (HBASE-26747) Use python2 instead of python in our python scripts
Duo Zhang created HBASE-26747: - Summary: Use python2 instead of python in our python scripts Key: HBASE-26747 URL: https://issues.apache.org/jira/browse/HBASE-26747 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang According to the suggestion from INFRA team, let's specify python2 directly. Later we could see if we can migrate to python3. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (HBASE-26747) Use python2 instead of python in our python scripts
[ https://issues.apache.org/jira/browse/HBASE-26747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26747: - Assignee: Duo Zhang > Use python2 instead of python in our python scripts > --- > > Key: HBASE-26747 > URL: https://issues.apache.org/jira/browse/HBASE-26747 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > According to the suggestion from INFRA team, let's specify python2 directly. > Later we could see if we can migrate to python3. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] joshelser commented on a change in pull request #4101: HBASE-26741 Incorrect exception handling in shell
joshelser commented on a change in pull request #4101: URL: https://github.com/apache/hbase/pull/4101#discussion_r802141273 ## File path: hbase-shell/src/main/ruby/irb/hirb.rb ## @@ -56,6 +56,108 @@ def output_value # after all output. super unless @context.last_value.nil? end + +# Copied from irb.rb and overrides the rescue Exception block so the +# Shell::exception_handler can deal with the exceptions. +def eval_input + @scanner.set_prompt do + |ltype, indent, continue, line_no| +if ltype + f = @context.prompt_s +elsif continue + f = @context.prompt_c +elsif indent > 0 + f = @context.prompt_n +else + f = @context.prompt_i +end +f = "" unless f +if @context.prompting? + @context.io.prompt = p = prompt(f, ltype, indent, line_no) +else + @context.io.prompt = p = "" +end +if @context.auto_indent_mode + unless ltype +ind = prompt(@context.prompt_i, ltype, indent, line_no)[/.*\z/].size + + indent * 2 - p.size +ind += 2 if continue +@context.io.prompt = p + " " * ind if ind > 0 + end +end + end + + @scanner.set_input(@context.io) do +signal_status(:IN_INPUT) do + if l = @context.io.gets +print l if @context.verbose? + else +if @context.ignore_eof? and @context.io.readable_after_eof? + l = "\n" + if @context.verbose? +printf "Use \"exit\" to leave %s\n", @context.ap_name + end +else + print "\n" +end + end + l +end + end + + @scanner.each_top_level_statement do |line, line_no| +signal_status(:IN_EVAL) do + begin +line.untaint +@context.evaluate(line, line_no) +output_value if @context.echo? +exc = nil + rescue Interrupt => exc + rescue SystemExit, SignalException +raise + rescue Exception +# Raise exception so Shell::exception_handler can catch it. Review comment: ```suggestion # HBASE-26741: Raise exception so Shell::exception_handler can catch it. # This modifies this copied method from JRuby so that the HBase shell can # manage the exception and set a proper exit code on the process. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4024: HBASE-26521 Name RPC spans as `$package.$service/$method`
Apache-HBase commented on pull request #4024: URL: https://github.com/apache/hbase/pull/4024#issuecomment-1033024895 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | compile | 2m 44s | master passed | | +1 :green_heart: | shadedjars | 8m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 36s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 48s | the patch passed | | +1 :green_heart: | compile | 2m 50s | the patch passed | | +1 :green_heart: | javac | 2m 50s | the patch passed | | +1 :green_heart: | shadedjars | 8m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 380m 29s | root in the patch failed. | | | | 421m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4024 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a9294f2cd344 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 36d8654a97 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/testReport/ | | Max. process+thread count | 4981 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #77: HBASE-26746 Update protobuf-java to 3.19.4
Apache-HBase commented on pull request #77: URL: https://github.com/apache/hbase-thirdparty/pull/77#issuecomment-1032950584 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 50s | master passed | | +1 :green_heart: | compile | 0m 13s | master passed | | +1 :green_heart: | javadoc | 0m 8s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 25s | the patch passed | | +1 :green_heart: | compile | 0m 12s | the patch passed | | +1 :green_heart: | javac | 0m 12s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 32s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 7s | The patch does not generate ASF License warnings. | | | | 4m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-77/1/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/77 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 993b99bb7b99 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 04aa08b | | Default Java | Oracle Corporation-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-77/1/testReport/ | | Max. process+thread count | 401 (vs. ulimit of 1000) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-77/1/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4024: HBASE-26521 Name RPC spans as `$package.$service/$method`
Apache-HBase commented on pull request #4024: URL: https://github.com/apache/hbase/pull/4024#issuecomment-1032938206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 10s | master passed | | +1 :green_heart: | compile | 3m 38s | master passed | | +1 :green_heart: | shadedjars | 9m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 47s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 3s | the patch passed | | +1 :green_heart: | compile | 3m 36s | the patch passed | | +1 :green_heart: | javac | 3m 36s | the patch passed | | +1 :green_heart: | shadedjars | 9m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 270m 46s | root in the patch passed. | | | | 320m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4024 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 115a8e68a1b6 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 36d8654a97 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/testReport/ | | Max. process+thread count | 4403 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26746) Update protobuf-java to 3.19.4
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-26746: Status: Patch Available (was: Open) > Update protobuf-java to 3.19.4 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Assignee: Sean Busbey >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (HBASE-26746) Update protobuf-java to 3.19.4
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-26746: --- Assignee: Sean Busbey > Update protobuf-java to 3.19.4 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Assignee: Sean Busbey >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26746) Update protobuf-java to 3.19.4
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-26746: Summary: Update protobuf-java to 3.19.4 (was: Protobuf jar is vulnerable with CVE-2021-22569) > Update protobuf-java to 3.19.4 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26746) Protobuf jar is vulnerable with CVE-2021-22569
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489062#comment-17489062 ] Sean Busbey commented on HBASE-26746: - will need to update hbase-thirdpary to protobuf.version 3.19.2+ > Protobuf jar is vulnerable with CVE-2021-22569 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26746) Protobuf jar is vulnerable with CVE-2021-22569
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-26746: Priority: Minor (was: Major) > Protobuf jar is vulnerable with CVE-2021-22569 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26746) Protobuf jar is vulnerable with CVE-2021-22569
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-26746: Component/s: thirdparty > Protobuf jar is vulnerable with CVE-2021-22569 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Priority: Major > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4100: HBASE-26744 Normalizer exits without normalizing all the tables
Apache-HBase commented on pull request #4100: URL: https://github.com/apache/hbase/pull/4100#issuecomment-1032899979 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 55s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 19m 5s | branch-1 passed | | +1 :green_heart: | compile | 0m 49s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | compile | 0m 59s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | checkstyle | 2m 3s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 50s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javadoc | 0m 48s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +0 :ok: | spotbugs | 3m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 40s | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 0m 51s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javac | 0m 51s | the patch passed | | +1 :green_heart: | compile | 0m 52s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | javac | 0m 52s | the patch passed | | +1 :green_heart: | checkstyle | 1m 53s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 3m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 6m 37s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javadoc | 0m 46s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | findbugs | 3m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 140m 44s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 204m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4100/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4100 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7c82257c5529 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4100/out/precommit/personality/provided.sh | | git revision | branch-1 / bd8a33278e | | Default Java | Azul Systems, Inc.-1.7.0_272-b10 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4100/1/testReport/ | | Max. process+thread count | 4045 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4100/1/console | | versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26746) Protobuf jar is vulnerable with CVE-2021-22569
Pankaj Kumar created HBASE-26746: Summary: Protobuf jar is vulnerable with CVE-2021-22569 Key: HBASE-26746 URL: https://issues.apache.org/jira/browse/HBASE-26746 Project: HBase Issue Type: Bug Components: Protobufs Reporter: Pankaj Kumar Refer, https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26745) MetricsStochasticBalancerSource metrics don't render in /jmx endpoint
[
https://issues.apache.org/jira/browse/HBASE-26745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-26745:
--
Description:
The check in JSONBean
[here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java#L266]
causes the balancer cost metrics to be excluded from the {{/jmx}} endpoint. I
think we should just remove the check for ":". I don't think including metrics
with a colon in them poses any problem, since the strings are quoted. We
removed this check in our cdh5 fork almost a year ago and have not seen any
issues.
Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit
metrics that adhere to these filters, but I think that would be a backwards
incompatible change since this is only a json rendering issue and people might
be consuming JMX directly.
was:
The check in JSONBean
[here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java#L266]
causes the balancer cost metrics to be excluded from the jmx endpoint. I think
we should just remove the check for ":". I don't think including metrics with a
colon in them poses any problem, since the strings are quoted. We removed this
check in our cdh5 fork almost a year ago and have not seen any issues.
Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit
metrics that adhere to these filters, but I think that would be a backwards
incompatible change since this is only a json rendering issue and people might
be consuming JMX directly.
> MetricsStochasticBalancerSource metrics don't render in /jmx endpoint
> -
>
> Key: HBASE-26745
> URL: https://issues.apache.org/jira/browse/HBASE-26745
> Project: HBase
> Issue Type: Bug
>Reporter: Bryan Beaudreault
>Priority: Minor
>
> The check in JSONBean
> [here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java#L266]
> causes the balancer cost metrics to be excluded from the {{/jmx}} endpoint.
> I think we should just remove the check for ":". I don't think including
> metrics with a colon in them poses any problem, since the strings are quoted.
> We removed this check in our cdh5 fork almost a year ago and have not seen
> any issues.
> Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit
> metrics that adhere to these filters, but I think that would be a backwards
> incompatible change since this is only a json rendering issue and people
> might be consuming JMX directly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1032827728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 37s | master passed | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 21s | the patch passed | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 12s | hbase-shell in the patch passed. | | | | 19m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | javac javadoc unit | | uname | Linux 38ada80b8ecc 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 36d8654a97 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/testReport/ | | Max. process+thread count | 1616 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1032827452 non-interactive mode with exception: ``` ➜ hbase-upstream git:(HBASE-26741) ✗ bin/hbase shell -n commands.txt 2022-02-08T17:37:11,367 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable hbase:001:0> scan 'foo' ROW COLUMN+CELL 2022-02-08T17:37:17,679 WARN [RPCClient-NioEventLoopGroup-1-2] client.AsyncNonMetaRegionLocator: Failed to locate region in 'foo', row='', locateType=CURRENT org.apache.hadoop.hbase.TableNotFoundException: foo at org.apache.hadoop.hbase.client.AsyncNonMetaRegionLocator$1.onComplete(AsyncNonMetaRegionLocator.java:503) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.client.AsyncClientScanner.lambda$startScan$1(AsyncClientScanner.java:183) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] [[[ cropped ]]] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242] Took 0.1307 seconds ERROR RuntimeError: Unknown table foo! ➜ hbase-upstream git:(HBASE-26741) ✗ echo $? 1 ``` non-interactive without exceptions and non-zero exit code: ``` ➜ hbase-upstream git:(HBASE-26741) ✗ cat commands-ok.txt scan 'hbase:meta' exit 2 ➜ hbase-upstream git:(HBASE-26741) ✗ bin/hbase shell -n commands-ok.txt 2022-02-08T17:41:08,845 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable hbase:001:0> scan 'hbase:meta' ROWCOLUMN+CELL default column=ns:d, timestamp=2022-02-08T17:34:31.881, value=\x0A\x07default hbase column=ns:d, timestamp=2022-02-08T17:34:31.889, value=\x0A\x05hbase 2 row(s) Took 0.1263 seconds hbase:002:0> exit 2 ➜ hbase-upstream git:(HBASE-26741) ✗ echo $? 2 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1032826443 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 47s | master passed | | +1 :green_heart: | javadoc | 0m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 53s | hbase-shell in the patch passed. | | | | 18m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | javac javadoc unit | | uname | Linux 11130ed67023 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 36d8654a97 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/testReport/ | | Max. process+thread count | 2459 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1032822533 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | the patch passed | | -0 :warning: | rubocop | 0m 4s | The patch generated 39 new + 2 unchanged - 0 fixed = 41 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 10m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | dupname asflicense javac rubocop | | uname | Linux 9e15832dc05d 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 36d8654a97 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/1/console | | versions | git=2.17.1 maven=3.6.3 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1032821315 > what does this behavior look like during the default interactive mode? ``` ➜ hbase-upstream git:(HBASE-26741) ✗ bin/hbase shell 2022-02-08T17:34:52,336 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable HBase Shell Use "help" to get list of supported commands. Use "exit" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/book.html#shell Version 3.0.0-alpha-3-SNAPSHOT, re848d3b9d95e2c0f3c091285f6ecf50bf9330987, Tue Feb 8 17:02:57 CET 2022 Took 0.0013 seconds hbase:001:0> scan 'foo' ROW COLUMN+CELL 2022-02-08T17:35:07,724 WARN [RPCClient-NioEventLoopGroup-1-2] client.AsyncNonMetaRegionLocator: Failed to locate region in 'foo', row='', locateType=CURRENT org.apache.hadoop.hbase.TableNotFoundException: foo at org.apache.hadoop.hbase.client.AsyncNonMetaRegionLocator$1.onComplete(AsyncNonMetaRegionLocator.java:503) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.client.AsyncClientScanner.lambda$startScan$1(AsyncClientScanner.java:183) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) ~[hbase-common-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774) ~[?:1.8.0_242] at java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:792) ~[?:1.8.0_242] at java.util.concurrent.CompletableFuture.whenComplete(CompletableFuture.java:2153) ~[?:1.8.0_242] at org.apache.hadoop.hbase.util.FutureUtils.addListener(FutureUtils.java:61) ~[hbase-common-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.client.AsyncClientScanner.startScan(AsyncClientScanner.java:166) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.client.AsyncClientScanner.lambda$openScanner$2(AsyncClientScanner.java:212) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) ~[hbase-common-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774) ~[?:1.8.0_242] at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750) ~[?:1.8.0_242] at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488) ~[?:1.8.0_242] at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975) ~[?:1.8.0_242] at org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$call$4(AsyncSingleRequestRpcRetryingCaller.java:90) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) ~[hbase-common-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774) ~[?:1.8.0_242] at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750) ~[?:1.8.0_242] at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488) ~[?:1.8.0_242] at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975) ~[?:1.8.0_242] at org.apache.hadoop.hbase.client.AsyncClientScanner.lambda$callOpenScanner$0(AsyncClientScanner.java:157) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.RpcUtil$1.run(RpcUtil.java:79) [hbase-shaded-protobuf-4.0.1.jar:4.0.1] at org.apache.hbase.thirdparty.com.google.protobuf.RpcUtil$1.run(RpcUtil.java:70) [hbase-shaded-protobuf-4.0.1.jar:4.0.1] at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:395) [hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:96) [hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:428) [hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:423) [hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:119)
[GitHub] [hbase] petersomogyi commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1032818889 > where's the specific line this is copied from? we'll need to attribute and update LICENSE info. Copied this method with a single line change: https://github.com/jruby/jruby/blob/9.2.13.0/lib/ruby/stdlib/irb.rb#L440-L537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
busbey commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1032816110 what does this behavior look like during the default interactive mode? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
busbey commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1032815321 where's the specific line this is copied from? we'll need to attribute and update LICENSE info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26745) MetricsStochasticBalancerSource metrics don't render in /jmx endpoint
Bryan Beaudreault created HBASE-26745: - Summary: MetricsStochasticBalancerSource metrics don't render in /jmx endpoint Key: HBASE-26745 URL: https://issues.apache.org/jira/browse/HBASE-26745 Project: HBase Issue Type: Bug Reporter: Bryan Beaudreault The check in JSONBean [here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java#L266] causes the balancer cost metrics to be excluded from the jmx endpoint. I think we should just remove the check for ":". I don't think including metrics with a colon in them poses any problem, since the strings are quoted. We removed this check in our cdh5 fork almost a year ago and have not seen any issues. Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit metrics that adhere to these filters, but I think that would be a backwards incompatible change since this is only a json rendering issue and people might be consuming JMX directly. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (HBASE-26741) Incorrect exception handling in shell
[
https://issues.apache.org/jira/browse/HBASE-26741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi reassigned HBASE-26741:
-
Assignee: Peter Somogyi
> Incorrect exception handling in shell
> -
>
> Key: HBASE-26741
> URL: https://issues.apache.org/jira/browse/HBASE-26741
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.4.10
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
>
> The exception handling changed in the shell compared to 2.2.
> {noformat}
> ➜ hbase-upstream git:(branch-2.4) ✗ cat commands.txt
> scan 'foo'
> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ bin/hbase shell -n commands.txt
> 2022-02-07 16:21:33,654 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> hbase:001:0> scan 'foo'
> ROW COLUMN+CELL
> Took 0.3890 seconds
> Traceback (most
> recent call last):
> RuntimeError (Unknown table foo!)
> hbase:002:0> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ echo $?
> 0 {noformat}
> The execution continues even after an exception is thrown. In 2.2.7 the
> execution stops when an exception is thrown and the shell exits with error
> code.
> {noformat}
> ➜ hbase-2.2.7 bin/hbase shell -n commands.txt
> 2022-02-07 16:33:54,930 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> ROW COLUMN+CELL
> Took 0.3082 seconds
> RuntimeError:
> Unknown table foo!
> translate_hbase_exceptions at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:130
> command_safe at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:49
> internal_command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:148
> command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:140
> scan at (eval):2
> at commands.txt:1
> load at org/jruby/RubyKernel.java:973
> at
> /Users/petersomogyi/tmp/hbase-2.2.7/bin/../bin/hirb.rb:186
> ➜ hbase-2.2.7 echo $?
> 1 {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] petersomogyi opened a new pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi opened a new pull request #4101: URL: https://github.com/apache/hbase/pull/4101 Override eval_input in HIRB to modify exception handling logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-26741) Incorrect exception handling in shell
[
https://issues.apache.org/jira/browse/HBASE-26741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488929#comment-17488929
]
Peter Somogyi edited comment on HBASE-26741 at 2/8/22, 3:10 PM:
The problem is in Irb::eval_input method. This method has its own exception
handling logic so the thrown exceptions are caught there and not in the
Shell:exception_handler method. This behavior change was introduced by
stitching to IRB.run from @shell.eval_io in HBASE-26469.
One solution I managed to find is to override the Irb::eval_input method in
HIRB and in {{rescue Exception}} call {{{}raise{}}}. This throws the exception
and HBase's custom exception handling logic could be invoked.
was (Author: psomogyi):
The problem is in Irb::eval_input method. This method has its own exception
handling logic so the thrown exceptions are caught there and not in the
Shell:exception_handler method. This behavior change was introduced by
stitching to IRB.run from @shell.eval_io in HBASE-26469.
One solution I managed to find is to override the Irb::eval_input method in
HIRB and in {{rescue Exception}} call \{{raise}. This throws the exception and
HBase's custom exception handling logic could be invoked.
> Incorrect exception handling in shell
> -
>
> Key: HBASE-26741
> URL: https://issues.apache.org/jira/browse/HBASE-26741
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.4.10
>Reporter: Peter Somogyi
>Priority: Critical
>
> The exception handling changed in the shell compared to 2.2.
> {noformat}
> ➜ hbase-upstream git:(branch-2.4) ✗ cat commands.txt
> scan 'foo'
> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ bin/hbase shell -n commands.txt
> 2022-02-07 16:21:33,654 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> hbase:001:0> scan 'foo'
> ROW COLUMN+CELL
> Took 0.3890 seconds
> Traceback (most
> recent call last):
> RuntimeError (Unknown table foo!)
> hbase:002:0> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ echo $?
> 0 {noformat}
> The execution continues even after an exception is thrown. In 2.2.7 the
> execution stops when an exception is thrown and the shell exits with error
> code.
> {noformat}
> ➜ hbase-2.2.7 bin/hbase shell -n commands.txt
> 2022-02-07 16:33:54,930 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> ROW COLUMN+CELL
> Took 0.3082 seconds
> RuntimeError:
> Unknown table foo!
> translate_hbase_exceptions at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:130
> command_safe at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:49
> internal_command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:148
> command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:140
> scan at (eval):2
> at commands.txt:1
> load at org/jruby/RubyKernel.java:973
> at
> /Users/petersomogyi/tmp/hbase-2.2.7/bin/../bin/hirb.rb:186
> ➜ hbase-2.2.7 echo $?
> 1 {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26741) Incorrect exception handling in shell
[
https://issues.apache.org/jira/browse/HBASE-26741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488929#comment-17488929
]
Peter Somogyi commented on HBASE-26741:
---
The problem is in Irb::eval_input method. This method has its own exception
handling logic so the thrown exceptions are caught there and not in the
Shell:exception_handler method. This behavior change was introduced by
stitching to IRB.run from @shell.eval_io in HBASE-26469.
One solution I managed to find is to override the Irb::eval_input method in
HIRB and in {{rescue Exception}} call \{{raise}. This throws the exception and
HBase's custom exception handling logic could be invoked.
> Incorrect exception handling in shell
> -
>
> Key: HBASE-26741
> URL: https://issues.apache.org/jira/browse/HBASE-26741
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.4.10
>Reporter: Peter Somogyi
>Priority: Critical
>
> The exception handling changed in the shell compared to 2.2.
> {noformat}
> ➜ hbase-upstream git:(branch-2.4) ✗ cat commands.txt
> scan 'foo'
> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ bin/hbase shell -n commands.txt
> 2022-02-07 16:21:33,654 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> hbase:001:0> scan 'foo'
> ROW COLUMN+CELL
> Took 0.3890 seconds
> Traceback (most
> recent call last):
> RuntimeError (Unknown table foo!)
> hbase:002:0> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ echo $?
> 0 {noformat}
> The execution continues even after an exception is thrown. In 2.2.7 the
> execution stops when an exception is thrown and the shell exits with error
> code.
> {noformat}
> ➜ hbase-2.2.7 bin/hbase shell -n commands.txt
> 2022-02-07 16:33:54,930 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> ROW COLUMN+CELL
> Took 0.3082 seconds
> RuntimeError:
> Unknown table foo!
> translate_hbase_exceptions at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:130
> command_safe at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:49
> internal_command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:148
> command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:140
> scan at (eval):2
> at commands.txt:1
> load at org/jruby/RubyKernel.java:973
> at
> /Users/petersomogyi/tmp/hbase-2.2.7/bin/../bin/hirb.rb:186
> ➜ hbase-2.2.7 echo $?
> 1 {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4024: HBASE-26521 Name RPC spans as `$package.$service/$method`
Apache-HBase commented on pull request #4024: URL: https://github.com/apache/hbase/pull/4024#issuecomment-1032703380 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 20s | master passed | | +1 :green_heart: | compile | 9m 27s | master passed | | +1 :green_heart: | checkstyle | 2m 19s | master passed | | +1 :green_heart: | spotbugs | 15m 28s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 16s | the patch passed | | +1 :green_heart: | compile | 9m 26s | the patch passed | | +1 :green_heart: | javac | 9m 26s | the patch passed | | +1 :green_heart: | checkstyle | 2m 20s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 22m 56s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 18m 2s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. | | | | 102m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4024 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 2f033cef5fa0 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 36d8654a97 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 126 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4024/6/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26744) Normalizer exits without normalizing all the tables
Aman Poonia created HBASE-26744:
---
Summary: Normalizer exits without normalizing all the tables
Key: HBASE-26744
URL: https://issues.apache.org/jira/browse/HBASE-26744
Project: HBase
Issue Type: Bug
Components: Normalizer
Affects Versions: 1.7.1
Reporter: Aman Poonia
Assignee: Aman Poonia
Currently if there are multiple tables to normalize, normalizer is exiting even
before iterating all the table if there is a table that doesnot require
normalization
here is the offending code
[https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1736]
{code:java}
List plans = this.normalizer.computePlansForTable(table);
if (plans == null || plans.isEmpty()) {
return true;
} {code}
this is running inside loop over tables
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26624) [hbase-operator-tools] Introduce a HBCK2 tool to fix the store file tracking
[ https://issues.apache.org/jira/browse/HBASE-26624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488817#comment-17488817 ] Duo Zhang commented on HBASE-26624: --- I think this should be part of HBCK2. It is for fixing corrupted data, not for normal operations like RegionMover. For me, I think regenerating the tracker files for a region or a table is enough? But I'm also fine with rebuild the whole cluster. Thanks. > [hbase-operator-tools] Introduce a HBCK2 tool to fix the store file tracking > > > Key: HBASE-26624 > URL: https://issues.apache.org/jira/browse/HBASE-26624 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 >Reporter: Duo Zhang >Assignee: Szabolcs Bukros >Priority: Major > > We should provide a HBCK2 tool to recover the store file tracking if it is > broken. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26697) Migrate HBase Nightly HBase-Flaky-Tests and HBase-Find-Flaky-Tests to ci-hbase
[ https://issues.apache.org/jira/browse/HBASE-26697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488814#comment-17488814 ] Duo Zhang commented on HBASE-26697: --- Gavin said the ssh transfer plugin is ready. Will reapply the PR here and try again. > Migrate HBase Nightly HBase-Flaky-Tests and HBase-Find-Flaky-Tests to ci-hbase > -- > > Key: HBASE-26697 > URL: https://issues.apache.org/jira/browse/HBASE-26697 > Project: HBase > Issue Type: Sub-task > Components: jenkins >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > They are tied together so let's do them at once. > We also need to modify the url for our pre commit job. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26741) Incorrect exception handling in shell
[
https://issues.apache.org/jira/browse/HBASE-26741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488807#comment-17488807
]
Peter Somogyi commented on HBASE-26741:
---
The thrown exception is not caught in the
[exception_handler|https://github.com/apache/hbase/blob/branch-2.4/hbase-shell/src/main/ruby/shell.rb#L329-L351]
method when the commands are called via
[IRB::HBaseLoader.file_for_load(script2run)).run|#L212]]. I think that is the
expected behavior of the run command and I'm not able to find any option to
force the exception to be thrown.
[~busbey], [~mdrob]: Do you have any idea how this could be solved?
> Incorrect exception handling in shell
> -
>
> Key: HBASE-26741
> URL: https://issues.apache.org/jira/browse/HBASE-26741
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.4.10
>Reporter: Peter Somogyi
>Priority: Critical
>
> The exception handling changed in the shell compared to 2.2.
> {noformat}
> ➜ hbase-upstream git:(branch-2.4) ✗ cat commands.txt
> scan 'foo'
> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ bin/hbase shell -n commands.txt
> 2022-02-07 16:21:33,654 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> hbase:001:0> scan 'foo'
> ROW COLUMN+CELL
> Took 0.3890 seconds
> Traceback (most
> recent call last):
> RuntimeError (Unknown table foo!)
> hbase:002:0> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ echo $?
> 0 {noformat}
> The execution continues even after an exception is thrown. In 2.2.7 the
> execution stops when an exception is thrown and the shell exits with error
> code.
> {noformat}
> ➜ hbase-2.2.7 bin/hbase shell -n commands.txt
> 2022-02-07 16:33:54,930 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> ROW COLUMN+CELL
> Took 0.3082 seconds
> RuntimeError:
> Unknown table foo!
> translate_hbase_exceptions at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:130
> command_safe at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:49
> internal_command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:148
> command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:140
> scan at (eval):2
> at commands.txt:1
> load at org/jruby/RubyKernel.java:973
> at
> /Users/petersomogyi/tmp/hbase-2.2.7/bin/../bin/hirb.rb:186
> ➜ hbase-2.2.7 echo $?
> 1 {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26706) The replication batch size is too large and cannot be written to the standby cluster
[ https://issues.apache.org/jira/browse/HBASE-26706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488800#comment-17488800 ] ShuangQi Xia commented on HBASE-26706: -- I think this is diffrent from replication.source.size.capacity , the replication.source.size.capacity parameter controls all table's size ,but this issue need table's control > The replication batch size is too large and cannot be written to the standby > cluster > > > Key: HBASE-26706 > URL: https://issues.apache.org/jira/browse/HBASE-26706 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.3.1, 2.2.3 >Reporter: ShuangQi Xia >Assignee: ShuangQi Xia >Priority: Major > Attachments: image-2022-01-25-19-59-39-118.png > > > Recently, we met a replication failure and it cannot be recovered. The main > reason is that the number of data records read from the wal during > synchronization is not limited. In addition, the batch size is not limited > when data is written to the peer cluster. As a result, the replication will > be failed because of writing timeout. It is recommended that the number of > records to be written with a controllable range, for example, 2000 records, > and can be modified through configuration. > Here are some log stacks > !image-2022-01-25-19-59-39-118.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26699) hbase regionserver keep on restarting in azure setup
[ https://issues.apache.org/jira/browse/HBASE-26699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Mandal updated HBASE-26699: --- Attachment: (was: trace_master.txt) > hbase regionserver keep on restarting in azure setup > > > Key: HBASE-26699 > URL: https://issues.apache.org/jira/browse/HBASE-26699 > Project: HBase > Issue Type: Bug > Environment: Azure cloud >Reporter: Kaushik Mandal >Priority: Major > Fix For: 2.4.8 > > > hadoop hbase version 2.4.8 > hadoop hdfs version 2.7.7 > > Hbase master and regionserver keep on restarting due to > procedure.SplitWALProcedure: Failed to split wa > > logs from master and regionserver attached -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26699) hbase regionserver keep on restarting in azure setup
[ https://issues.apache.org/jira/browse/HBASE-26699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Mandal updated HBASE-26699: --- Attachment: (was: trace_region.txt) > hbase regionserver keep on restarting in azure setup > > > Key: HBASE-26699 > URL: https://issues.apache.org/jira/browse/HBASE-26699 > Project: HBase > Issue Type: Bug > Environment: Azure cloud >Reporter: Kaushik Mandal >Priority: Major > Fix For: 2.4.8 > > > hadoop hbase version 2.4.8 > hadoop hdfs version 2.7.7 > > Hbase master and regionserver keep on restarting due to > procedure.SplitWALProcedure: Failed to split wa > > logs from master and regionserver attached -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #4066: HBASE-26707: Reduce number of renames during bulkload
BukrosSzabolcs commented on a change in pull request #4066:
URL: https://github.com/apache/hbase/pull/4066#discussion_r801400439
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java
##
@@ -390,11 +400,16 @@ public String prepareBulkLoad(final byte[] family, final
String srcPath, boolean
LOG.debug("Moving " + p + " to " + stageP);
FileStatus origFileStatus = fs.getFileStatus(p);
origPermissions.put(srcPath, origFileStatus.getPermission());
+origlSources.put(stageP.toString(), srcPath);
Review comment:
I do not think concurrency is an issue. `SecureBulkLoadListener` keeps
track of the moved files and a separate listener is created for each region in
each bulkLoad. So even with parallel bulkLoads they can not touch each other's
files. Using the same source folder can be an issue but it always was an issue.
I'm not sure I understand your comment about "always pass a custom staging
dir". The staging dir by default is different for each bulkLoad process. I
break this by introducing the "custom staging dir" which always points to the
live data folder as a workaround to skip moving hfiles to an actual staging dir
without loosing the existing error handling. We can't change it and decrease
the number of moves at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-26741) Incorrect exception handling in shell
[
https://issues.apache.org/jira/browse/HBASE-26741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-26741:
--
Priority: Critical (was: Major)
> Incorrect exception handling in shell
> -
>
> Key: HBASE-26741
> URL: https://issues.apache.org/jira/browse/HBASE-26741
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.4.10
>Reporter: Peter Somogyi
>Priority: Critical
>
> The exception handling changed in the shell compared to 2.2.
> {noformat}
> ➜ hbase-upstream git:(branch-2.4) ✗ cat commands.txt
> scan 'foo'
> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ bin/hbase shell -n commands.txt
> 2022-02-07 16:21:33,654 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> hbase:001:0> scan 'foo'
> ROW COLUMN+CELL
> Took 0.3890 seconds
> Traceback (most
> recent call last):
> RuntimeError (Unknown table foo!)
> hbase:002:0> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ echo $?
> 0 {noformat}
> The execution continues even after an exception is thrown. In 2.2.7 the
> execution stops when an exception is thrown and the shell exits with error
> code.
> {noformat}
> ➜ hbase-2.2.7 bin/hbase shell -n commands.txt
> 2022-02-07 16:33:54,930 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> ROW COLUMN+CELL
> Took 0.3082 seconds
> RuntimeError:
> Unknown table foo!
> translate_hbase_exceptions at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:130
> command_safe at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:49
> internal_command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:148
> command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:140
> scan at (eval):2
> at commands.txt:1
> load at org/jruby/RubyKernel.java:973
> at
> /Users/petersomogyi/tmp/hbase-2.2.7/bin/../bin/hirb.rb:186
> ➜ hbase-2.2.7 echo $?
> 1 {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
