[GitHub] [hbase] Apache-HBase commented on pull request #4147: HBASE-26783 ScannerCallable doubly clears meta cache on retries
Apache-HBase commented on pull request #4147: URL: https://github.com/apache/hbase/pull/4147#issuecomment-1057670866 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 30s | branch-2 passed | | +1 :green_heart: | compile | 2m 27s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 54s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 55s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 2m 29s | the patch passed | | -0 :warning: | javac | 1m 53s | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) | | -0 :warning: | checkstyle | 0m 16s | hbase-client: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2) | | -0 :warning: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 7m 32s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 29m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4147 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0f65515e73f4 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d020cba795 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | whitespace | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/3/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 60 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23303) Add security headers to REST server/info page
[
https://issues.apache.org/jira/browse/HBASE-23303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500499#comment-17500499
]
Hudson commented on HBASE-23303:
Results for branch branch-2.4
[build #297 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add security headers to REST server/info page
> -
>
> Key: HBASE-23303
> URL: https://issues.apache.org/jira/browse/HBASE-23303
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 3.0.0-alpha-1, 2.0.6, 2.1.7, 2.2.2
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.3, 2.1.9
>
>
> Vulnerability scanners suggest that the following extra headers should be
> added to both Info/Rest server endpoints which are exposed by {{hbase-rest}}
> project.
> * X-Frame-Options: SAMEORIGIN
> * X-Xss-Protection: 1; mode=block
> * X-Content-Type-Options: nosniff
> * Strict-Transport-Security: “max-age=63072000;includeSubDomains;preload”
> * Content-Security-Policy: default-src https: data: 'unsafe-inline'
> 'unsafe-eval'
> Info server already has "X-Frame-Options: DENY" which is more restrictive
> than "SAMEORIGIN", so it's probably fine. All of three headers are missing
> from REST responses.
> I'll put together a patch to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26776) RpcServer failure to SASL handshake always logs user "unknown" to audit log
[
https://issues.apache.org/jira/browse/HBASE-26776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500500#comment-17500500
]
Hudson commented on HBASE-26776:
Results for branch branch-2.4
[build #297 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/297/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RpcServer failure to SASL handshake always logs user "unknown" to audit log
> ---
>
> Key: HBASE-26776
> URL: https://issues.apache.org/jira/browse/HBASE-26776
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> Over on HBASE-26622, we noticed that the "attempting user" is always returned
> as "Unknown". This information is sent to the audit log when constructing the
> {{HBaseSaslRpcServer}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26762) Scan#setRowPrefixFilter incorrectly marked as deprecated
[
https://issues.apache.org/jira/browse/HBASE-26762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500495#comment-17500495
]
Hudson commented on HBASE-26762:
Results for branch branch-2
[build #472 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Scan#setRowPrefixFilter incorrectly marked as deprecated
>
>
> Key: HBASE-26762
> URL: https://issues.apache.org/jira/browse/HBASE-26762
> Project: HBase
> Issue Type: Bug
> Components: Client, scan
>Affects Versions: 3.0.0-alpha-2
>Reporter: Niels Basjes
>Assignee: Niels Basjes
>Priority: Major
>
> Issue HBASE-25299 is about the Scan#setRowPrefixFilter having not the
> expected effects when using also the setStartRow and/or setStopRow.
> The setRowPrefixFilter is intended to make setting the right startRow and
> stopRow for prefix scans. So it was always intended of using it *instead* of
> doing separate setStartRow and/or setStopRow calls.
> The reason for adding this to the Scan (~ 8 years ago, HBASE-11990 ) was that
> calculating the correct start and stop row for doing the very efficient
> prefix scan is very very hard to do right in the generic case.
> This is still a current usecase and many of my applications rely on this
> function (I even prefer the HBase Client when connecting to Google BigTable
> for this method).
> With issue HBASE-25299 it has now been marked as deprecated.
> Quote from the changes made in HBASE-25299:
> {code}
> @deprecated since 3.0.0. The scan result might be unexpected in some cases.
> {code}
> Yes, if you use this very valuable method incorrectly it will yield incorrect
> results.
> I do not consider this a valid reason to deprecate it.
> So I do agree with the confusion of the effects as described in HBASE-25299
> which should be fixed with additional documentation.
> I disagree with the deprecation of this method.
>
> I'll put up a pull request in which I improve the documentation and remove
> the deprecation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-23303) Add security headers to REST server/info page
[
https://issues.apache.org/jira/browse/HBASE-23303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500493#comment-17500493
]
Hudson commented on HBASE-23303:
Results for branch branch-2
[build #472 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add security headers to REST server/info page
> -
>
> Key: HBASE-23303
> URL: https://issues.apache.org/jira/browse/HBASE-23303
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 3.0.0-alpha-1, 2.0.6, 2.1.7, 2.2.2
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.3, 2.1.9
>
>
> Vulnerability scanners suggest that the following extra headers should be
> added to both Info/Rest server endpoints which are exposed by {{hbase-rest}}
> project.
> * X-Frame-Options: SAMEORIGIN
> * X-Xss-Protection: 1; mode=block
> * X-Content-Type-Options: nosniff
> * Strict-Transport-Security: “max-age=63072000;includeSubDomains;preload”
> * Content-Security-Policy: default-src https: data: 'unsafe-inline'
> 'unsafe-eval'
> Info server already has "X-Frame-Options: DENY" which is more restrictive
> than "SAMEORIGIN", so it's probably fine. All of three headers are missing
> from REST responses.
> I'll put together a patch to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26776) RpcServer failure to SASL handshake always logs user "unknown" to audit log
[
https://issues.apache.org/jira/browse/HBASE-26776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500494#comment-17500494
]
Hudson commented on HBASE-26776:
Results for branch branch-2
[build #472 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RpcServer failure to SASL handshake always logs user "unknown" to audit log
> ---
>
> Key: HBASE-26776
> URL: https://issues.apache.org/jira/browse/HBASE-26776
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> Over on HBASE-26622, we noticed that the "attempting user" is always returned
> as "Unknown". This information is sent to the audit log when constructing the
> {{HBaseSaslRpcServer}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4147: HBASE-26783 ScannerCallable doubly clears meta cache on retries
Apache-HBase commented on pull request #4147: URL: https://github.com/apache/hbase/pull/4147#issuecomment-1057658558 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 29s | branch-2 passed | | +1 :green_heart: | compile | 0m 48s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 15s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 3m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 3s | hbase-client in the patch passed. | | -1 :x: | unit | 329m 50s | hbase-server in the patch failed. | | | | 349m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4147 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 160b78666f15 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5f63550b7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/testReport/ | | Max. process+thread count | 2621 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4147: HBASE-26783 ScannerCallable doubly clears meta cache on retries
Apache-HBase commented on pull request #4147: URL: https://github.com/apache/hbase/pull/4147#issuecomment-1057655975 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 24s | branch-2 passed | | +1 :green_heart: | compile | 1m 19s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 57s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 3m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 35s | hbase-client in the patch passed. | | -1 :x: | unit | 316m 23s | hbase-server in the patch failed. | | | | 344m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4147 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f36b1b0a4540 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5f63550b7 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/testReport/ | | Max. process+thread count | 2348 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26787) TestRegionReplicaReplicationError should inject error in replicateToReplica method
[
https://issues.apache.org/jira/browse/HBASE-26787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500485#comment-17500485
]
chenglei commented on HBASE-26787:
--
Pushed to master, thanks [~zhangduo] for review
> TestRegionReplicaReplicationError should inject error in replicateToReplica
> method
> --
>
> Key: HBASE-26787
> URL: https://issues.apache.org/jira/browse/HBASE-26787
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0-alpha-2
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
>
> {{TestRegionReplicaReplicationError}} added by HBASE-26233 now injects error
> in {{RSRpcServices.replay}}, but {{RSRpcServices.replay}} in fact is not
> invoked, seems we should inject error in {{RSRpcServices.replicateToReplica}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26787) TestRegionReplicaReplicationError should inject error in replicateToReplica method
[
https://issues.apache.org/jira/browse/HBASE-26787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated HBASE-26787:
-
Fix Version/s: 3.0.0-alpha-3
Resolution: Fixed
Status: Resolved (was: Patch Available)
> TestRegionReplicaReplicationError should inject error in replicateToReplica
> method
> --
>
> Key: HBASE-26787
> URL: https://issues.apache.org/jira/browse/HBASE-26787
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0-alpha-2
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> {{TestRegionReplicaReplicationError}} added by HBASE-26233 now injects error
> in {{RSRpcServices.replay}}, but {{RSRpcServices.replay}} in fact is not
> invoked, seems we should inject error in {{RSRpcServices.replicateToReplica}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (HBASE-26787) TestRegionReplicaReplicationError should inject error in replicateToReplica method
[
https://issues.apache.org/jira/browse/HBASE-26787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei reassigned HBASE-26787:
Assignee: chenglei
> TestRegionReplicaReplicationError should inject error in replicateToReplica
> method
> --
>
> Key: HBASE-26787
> URL: https://issues.apache.org/jira/browse/HBASE-26787
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0-alpha-2
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
>
> {{TestRegionReplicaReplicationError}} added by HBASE-26233 now injects error
> in {{RSRpcServices.replay}}, but {{RSRpcServices.replay}} in fact is not
> invoked, seems we should inject error in {{RSRpcServices.replicateToReplica}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] comnetwork merged pull request #4148: HBASE-26787 TestRegionReplicaReplicationError should inject error in …
comnetwork merged pull request #4148: URL: https://github.com/apache/hbase/pull/4148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4153: HBASE-26792 Implement ScanInfo#toString
Apache-HBase commented on pull request #4153: URL: https://github.com/apache/hbase/pull/4153#issuecomment-1057635217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 58s | master passed | | +1 :green_heart: | compile | 0m 54s | master passed | | +1 :green_heart: | shadedjars | 4m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 23s | the patch passed | | +1 :green_heart: | compile | 0m 34s | the patch passed | | +1 :green_heart: | javac | 0m 34s | the patch passed | | +1 :green_heart: | shadedjars | 4m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 330m 14s | hbase-server in the patch failed. | | | | 350m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4153 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8778f4040edb 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 06f06cbd86 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/testReport/ | | Max. process+thread count | 1589 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4154: HBASE-26792 Implement ScanInfo#toString
Apache-HBase commented on pull request #4154: URL: https://github.com/apache/hbase/pull/4154#issuecomment-1057634397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 7s | branch-2 passed | | +1 :green_heart: | compile | 0m 45s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 0m 43s | the patch passed | | +1 :green_heart: | javac | 0m 43s | the patch passed | | +1 :green_heart: | shadedjars | 3m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 331m 6s | hbase-server in the patch passed. | | | | 348m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4154/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4154 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d90bcf7af6df 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5f63550b7 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4154/1/testReport/ | | Max. process+thread count | 2052 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4154/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4154: HBASE-26792 Implement ScanInfo#toString
Apache-HBase commented on pull request #4154: URL: https://github.com/apache/hbase/pull/4154#issuecomment-1057633760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 40s | branch-2 passed | | +1 :green_heart: | compile | 0m 33s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 0m 32s | the patch passed | | +1 :green_heart: | javac | 0m 32s | the patch passed | | +1 :green_heart: | shadedjars | 3m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 331m 29s | hbase-server in the patch passed. | | | | 347m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4154/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4154 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ccfb0b052955 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5f63550b7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4154/1/testReport/ | | Max. process+thread count | 2332 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4154/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4153: HBASE-26792 Implement ScanInfo#toString
Apache-HBase commented on pull request #4153: URL: https://github.com/apache/hbase/pull/4153#issuecomment-1057629644 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 8s | master passed | | +1 :green_heart: | compile | 0m 42s | master passed | | +1 :green_heart: | shadedjars | 3m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 0m 42s | the patch passed | | +1 :green_heart: | javac | 0m 42s | the patch passed | | +1 :green_heart: | shadedjars | 3m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 316m 21s | hbase-server in the patch failed. | | | | 334m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4153 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 80caf7e54fb7 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 06f06cbd86 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/testReport/ | | Max. process+thread count | 1652 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client
Apache-HBase commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1057626824 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 45s | master passed | | +1 :green_heart: | compile | 2m 17s | master passed | | +1 :green_heart: | shadedjars | 4m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 11s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 0s | the patch passed | | +1 :green_heart: | compile | 2m 3s | the patch passed | | +1 :green_heart: | javac | 2m 3s | the patch passed | | +1 :green_heart: | shadedjars | 4m 23s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 42s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 502m 47s | root in the patch failed. | | | | 530m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4125/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4125 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2c12ec54dd99 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 06f06cbd86 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4125/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4125/8/testReport/ | | Max. process+thread count | 1682 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4125/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4118: HBASE-26582 Prune use of Random and SecureRandom objects
Apache-HBase commented on pull request #4118: URL: https://github.com/apache/hbase/pull/4118#issuecomment-1057619932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 41s | master passed | | +1 :green_heart: | compile | 7m 2s | master passed | | +1 :green_heart: | checkstyle | 2m 39s | master passed | | +1 :green_heart: | spotbugs | 6m 0s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 22s | the patch passed | | -1 :x: | compile | 0m 24s | hbase-it in the patch failed. | | -0 :warning: | javac | 0m 17s | hbase-asyncfs generated 1 new + 25 unchanged - 1 fixed = 26 total (was 26) | | -0 :warning: | javac | 2m 10s | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) | | -0 :warning: | javac | 0m 24s | hbase-it in the patch failed. | | -0 :warning: | checkstyle | 0m 13s | hbase-common: The patch generated 3 new + 135 unchanged - 0 fixed = 138 total (was 135) | | +1 :green_heart: | checkstyle | 0m 5s | The patch passed checkstyle in hbase-metrics | | +1 :green_heart: | checkstyle | 0m 7s | The patch passed checkstyle in hbase-hadoop-compat | | +1 :green_heart: | checkstyle | 0m 14s | hbase-client: The patch generated 0 new + 14 unchanged - 4 fixed = 14 total (was 18) | | +1 :green_heart: | checkstyle | 0m 7s | The patch passed checkstyle in hbase-zookeeper | | +1 :green_heart: | checkstyle | 0m 6s | The patch passed checkstyle in hbase-replication | | +1 :green_heart: | checkstyle | 0m 8s | The patch passed checkstyle in hbase-balancer | | +1 :green_heart: | checkstyle | 0m 7s | The patch passed checkstyle in hbase-http | | +1 :green_heart: | checkstyle | 0m 6s | The patch passed checkstyle in hbase-asyncfs | | +1 :green_heart: | checkstyle | 0m 7s | The patch passed checkstyle in hbase-procedure | | -0 :warning: | checkstyle | 0m 37s | hbase-server: The patch generated 7 new + 389 unchanged - 18 fixed = 396 total (was 407) | | +1 :green_heart: | checkstyle | 0m 10s | hbase-mapreduce: The patch generated 0 new + 85 unchanged - 1 fixed = 85 total (was 86) | | -0 :warning: | checkstyle | 0m 9s | hbase-testing-util: The patch generated 1 new + 142 unchanged - 0 fixed = 143 total (was 142) | | -0 :warning: | checkstyle | 0m 10s | hbase-it: The patch generated 3 new + 186 unchanged - 2 fixed = 189 total (was 188) | | +1 :green_heart: | checkstyle | 0m 8s | The patch passed checkstyle in hbase-rest | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 57s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 7m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 40s | The patch does not generate ASF License warnings. | | | | 60m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4118/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4118 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux bdc5ccb46a88 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b81ddd83bc | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4118/2/artifact/yetus-general-check/output/patch-compile-hbase-it.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4118/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-asyncfs.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4118/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt | | javac |
[GitHub] [hbase] Apache9 commented on pull request #4050: HBASE-26691 Replacing log4j with reload4j for branch-2.x
Apache9 commented on pull request #4050: URL: https://github.com/apache/hbase/pull/4050#issuecomment-1057619529 > how about we get this in place for branches-2 now, so that we can stop shipping hbase 2 releases with an EOL log4j 1, but we plan for the log4j 2 changes to be the preferred path for whatever the next minor 2.x release is after the backport lands. (presuming the testing goes well.) Fine by me~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #4050: HBASE-26691 Replacing log4j with reload4j for branch-2.x
busbey commented on pull request #4050: URL: https://github.com/apache/hbase/pull/4050#issuecomment-1057614226 how about we get this in place for branches-2 now, so that we can stop shipping hbase 2 releases with an EOL log4j 1, but we plan for the log4j 2 changes to be the preferred path for whatever the next minor 2.x release is after the backport lands. (presuming the testing goes well.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4050: HBASE-26691 Replacing log4j with reload4j for branch-2.x
Apache9 commented on pull request #4050: URL: https://github.com/apache/hbase/pull/4050#issuecomment-1057589064 So do we plan to use reload4j for 2.x, or we plan to directly upgrade to log4j2? I plan to backport the log4j2 changes to branch-2 and try to see if using the old log4j.properties is fine with log4j-1.2-api in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4152: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2.4
Apache-HBase commented on pull request #4152: URL: https://github.com/apache/hbase/pull/4152#issuecomment-1057579323 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 23s | branch-2.4 passed | | +1 :green_heart: | compile | 1m 25s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 3m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 54s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 6s | the patch passed | | +1 :green_heart: | compile | 1m 24s | the patch passed | | +1 :green_heart: | javac | 1m 24s | the patch passed | | +1 :green_heart: | shadedjars | 3m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 506m 39s | root in the patch passed. | | | | 530m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4152 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f88277d9abd6 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / 36e1a1d260 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/testReport/ | | Max. process+thread count | 2286 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4155: HBASE-26792 Implement ScanInfo#toString
Apache-HBase commented on pull request #4155: URL: https://github.com/apache/hbase/pull/4155#issuecomment-1057578790 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m 53s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 18s | branch-1 passed | | +1 :green_heart: | compile | 0m 30s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | compile | 0m 33s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | checkstyle | 1m 1s | branch-1 passed | | +1 :green_heart: | shadedjars | 1m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javadoc | 0m 32s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +0 :ok: | spotbugs | 1m 56s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 1m 53s | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 25s | the patch passed | | +1 :green_heart: | compile | 0m 33s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javac | 0m 33s | the patch passed | | +1 :green_heart: | compile | 0m 34s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | javac | 0m 34s | the patch passed | | +1 :green_heart: | checkstyle | 1m 1s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 3m 15s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javadoc | 0m 30s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | findbugs | 2m 19s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 166m 15s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 201m 40s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles | | | hadoop.hbase.namequeues.TestSlowLogAccessor | | | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles | | | hadoop.hbase.regionserver.TestRegionProcessRowsWithLocks | | | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4155/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4155 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 656c090d72a8 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4155/out/precommit/personality/provided.sh | | git revision | branch-1 / 5b26932415 | | Default Java | Azul Systems, Inc.-1.7.0_272-b10 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4155/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4155/1/testReport/ | | Max. process+thread count | 4010 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output |
[jira] [Updated] (HBASE-26745) MetricsStochasticBalancerSource metrics don't render in /jmx endpoint
[
https://issues.apache.org/jira/browse/HBASE-26745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-26745:
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
Pushed to branch-2.4 and up. Thank you for the patch [~baugenreich]!
> MetricsStochasticBalancerSource metrics don't render in /jmx endpoint
> -
>
> Key: HBASE-26745
> URL: https://issues.apache.org/jira/browse/HBASE-26745
> Project: HBase
> Issue Type: Bug
>Reporter: Bryan Beaudreault
>Assignee: Briana Augenreich
>Priority: Minor
> Labels: patch-available
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> The check in JSONBean
> [here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java#L266]
> causes the balancer cost metrics to be excluded from the {{/jmx}} endpoint.
> I think we should just remove the check for ":". I don't think including
> metrics with a colon in them poses any problem, since the strings are quoted.
> We removed this check in our cdh5 fork almost a year ago and have not seen
> any issues.
> Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit
> metrics that adhere to these filters, but I think that would be a backwards
> incompatible change since this is only a json rendering issue and people
> might be consuming JMX directly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] apurtell commented on pull request #4050: HBASE-26691 Replacing log4j with reload4j for branch-2.x
apurtell commented on pull request #4050: URL: https://github.com/apache/hbase/pull/4050#issuecomment-1057577852 If there are no more concerns or updates, I will merge this tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4151: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2.5
Apache-HBase commented on pull request #4151: URL: https://github.com/apache/hbase/pull/4151#issuecomment-1057577389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 39s | branch-2.5 passed | | +1 :green_heart: | compile | 1m 42s | branch-2.5 passed | | +1 :green_heart: | shadedjars | 3m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 4s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 2m 22s | the patch passed | | +1 :green_heart: | javac | 2m 22s | the patch passed | | +1 :green_heart: | shadedjars | 4m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 560m 57s | root in the patch passed. | | | | 591m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4151 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f84f2d43dba0 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4858b2543c | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/testReport/ | | Max. process+thread count | 2000 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26745) MetricsStochasticBalancerSource metrics don't render in /jmx endpoint
[
https://issues.apache.org/jira/browse/HBASE-26745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-26745:
Fix Version/s: 2.5.0
2.6.0
3.0.0-alpha-3
2.4.11
Status: Patch Available (was: Open)
> MetricsStochasticBalancerSource metrics don't render in /jmx endpoint
> -
>
> Key: HBASE-26745
> URL: https://issues.apache.org/jira/browse/HBASE-26745
> Project: HBase
> Issue Type: Bug
>Reporter: Bryan Beaudreault
>Assignee: Briana Augenreich
>Priority: Minor
> Labels: patch-available
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> The check in JSONBean
> [here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java#L266]
> causes the balancer cost metrics to be excluded from the {{/jmx}} endpoint.
> I think we should just remove the check for ":". I don't think including
> metrics with a colon in them poses any problem, since the strings are quoted.
> We removed this check in our cdh5 fork almost a year ago and have not seen
> any issues.
> Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit
> metrics that adhere to these filters, but I think that would be a backwards
> incompatible change since this is only a json rendering issue and people
> might be consuming JMX directly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] apurtell merged pull request #4140: HBASE-26745: Include balancer cost metrics in jmx endpoint
apurtell merged pull request #4140: URL: https://github.com/apache/hbase/pull/4140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4150: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2
Apache-HBase commented on pull request #4150: URL: https://github.com/apache/hbase/pull/4150#issuecomment-1057548476 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 27s | branch-2 passed | | +1 :green_heart: | compile | 1m 33s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 52s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 1m 34s | the patch passed | | +1 :green_heart: | javac | 1m 34s | the patch passed | | +1 :green_heart: | shadedjars | 3m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 536m 28s | root in the patch passed. | | | | 559m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4150 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a60f7f50028d 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e93abe687b | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/testReport/ | | Max. process+thread count | 2469 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] clarax commented on pull request #69: HBASE-24587 hbck2 command should accept one or more files containing …
clarax commented on pull request #69: URL: https://github.com/apache/hbase-operator-tools/pull/69#issuecomment-1057533157 @wchevreuil @ndimiduk all ready. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4152: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2.4
Apache-HBase commented on pull request #4152: URL: https://github.com/apache/hbase/pull/4152#issuecomment-1057516822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 40s | branch-2.4 passed | | +1 :green_heart: | compile | 1m 50s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 4m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 33s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 1m 50s | the patch passed | | +1 :green_heart: | javac | 1m 50s | the patch passed | | +1 :green_heart: | shadedjars | 4m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 379m 43s | root in the patch passed. | | | | 411m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4152 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 03512711752f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / 36e1a1d260 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/testReport/ | | Max. process+thread count | 3170 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-filesystem] ankitsinghal merged pull request #32: HBASE-26786 [hboss] Limit synchronization from hot path of HBoss APIs
ankitsinghal merged pull request #32: URL: https://github.com/apache/hbase-filesystem/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-filesystem] ankitsinghal commented on pull request #32: HBASE-26786 [hboss] Limit synchronization from hot path of HBoss APIs
ankitsinghal commented on pull request #32: URL: https://github.com/apache/hbase-filesystem/pull/32#issuecomment-1057504075 Thanks @joshelser for taking a closer look.. I agree filesytem shouldn't need to worry about the synchronization between close and writes as it is what the caller should ensure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #69: HBASE-24587 hbck2 command should accept one or more files containing …
Apache-HBase commented on pull request #69: URL: https://github.com/apache/hbase-operator-tools/pull/69#issuecomment-1057499022 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 54s | master passed | | +1 :green_heart: | compile | 0m 10s | master passed | | +1 :green_heart: | checkstyle | 0m 7s | master passed | | +1 :green_heart: | javadoc | 0m 7s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 12s | the patch passed | | +1 :green_heart: | compile | 0m 10s | the patch passed | | +1 :green_heart: | javac | 0m 10s | the patch passed | | +1 :green_heart: | checkstyle | 0m 4s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 35s | hbase-hbck2 in the patch passed. | | +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. | | | | 6m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-69/8/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/69 | | Optional Tests | dupname asflicense markdownlint javac javadoc unit spotbugs findbugs checkstyle compile | | uname | Linux 67c579d8c97d 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b7d9fc8 | | Default Java | Oracle Corporation-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-69/8/testReport/ | | Max. process+thread count | 1259 (vs. ulimit of 5000) | | modules | C: hbase-hbck2 U: hbase-hbck2 | | Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-69/8/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24587) hbck2 command should accept one or more files containing a list of region names/table names/namespaces
[ https://issues.apache.org/jira/browse/HBASE-24587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499761#comment-17499761 ] Clara Xiong edited comment on HBASE-24587 at 3/2/22, 11:27 PM: --- # added a common -i option so any command that takes a list of argument can take a list of input files. # updated the -h message and README. # added a unit test for the generic option and test this option for assigns and unassigns. For other commands, since they all share the same code path, I don't see a need to add more ut. The existing ut for other command don't touch generic options either. # for commands that take two arguments(table|resgion state), I opened a subtask for taking the pairs in a list of files because that involves changing the interface of calls to server. But I have roll the changes into the same pr. was (Author: claraxiong): # added a common -i option so any command that takes a list of argument can take a list of input files. # updated the -h message and README. # added a unit test for the generic option and test this option for assigns and unassigns. For other commands, since they all share the same code path, I don't see a need to add more ut. The existing ut for other command don't touch generic options either. # for commands that take two arguments(table|resgion state), I will open a separate jira and pr for taking the pairs in a list of files because that involves changing the interface of calls to server. > hbck2 command should accept one or more files containing a list of region > names/table names/namespaces > -- > > Key: HBASE-24587 > URL: https://issues.apache.org/jira/browse/HBASE-24587 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools, hbck2 >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Clara Xiong >Assignee: Clara Xiong >Priority: Major > > Currently many command accepts a list of region names/ table names/namespaces > on the command line. We should accept paths to one or more files that > contains these encoded regions, one per line. That way, this command tails > nicely into an operator's incantation using grep/sed over log files. > Similar work has been done in > https://issues.apache.org/jira/browse/HBASE-23927 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-26785) hbck setTableState and setRegionState should accept one or more files for batch processing
[ https://issues.apache.org/jira/browse/HBASE-26785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong resolved HBASE-26785. - Resolution: Fixed Rolled into the same PR for parent jira > hbck setTableState and setRegionState should accept one or more files for > batch processing > -- > > Key: HBASE-26785 > URL: https://issues.apache.org/jira/browse/HBASE-26785 > Project: HBase > Issue Type: Sub-task >Reporter: Clara Xiong >Priority: Major > > They should take a list of input files containing list of target and state > pair, one pair per line. > > This aa separate jira and pr from HBASE-24587 because that involves changing > the interface of calls to server. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase-operator-tools] clarax edited a comment on pull request #69: HBASE-24587 hbck2 command should accept one or more files containing …
clarax edited a comment on pull request #69: URL: https://github.com/apache/hbase-operator-tools/pull/69#issuecomment-1055851862 @wchevreuil @ndimiduk Thank you for the feedback. Sorry I shelved this for other priorities. I am back to finish this. The changes are: 1. added a common -i option so any command that takes a list of argument can take a list of input files. 2. updated the -h message and README. 3. added a unit test for the generic option and test this option for assigns and unassigns. For other commands, since they all share the same code path, I don't see a need to add more ut. The existing ut for other command don't touch generic options either. 4. for commands that take two arguments(table|resgion state), I opened a separate jira and pr for taking the pairs in a list of files. https://issues.apache.org/jira/browse/HBASE-26785 but later decided to include here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4151: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2.5
Apache-HBase commented on pull request #4151: URL: https://github.com/apache/hbase/pull/4151#issuecomment-1057489648 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 32s | branch-2.5 passed | | +1 :green_heart: | compile | 2m 46s | branch-2.5 passed | | +1 :green_heart: | shadedjars | 4m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 55s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 2m 56s | the patch passed | | +1 :green_heart: | javac | 2m 56s | the patch passed | | +1 :green_heart: | shadedjars | 4m 23s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 407m 4s | root in the patch passed. | | | | 442m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4151 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3b8c408d30bf 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4858b2543c | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/testReport/ | | Max. process+thread count | 2482 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4133: HBASE-26622 Update error-prone to 2.10
Apache-HBase commented on pull request #4133: URL: https://github.com/apache/hbase/pull/4133#issuecomment-1057486599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 21s | master passed | | +1 :green_heart: | compile | 1m 39s | master passed | | +1 :green_heart: | shadedjars | 3m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 21s | the patch passed | | +1 :green_heart: | compile | 1m 40s | the patch passed | | +1 :green_heart: | javac | 1m 40s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 53s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 471m 32s | root in the patch failed. | | | | 496m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4133 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2240dd146828 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 87f8d9ac4e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/testReport/ | | Max. process+thread count | 1664 (vs. ulimit of 3) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4147: HBASE-26783 ScannerCallable doubly clears meta cache on retries
Apache-HBase commented on pull request #4147: URL: https://github.com/apache/hbase/pull/4147#issuecomment-1057485620 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 12s | branch-2 passed | | +1 :green_heart: | compile | 2m 27s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 51s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 55s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 2m 27s | the patch passed | | -0 :warning: | javac | 1m 51s | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) | | -0 :warning: | checkstyle | 0m 17s | hbase-client: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 7m 20s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 29m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4147 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux d73184770645 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5f63550b7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | whitespace | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 60 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4147/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #4147: HBASE-26783 ScannerCallable doubly clears meta cache on retries
bbeaudreault commented on pull request #4147: URL: https://github.com/apache/hbase/pull/4147#issuecomment-1057478213 I hit an unrelated bug and some extra complexity for reverse scans. I filed HBASE-26790 to track the bug, since that really only affected a test but should be fixed separately. I just pushed some changes to fix reverse scans. The crux of the reverse scan issue is that it does some special magic to find the appropriate region location when using an empty start row. When a throwable is handled, we'd pass the empty row into updateRegionLocations and end up not updating anything. So we really need to update the row key for the found location, so I stashed that in the object member variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4153: HBASE-26792 Implement ScanInfo#toString
Apache-HBase commented on pull request #4153: URL: https://github.com/apache/hbase/pull/4153#issuecomment-1057454307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 43s | master passed | | +1 :green_heart: | compile | 2m 16s | master passed | | +1 :green_heart: | checkstyle | 0m 37s | master passed | | +1 :green_heart: | spotbugs | 1m 20s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 2m 10s | the patch passed | | +1 :green_heart: | javac | 2m 10s | the patch passed | | +1 :green_heart: | checkstyle | 0m 35s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 27s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 1m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 31m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4153 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 45f6b9332ebf 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 06f06cbd86 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4153/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4154: HBASE-26792 Implement ScanInfo#toString
Apache-HBase commented on pull request #4154: URL: https://github.com/apache/hbase/pull/4154#issuecomment-1057451065 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 45s | branch-2 passed | | +1 :green_heart: | compile | 1m 50s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 38s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 17s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 15s | the patch passed | | +1 :green_heart: | compile | 1m 51s | the patch passed | | +1 :green_heart: | javac | 1m 51s | the patch passed | | +1 :green_heart: | checkstyle | 0m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 34s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 1m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 26m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4154/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4154 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6e4352065034 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5f63550b7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 60 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4154/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4133: HBASE-26622 Update error-prone to 2.10
Apache-HBase commented on pull request #4133: URL: https://github.com/apache/hbase/pull/4133#issuecomment-1057398826 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 12s | master passed | | +1 :green_heart: | compile | 1m 57s | master passed | | +1 :green_heart: | shadedjars | 4m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 21s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 58s | the patch passed | | +1 :green_heart: | compile | 1m 56s | the patch passed | | +1 :green_heart: | javac | 1m 56s | the patch passed | | +1 :green_heart: | shadedjars | 4m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 21s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 347m 19s | root in the patch failed. | | | | 376m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4133 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ad9728fda56d 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 87f8d9ac4e | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/testReport/ | | Max. process+thread count | 1551 (vs. ulimit of 3) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey edited a comment on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
busbey edited a comment on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057382135 yeah, I think this is the prudent first step since we're not currently using the Checks API for our precommit jobs. At some point we'll want to use it, but that should include a bunch of other work like removing the yetus comments and making sure the check details are a link to the yetus reports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
busbey commented on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057382135 yeah, I think this is the prudent first step since we're not currently using the Checks API for our precommit jobs. At some point we'll want to us it, but that should include a bunch of other work like removing the yetus comments and making sure the check details are a link to the yetus reports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4141: Backport "HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)" to branch-2
Apache-HBase commented on pull request #4141: URL: https://github.com/apache/hbase/pull/4141#issuecomment-1057363837 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | branch-2 passed | | +1 :green_heart: | compile | 0m 53s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 4m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 340m 51s | hbase-server in the patch passed. | | | | 362m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4141/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4141 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4787adbdef4f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7f30aa8b63 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4141/2/testReport/ | | Max. process+thread count | 2021 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4141/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26792) Implement ScanInfo#toString
Rushabh Shah created HBASE-26792: Summary: Implement ScanInfo#toString Key: HBASE-26792 URL: https://issues.apache.org/jira/browse/HBASE-26792 Project: HBase Issue Type: Improvement Reporter: Rushabh Shah Assignee: Rushabh Shah We don't have ScanInfo#toString. We use ScanInfo while creating StoreScanner which is used in preFlushScannerOpen in co-proc. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4141: Backport "HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)" to branch-2
Apache-HBase commented on pull request #4141: URL: https://github.com/apache/hbase/pull/4141#issuecomment-1057353256 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 11s | branch-2 passed | | +1 :green_heart: | compile | 0m 33s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 0m 31s | the patch passed | | +1 :green_heart: | javac | 0m 31s | the patch passed | | +1 :green_heart: | shadedjars | 3m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 332m 25s | hbase-server in the patch passed. | | | | 348m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4141/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4141 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5e2744eb5d3c 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7f30aa8b63 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4141/2/testReport/ | | Max. process+thread count | 2123 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4141/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26772) Shell suspended in background
[
https://issues.apache.org/jira/browse/HBASE-26772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500365#comment-17500365
]
Hudson commented on HBASE-26772:
Results for branch branch-2.5
[build #53 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/53/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/53/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/53/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/53/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/53/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Shell suspended in background
> -
>
> Key: HBASE-26772
> URL: https://issues.apache.org/jira/browse/HBASE-26772
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.11
>
>
> The hbase shell process hangs when running in the background with piped input.
> {noformat}
> $ cat command.sh
> #!/bin/bash
> echo "list" | bin/hbase shell > shell.out 2>&1
> $ ./command.sh &
> [1] 62907
> $
> [1] + 62907 suspended (tty output) ./command.sh{noformat}
> This regression was introduced with JRuby 9.1 -> 9.2 upgrade and the process
> hangs on this line:
> [https://github.com/apache/hbase/blob/master/hbase-shell/src/main/ruby/jar-bootstrap.rb#L41]
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client
Apache-HBase commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1057306705 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 48s | master passed | | +1 :green_heart: | compile | 7m 40s | master passed | | +1 :green_heart: | checkstyle | 1m 23s | master passed | | +1 :green_heart: | spotbugs | 11m 51s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 7m 53s | the patch passed | | -0 :warning: | javac | 7m 53s | root generated 3 new + 1472 unchanged - 0 fixed = 1475 total (was 1472) | | +1 :green_heart: | checkstyle | 1m 27s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 13m 17s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 11m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 68m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4125/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4125 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux be64f21a784e 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 06f06cbd86 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4125/8/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 87 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4125/8/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26772) Shell suspended in background
[
https://issues.apache.org/jira/browse/HBASE-26772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500345#comment-17500345
]
Hudson commented on HBASE-26772:
Results for branch master
[build #523 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/523/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/523/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/523/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/523/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Shell suspended in background
> -
>
> Key: HBASE-26772
> URL: https://issues.apache.org/jira/browse/HBASE-26772
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.11
>
>
> The hbase shell process hangs when running in the background with piped input.
> {noformat}
> $ cat command.sh
> #!/bin/bash
> echo "list" | bin/hbase shell > shell.out 2>&1
> $ ./command.sh &
> [1] 62907
> $
> [1] + 62907 suspended (tty output) ./command.sh{noformat}
> This regression was introduced with JRuby 9.1 -> 9.2 upgrade and the process
> hangs on this line:
> [https://github.com/apache/hbase/blob/master/hbase-shell/src/main/ruby/jar-bootstrap.rb#L41]
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26776) RpcServer failure to SASL handshake always logs user "unknown" to audit log
[
https://issues.apache.org/jira/browse/HBASE-26776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500346#comment-17500346
]
Hudson commented on HBASE-26776:
Results for branch master
[build #523 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/523/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/523/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/523/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/523/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RpcServer failure to SASL handshake always logs user "unknown" to audit log
> ---
>
> Key: HBASE-26776
> URL: https://issues.apache.org/jira/browse/HBASE-26776
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> Over on HBASE-26622, we noticed that the "attempting user" is always returned
> as "Unknown". This information is sent to the audit log when constructing the
> {{HBaseSaslRpcServer}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4152: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2.4
Apache-HBase commented on pull request #4152: URL: https://github.com/apache/hbase/pull/4152#issuecomment-1057213108 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 27s | branch-2.4 passed | | +1 :green_heart: | compile | 5m 15s | branch-2.4 passed | | +1 :green_heart: | checkstyle | 1m 10s | branch-2.4 passed | | +1 :green_heart: | spotbugs | 9m 2s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 3s | the patch passed | | +1 :green_heart: | compile | 5m 54s | the patch passed | | -0 :warning: | javac | 5m 54s | root generated 117 new + 1557 unchanged - 286 fixed = 1674 total (was 1843) | | +1 :green_heart: | checkstyle | 1m 8s | root: The patch generated 0 new + 196 unchanged - 5 fixed = 196 total (was 201) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 10m 15s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 9m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. | | | | 55m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4152 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 2e0591e5e4d1 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / 36e1a1d260 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 87 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4152/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4151: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2.5
Apache-HBase commented on pull request #4151: URL: https://github.com/apache/hbase/pull/4151#issuecomment-1057162711 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 3s | branch-2.5 passed | | +1 :green_heart: | compile | 7m 12s | branch-2.5 passed | | +1 :green_heart: | checkstyle | 1m 17s | branch-2.5 passed | | +1 :green_heart: | spotbugs | 14m 31s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | +1 :green_heart: | compile | 7m 21s | the patch passed | | -0 :warning: | javac | 7m 21s | root generated 121 new + 1549 unchanged - 332 fixed = 1670 total (was 1881) | | +1 :green_heart: | checkstyle | 1m 6s | root: The patch generated 0 new + 81 unchanged - 5 fixed = 81 total (was 86) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 10m 52s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 10m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. | | | | 69m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4151 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux e772fe54b8a4 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4858b2543c | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 87 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4151/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
ndimiduk commented on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057146884 @busbey do you agree that we should disable the Check API feature of the `junit` plugin? This is in place of installing the GitHub Check API Implementation plugin and enabling post-back of unit test results to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26788) Fix or disable Checks API callback in builds
[
https://issues.apache.org/jira/browse/HBASE-26788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26788:
-
Assignee: Nick Dimiduk
Status: Patch Available (was: Open)
> Fix or disable Checks API callback in builds
>
>
> Key: HBASE-26788
> URL: https://issues.apache.org/jira/browse/HBASE-26788
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> Often as not, PR builds will succeed but be reported on the PR as a failure.
> The reason is represented in Jenkins pipeline as a warning in the "Archive
> Junit-formatted test results", with the message
> {noformat}
> [2022-03-01T22:05:49.166Z] Recording test results
> [2022-03-01T22:05:50.627Z] [Checks API] No suitable checks publisher found.
> {noformat}
> This is confusing and discouraging to contributors.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] ndimiduk opened a new pull request #4152: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2.4
ndimiduk opened a new pull request #4152: URL: https://github.com/apache/hbase/pull/4152 Author:Mike Drob Co-authored-by: Nick Dimiduk Signed-off-by: Andrew Purtell -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3652: HBASE-26242 Allow split when store file count larger than the …
Apache-HBase commented on pull request #3652: URL: https://github.com/apache/hbase/pull/3652#issuecomment-1057141656 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 4m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 343m 4s | hbase-server in the patch passed. | | | | 364m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3652/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3652 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9ce6d5b5f934 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e85bf414ab | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3652/4/testReport/ | | Max. process+thread count | 1774 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3652/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3652: HBASE-26242 Allow split when store file count larger than the …
Apache-HBase commented on pull request #3652: URL: https://github.com/apache/hbase/pull/3652#issuecomment-1057140913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 0m 37s | master passed | | +1 :green_heart: | shadedjars | 3m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 23s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | shadedjars | 3m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 341m 18s | hbase-server in the patch failed. | | | | 363m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3652/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3652 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 92ca5562cb4d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e85bf414ab | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3652/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3652/4/testReport/ | | Max. process+thread count | 1714 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-3652/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26791) Memstore flush fencing issue for SFT
Szabolcs Bukros created HBASE-26791: --- Summary: Memstore flush fencing issue for SFT Key: HBASE-26791 URL: https://issues.apache.org/jira/browse/HBASE-26791 Project: HBase Issue Type: Bug Affects Versions: 2.6.0, 3.0.0-alpha-3 Reporter: Szabolcs Bukros The scenarios is the following: # rs1 is flushing file to S3 for region1 # rs1 loses ZK lock # region1 gets assigned to rs2 # rs2 opens region1 # rs1 completes flush and updates sft file for region1 # rs2 has a different “version” of the sft file for region1 The flush should fail at the end, but the SFT file gets overwritten before that, resulting in potential data loss. Potential solutions include: * Adding timestamp to the tracker file names. This and creating a new tracker file when an rs open the region would allow us to list available tracker files before an update and compare the found timestamps to the one stored in memory to verify the store still owns the latest tracker file * Using the existing timestamp in the tracker file content. This would also require us to create a new tracker file when a new rs opens the region, but instead of listing the available tracker files, we could try to load and de-serialize the last tracker file and compare the timestamp found in it to the one stored in memory. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4150: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2
Apache-HBase commented on pull request #4150: URL: https://github.com/apache/hbase/pull/4150#issuecomment-1057124225 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 0s | branch-2 passed | | +1 :green_heart: | compile | 7m 22s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 13s | branch-2 passed | | +1 :green_heart: | spotbugs | 10m 3s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | -1 :x: | compile | 3m 31s | root in the patch failed. | | -0 :warning: | javac | 3m 31s | root in the patch failed. | | +1 :green_heart: | checkstyle | 1m 33s | root: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 9m 55s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 16m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. | | | | 66m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4150 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 54ed1db92c42 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e93abe687b | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/artifact/yetus-general-check/output/patch-compile-root.txt | | Max. process+thread count | 87 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4150: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2
Apache-HBase commented on pull request #4150: URL: https://github.com/apache/hbase/pull/4150#issuecomment-1057101185 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 47s | branch-2 passed | | +1 :green_heart: | compile | 2m 33s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 33s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 2m 21s | the patch passed | | +1 :green_heart: | javac | 2m 21s | the patch passed | | +1 :green_heart: | shadedjars | 3m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 20s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 9m 54s | root in the patch failed. | | | | 44m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4150 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 598fc8116aa0 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e93abe687b | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/testReport/ | | Max. process+thread count | 524 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4150/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4133: HBASE-26622 Update error-prone to 2.10
Apache-HBase commented on pull request #4133: URL: https://github.com/apache/hbase/pull/4133#issuecomment-1057090253 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 25s | master passed | | +1 :green_heart: | compile | 5m 25s | master passed | | +1 :green_heart: | checkstyle | 1m 8s | master passed | | +1 :green_heart: | spotbugs | 10m 18s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 20s | the patch passed | | +1 :green_heart: | compile | 6m 8s | the patch passed | | -0 :warning: | javac | 6m 8s | root generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625) | | +1 :green_heart: | checkstyle | 1m 5s | root: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 0s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 17s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 11m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. | | | | 60m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4133 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 2a954ae14eee 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 87f8d9ac4e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 87 (vs. ulimit of 3) | | modules | C: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26790) getAllRegionLocations can cache locations with null hostname
Bryan Beaudreault created HBASE-26790: - Summary: getAllRegionLocations can cache locations with null hostname Key: HBASE-26790 URL: https://issues.apache.org/jira/browse/HBASE-26790 Project: HBase Issue Type: Bug Reporter: Bryan Beaudreault RegionLocator methods typically delegate to ConnectionImplementation.locateRegion, which throws a NoServerForRegionException if the located region's serverName is null. RegionLocator.getAllRegionLocations does not go through that path, instead caching all returned region locations without any validation. This can result in a "dirty" meta cache, since clients do not expect to have null serverNames in the meta cache. We should add the same throwing of NoServerForRegionException to this method as used in the others. Or at least we should not cache the result if the serverName is null. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] ndimiduk opened a new pull request #4151: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2.5
ndimiduk opened a new pull request #4151: URL: https://github.com/apache/hbase/pull/4151 Author:Mike Drob Co-authored-by: Nick Dimiduk Signed-off-by: Andrew Purtell -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
Apache-HBase commented on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057071469 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 46s | master passed | | +1 :green_heart: | compile | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 27s | the patch passed | | +1 :green_heart: | compile | 0m 37s | the patch passed | | +1 :green_heart: | javac | 0m 37s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 47s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 24m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4149 | | Optional Tests | dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile | | uname | Linux 6fe91df6d09d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 06f06cbd86 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/2/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
Apache-HBase commented on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057067636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 0s | master passed | | +1 :green_heart: | compile | 0m 20s | master passed | | +1 :green_heart: | shadedjars | 3m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 59s | the patch passed | | +1 :green_heart: | compile | 0m 22s | the patch passed | | +1 :green_heart: | javac | 0m 22s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 16s | hbase-client in the patch passed. | | | | 20m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4149 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux baa560307417 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 06f06cbd86 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/2/testReport/ | | Max. process+thread count | 119 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26762) Scan#setRowPrefixFilter incorrectly marked as deprecated
[
https://issues.apache.org/jira/browse/HBASE-26762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-26762.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.5+.
Thanks [~nielsbasjes] for contributing!
Please fill the release note.
> Scan#setRowPrefixFilter incorrectly marked as deprecated
>
>
> Key: HBASE-26762
> URL: https://issues.apache.org/jira/browse/HBASE-26762
> Project: HBase
> Issue Type: Bug
> Components: Client, scan
>Affects Versions: 3.0.0-alpha-2
>Reporter: Niels Basjes
>Assignee: Niels Basjes
>Priority: Major
>
> Issue HBASE-25299 is about the Scan#setRowPrefixFilter having not the
> expected effects when using also the setStartRow and/or setStopRow.
> The setRowPrefixFilter is intended to make setting the right startRow and
> stopRow for prefix scans. So it was always intended of using it *instead* of
> doing separate setStartRow and/or setStopRow calls.
> The reason for adding this to the Scan (~ 8 years ago, HBASE-11990 ) was that
> calculating the correct start and stop row for doing the very efficient
> prefix scan is very very hard to do right in the generic case.
> This is still a current usecase and many of my applications rely on this
> function (I even prefer the HBase Client when connecting to Google BigTable
> for this method).
> With issue HBASE-25299 it has now been marked as deprecated.
> Quote from the changes made in HBASE-25299:
> {code}
> @deprecated since 3.0.0. The scan result might be unexpected in some cases.
> {code}
> Yes, if you use this very valuable method incorrectly it will yield incorrect
> results.
> I do not consider this a valid reason to deprecate it.
> So I do agree with the confusion of the effects as described in HBASE-25299
> which should be fixed with additional documentation.
> I disagree with the deprecation of this method.
>
> I'll put up a pull request in which I improve the documentation and remove
> the deprecation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
Apache-HBase commented on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057064226 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 0m 18s | master passed | | +1 :green_heart: | shadedjars | 3m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 0m 17s | the patch passed | | +1 :green_heart: | javac | 0m 17s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 45s | hbase-client in the patch passed. | | | | 16m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4149 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux eeddc1f19d26 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 06f06cbd86 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/2/testReport/ | | Max. process+thread count | 97 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26788) Fix or disable Checks API callback in builds
[
https://issues.apache.org/jira/browse/HBASE-26788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500226#comment-17500226
]
Sean Busbey commented on HBASE-26788:
-
wonderful diagnosis work.
> Fix or disable Checks API callback in builds
>
>
> Key: HBASE-26788
> URL: https://issues.apache.org/jira/browse/HBASE-26788
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> Often as not, PR builds will succeed but be reported on the PR as a failure.
> The reason is represented in Jenkins pipeline as a warning in the "Archive
> Junit-formatted test results", with the message
> {noformat}
> [2022-03-01T22:05:49.166Z] Recording test results
> [2022-03-01T22:05:50.627Z] [Checks API] No suitable checks publisher found.
> {noformat}
> This is confusing and discouraging to contributors.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4141: Backport "HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)" to branch-2
Apache-HBase commented on pull request #4141: URL: https://github.com/apache/hbase/pull/4141#issuecomment-1057042692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 45s | branch-2 passed | | +1 :green_heart: | compile | 2m 11s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 41s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 41s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 12s | the patch passed | | +1 :green_heart: | compile | 1m 55s | the patch passed | | +1 :green_heart: | javac | 1m 55s | the patch passed | | +1 :green_heart: | checkstyle | 0m 38s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 14s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 1m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 25m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4141/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4141 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 82d787756c7e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7f30aa8b63 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 60 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4141/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk opened a new pull request #4150: Backport "HBASE-26622 Update error-prone to 2.10" to branch-2
ndimiduk opened a new pull request #4150: URL: https://github.com/apache/hbase/pull/4150 Author:Mike Drob Co-authored-by: Nick Dimiduk Signed-off-by: Andrew Purtell -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-26622) Update to error-prone 2.10
[ https://issues.apache.org/jira/browse/HBASE-26622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-26622: Assignee: Mike Drob (was: Nick Dimiduk) > Update to error-prone 2.10 > -- > > Key: HBASE-26622 > URL: https://issues.apache.org/jira/browse/HBASE-26622 > Project: HBase > Issue Type: Task >Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 3.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1057037823 Thanks for getting us started, @madrob ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk closed pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk closed pull request #3979: URL: https://github.com/apache/hbase/pull/3979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1057037578 Resolved via #4133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26622) Update to error-prone 2.10
[ https://issues.apache.org/jira/browse/HBASE-26622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26622: - Fix Version/s: 3.0.0-alpha-3 > Update to error-prone 2.10 > -- > > Key: HBASE-26622 > URL: https://issues.apache.org/jira/browse/HBASE-26622 > Project: HBase > Issue Type: Task >Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3 >Reporter: Mike Drob >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] ndimiduk merged pull request #4133: HBASE-26622 Update error-prone to 2.10
ndimiduk merged pull request #4133: URL: https://github.com/apache/hbase/pull/4133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4120: HBASE-26764 Implement generic exception support for TraceUtil methods over Callables and Runnables
ndimiduk commented on pull request #4120: URL: https://github.com/apache/hbase/pull/4120#issuecomment-1057032495 Ping @Apache9 @joshelser @taklwu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
Apache-HBase commented on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057030598 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 0m 34s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 0m 33s | the patch passed | | +1 :green_heart: | javac | 0m 33s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 51s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 25m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4149 | | Optional Tests | dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile | | uname | Linux 720f31f96770 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 87f8d9ac4e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/1/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
Apache-HBase commented on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057022269 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 37s | master passed | | +1 :green_heart: | compile | 0m 18s | master passed | | +1 :green_heart: | shadedjars | 3m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 4m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 1s | hbase-client in the patch passed. | | | | 19m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4149 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 31d0a4a21ec5 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 87f8d9ac4e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/1/testReport/ | | Max. process+thread count | 106 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4149: HBASE-26788 Disable Checks API callback from test results in PRs
Apache-HBase commented on pull request #4149: URL: https://github.com/apache/hbase/pull/4149#issuecomment-1057019514 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 2s | master passed | | +1 :green_heart: | compile | 0m 16s | master passed | | +1 :green_heart: | shadedjars | 3m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 38s | the patch passed | | +1 :green_heart: | compile | 0m 16s | the patch passed | | +1 :green_heart: | javac | 0m 16s | the patch passed | | +1 :green_heart: | shadedjars | 3m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 48s | hbase-client in the patch passed. | | | | 17m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4149 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7908b0e46252 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 87f8d9ac4e | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/1/testReport/ | | Max. process+thread count | 118 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4149/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26776) RpcServer failure to SASL handshake always logs user "unknown" to audit log
[
https://issues.apache.org/jira/browse/HBASE-26776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26776:
-
Fix Version/s: 2.5.0
2.6.0
2.4.11
> RpcServer failure to SASL handshake always logs user "unknown" to audit log
> ---
>
> Key: HBASE-26776
> URL: https://issues.apache.org/jira/browse/HBASE-26776
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> Over on HBASE-26622, we noticed that the "attempting user" is always returned
> as "Unknown". This information is sent to the audit log when constructing the
> {{HBaseSaslRpcServer}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (HBASE-26776) RpcServer failure to SASL handshake always logs user "unknown" to audit log
[
https://issues.apache.org/jira/browse/HBASE-26776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26776:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
> RpcServer failure to SASL handshake always logs user "unknown" to audit log
> ---
>
> Key: HBASE-26776
> URL: https://issues.apache.org/jira/browse/HBASE-26776
> Project: HBase
> Issue Type: Bug
> Components: security
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> Over on HBASE-26622, we noticed that the "attempting user" is always returned
> as "Unknown". This information is sent to the audit log when constructing the
> {{HBaseSaslRpcServer}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] ndimiduk merged pull request #4142: Backport "HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)" to branch-2.5
ndimiduk merged pull request #4142: URL: https://github.com/apache/hbase/pull/4142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #4143: Backport "HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)" to branch-2.4
ndimiduk merged pull request #4143: URL: https://github.com/apache/hbase/pull/4143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #4141: Backport "HBASE-26776 RpcServer failure to SASL handshake always logs user "unknown" to audit log (#4138)" to branch-2
ndimiduk merged pull request #4141: URL: https://github.com/apache/hbase/pull/4141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26789) Automatically add default security headers to http/rest if SSL enabled
[ https://issues.apache.org/jira/browse/HBASE-26789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros resolved HBASE-26789. - Resolution: Fixed > Automatically add default security headers to http/rest if SSL enabled > -- > > Key: HBASE-26789 > URL: https://issues.apache.org/jira/browse/HBASE-26789 > Project: HBase > Issue Type: Improvement > Components: REST, UI >Affects Versions: 2.0.6, 2.1.10, 2.2.7, 3.0.0-alpha-2 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.11 > > > In the previous ticket https://issues.apache.org/jira/browse/HBASE-23303 we > implemented these security headers as optional which had to explicitly > enabled in the config. > With this change the headers will automatically be added with meaningful > default values if SSL is enabled. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26789) Automatically add default security headers to http/rest if SSL enabled
[ https://issues.apache.org/jira/browse/HBASE-26789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-26789: Fix Version/s: 2.5.0 3.0.0-alpha-3 2.4.11 > Automatically add default security headers to http/rest if SSL enabled > -- > > Key: HBASE-26789 > URL: https://issues.apache.org/jira/browse/HBASE-26789 > Project: HBase > Issue Type: Improvement > Components: REST, UI >Affects Versions: 2.0.6, 2.1.10, 2.2.7, 3.0.0-alpha-2 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.11 > > > In the previous ticket https://issues.apache.org/jira/browse/HBASE-23303 we > implemented these security headers as optional which had to explicitly > enabled in the config. > With this change the headers will automatically be added with meaningful > default values if SSL is enabled. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26788) Fix or disable Checks API callback in builds
[
https://issues.apache.org/jira/browse/HBASE-26788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500202#comment-17500202
]
Nick Dimiduk commented on HBASE-26788:
--
FYI [~busbey]
> Fix or disable Checks API callback in builds
>
>
> Key: HBASE-26788
> URL: https://issues.apache.org/jira/browse/HBASE-26788
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> Often as not, PR builds will succeed but be reported on the PR as a failure.
> The reason is represented in Jenkins pipeline as a warning in the "Archive
> Junit-formatted test results", with the message
> {noformat}
> [2022-03-01T22:05:49.166Z] Recording test results
> [2022-03-01T22:05:50.627Z] [Checks API] No suitable checks publisher found.
> {noformat}
> This is confusing and discouraging to contributors.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26788) Fix or disable Checks API callback in builds
[
https://issues.apache.org/jira/browse/HBASE-26788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500201#comment-17500201
]
Nick Dimiduk commented on HBASE-26788:
--
Looking through the [installed
plugins|https://ci-hbase.apache.org/pluginManager/installed], it seems we have
the Checks API plugin installed but no Checks Implementation plugins installed.
> Fix or disable Checks API callback in builds
>
>
> Key: HBASE-26788
> URL: https://issues.apache.org/jira/browse/HBASE-26788
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> Often as not, PR builds will succeed but be reported on the PR as a failure.
> The reason is represented in Jenkins pipeline as a warning in the "Archive
> Junit-formatted test results", with the message
> {noformat}
> [2022-03-01T22:05:49.166Z] Recording test results
> [2022-03-01T22:05:50.627Z] [Checks API] No suitable checks publisher found.
> {noformat}
> This is confusing and discouraging to contributors.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] meszibalu merged pull request #4128: HBASE-26789 Automatically add default security headers to http/rest if SSL enabled
meszibalu merged pull request #4128: URL: https://github.com/apache/hbase/pull/4128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26788) Fix or disable Checks API callback in builds
[
https://issues.apache.org/jira/browse/HBASE-26788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500192#comment-17500192
]
Nick Dimiduk commented on HBASE-26788:
--
This step is coming from [our
use|https://github.com/apache/hbase/blob/ccd908f2187379853093dbb6fd3aabb648343a85/dev-support/Jenkinsfile_GitHub#L253]
of the {{junit}} plugin to "Archive JUnit-formatted test results". The [junit
plugin|https://www.jenkins.io/doc/pipeline/steps/junit/] seems to have support
for [Checks API plugin|https://plugins.jenkins.io/checks-api/], the mechanism
by which Jenkins can publish actions results to Github. I guess we have not
configured something about the Checks API plugin at the stage where the junit
plugin runs, and thus we get this warning. Let me try disabling check
publication at the {{junit}} configuration.
> Fix or disable Checks API callback in builds
>
>
> Key: HBASE-26788
> URL: https://issues.apache.org/jira/browse/HBASE-26788
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> Often as not, PR builds will succeed but be reported on the PR as a failure.
> The reason is represented in Jenkins pipeline as a warning in the "Archive
> Junit-formatted test results", with the message
> {noformat}
> [2022-03-01T22:05:49.166Z] Recording test results
> [2022-03-01T22:05:50.627Z] [Checks API] No suitable checks publisher found.
> {noformat}
> This is confusing and discouraging to contributors.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26548) Investigate mTLS in RPC layer
[ https://issues.apache.org/jira/browse/HBASE-26548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500161#comment-17500161 ] Bryan Beaudreault commented on HBASE-26548: --- An initial implementation for one-way TLS has been contributed over in https://issues.apache.org/jira/browse/HBASE-2. If that lands, it might be part of the work necessary for mTLS. > Investigate mTLS in RPC layer > - > > Key: HBASE-26548 > URL: https://issues.apache.org/jira/browse/HBASE-26548 > Project: HBase > Issue Type: New Feature >Reporter: Bryan Beaudreault >Priority: Major > Attachments: 0001-One-way-TLS-on-Netty-RPC-Implementation.patch > > > Current authentication options are heavily based on SASL and Kerberos. For > organizations that don't already deploy Kerberos or other token provider, > this is a heavy lift. Another very common way of authenticating in the > industry is mTLS, which makes use of SSL certifications and can solve both > wire encryption and auth. For those already deploying trusted certificates in > their infra, mTLS may be much easier to integrate. > It isn't necessarily easy to implement this, but I do think we could use > existing Netty SSL support in the NettyRpcClient and NettyRpcServer. I know > it's easy to add SSL to non-blocking IO through a > hadoop.rpc.socket.factory.class.default which returns SSLSockets, but that > doesn't touch on the certification verification at all. > Much more investigation is needed, but logging this due to some interest > encountered on slack. > Slack thread: > https://apache-hbase.slack.com/archives/C13K8NVAM/p1638980520110600 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26788) Fix or disable Checks API callback in builds
[
https://issues.apache.org/jira/browse/HBASE-26788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500160#comment-17500160
]
Nick Dimiduk commented on HBASE-26788:
--
I was looking at
https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4125/7/pipeline/18/
> Fix or disable Checks API callback in builds
>
>
> Key: HBASE-26788
> URL: https://issues.apache.org/jira/browse/HBASE-26788
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> Often as not, PR builds will succeed but be reported on the PR as a failure.
> The reason is represented in Jenkins pipeline as a warning in the "Archive
> Junit-formatted test results", with the message
> {noformat}
> [2022-03-01T22:05:49.166Z] Recording test results
> [2022-03-01T22:05:50.627Z] [Checks API] No suitable checks publisher found.
> {noformat}
> This is confusing and discouraging to contributors.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (HBASE-26723) Switch to use log4j2.properties file to configure log4j2
[ https://issues.apache.org/jira/browse/HBASE-26723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26723. --- Fix Version/s: 3.0.0-alpha-3 Hadoop Flags: Reviewed Release Note: Use log4j2.properties file instead of log4j2.xml. With LOG4J2-3341 in place, we could still make use of the old syntax where we could specify level and appenders at once, so we do not need to do splitting in our bash script and also make it less hurt for our users to upgrade. Resolution: Fixed Merged to master. Thanks [~apurtell] for reviewing! > Switch to use log4j2.properties file to configure log4j2 > > > Key: HBASE-26723 > URL: https://issues.apache.org/jira/browse/HBASE-26723 > Project: HBase > Issue Type: Improvement > Components: logging >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3 > > > After LOG4J2-3341, we could set the level and appender at once in properties > file, so we do not need to split the ROOT_LOGGER config in the start up > scripts any more. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache9 merged pull request #4096: HBASE-26723 Switch to use log4j2.properties file to configure log4j2
Apache9 merged pull request #4096: URL: https://github.com/apache/hbase/pull/4096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26789) Automatically add default security headers to http/rest if SSL enabled
Andor Molnar created HBASE-26789: Summary: Automatically add default security headers to http/rest if SSL enabled Key: HBASE-26789 URL: https://issues.apache.org/jira/browse/HBASE-26789 Project: HBase Issue Type: Improvement Components: REST, UI Affects Versions: 3.0.0-alpha-2, 2.2.7, 2.1.10, 2.0.6 Reporter: Andor Molnar Assignee: Andor Molnar In the previous ticket https://issues.apache.org/jira/browse/HBASE-23303 we implemented these security headers as optional which had to explicitly enabled in the config. With this change the headers will automatically be added with meaningful default values if SSL is enabled. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #79: HBASE-26781 [hbase-thirdparty] Introduce the sun.misc.Signal delegati…
Apache-HBase commented on pull request #79: URL: https://github.com/apache/hbase-thirdparty/pull/79#issuecomment-1056879273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 0m 28s | master passed | | +1 :green_heart: | compile | 0m 11s | master passed | | +1 :green_heart: | checkstyle | 0m 8s | master passed | | +1 :green_heart: | javadoc | 0m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 13s | the patch passed | | +1 :green_heart: | compile | 0m 12s | the patch passed | | -1 :x: | javac | 0m 6s | hbase-unsafe generated 4 new + 4 unchanged - 0 fixed = 8 total (was 4) | | +1 :green_heart: | checkstyle | 0m 8s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 10s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 21s | hbase-noop-htrace in the patch failed. | | +1 :green_heart: | unit | 0m 7s | hbase-unsafe in the patch passed. | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 3m 58s | | | Reason | Tests | |---:|:--| | Failed junit tests | hbase.htrace_noop.TestHBaseTestingUtilityWithHTraceNoop | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-79/2/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/79 | | Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux 75b1a86adebb 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 9f5c6e2 | | Default Java | Oracle Corporation-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-79/2/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt | | unit | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-79/2/artifact/yetus-precommit-check/output/patch-unit-hbase-noop-htrace.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-79/2/testReport/ | | Max. process+thread count | 233 (vs. ulimit of 1000) | | modules | C: hbase-noop-htrace hbase-unsafe U: . | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-79/2/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
