[GitHub] [hbase] Apache-HBase commented on pull request #4460: Backport to branch-2, HBASE-26320 Implement a separate thread pool for the LogCleaner (#3712)
Apache-HBase commented on PR #4460: URL: https://github.com/apache/hbase/pull/4460#issuecomment-1135475373 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 23s | branch-2 passed | | +1 :green_heart: | compile | 2m 16s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 32s | branch-2 passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 20s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 2m 59s | the patch passed | | +1 :green_heart: | javac | 2m 59s | the patch passed | | -0 :warning: | checkstyle | 0m 33s | hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 9m 21s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotless | 0m 50s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 32m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4460 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 8bc55c8e6cf1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 4260e3afb7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 69 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sunhelly merged pull request #4460: Backport to branch-2, HBASE-26320 Implement a separate thread pool for the LogCleaner (#3712)
sunhelly merged PR #4460: URL: https://github.com/apache/hbase/pull/4460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4457: HBASE-27028 Add a shell command for flushing master local region
Apache-HBase commented on PR #4457: URL: https://github.com/apache/hbase/pull/4457#issuecomment-1135458585 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 2m 25s | master passed | | +1 :green_heart: | shadedjars | 3m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 35s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 33s | the patch passed | | +1 :green_heart: | compile | 2m 25s | the patch passed | | +1 :green_heart: | javac | 2m 25s | the patch passed | | +1 :green_heart: | shadedjars | 3m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 39s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 17s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 200m 25s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 8m 37s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 7s | hbase-shell in the patch passed. | | | | 242m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4457 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bd6e069f329a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / bc21967946 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/testReport/ | | Max. process+thread count | 2578 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4457: HBASE-27028 Add a shell command for flushing master local region
Apache-HBase commented on PR #4457: URL: https://github.com/apache/hbase/pull/4457#issuecomment-1135454752 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 7s | master passed | | +1 :green_heart: | compile | 1m 46s | master passed | | +1 :green_heart: | shadedjars | 3m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 11s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 1m 48s | the patch passed | | +1 :green_heart: | javac | 1m 48s | the patch passed | | +1 :green_heart: | shadedjars | 3m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 25s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 198m 37s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 6m 44s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 42s | hbase-shell in the patch passed. | | | | 236m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4457 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 734122f64bd6 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / bc21967946 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/testReport/ | | Max. process+thread count | 2730 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4460: Backport to branch-2, HBASE-26320 Implement a separate thread pool for the LogCleaner (#3712)
Apache-HBase commented on PR #4460: URL: https://github.com/apache/hbase/pull/4460#issuecomment-1135452295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 51s | branch-2 passed | | +1 :green_heart: | compile | 0m 47s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 34s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 3m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 197m 7s | hbase-server in the patch passed. | | | | 217m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4460 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5bae01cb4212 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 4260e3afb7 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/testReport/ | | Max. process+thread count | 2557 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4460: Backport to branch-2, HBASE-26320 Implement a separate thread pool for the LogCleaner (#3712)
Apache-HBase commented on PR #4460: URL: https://github.com/apache/hbase/pull/4460#issuecomment-1135447097 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | branch-2 passed | | +1 :green_heart: | compile | 0m 35s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 56s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 6s | the patch passed | | +1 :green_heart: | compile | 0m 34s | the patch passed | | +1 :green_heart: | javac | 0m 34s | the patch passed | | +1 :green_heart: | shadedjars | 3m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 186m 31s | hbase-server in the patch passed. | | | | 208m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4460 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b0033796e914 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 4260e3afb7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/testReport/ | | Max. process+thread count | 2519 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4457: HBASE-27028 Add a shell command for flushing master local region
Apache-HBase commented on PR #4457: URL: https://github.com/apache/hbase/pull/4457#issuecomment-1135356636 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 42s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 13s | master passed | | +1 :green_heart: | compile | 4m 42s | master passed | | +1 :green_heart: | checkstyle | 1m 25s | master passed | | -1 :x: | spotless | 0m 36s | branch has 22 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 6m 7s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 5m 54s | the patch passed | | +1 :green_heart: | cc | 5m 54s | the patch passed | | +1 :green_heart: | javac | 5m 54s | the patch passed | | +1 :green_heart: | checkstyle | 1m 36s | the patch passed | | -0 :warning: | rubocop | 0m 7s | The patch generated 7 new + 425 unchanged - 1 fixed = 432 total (was 426) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | hbaseprotoc | 2m 3s | the patch passed | | -1 :x: | spotless | 0m 36s | patch has 22 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 5m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. | | | | 57m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4457 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop | | uname | Linux c5926117925e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / bc21967946 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-general-check/output/branch-spotless.txt | | rubocop | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4457/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4460: Backport to branch-2, HBASE-26320 Implement a separate thread pool for the LogCleaner (#3712)
Apache-HBase commented on PR #4460: URL: https://github.com/apache/hbase/pull/4460#issuecomment-1135351556 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 59s | branch-2 passed | | +1 :green_heart: | compile | 3m 0s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 35s | branch-2 passed | | +1 :green_heart: | spotless | 0m 55s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 42s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 2m 54s | the patch passed | | +1 :green_heart: | javac | 2m 54s | the patch passed | | -0 :warning: | checkstyle | 0m 33s | hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 51s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | -1 :x: | spotless | 0m 40s | patch has 66 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 1m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 33m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4460 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux c4403f1498ee 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 4260e3afb7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 60 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4460/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sunhelly opened a new pull request, #4460: Backport to branch-2, HBASE-26320 Implement a separate thread pool for the LogCleaner (#3712)
sunhelly opened a new pull request, #4460: URL: https://github.com/apache/hbase/pull/4460 This avoids starvation when the archive directory is large and takes a long time to iterate through. Signed-off-by: Duo Zhang Signed-off-by: Anoop Sam John Signed-off-by: Pankaj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26977) HMaster's ShutdownHook does not take effect, if tablesOnMaster is false
[ https://issues.apache.org/jira/browse/HBASE-26977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiangJun He resolved HBASE-26977. - Resolution: Resolved > HMaster's ShutdownHook does not take effect, if tablesOnMaster is false > --- > > Key: HBASE-26977 > URL: https://issues.apache.org/jira/browse/HBASE-26977 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 1.7.1, 2.4.9 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Major > Attachments: image-2022-04-26-21-12-51-843.png, > image-2022-04-26-21-18-24-884.png, image-2022-04-26-21-22-38-572.png > > > Because we are going to upgrade the HBase kernel version, during the test, I > found that the HMaster ShutdownHook of version 1.7.1 and 2.4.9 did not take > effect if tablesOnMaster is false. After further confirmation, I found that > all versions of HBase 1.x and 2.x have this problem. > I analyzed the cause of the problem： > Before HBase 3.x, HMaster registered ShutdownHook by calling the run() method > of HRegionServer, but the run() method will be blocked on the > waitForMasterActive() method of HMaster(before registering the shutdownhook) > if tablesOnMaster is false. Eventually, the ShutdownHook of HMaster was not > registered successfully. > 1. The code path of HRegionServer's run() method： > !image-2022-04-26-21-18-24-884.png! > > 2. The preRegistrationInitialization() method will be called first: > !image-2022-04-26-21-12-51-843.png! > 3. The HMaster's waitForMasterActive() method will be blocked if > tablesOnMaster is false: > !image-2022-04-26-21-22-38-572.png! > Finally, because the default value of tablesOnMaster is false, the > ShutdownHook of HMaster was not registered successfully. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-26320) Separate Log Cleaner DirScanPool to prevent the OLDWALs from filling up the disk when archive is large
[ https://issues.apache.org/jira/browse/HBASE-26320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541236#comment-17541236 ] Xiaolin Ha commented on HBASE-26320: This issue blocked the back port of HBASE-26342 to branch-2, I'll prepare a PR for branch-2.5+. FYI [~apurtell]. > Separate Log Cleaner DirScanPool to prevent the OLDWALs from filling up the > disk when archive is large > -- > > Key: HBASE-26320 > URL: https://issues.apache.org/jira/browse/HBASE-26320 > Project: HBase > Issue Type: Improvement > Components: Operability >Affects Versions: 1.7.1, 2.4.6 >Reporter: Zach York >Assignee: Zach York >Priority: Major > > We currently share the DirScanPool (threadpool for scanning for files to > delete in the OldLogs and archive directories) between the LogCleaner and > HFileCleaner. This means that if the archive directory is large/has lots of > files/directories, the threads can get stuck scanning through the archive > directory, starving the LogCleaner. This is especially apparent on S3 where > list can be slower than on HDFS. > This JIRA creates separate DirScanPools for the LogCleaner and HFileCleaner -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] sunhelly merged pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
sunhelly merged PR #4403: URL: https://github.com/apache/hbase/pull/4403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] tomscut commented on pull request #4432: HBASE-27037 Display the region server state on the Web UI
tomscut commented on PR #4432: URL: https://github.com/apache/hbase/pull/4432#issuecomment-1135287871 Hi @Apache9 , I updated the code, please have a look. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27058) Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped
[ https://issues.apache.org/jira/browse/HBASE-27058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-27058: - Priority: Major (was: Minor) > Admin#getLastMajorCompactionTimestamp() doesn't get updated when the > EnvironmentEdgeManager clock is stopped > > > Key: HBASE-27058 > URL: https://issues.apache.org/jira/browse/HBASE-27058 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.0 >Reporter: Istvan Toth >Priority: Major > Labels: test > > In Hbase 2.0-2.4 it is possible to check for a finished compaction by polling > Admin.getLastMajorCompactionTimestamp() for the table under compaction, even > when the clock is stopped via EnvironmentEdgeManager. > However, in Hbase 2.5 the Admin.getLastMajorCompactionTimestamp() will not be > updated even after the compaction is finished, and getCompactionState() > returns NONE. > I am not even sure that this is bug, however, this has broken one of our > Phoenix tests, and may cause problems for others. > This is the test code that breaks: > [https://github.com/apache/phoenix/blob/8aa825ed88828a99d40fdb68eb2f930981cd8a6b/phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java#L818] > Admin.getLastMajorCompactionTimestamp() seems to take the value from the > Metrics, so I guess that the metrics no longer get updated somewhere when the > clock is stopped. > I did not dig deeper than that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] tomscut commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command
tomscut commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879419726
##
hbase-shell/src/main/ruby/hbase/admin.rb:
##
@@ -1043,6 +1043,7 @@ def status(format, type)
else
puts "1 active master, #{cluster_metrics.getBackupMasterNames.size}
backup masters,
#{cluster_metrics.getLiveServerMetrics.size} servers,
+ #{@admin.listDecommissionedRegionServers.size} decommissioned,
Review Comment:
> [HBASE-25460](https://issues.apache.org/jira/browse/HBASE-25460) added
draininigRegionServers as a JMX metric. Can you access it via ClusterMetrics
class?
Thanks @pankaj72981 for your comment.
I will try to add this to ClusterMetrics. Do you think
`draininigRegionServers` or `decommissionedRegionServers` is a more appropriate
metric name? @Apache9 Please also take a look. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (HBASE-27042) hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut
[ https://issues.apache.org/jira/browse/HBASE-27042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-27042. Hadoop Flags: Reviewed Release Note: Adds support for Apache Hadoop 3.3.3 and removes S3Guard vestiges. Resolution: Fixed Thanks Steve! > hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut > --- > > Key: HBASE-27042 > URL: https://issues.apache.org/jira/browse/HBASE-27042 > Project: HBase > Issue Type: Bug > Components: hboss >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: hbase-filesystem-1.0.0-alpha2 > > > HBoss doesn't compile against hadoop builds containing HADOOP-17409, "remove > s3guard", as test setup tries to turn it off. > there's no need for s3guard any more, so hboss can just avoid all settings > and expect it to be disabled (hadoop 3.3.3. or earlier) or removed (3.4+) > (hboss version is 1.0.0-alpha2-SNAPSHOT) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (HBASE-27042) hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut
[ https://issues.apache.org/jira/browse/HBASE-27042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser reassigned HBASE-27042: -- Assignee: Steve Loughran (was: Steve Loughran) > hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut > --- > > Key: HBASE-27042 > URL: https://issues.apache.org/jira/browse/HBASE-27042 > Project: HBase > Issue Type: Bug > Components: hboss >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > > HBoss doesn't compile against hadoop builds containing HADOOP-17409, "remove > s3guard", as test setup tries to turn it off. > there's no need for s3guard any more, so hboss can just avoid all settings > and expect it to be disabled (hadoop 3.3.3. or earlier) or removed (3.4+) > (hboss version is 1.0.0-alpha2-SNAPSHOT) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HBASE-27042) hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut
[ https://issues.apache.org/jira/browse/HBASE-27042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-27042: --- Fix Version/s: hbase-filesystem-1.0.0-alpha2 > hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut > --- > > Key: HBASE-27042 > URL: https://issues.apache.org/jira/browse/HBASE-27042 > Project: HBase > Issue Type: Bug > Components: hboss >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: hbase-filesystem-1.0.0-alpha2 > > > HBoss doesn't compile against hadoop builds containing HADOOP-17409, "remove > s3guard", as test setup tries to turn it off. > there's no need for s3guard any more, so hboss can just avoid all settings > and expect it to be disabled (hadoop 3.3.3. or earlier) or removed (3.4+) > (hboss version is 1.0.0-alpha2-SNAPSHOT) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (HBASE-27042) hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut
[ https://issues.apache.org/jira/browse/HBASE-27042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser reassigned HBASE-27042: -- Assignee: Steve Loughran > hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut > --- > > Key: HBASE-27042 > URL: https://issues.apache.org/jira/browse/HBASE-27042 > Project: HBase > Issue Type: Bug > Components: hboss >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > > HBoss doesn't compile against hadoop builds containing HADOOP-17409, "remove > s3guard", as test setup tries to turn it off. > there's no need for s3guard any more, so hboss can just avoid all settings > and expect it to be disabled (hadoop 3.3.3. or earlier) or removed (3.4+) > (hboss version is 1.0.0-alpha2-SNAPSHOT) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase-filesystem] joshelser closed pull request #33: HBASE-27042. Remove S3Guard awareness from HBoss
joshelser closed pull request #33: HBASE-27042. Remove S3Guard awareness from HBoss URL: https://github.com/apache/hbase-filesystem/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-27058) Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped
[ https://issues.apache.org/jira/browse/HBASE-27058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541169#comment-17541169 ] Geoffrey Jacoby edited comment on HBASE-27058 at 5/23/22 9:01 PM: -- Some more context: at a high level, what is needed is a way to _synchronously_ request a major compaction in an IT test and not proceed until after the major compaction is done. And for this to work in a test using the EnvironmentEdgeManager. Since HBase doesn't provide a way to do that directly (I think it did a long time ago on the Admin API?), Phoenix has some test utilities that use the Admin API to request a major compaction, and then loop on Admin.getLastMajorCompactionTimestamp waiting for it to update to confirm the major compaction has taken place. This is necessary because Phoenix has some coprocessor hooks that modify compaction behavior that need to be tested. (For example, Phoenix has an option to block major compaction from reaping deleted / overwritten / TTL expired Cells for a certain window of time. This is necessary to keep Phoenix global index verifications and rebuilds from being messed up by an unlucky major compaction, because HBase has no idea that the base HBase table and index HBase table are logically linked.) Tests which exercise this sort of behavior usually use the EnvironmentEdgeManager a lot, because they're testing precise timestamp behavior and using the system clock and Thread.sleep would both be slow and unstable. was (Author: gjacoby): Some more context: at a high level, what is needed is a way to _synchronously_ request a major compaction in an IT test and not proceed until after the major compaction is done. Since HBase doesn't provide a way to do that directly (I think it did a long time ago on the Admin API?), Phoenix has some test utilities that use the Admin API to request a major compaction, and then loop on Admin.getLastMajorCompactionTimestamp waiting for it to update to confirm the major compaction has taken place. This is necessary because Phoenix has some coprocessor hooks that modify compaction behavior that need to be tested. (For example, Phoenix has an option to block major compaction from reaping deleted / overwritten / TTL expired Cells for a certain window of time. This is necessary to keep Phoenix global index verification and rebuilds from being messed up by an unlucky major compaction, because HBase has no idea that the base HBase table and index HBase table are logically linked.) > Admin#getLastMajorCompactionTimestamp() doesn't get updated when the > EnvironmentEdgeManager clock is stopped > > > Key: HBASE-27058 > URL: https://issues.apache.org/jira/browse/HBASE-27058 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.0 >Reporter: Istvan Toth >Priority: Minor > Labels: test > > In Hbase 2.0-2.4 it is possible to check for a finished compaction by polling > Admin.getLastMajorCompactionTimestamp() for the table under compaction, even > when the clock is stopped via EnvironmentEdgeManager. > However, in Hbase 2.5 the Admin.getLastMajorCompactionTimestamp() will not be > updated even after the compaction is finished, and getCompactionState() > returns NONE. > I am not even sure that this is bug, however, this has broken one of our > Phoenix tests, and may cause problems for others. > This is the test code that breaks: > [https://github.com/apache/phoenix/blob/8aa825ed88828a99d40fdb68eb2f930981cd8a6b/phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java#L818] > Admin.getLastMajorCompactionTimestamp() seems to take the value from the > Metrics, so I guess that the metrics no longer get updated somewhere when the > clock is stopped. > I did not dig deeper than that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27058) Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped
[ https://issues.apache.org/jira/browse/HBASE-27058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541169#comment-17541169 ] Geoffrey Jacoby commented on HBASE-27058: - Some more context: at a high level, what is needed is a way to _synchronously_ request a major compaction in an IT test and not proceed until after the major compaction is done. Since HBase doesn't provide a way to do that directly (I think it did a long time ago on the Admin API?), Phoenix has some test utilities that use the Admin API to request a major compaction, and then loop on Admin.getLastMajorCompactionTimestamp waiting for it to update to confirm the major compaction has taken place. This is necessary because Phoenix has some coprocessor hooks that modify compaction behavior that need to be tested. (For example, Phoenix has an option to block major compaction from reaping deleted / overwritten / TTL expired Cells for a certain window of time. This is necessary to keep Phoenix global index verification and rebuilds from being messed up by an unlucky major compaction, because HBase has no idea that the base HBase table and index HBase table are logically linked.) > Admin#getLastMajorCompactionTimestamp() doesn't get updated when the > EnvironmentEdgeManager clock is stopped > > > Key: HBASE-27058 > URL: https://issues.apache.org/jira/browse/HBASE-27058 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.0 >Reporter: Istvan Toth >Priority: Minor > Labels: test > > In Hbase 2.0-2.4 it is possible to check for a finished compaction by polling > Admin.getLastMajorCompactionTimestamp() for the table under compaction, even > when the clock is stopped via EnvironmentEdgeManager. > However, in Hbase 2.5 the Admin.getLastMajorCompactionTimestamp() will not be > updated even after the compaction is finished, and getCompactionState() > returns NONE. > I am not even sure that this is bug, however, this has broken one of our > Phoenix tests, and may cause problems for others. > This is the test code that breaks: > [https://github.com/apache/phoenix/blob/8aa825ed88828a99d40fdb68eb2f930981cd8a6b/phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java#L818] > Admin.getLastMajorCompactionTimestamp() seems to take the value from the > Metrics, so I guess that the metrics no longer get updated somewhere when the > clock is stopped. > I did not dig deeper than that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase-filesystem] joshelser commented on pull request #33: HBASE-27042. Remove S3Guard awareness from HBoss
joshelser commented on PR #33: URL: https://github.com/apache/hbase-filesystem/pull/33#issuecomment-1135110326 Running the tests locally since we don't have QA wired up here automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27026) Disable Style/FrozenStringLiteralComment for ruby
[ https://issues.apache.org/jira/browse/HBASE-27026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541129#comment-17541129 ] Jan Hentschel commented on HBASE-27026: --- Not sure. I would have expected that your [second commit|https://github.com/apache/hbase/pull/4416/commits/71b2f9670b205252b6bb7357265995c2d554e864] would be ok from a Rubocop perspective. It definitely could be related to the version as it seems that Rubocop also makes adjustments to the rules. > Disable Style/FrozenStringLiteralComment for ruby > - > > Key: HBASE-27026 > URL: https://issues.apache.org/jira/browse/HBASE-27026 > Project: HBase > Issue Type: Task >Reporter: Tao Li >Assignee: Tao Li >Priority: Major > Attachments: image-2022-05-20-09-14-36-355.png, > image-2022-05-20-09-25-05-608.png > > > By default Style/FrozenStringLiteralComment is enabled in rubocop. If we > update a ruby file, rubocop prompts `Missing frozen string literal comment` > (see > [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt]. > To address this warn, we need to add `# frozen_string_literal: true` to the > top of the ruby file(see > https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3637), > which will be added to the top of the `Apache License` and will look strange. > I don't think this `FrozenStringLiteralComment` check is very necessary. We > can disable it. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4459: HBASE-26366 Provide meaningful parent spans to ZK interactions
Apache-HBase commented on PR #4459: URL: https://github.com/apache/hbase/pull/4459#issuecomment-1134993765 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 3s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | shadedjars | 4m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 4m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 39s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 198m 20s | hbase-server in the patch passed. | | | | 219m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4459 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 428bdf0c0bcf 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/1/testReport/ | | Max. process+thread count | 2842 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26969) Eliminate MOB renames when SFT is enabled
[
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541025#comment-17541025
]
Szabolcs Bukros commented on HBASE-26969:
-
[~zhangduo] I'm sorry, I might have misspoken. We do not need an extra SFT.
Having the references in hfile metadata is sufficient. It's just slow and
clunky. But it works. I hoped a better way of storing this data could be found,
but as you have pointed out that is not necessary.
SFT is only linked to this issue, because SFT and removing renames are
thematically connected, I'm relying on some tools/solutions added to support
SFT and removing renames makes things more complicated so instead of changing
the default behavior the idea was to only remove them when SFT, that removed
the other renames, is enabled.
> Eliminate MOB renames when SFT is enabled
> -
>
> Key: HBASE-26969
> URL: https://issues.apache.org/jira/browse/HBASE-26969
> Project: HBase
> Issue Type: Sub-task
> Components: mob
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-3
>
>
> MOB file compaction and flush still relies on renames even when SFT is
> enabled.
> My proposed changes are:
> * when requireWritingToTmpDirFirst is false during mob flush/compact instead
> of using the temp writer we should create a different writer using a
> {color:#00}StoreFileWriterCreationTracker that writes directly to the mob
> store folder{color}
> * {color:#00}these StoreFileWriterCreationTracker should be stored in
> the MobStore. This would requires us to extend MobStore with a createWriter
> and a finalizeWriter method to handle this{color}
> * {color:#00}refactor {color}MobFileCleanerChore to run on the RS
> instead on Master to allow access to the
> {color:#00}StoreFileWriterCreationTracker{color}s to make sure the
> currently written files are not cleaned up
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (HBASE-27017) MOB snapshot is broken when FileBased SFT is used
[ https://issues.apache.org/jira/browse/HBASE-27017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Bukros reassigned HBASE-27017: --- Assignee: Szabolcs Bukros > MOB snapshot is broken when FileBased SFT is used > - > > Key: HBASE-27017 > URL: https://issues.apache.org/jira/browse/HBASE-27017 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Szabolcs Bukros >Assignee: Szabolcs Bukros >Priority: Major > > During snapshot MOB regions are treated like any other region. When a > snapshot is taken and hfile references are collected a StoreFileTracker is > created to get the current active hfile list. But the MOB region stores are > not tracked so an empty list is returned, resulting in a broken snapshot. > When this snapshot is cloned the resulting table will have no MOB files or > references. > The problematic code can be found here: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java#L313] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] huaxiangsun merged pull request #4442: HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…
huaxiangsun merged PR #4442: URL: https://github.com/apache/hbase/pull/4442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27017) MOB snapshot is broken when FileBased SFT is used
[ https://issues.apache.org/jira/browse/HBASE-27017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541018#comment-17541018 ] Szabolcs Bukros commented on HBASE-27017: - [~zhangduo] If you look at it like this, then you are absolutely right :) > MOB snapshot is broken when FileBased SFT is used > - > > Key: HBASE-27017 > URL: https://issues.apache.org/jira/browse/HBASE-27017 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Szabolcs Bukros >Priority: Major > > During snapshot MOB regions are treated like any other region. When a > snapshot is taken and hfile references are collected a StoreFileTracker is > created to get the current active hfile list. But the MOB region stores are > not tracked so an empty list is returned, resulting in a broken snapshot. > When this snapshot is cloned the resulting table will have no MOB files or > references. > The problematic code can be found here: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java#L313] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] huaxiangsun commented on pull request #4442: HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…
huaxiangsun commented on PR #4442: URL: https://github.com/apache/hbase/pull/4442#issuecomment-1134849688 Thanks @Apache9 for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] carp84 merged pull request #4377: HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false
carp84 merged PR #4377: URL: https://github.com/apache/hbase/pull/4377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27017) MOB snapshot is broken when FileBased SFT is used
[ https://issues.apache.org/jira/browse/HBASE-27017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541017#comment-17541017 ] Duo Zhang commented on HBASE-27017: --- This is not related to the problem here? First, we should make MOB work when SFT is enabled, since MOB regions are not compatible with file based SFT implementations for now, we should always set the SFT implementation to default in this case. In this case, we still need to write the files to a tmp directory first and then rename it to the final directory. This will impact performance, but anyway, do things correctly first, then try to increase the performance :) And how to eliminate the renames for MOB regions is another topic, which we will discuss it in HBASE-26969. > MOB snapshot is broken when FileBased SFT is used > - > > Key: HBASE-27017 > URL: https://issues.apache.org/jira/browse/HBASE-27017 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Szabolcs Bukros >Priority: Major > > During snapshot MOB regions are treated like any other region. When a > snapshot is taken and hfile references are collected a StoreFileTracker is > created to get the current active hfile list. But the MOB region stores are > not tracked so an empty list is returned, resulting in a broken snapshot. > When this snapshot is cloned the resulting table will have no MOB files or > references. > The problematic code can be found here: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java#L313] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4432: HBASE-27037 Display the region server state on the Web UI
Apache-HBase commented on PR #4432: URL: https://github.com/apache/hbase/pull/4432#issuecomment-1134843490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 53s | master passed | | +1 :green_heart: | javadoc | 0m 31s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 38s | the patch passed | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 206m 33s | hbase-server in the patch passed. | | | | 216m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4432 | | Optional Tests | javac javadoc unit | | uname | Linux b3a08bf55922 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/testReport/ | | Max. process+thread count | 2481 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4432: HBASE-27037 Display the region server state on the Web UI
Apache-HBase commented on PR #4432: URL: https://github.com/apache/hbase/pull/4432#issuecomment-1134843063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 46s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 8s | master passed | | +1 :green_heart: | javadoc | 0m 30s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 2s | the patch passed | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 205m 27s | hbase-server in the patch passed. | | | | 216m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4432 | | Optional Tests | javac javadoc unit | | uname | Linux 7b401fe74441 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/testReport/ | | Max. process+thread count | 2532 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] BukrosSzabolcs commented on a diff in pull request #4418: HBASE-26969:Eliminate MOB renames when SFT is enabled
BukrosSzabolcs commented on code in PR #4418:
URL: https://github.com/apache/hbase/pull/4418#discussion_r879616672
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/RSMobFileCleanerChore.java:
##
@@ -0,0 +1,262 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.mob;
+
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.ScheduledChore;
+import org.apache.hadoop.hbase.TableDescriptors;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.backup.HFileArchiver;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.regionserver.HRegion;
+import org.apache.hadoop.hbase.regionserver.HRegionServer;
+import org.apache.hadoop.hbase.regionserver.HStore;
+import org.apache.hadoop.hbase.regionserver.HStoreFile;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.common.collect.SetMultimap;
+
+/**
+ * The class RSMobFileCleanerChore for running cleaner regularly to remove the
+ * obsolete (files which have no active references to) mob files that were
referenced from the
+ * current RS.
+ */
+@InterfaceAudience.Private
+public class RSMobFileCleanerChore extends ScheduledChore {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(RSMobFileCleanerChore.class);
+ private final HRegionServer rs;
+
+ public RSMobFileCleanerChore(HRegionServer rs) {
+super(rs.getServerName() + "-MobFileCleanerChore", rs,
rs.getConfiguration()
+ .getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD), Math.round(
+ rs.getConfiguration()
+.getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD) * ((
+ThreadLocalRandom.current().nextDouble() + 0.5D))), TimeUnit.SECONDS);
+// to prevent a load spike on the fs the initial delay is modified by +/-
50%
+this.rs = rs;
+ }
+
+ public RSMobFileCleanerChore() {
+this.rs = null;
+ }
+
+ @Override protected void chore() {
+
+long minAgeToArchive = rs.getConfiguration()
+ .getLong(MobConstants.MIN_AGE_TO_ARCHIVE_KEY,
MobConstants.DEFAULT_MIN_AGE_TO_ARCHIVE);
+// We check only those MOB files, which creation time is less
+// than maxCreationTimeToArchive. This is a current time - 1h. 1 hour gap
+// gives us full confidence that all corresponding store files will
+// exist at the time cleaning procedure begins and will be examined.
+// So, if MOB file creation time is greater than this maxTimeToArchive,
+// this will be skipped and won't be archived.
+long maxCreationTimeToArchive = EnvironmentEdgeManager.currentTime() -
minAgeToArchive;
+
+TableDescriptors htds = rs.getTableDescriptors();
+try {
+ FileSystem fs = FileSystem.get(rs.getConfiguration());
+
+ Map map = null;
+ try {
+map = htds.getAll();
+ } catch (IOException e) {
+LOG.error("MobFileCleanerChore failed", e);
+return;
+ }
+ Map>> referencedMOBs = new HashMap<>();
+ for (TableDescriptor htd : map.values()) {
+// Now clean obsolete files for a table
+LOG.info("Cleaning obsolete MOB files from table={}",
htd.getTableName());
+List list = MobUtils.getMobColumnFamilies(htd);
+List regions = rs.getRegions(htd.getTableName());
+for (HRegion region
[GitHub] [hbase] BukrosSzabolcs commented on a diff in pull request #4418: HBASE-26969:Eliminate MOB renames when SFT is enabled
BukrosSzabolcs commented on code in PR #4418:
URL: https://github.com/apache/hbase/pull/4418#discussion_r879616412
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/RSMobFileCleanerChore.java:
##
@@ -0,0 +1,262 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.mob;
+
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.ScheduledChore;
+import org.apache.hadoop.hbase.TableDescriptors;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.backup.HFileArchiver;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.regionserver.HRegion;
+import org.apache.hadoop.hbase.regionserver.HRegionServer;
+import org.apache.hadoop.hbase.regionserver.HStore;
+import org.apache.hadoop.hbase.regionserver.HStoreFile;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.common.collect.SetMultimap;
+
+/**
+ * The class RSMobFileCleanerChore for running cleaner regularly to remove the
+ * obsolete (files which have no active references to) mob files that were
referenced from the
+ * current RS.
+ */
+@InterfaceAudience.Private
+public class RSMobFileCleanerChore extends ScheduledChore {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(RSMobFileCleanerChore.class);
+ private final HRegionServer rs;
+
+ public RSMobFileCleanerChore(HRegionServer rs) {
+super(rs.getServerName() + "-MobFileCleanerChore", rs,
rs.getConfiguration()
+ .getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD), Math.round(
+ rs.getConfiguration()
+.getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD) * ((
+ThreadLocalRandom.current().nextDouble() + 0.5D))), TimeUnit.SECONDS);
+// to prevent a load spike on the fs the initial delay is modified by +/-
50%
+this.rs = rs;
+ }
+
+ public RSMobFileCleanerChore() {
+this.rs = null;
+ }
+
+ @Override protected void chore() {
+
+long minAgeToArchive = rs.getConfiguration()
+ .getLong(MobConstants.MIN_AGE_TO_ARCHIVE_KEY,
MobConstants.DEFAULT_MIN_AGE_TO_ARCHIVE);
+// We check only those MOB files, which creation time is less
+// than maxCreationTimeToArchive. This is a current time - 1h. 1 hour gap
+// gives us full confidence that all corresponding store files will
+// exist at the time cleaning procedure begins and will be examined.
+// So, if MOB file creation time is greater than this maxTimeToArchive,
+// this will be skipped and won't be archived.
+long maxCreationTimeToArchive = EnvironmentEdgeManager.currentTime() -
minAgeToArchive;
+
+TableDescriptors htds = rs.getTableDescriptors();
+try {
+ FileSystem fs = FileSystem.get(rs.getConfiguration());
+
+ Map map = null;
+ try {
+map = htds.getAll();
+ } catch (IOException e) {
+LOG.error("MobFileCleanerChore failed", e);
+return;
+ }
+ Map>> referencedMOBs = new HashMap<>();
+ for (TableDescriptor htd : map.values()) {
+// Now clean obsolete files for a table
+LOG.info("Cleaning obsolete MOB files from table={}",
htd.getTableName());
+List list = MobUtils.getMobColumnFamilies(htd);
+List regions = rs.getRegions(htd.getTableName());
+for (HRegion region
[GitHub] [hbase] BukrosSzabolcs commented on a diff in pull request #4418: HBASE-26969:Eliminate MOB renames when SFT is enabled
BukrosSzabolcs commented on code in PR #4418:
URL: https://github.com/apache/hbase/pull/4418#discussion_r879614934
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/RSMobFileCleanerChore.java:
##
@@ -0,0 +1,262 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.mob;
+
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.ScheduledChore;
+import org.apache.hadoop.hbase.TableDescriptors;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.backup.HFileArchiver;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.regionserver.HRegion;
+import org.apache.hadoop.hbase.regionserver.HRegionServer;
+import org.apache.hadoop.hbase.regionserver.HStore;
+import org.apache.hadoop.hbase.regionserver.HStoreFile;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.CommonFSUtils;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.common.collect.SetMultimap;
+
+/**
+ * The class RSMobFileCleanerChore for running cleaner regularly to remove the
+ * obsolete (files which have no active references to) mob files that were
referenced from the
+ * current RS.
+ */
+@InterfaceAudience.Private
+public class RSMobFileCleanerChore extends ScheduledChore {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(RSMobFileCleanerChore.class);
+ private final HRegionServer rs;
+
+ public RSMobFileCleanerChore(HRegionServer rs) {
+super(rs.getServerName() + "-MobFileCleanerChore", rs,
rs.getConfiguration()
+ .getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD), Math.round(
+ rs.getConfiguration()
+.getInt(MobConstants.MOB_CLEANER_PERIOD,
MobConstants.DEFAULT_MOB_CLEANER_PERIOD) * ((
+ThreadLocalRandom.current().nextDouble() + 0.5D))), TimeUnit.SECONDS);
+// to prevent a load spike on the fs the initial delay is modified by +/-
50%
+this.rs = rs;
+ }
+
+ public RSMobFileCleanerChore() {
+this.rs = null;
+ }
+
+ @Override protected void chore() {
+
+long minAgeToArchive = rs.getConfiguration()
+ .getLong(MobConstants.MIN_AGE_TO_ARCHIVE_KEY,
MobConstants.DEFAULT_MIN_AGE_TO_ARCHIVE);
+// We check only those MOB files, which creation time is less
+// than maxCreationTimeToArchive. This is a current time - 1h. 1 hour gap
+// gives us full confidence that all corresponding store files will
+// exist at the time cleaning procedure begins and will be examined.
+// So, if MOB file creation time is greater than this maxTimeToArchive,
+// this will be skipped and won't be archived.
+long maxCreationTimeToArchive = EnvironmentEdgeManager.currentTime() -
minAgeToArchive;
+
+TableDescriptors htds = rs.getTableDescriptors();
+try {
+ FileSystem fs = FileSystem.get(rs.getConfiguration());
+
+ Map map = null;
+ try {
+map = htds.getAll();
+ } catch (IOException e) {
+LOG.error("MobFileCleanerChore failed", e);
+return;
+ }
+ Map>> referencedMOBs = new HashMap<>();
+ for (TableDescriptor htd : map.values()) {
+// Now clean obsolete files for a table
+LOG.info("Cleaning obsolete MOB files from table={}",
htd.getTableName());
+List list = MobUtils.getMobColumnFamilies(htd);
+List regions = rs.getRegions(htd.getTableName());
+for (HRegion region
[GitHub] [hbase] carp84 commented on pull request #4377: HBASE-26977 HMaster's ShutdownHook does not take effect, if tablesOnMaster is false
carp84 commented on PR #4377: URL: https://github.com/apache/hbase/pull/4377#issuecomment-1134838144 Thanks for checking @2005hithlj . Since the test failures are irrelative to changes here and could pass locally, I will merge it soon. It seems the branch-1 pre-commit test is pretty unstable, let me try to dig into it when time allows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27058) Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped
[ https://issues.apache.org/jira/browse/HBASE-27058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-27058: Labels: test (was: ) > Admin#getLastMajorCompactionTimestamp() doesn't get updated when the > EnvironmentEdgeManager clock is stopped > > > Key: HBASE-27058 > URL: https://issues.apache.org/jira/browse/HBASE-27058 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.0 >Reporter: Istvan Toth >Priority: Minor > Labels: test > > In Hbase 2.0-2.4 it is possible to check for a finished compaction by polling > Admin.getLastMajorCompactionTimestamp() for the table under compaction, even > when the clock is stopped via EnvironmentEdgeManager. > However, in Hbase 2.5 the Admin.getLastMajorCompactionTimestamp() will not be > updated even after the compaction is finished, and getCompactionState() > returns NONE. > I am not even sure that this is bug, however, this has broken one of our > Phoenix tests, and may cause problems for others. > This is the test code that breaks: > [https://github.com/apache/phoenix/blob/8aa825ed88828a99d40fdb68eb2f930981cd8a6b/phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java#L818] > Admin.getLastMajorCompactionTimestamp() seems to take the value from the > Metrics, so I guess that the metrics no longer get updated somewhere when the > clock is stopped. > I did not dig deeper than that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27017) MOB snapshot is broken when FileBased SFT is used
[ https://issues.apache.org/jira/browse/HBASE-27017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541008#comment-17541008 ] Szabolcs Bukros commented on HBASE-27017: - [~zhangduo] That would not work well after we remove the renames. It would mean the snapshot would also contain any incomplete or broken files too currently in the dir. Copying trash around is a non-issue, because we only ever read the referenced mob files, but if a snapshot is made during write operation that later fails and the file is removed we would end up with a snapshot referencing a missing file. > MOB snapshot is broken when FileBased SFT is used > - > > Key: HBASE-27017 > URL: https://issues.apache.org/jira/browse/HBASE-27017 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.5.0, 3.0.0-alpha-2 >Reporter: Szabolcs Bukros >Priority: Major > > During snapshot MOB regions are treated like any other region. When a > snapshot is taken and hfile references are collected a StoreFileTracker is > created to get the current active hfile list. But the MOB region stores are > not tracked so an empty list is returned, resulting in a broken snapshot. > When this snapshot is cloned the resulting table will have no MOB files or > references. > The problematic code can be found here: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java#L313] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (HBASE-27058) Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped
Istvan Toth created HBASE-27058: --- Summary: Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped Key: HBASE-27058 URL: https://issues.apache.org/jira/browse/HBASE-27058 Project: HBase Issue Type: Bug Affects Versions: 2.5.0 Reporter: Istvan Toth In Hbase 2.0-2.4 it is possible to check for a finished compaction by polling Admin.getLastMajorCompactionTimestamp() for the table under compaction, even when the clock is stopped via EnvironmentEdgeManager. However, in Hbase 2.5 the Admin.getLastMajorCompactionTimestamp() will not be updated even after the compaction is finished, and getCompactionState() returns NONE. I am not even sure that this is bug, however, this has broken one of our Phoenix tests, and may cause problems for others. This is the test code that breaks: [https://github.com/apache/phoenix/blob/8aa825ed88828a99d40fdb68eb2f930981cd8a6b/phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java#L818] Admin.getLastMajorCompactionTimestamp() seems to take the value from the Metrics, so I guess that the metrics no longer get updated somewhere when the clock is stopped. I did not dig deeper than that. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (HBASE-26969) Eliminate MOB renames when SFT is enabled
[
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541006#comment-17541006
]
Duo Zhang edited comment on HBASE-26969 at 5/23/22 3:33 PM:
{quote}
That is true. We do not use SFT. But based on similar changes the renames would
be only eliminated if SFT is enabled, not by default. Also it relies on
WriterCreationTracker which is mostly an SFT tool.
{quote}
As long as we have all the file references in the normal store file's metadata,
why we still need an extra SFT?
was (Author: apache9):
{noformat}
That is true. We do not use SFT. But based on similar changes the renames would
be only eliminated if SFT is enabled, not by default. Also it relies on
WriterCreationTracker which is mostly an SFT tool.
{noformat}
As long as we have all the file references in the normal store file's metadata,
why we still need an extra SFT?
> Eliminate MOB renames when SFT is enabled
> -
>
> Key: HBASE-26969
> URL: https://issues.apache.org/jira/browse/HBASE-26969
> Project: HBase
> Issue Type: Sub-task
> Components: mob
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-3
>
>
> MOB file compaction and flush still relies on renames even when SFT is
> enabled.
> My proposed changes are:
> * when requireWritingToTmpDirFirst is false during mob flush/compact instead
> of using the temp writer we should create a different writer using a
> {color:#00}StoreFileWriterCreationTracker that writes directly to the mob
> store folder{color}
> * {color:#00}these StoreFileWriterCreationTracker should be stored in
> the MobStore. This would requires us to extend MobStore with a createWriter
> and a finalizeWriter method to handle this{color}
> * {color:#00}refactor {color}MobFileCleanerChore to run on the RS
> instead on Master to allow access to the
> {color:#00}StoreFileWriterCreationTracker{color}s to make sure the
> currently written files are not cleaned up
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-26969) Eliminate MOB renames when SFT is enabled
[
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541006#comment-17541006
]
Duo Zhang commented on HBASE-26969:
---
{noformat}
That is true. We do not use SFT. But based on similar changes the renames would
be only eliminated if SFT is enabled, not by default. Also it relies on
WriterCreationTracker which is mostly an SFT tool.
{noformat}
As long as we have all the file references in the normal store file's metadata,
why we still need an extra SFT?
> Eliminate MOB renames when SFT is enabled
> -
>
> Key: HBASE-26969
> URL: https://issues.apache.org/jira/browse/HBASE-26969
> Project: HBase
> Issue Type: Sub-task
> Components: mob
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-3
>
>
> MOB file compaction and flush still relies on renames even when SFT is
> enabled.
> My proposed changes are:
> * when requireWritingToTmpDirFirst is false during mob flush/compact instead
> of using the temp writer we should create a different writer using a
> {color:#00}StoreFileWriterCreationTracker that writes directly to the mob
> store folder{color}
> * {color:#00}these StoreFileWriterCreationTracker should be stored in
> the MobStore. This would requires us to extend MobStore with a createWriter
> and a finalizeWriter method to handle this{color}
> * {color:#00}refactor {color}MobFileCleanerChore to run on the RS
> instead on Master to allow access to the
> {color:#00}StoreFileWriterCreationTracker{color}s to make sure the
> currently written files are not cleaned up
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-26969) Eliminate MOB renames when SFT is enabled
[
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541004#comment-17541004
]
Szabolcs Bukros commented on HBASE-26969:
-
[~wchevreuil]
> Or is it that we lingering region dirs even after the parent SPLIT/MERGE got
>removed from META?
Yes. these regions are clean up by a chore and linger after no longer used. But
this does not really matter. The problem is that when we can not easily
identify which region should contain references to a given MOB file we have
absolutely no way to tell and have to read every single hfile's metadata to
check for references.
[~zhangduo]
> we do not use SFT at all the MOB regions
That is true. We do not use SFT. But based on similar changes the renames would
be only eliminated if SFT is enabled, not by default. Also it relies on
WriterCreationTracker which is mostly an SFT tool.
> Eliminate MOB renames when SFT is enabled
> -
>
> Key: HBASE-26969
> URL: https://issues.apache.org/jira/browse/HBASE-26969
> Project: HBase
> Issue Type: Sub-task
> Components: mob
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-3
>
>
> MOB file compaction and flush still relies on renames even when SFT is
> enabled.
> My proposed changes are:
> * when requireWritingToTmpDirFirst is false during mob flush/compact instead
> of using the temp writer we should create a different writer using a
> {color:#00}StoreFileWriterCreationTracker that writes directly to the mob
> store folder{color}
> * {color:#00}these StoreFileWriterCreationTracker should be stored in
> the MobStore. This would requires us to extend MobStore with a createWriter
> and a finalizeWriter method to handle this{color}
> * {color:#00}refactor {color}MobFileCleanerChore to run on the RS
> instead on Master to allow access to the
> {color:#00}StoreFileWriterCreationTracker{color}s to make sure the
> currently written files are not cleaned up
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4459: HBASE-26366 Provide meaningful parent spans to ZK interactions
Apache-HBase commented on PR #4459: URL: https://github.com/apache/hbase/pull/4459#issuecomment-1134805327 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 49s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 40s | master passed | | +1 :green_heart: | compile | 2m 30s | master passed | | +1 :green_heart: | checkstyle | 0m 38s | master passed | | +1 :green_heart: | spotless | 0m 46s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 4s | the patch passed | | +1 :green_heart: | compile | 2m 26s | the patch passed | | +1 :green_heart: | javac | 2m 26s | the patch passed | | -0 :warning: | checkstyle | 0m 28s | hbase-server: The patch generated 2 new + 13 unchanged - 1 fixed = 15 total (was 14) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 1s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 35m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4459 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 1fae7cdbb445 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4459/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26366) Provide meaningful parent spans to ZK interactions
[
https://issues.apache.org/jira/browse/HBASE-26366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26366:
-
Status: Patch Available (was: In Progress)
As of this patch, now every span that's emitted in my unit test has a
meaningful parent span, tied back to either a server activity or the ZKWatcher
handler pool. PTAL.
> Provide meaningful parent spans to ZK interactions
> --
>
> Key: HBASE-26366
> URL: https://issues.apache.org/jira/browse/HBASE-26366
> Project: HBase
> Issue Type: Improvement
> Components: tracing
>Affects Versions: 3.0.0-alpha-2, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-3
>
> Attachments: image.png,
> regroup-spans-for-recoverablezookeeper.create.png
>
>
> Enable tracing with {{-Dotel.traces.sampler=always_on}} and launch the
> standalone master, check the trace store. We see lots of single-span traces,
> each a call to different {{RecoverableZooKeeper}} methods, like {{create}}
> and {{exists}}. Whatever master startup thread this is should define its own
> root span.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [hbase] ndimiduk opened a new pull request, #4459: HBASE-26366 Provide meaningful parent spans to ZK interactions
ndimiduk opened a new pull request, #4459: URL: https://github.com/apache/hbase/pull/4459 As of this patch, now every span that's emitted in my unit test has a meaningful parent span, tied back to either a server activity or the ZKWatcher handler pool. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
Apache-HBase commented on PR #4403: URL: https://github.com/apache/hbase/pull/4403#issuecomment-1134639935 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | shadedjars | 3m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 214m 55s | hbase-server in the patch passed. | | | | 232m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4403 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a887d15f4c3a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/testReport/ | | Max. process+thread count | 2327 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] tomscut commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command
tomscut commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879419726
##
hbase-shell/src/main/ruby/hbase/admin.rb:
##
@@ -1043,6 +1043,7 @@ def status(format, type)
else
puts "1 active master, #{cluster_metrics.getBackupMasterNames.size}
backup masters,
#{cluster_metrics.getLiveServerMetrics.size} servers,
+ #{@admin.listDecommissionedRegionServers.size} decommissioned,
Review Comment:
> [HBASE-25460](https://issues.apache.org/jira/browse/HBASE-25460) added
draininigRegionServers as a JMX metric. Can you access it via ClusterMetrics
class?
Thanks @pankaj72981 for your comment.
I will try to add this to ClusterMetrics. Do you think
`draininigRegionServers` or `decommissionedRegionServers` more appropriate?
@Apache9 Please also take a look. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-27047) Fix typo for metric drainingRegionServers
[ https://issues.apache.org/jira/browse/HBASE-27047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540934#comment-17540934 ] Tao Li commented on HBASE-27047: Thanks [~pankajkumar] for reminding me. I updated the release note. Thanks [~zhangduo] and [~psomogyi] for your discussion. > Fix typo for metric drainingRegionServers > - > > Key: HBASE-27047 > URL: https://issues.apache.org/jira/browse/HBASE-27047 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Tao Li >Assignee: Tao Li >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13 > > > Fix typo for metric drainingRegionServers. `draininigRegionServers` -> > `drainingRegionServers`. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
Apache-HBase commented on PR #4403: URL: https://github.com/apache/hbase/pull/4403#issuecomment-1134620251 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 35s | master passed | | +1 :green_heart: | compile | 0m 44s | master passed | | +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed | | +1 :green_heart: | javac | 0m 44s | the patch passed | | +1 :green_heart: | shadedjars | 4m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 196m 9s | hbase-server in the patch failed. | | | | 213m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4403 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0adcfb87cba8 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/testReport/ | | Max. process+thread count | 2651 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27047) Fix typo for metric drainingRegionServers
[ https://issues.apache.org/jira/browse/HBASE-27047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Li updated HBASE-27047: --- Release Note: Fix typo for metric drainingRegionServers. Change metric name from draininigRegionServers to drainingRegionServers. > Fix typo for metric drainingRegionServers > - > > Key: HBASE-27047 > URL: https://issues.apache.org/jira/browse/HBASE-27047 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Tao Li >Assignee: Tao Li >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13 > > > Fix typo for metric drainingRegionServers. `draininigRegionServers` -> > `drainingRegionServers`. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] Apache-HBase commented on pull request #4432: HBASE-27037 Display the region server state on the Web UI
Apache-HBase commented on PR #4432: URL: https://github.com/apache/hbase/pull/4432#issuecomment-1134606053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 6s | master passed | | +1 :green_heart: | spotless | 0m 55s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 58s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 53s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 11m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4432 | | Optional Tests | dupname asflicense javac spotless | | uname | Linux ae068ad82b12 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26836) Should always set SFT implementation when cloning snapshot
[
https://issues.apache.org/jira/browse/HBASE-26836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540899#comment-17540899
]
Wellington Chevreuil commented on HBASE-26836:
--
Yes, we are going over this whilst running some test sets with pre-existing
snapshotted data. The options I see here are:
1) We leave as this, documenting this limitation and that MIGRATION cluster
should be used then to convert it to FILE, if that's desired. The risk here is
if cluster doesn't have HBOSS enabled and this step is ignored, there might be
problems for the table.
2) We add extra checks for the global SFT config, and if no SFT is defined in
the snapshot, we set the MIGRATION accordingly. Question then is when
should/would we change SFT config from MIGRATION to FILE? Add an extra stage on
the restore snapshot procedure, or should we just leave it for manual change?
> Should always set SFT implementation when cloning snapshot
> --
>
> Key: HBASE-26836
> URL: https://issues.apache.org/jira/browse/HBASE-26836
> Project: HBase
> Issue Type: Sub-task
> Components: HFile, snapshots
>Reporter: Duo Zhang
>Priority: Major
>
> Saw the TestCloneSnapshotProcedureFileBasedSFT failing several times
> {noformat}
> 2022-03-14T11:23:13,782 INFO [PEWorker-1]
> procedure2.ProcedureExecutor(1432): Finished pid=99, state=SUCCESS,
> hasLock=false; CloneSnapshotProcedure (table=testRecoverWithRestoreAclFlag
> snapshot=name: "snapshot-1647256973399"
> table: "testCloneSnapshot"
> creation_time: 1647256982366
> type: FLUSH
> version: 2
> owner: ""
> ttl: 0
> max_file_size: 0
> ) in 6.9090 sec
> 2022-03-14T11:23:13,794 WARN [PEWorker-1]
> procedure2.ProcedureExecutor$Testing(127): Toggle KILL before store update
> to: false
> 2022-03-14T11:23:13,794 DEBUG [PEWorker-1]
> procedure2.ProcedureExecutor(1777): TESTING: Kill BEFORE store update:
> pid=112, state=RUNNABLE:MODIFY_TABLE_DESCRIPTOR_UPDATE, hasLock=true;
> InitializeStoreFileTrackerProcedure table=testRecoverWithRestoreAclFlag
> 2022-03-14T11:23:13,794 INFO [PEWorker-1] procedure2.ProcedureExecutor(635):
> Stopping
> 2022-03-14T11:23:13,795 WARN [PEWorker-1]
> procedure2.ProcedureExecutor$WorkerThread(1997): Worker terminating
> UNNATURALLY null
> java.lang.RuntimeException: TESTING: Kill BEFORE store update: pid=112,
> state=RUNNABLE:MODIFY_TABLE_DESCRIPTOR_UPDATE, hasLock=true;
> InitializeStoreFileTrackerProcedure table=testRecoverWithRestoreAclFlag
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.kill(ProcedureExecutor.java:1779)
> ~[classes/:?]
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1723)
> ~[classes/:?]
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1414)
> ~[classes/:?]
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)
> ~[classes/:?]
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1981)
> ~[classes/:?]
> 2022-03-14T11:23:14,012 WARN [Time-limited test]
> procedure2.ProcedureTestingUtility(193): Set Kill before store update to:
> false
> {noformat}
> The CloneSnapshotProcedure is finished but then we get a
> InitializeStoreFileTrackerProcedure which messes up the test.
> The InitializeStoreFileTrackerProcedure will be scheduled when rolling
> upgrade, where we do not have SFT set for a table. So typically it should not
> be schedule. Not sure how this could happen in the UT, need to dig more.
> But anyway, when we clone a snapshot which was taken before we have SFT, it
> is possible the TableDescriptor does not have SFT implementation set, so we
> should set one for it.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HBASE-27047) Fix typo for metric drainingRegionServers
[ https://issues.apache.org/jira/browse/HBASE-27047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540884#comment-17540884 ] Duo Zhang commented on HBASE-27047: --- Yes, I think we should mark it as an incompatible change. The only concern here is whether it is OK to apply it to branch-2.4. For me, I think this is a typo, a mistake, which is OK for us to apply it to branch-2.4. And let's see the opinion from the release manager of branch-2.4. [~apurtell]. If this is not OK, we could revert it from branch-2.4. Thanks. > Fix typo for metric drainingRegionServers > - > > Key: HBASE-27047 > URL: https://issues.apache.org/jira/browse/HBASE-27047 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Tao Li >Assignee: Tao Li >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13 > > > Fix typo for metric drainingRegionServers. `draininigRegionServers` -> > `drainingRegionServers`. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HBASE-27047) Fix typo for metric drainingRegionServers
[ https://issues.apache.org/jira/browse/HBASE-27047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27047: -- Hadoop Flags: Incompatible change,Reviewed (was: Reviewed) > Fix typo for metric drainingRegionServers > - > > Key: HBASE-27047 > URL: https://issues.apache.org/jira/browse/HBASE-27047 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Tao Li >Assignee: Tao Li >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13 > > > Fix typo for metric drainingRegionServers. `draininigRegionServers` -> > `drainingRegionServers`. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27047) Fix typo for metric drainingRegionServers
[ https://issues.apache.org/jira/browse/HBASE-27047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540883#comment-17540883 ] Peter Somogyi commented on HBASE-27047: --- Isn't the removal of "draininigRegionServers" metric count as an incompatible change? > Fix typo for metric drainingRegionServers > - > > Key: HBASE-27047 > URL: https://issues.apache.org/jira/browse/HBASE-27047 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Tao Li >Assignee: Tao Li >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13 > > > Fix typo for metric drainingRegionServers. `draininigRegionServers` -> > `drainingRegionServers`. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [hbase] pankaj72981 commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command
pankaj72981 commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879247358
##
hbase-shell/src/main/ruby/hbase/admin.rb:
##
@@ -1043,6 +1043,7 @@ def status(format, type)
else
puts "1 active master, #{cluster_metrics.getBackupMasterNames.size}
backup masters,
#{cluster_metrics.getLiveServerMetrics.size} servers,
+ #{@admin.listDecommissionedRegionServers.size} decommissioned,
Review Comment:
HBASE-25460 added draininigRegionServers as a JMX metric. Can you access it
via ClusterMetrics class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
Apache-HBase commented on PR #4403: URL: https://github.com/apache/hbase/pull/4403#issuecomment-1134427110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 2m 14s | master passed | | +1 :green_heart: | checkstyle | 0m 29s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 2m 13s | the patch passed | | +1 :green_heart: | javac | 2m 13s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 59s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 31m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4403 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux a3ef7ef04ca2 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 73 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/6/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
Apache-HBase commented on PR #4403: URL: https://github.com/apache/hbase/pull/4403#issuecomment-1134387432 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 21s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | shadedjars | 3m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 18s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 217m 24s | hbase-server in the patch passed. | | | | 234m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4403 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 481068a21f13 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/5/testReport/ | | Max. process+thread count | 2352 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4403: HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner
Apache-HBase commented on PR #4403: URL: https://github.com/apache/hbase/pull/4403#issuecomment-1134363957 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 5s | master passed | | +1 :green_heart: | compile | 0m 44s | master passed | | +1 :green_heart: | shadedjars | 4m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 33s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed | | +1 :green_heart: | javac | 0m 44s | the patch passed | | +1 :green_heart: | shadedjars | 4m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 195m 26s | hbase-server in the patch failed. | | | | 213m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4403 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d303445619aa 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1be2c83b3d | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/5/testReport/ | | Max. process+thread count | 2820 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4403/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi closed pull request #4421: HBASE-27023 Add protobuf to NOTICE file
petersomogyi closed pull request #4421: HBASE-27023 Add protobuf to NOTICE file URL: https://github.com/apache/hbase/pull/4421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27047) Fix typo for metric drainingRegionServers
[ https://issues.apache.org/jira/browse/HBASE-27047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540817#comment-17540817 ] Pankaj Kumar commented on HBASE-27047: -- [~tomscut] Please update release notes for this incompatible change. > Fix typo for metric drainingRegionServers > - > > Key: HBASE-27047 > URL: https://issues.apache.org/jira/browse/HBASE-27047 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Tao Li >Assignee: Tao Li >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13 > > > Fix typo for metric drainingRegionServers. `draininigRegionServers` -> > `drainingRegionServers`. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
