[GitHub] [hbase] Apache-HBase commented on pull request #4670: HBASE-27237 Address is shoule be case insensitive
Apache-HBase commented on PR #4670: URL: https://github.com/apache/hbase/pull/4670#issuecomment-1200344100 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 23s | master passed | | +1 :green_heart: | compile | 0m 30s | master passed | | +1 :green_heart: | checkstyle | 0m 12s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 28s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 5s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | -0 :warning: | checkstyle | 0m 11s | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 23s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | -1 :x: | spotless | 0m 11s | patch has 26 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 0m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 8s | The patch does not generate ASF License warnings. | | | | 25m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4670 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 9a796eb212e1 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e8c14ee308 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 69 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4670: HBASE-27237 Address is shoule be case insensitive
Apache-HBase commented on PR #4670: URL: https://github.com/apache/hbase/pull/4670#issuecomment-1200343368 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 58s | master passed | | +1 :green_heart: | compile | 0m 17s | master passed | | +1 :green_heart: | shadedjars | 3m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 41s | the patch passed | | +1 :green_heart: | compile | 0m 17s | the patch passed | | +1 :green_heart: | javac | 0m 17s | the patch passed | | +1 :green_heart: | shadedjars | 3m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 52s | hbase-common in the patch passed. | | | | 18m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4670 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ec872c01bc75 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e8c14ee308 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/testReport/ | | Max. process+thread count | 186 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4670: HBASE-27237 Address is shoule be case insensitive
Apache-HBase commented on PR #4670: URL: https://github.com/apache/hbase/pull/4670#issuecomment-1200343187 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 28s | master passed | | +1 :green_heart: | compile | 0m 13s | master passed | | +1 :green_heart: | shadedjars | 3m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 0m 13s | the patch passed | | +1 :green_heart: | javac | 0m 13s | the patch passed | | +1 :green_heart: | shadedjars | 4m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 23s | hbase-common in the patch passed. | | | | 16m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4670 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f5934d2e12f9 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e8c14ee308 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/testReport/ | | Max. process+thread count | 162 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4670/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27257) Remove unnecessary usage of CachedBlocksByFile from RS UI
[
https://issues.apache.org/jira/browse/HBASE-27257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573293#comment-17573293
]
Hudson commented on HBASE-27257:
Results for branch branch-2.5
[build #175 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/175/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/175/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/175/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/175/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/175/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove unnecessary usage of CachedBlocksByFile from RS UI
> -
>
> Key: HBASE-27257
> URL: https://issues.apache.org/jira/browse/HBASE-27257
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.14
>
> Attachments: async-prof-pid-29233-cpu-1.html
>
>
> We have started deploying regionservers with large BucketCaches, with over 1M
> blocks in the cache. I noticed that our RS UI was loading pretty slowly, and
> I also noticed the following warning:
> {quote}*The stats below are incomplete!* We ran into our accounting limit of
> 100 blocks. Up the configuration
> {_}hbase.ui.blockcache.by.file.max{_}.{quote}
> Tracking that down, it seems like the original implementation back in 2014
> for the BlockCache statistics used CachedBlocksByFile to calculate counts,
> sizes, etc. But over time this was improved to be backed by CacheStats, for
> example in HBASE-11573, HBASE-15635, HBASE-18532, etc.
> At this point the cbsbf variable holding the CachedBlocksByFile object is not
> actually used by anything on the RS UI. Instead those per-file statistics
> have been moved to other endpoints, available via the "View block cache as
> JSON" and "as JSON by file" links.
> Removing the creation of the cbsbf variable makes a dramatic improvement on
> RS UI load times for large caches. Prior to the change, it consistently took
> 4-5s to load the UI. Afterward it takes a fraction of a second.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27257) Remove unnecessary usage of CachedBlocksByFile from RS UI
[
https://issues.apache.org/jira/browse/HBASE-27257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573292#comment-17573292
]
Hudson commented on HBASE-27257:
Results for branch master
[build #646 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/646/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/646/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/646/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/646/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove unnecessary usage of CachedBlocksByFile from RS UI
> -
>
> Key: HBASE-27257
> URL: https://issues.apache.org/jira/browse/HBASE-27257
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.14
>
> Attachments: async-prof-pid-29233-cpu-1.html
>
>
> We have started deploying regionservers with large BucketCaches, with over 1M
> blocks in the cache. I noticed that our RS UI was loading pretty slowly, and
> I also noticed the following warning:
> {quote}*The stats below are incomplete!* We ran into our accounting limit of
> 100 blocks. Up the configuration
> {_}hbase.ui.blockcache.by.file.max{_}.{quote}
> Tracking that down, it seems like the original implementation back in 2014
> for the BlockCache statistics used CachedBlocksByFile to calculate counts,
> sizes, etc. But over time this was improved to be backed by CacheStats, for
> example in HBASE-11573, HBASE-15635, HBASE-18532, etc.
> At this point the cbsbf variable holding the CachedBlocksByFile object is not
> actually used by anything on the RS UI. Instead those per-file statistics
> have been moved to other endpoints, available via the "View block cache as
> JSON" and "as JSON by file" links.
> Removing the creation of the cbsbf variable makes a dramatic improvement on
> RS UI load times for large caches. Prior to the change, it consistently took
> 4-5s to load the UI. Afterward it takes a fraction of a second.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4669: HBASE-27241 Add metrics for evaluating cost and effectiveness of bloom filters
Apache-HBase commented on PR #4669: URL: https://github.com/apache/hbase/pull/4669#issuecomment-1200264740 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 51s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 3m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 38s | hbase-hadoop-compat in the patch passed. | | -1 :x: | unit | 208m 46s | hbase-server in the patch failed. | | | | 229m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4669 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0ffefba27edd 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e8c14ee308 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/testReport/ | | Max. process+thread count | 2387 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4669: HBASE-27241 Add metrics for evaluating cost and effectiveness of bloom filters
Apache-HBase commented on PR #4669: URL: https://github.com/apache/hbase/pull/4669#issuecomment-1200263808 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 22s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | shadedjars | 3m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 0m 52s | the patch passed | | +1 :green_heart: | javac | 0m 52s | the patch passed | | +1 :green_heart: | shadedjars | 3m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 34s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 205m 32s | hbase-server in the patch passed. | | | | 223m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4669 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1fcdcbf118ad 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e8c14ee308 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/testReport/ | | Max. process+thread count | 2601 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4669: HBASE-27241 Add metrics for evaluating cost and effectiveness of bloom filters
Apache-HBase commented on PR #4669: URL: https://github.com/apache/hbase/pull/4669#issuecomment-1200170263 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 3m 19s | master passed | | +1 :green_heart: | checkstyle | 1m 3s | master passed | | +1 :green_heart: | spotless | 0m 58s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 0s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 32s | the patch passed | | +1 :green_heart: | compile | 2m 57s | the patch passed | | -0 :warning: | javac | 0m 20s | hbase-hadoop-compat generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | -0 :warning: | checkstyle | 0m 8s | hbase-hadoop-compat: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -0 :warning: | checkstyle | 0m 34s | hbase-server: The patch generated 1 new + 9 unchanged - 1 fixed = 10 total (was 10) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 18s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotless | 0m 48s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 39m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4669 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux ebe39f23bfad 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e8c14ee308 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-hadoop-compat.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4669/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27237) Address is shoule be case insensitive
[ https://issues.apache.org/jira/browse/HBASE-27237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Zhang updated HBASE-27237: --- Description: In HBASE-13995 and HBASE-24395, both mention that ServerName.getHostname() is case sensitive. Now the move_servers_rsgroup is still case sensitive. Servername is displayed in lowercase on the master ui, but uppercase is stored in the rsgroup table. I think the master ui should be consistent with the rsgroup table. !27237.png! was: In HBASE-13995 and HBASE-24395, both mention that ServerName.getHostname() is case sensitive. Now the move_servers_rsgroup is still case sensitive. Servername is displayed in lowercase on the master ui, but uppercase is stored in the rsgroup table. I think the master ui should be consistent with the rsgroup table, and move_servers_rsgroup should be case-insensitive. !27237.png! > Address is shoule be case insensitive > - > > Key: HBASE-27237 > URL: https://issues.apache.org/jira/browse/HBASE-27237 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.4.13, 2.5.1, 3.0.0-alpha-4 >Reporter: Xiao Zhang >Assignee: Xiao Zhang >Priority: Major > Attachments: 27237.png > > > In HBASE-13995 and HBASE-24395, both mention that ServerName.getHostname() is > case sensitive. > > Now the move_servers_rsgroup is still case sensitive. Servername is displayed > in lowercase on the master ui, but uppercase is stored in the rsgroup table. > I think the master ui should be consistent with the rsgroup table. > !27237.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27237) Address is not case insensitive
[ https://issues.apache.org/jira/browse/HBASE-27237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Zhang updated HBASE-27237: --- Summary: Address is not case insensitive (was: Address is not fully case insensitive) > Address is not case insensitive > --- > > Key: HBASE-27237 > URL: https://issues.apache.org/jira/browse/HBASE-27237 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.4.13, 2.5.1, 3.0.0-alpha-4 >Reporter: Xiao Zhang >Assignee: Xiao Zhang >Priority: Major > Attachments: 27237.png > > > In HBASE-13995 and HBASE-24395, both mention that ServerName.getHostname() is > case sensitive. > > Now the move_servers_rsgroup is still case sensitive. Servername is displayed > in lowercase on the master ui, but uppercase is stored in the rsgroup table. > I think the master ui should be consistent with the rsgroup table, and > move_servers_rsgroup should be case-insensitive. > !27237.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27237) Address is shoule be case insensitive
[ https://issues.apache.org/jira/browse/HBASE-27237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Zhang updated HBASE-27237: --- Summary: Address is shoule be case insensitive (was: Address is not case insensitive) > Address is shoule be case insensitive > - > > Key: HBASE-27237 > URL: https://issues.apache.org/jira/browse/HBASE-27237 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.4.13, 2.5.1, 3.0.0-alpha-4 >Reporter: Xiao Zhang >Assignee: Xiao Zhang >Priority: Major > Attachments: 27237.png > > > In HBASE-13995 and HBASE-24395, both mention that ServerName.getHostname() is > case sensitive. > > Now the move_servers_rsgroup is still case sensitive. Servername is displayed > in lowercase on the master ui, but uppercase is stored in the rsgroup table. > I think the master ui should be consistent with the rsgroup table, and > move_servers_rsgroup should be case-insensitive. > !27237.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27237) Address is not fully case insensitive
[ https://issues.apache.org/jira/browse/HBASE-27237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Zhang updated HBASE-27237: --- Summary: Address is not fully case insensitive (was: move_servers_rsgroup should be case insensitive) > Address is not fully case insensitive > - > > Key: HBASE-27237 > URL: https://issues.apache.org/jira/browse/HBASE-27237 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.4.13, 2.5.1, 3.0.0-alpha-4 >Reporter: Xiao Zhang >Assignee: Xiao Zhang >Priority: Major > Attachments: 27237.png > > > In HBASE-13995 and HBASE-24395, both mention that ServerName.getHostname() is > case sensitive. > > Now the move_servers_rsgroup is still case sensitive. Servername is displayed > in lowercase on the master ui, but uppercase is stored in the rsgroup table. > I think the master ui should be consistent with the rsgroup table, and > move_servers_rsgroup should be case-insensitive. > !27237.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27241) Add metrics for evaluating cost and effectiveness of bloom filters
[
https://issues.apache.org/jira/browse/HBASE-27241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Beaudreault updated HBASE-27241:
--
Fix Version/s: 2.5.1
3.0.0-alpha-4
2.4.14
Labels: patch-available (was: )
Status: Patch Available (was: Open)
> Add metrics for evaluating cost and effectiveness of bloom filters
> --
>
> Key: HBASE-27241
> URL: https://issues.apache.org/jira/browse/HBASE-27241
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Labels: patch-available
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.14
>
>
> Bloom filters can be costly for some tables, easily resulting in an aggregate
> memory footprint of many GBs. It's currently hard to monitor for that cost on
> a per-table basis. You can view {{staticBloomSize}} in JMX, but that is for
> the whole server. Otherwise you must manually sum the values using the
> regionserver UI. We can add this (as well as staticIndexSize) to the
> per-table metrics.
> Additionally, it can be hard to know how effective those bloom filters are. I
> think the easiest way to measure that is to count bloomFilterRequests and
> bloomFilterNegativeResults. With these metrics in hand, one can have an
> easier time deciding how much memory they want to give to their L1 cache
> and/or whether they want to disable blooms on a table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] bbeaudreault opened a new pull request, #4669: HBASE-27241 Add metrics for evaluating cost and effectiveness of bloom filters
bbeaudreault opened a new pull request, #4669: URL: https://github.com/apache/hbase/pull/4669 - Add static index/bloom sizes - Add metrics for bloom requests and negative results Combined these together are very useful for determining whether you should add bloom filters (if eligible requests is high) and whether they are worth the cost (compare bloom size to bloom request/negative result count) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
