[jira] [Commented] (HBASE-24163) MOB compactor implementations should use format specifiers when calling String.format
[
https://issues.apache.org/jira/browse/HBASE-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581158#comment-17581158
]
Hudson commented on HBASE-24163:
Results for branch branch-2
[build #620 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/620/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/620/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/620/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/620/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/620/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> MOB compactor implementations should use format specifiers when calling
> String.format
> -
>
> Key: HBASE-24163
> URL: https://issues.apache.org/jira/browse/HBASE-24163
> Project: HBase
> Issue Type: Bug
> Components: Compaction, mob
>Affects Versions: 3.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> HBASE-23723 includes a few IOException message constructions that rely on
> String.format but use slf4j parameters instead of format specifiers.
> Discovered by nightly failing error-prone.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1219024398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 23s | master passed | | +1 :green_heart: | compile | 1m 27s | master passed | | +1 :green_heart: | shadedjars | 4m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 50s | master passed | | -0 :warning: | patch | 6m 13s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 19s | the patch passed | | +1 :green_heart: | compile | 1m 29s | the patch passed | | +1 :green_heart: | javac | 1m 29s | the patch passed | | +1 :green_heart: | shadedjars | 4m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 397m 56s | root in the patch passed. | | | | 421m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4691 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux beee8c45a058 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/5/testReport/ | | Max. process+thread count | 4811 (vs. ulimit of 3) | | modules | C: hbase-common hbase-hadoop-compat hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1218932830 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | compile | 3m 8s | master passed | | +1 :green_heart: | shadedjars | 5m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 17s | master passed | | -0 :warning: | patch | 8m 57s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 2m 44s | the patch passed | | +1 :green_heart: | javac | 2m 44s | the patch passed | | +1 :green_heart: | shadedjars | 5m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 277m 46s | root in the patch passed. | | | | 313m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4691 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7b47f3ee37d0 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/5/testReport/ | | Max. process+thread count | 4220 (vs. ulimit of 3) | | modules | C: hbase-common hbase-hadoop-compat hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
busbey commented on PR #4706: URL: https://github.com/apache/hbase/pull/4706#issuecomment-1218908610 One of the distributed mob compaction changes brought in this bug on master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27295) Correct the comment of list_deadservers method in admin.rb
[ https://issues.apache.org/jira/browse/HBASE-27295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27295: - Fix Version/s: 3.0.0-alpha-4 > Correct the comment of list_deadservers method in admin.rb > -- > > Key: HBASE-27295 > URL: https://issues.apache.org/jira/browse/HBASE-27295 > Project: HBase > Issue Type: Improvement > Components: shell >Affects Versions: 3.0.0-alpha-4 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27295) Correct the comment of list_deadservers method in admin.rb
[ https://issues.apache.org/jira/browse/HBASE-27295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581076#comment-17581076 ] Tak-Lon (Stephen) Wu commented on HBASE-27295: -- commit merged > Correct the comment of list_deadservers method in admin.rb > -- > > Key: HBASE-27295 > URL: https://issues.apache.org/jira/browse/HBASE-27295 > Project: HBase > Issue Type: Improvement > Components: shell >Affects Versions: 3.0.0-alpha-4 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27295) Correct the comment of list_deadservers method in admin.rb
[ https://issues.apache.org/jira/browse/HBASE-27295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-27295. -- Hadoop Flags: Reviewed Resolution: Fixed > Correct the comment of list_deadservers method in admin.rb > -- > > Key: HBASE-27295 > URL: https://issues.apache.org/jira/browse/HBASE-27295 > Project: HBase > Issue Type: Improvement > Components: shell >Affects Versions: 3.0.0-alpha-4 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Minor > Fix For: 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] taklwu merged pull request #4694: HBASE-27295 Correct the comment of list_deadservers method in admin.rb
taklwu merged PR #4694: URL: https://github.com/apache/hbase/pull/4694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu commented on pull request #4662: HBASE-27252 Clean up error-prone findings in hbase-it
taklwu commented on PR #4662: URL: https://github.com/apache/hbase/pull/4662#issuecomment-1218647728 should we merge this PR ? or do we need to fix those nits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1218567401 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 56s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 32s | master passed | | +1 :green_heart: | compile | 8m 19s | master passed | | +1 :green_heart: | checkstyle | 1m 23s | master passed | | +0 :ok: | refguide | 3m 9s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 0m 54s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 11m 27s | master passed | | -0 :warning: | patch | 10m 31s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 45s | the patch passed | | +1 :green_heart: | compile | 11m 8s | the patch passed | | +1 :green_heart: | javac | 11m 8s | the patch passed | | +1 :green_heart: | checkstyle | 1m 22s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 2m 51s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 13m 3s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 56s | patch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 49s | hbase-http generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -1 :x: | spotbugs | 12m 20s | root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. | | | | 88m 15s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-http | | | Possible null pointer dereference in org.apache.hadoop.hbase.http.HttpServer.addDefaultServlets(ContextHandlerCollection, Configuration) due to return value of called method Dereferenced at HttpServer.java:org.apache.hadoop.hbase.http.HttpServer.addDefaultServlets(ContextHandlerCollection, Configuration) due to return value of called method Dereferenced at HttpServer.java:[line 796] | | FindBugs | module:root | | | Possible null pointer dereference in org.apache.hadoop.hbase.http.HttpServer.addDefaultServlets(ContextHandlerCollection, Configuration) due to return value of called method Dereferenced at HttpServer.java:org.apache.hadoop.hbase.http.HttpServer.addDefaultServlets(ContextHandlerCollection, Configuration) due to return value of called method Dereferenced at HttpServer.java:[line 796] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4691 | | Optional Tests | dupname asflicense javac refguide spotless xml spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8e01b97d038f 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4691/5/yetus-general-check/output/branch-site/book.html | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4691/5/yetus-general-check/output/patch-site/book.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/5/artifact/yetus-general-check/output/new-spotbugs-hbase-http.html | | spotbugs |
[GitHub] [hbase] lucakovacs commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
lucakovacs commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1218496467 > No big problem. Just some style nits. Fixed them :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4712: HBASE-26969:Eliminate MOB renames when SFT is enabled
Apache-HBase commented on PR #4712: URL: https://github.com/apache/hbase/pull/4712#issuecomment-1218490921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 33s | branch-2 passed | | +1 :green_heart: | compile | 0m 47s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 56s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 36s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 3m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 227m 6s | hbase-server in the patch passed. | | | | 245m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4712 | | JIRA Issue | HBASE-26969 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 204239e67aec 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1986a6ec31 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/testReport/ | | Max. process+thread count | 2337 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27294) Add new hadoop releases in our hadoop checks
[
https://issues.apache.org/jira/browse/HBASE-27294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581014#comment-17581014
]
Hudson commented on HBASE-27294:
Results for branch branch-2.5
[build #188 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/188/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/188/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/188/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/188/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/188//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add new hadoop releases in our hadoop checks
>
>
> Key: HBASE-27294
> URL: https://issues.apache.org/jira/browse/HBASE-27294
> Project: HBase
> Issue Type: Task
> Components: scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> 3.1.3, 3.1.4
> 3.2.3, 3.2.4
> 3.3.2,3.3.3,3.3.4
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4712: HBASE-26969:Eliminate MOB renames when SFT is enabled
Apache-HBase commented on PR #4712: URL: https://github.com/apache/hbase/pull/4712#issuecomment-1218463918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 11s | branch-2 passed | | +1 :green_heart: | compile | 0m 39s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | shadedjars | 3m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 195m 54s | hbase-server in the patch passed. | | | | 212m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4712 | | JIRA Issue | HBASE-26969 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 84f3db86f26c 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1986a6ec31 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/testReport/ | | Max. process+thread count | 2656 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26969) Eliminate MOB renames when SFT is enabled
[
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26969:
-
Fix Version/s: 2.6.0
2.5.1
(was: 2.5.0)
> Eliminate MOB renames when SFT is enabled
> -
>
> Key: HBASE-26969
> URL: https://issues.apache.org/jira/browse/HBASE-26969
> Project: HBase
> Issue Type: Sub-task
> Components: mob
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> MOB file compaction and flush still relies on renames even when SFT is
> enabled.
> My proposed changes are:
> * when requireWritingToTmpDirFirst is false during mob flush/compact instead
> of using the temp writer we should create a different writer using a
> {color:#00}StoreFileWriterCreationTracker that writes directly to the mob
> store folder{color}
> * {color:#00}these StoreFileWriterCreationTracker should be stored in
> the MobStore. This would requires us to extend MobStore with a createWriter
> and a finalizeWriter method to handle this{color}
> * {color:#00}refactor {color}MobFileCleanerChore to run on the RS
> instead on Master to allow access to the
> {color:#00}StoreFileWriterCreationTracker{color}s to make sure the
> currently written files are not cleaned up
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27154) Backport missing MOB related changes to branch-2
[ https://issues.apache.org/jira/browse/HBASE-27154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27154: - Fix Version/s: 2.6.0 2.5.1 (was: 2.5.0) > Backport missing MOB related changes to branch-2 > > > Key: HBASE-27154 > URL: https://issues.apache.org/jira/browse/HBASE-27154 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.6.0 >Reporter: Szabolcs Bukros >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.6.0, 2.5.1 > > > While trying to backport https://issues.apache.org/jira/browse/HBASE-26969 to > branch-2 I have found that multiple major MOB related changes are missing. > This change is required for FileBased SFT correctness so the changes it > depends on should be backported first. Also any improvement to MOB stability > is usually welcomed. > The missing changes I have found so far: > https://issues.apache.org/jira/browse/HBASE-22749 > https://issues.apache.org/jira/browse/HBASE-23723 > https://issues.apache.org/jira/browse/HBASE-24163 > There is also a docs change describing the new MOB functionality. But > considering that the book is always generated based on master I think it is > safe to skip backporting it. > https://issues.apache.org/jira/browse/HBASE-23198 > I'm planning to backport these changes one by one until we reach a state > where HBASE-26969 can be backported too. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27206) Clean up error-prone findings in hbase-common
[ https://issues.apache.org/jira/browse/HBASE-27206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27206: - Fix Version/s: 2.6.0 2.5.1 (was: 2.5.0) > Clean up error-prone findings in hbase-common > - > > Key: HBASE-27206 > URL: https://issues.apache.org/jira/browse/HBASE-27206 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27252) Clean up error-prone findings in hbase-it
[ https://issues.apache.org/jira/browse/HBASE-27252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27252: - Fix Version/s: 2.6.0 2.5.1 (was: 2.5.0) > Clean up error-prone findings in hbase-it > - > > Key: HBASE-27252 > URL: https://issues.apache.org/jira/browse/HBASE-27252 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27234) Clean up error-prone findings in hbase-examples
[ https://issues.apache.org/jira/browse/HBASE-27234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27234: - Fix Version/s: 2.6.0 2.5.1 (was: 2.5.0) > Clean up error-prone findings in hbase-examples > --- > > Key: HBASE-27234 > URL: https://issues.apache.org/jira/browse/HBASE-27234 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27294) Add new hadoop releases in our hadoop checks
[
https://issues.apache.org/jira/browse/HBASE-27294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580968#comment-17580968
]
Hudson commented on HBASE-27294:
Results for branch master
[build #660 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/660/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/660/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/660/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/660//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add new hadoop releases in our hadoop checks
>
>
> Key: HBASE-27294
> URL: https://issues.apache.org/jira/browse/HBASE-27294
> Project: HBase
> Issue Type: Task
> Components: scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> 3.1.3, 3.1.4
> 3.2.3, 3.2.4
> 3.3.2,3.3.3,3.3.4
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27279) Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler
[
https://issues.apache.org/jira/browse/HBASE-27279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580967#comment-17580967
]
Hudson commented on HBASE-27279:
Results for branch master
[build #660 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/660/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/660/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/660/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/660//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler
> ---
>
> Key: HBASE-27279
> URL: https://issues.apache.org/jira/browse/HBASE-27279
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC, security
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Though this is not recommended as SslHandler has already done wrap/unwrap, it
> is still better to make it work(maybe we could add some warning logs to say
> this is unnecessary?) than fail with strange error message.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4709: add an option to skip file splitting when bulkload hfiles
Apache-HBase commented on PR #4709: URL: https://github.com/apache/hbase/pull/4709#issuecomment-1218336251 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 4m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 231m 0s | hbase-server in the patch passed. | | | | 253m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4709 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 06da379c3aeb 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/testReport/ | | Max. process+thread count | 2839 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4709: add an option to skip file splitting when bulkload hfiles
Apache-HBase commented on PR #4709: URL: https://github.com/apache/hbase/pull/4709#issuecomment-1218334628 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 51s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | shadedjars | 4m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 5m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 231m 9s | hbase-server in the patch failed. | | | | 251m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4709 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0a96e15d4281 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/testReport/ | | Max. process+thread count | 2631 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4712: HBASE-26969:Eliminate MOB renames when SFT is enabled
Apache-HBase commented on PR #4712: URL: https://github.com/apache/hbase/pull/4712#issuecomment-1218305021 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 21s | branch-2 passed | | +1 :green_heart: | compile | 2m 17s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 32s | branch-2 passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 19s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 2m 15s | the patch passed | | +1 :green_heart: | javac | 2m 15s | the patch passed | | -0 :warning: | checkstyle | 0m 32s | hbase-server: The patch generated 2 new + 19 unchanged - 0 fixed = 21 total (was 19) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 6s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 28m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4712 | | JIRA Issue | HBASE-26969 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 57a298ae6530 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1986a6ec31 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 65 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4712: HBASE-26969:Eliminate MOB renames when SFT is enabled
Apache-HBase commented on PR #4712: URL: https://github.com/apache/hbase/pull/4712#issuecomment-1218275862 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 3s | branch-2 passed | | +1 :green_heart: | compile | 0m 47s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 38s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 3m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 213m 48s | hbase-server in the patch failed. | | | | 233m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4712 | | JIRA Issue | HBASE-26969 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a0511d8a1d5c 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1986a6ec31 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/testReport/ | | Max. process+thread count | 2367 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4712: HBASE-26969:Eliminate MOB renames when SFT is enabled
Apache-HBase commented on PR #4712: URL: https://github.com/apache/hbase/pull/4712#issuecomment-1218254921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 22s | branch-2 passed | | +1 :green_heart: | compile | 0m 39s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 12s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | shadedjars | 3m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 196m 20s | hbase-server in the patch passed. | | | | 212m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4712 | | JIRA Issue | HBASE-26969 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dd0324044cba 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1986a6ec31 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/testReport/ | | Max. process+thread count | 2629 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27214) Implement the new replication hfile/log cleaner
[ https://issues.apache.org/jira/browse/HBASE-27214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580858#comment-17580858 ] Duo Zhang commented on HBASE-27214: --- After reconsideration, I think AddPeerProcedure could have race with ReplicationLogCleaner. Think of this scenario: 1. ReplicationLogCleaner starts, and we load the current replication peers. 2. AddPeerProcedure added a new replication peer in disabled state. 3. The region server rolls a new wal file, and all other replication peers have finished replicate it, so the ReplicationLogCleaner decides to delete the wal file. 4. But actually, the peer added in #2 still needs to replicate this wal file, and cause trouble. The problem here is that, in #3 we do not know there is a new peer added in #2. We could load the replication peers every time when we want to decide whether to delete file, but since there is no fence, theoretically after we reload the replication peers, it is still possible that, a new peer is added, and a wal roll happens and then lead us to the same situation. A possible solution here is to add a barrier to not allow AddPeerProcedure and ReplicationLogCleaner run at the same time. Will try to see if there are other better solutions. Thanks. > Implement the new replication hfile/log cleaner > --- > > Key: HBASE-27214 > URL: https://issues.apache.org/jira/browse/HBASE-27214 > Project: HBase > Issue Type: Sub-task > Components: master, Replication >Reporter: Duo Zhang >Assignee: LiangJun He >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4709: add an option to skip file splitting when bulkload hfiles
Apache-HBase commented on PR #4709: URL: https://github.com/apache/hbase/pull/4709#issuecomment-1218074793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 2m 15s | master passed | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 20s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 2m 15s | the patch passed | | -0 :warning: | javac | 2m 15s | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) | | +1 :green_heart: | checkstyle | 0m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 0s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 28m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4709 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux af1b7ea1972a 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4709/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27154) Backport missing MOB related changes to branch-2
[ https://issues.apache.org/jira/browse/HBASE-27154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580795#comment-17580795 ] Szabolcs Bukros commented on HBASE-27154: - [~ndimiduk] The PR is already up. > Backport missing MOB related changes to branch-2 > > > Key: HBASE-27154 > URL: https://issues.apache.org/jira/browse/HBASE-27154 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.6.0 >Reporter: Szabolcs Bukros >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.5.0 > > > While trying to backport https://issues.apache.org/jira/browse/HBASE-26969 to > branch-2 I have found that multiple major MOB related changes are missing. > This change is required for FileBased SFT correctness so the changes it > depends on should be backported first. Also any improvement to MOB stability > is usually welcomed. > The missing changes I have found so far: > https://issues.apache.org/jira/browse/HBASE-22749 > https://issues.apache.org/jira/browse/HBASE-23723 > https://issues.apache.org/jira/browse/HBASE-24163 > There is also a docs change describing the new MOB functionality. But > considering that the book is always generated based on master I think it is > safe to skip backporting it. > https://issues.apache.org/jira/browse/HBASE-23198 > I'm planning to backport these changes one by one until we reach a state > where HBASE-26969 can be backported too. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4712: HBASE-26969:Eliminate MOB renames when SFT is enabled
Apache-HBase commented on PR #4712: URL: https://github.com/apache/hbase/pull/4712#issuecomment-1218018429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 33s | branch-2 passed | | +1 :green_heart: | compile | 2m 16s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 33s | branch-2 passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 19s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 2m 14s | the patch passed | | +1 :green_heart: | javac | 2m 14s | the patch passed | | -0 :warning: | checkstyle | 0m 30s | hbase-server: The patch generated 2 new + 19 unchanged - 0 fixed = 21 total (was 19) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 6s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | -1 :x: | spotless | 0m 34s | patch has 37 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 1m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 29m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4712 | | JIRA Issue | HBASE-26969 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 690717d17950 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 1986a6ec31 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 62 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4712/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27154) Backport missing MOB related changes to branch-2
[ https://issues.apache.org/jira/browse/HBASE-27154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580782#comment-17580782 ] Nick Dimiduk commented on HBASE-27154: -- [~bszabolcs] all three of the tickets you mentioned in the description have been backported. Mind giving HBASE-26969 another try? When you're satisfied, please resolve this ticket as well. Thanks. > Backport missing MOB related changes to branch-2 > > > Key: HBASE-27154 > URL: https://issues.apache.org/jira/browse/HBASE-27154 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.6.0 >Reporter: Szabolcs Bukros >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.5.0 > > > While trying to backport https://issues.apache.org/jira/browse/HBASE-26969 to > branch-2 I have found that multiple major MOB related changes are missing. > This change is required for FileBased SFT correctness so the changes it > depends on should be backported first. Also any improvement to MOB stability > is usually welcomed. > The missing changes I have found so far: > https://issues.apache.org/jira/browse/HBASE-22749 > https://issues.apache.org/jira/browse/HBASE-23723 > https://issues.apache.org/jira/browse/HBASE-24163 > There is also a docs change describing the new MOB functionality. But > considering that the book is always generated based on master I think it is > safe to skip backporting it. > https://issues.apache.org/jira/browse/HBASE-23198 > I'm planning to backport these changes one by one until we reach a state > where HBASE-26969 can be backported too. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (HBASE-26969) Eliminate MOB renames when SFT is enabled
[
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580779#comment-17580779
]
Szabolcs Bukros edited comment on HBASE-26969 at 8/17/22 1:10 PM:
--
[~apurtell] [~huaxiangsun] Please find
[#4712|https://github.com/apache/hbase/pull/4712] with the branch-2 backport.
Please note I made some additional changes in this PR:
* [#4617|https://github.com/apache/hbase/pull/4617] left 2 test classes in
the code that the original commit deleted and I had to delete them here.
* HBASE-25970 is another dependency I missed in HBASE-27154. To shorten the
review cycles instead of backporting it separately I included the changes it
contained in this PR. Please let me know if that would not be acceptable and I
prepare a separate PR for that backport.
was (Author: bszabolcs):
[~apurtell] [~huaxiangsun] Please find
[#4712|https://github.com/apache/hbase/pull/4712] with the branch-2 backport.
Please note I made some additional changes:
* [#4617|https://github.com/apache/hbase/pull/4617] left 2 test classes in
the code that the original commit deleted and I had to delete them here.
* HBASE-25970 is another dependency I missed in HBASE-27154. To shorten the
review cycles instead of backporting it separately I included the changes it
contained in this PR. Please let me know if that would not be acceptable and I
prepare a separate PR for that backport.
> Eliminate MOB renames when SFT is enabled
> -
>
> Key: HBASE-26969
> URL: https://issues.apache.org/jira/browse/HBASE-26969
> Project: HBase
> Issue Type: Sub-task
> Components: mob
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> MOB file compaction and flush still relies on renames even when SFT is
> enabled.
> My proposed changes are:
> * when requireWritingToTmpDirFirst is false during mob flush/compact instead
> of using the temp writer we should create a different writer using a
> {color:#00}StoreFileWriterCreationTracker that writes directly to the mob
> store folder{color}
> * {color:#00}these StoreFileWriterCreationTracker should be stored in
> the MobStore. This would requires us to extend MobStore with a createWriter
> and a finalizeWriter method to handle this{color}
> * {color:#00}refactor {color}MobFileCleanerChore to run on the RS
> instead on Master to allow access to the
> {color:#00}StoreFileWriterCreationTracker{color}s to make sure the
> currently written files are not cleaned up
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (HBASE-26969) Eliminate MOB renames when SFT is enabled
[
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580779#comment-17580779
]
Szabolcs Bukros edited comment on HBASE-26969 at 8/17/22 1:09 PM:
--
[~apurtell] [~huaxiangsun] Please find
[#4712|https://github.com/apache/hbase/pull/4712] with the branch-2 backport.
Please note I made some additional changes:
* [#4617|https://github.com/apache/hbase/pull/4617] left 2 test classes in
the code that the original commit deleted and I had to delete them here.
* HBASE-25970 is another dependency I missed in HBASE-27154. To shorten the
review cycles instead of backporting it separately I included the changes it
contained in this PR. Please let me know if that would not be acceptable and I
prepare a separate PR for that backport.
was (Author: bszabolcs):
[~apurtell] [~huaxiangsun] Please find #4712 with the branch-2 backport.
Please note I made some additional changes:
* [#4617|https://github.com/apache/hbase/pull/4617] left 2 test classes in
the code that the original commit deleted and I had to delete them here.
* HBASE-25970 is another dependency I missed in HBASE-27154. To shorten the
review cycles instead of backporting it separately I included the changes it
contained in this PR. Please let me know if that would not be acceptable and I
prepare a separate PR for that backport.
> Eliminate MOB renames when SFT is enabled
> -
>
> Key: HBASE-26969
> URL: https://issues.apache.org/jira/browse/HBASE-26969
> Project: HBase
> Issue Type: Sub-task
> Components: mob
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> MOB file compaction and flush still relies on renames even when SFT is
> enabled.
> My proposed changes are:
> * when requireWritingToTmpDirFirst is false during mob flush/compact instead
> of using the temp writer we should create a different writer using a
> {color:#00}StoreFileWriterCreationTracker that writes directly to the mob
> store folder{color}
> * {color:#00}these StoreFileWriterCreationTracker should be stored in
> the MobStore. This would requires us to extend MobStore with a createWriter
> and a finalizeWriter method to handle this{color}
> * {color:#00}refactor {color}MobFileCleanerChore to run on the RS
> instead on Master to allow access to the
> {color:#00}StoreFileWriterCreationTracker{color}s to make sure the
> currently written files are not cleaned up
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-26969) Eliminate MOB renames when SFT is enabled
[
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580779#comment-17580779
]
Szabolcs Bukros commented on HBASE-26969:
-
[~apurtell] [~huaxiangsun] Please find #4712 with the branch-2 backport.
Please note I made some additional changes:
* [#4617|https://github.com/apache/hbase/pull/4617] left 2 test classes in
the code that the original commit deleted and I had to delete them here.
* HBASE-25970 is another dependency I missed in HBASE-27154. To shorten the
review cycles instead of backporting it separately I included the changes it
contained in this PR. Please let me know if that would not be acceptable and I
prepare a separate PR for that backport.
> Eliminate MOB renames when SFT is enabled
> -
>
> Key: HBASE-26969
> URL: https://issues.apache.org/jira/browse/HBASE-26969
> Project: HBase
> Issue Type: Sub-task
> Components: mob
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> MOB file compaction and flush still relies on renames even when SFT is
> enabled.
> My proposed changes are:
> * when requireWritingToTmpDirFirst is false during mob flush/compact instead
> of using the temp writer we should create a different writer using a
> {color:#00}StoreFileWriterCreationTracker that writes directly to the mob
> store folder{color}
> * {color:#00}these StoreFileWriterCreationTracker should be stored in
> the MobStore. This would requires us to extend MobStore with a createWriter
> and a finalizeWriter method to handle this{color}
> * {color:#00}refactor {color}MobFileCleanerChore to run on the RS
> instead on Master to allow access to the
> {color:#00}StoreFileWriterCreationTracker{color}s to make sure the
> currently written files are not cleaned up
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] BukrosSzabolcs opened a new pull request, #4712: HBASE-26969:Eliminate MOB renames when SFT is enabled
BukrosSzabolcs opened a new pull request, #4712: URL: https://github.com/apache/hbase/pull/4712 HBASE-25970:MOB data loss - incorrect concatenation of MOB_FILE_REFS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4710: HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime
Apache-HBase commented on PR #4710: URL: https://github.com/apache/hbase/pull/4710#issuecomment-1217945598 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 20s | master passed | | +1 :green_heart: | compile | 0m 51s | master passed | | +1 :green_heart: | shadedjars | 4m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 10s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 4m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 9s | hbase-client in the patch passed. | | -1 :x: | unit | 228m 46s | hbase-server in the patch failed. | | | | 249m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4710 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 163150b38fd3 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/testReport/ | | Max. process+thread count | 3010 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4710: HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime
Apache-HBase commented on PR #4710: URL: https://github.com/apache/hbase/pull/4710#issuecomment-1217921539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 31s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 3m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 18s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 204m 40s | hbase-server in the patch passed. | | | | 225m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4710 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b74940b5b206 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/testReport/ | | Max. process+thread count | 2355 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24163) MOB compactor implementations should use format specifiers when calling String.format
[ https://issues.apache.org/jira/browse/HBASE-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24163: - Fix Version/s: 2.5.0 > MOB compactor implementations should use format specifiers when calling > String.format > - > > Key: HBASE-24163 > URL: https://issues.apache.org/jira/browse/HBASE-24163 > Project: HBase > Issue Type: Bug > Components: Compaction, mob >Affects Versions: 3.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > > HBASE-23723 includes a few IOException message constructions that rely on > String.format but use slf4j parameters instead of format specifiers. > Discovered by nightly failing error-prone. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27154) Backport missing MOB related changes to branch-2
[ https://issues.apache.org/jira/browse/HBASE-27154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580757#comment-17580757 ] Nick Dimiduk commented on HBASE-27154: -- HBASE-24163 backport is complete. > Backport missing MOB related changes to branch-2 > > > Key: HBASE-27154 > URL: https://issues.apache.org/jira/browse/HBASE-27154 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.6.0 >Reporter: Szabolcs Bukros >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.5.0 > > > While trying to backport https://issues.apache.org/jira/browse/HBASE-26969 to > branch-2 I have found that multiple major MOB related changes are missing. > This change is required for FileBased SFT correctness so the changes it > depends on should be backported first. Also any improvement to MOB stability > is usually welcomed. > The missing changes I have found so far: > https://issues.apache.org/jira/browse/HBASE-22749 > https://issues.apache.org/jira/browse/HBASE-23723 > https://issues.apache.org/jira/browse/HBASE-24163 > There is also a docs change describing the new MOB functionality. But > considering that the book is always generated based on master I think it is > safe to skip backporting it. > https://issues.apache.org/jira/browse/HBASE-23198 > I'm planning to backport these changes one by one until we reach a state > where HBASE-26969 can be backported too. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-24163) MOB compactor implementations should use format specifiers when calling String.format
[ https://issues.apache.org/jira/browse/HBASE-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24163. -- Resolution: Fixed Merged to branch-2 and branch-2.5. > MOB compactor implementations should use format specifiers when calling > String.format > - > > Key: HBASE-24163 > URL: https://issues.apache.org/jira/browse/HBASE-24163 > Project: HBase > Issue Type: Bug > Components: Compaction, mob >Affects Versions: 3.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-1 > > > HBASE-23723 includes a few IOException message constructions that rely on > String.format but use slf4j parameters instead of format specifiers. > Discovered by nightly failing error-prone. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] ndimiduk merged pull request #4711: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2.5
ndimiduk merged PR #4711: URL: https://github.com/apache/hbase/pull/4711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (HBASE-24163) MOB compactor implementations should use format specifiers when calling String.format
[ https://issues.apache.org/jira/browse/HBASE-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24163: -- Reopened for branch-2.5+ banckports. > MOB compactor implementations should use format specifiers when calling > String.format > - > > Key: HBASE-24163 > URL: https://issues.apache.org/jira/browse/HBASE-24163 > Project: HBase > Issue Type: Bug > Components: Compaction, mob >Affects Versions: 3.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 3.0.0-alpha-1 > > > HBASE-23723 includes a few IOException message constructions that rely on > String.format but use slf4j parameters instead of format specifiers. > Discovered by nightly failing error-prone. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] ndimiduk opened a new pull request, #4711: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2.5
ndimiduk opened a new pull request, #4711: URL: https://github.com/apache/hbase/pull/4711 Signed-off-by: stack Signed-off-by: Viraj Jasani Signed-off-by: Josh Elser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
ndimiduk merged PR #4706: URL: https://github.com/apache/hbase/pull/4706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4706: Backport "HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format" to branch-2
ndimiduk commented on PR #4706: URL: https://github.com/apache/hbase/pull/4706#issuecomment-1217902425 Yep, I see that. I wonder what patch brought in the bug that this one fixed on master, it apparently hasn't been back ported to branch-2 yet. Anyway, I'll continue this backport so that the active release lines remain fairly similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27214) Implement the new replication hfile/log cleaner
[ https://issues.apache.org/jira/browse/HBASE-27214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27214: -- Summary: Implement the new replication hfile/log cleaner (was: Implement the new replication log cleaner) > Implement the new replication hfile/log cleaner > --- > > Key: HBASE-27214 > URL: https://issues.apache.org/jira/browse/HBASE-27214 > Project: HBase > Issue Type: Sub-task > Components: master, Replication >Reporter: Duo Zhang >Assignee: LiangJun He >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4710: HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime
Apache-HBase commented on PR #4710: URL: https://github.com/apache/hbase/pull/4710#issuecomment-1217704459 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 23s | master passed | | +1 :green_heart: | compile | 2m 47s | master passed | | +1 :green_heart: | checkstyle | 0m 40s | master passed | | +1 :green_heart: | spotless | 0m 38s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 2m 46s | the patch passed | | +1 :green_heart: | javac | 2m 46s | the patch passed | | +1 :green_heart: | checkstyle | 0m 40s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 11s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 2s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 31m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4710 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux d963c43ffeef 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 116458ab04 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4710/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580666#comment-17580666
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #3 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/3/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/3/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/3/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/3/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] zhuyaogai commented on a diff in pull request #4710: HBASE-27268 In trace log mode, the client does not print callId/startTime and the server does not print receiveTime
zhuyaogai commented on code in PR #4710:
URL: https://github.com/apache/hbase/pull/4710#discussion_r947581922
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java:
##
@@ -380,7 +380,8 @@ private void onCallFinished(Call call, HBaseRpcController
hrc, Address addr,
}
if (LOG.isTraceEnabled()) {
LOG.trace(
-"Call: " + call.md.getName() + ", callTime: " +
call.callStats.getCallTimeMs() + "ms");
+"CallId: {}, call: {}, startTime: {}ms, callTime: {}ms", call.id,
call.getStartTime(),
Review Comment:
Sorry, i will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache9 commented on code in PR #4691:
URL: https://github.com/apache/hbase/pull/4691#discussion_r947551006
##
hbase-hadoop-compat/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsExportHelper.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.metrics;
+
+import java.util.Collection;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.testclassification.MetricsTests;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.apache.hadoop.metrics2.AbstractMetric;
+import org.apache.hadoop.metrics2.MetricsRecord;
+import org.apache.hadoop.metrics2.impl.MetricsExportHelper;
+import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
+import org.junit.Assert;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category({ MetricsTests.class, SmallTests.class })
+public class TestMetricsExportHelper {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestMetricsExportHelper.class);
+
+ @Test
+ public void testExportHelper() {
+DefaultMetricsSystem.initialize("exportHelperTestSystem");
+DefaultMetricsSystem.instance().start();
+
+String metricsName = "exportMetricsTestGrp";
+String gaugeName = "exportMetricsTestGauge";
+String counterName = "exportMetricsTestCounter";
+
+BaseSourceImpl baseSource = new BaseSourceImpl(metricsName, "",
metricsName, metricsName);
+
+baseSource.setGauge(gaugeName, 0);
+baseSource.incCounters(counterName, 1);
+
+Collection metrics = MetricsExportHelper.export();
+DefaultMetricsSystem.instance().stop();
+
+Assert.assertTrue(metrics.stream().anyMatch(mr ->
mr.name().equals(metricsName)));
+Assert.assertTrue(gaugeName + " is missing in the export",
+ contains(metrics, metricsName, gaugeName));
+Assert.assertTrue(counterName + " is missing in the export",
+ contains(metrics, metricsName, counterName));
+ }
+
+ private boolean contains(Collection metrics, String
metricsName,
+String metricName) {
+return metrics.stream().filter(mr ->
mr.name().equals(metricsName)).anyMatch(mr -> {
+ for (AbstractMetric metric : mr.metrics()) {
+if (metric.name().equals(metricName)) return true;
Review Comment:
New line with '{}', otherwise there will be a checkstyle warning.
##
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:
##
@@ -784,6 +788,20 @@ protected void addDefaultServlets(ContextHandlerCollection
contexts, Configurati
LOG.info("ASYNC_PROFILER_HOME environment variable and
async.profiler.home system property "
+ "not specified. Disabling /prof endpoint.");
}
+
+/* register metrics servlets */
+String enabledServlets[] = conf.getStrings(METRIC_SERVLETS_CONF_KEY,
METRICS_SERVLETS_DEFAULT);
Review Comment:
`String enabledServlets[]` -> `String[] enabledServlets`
##
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:
##
@@ -154,6 +153,20 @@ public class HttpServer implements FilterContainer {
public static final String NO_CACHE_FILTER = "NoCacheFilter";
public static final String APP_DIR = "webapps";
+ public static final String METRIC_SERVLETS_CONF_KEY =
"hbase.http.metrics.servlets";
+ public static final String METRICS_SERVLETS_DEFAULT[] = { "jmx", "metrics",
"prometheus" };
Review Comment:
`String METRICS_SERVLETS_DEFAULT[]` -> `String[] METRICS_SERVLETS_DEFAULT`
##
hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/impl/MetricsExportHelper.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
[jira] [Commented] (HBASE-27294) Add new hadoop releases in our hadoop checks
[
https://issues.apache.org/jira/browse/HBASE-27294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580606#comment-17580606
]
Hudson commented on HBASE-27294:
Results for branch branch-2
[build #619 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add new hadoop releases in our hadoop checks
>
>
> Key: HBASE-27294
> URL: https://issues.apache.org/jira/browse/HBASE-27294
> Project: HBase
> Issue Type: Task
> Components: scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> 3.1.3, 3.1.4
> 3.2.3, 3.2.4
> 3.3.2,3.3.3,3.3.4
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27279) Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler
[
https://issues.apache.org/jira/browse/HBASE-27279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580605#comment-17580605
]
Hudson commented on HBASE-27279:
Results for branch branch-2
[build #619 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler
> ---
>
> Key: HBASE-27279
> URL: https://issues.apache.org/jira/browse/HBASE-27279
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC, security
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Though this is not recommended as SslHandler has already done wrap/unwrap, it
> is still better to make it work(maybe we could add some warning logs to say
> this is unnecessary?) than fail with strange error message.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27264) Add options to consider compressed size when delimiting blocks during hfile writes
[
https://issues.apache.org/jira/browse/HBASE-27264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580604#comment-17580604
]
Hudson commented on HBASE-27264:
Results for branch branch-2
[build #619 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/619/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add options to consider compressed size when delimiting blocks during hfile
> writes
> --
>
> Key: HBASE-27264
> URL: https://issues.apache.org/jira/browse/HBASE-27264
> Project: HBase
> Issue Type: New Feature
>Affects Versions: 3.0.0-alpha-4
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> In HBASE-27232 we had modified "hbase.writer.unified.encoded.blocksize.ratio"
> property soo that it can allow for the encoded size to be considered when
> delimiting hfiles blocks during writes.
> -Here we propose two additional
> properties,"hbase.block.size.limit.compressed" and
> "hbase.block.size.max.compressed" that would allow for consider the
> compressed size (if compression is in use) for delimiting blocks during hfile
> writing. When compression is enabled, certain datasets can have very high
> compression efficiency, so that the default 64KB block size and 10GB max file
> size can lead to hfiles with very large number of blocks.-
> -In this proposal, "hbase.block.size.limit.compressed" is a boolean flag that
> switches to compressed size for delimiting blocks, and
> "hbase.block.size.max.compressed" is an int with the limit, in bytes for the
> compressed block size, in order to avoid very large uncompressed blocks
> (defaulting to 320KB).-
> Note: As of 15/08/2022, the original proposal above has been modified to
> define a pluggable strategy for predicating block compression rate. Please
> refer to the release notes for more details.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
