[jira] [Commented] (HBASE-27089) Add “commons.crypto.stream.buffer.size” configuration
[
https://issues.apache.org/jira/browse/HBASE-27089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582747#comment-17582747
]
Hudson commented on HBASE-27089:
Results for branch branch-2
[build #623 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add “commons.crypto.stream.buffer.size” configuration
> --
>
> Key: HBASE-27089
> URL: https://issues.apache.org/jira/browse/HBASE-27089
> Project: HBase
> Issue Type: Improvement
> Components: io
>Reporter: wenweijian
>Assignee: wenweijian
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> Add “commons.crypto.stream.buffer.size” configuration in hbase when doing
> encryption through commonsCryptoAES.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27206) Clean up error-prone findings in hbase-common
[
https://issues.apache.org/jira/browse/HBASE-27206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582746#comment-17582746
]
Hudson commented on HBASE-27206:
Results for branch branch-2
[build #623 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/623/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up error-prone findings in hbase-common
> -
>
> Key: HBASE-27206
> URL: https://issues.apache.org/jira/browse/HBASE-27206
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27089) Add “commons.crypto.stream.buffer.size” configuration
[
https://issues.apache.org/jira/browse/HBASE-27089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582733#comment-17582733
]
Hudson commented on HBASE-27089:
Results for branch branch-2.4
[build #413 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/413/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/413/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/413/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/413/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/413/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add “commons.crypto.stream.buffer.size” configuration
> --
>
> Key: HBASE-27089
> URL: https://issues.apache.org/jira/browse/HBASE-27089
> Project: HBase
> Issue Type: Improvement
> Components: io
>Reporter: wenweijian
>Assignee: wenweijian
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> Add “commons.crypto.stream.buffer.size” configuration in hbase when doing
> encryption through commonsCryptoAES.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4698: HBASE-27238 backport backup restore to 2.x
Apache-HBase commented on PR #4698: URL: https://github.com/apache/hbase/pull/4698#issuecomment-1221754004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 42s | branch-2.5 passed | | +1 :green_heart: | compile | 7m 54s | branch-2.5 passed | | +1 :green_heart: | checkstyle | 1m 12s | branch-2.5 passed | | +1 :green_heart: | spotless | 0m 46s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 12m 5s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 8m 14s | the patch passed | | +1 :green_heart: | cc | 8m 14s | the patch passed | | -0 :warning: | javac | 8m 14s | root generated 47 new + 1156 unchanged - 0 fixed = 1203 total (was 1156) | | +1 :green_heart: | checkstyle | 1m 7s | the patch passed | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 15m 9s | Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 5m 42s | the patch passed | | +1 :green_heart: | spotless | 1m 7s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 17m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. | | | | 87m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4698 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 67ca2b41ff65 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / eff5053f99 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/9/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 138 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/9/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27129) Add a config that allows us to configure region-level storage policies
[
https://issues.apache.org/jira/browse/HBASE-27129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-27129:
--
Component/s: regionserver
> Add a config that allows us to configure region-level storage policies
> --
>
> Key: HBASE-27129
> URL: https://issues.apache.org/jira/browse/HBASE-27129
> Project: HBase
> Issue Type: New Feature
> Components: regionserver
>Reporter: tianhang tang
>Assignee: tianhang tang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
>
> hbase.hregion.block.storage.policy
> HOT|ALL_SSD|...
>
> With this config, we can set region-level storage policies.
>
> We have this config about CF storage policy:
> {code:java}
>
> hbase.hstore.block.storage.policy
> ALL_SSD
>
> {code}
> But in addition to CF, we also have some other path under region path, such
> like .splits,
> recovered.edits, .tmp .
> So i want to add a region-level config which could cover the whole path, and
> if you have any other requirements for the cf directory, you can continue to
> use the previous hbase.hstore.block.storage.policy to specify them separately.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HBASE-27129) Add a config that allows us to configure region-level storage policies
[
https://issues.apache.org/jira/browse/HBASE-27129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-27129.
---
Fix Version/s: 2.5.0
3.0.0-alpha-4
2.4.14
Hadoop Flags: Reviewed
Release Note: Add a 'hbase.hregion.block.storage.policy' so you can config
storage policy at region level. This is useful when you want to control the
storage policy for the directories other than CF directories, such as .splits,
.recovered.edits, etc.
Resolution: Fixed
Pushed to branch-2.5+.
Thanks [~tangtianhang] for contributing!
> Add a config that allows us to configure region-level storage policies
> --
>
> Key: HBASE-27129
> URL: https://issues.apache.org/jira/browse/HBASE-27129
> Project: HBase
> Issue Type: New Feature
>Reporter: tianhang tang
>Assignee: tianhang tang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
>
> hbase.hregion.block.storage.policy
> HOT|ALL_SSD|...
>
> With this config, we can set region-level storage policies.
>
> We have this config about CF storage policy:
> {code:java}
>
> hbase.hstore.block.storage.policy
> ALL_SSD
>
> {code}
> But in addition to CF, we also have some other path under region path, such
> like .splits,
> recovered.edits, .tmp .
> So i want to add a region-level config which could cover the whole path, and
> if you have any other requirements for the cf directory, you can continue to
> use the previous hbase.hstore.block.storage.policy to specify them separately.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on a diff in pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore
Apache9 commented on code in PR #4533:
URL: https://github.com/apache/hbase/pull/4533#discussion_r950951328
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOpenRegionFailedMemoryLeak.java:
##
@@ -60,6 +63,14 @@ public class TestOpenRegionFailedMemoryLeak {
private static HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();
+ @BeforeClass
+ public static void startCluster() throws Exception {
+Configuration conf = TEST_UTIL.getConfiguration();
+
+// Enable sanity check for coprocessor
+conf.setBoolean(TableDescriptorChecker.TABLE_SANITY_CHECKS, true);
Review Comment:
OK, seems to have some side effects. Need to fill a release note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore
Apache9 commented on code in PR #4533: URL: https://github.com/apache/hbase/pull/4533#discussion_r950950467 ## hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java: ## @@ -185,11 +175,6 @@ public static void sanityCheck(final Configuration c, final TableDescriptor td) warnOrThrowExceptionForFailure(logWarn, message, null); Review Comment: Ah, OK, in unchanged code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4547: HBASE-27129 Add a config that allows us to configure region-level sto…
Apache9 merged PR #4547: URL: https://github.com/apache/hbase/pull/4547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4697: HBASE-27297 "HBASE-26810 Add dynamic configuration support for system…
Apache9 commented on PR #4697: URL: https://github.com/apache/hbase/pull/4697#issuecomment-1221700308 Let's just reopen HBASE-26882 and use that issue to land this change? It is a bit weird that HBASE-26882 has been committed to branch-2 and branch-2.4 but no branch-2.5? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4714: HBASE-27104 Add a tool command list_unknownservers
Apache-HBase commented on PR #4714: URL: https://github.com/apache/hbase/pull/4714#issuecomment-1221621011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 45s | branch-2 passed | | +1 :green_heart: | compile | 1m 58s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 4s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 35s | the patch passed | | +1 :green_heart: | compile | 1m 59s | the patch passed | | +1 :green_heart: | javac | 1m 59s | the patch passed | | +1 :green_heart: | shadedjars | 3m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 34s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 2m 51s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 196m 9s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 9m 20s | hbase-shell in the patch passed. | | | | 231m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4714 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 491fdfd34271 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f509e43eaa | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/testReport/ | | Max. process+thread count | 2779 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4714: HBASE-27104 Add a tool command list_unknownservers
Apache-HBase commented on PR #4714: URL: https://github.com/apache/hbase/pull/4714#issuecomment-1221620860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 33s | branch-2 passed | | +1 :green_heart: | compile | 1m 34s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 56s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 1m 35s | the patch passed | | +1 :green_heart: | javac | 1m 35s | the patch passed | | +1 :green_heart: | shadedjars | 4m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 23s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 2m 33s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 197m 57s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 8m 0s | hbase-shell in the patch passed. | | | | 230m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4714 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1a94526b9661 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f509e43eaa | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/testReport/ | | Max. process+thread count | 2485 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27252) Clean up error-prone findings in hbase-it
[
https://issues.apache.org/jira/browse/HBASE-27252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582624#comment-17582624
]
Hudson commented on HBASE-27252:
Results for branch branch-2.5
[build #191 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up error-prone findings in hbase-it
> -
>
> Key: HBASE-27252
> URL: https://issues.apache.org/jira/browse/HBASE-27252
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27234) Clean up error-prone findings in hbase-examples
[
https://issues.apache.org/jira/browse/HBASE-27234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582625#comment-17582625
]
Hudson commented on HBASE-27234:
Results for branch branch-2.5
[build #191 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up error-prone findings in hbase-examples
> ---
>
> Key: HBASE-27234
> URL: https://issues.apache.org/jira/browse/HBASE-27234
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27268) In trace log mode, the client does not print callId/startTime and the server does not print receiveTime
[
https://issues.apache.org/jira/browse/HBASE-27268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582623#comment-17582623
]
Hudson commented on HBASE-27268:
Results for branch branch-2.5
[build #191 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/191/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> In trace log mode, the client does not print callId/startTime and the server
> does not print receiveTime
> ---
>
> Key: HBASE-27268
> URL: https://issues.apache.org/jira/browse/HBASE-27268
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: zhuyaogai
>Assignee: zhuyaogai
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> *Question:*
> In some scenarios in the production environment, users find that the request
> latancy is high on the client side, but it is not high on the server side
> (all through the internal monitor system). In this inconsistent scenario, we
> want to know if there is a problem with the client or the current network.
> Therefore, we want to know the time when the server receives the request.
> However, in Trace mode, no relevant information is printed.
>
> A possible solution is that the client prints callId (so we can associate the
> corresponding request on the server) and startTime about the request，and the
> server prints receiveTime about the request. In this way, we can find out at
> what stage the problem occurs.
>
> The client can even wrap the startTime in the request, and the server can
> directly collect the time at the network level (netty framework process time
> and network transmission time and so on) which make it easy to monitor some
> network level metrics about the client requests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27104) Add a tool command list_unknownservers
[
https://issues.apache.org/jira/browse/HBASE-27104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582618#comment-17582618
]
Hudson commented on HBASE-27104:
Results for branch master
[build #662 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add a tool command list_unknownservers
> --
>
> Key: HBASE-27104
> URL: https://issues.apache.org/jira/browse/HBASE-27104
> Project: HBase
> Issue Type: New Feature
> Components: master
>Affects Versions: 3.0.0-alpha-3
>Reporter: LiangJun He
>Assignee: LiangJun He
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
> Attachments: image-2022-06-10-15-49-33-178.png
>
>
> Sometimes, RegionServer will become an unknown server. It is necessary to add
> a tool command to list unknown servers.
> !image-2022-06-10-15-49-33-178.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27234) Clean up error-prone findings in hbase-examples
[
https://issues.apache.org/jira/browse/HBASE-27234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582620#comment-17582620
]
Hudson commented on HBASE-27234:
Results for branch master
[build #662 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up error-prone findings in hbase-examples
> ---
>
> Key: HBASE-27234
> URL: https://issues.apache.org/jira/browse/HBASE-27234
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27268) In trace log mode, the client does not print callId/startTime and the server does not print receiveTime
[
https://issues.apache.org/jira/browse/HBASE-27268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582617#comment-17582617
]
Hudson commented on HBASE-27268:
Results for branch master
[build #662 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> In trace log mode, the client does not print callId/startTime and the server
> does not print receiveTime
> ---
>
> Key: HBASE-27268
> URL: https://issues.apache.org/jira/browse/HBASE-27268
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Affects Versions: 2.5.0, 3.0.0-alpha-3
>Reporter: zhuyaogai
>Assignee: zhuyaogai
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> *Question:*
> In some scenarios in the production environment, users find that the request
> latancy is high on the client side, but it is not high on the server side
> (all through the internal monitor system). In this inconsistent scenario, we
> want to know if there is a problem with the client or the current network.
> Therefore, we want to know the time when the server receives the request.
> However, in Trace mode, no relevant information is printed.
>
> A possible solution is that the client prints callId (so we can associate the
> corresponding request on the server) and startTime about the request，and the
> server prints receiveTime about the request. In this way, we can find out at
> what stage the problem occurs.
>
> The client can even wrap the startTime in the request, and the server can
> directly collect the time at the network level (netty framework process time
> and network transmission time and so on) which make it easy to monitor some
> network level metrics about the client requests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27252) Clean up error-prone findings in hbase-it
[
https://issues.apache.org/jira/browse/HBASE-27252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582619#comment-17582619
]
Hudson commented on HBASE-27252:
Results for branch master
[build #662 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/662/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up error-prone findings in hbase-it
> -
>
> Key: HBASE-27252
> URL: https://issues.apache.org/jira/browse/HBASE-27252
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4698: HBASE-27238 backport backup restore to 2.x
Apache-HBase commented on PR #4698: URL: https://github.com/apache/hbase/pull/4698#issuecomment-1221597886 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 6s | branch-2.5 passed | | +1 :green_heart: | compile | 1m 37s | branch-2.5 passed | | +1 :green_heart: | shadedjars | 3m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 31s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 6s | the patch passed | | +1 :green_heart: | compile | 1m 34s | the patch passed | | +1 :green_heart: | javac | 1m 34s | the patch passed | | +1 :green_heart: | shadedjars | 3m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 48s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 313m 19s | root in the patch failed. | | | | 337m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4698 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5c8bf5e2ecb6 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 8c92a5d4d3 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/testReport/ | | Max. process+thread count | 3881 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4714: HBASE-27104 Add a tool command list_unknownservers
Apache-HBase commented on PR #4714: URL: https://github.com/apache/hbase/pull/4714#issuecomment-1221594454 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 15s | branch-2 passed | | +1 :green_heart: | compile | 5m 30s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 10s | branch-2 passed | | +1 :green_heart: | spotless | 0m 48s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 4m 41s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 4m 43s | the patch passed | | +1 :green_heart: | cc | 4m 43s | the patch passed | | +1 :green_heart: | javac | 4m 43s | the patch passed | | +1 :green_heart: | checkstyle | 1m 6s | the patch passed | | -0 :warning: | rubocop | 0m 7s | The patch generated 3 new + 439 unchanged - 0 fixed = 442 total (was 439) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 5s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 2m 2s | the patch passed | | +1 :green_heart: | spotless | 0m 49s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 51m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4714 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop | | uname | Linux 4440d304c54a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / f509e43eaa | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | rubocop | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4714/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj opened a new pull request, #4714: HBASE-27104 Add a tool command list_unknownservers
2005hithlj opened a new pull request, #4714: URL: https://github.com/apache/hbase/pull/4714 https://issues.apache.org/jira/browse/HBASE-27104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4698: HBASE-27238 backport backup restore to 2.x
Apache-HBase commented on PR #4698: URL: https://github.com/apache/hbase/pull/4698#issuecomment-1221583595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 47s | branch-2.5 passed | | +1 :green_heart: | compile | 1m 43s | branch-2.5 passed | | +1 :green_heart: | shadedjars | 4m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 46s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 28s | the patch passed | | +1 :green_heart: | compile | 1m 45s | the patch passed | | +1 :green_heart: | javac | 1m 45s | the patch passed | | +1 :green_heart: | shadedjars | 4m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 55s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 221m 22s | root in the patch failed. | | | | 251m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4698 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d0b1aabc62ba 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 8c92a5d4d3 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/testReport/ | | Max. process+thread count | 5156 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27089) Add “commons.crypto.stream.buffer.size” configuration
[ https://issues.apache.org/jira/browse/HBASE-27089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27089. --- Fix Version/s: 2.5.0 3.0.0-alpha-4 2.4.14 Hadoop Flags: Reviewed Release Note: Add a 'commons.crypto.stream.buffer.size' config for setting the buffer size when doing AES crypto for RPC. Assignee: wenweijian Resolution: Fixed Pushed to branch-2.4+. Thanks [~leo wen] for contributing! > Add “commons.crypto.stream.buffer.size” configuration > -- > > Key: HBASE-27089 > URL: https://issues.apache.org/jira/browse/HBASE-27089 > Project: HBase > Issue Type: Improvement > Components: io >Reporter: wenweijian >Assignee: wenweijian >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14 > > > Add “commons.crypto.stream.buffer.size” configuration in hbase when doing > encryption through commonsCryptoAES. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27206) Clean up error-prone findings in hbase-common
[ https://issues.apache.org/jira/browse/HBASE-27206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27206: -- Fix Version/s: 2.5.0 (was: 2.6.0) (was: 2.5.1) Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2.5+. Thanks [~apurtell] and [~ndimiduk]! > Clean up error-prone findings in hbase-common > - > > Key: HBASE-27206 > URL: https://issues.apache.org/jira/browse/HBASE-27206 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4491: HBASE-27089 Add “commons.crypto.stream.buffer.size” configuration
Apache9 merged PR #4491: URL: https://github.com/apache/hbase/pull/4491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4698: HBASE-27238 backport backup restore to 2.x
Apache-HBase commented on PR #4698: URL: https://github.com/apache/hbase/pull/4698#issuecomment-1221551926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 27s | branch-2.5 passed | | +1 :green_heart: | compile | 6m 29s | branch-2.5 passed | | +1 :green_heart: | checkstyle | 1m 0s | branch-2.5 passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 10m 22s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 6m 27s | the patch passed | | +1 :green_heart: | cc | 6m 27s | the patch passed | | -0 :warning: | javac | 6m 27s | root generated 47 new + 1279 unchanged - 0 fixed = 1326 total (was 1279) | | +1 :green_heart: | checkstyle | 1m 1s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 25s | Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 4m 25s | the patch passed | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 11m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 6s | The patch does not generate ASF License warnings. | | | | 69m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4698 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 96cdf9ee021e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 8c92a5d4d3 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4698/8/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ujjawal4046 commented on a diff in pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore
ujjawal4046 commented on code in PR #4533:
URL: https://github.com/apache/hbase/pull/4533#discussion_r950849504
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOpenRegionFailedMemoryLeak.java:
##
@@ -60,6 +63,14 @@ public class TestOpenRegionFailedMemoryLeak {
private static HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();
+ @BeforeClass
+ public static void startCluster() throws Exception {
+Configuration conf = TEST_UTIL.getConfiguration();
+
+// Enable sanity check for coprocessor
+conf.setBoolean(TableDescriptorChecker.TABLE_SANITY_CHECKS, true);
Review Comment:
Oh, it's due to the fact that this test checks region open [is failing due
to invalid loaded coprocessor at line
90](https://github.com/apache/hbase/pull/4533/files#diff-38ced1e200aafb2db3ee4f242681b31ee6a379f31ca238bd42ac86a7eaf46463R90)
below, before this change it was always true (since the coprocessor loading
was independent of sanity check). However after this change, we have made it
configurable based on the sanity check config ([which is always false in
hbase-server's test related
hbase-site.xml](https://github.com/apache/hbase/blob/master/hbase-server/src/test/resources/hbase-site.xml#L154)),
so we need to explicitly enable sanity check in the test setup
##
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##
@@ -185,11 +175,6 @@ public static void sanityCheck(final Configuration c,
final TableDescriptor td)
warnOrThrowExceptionForFailure(logWarn, message, null);
Review Comment:
There are multiple checks based on logWarn variable before this line (for
e.g. [at line no
92](https://github.com/apache/hbase/pull/4533/files#diff-e83f41eef4aa6cbdb757de3bcbd8c976a9068fea4849b4a52966ddad7a8018daR92),
106, 127, 134 above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4645: HBASE-27206 Clean up error-prone findings in hbase-common
Apache9 merged PR #4645: URL: https://github.com/apache/hbase/pull/4645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4533: HBASE-25922 - Disabled sanity checks ignored on snapshot restore
Apache9 commented on code in PR #4533:
URL: https://github.com/apache/hbase/pull/4533#discussion_r950839188
##
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##
@@ -185,11 +175,6 @@ public static void sanityCheck(final Configuration c,
final TableDescriptor td)
warnOrThrowExceptionForFailure(logWarn, message, null);
Review Comment:
This is the place where we use logWarn in this method? Then let's move the
`boolean logWarn = !shouldSanityCheck(conf);` line here?
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOpenRegionFailedMemoryLeak.java:
##
@@ -60,6 +63,14 @@ public class TestOpenRegionFailedMemoryLeak {
private static HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();
+ @BeforeClass
+ public static void startCluster() throws Exception {
+Configuration conf = TEST_UTIL.getConfiguration();
+
+// Enable sanity check for coprocessor
+conf.setBoolean(TableDescriptorChecker.TABLE_SANITY_CHECKS, true);
Review Comment:
Why we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4645: HBASE-27206 Clean up error-prone findings in hbase-common
Apache9 commented on code in PR #4645:
URL: https://github.com/apache/hbase/pull/4645#discussion_r950834395
##
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferArray.java:
##
@@ -119,13 +122,16 @@ public void testArrayIO() throws IOException {
testReadAndWrite(array, cap - 2, 2, (byte) 10);
expectedAssert(() -> testReadAndWrite(array, cap - 2, 3, (byte) 11));
-expectedAssert(() -> testReadAndWrite(array, cap + 1, 0, (byte) 12));
expectedAssert(() -> testReadAndWrite(array, 0, cap + 1, (byte) 12));
-expectedAssert(() -> testReadAndWrite(array, -1, 0, (byte) 13));
expectedAssert(() -> testReadAndWrite(array, 0, -23, (byte) 14));
-expectedAssert(() -> testReadAndWrite(array, 0, 0, (byte) 15));
expectedAssert(() -> testReadAndWrite(array, 4096, cap - 4096 + 1, (byte)
16));
+// XXX: These cases were apparently expected to assert but
expectedAssert() was
Review Comment:
Oops.
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockType.java:
##
@@ -31,6 +31,7 @@
* The values in the enum appear in the order they appear in a version 2 HFile.
*/
@InterfaceAudience.Private
+@SuppressWarnings("ImmutableEnumChecker")
Review Comment:
I guess it is because the 'magic' field. It is a byte array, the content can
be changed at runtime.
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java:
##
@@ -279,14 +278,14 @@ private Cell toOffheapCell(ByteBuffer valAndTagsBuffer,
int vOffset,
protected static class OnheapDecodedCell implements ExtendedCell {
private static final long FIXED_OVERHEAD = ClassSize.align(ClassSize.OBJECT
+ (3 * ClassSize.REFERENCE) + (2 * Bytes.SIZEOF_LONG) + (7 *
Bytes.SIZEOF_INT)
- + (Bytes.SIZEOF_SHORT) + (2 * Bytes.SIZEOF_BYTE) + (3 *
ClassSize.ARRAY));
+ + Bytes.SIZEOF_SHORT + (2 * Bytes.SIZEOF_BYTE) + (3 * ClassSize.ARRAY));
private byte[] keyOnlyBuffer;
private short rowLength;
private int familyOffset;
private byte familyLength;
private int qualifierOffset;
private int qualifierLength;
-private long timestamp;
+private long timeStamp;
Review Comment:
If we do not change the public method declaration I think it is fine. Can
discuss this later.
##
hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java:
##
@@ -234,13 +228,10 @@ public void testBinaryKeys() throws Exception {
// This will output the keys incorrectly.
boolean assertion = false;
int count = 0;
-try {
- for (Cell k : set) {
-assertTrue("count=" + count + ", " + k.toString(), count++ ==
k.getTimestamp());
+for (Cell k : set) {
Review Comment:
Could try to use assertThrows in the future. Not a blocker.
##
hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java:
##
@@ -167,11 +170,10 @@ public long getOpenFileDescriptorCount() {
// need to get the PID number of the process first
RuntimeMXBean rtmbean = ManagementFactory.getRuntimeMXBean();
String rtname = rtmbean.getName();
- String[] pidhost = rtname.split("@");
-
+ Iterator pidhost = Splitter.on('@').split(rtname).iterator();
// using linux bash commands to retrieve info
Process p = Runtime.getRuntime()
-.exec(new String[] { "bash", "-c", "ls /proc/" + pidhost[0] + "/fdinfo
| wc -l" });
+.exec(new String[] { "bash", "-c", "ls /proc/" + pidhost.next() +
"/fdinfo | wc -l" });
Review Comment:
This could be done as a separated issue, not an error prone related problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17582499#comment-17582499
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #4 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/4/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/4/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/4/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/4/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27104) Add a tool command list_unknownservers
[ https://issues.apache.org/jira/browse/HBASE-27104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiangJun He updated HBASE-27104: Release Note: Introduce a shell command 'list_unknownservers' to list unknown servers > Add a tool command list_unknownservers > -- > > Key: HBASE-27104 > URL: https://issues.apache.org/jira/browse/HBASE-27104 > Project: HBase > Issue Type: New Feature > Components: master >Affects Versions: 3.0.0-alpha-3 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Major > Fix For: 3.0.0-alpha-4 > > Attachments: image-2022-06-10-15-49-33-178.png > > > Sometimes, RegionServer will become an unknown server. It is necessary to add > a tool command to list unknown servers. > !image-2022-06-10-15-49-33-178.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27104) Add a tool command list_unknownservers
[ https://issues.apache.org/jira/browse/HBASE-27104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiangJun He updated HBASE-27104: Release Note: Introduce a shell command 'list_unknownservers' to list unknown servers. (was: Introduce a shell command 'list_unknownservers' to list unknown servers) > Add a tool command list_unknownservers > -- > > Key: HBASE-27104 > URL: https://issues.apache.org/jira/browse/HBASE-27104 > Project: HBase > Issue Type: New Feature > Components: master >Affects Versions: 3.0.0-alpha-3 >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Major > Fix For: 3.0.0-alpha-4 > > Attachments: image-2022-06-10-15-49-33-178.png > > > Sometimes, RegionServer will become an unknown server. It is necessary to add > a tool command to list unknown servers. > !image-2022-06-10-15-49-33-178.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
