[GitHub] [hbase] Apache-HBase commented on pull request #4774: HBASE-27363: Fix the config key PREFETCH_PERSISTENCE_PATH_KEY and spotbugs
Apache-HBase commented on PR #4774: URL: https://github.com/apache/hbase/pull/4774#issuecomment-1244932344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 28s | master passed | | +1 :green_heart: | compile | 0m 36s | master passed | | +1 :green_heart: | shadedjars | 4m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 0m 35s | the patch passed | | +1 :green_heart: | javac | 0m 35s | the patch passed | | +1 :green_heart: | shadedjars | 4m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 199m 19s | hbase-server in the patch passed. | | | | 216m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4774 | | JIRA Issue | HBASE-27363 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4dd187defaad 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3f88ff6c1 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/2/testReport/ | | Max. process+thread count | 3553 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-21521) Expose master startup status via JMX and web UI
[ https://issues.apache.org/jira/browse/HBASE-21521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603335#comment-17603335 ] Xiaolin Ha commented on HBASE-21521: I'll prepare a new PR, thanks. > Expose master startup status via JMX and web UI > --- > > Key: HBASE-21521 > URL: https://issues.apache.org/jira/browse/HBASE-21521 > Project: HBase > Issue Type: Improvement > Components: master, UI >Reporter: Andrew Kyle Purtell >Assignee: Rushabh Shah >Priority: Major > Attachments: hbase-21521-1.png, hbase-21521-2.png, hbase-21521-3.png, > hbase-21521-4.png, hbase-21521-revised-1.png, hbase-21521-revised-2.png > > > Add an internal API to the master for tracking startup progress. Expose this > information via JMX. > Modify the master to bring the web UI up sooner. Will require tweaks to > various views to prevent attempts to retrieve state before the master fully > up (or else expect NPEs). Currently, before the master has fully initialized > an attempt to use the web UI will return a 500 error code and display an > error page. > Finally, update the web UI to display startup progress, like HDFS-4249. > Filing this for branch-1. Need to check what if anything is available or > improved in branch-2 and master. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4775: HBASE-27314 Make index block be customized and configured (#4763)
Apache-HBase commented on PR #4775: URL: https://github.com/apache/hbase/pull/4775#issuecomment-1244873063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 1s | branch-2.4 passed | | +1 :green_heart: | compile | 3m 23s | branch-2.4 passed | | +1 :green_heart: | checkstyle | 1m 2s | branch-2.4 passed | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 25s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 1m 51s | root in the patch failed. | | +1 :green_heart: | compile | 3m 19s | the patch passed | | +1 :green_heart: | javac | 3m 19s | the patch passed | | -0 :warning: | checkstyle | 0m 30s | hbase-server: The patch generated 3 new + 19 unchanged - 1 fixed = 22 total (was 20) | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 39s | Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. | | | | 41m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4775/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4775 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 71dbab93a0fc 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / b73348515e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4775/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4775/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4775/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] binlijin commented on pull request #4775: HBASE-27314 Make index block be customized and configured (#4763)
binlijin commented on PR #4775: URL: https://github.com/apache/hbase/pull/4775#issuecomment-1244849759 branch-2.4 do not have class 'StoreFileTrackerBase.java'. and the change to 'StoreFileTrackerBase.java' in branch-2/branch-2.5 apply to 'HStore.java' in branch-2.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] binlijin opened a new pull request, #4775: HBASE-27314 Make index block be customized and configured (#4763)
binlijin opened a new pull request, #4775: URL: https://github.com/apache/hbase/pull/4775 patch for branch-2.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244838135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 1s | branch-2 passed | | +1 :green_heart: | compile | 6m 0s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 57s | branch-2 passed | | +1 :green_heart: | spotless | 0m 36s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 1m 12s | hbase-server in branch-2 has 1 extant spotbugs warnings. | | -1 :x: | spotbugs | 6m 19s | root in branch-2 has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 2m 3s | root in the patch failed. | | -1 :x: | compile | 5m 49s | root in the patch failed. | | -0 :warning: | cc | 5m 49s | root in the patch failed. | | -0 :warning: | javac | 5m 49s | root in the patch failed. | | +1 :green_heart: | checkstyle | 1m 0s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. | | -1 :x: | hadoopcheck | 1m 50s | The patch causes 15 errors with Hadoop v3.2.4. | | -1 :x: | hadoopcheck | 3m 44s | The patch causes 15 errors with Hadoop v3.3.4. | | -1 :x: | hbaseprotoc | 0m 13s | hbase-backup in the patch failed. | | -1 :x: | hbaseprotoc | 2m 23s | root in the patch failed. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 43s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | spotbugs | 1m 20s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | spotbugs | 0m 30s | hbase-mapreduce in the patch passed. | | -1 :x: | spotbugs | 0m 12s | hbase-backup in the patch failed. | | +1 :green_heart: | spotbugs | 0m 24s | hbase-it in the patch passed. | | -1 :x: | spotbugs | 6m 1s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. | | | | 52m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4770 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 8c427c8e196a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7ae66a1d2e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-compile-root.txt | | cc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/4/artifact/yetus-general-check/output/patch-compile-root.txt | | hadoopcheck |
[GitHub] [hbase] Apache-HBase commented on pull request #4765: HBASE-27358 Avoid synchronization in AsyncFSWAL
Apache-HBase commented on PR #4765: URL: https://github.com/apache/hbase/pull/4765#issuecomment-1244833906 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 40s | master passed | | +1 :green_heart: | compile | 2m 23s | master passed | | +1 :green_heart: | checkstyle | 0m 29s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 1m 25s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 17s | the patch passed | | +1 :green_heart: | compile | 2m 20s | the patch passed | | -0 :warning: | javac | 2m 20s | hbase-server generated 4 new + 189 unchanged - 4 fixed = 193 total (was 193) | | +1 :green_heart: | checkstyle | 0m 30s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 21s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 30s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 29m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4765 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 2c1e6f3cb8fc 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3f88ff6c1 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/6/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/6/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4774: HBASE-27363: Fix the config key PREFETCH_PERSISTENCE_PATH_KEY and spotbugs
Apache-HBase commented on PR #4774: URL: https://github.com/apache/hbase/pull/4774#issuecomment-1244825588 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 23s | master passed | | +1 :green_heart: | compile | 2m 16s | master passed | | +1 :green_heart: | checkstyle | 0m 31s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 1m 21s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 2m 11s | the patch passed | | +1 :green_heart: | javac | 2m 11s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 57s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 25s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 28m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4774 | | JIRA Issue | HBASE-27363 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux aad01c0e5f9e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3f88ff6c1 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] rda3mon commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
rda3mon commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244800696 > This has me wondering if there are other patches we need to include though Highly unlikely. I did go into each of the commits from backup history to verify if anything is missed out. May be this was merged after that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
bbeaudreault commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244797927 @rda3mon I find that the violations are usually pretty straightforward. If there are any that you have a question about, feel free to post here. I do think it's possible to run locally, maybe with `-PerrorProne`. But actually, you could try including https://github.com/apache/hbase/commit/2c3abae18aa35e2693b64b143316817d4569d0c3 in your back port here. Seems like Andrew already handled these in master. This has me wondering if there are other patches we need to include though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] rda3mon commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
rda3mon commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244760590 @bbeaudreault Is there a way to run these checks locally? Pushing and checking might be tedious job to do for fixing non obvious ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] rda3mon commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
rda3mon commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244746203 @bbeaudreault These errors if I fix, would differ from master branch. right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603276#comment-17603276
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #16 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/16/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/16/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/16/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-27366) split or merge removed region under snapshot
Huaxiang Sun created HBASE-27366: Summary: split or merge removed region under snapshot Key: HBASE-27366 URL: https://issues.apache.org/jira/browse/HBASE-27366 Project: HBase Issue Type: Bug Components: snapshots Affects Versions: 2.4.10 Reporter: Huaxiang Sun We run into snapshot failures for one table with large number of regions. The event sequence is like the following: # Snapshot process lists all regions for one table. # Normalize kicks in to split some regions for the table under snapshot. # split finishes and major compaction finishes. The parent region is moved to archive. # When the Snapshot processes the parent region, it does not exist and snapshot fails. Since snapshot process acquires the table lock, but there is no table lock acquired in split or merge process, they crash into each other. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] bbeaudreault commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
bbeaudreault commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244458268 @rda3mon I know this is still just a draft, but can you address the error-prone findings in the pre-commit? Shows up under javac: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt Can you do it in a separate commit so that I can review it separately from the initial backport? I re-ran the pre-commit hooks and all the tests are passing, the above is the only automated failure test remaining. The spotbugs error is a known issue which I think will be fixed in https://issues.apache.org/jira/browse/HBASE-27363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4774: HBASE-27363: Fix the config key PREFETCH_PERSISTENCE_PATH_KEY and spotbugs
Apache-HBase commented on PR #4774: URL: https://github.com/apache/hbase/pull/4774#issuecomment-1244276874 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 232m 42s | hbase-server in the patch failed. | | | | 254m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4774 | | JIRA Issue | HBASE-27363 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bedf8f5a9d77 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3f88ff6c1 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/testReport/ | | Max. process+thread count | 2723 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4774: HBASE-27363: Fix the config key PREFETCH_PERSISTENCE_PATH_KEY and spotbugs
Apache-HBase commented on PR #4774: URL: https://github.com/apache/hbase/pull/4774#issuecomment-1244220979 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 27s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 4m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 41s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | shadedjars | 3m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 211m 29s | hbase-server in the patch passed. | | | | 232m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4774 | | JIRA Issue | HBASE-27363 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9fdcf3310de6 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3f88ff6c1 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/testReport/ | | Max. process+thread count | 2374 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244212308 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 46s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 32s | branch-2 passed | | +1 :green_heart: | compile | 1m 46s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 29s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 5s | the patch passed | | +1 :green_heart: | compile | 2m 4s | the patch passed | | +1 :green_heart: | javac | 2m 4s | the patch passed | | +1 :green_heart: | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 382m 35s | root in the patch passed. | | | | 413m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4770 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 99be715ff43e 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7ae66a1d2e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/testReport/ | | Max. process+thread count | 4213 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-27365) Minimise block addition failures due to no space in bucket cache writers queue by introducing wait time
[ https://issues.apache.org/jira/browse/HBASE-27365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27365 started by Rajeshbabu Chintaguntla. --- > Minimise block addition failures due to no space in bucket cache writers > queue by introducing wait time > --- > > Key: HBASE-27365 > URL: https://issues.apache.org/jira/browse/HBASE-27365 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > > Currently in bucket cache asynchronous caching mechanism introduced where > initially the blocks to be cached will be added to queue and writer threads > consume the blocks from the queue and write to bucket cache. In case if block > writing to bucket cache is slow then there is a chance that queue of writer > threads become full and following block additions will be failed. In case of > slower storages like s3 might introduce latencies even if we enable bigger > sizes of bucket cache using ephemeral storages. So we can allow configurable > wait time while adding blocks to queue so that chances of queue free up is > possible during the wait time and block addition failures can be minimised. > To avoid the performance impact of wait time in regular read paths we can use > the wait time mainly during background operations like compactions, flushes > or prefetches etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27365) Minimise block addition failures due to no space in bucket cache writers queue by introducing wait time
[ https://issues.apache.org/jira/browse/HBASE-27365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated HBASE-27365: Description: Currently in bucket cache asynchronous caching mechanism introduced where initially the blocks to be cached will be added to queue and writer threads consume the blocks from the queue and write to bucket cache. In case if block writing to bucket cache is slow then there is a chance that queue of writer threads become full and following block additions will be failed. In case of slower storages like s3 might introduce latencies even if we enable bigger sizes of bucket cache using ephemeral storages. So we can allow configurable wait time while adding blocks to queue so that chances of queue free up is possible during the wait time and block addition failures can be minimised. To avoid the performance impact of wait time in regular read paths we can use the wait time mainly during background operations like compactions, flushes or prefetches etc. (was: Currently in bucket cache asynchronous caching mechanism introduced where initially the blocks to be cached will be added to queue and writer threads consume the blocks from the queue and write to bucket cache. In case if block writing to bucket cache is slow then there is a chance that queue of writer threads become full and following block additions will be failed. In case of slower storages like s3 might introduce latencies even if we enable bigger sizes of bucket cache using ephemeral storages. So we can allow configurable wait time while adding blocks to queue so that chances of queue free up is possible during the wait time and block addition failures can be minimised.) > Minimise block addition failures due to no space in bucket cache writers > queue by introducing wait time > --- > > Key: HBASE-27365 > URL: https://issues.apache.org/jira/browse/HBASE-27365 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > > Currently in bucket cache asynchronous caching mechanism introduced where > initially the blocks to be cached will be added to queue and writer threads > consume the blocks from the queue and write to bucket cache. In case if block > writing to bucket cache is slow then there is a chance that queue of writer > threads become full and following block additions will be failed. In case of > slower storages like s3 might introduce latencies even if we enable bigger > sizes of bucket cache using ephemeral storages. So we can allow configurable > wait time while adding blocks to queue so that chances of queue free up is > possible during the wait time and block addition failures can be minimised. > To avoid the performance impact of wait time in regular read paths we can use > the wait time mainly during background operations like compactions, flushes > or prefetches etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27365) Minimise block addition failures due to no space in bucket cache writers queue by introducing wait time
Rajeshbabu Chintaguntla created HBASE-27365: --- Summary: Minimise block addition failures due to no space in bucket cache writers queue by introducing wait time Key: HBASE-27365 URL: https://issues.apache.org/jira/browse/HBASE-27365 Project: HBase Issue Type: Improvement Components: BucketCache Reporter: Rajeshbabu Chintaguntla Assignee: Rajeshbabu Chintaguntla Currently in bucket cache asynchronous caching mechanism introduced where initially the blocks to be cached will be added to queue and writer threads consume the blocks from the queue and write to bucket cache. In case if block writing to bucket cache is slow then there is a chance that queue of writer threads become full and following block additions will be failed. In case of slower storages like s3 might introduce latencies even if we enable bigger sizes of bucket cache using ephemeral storages. So we can allow configurable wait time while adding blocks to queue so that chances of queue free up is possible during the wait time and block addition failures can be minimised. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1244021139 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 57s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 53s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 47s | branch-2 passed | | +1 :green_heart: | compile | 1m 40s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 45s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 26s | the patch passed | | +1 :green_heart: | compile | 1m 43s | the patch passed | | +1 :green_heart: | javac | 1m 43s | the patch passed | | +1 :green_heart: | shadedjars | 4m 3s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 237m 42s | root in the patch passed. | | | | 267m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4770 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 33afc30f4216 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7ae66a1d2e | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/testReport/ | | Max. process+thread count | 5330 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup hbase-it hbase-assembly . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4774: HBASE-27363: Fix the config key PREFETCH_PERSISTENCE_PATH_KEY and spotbugs
Apache-HBase commented on PR #4774: URL: https://github.com/apache/hbase/pull/4774#issuecomment-1243950865 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 2m 14s | master passed | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 1m 19s | hbase-server in master has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 2m 13s | the patch passed | | +1 :green_heart: | javac | 2m 13s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 0s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 25s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 28m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4774 | | JIRA Issue | HBASE-27363 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux d1122c54de5e 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f3f88ff6c1 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4774/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4762: HBASE-27215 Add support for sync replication
Apache9 commented on PR #4762:
URL: https://github.com/apache/hbase/pull/4762#issuecomment-1243943159
OK, we have this check in code
```
if (!this.isSourceActive()) {
setSourceStartupStatus(false);
if (Thread.currentThread().isInterrupted()) {
// If source is not running and thread is interrupted this means
someone has tried to
// remove this peer.
return;
}
retryStartup.set(!this.abortOnError);
throw new IllegalStateException("Source should be active.");
}
```
```
2022-09-12T23:00:16,183 WARN
[RS_REFRESH_PEER-regionserver/zhangduo-VirtualBox:0-0.replicationSource,1-zhangduo-virtualbox,34201,1662994782531]
replication.HBaseReplicationEndpoint(206): 1 Failed to create connection for
peer cluster
java.io.InterruptedIOException: null
at
org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:184)
~[hbase-common-3.0.0-alpha-4-SNAPSHOT.jar:?]
at
org.apache.hadoop.hbase.client.ClusterConnectionFactory.createAsyncClusterConnection(ClusterConnectionFactory.java:43)
~[classes/:?]
at
org.apache.hadoop.hbase.client.ClusterConnectionFactory.createAsyncClusterConnection(ClusterConnectionFactory.java:67)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.createConnection(HBaseReplicationEndpoint.java:95)
~[classes/:3.0.0-alpha-4-SNAPSHOT]
at
org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.connectPeerCluster(HBaseReplicationEndpoint.java:204)
~[classes/:3.0.0-alpha-4-SNAPSHOT]
at
org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.doStart(HBaseReplicationEndpoint.java:157)
~[classes/:3.0.0-alpha-4-SNAPSHOT]
at
org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:251)
~[hbase-shaded-miscellaneous-4.1.1.jar:4.1.1]
at
org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.start(HBaseReplicationEndpoint.java:145)
~[classes/:3.0.0-alpha-4-SNAPSHOT]
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initAndStartReplicationEndpoint(ReplicationSource.java:327)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:555)
~[classes/:?]
at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_292]
Caused by: java.lang.InterruptedException
at
java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:347)
~[?:1.8.0_292]
at
java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
~[?:1.8.0_292]
at
org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:182)
~[hbase-common-3.0.0-alpha-4-SNAPSHOT.jar:?]
... 10 more
2022-09-12T23:00:16,184 WARN
[RS_REFRESH_PEER-regionserver/zhangduo-VirtualBox:0-0.replicationSource,1-zhangduo-virtualbox,34201,1662994782531]
regionserver.ReplicationSource(559): peerId=1, Error starting
ReplicationEndpoint, retry
java.lang.IllegalStateException: Expected the service
HBaseInterClusterReplicationEndpoint [FAILED] to be RUNNING, but the service
has FAILED
at
org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:381)
~[hbase-shaded-miscellaneous-4.1.1.jar:4.1.1]
at
org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:321)
~[hbase-shaded-miscellaneous-4.1.1.jar:4.1.1]
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initAndStartReplicationEndpoint(ReplicationSource.java:328)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:555)
~[classes/:?]
at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_292]
Caused by: java.io.InterruptedIOException
at
org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:184)
~[hbase-common-3.0.0-alpha-4-SNAPSHOT.jar:?]
at
org.apache.hadoop.hbase.client.ClusterConnectionFactory.createAsyncClusterConnection(ClusterConnectionFactory.java:43)
~[classes/:?]
at
org.apache.hadoop.hbase.client.ClusterConnectionFactory.createAsyncClusterConnection(ClusterConnectionFactory.java:67)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.createConnection(HBaseReplicationEndpoint.java:95)
~[classes/:3.0.0-alpha-4-SNAPSHOT]
at
org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.connectPeerCluster(HBaseReplicationEndpoint.java:204)
~[classes/:3.0.0-alpha-4-SNAPSHOT]
at
org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.doStart(HBaseReplicationEndpoint.java:157)
~[classes/:3.0.0-alpha-4-SNAPSHOT]
at
[jira] [Updated] (HBASE-27363) Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY
[ https://issues.apache.org/jira/browse/HBASE-27363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27363: - Status: Patch Available (was: In Progress) > Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY > - > > Key: HBASE-27363 > URL: https://issues.apache.org/jira/browse/HBASE-27363 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Trivial > > Change the config key for PREFETCH_PERSISTENCE_PATH_KEY to > hbase.prefetch.file.list.path -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Kota-SH opened a new pull request, #4774: HBASE-27363: Fix the config key PREFETCH_PERSISTENCE_PATH_KEY and spotbugs
Kota-SH opened a new pull request, #4774: URL: https://github.com/apache/hbase/pull/4774 Apache Jira: https://issues.apache.org/jira/browse/HBASE-27363 Summary: 1. Change the config key for PREFETCH_PERSISTENCE_PATH_KEY to hbase.prefetch.file.list.path 2. Fix the spotbugs issue mentioned in https://issues.apache.org/jira/browse/HBASE-27313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4762: HBASE-27215 Add support for sync replication
Apache9 commented on PR #4762: URL: https://github.com/apache/hbase/pull/4762#issuecomment-1243895065 OK, finally I seemed to reproduce the failure locally. ``` 2022-09-12T23:00:18,192 ERROR [RS_REFRESH_PEER-regionserver/zhangduo-VirtualBox:0-0.replicationSource,1-zhangduo-virtualbox,34201,1662994782531] regionserver.ReplicationSource(457): Unexpected exception in RS_REFRESH_PEER-regionserver/zhangduo-VirtualBox:0-0.replicationSource,1-zhangduo-virtualbox,34201,166299478253 1 currentPath=null java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:580) ~[classes/:?] at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_292] 2022-09-12T23:00:18,195 ERROR [RS_REFRESH_PEER-regionserver/zhangduo-VirtualBox:0-0.replicationSource,1-zhangduo-virtualbox,34201,1662994782531] regionserver.HRegionServer(2307): * ABORTING region server zhangduo-virtualbox,34201,1662994782531: Unexpected exception in RS_REFRESH_PEER-regionserver/zhangduo-Virtua lBox:0-0.replicationSource,1-zhangduo-virtualbox,34201,1662994782531 * java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:580) ~[classes/:?] at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_292] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27364) Intra-cluster replication sink metrics
Hernan Gelaf-Romer created HBASE-27364: -- Summary: Intra-cluster replication sink metrics Key: HBASE-27364 URL: https://issues.apache.org/jira/browse/HBASE-27364 Project: HBase Issue Type: Improvement Components: metrics, read replicas Reporter: Hernan Gelaf-Romer Region replication doesn't emit any sink metrics at the moment, these would be useful in determining replication lag. Adding metrics such as ageOfLastAppliedOp would be helpful. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4762: HBASE-27215 Add support for sync replication
Apache-HBase commented on PR #4762: URL: https://github.com/apache/hbase/pull/4762#issuecomment-1243801655 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 3m 17s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 42s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 1m 0s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 1m 52s | hbase-server in HBASE-27109/table_based_rqs has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 40s | the patch passed | | +1 :green_heart: | compile | 2m 57s | the patch passed | | +1 :green_heart: | javac | 2m 57s | the patch passed | | +1 :green_heart: | checkstyle | 0m 33s | hbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 36s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 51s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 0s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 39m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4762/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4762 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 9db6554326d3 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / d530ebb070 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4762/8/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | Max. process+thread count | 69 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4762/8/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4770: HBASE-27238 Backport backup restore to 2.x
Apache-HBase commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1243762070 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 33s | branch-2 passed | | +1 :green_heart: | compile | 7m 43s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 8s | branch-2 passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 1m 33s | hbase-server in branch-2 has 1 extant spotbugs warnings. | | -1 :x: | spotbugs | 7m 47s | root in branch-2 has 1 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 22s | the patch passed | | +1 :green_heart: | compile | 7m 11s | the patch passed | | +1 :green_heart: | cc | 7m 11s | the patch passed | | -0 :warning: | javac | 7m 11s | root generated 50 new + 1159 unchanged - 0 fixed = 1209 total (was 1159) | | +1 :green_heart: | checkstyle | 1m 6s | the patch passed | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 9m 23s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 5m 40s | the patch passed | | +1 :green_heart: | spotless | 0m 45s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 10s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | spotbugs | 1m 33s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | spotbugs | 0m 42s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | spotbugs | 0m 42s | hbase-backup in the patch passed. | | +1 :green_heart: | spotbugs | 8m 20s | root generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | spotbugs | 0m 34s | hbase-it in the patch passed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 55s | The patch does not generate ASF License warnings. | | | | 75m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4770 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile spotbugs hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 7770d033f8eb 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 7ae66a1d2e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-server hbase-mapreduce hbase-backup . hbase-assembly hbase-it U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/3/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To
[GitHub] [hbase] Apache9 commented on pull request #4762: HBASE-27215 Add support for sync replication
Apache9 commented on PR #4762: URL: https://github.com/apache/hbase/pull/4762#issuecomment-1243749657 Strange, it always timed out in jdk11 or jdk8... Let me dig more... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] anmolnar commented on pull request #4733: HBASE-26553 OAuth Bearer authentication mech plugin for SASL
anmolnar commented on PR #4733: URL: https://github.com/apache/hbase/pull/4733#issuecomment-1243416375 Thanks @taklwu , I've updated the minimum configuration in the description with more details. Sorry for the confusion, I've decided to abandon the feature branch to speed up the rebasing and the process. Please let me know if you think it would be better to go back and continue working on the feature branch instead. @joshelser > but why [HBASE-26655](https://issues.apache.org/jira/browse/HBASE-26655) does not have a link to https://github.com/apache/hbase/pull/4019 ? I see the link in the jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
