[GitHub] [hbase] Apache-HBase commented on pull request #4789: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4789: URL: https://github.com/apache/hbase/pull/4789#issuecomment-1249993137 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 11s | branch-2 passed | | +1 :green_heart: | compile | 6m 20s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 3s | branch-2 passed | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 27s | hbase-common in branch-2 has 6 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 15s | hbase-metrics in branch-2 has 1 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 51s | hbase-protocol in branch-2 has 1 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 45s | hbase-client in branch-2 has 11 extant spotbugs warnings. | | -1 :x: | spotbugs | 1m 16s | hbase-server in branch-2 has 28 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 26s | hbase-rest in branch-2 has 2 extant spotbugs warnings. | | -1 :x: | spotbugs | 6m 23s | root in branch-2 has 49 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 6m 22s | the patch passed | | -0 :warning: | javac | 6m 22s | root generated 1 new + 1158 unchanged - 1 fixed = 1159 total (was 1159) | | +1 :green_heart: | checkstyle | 1m 2s | root: The patch generated 0 new + 57 unchanged - 5 fixed = 57 total (was 62) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 57s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 35s | hbase-common generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6) | | +1 :green_heart: | spotbugs | 0m 23s | hbase-metrics generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | spotbugs | 1m 3s | hbase-protocol generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | spotbugs | 0m 53s | hbase-client generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11) | | +1 :green_heart: | spotbugs | 1m 22s | hbase-server generated 0 new + 0 unchanged - 28 fixed = 0 total (was 28) | | +1 :green_heart: | spotbugs | 0m 34s | hbase-rest generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 :green_heart: | spotbugs | 6m 22s | root generated 0 new + 0 unchanged - 49 fixed = 0 total (was 49) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 6s | The patch does not generate ASF License warnings. | | | | 58m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4789 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml | | uname | Linux 2594b8dcd32c 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 11b327fddc | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-common-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-metrics-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-protocol-warnings.html | | spotbugs |
[GitHub] [hbase] Apache-HBase commented on pull request #4789: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4789: URL: https://github.com/apache/hbase/pull/4789#issuecomment-1249982390 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 17s | branch-2 passed | | +1 :green_heart: | compile | 6m 17s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 2s | branch-2 passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 6m 23s | root in branch-2 has 49 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 43s | hbase-client in branch-2 has 11 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 27s | hbase-common in branch-2 has 6 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 15s | hbase-metrics in branch-2 has 1 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 53s | hbase-protocol in branch-2 has 1 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 26s | hbase-rest in branch-2 has 2 extant spotbugs warnings. | | -1 :x: | spotbugs | 1m 17s | hbase-server in branch-2 has 28 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 38s | root in the patch failed. | | -1 :x: | compile | 1m 4s | root in the patch failed. | | -0 :warning: | javac | 1m 4s | root in the patch failed. | | +1 :green_heart: | checkstyle | 1m 0s | root: The patch generated 0 new + 57 unchanged - 5 fixed = 57 total (was 62) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | -1 :x: | hadoopcheck | 0m 46s | The patch causes 14 errors with Hadoop v3.2.4. | | -1 :x: | hadoopcheck | 1m 32s | The patch causes 14 errors with Hadoop v3.3.4. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 33s | hbase-common generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6) | | +1 :green_heart: | spotbugs | 0m 20s | hbase-metrics generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | -1 :x: | spotbugs | 0m 14s | hbase-protocol in the patch failed. | | +1 :green_heart: | spotbugs | 0m 52s | hbase-client generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11) | | +1 :green_heart: | spotbugs | 1m 44s | hbase-server generated 0 new + 0 unchanged - 28 fixed = 0 total (was 28) | | +1 :green_heart: | spotbugs | 0m 35s | hbase-rest generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | -1 :x: | spotbugs | 1m 46s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 56s | The patch does not generate ASF License warnings. | | | | 35m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4789 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml | | uname | Linux 8f271cacfdb2 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 11b327fddc | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-client-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-common-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-metrics-warnings.html | | spotbugs |
[GitHub] [hbase] Apache-HBase commented on pull request #4789: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4789: URL: https://github.com/apache/hbase/pull/4789#issuecomment-1249980923 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 38s | branch-2 passed | | +1 :green_heart: | compile | 1m 49s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 33s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 46s | root in the patch failed. | | -1 :x: | compile | 0m 38s | root in the patch failed. | | -0 :warning: | javac | 0m 38s | root in the patch failed. | | -1 :x: | shadedjars | 1m 43s | patch has 14 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 22s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 4m 16s | root in the patch failed. | | | | 25m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4789 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 406400d6aa43 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 11b327fddc | | Default Java | AdoptOpenJDK-11.0.10+9 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/testReport/ | | Max. process+thread count | 640 (vs. ulimit of 3) | | modules | C: hbase-common hbase-metrics hbase-protocol hbase-client hbase-server hbase-rest . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4789: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4789: URL: https://github.com/apache/hbase/pull/4789#issuecomment-1249980521 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 29s | branch-2 passed | | +1 :green_heart: | compile | 1m 25s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 32s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 34s | root in the patch failed. | | -1 :x: | compile | 0m 23s | root in the patch failed. | | -0 :warning: | javac | 0m 23s | root in the patch failed. | | -1 :x: | shadedjars | 1m 36s | patch has 14 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 28s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 3m 39s | root in the patch failed. | | | | 22m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4789 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3023d5d0299e 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 11b327fddc | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-root.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/testReport/ | | Max. process+thread count | 471 (vs. ulimit of 3) | | modules | C: hbase-common hbase-metrics hbase-protocol hbase-client hbase-server hbase-rest . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4789: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4789: URL: https://github.com/apache/hbase/pull/4789#issuecomment-1249846577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 20s | branch-2 passed | | +1 :green_heart: | compile | 1m 25s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 25s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | shadedjars | 3m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 354m 59s | root in the patch passed. | | | | 379m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4789 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e2392fea057b 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 11b327fddc | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/testReport/ | | Max. process+thread count | 4455 (vs. ulimit of 3) | | modules | C: hbase-common hbase-metrics hbase-client hbase-server hbase-rest . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4789: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4789: URL: https://github.com/apache/hbase/pull/4789#issuecomment-1249743527 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 50s | branch-2 passed | | +1 :green_heart: | compile | 1m 55s | branch-2 passed | | +1 :green_heart: | shadedjars | 3m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 24s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 32s | the patch passed | | +1 :green_heart: | compile | 1m 49s | the patch passed | | +1 :green_heart: | javac | 1m 49s | the patch passed | | +1 :green_heart: | shadedjars | 3m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 238m 1s | root in the patch passed. | | | | 266m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4789 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 71621254f23e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 11b327fddc | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/testReport/ | | Max. process+thread count | 4562 (vs. ulimit of 3) | | modules | C: hbase-common hbase-metrics hbase-client hbase-server hbase-rest . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a diff in pull request #4781: HBASE-27370 Avoid decompressing blocks when reading from bucket cache…
wchevreuil commented on code in PR #4781:
URL: https://github.com/apache/hbase/pull/4781#discussion_r973273430
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -148,36 +153,88 @@ private void readStoreFileLikeScanner(Path storeFilePath)
throws Exception {
}
private void readStoreFile(Path storeFilePath) throws Exception {
+readStoreFile(storeFilePath, (r, o) -> {
+ HFileBlock block = null;
+ try {
+block = r.readBlock(o, -1, false, true, false, true, null, null);
+ } catch (IOException e) {
+fail(e.getMessage());
+ }
+ return block;
+}, (key, block) -> {
+ boolean isCached = blockCache.getBlock(key, true, false, true) != null;
+ if (
+block.getBlockType() == BlockType.DATA || block.getBlockType() ==
BlockType.ROOT_INDEX
+ || block.getBlockType() == BlockType.INTERMEDIATE_INDEX
+ ) {
+assertTrue(isCached);
+ }
+});
+ }
+
+ private void readStoreFileCacheOnly(Path storeFilePath) throws Exception {
+readStoreFile(storeFilePath, (r, o) -> {
+ HFileBlock block = null;
+ try {
+block = r.readBlock(o, -1, false, true, false, true, null, null, true);
+ } catch (IOException e) {
+fail(e.getMessage());
+ }
+ return block;
+}, (key, block) -> {
+ boolean isCached = blockCache.getBlock(key, true, false, true) != null;
+ if (block.getBlockType() == BlockType.DATA) {
+assertFalse(block.isUnpacked());
+ } else if (
+block.getBlockType() == BlockType.ROOT_INDEX
+ || block.getBlockType() == BlockType.INTERMEDIATE_INDEX
+ ) {
+assertTrue(block.isUnpacked());
+ }
+ assertTrue(isCached);
+});
+ }
+
+ private void readStoreFile(Path storeFilePath,
+BiFunction readFunction,
+BiConsumer validationFunction) throws Exception
{
// Open the file
HFile.Reader reader = HFile.createReader(fs, storeFilePath, cacheConf,
true, conf);
while (!reader.prefetchComplete()) {
// Sleep for a bit
Thread.sleep(1000);
}
-
-// Check that all of the data blocks were preloaded
-BlockCache blockCache = cacheConf.getBlockCache().get();
long offset = 0;
while (offset < reader.getTrailer().getLoadOnOpenDataOffset()) {
- HFileBlock block = reader.readBlock(offset, -1, false, true, false,
true, null, null);
+ HFileBlock block = readFunction.apply(reader, offset);
BlockCacheKey blockCacheKey = new BlockCacheKey(reader.getName(),
offset);
- boolean isCached = blockCache.getBlock(blockCacheKey, true, false, true)
!= null;
- if (
-block.getBlockType() == BlockType.DATA || block.getBlockType() ==
BlockType.ROOT_INDEX
- || block.getBlockType() == BlockType.INTERMEDIATE_INDEX
- ) {
-assertTrue(isCached);
- }
+ validationFunction.accept(blockCacheKey, block);
offset += block.getOnDiskSizeWithHeader();
}
}
+ @Test
+ public void testPrefetchCompressed() throws Exception {
+conf.setBoolean(CACHE_DATA_BLOCKS_COMPRESSED_KEY, true);
+cacheConf = new CacheConfig(conf, blockCache);
+HFileContext context = new
HFileContextBuilder().withCompression(Compression.Algorithm.GZ)
+ .withBlockSize(DATA_BLOCK_SIZE).build();
+Path storeFile = writeStoreFile("TestPrefetchCompressed", context);
+readStoreFileCacheOnly(storeFile);
+conf.setBoolean(CACHE_DATA_BLOCKS_COMPRESSED_KEY, false);
Review Comment:
Yeah, don't want to interfere on other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on a diff in pull request #4781: HBASE-27370 Avoid decompressing blocks when reading from bucket cache…
wchevreuil commented on code in PR #4781:
URL: https://github.com/apache/hbase/pull/4781#discussion_r973272991
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1236,6 +1236,15 @@ private boolean shouldUseHeap(BlockType
expectedBlockType) {
public HFileBlock readBlock(long dataBlockOffset, long onDiskBlockSize,
final boolean cacheBlock,
boolean pread, final boolean isCompaction, boolean updateCacheMetrics,
BlockType expectedBlockType, DataBlockEncoding expectedDataBlockEncoding)
throws IOException {
+return readBlock(dataBlockOffset, onDiskBlockSize, cacheBlock, pread,
isCompaction,
+ updateCacheMetrics, expectedBlockType, expectedDataBlockEncoding, false);
+ }
+
+ @Override
+ public HFileBlock readBlock(long dataBlockOffset, long onDiskBlockSize,
final boolean cacheBlock,
+boolean pread, final boolean isCompaction, boolean updateCacheMetrics,
+BlockType expectedBlockType, DataBlockEncoding expectedDataBlockEncoding,
boolean cacheOnly)
Review Comment:
We call this on line #60 of HFilePreadReader. That line is executed once we
set CACHE_DATA_BLOCKS_COMPRESSED_KEY to true, which is how we are testing it
further down on the UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] taklwu commented on a diff in pull request #4781: HBASE-27370 Avoid decompressing blocks when reading from bucket cache…
taklwu commented on code in PR #4781:
URL: https://github.com/apache/hbase/pull/4781#discussion_r973246512
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -148,36 +153,88 @@ private void readStoreFileLikeScanner(Path storeFilePath)
throws Exception {
}
private void readStoreFile(Path storeFilePath) throws Exception {
+readStoreFile(storeFilePath, (r, o) -> {
+ HFileBlock block = null;
+ try {
+block = r.readBlock(o, -1, false, true, false, true, null, null);
+ } catch (IOException e) {
+fail(e.getMessage());
+ }
+ return block;
+}, (key, block) -> {
+ boolean isCached = blockCache.getBlock(key, true, false, true) != null;
+ if (
+block.getBlockType() == BlockType.DATA || block.getBlockType() ==
BlockType.ROOT_INDEX
+ || block.getBlockType() == BlockType.INTERMEDIATE_INDEX
+ ) {
+assertTrue(isCached);
+ }
+});
+ }
+
+ private void readStoreFileCacheOnly(Path storeFilePath) throws Exception {
+readStoreFile(storeFilePath, (r, o) -> {
+ HFileBlock block = null;
+ try {
+block = r.readBlock(o, -1, false, true, false, true, null, null, true);
+ } catch (IOException e) {
+fail(e.getMessage());
+ }
+ return block;
+}, (key, block) -> {
+ boolean isCached = blockCache.getBlock(key, true, false, true) != null;
+ if (block.getBlockType() == BlockType.DATA) {
+assertFalse(block.isUnpacked());
+ } else if (
+block.getBlockType() == BlockType.ROOT_INDEX
+ || block.getBlockType() == BlockType.INTERMEDIATE_INDEX
+ ) {
+assertTrue(block.isUnpacked());
+ }
+ assertTrue(isCached);
+});
+ }
+
+ private void readStoreFile(Path storeFilePath,
+BiFunction readFunction,
+BiConsumer validationFunction) throws Exception
{
// Open the file
HFile.Reader reader = HFile.createReader(fs, storeFilePath, cacheConf,
true, conf);
while (!reader.prefetchComplete()) {
// Sleep for a bit
Thread.sleep(1000);
}
-
-// Check that all of the data blocks were preloaded
-BlockCache blockCache = cacheConf.getBlockCache().get();
long offset = 0;
while (offset < reader.getTrailer().getLoadOnOpenDataOffset()) {
- HFileBlock block = reader.readBlock(offset, -1, false, true, false,
true, null, null);
+ HFileBlock block = readFunction.apply(reader, offset);
BlockCacheKey blockCacheKey = new BlockCacheKey(reader.getName(),
offset);
- boolean isCached = blockCache.getBlock(blockCacheKey, true, false, true)
!= null;
- if (
-block.getBlockType() == BlockType.DATA || block.getBlockType() ==
BlockType.ROOT_INDEX
- || block.getBlockType() == BlockType.INTERMEDIATE_INDEX
- ) {
-assertTrue(isCached);
- }
+ validationFunction.accept(blockCacheKey, block);
offset += block.getOnDiskSizeWithHeader();
}
}
+ @Test
+ public void testPrefetchCompressed() throws Exception {
+conf.setBoolean(CACHE_DATA_BLOCKS_COMPRESSED_KEY, true);
+cacheConf = new CacheConfig(conf, blockCache);
+HFileContext context = new
HFileContextBuilder().withCompression(Compression.Algorithm.GZ)
+ .withBlockSize(DATA_BLOCK_SIZE).build();
+Path storeFile = writeStoreFile("TestPrefetchCompressed", context);
+readStoreFileCacheOnly(storeFile);
+conf.setBoolean(CACHE_DATA_BLOCKS_COMPRESSED_KEY, false);
Review Comment:
[nit] is it for resetting configuration to avoid error for other tests?
should we use a cleanup? but it's not a blocker
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1236,6 +1236,15 @@ private boolean shouldUseHeap(BlockType
expectedBlockType) {
public HFileBlock readBlock(long dataBlockOffset, long onDiskBlockSize,
final boolean cacheBlock,
boolean pread, final boolean isCompaction, boolean updateCacheMetrics,
BlockType expectedBlockType, DataBlockEncoding expectedDataBlockEncoding)
throws IOException {
+return readBlock(dataBlockOffset, onDiskBlockSize, cacheBlock, pread,
isCompaction,
+ updateCacheMetrics, expectedBlockType, expectedDataBlockEncoding, false);
+ }
+
+ @Override
+ public HFileBlock readBlock(long dataBlockOffset, long onDiskBlockSize,
final boolean cacheBlock,
+boolean pread, final boolean isCompaction, boolean updateCacheMetrics,
+BlockType expectedBlockType, DataBlockEncoding expectedDataBlockEncoding,
boolean cacheOnly)
Review Comment:
[nit] this new flag `cacheOnly=true` should just skip reading blocks from
the local cache, and it does not have any caller other in the unit tests, are
you planning to introduce a new behavior in the future ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[GitHub] [hbase] Apache-HBase commented on pull request #4789: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4789: URL: https://github.com/apache/hbase/pull/4789#issuecomment-1249552052 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 20s | branch-2 passed | | +1 :green_heart: | compile | 6m 24s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 3s | branch-2 passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 6m 20s | root in branch-2 has 49 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 44s | hbase-client in branch-2 has 11 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 28s | hbase-common in branch-2 has 6 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 16s | hbase-metrics in branch-2 has 1 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 26s | hbase-rest in branch-2 has 2 extant spotbugs warnings. | | -1 :x: | spotbugs | 1m 16s | hbase-server in branch-2 has 28 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 6m 29s | the patch passed | | -0 :warning: | javac | 6m 29s | root generated 1 new + 1158 unchanged - 1 fixed = 1159 total (was 1159) | | +1 :green_heart: | checkstyle | 1m 2s | root: The patch generated 0 new + 48 unchanged - 5 fixed = 48 total (was 53) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 8m 5s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 34s | hbase-common generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6) | | +1 :green_heart: | spotbugs | 0m 22s | hbase-metrics generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | spotbugs | 0m 52s | hbase-client generated 0 new + 1 unchanged - 10 fixed = 1 total (was 11) | | +1 :green_heart: | spotbugs | 1m 24s | hbase-server generated 0 new + 0 unchanged - 28 fixed = 0 total (was 28) | | +1 :green_heart: | spotbugs | 0m 33s | hbase-rest generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 :green_heart: | spotbugs | 6m 27s | root generated 0 new + 2 unchanged - 47 fixed = 2 total (was 49) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. | | | | 57m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4789 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml | | uname | Linux bc56220c3487 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 11b327fddc | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-client-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-common-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-metrics-warnings.html | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4789/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-rest-warnings.html | |
[GitHub] [hbase] Apache9 merged pull request #4787: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache9 merged PR #4787: URL: https://github.com/apache/hbase/pull/4787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4787: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache9 commented on PR #4787: URL: https://github.com/apache/hbase/pull/4787#issuecomment-1249470084 Tried several times, TestTags passed for me locally. Looking at the code, I guess the problem is the 'no condition check' Thread.sleep. Maybe the problem is our build machine is under high load and slow. Let me merge to solve the spotbugs for master branch and keep an eye on the flaky dashboard. Thanks @wchevreuil for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4787: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache9 commented on PR #4787: URL: https://github.com/apache/hbase/pull/4787#issuecomment-1249393397 Let me check the TestTags test. It failed for both jdk8 and jdk11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27374) Export Hbase table to hdfs as comma delimiter
Sai created HBASE-27374: --- Summary: Export Hbase table to hdfs as comma delimiter Key: HBASE-27374 URL: https://issues.apache.org/jira/browse/HBASE-27374 Project: HBase Issue Type: New Feature Reporter: Sai we are trying to export hbase table to hdfs as comma delimiter/seperator . hope this feature will be added. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] wchevreuil commented on pull request #4781: HBASE-27370 Avoid decompressing blocks when reading from bucket cache…
wchevreuil commented on PR #4781: URL: https://github.com/apache/hbase/pull/4781#issuecomment-1249222868 Spotbugs issue shouldn't be related. See ongoing PR for fixing sputbugs: https://github.com/apache/hbase/pull/4787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4787: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4787: URL: https://github.com/apache/hbase/pull/4787#issuecomment-1249171277 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 2s | master passed | | +1 :green_heart: | compile | 3m 30s | master passed | | +1 :green_heart: | shadedjars | 5m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 19s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 3m 13s | the patch passed | | +1 :green_heart: | javac | 3m 13s | the patch passed | | +1 :green_heart: | shadedjars | 5m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 17s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 0m 23s | hbase-metrics in the patch passed. | | +1 :green_heart: | unit | 1m 56s | hbase-client in the patch passed. | | -1 :x: | unit | 281m 52s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 1m 57s | hbase-testing-util in the patch passed. | | +1 :green_heart: | unit | 3m 30s | hbase-rest in the patch passed. | | | | 328m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4787 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 72a96ba22623 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 460bb47c04 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/testReport/ | | Max. process+thread count | 2659 (vs. ulimit of 3) | | modules | C: hbase-common hbase-metrics hbase-client hbase-server hbase-testing-util hbase-rest U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4765: HBASE-27358 Avoid synchronization in AsyncFSWAL
Apache-HBase commented on PR #4765: URL: https://github.com/apache/hbase/pull/4765#issuecomment-1249118806 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 37s | master passed | | +1 :green_heart: | compile | 0m 46s | master passed | | +1 :green_heart: | shadedjars | 3m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 35s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 3m 48s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-server generated 4 new + 93 unchanged - 3 fixed = 97 total (was 96) | ||| _ Other Tests _ | | -1 :x: | unit | 289m 39s | hbase-server in the patch failed. | | | | 309m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4765 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f2d40db85f1a 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 460bb47c04 | | Default Java | AdoptOpenJDK-11.0.10+9 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/testReport/ | | Max. process+thread count | 2494 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4787: HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
Apache-HBase commented on PR #4787: URL: https://github.com/apache/hbase/pull/4787#issuecomment-1249091811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 41s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 49s | master passed | | +1 :green_heart: | compile | 1m 58s | master passed | | +1 :green_heart: | shadedjars | 4m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 35s | the patch passed | | +1 :green_heart: | compile | 1m 59s | the patch passed | | +1 :green_heart: | javac | 1m 59s | the patch passed | | +1 :green_heart: | shadedjars | 4m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 52s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 0m 16s | hbase-metrics in the patch passed. | | +1 :green_heart: | unit | 1m 17s | hbase-client in the patch passed. | | -1 :x: | unit | 218m 30s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 2m 19s | hbase-testing-util in the patch passed. | | +1 :green_heart: | unit | 4m 30s | hbase-rest in the patch passed. | | | | 253m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4787 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 76d4640999b4 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 460bb47c04 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/testReport/ | | Max. process+thread count | 2669 (vs. ulimit of 3) | | modules | C: hbase-common hbase-metrics hbase-client hbase-server hbase-testing-util hbase-rest U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605687#comment-17605687
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #17 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/17/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/17/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/17/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/17/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4765: HBASE-27358 Avoid synchronization in AsyncFSWAL
Apache-HBase commented on PR #4765: URL: https://github.com/apache/hbase/pull/4765#issuecomment-1249025397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 31s | master passed | | +1 :green_heart: | compile | 0m 34s | master passed | | +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 6s | the patch passed | | +1 :green_heart: | compile | 0m 34s | the patch passed | | +1 :green_heart: | javac | 0m 34s | the patch passed | | +1 :green_heart: | shadedjars | 4m 7s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-server generated 4 new + 23 unchanged - 0 fixed = 27 total (was 23) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 199m 3s | hbase-server in the patch passed. | | | | 216m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4765 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 466c32fd0f67 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 460bb47c04 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/testReport/ | | Max. process+thread count | 3043 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4765/7/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
