[GitHub] [hbase] Apache-HBase commented on pull request #4809: HBASE-27403 Remove 'Remove unhelpful javadoc stubs' spotless rule for…
Apache-HBase commented on PR #4809: URL: https://github.com/apache/hbase/pull/4809#issuecomment-1264486317 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 26s | master passed | | +1 :green_heart: | compile | 1m 26s | master passed | | +1 :green_heart: | shadedjars | 3m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 21s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 5s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | +1 :green_heart: | shadedjars | 4m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 390m 33s | root in the patch passed. | | | | 412m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4809/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4809 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0dfdfcf018ea 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 23a56331db | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4809/1/testReport/ | | Max. process+thread count | 4903 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4809/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4809: HBASE-27403 Remove 'Remove unhelpful javadoc stubs' spotless rule for…
Apache-HBase commented on PR #4809: URL: https://github.com/apache/hbase/pull/4809#issuecomment-1264459847 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 53s | master passed | | +1 :green_heart: | compile | 1m 52s | master passed | | +1 :green_heart: | shadedjars | 3m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 58s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 1m 57s | the patch passed | | +1 :green_heart: | javac | 1m 57s | the patch passed | | +1 :green_heart: | shadedjars | 3m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 262m 59s | root in the patch passed. | | | | 286m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4809/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4809 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b393b51fba60 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 23a56331db | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4809/1/testReport/ | | Max. process+thread count | 4643 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4809/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1264411813 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 21s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 53s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 3m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 15s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 10s | the patch passed | | +1 :green_heart: | compile | 1m 55s | the patch passed | | +1 :green_heart: | javac | 1m 55s | the patch passed | | +1 :green_heart: | shadedjars | 3m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 30s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 6s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 16s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 1m 25s | hbase-procedure in the patch passed. | | -1 :x: | unit | 223m 28s | hbase-server in the patch failed. | | | | 249m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5ad5e725c7fd 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / de2d20aac2 | | Default Java | Temurin-1.8.0_345-b01 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/testReport/ | | Max. process+thread count | 2879 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1264410711 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 50s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 2m 0s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 4m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 14s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 2m 0s | the patch passed | | +1 :green_heart: | javac | 2m 0s | the patch passed | | +1 :green_heart: | shadedjars | 4m 10s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 34s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 22s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 14s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 1m 22s | hbase-procedure in the patch passed. | | -1 :x: | unit | 215m 35s | hbase-server in the patch failed. | | | | 243m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8457c685f90c 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / de2d20aac2 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/testReport/ | | Max. process+thread count | 2764 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611926#comment-17611926
]
Duo Zhang edited comment on HBASE-27401 at 10/1/22 4:10 PM:
And I've added a check for finding the broken javadoc line where we trim the
javadoc incorrectly, with code like this
{code}
if (line.trim().substring(1).contains(" * ") || line.trim().endsWith("
*")) {
System.out.println(path + ":" + line);
}
{code}
This is the output, not too many so let me fix them manually.
{noformat}
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousRegionCountCostFunction.java:
* * rs[0-9] 200 * rs1[0-9] 50
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaGroupingCostFunction.java:
* d, e, f where a and b are same replicas, and c,d,e are same replicas, it
returns (2-1) * (2-1)
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaGroupingCostFunction.java:
* + (3-1) * (3-1) + (1-1) * (1-1).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java:
* processors * size. Pay attention that 1.0 is different from 1, former
indicates it will use
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
* For each region R0, if R0 is bigger than S * 2, it is kindly requested
to split.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitWALManager.java:
* {@link SplitWALProcedure}. Total number of workers is (number of online
servers) *
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:
* Hard capacity limit of cache, will reject any put if size > this *
acceptable
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/package-info.java:
* usually means less GC headache), try enabling * BucketCache. Fetching will
always
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
* blocks requested * (1 + extraFreeFactor)
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/ByteBufferIOEngine.java:
* divided by 4 (hard-coded currently) * max size option. So using defaults,
buckets will be is 4 *
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java:
* Combined {@link #totalCount()} * {@link #itemSize()}
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Sum (MB) * 100 / Limit (MB) - 100; For example we set the limit = 500 and
were evicted 2000 MB.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Overhead is: 2000 * 100 / 500 - 100 = 300% The feature is going to reduce a
percent caching data
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* bytes less then the limit we have got negative overhead. For example if were
freed 200 MB: 200 *
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Hard capacity limit of cache, will reject any put if size > this *
acceptable
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PreviousBlockCompressionRatePredicator.java:
* BLOCK_SIZE * (uncompressed/compressed).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareCompactionThroughputController.java:
* (higer - lower) * compactionPressure, where compactionPressure is in
range [0.0, 1.0]
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareFlushThroughputController.java:
* lower) * flushPressure, where flushPressure is in range [0.0, 1.0)
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java:
* @return flushSize * 2 if there's exactly one region of the table in
question found on this
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/ExploringCompactionPolicy.java:
* FileSize(i) <= ( Sum(0,N,FileSize(_)) - FileSize(i)) * Ratio.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java:
* is, +/- 3.5 days (7 days * 0.5).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CellFlatMap.java:
* of the output is the possible insert index for the searched key In
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611925#comment-17611925
]
Duo Zhang commented on HBASE-27401:
---
This is the code I used to fix the style problem. And after running this code
and execute 'mvn spotless:apply' again, we could fix most of the problems.
{code}
import java.io.IOException;
import java.io.PrintWriter;
import java.io.UncheckedIOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.List;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
public class FixFormat {
private static Pattern N_IN_THE_MIDDLE = Pattern.compile(" n+ *\\*");
private static Pattern N_AT_THE_END = Pattern.compile("^(.*) +n+$");
private static Pattern JAVA_DOC_TAG = Pattern.compile(" *\\*
*@(param|throws|return) *\\w*");
private static void fix(Path path) throws IOException {
List lines = Files.readAllLines(path);
try (PrintWriter writer = new PrintWriter(path.toFile(),
StandardCharsets.UTF_8.name())) {
for (int i = 0; i < lines.size(); i++) {
String line = lines.get(i);
if (!line.trim().startsWith("*")) {
writer.println(line);
continue;
}
Matcher m = N_IN_THE_MIDDLE.matcher(line);
int start = 0;
while (m.find()) {
writer.println(line.substring(start, m.start()));
start = m.end() - 1;
}
String lastPart = line.substring(start);
if (!JAVA_DOC_TAG.matcher(lastPart).matches() || i == lines.size() - 1)
{
writer.println(lastPart);
continue;
}
String nextLine = lines.get(i + 1);
if (!nextLine.trim().startsWith("* @")) {
writer.print(lastPart);
writer.print(" ");
writer.println(nextLine.trim().substring(1));
i++;
} else {
writer.println(lastPart);
}
}
}
lines = Files.readAllLines(path);
try (PrintWriter writer = new PrintWriter(path.toFile(),
StandardCharsets.UTF_8.name())) {
for (int i = 0; i < lines.size(); i++) {
String line = lines.get(i);
if (!line.trim().startsWith("*")) {
writer.println(line);
continue;
}
Matcher m = N_AT_THE_END.matcher(line);
if (m.matches()) {
writer.print(m.group(1));
} else {
writer.println(line);
}
}
}
}
public static void main(String[] args) throws IOException {
Files.walk(Paths.get("/home/zhangduo/hbase/code")).filter(p ->
p.toFile().isFile())
.filter(p -> p.toFile().getName().endsWith(".java"))
.filter(p ->
!p.toAbsolutePath().toFile().getAbsolutePath().contains("/generated/"))
.filter(p ->
!p.toAbsolutePath().toFile().getAbsolutePath().contains("/target/"))
.forEach(p -> {
try {
fix(p);
} catch (IOException e) {
throw new UncheckedIOException(e);
}
});
}
}
{code}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611926#comment-17611926
]
Duo Zhang commented on HBASE-27401:
---
And I've added a check for finding the broken javadoc line where we trim the
javadoc incorrectly, with code like this
{code}
if (line.trim().substring(1).contains(" * ")) {
System.out.println(path + ":" + line);
}
{code}
This is the output, not too many so let me fix them manually.
{noformat}
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousRegionCountCostFunction.java:
* * rs[0-9] 200 * rs1[0-9] 50
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaGroupingCostFunction.java:
* d, e, f where a and b are same replicas, and c,d,e are same replicas, it
returns (2-1) * (2-1)
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaGroupingCostFunction.java:
* + (3-1) * (3-1) + (1-1) * (1-1).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java:
* processors * size. Pay attention that 1.0 is different from 1, former
indicates it will use
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java:
* This will be called before update META step as part of split table region
procedure. * * @param
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
* For each region R0, if R0 is bigger than S * 2, it is kindly requested
to split.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:
* Hard capacity limit of cache, will reject any put if size > this *
acceptable
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/package-info.java:
* usually means less GC headache), try enabling * BucketCache. Fetching will
always
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
* blocks requested * (1 + extraFreeFactor)
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/ByteBufferIOEngine.java:
* divided by 4 (hard-coded currently) * max size option. So using defaults,
buckets will be is 4 *
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java:
* Combined {@link #totalCount()} * {@link #itemSize()}
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Sum (MB) * 100 / Limit (MB) - 100; For example we set the limit = 500 and
were evicted 2000 MB.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Overhead is: 2000 * 100 / 500 - 100 = 300% The feature is going to reduce a
percent caching data
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Hard capacity limit of cache, will reject any put if size > this *
acceptable
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PreviousBlockCompressionRatePredicator.java:
* BLOCK_SIZE * (uncompressed/compressed).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareCompactionThroughputController.java:
* (higer - lower) * compactionPressure, where compactionPressure is in
range [0.0, 1.0]
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareFlushThroughputController.java:
* lower) * flushPressure, where flushPressure is in range [0.0, 1.0)
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java:
* @return flushSize * 2 if there's exactly one region of the table in
question found on this
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/ExploringCompactionPolicy.java:
* ) * Ratio.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java:
* is, +/- 3.5 days (7 days * 0.5).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java:
* multiplier * HConstants.THREAD_WAKE_FREQUENCY milliseconds.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java:
* * @return the result of fs.mkdirs(). In case underlying fs throws an
IOException, it checks
[jira] [Updated] (HBASE-27403) Remove 'Remove unhelpful javadoc stubs' spotless rule for now
[ https://issues.apache.org/jira/browse/HBASE-27403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27403: -- Status: Patch Available (was: Open) > Remove 'Remove unhelpful javadoc stubs' spotless rule for now > - > > Key: HBASE-27403 > URL: https://issues.apache.org/jira/browse/HBASE-27403 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Until we fix the spotless issue: > https://github.com/diffplug/spotless/issues/1359 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4809: HBASE-27403 Remove 'Remove unhelpful javadoc stubs' spotless rule for…
Apache-HBase commented on PR #4809: URL: https://github.com/apache/hbase/pull/4809#issuecomment-1264394086 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 6m 17s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 6m 16s | the patch passed | | +1 :green_heart: | javac | 6m 16s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 51s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 32m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4809/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4809 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux ecb1d858881f 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 23a56331db | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4809/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request, #4809: HBASE-27403 Remove 'Remove unhelpful javadoc stubs' spotless rule for…
Apache9 opened a new pull request, #4809: URL: https://github.com/apache/hbase/pull/4809 … now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27403) Remove 'Remove unhelpful javadoc stubs' spotless rule for now
Duo Zhang created HBASE-27403: - Summary: Remove 'Remove unhelpful javadoc stubs' spotless rule for now Key: HBASE-27403 URL: https://issues.apache.org/jira/browse/HBASE-27403 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang Assignee: Duo Zhang Until we fix the spotless issue: https://github.com/diffplug/spotless/issues/1359 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27402) Clone Scan in ClientScanner to avoid errors with Scan re-used
[ https://issues.apache.org/jira/browse/HBASE-27402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611914#comment-17611914 ] Bryan Beaudreault commented on HBASE-27402: --- Actually, this problem does not exist in master because it does not exist in AsyncTable. AsyncTable already clones the scan object. So this patch would just be for Table in branch-2, if accepted. > Clone Scan in ClientScanner to avoid errors with Scan re-used > - > > Key: HBASE-27402 > URL: https://issues.apache.org/jira/browse/HBASE-27402 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Priority: Major > > This has come up before in https://issues.apache.org/jira/browse/HBASE-1774 > and https://issues.apache.org/jira/browse/HBASE-4891. The major pushback was > around ScanMetrics, which relied on sharing a mutable Scan object. > Since https://issues.apache.org/jira/browse/HBASE-17584, ScanMetrics are > available on ResultScanner and the method on Scan was deprecated (removed in > master). > I think this issue became pretty urgent in > https://issues.apache.org/jira/browse/HBASE-17167, when we started passing > mvcc into the Scan object. If a user unknowingly reuses the Scan object, this > can seem like data loss since the Scan will return none of the expected data. > We recently hit this in our upgrade from hbase client 1.2 to 2.4.6, where > use-cases that had worked in 1.2 suddenly started returning no results in > 2.4.6. It's very hard to debug. > I suggest that we now add the clone in master branch. For branch-2, I think > we could put it behind a config param to preserve backwards compatibility of > Scan.getScanMetrics. If the config param is enabled, scan cloning occurs and > Scan.getScanMetrics will be inaccurate. Personally I think this is far better > scenario, because data result accuracy is more important than metrics. But we > can leave it to the user to decide, and provide a release note. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27402) Clone Scan in ClientScanner to avoid errors with Scan re-used
Bryan Beaudreault created HBASE-27402: - Summary: Clone Scan in ClientScanner to avoid errors with Scan re-used Key: HBASE-27402 URL: https://issues.apache.org/jira/browse/HBASE-27402 Project: HBase Issue Type: Improvement Reporter: Bryan Beaudreault This has come up before in https://issues.apache.org/jira/browse/HBASE-1774 and https://issues.apache.org/jira/browse/HBASE-4891. The major pushback was around ScanMetrics, which relied on sharing a mutable Scan object. Since https://issues.apache.org/jira/browse/HBASE-17584, ScanMetrics are available on ResultScanner and the method on Scan was deprecated (removed in master). I think this issue became pretty urgent in https://issues.apache.org/jira/browse/HBASE-17167, when we started passing mvcc into the Scan object. If a user unknowingly reuses the Scan object, this can seem like data loss since the Scan will return none of the expected data. We recently hit this in our upgrade from hbase client 1.2 to 2.4.6, where use-cases that had worked in 1.2 suddenly started returning no results in 2.4.6. It's very hard to debug. I suggest that we now add the clone in master branch. For branch-2, I think we could put it behind a config param to preserve backwards compatibility of Scan.getScanMetrics. If the config param is enabled, scan cloning occurs and Scan.getScanMetrics will be inaccurate. Personally I think this is far better scenario, because data result accuracy is more important than metrics. But we can leave it to the user to decide, and provide a release note. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1264355802 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 24s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 4m 20s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 59s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 38s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 20s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 6s | the patch passed | | +1 :green_heart: | compile | 4m 10s | the patch passed | | +1 :green_heart: | cc | 4m 10s | the patch passed | | -0 :warning: | javac | 0m 15s | hbase-replication generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | | -0 :warning: | javac | 0m 18s | hbase-procedure generated 1 new + 29 unchanged - 0 fixed = 30 total (was 29) | | -0 :warning: | javac | 2m 11s | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) | | -0 :warning: | checkstyle | 0m 28s | hbase-server: The patch generated 3 new + 8 unchanged - 0 fixed = 11 total (was 8) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 10s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 1m 39s | the patch passed | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 44m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux 626b1e57235b 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / de2d20aac2 | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-replication.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-procedure.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[ https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611897#comment-17611897 ] Duo Zhang commented on HBASE-27401: --- There thousands of broken lines... Let me see how to fix most of them by some awk or sed magics... > Clean up current broken 'n's in our javadoc > --- > > Key: HBASE-27401 > URL: https://issues.apache.org/jira/browse/HBASE-27401 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: ns_at_the_end, ns_in_the_middle > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27401) Clean up current broken 'n's in our javadoc
[ https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27401: -- Attachment: ns_in_the_middle > Clean up current broken 'n's in our javadoc > --- > > Key: HBASE-27401 > URL: https://issues.apache.org/jira/browse/HBASE-27401 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: ns_at_the_end, ns_in_the_middle > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27401) Clean up current broken 'n's in our javadoc
[ https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27401: -- Attachment: ns_at_the_end > Clean up current broken 'n's in our javadoc > --- > > Key: HBASE-27401 > URL: https://issues.apache.org/jira/browse/HBASE-27401 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: ns_at_the_end, ns_in_the_middle > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611895#comment-17611895
]
Duo Zhang commented on HBASE-27401:
---
I've run the following commands
{code}
find . -type f -name *.java | xargs egrep "^ *\*" | egrep " n+ "
find . -type f -name *.java | xargs egrep "^ *\*" | egrep " n+$"
{code}
Let me upload the result as attachedment.
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27400) The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead of '\n'
[ https://issues.apache.org/jira/browse/HBASE-27400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611894#comment-17611894 ] Duo Zhang commented on HBASE-27400: --- https://github.com/diffplug/spotless/issues/1359 > The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead > of '\n' > --- > > Key: HBASE-27400 > URL: https://issues.apache.org/jira/browse/HBASE-27400 > Project: HBase > Issue Type: Bug >Reporter: Duo Zhang >Priority: Major > > That's why there are lots of 'n' in our code base... > Let me find a way to fix this and clean up all the 'n's. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27401) Clean up current broken 'n's in our javadoc
[ https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27401 started by Duo Zhang. - > Clean up current broken 'n's in our javadoc > --- > > Key: HBASE-27401 > URL: https://issues.apache.org/jira/browse/HBASE-27401 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27401) Clean up current broken 'n's in our javadoc
Duo Zhang created HBASE-27401: - Summary: Clean up current broken 'n's in our javadoc Key: HBASE-27401 URL: https://issues.apache.org/jira/browse/HBASE-27401 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27401) Clean up current broken 'n's in our javadoc
[ https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27401: - Assignee: Duo Zhang > Clean up current broken 'n's in our javadoc > --- > > Key: HBASE-27401 > URL: https://issues.apache.org/jira/browse/HBASE-27401 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27400) The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead of '\n'
[ https://issues.apache.org/jira/browse/HBASE-27400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611893#comment-17611893 ] Duo Zhang commented on HBASE-27400: --- I've opened an issue in spotless, seems no other way besides changing the code in spotless... > The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead > of '\n' > --- > > Key: HBASE-27400 > URL: https://issues.apache.org/jira/browse/HBASE-27400 > Project: HBase > Issue Type: Bug >Reporter: Duo Zhang >Priority: Major > > That's why there are lots of 'n' in our code base... > Let me find a way to fix this and clean up all the 'n's. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27400) The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead of '\n'
Duo Zhang created HBASE-27400: - Summary: The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead of '\n' Key: HBASE-27400 URL: https://issues.apache.org/jira/browse/HBASE-27400 Project: HBase Issue Type: Bug Reporter: Duo Zhang That's why there are lots of 'n' in our code base... Let me find a way to fix this and clean up all the 'n's. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache9 commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1264341220 This is not the final patch yet, we still need to implement a bunch of UTs to verify all logics work as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4805: HBASE-27365 Minimise block addition failures due to no space in bucke…
Apache-HBase commented on PR #4805: URL: https://github.com/apache/hbase/pull/4805#issuecomment-1264320771 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 9s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 4m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 59s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 4m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 351m 21s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 5m 45s | hbase-external-blockcache in the patch passed. | | | | 381m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4805/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4805 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 98eb9e15cb8d 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 23a56331db | | Default Java | Temurin-1.8.0_345-b01 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4805/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4805/5/testReport/ | | Max. process+thread count | 2496 (vs. ulimit of 3) | | modules | C: hbase-server hbase-external-blockcache U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4805/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4805: HBASE-27365 Minimise block addition failures due to no space in bucke…
Apache-HBase commented on PR #4805: URL: https://github.com/apache/hbase/pull/4805#issuecomment-1264318156 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 32s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 4m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 4m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 328m 24s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 9m 11s | hbase-external-blockcache in the patch passed. | | | | 368m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4805/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4805 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 386f5719bd8d 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 23a56331db | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4805/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4805/5/testReport/ | | Max. process+thread count | 2686 (vs. ulimit of 3) | | modules | C: hbase-server hbase-external-blockcache U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4805/5/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611842#comment-17611842
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #24 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/24/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/24/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/24/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/24/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
