[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1272816305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 5s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 5m 40s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 1m 42s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 59s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 7m 37s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | +1 :green_heart: | compile | 6m 11s | the patch passed | | +1 :green_heart: | cc | 6m 11s | the patch passed | | -0 :warning: | javac | 0m 23s | hbase-replication generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) | | -0 :warning: | javac | 0m 34s | hbase-procedure generated 1 new + 29 unchanged - 0 fixed = 30 total (was 29) | | -0 :warning: | checkstyle | 0m 33s | hbase-server: The patch generated 3 new + 8 unchanged - 0 fixed = 11 total (was 8) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 10m 51s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 2m 30s | the patch passed | | +1 :green_heart: | spotless | 0m 58s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 9m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 49s | The patch does not generate ASF License warnings. | | | | 63m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool xml | | uname | Linux 84dfe792f73f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-replication.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-procedure.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 69 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache9 commented on code in PR #4811:
URL: https://github.com/apache/hbase/pull/4811#discussion_r990904958
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java:
##
@@ -314,4 +318,24 @@ public ZKWatcher getZooKeeper() {
return null;
}
}
+
+ private static class FSTableDescriptorsTest extends FSTableDescriptors {
Review Comment:
Do we really need this class? Just use Mockito to mock the return value of
exists method is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1272770320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 20s | master passed | | +1 :green_heart: | compile | 2m 59s | master passed | | +1 :green_heart: | checkstyle | 0m 46s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 0s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 12s | the patch passed | | +1 :green_heart: | compile | 2m 55s | the patch passed | | +1 :green_heart: | javac | 2m 55s | the patch passed | | +1 :green_heart: | checkstyle | 0m 45s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 47s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | -1 :x: | spotless | 0m 34s | patch has 32 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 2m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 32m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4820 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux ec95253a5052 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 69 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected
[
https://issues.apache.org/jira/browse/HBASE-26967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614865#comment-17614865
]
Duo Zhang commented on HBASE-26967:
---
There is a hasFilterRow method in Filter, I think if a filter does not support
filter row, we should not consider its filterRow result?
> FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with
> operator MUST_PASS_ONE doesn't work as expected
> -
>
> Key: HBASE-26967
> URL: https://issues.apache.org/jira/browse/HBASE-26967
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.4.11
>Reporter: Boris
>Priority: Blocker
>
> I created test table with two column families by hbase shell:
>
> {code:java}
> create 'test_table2', 'f1', 'f2'
> put 'test_table2', '1', 'f1:col1', 'a1'
> put 'test_table2', '1', 'f2:col2', 'a2'
> put 'test_table2', '2', 'f1:col1', 'b1'
> put 'test_table2', '2', 'f2:col2', 'b2' {code}
>
>
> The table contains of two rows (rowkeys '1' and '2'), tested FuzzyRowFilter
> selects first row,
> SingleColumnValueFilter selects no rows, combination of both filters
> evaluated with
> MUST_PASS_ONE operator returns surprisingly whole table. I prepared java
> examples to
> show this strange behavior.
>
> Code snippet below doesn't work as expected:
>
> {code:java}
> try (Table table = connection.getTable(TableName.valueOf("test_table2"))) {
> Scan scan = new Scan();
> scan.addFamily(Bytes.toBytes("f1"));
> scan.addFamily(Bytes.toBytes("f2"));
> Filter fuzzyRowFilter = new FuzzyRowFilter(List.of(new
> Pair<>(Bytes.toBytes("1"), new byte[] { 0x00 })));
> scan.setFilter(fuzzyRowFilter);
> System.out.println("result of fuzzy filter:");
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of single column value filter:");
> Filter singleColumnValueFilter = new
> SingleColumnValueFilter(Bytes.toBytes("f2"), Bytes.toBytes("col2"),
> CompareOperator.EQUAL,
> Bytes.toBytes("x"));
> scan.setFilter(singleColumnValueFilter);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of fuzzy or single column value filters:");
> FilterList filterList = new FilterList(Operator.MUST_PASS_ONE);
> filterList.addFilter(fuzzyRowFilter);
> filterList.addFilter(singleColumnValueFilter);
> scan.setFilter(filterList);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> } {code}
> Expected result in my opinion is:
>
> {quote}result of fuzzy filter:
> 1
> result of single column value filter:
> result of fuzzy or single column value filters:
> 1
> {quote}
> But i am getting (NOT OK):
> {quote}result of fuzzy filter:
> 1
> result of single column value filter:
> result of fuzzy or single column value filters:
> 1
> 2
> {quote}
>
> For tables with one column family or commentig out the line
> _{color:#00}scan{color}.addFamily({color:#00}Bytes{color}.toBytes({color:#067d17}"f1"{color}))_
> filter list evaluation is working OK. Similar example with PrefixFilter is
> working like a charm:
>
> {code:java}
> try (Table table = connection.getTable(TableName.valueOf("test_table2"))) {
> Scan scan = new Scan();
> scan.addFamily(Bytes.toBytes("f1"));
> scan.addFamily(Bytes.toBytes("f2"));
> Filter prefixFilter = new PrefixFilter(Bytes.toBytes("1"));
> scan.setFilter(prefixFilter);
> System.out.println("result of prefix filter:");
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of single column value filter:");
> Filter singleColumnValueFilter = new
> SingleColumnValueFilter(Bytes.toBytes("f2"), Bytes.toBytes("col2"),
> CompareOperator.EQUAL,
> Bytes.toBytes("x"));
> scan.setFilter(singleColumnValueFilter);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of prefix or single column value filters");
> FilterList filterList = new FilterList(Operator.MUST_PASS_ONE);
> filterList.addFilter(prefixFilter);
> filterList.addFilter(singleColumnValueFilter);
> scan.setFilter(filterList);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> } {code}
>
>
> Result OK{_}:{_}
> {quote}result of prefix filter:
> 1
> result of single column value filter:
> result of prefix or single column value filters
> 1
> {quote}
[GitHub] [hbase] chaijunjie0101 opened a new pull request, #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…
chaijunjie0101 opened a new pull request, #4820: URL: https://github.com/apache/hbase/pull/4820 …r evaluated with operator MUST_PASS_ONE doesn't work as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1272629326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 12s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 54s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 3m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 13s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 18s | the patch passed | | +1 :green_heart: | compile | 1m 53s | the patch passed | | +1 :green_heart: | javac | 1m 53s | the patch passed | | +1 :green_heart: | shadedjars | 3m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 29s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 26s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 1m 27s | hbase-procedure in the patch passed. | | -1 :x: | unit | 223m 19s | hbase-server in the patch failed. | | | | 248m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5bce74d822f6 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/testReport/ | | Max. process+thread count | 2835 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1272594316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 9s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 4m 9s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 57s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 36s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 31s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 4m 10s | the patch passed | | +1 :green_heart: | cc | 4m 10s | the patch passed | | -0 :warning: | javac | 0m 14s | hbase-replication generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) | | -0 :warning: | javac | 0m 20s | hbase-procedure generated 1 new + 29 unchanged - 0 fixed = 30 total (was 29) | | -0 :warning: | checkstyle | 0m 28s | hbase-server: The patch generated 3 new + 8 unchanged - 0 fixed = 11 total (was 8) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 57s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 1m 39s | the patch passed | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. | | | | 44m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool xml | | uname | Linux 05cad0f1decc 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-replication.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-procedure.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1272592477 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 19s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 0m 40s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 3m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 20s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | shadedjars | 3m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 227m 43s | hbase-server in the patch passed. | | | | 244m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4811 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d8ece38742f2 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/testReport/ | | Max. process+thread count | 3461 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1272589741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 34s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 0m 48s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 3m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 34s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 3m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 213m 46s | hbase-server in the patch failed. | | | | 231m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4811 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 60e2ce149021 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/testReport/ | | Max. process+thread count | 3046 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27355) Separate meta read requests from master and client
[ https://issues.apache.org/jira/browse/HBASE-27355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614716#comment-17614716 ] ruanhui commented on HBASE-27355: - Hi Duo Do you think we can use an additional RpcExecutor to specifically serve all internal system table requests ? Not only the master, the regionservers also accesses the system tables, like hbase:quota and hbase:replication. So if clients retry a lot, the replication maybe be blocked too(if we deploy hbase:meta and hbase:replication on same regionserver, which is common in our production to using a specific rsgroup to hold all system tables). Based on this consideration, is it better to seperate intenal requests (both from masters and regionservers, including the requests from CatalogJanitor) and client requests ? > Separate meta read requests from master and client > --- > > Key: HBASE-27355 > URL: https://issues.apache.org/jira/browse/HBASE-27355 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC >Affects Versions: 3.0.0-alpha-3 >Reporter: ruanhui >Assignee: ruanhui >Priority: Minor > Fix For: 3.0.0-alpha-4 > > > If we have a large number of store files in a single region or the response > from hdfs is slow, the region transition can be slow, the client may put a > lot of pressure on the meta server when retrying. This may block the master > system read requests. Maybe we can set a special priority for the master > request to isolate read requests from master and client. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1272549667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 2m 13s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 32s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 16s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 2m 16s | the patch passed | | +1 :green_heart: | javac | 2m 16s | the patch passed | | +1 :green_heart: | checkstyle | 0m 30s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 49s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 27m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4811 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 5fe8e33db06b 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 69 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/7/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614658#comment-17614658
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #26 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/26/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/26/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/26/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/26/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-25720) Sync WAL stuck when prepare flush cache will prevent flush cache and cause OOM
[ https://issues.apache.org/jira/browse/HBASE-25720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614598#comment-17614598 ] Xiaolin Ha commented on HBASE-25720: Hi, [~MarchWang] , I saw the problem you described in HBASE-27413. The idea here is to abort the RS ASAP when sync WAL failed, even in the stage of preparing to flush memstore, while currently only fail when committing the flush of memstore will abort the RS. The PR is not accepted, but you can backport it, we are using it on our production environment smoothly. For the sync wal stuck problems, several issues are helpful, I think they can solve mostly of your problems, especially HBASE-22301, HBASE-26347, and HBASE-25905. > Sync WAL stuck when prepare flush cache will prevent flush cache and cause OOM > -- > > Key: HBASE-25720 > URL: https://issues.apache.org/jira/browse/HBASE-25720 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.13 >Reporter: Xiaolin Ha >Assignee: Xiaolin Ha >Priority: Major > Attachments: prepare-flush-cache-stuck.png > > > We call HRegion#doSyncOfUnflushedWALChanges when preparing to flush cache. > But this WAL sync may stuck, and abort the flush of cache. > !prepare-flush-cache-stuck.png|width=519,height=246! > If we cannot aware of this problem in time, RS will OOM kill. > I think we should force abort RS when sync stuck in preparing, like in > committing snapshots. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
