[GitHub] [hbase] Apache-HBase commented on pull request #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150
Apache-HBase commented on PR #4822: URL: https://github.com/apache/hbase/pull/4822#issuecomment-1274121599 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 48s | master passed | | +1 :green_heart: | compile | 1m 53s | master passed | | +1 :green_heart: | shadedjars | 3m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 58s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 34s | the patch passed | | +1 :green_heart: | compile | 1m 53s | the patch passed | | +1 :green_heart: | javac | 1m 53s | the patch passed | | +1 :green_heart: | shadedjars | 3m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 272m 48s | root in the patch passed. | | | | 297m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4822/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4822 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6bb20269c2ae 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d2efc8aaa | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4822/1/testReport/ | | Max. process+thread count | 4743 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4822/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request, #4824: HBASE-27421 Bump spotless plugin to 2.27.2 and reimplement the 'Remov…
Apache9 opened a new pull request, #4824: URL: https://github.com/apache/hbase/pull/4824 …e unhelpful javadoc stubs' rule -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27421: - Assignee: Duo Zhang > Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc > stubs' rule > > > Key: HBASE-27421 > URL: https://issues.apache.org/jira/browse/HBASE-27421 > Project: HBase > Issue Type: Sub-task > Components: documentation, pom >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > spotless maven 2.27.2 is released and it contains > https://github.com/diffplug/spotless/issues/1359, which allows the > replacement to be null, so we can add back the 'Remove unhelpful javadoc > stubs' rule now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27421 started by Duo Zhang. - > Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc > stubs' rule > > > Key: HBASE-27421 > URL: https://issues.apache.org/jira/browse/HBASE-27421 > Project: HBase > Issue Type: Sub-task > Components: documentation, pom >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > spotless maven 2.27.2 is released and it contains > https://github.com/diffplug/spotless/issues/1359, which allows the > replacement to be null, so we can add back the 'Remove unhelpful javadoc > stubs' rule now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
2005hithlj commented on code in PR #4811:
URL: https://github.com/apache/hbase/pull/4811#discussion_r991828225
##
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/TableReplicationQueueStorage.java:
##
@@ -532,4 +532,13 @@ public Set getAllHFileRefs() throws
ReplicationException {
throw new ReplicationException("failed to getAllHFileRefs", e);
}
}
+
+ @Override
+ public boolean hasData() throws ReplicationException {
+try {
+ return conn.getAdmin().getDescriptor(tableName) != null;
Review Comment:
@Apache9 sir
Well, we can only use admin here, unless the masterServices is passed in
the constructor of TableReplicationQueueStorage,so do we need to optimize
further?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1274097018 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 21s | master passed | | +1 :green_heart: | compile | 1m 37s | master passed | | +1 :green_heart: | shadedjars | 3m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 41s | master passed | | -0 :warning: | patch | 7m 4s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 1m 33s | the patch passed | | +1 :green_heart: | javac | 1m 33s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 1m 26s | root generated 13 new + 69 unchanged - 15 fixed = 82 total (was 84) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 361m 30s | root in the patch passed. | | | | 386m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4556 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1d404b81a4ba 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/8/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/8/testReport/ | | Max. process+thread count | 4573 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-hadoop-compat hbase-client hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1274040172 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 50s | master passed | | +1 :green_heart: | compile | 1m 47s | master passed | | +1 :green_heart: | shadedjars | 4m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 58s | master passed | | -0 :warning: | patch | 7m 40s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 1m 47s | the patch passed | | +1 :green_heart: | javac | 1m 47s | the patch passed | | +1 :green_heart: | shadedjars | 4m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 256m 37s | root in the patch passed. | | | | 284m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4556 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 418793dbfd57 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/8/testReport/ | | Max. process+thread count | 4923 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-hadoop-compat hbase-client hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a diff in pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server
virajjasani commented on code in PR #4823:
URL: https://github.com/apache/hbase/pull/4823#discussion_r991778115
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -314,7 +314,9 @@ private void succeed(Channel ch) throws IOException {
}
private void fail(Channel ch, Throwable error) {
- failInit(ch, toIOE(error));
+ IOException ex = toIOE(error);
+ LOG.warn("Exception encountered while connecting to the server " +
remoteId.getAddress(), ex);
+ failInit(ch, toIOE(ex));
Review Comment:
Yes, once this is addressed, +1 for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache9 commented on code in PR #4811:
URL: https://github.com/apache/hbase/pull/4811#discussion_r991774124
##
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/TableReplicationQueueStorage.java:
##
@@ -532,4 +532,13 @@ public Set getAllHFileRefs() throws
ReplicationException {
throw new ReplicationException("failed to getAllHFileRefs", e);
}
}
+
+ @Override
+ public boolean hasData() throws ReplicationException {
+try {
+ return conn.getAdmin().getDescriptor(tableName) != null;
Review Comment:
Oh, here we can only use Admin...
Anyone, can be a follow on issue to see if we can use master services
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1274026630 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 43s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 0s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 3m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 30s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 3m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 17s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 217m 59s | hbase-server in the patch passed. | | | | 237m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4811 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux eff02a1de9d3 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/9/testReport/ | | Max. process+thread count | 3286 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/9/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[ https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615433#comment-17615433 ] Lijin Bin commented on HBASE-27414: --- Can you supply any patch? > Search order for locations in HFileLink > > > Key: HBASE-27414 > URL: https://issues.apache.org/jira/browse/HBASE-27414 > Project: HBase > Issue Type: Improvement > Components: Performance >Reporter: Huaxiang Sun >Priority: Minor > > Found that search order for locations is following the order of these > locations added to HFileLink object. > > setLocations(originPath, tempPath, mobPath, archivePath); > archivePath is the last one to be searched. For most cases, hfile exists in > archivePath, so we can move archivePath to the first parameter to avoid > unnecessary NN query. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27419) Update to hbase-thirdparty 4.1.2
[ https://issues.apache.org/jira/browse/HBASE-27419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27419. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4+. Thanks [~apurtell] for reviewing! > Update to hbase-thirdparty 4.1.2 > > > Key: HBASE-27419 > URL: https://issues.apache.org/jira/browse/HBASE-27419 > Project: HBase > Issue Type: Bug > Components: dependencies >Affects Versions: 2.5.0, 2.4.14 >Reporter: Andrew Kyle Purtell >Assignee: Duo Zhang >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15 > > > Update to hbase-thirdparty 4.1.2 when it is released. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27314) Make index block be customized and configured
[ https://issues.apache.org/jira/browse/HBASE-27314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin resolved HBASE-27314. --- Resolution: Fixed > Make index block be customized and configured > - > > Key: HBASE-27314 > URL: https://issues.apache.org/jira/browse/HBASE-27314 > Project: HBase > Issue Type: New Feature >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4 > > > Current the index block use a flat structure and can not support other > format, we can explore other structure to use it like the data block encoding. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27314) Make index block be customized and configured
[ https://issues.apache.org/jira/browse/HBASE-27314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin reassigned HBASE-27314: - Fix Version/s: 2.6.0 2.5.1 3.0.0-alpha-4 Assignee: Lijin Bin > Make index block be customized and configured > - > > Key: HBASE-27314 > URL: https://issues.apache.org/jira/browse/HBASE-27314 > Project: HBase > Issue Type: New Feature >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4 > > > Current the index block use a flat structure and can not support other > format, we can explore other structure to use it like the data block encoding. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] sunhelly commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen
sunhelly commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1274002030 Thanks @apurtell for the review, I'll dig more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server
Apache-HBase commented on PR #4823: URL: https://github.com/apache/hbase/pull/4823#issuecomment-1274000797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | master passed | | +1 :green_heart: | compile | 0m 37s | master passed | | +1 :green_heart: | shadedjars | 6m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | shadedjars | 5m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 25s | hbase-client in the patch passed. | | | | 26m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4823 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7b85759af385 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 79f853ee7c | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/testReport/ | | Max. process+thread count | 192 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server
Apache-HBase commented on PR #4823: URL: https://github.com/apache/hbase/pull/4823#issuecomment-1273998887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 27s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | checkstyle | 0m 17s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 0m 36s | the patch passed | | +1 :green_heart: | javac | 0m 36s | the patch passed | | -0 :warning: | checkstyle | 0m 14s | hbase-client: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 55s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | -1 :x: | spotless | 0m 17s | patch has 44 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 0m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 23m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4823 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux b40a7dabe1af 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 79f853ee7c | | Default Java | Temurin-1.8.0_345-b01 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server
Apache-HBase commented on PR #4823: URL: https://github.com/apache/hbase/pull/4823#issuecomment-1273995115 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 23s | master passed | | +1 :green_heart: | compile | 0m 15s | master passed | | +1 :green_heart: | shadedjars | 4m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 6s | the patch passed | | +1 :green_heart: | compile | 0m 16s | the patch passed | | +1 :green_heart: | javac | 0m 16s | the patch passed | | +1 :green_heart: | shadedjars | 4m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | | | 16m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4823 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fcc895ecc733 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 79f853ee7c | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/testReport/ | | Max. process+thread count | 164 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4823/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4823: HBASE-27339 Improve sasl connection failure log message to include server
Apache9 commented on code in PR #4823:
URL: https://github.com/apache/hbase/pull/4823#discussion_r991747624
##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -314,7 +314,9 @@ private void succeed(Channel ch) throws IOException {
}
private void fail(Channel ch, Throwable error) {
- failInit(ch, toIOE(error));
+ IOException ex = toIOE(error);
+ LOG.warn("Exception encountered while connecting to the server " +
remoteId.getAddress(), ex);
+ failInit(ch, toIOE(ex));
Review Comment:
Should be `failInit(ch, ex)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] dependabot[bot] closed pull request #4815: Bump protobuf-java from 3.17.3 to 3.19.6 in /hbase-examples
dependabot[bot] closed pull request #4815: Bump protobuf-java from 3.17.3 to 3.19.6 in /hbase-examples URL: https://github.com/apache/hbase/pull/4815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] dependabot[bot] commented on pull request #4815: Bump protobuf-java from 3.17.3 to 3.19.6 in /hbase-examples
dependabot[bot] commented on PR #4815: URL: https://github.com/apache/hbase/pull/4815#issuecomment-1273984533 Looks like com.google.protobuf:protobuf-java is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2
Apache9 merged PR #4818: URL: https://github.com/apache/hbase/pull/4818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27339) Improve sasl connection failure log message to include server
[
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-27339:
Status: Patch Available (was: Open)
> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in
> the blockingRPC client. Knowing which server we failed to connect to would
> help isolate and understand the issue.
>
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server :
> java.io.IOException: Connection reset by peer {code}
>
>
> Change the log message to something like
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server myhost.realm.net:
> java.io.IOException: Connection reset by peer {code}
>
> See relevant code
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] apurtell opened a new pull request, #4823: HBASE-27339 Improve sasl connection failure log message to include server
apurtell opened a new pull request, #4823: URL: https://github.com/apache/hbase/pull/4823 Include the remote server name in the logged exception message when the connection setup fails in BlockingRpcConnection. Add an equivalent log line in NettyRpcConnection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4821: HBASE-27423 Upgrade Jackson for CVE-2022-42003/42004
Apache9 commented on PR #4821: URL: https://github.com/apache/hbase/pull/4821#issuecomment-1273983170 2.14.0-rc2 is out, maybe we should wait for 2.14.0 final release and then upgrading? Will need a new thirdparty release then... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27339) Improve sasl connection failure log message to include server
[
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-27339:
Fix Version/s: 2.5.1
(was: 2.5.2)
> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in
> the blockingRPC client. Knowing which server we failed to connect to would
> help isolate and understand the issue.
>
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server :
> java.io.IOException: Connection reset by peer {code}
>
>
> Change the log message to something like
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server myhost.realm.net:
> java.io.IOException: Connection reset by peer {code}
>
> See relevant code
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HBASE-27339) Improve sasl connection failure log message to include server
[
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell reassigned HBASE-27339:
---
Assignee: Andrew Kyle Purtell
> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.15, 2.5.2
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in
> the blockingRPC client. Knowing which server we failed to connect to would
> help isolate and understand the issue.
>
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server :
> java.io.IOException: Connection reset by peer {code}
>
>
> Change the log message to something like
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server myhost.realm.net:
> java.io.IOException: Connection reset by peer {code}
>
> See relevant code
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on pull request #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150
Apache9 commented on PR #4822: URL: https://github.com/apache/hbase/pull/4822#issuecomment-1273979438 The jettison dependency is introduced by hadoop. I'm not sure whether upgrading jettison directly will break hadoop. There is a related issue in hadoop to fix jettison. https://issues.apache.org/jira/browse/HADOOP-18468 Let's check the PR there first to see if there are any breaking changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150
Apache-HBase commented on PR #4822: URL: https://github.com/apache/hbase/pull/4822#issuecomment-1273973300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 6m 14s | master passed | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 6s | the patch passed | | +1 :green_heart: | compile | 6m 14s | the patch passed | | +1 :green_heart: | javac | 6m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 0s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 8m 23s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 32m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4822/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4822 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux 9f9094cb2a8c 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d2efc8aaa | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4822/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4821: HBASE-27423 Upgrade Jackson for CVE-2022-42003/42004
Apache-HBase commented on PR #4821: URL: https://github.com/apache/hbase/pull/4821#issuecomment-1273965732 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 19s | master passed | | +1 :green_heart: | compile | 6m 21s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 6m 26s | the patch passed | | -0 :warning: | javac | 6m 26s | root generated 2 new + 701 unchanged - 2 fixed = 703 total (was 703) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 0s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 59s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 32m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4821/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4821 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux eefa38f0e25f 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8d2efc8aaa | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4821/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4821/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27424) Upgrade Jettison for CVE-2022-40149/40150
[ https://issues.apache.org/jira/browse/HBASE-27424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27424: Status: Patch Available (was: Open) > Upgrade Jettison for CVE-2022-40149/40150 > - > > Key: HBASE-27424 > URL: https://issues.apache.org/jira/browse/HBASE-27424 > Project: HBase > Issue Type: Bug >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15 > > > Jettison versions <= 1.5.0 are subject to CVE-2022-40149 and CVE-2022-40150. > Move jettison.version to 1.5.1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] apurtell commented on pull request #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150
apurtell commented on PR #4822: URL: https://github.com/apache/hbase/pull/4822#issuecomment-1273951689 Checked before push with tests in `hbase-rest`. All passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell opened a new pull request, #4822: HBASE-27424 Upgrade Jettison for CVE-2022-40149/40150
apurtell opened a new pull request, #4822: URL: https://github.com/apache/hbase/pull/4822 Jettison versions <= 1.5.0 are subject to CVE-2022-40149 and CVE-2022-40150. Move jettison.version to 1.5.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27424) Upgrade Jettison for CVE-2022-40149/40150
Andrew Kyle Purtell created HBASE-27424: --- Summary: Upgrade Jettison for CVE-2022-40149/40150 Key: HBASE-27424 URL: https://issues.apache.org/jira/browse/HBASE-27424 Project: HBase Issue Type: Bug Reporter: Andrew Kyle Purtell Assignee: Andrew Kyle Purtell Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15 Jettison versions <= 1.5.0 are subject to CVE-2022-40149 and CVE-2022-40150. Move jettison.version to 1.5.1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27423) Upgrade Jackson for CVE-2022-42003/42004
[ https://issues.apache.org/jira/browse/HBASE-27423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27423: Status: Patch Available (was: Open) > Upgrade Jackson for CVE-2022-42003/42004 > > > Key: HBASE-27423 > URL: https://issues.apache.org/jira/browse/HBASE-27423 > Project: HBase > Issue Type: Bug >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15 > > > Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes > CVE-2022-42004. > Move jackson.version to 2.13.4. > Move jackson.databind.version to 2.14.0-rc1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] apurtell opened a new pull request, #4821: HBASE-27423 Upgrade Jackson for CVE-2022-42003/42004
apurtell opened a new pull request, #4821: URL: https://github.com/apache/hbase/pull/4821 Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes CVE-2022-42004. Move jackson.version to 2.13.4. Move jackson.databind.version to 2.14.0-rc1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27423) Upgrade Jackson for CVE-2022-42003/42004
Andrew Kyle Purtell created HBASE-27423: --- Summary: Upgrade Jackson for CVE-2022-42003/42004 Key: HBASE-27423 URL: https://issues.apache.org/jira/browse/HBASE-27423 Project: HBase Issue Type: Bug Reporter: Andrew Kyle Purtell Assignee: Andrew Kyle Purtell Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15 Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes CVE-2022-42004. Move jackson.version to 2.13.4. Move jackson.databind.version to 2.14.0-rc1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27411) Update and clean up bcprov-jdk15on dependency
[
https://issues.apache.org/jira/browse/HBASE-27411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-27411:
Fix Version/s: 2.4.15
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Update and clean up bcprov-jdk15on dependency
> --
>
> Key: HBASE-27411
> URL: https://issues.apache.org/jira/browse/HBASE-27411
> Project: HBase
> Issue Type: Task
> Components: build
>Affects Versions: 3.0.0-alpha-4
>Reporter: Nick Dimiduk
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> {noformat}
> $ env
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> mvn -T0.5C clean install -DskipTests
>
> [INFO] Scanning for projects...
>
>
> [WARNING]
>
>
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.hbase:hbase-server:jar:3.0.0-alpha-4-SNAPSHOT
>
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.bouncycastle:bcprov-jdk15on:jar -> duplicate declaration of
> version (?) @ line 331, column 17
> [WARNING]
>
>
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
>
> [WARNING]
>
>
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
>
> [WARNING]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1273921294 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 22s | master passed | | +1 :green_heart: | compile | 6m 5s | master passed | | +1 :green_heart: | checkstyle | 0m 57s | master passed | | +0 :ok: | refguide | 2m 16s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 0m 38s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 12m 11s | master passed | | -0 :warning: | patch | 1m 45s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 3s | the patch passed | | +1 :green_heart: | compile | 6m 5s | the patch passed | | +1 :green_heart: | cc | 6m 5s | the patch passed | | -0 :warning: | javac | 6m 5s | root generated 2 new + 701 unchanged - 2 fixed = 703 total (was 703) | | -0 :warning: | checkstyle | 0m 57s | root: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 1m 52s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 8m 15s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 3m 59s | the patch passed | | -1 :x: | spotless | 0m 31s | patch has 33 errors when running spotless:check, run spotless:apply to fix. | | -1 :x: | spotbugs | 1m 21s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -1 :x: | spotbugs | 6m 50s | root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 43s | The patch does not generate ASF License warnings. | | | | 69m 18s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Nullcheck of entry at line 358 of value previously dereferenced in org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.filterEntry(WAL$Entry) At ReplicationSourceWALReader.java:358 of value previously dereferenced in org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.filterEntry(WAL$Entry) At ReplicationSourceWALReader.java:[line 354] | | FindBugs | module:root | | | Nullcheck of entry at line 358 of value previously dereferenced in org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.filterEntry(WAL$Entry) At ReplicationSourceWALReader.java:358 of value previously dereferenced in org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.filterEntry(WAL$Entry) At ReplicationSourceWALReader.java:[line 354] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4556 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide xml cc hbaseprotoc prototool | | uname | Linux 4a33ecce8670 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4556/8/yetus-general-check/output/branch-site/book.html | | javac |
[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273913802 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 17s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 2m 35s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 40s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 41s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 2m 34s | the patch passed | | +1 :green_heart: | javac | 2m 34s | the patch passed | | +1 :green_heart: | checkstyle | 0m 40s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 3s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 51s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 31m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4811 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 55358444640b 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 60 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/9/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell merged pull request #4817: HBASE-27411 Update and clean up bcprov-jdk15on dependency
apurtell merged PR #4817: URL: https://github.com/apache/hbase/pull/4817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] shahrs87 commented on a diff in pull request #4556: HBASE-26913 Replication Observability Framework
shahrs87 commented on code in PR #4556:
URL: https://github.com/apache/hbase/pull/4556#discussion_r991680391
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationMarkerChore.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.replication.regionserver;
+
+import static
org.apache.hadoop.hbase.replication.master.ReplicationSinkTrackerTableCreator.REPLICATION_SINK_TRACKER_TABLE_NAME;
+
+import java.io.IOException;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.ScheduledChore;
+import org.apache.hadoop.hbase.Stoppable;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.RegionInfoBuilder;
+import org.apache.hadoop.hbase.regionserver.MultiVersionConcurrencyControl;
+import org.apache.hadoop.hbase.regionserver.RegionServerServices;
+import org.apache.hadoop.hbase.regionserver.wal.WALUtil;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.hadoop.hbase.wal.WAL;
+import org.apache.hadoop.hbase.wal.WALEdit;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * This chore is responsible to create replication marker rows with special
WALEdit with family as
+ * {@link org.apache.hadoop.hbase.wal.WALEdit#METAFAMILY} and column qualifier
as
+ * {@link WALEdit#REPLICATION_MARKER} and empty value. If config key
+ * {@link #REPLICATION_MARKER_ENABLED_KEY} is set to true, then we will create
1 marker row every
+ * {@link #REPLICATION_MARKER_CHORE_DURATION_KEY} ms
+ * {@link
org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader}
will populate
+ * the Replication Marker edit with region_server_name, wal_name and
wal_offset encoded in
+ * {@link
org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos.ReplicationMarkerDescriptor}
+ * object. {@link
org.apache.hadoop.hbase.replication.regionserver.Replication} will change the
+ * REPLICATION_SCOPE for this edit to GLOBAL so that it can replicate. On the
sink cluster,
+ * {@link org.apache.hadoop.hbase.replication.regionserver.ReplicationSink}
will convert the
+ * ReplicationMarkerDescriptor into a Put mutation to
REPLICATION_SINK_TRACKER_TABLE_NAME_STR table.
+ */
+@InterfaceAudience.Private
+public class ReplicationMarkerChore extends ScheduledChore {
+ private static final Logger LOG =
LoggerFactory.getLogger(ReplicationMarkerChore.class);
+ private static final MultiVersionConcurrencyControl MVCC = new
MultiVersionConcurrencyControl();
+ public static final RegionInfo REGION_INFO =
+RegionInfoBuilder.newBuilder(REPLICATION_SINK_TRACKER_TABLE_NAME).build();
+ private static final String DELIMITER = "_";
+ private final Configuration conf;
+ private final RegionServerServices rsServices;
+ private WAL wal;
+
+ public static final String REPLICATION_MARKER_ENABLED_KEY =
+"hbase.regionserver.replication.marker.enabled";
+ public static final boolean REPLICATION_MARKER_ENABLED_DEFAULT = false;
+
+ public static final String REPLICATION_MARKER_CHORE_DURATION_KEY =
+"hbase.regionserver.replication.marker.chore.duration";
+ public static final int REPLICATION_MARKER_CHORE_DURATION_DEFAULT = 30 *
1000; // 30 seconds
+
+ public ReplicationMarkerChore(final Stoppable stopper, final
RegionServerServices rsServices,
+int period, Configuration conf) {
+super("ReplicationTrackerChore", stopper, period);
+this.conf = conf;
+this.rsServices = rsServices;
+ }
+
+ @Override
+ protected void chore() {
+if (wal == null) {
+ try {
+wal = rsServices.getWAL(null);
+ } catch (IOException ioe) {
+LOG.warn("Unable to get WAL ", ioe);
+// Shouldn't happen. Ignore and wait for the next chore run.
+return;
+ }
+}
+String serverName = rsServices.getServerName().getServerName();
+long timeStamp = EnvironmentEdgeManager.currentTime();
+// We only have timestamp in ReplicationMarkerDescriptor and the remaining
properties walname,
+// regionserver name and wal offset at
[GitHub] [hbase] Apache-HBase commented on pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2
Apache-HBase commented on PR #4818: URL: https://github.com/apache/hbase/pull/4818#issuecomment-1273838797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 1m 49s | master passed | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 6s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 1m 52s | the patch passed | | +1 :green_heart: | javac | 1m 52s | the patch passed | | +1 :green_heart: | shadedjars | 5m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 435m 19s | root in the patch passed. | | | | 462m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4818 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a835ac402e83 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/testReport/ | | Max. process+thread count | 4786 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-27422) Support replication for hbase:acl
[ https://issues.apache.org/jira/browse/HBASE-27422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27422 started by Shanmukha Haripriya Kota. > Support replication for hbase:acl > - > > Key: HBASE-27422 > URL: https://issues.apache.org/jira/browse/HBASE-27422 > Project: HBase > Issue Type: Improvement > Components: acl, Replication >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > As of now, we allow replication only for user tables. > We should support replication for hbase:acl as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2
Apache-HBase commented on PR #4818: URL: https://github.com/apache/hbase/pull/4818#issuecomment-1273682475 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 17s | master passed | | +1 :green_heart: | compile | 2m 33s | master passed | | +1 :green_heart: | shadedjars | 4m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 7s | the patch passed | | +1 :green_heart: | compile | 2m 16s | the patch passed | | +1 :green_heart: | javac | 2m 16s | the patch passed | | +1 :green_heart: | shadedjars | 4m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 0s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 256m 53s | root in the patch failed. | | | | 287m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4818 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3c4a7625294a 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/testReport/ | | Max. process+thread count | 2408 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615265#comment-17615265 ] Sandeep Pal commented on HBASE-25848: - This solved the problem since we used it in the our customer replication endpoint which was using the custom WALEntryFilter. > Add flexibility to backup replication in case replication filter throws an > exception > > > Key: HBASE-25848 > URL: https://issues.apache.org/jira/browse/HBASE-25848 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1, 1.6.0, 1.8.0, 2.6.0 >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.3.6, 2.4.4 > > > There may be situations when the wal entry filter might result in some > temporary issues but expected to recover at some point in time. In this case, > we should have an option to backup replication and retry until the wal entry > filter recovers instead of just aborting the region server. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615259#comment-17615259
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #27 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/27/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/27/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/27/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/27/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-27422) Support replication for hbase:acl
Shanmukha Haripriya Kota created HBASE-27422: Summary: Support replication for hbase:acl Key: HBASE-27422 URL: https://issues.apache.org/jira/browse/HBASE-27422 Project: HBase Issue Type: Improvement Components: acl, Replication Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota As of now, we allow replication only for user tables. We should support replication for hbase:acl as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273593399 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 0m 51s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 4m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 31s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 57s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 4m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 212m 31s | hbase-server in the patch passed. | | | | 233m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4811 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux eed9241b4a65 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/8/testReport/ | | Max. process+thread count | 2662 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4788: HBASE-21521 Expose master startup status via web UI
Apache-HBase commented on PR #4788: URL: https://github.com/apache/hbase/pull/4788#issuecomment-1273559031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 42s | master passed | | +1 :green_heart: | compile | 0m 42s | master passed | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | shadedjars | 4m 30s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 28s | hbase-server generated 1 new + 23 unchanged - 0 fixed = 24 total (was 23) | ||| _ Other Tests _ | | -1 :x: | unit | 242m 32s | hbase-server in the patch failed. | | | | 261m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4788 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7510ea9f1c84 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/testReport/ | | Max. process+thread count | 2606 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4788: HBASE-21521 Expose master startup status via web UI
Apache-HBase commented on PR #4788: URL: https://github.com/apache/hbase/pull/4788#issuecomment-1273505183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 56s | master passed | | +1 :green_heart: | compile | 0m 41s | master passed | | +1 :green_heart: | shadedjars | 3m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 24s | the patch passed | | +1 :green_heart: | compile | 0m 41s | the patch passed | | +1 :green_heart: | javac | 0m 41s | the patch passed | | +1 :green_heart: | shadedjars | 3m 55s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 23s | hbase-server generated 1 new + 96 unchanged - 0 fixed = 97 total (was 96) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 197m 37s | hbase-server in the patch passed. | | | | 217m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4788 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 02134a95c43d 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/testReport/ | | Max. process+thread count | 2686 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27421: -- Description: spotless maven 2.27.2 is released and it contains https://github.com/diffplug/spotless/issues/1359, which allows the replacement to be null, so we can add back the 'Remove unhelpful javadoc stubs' rule now. (was: spotless maven 2.27.2 is released and it contains https://github.com/diffplug/spotless/issues/1359, which allows the replacement to be null, so we can add back the ) > Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc > stubs' rule > > > Key: HBASE-27421 > URL: https://issues.apache.org/jira/browse/HBASE-27421 > Project: HBase > Issue Type: Sub-task > Components: documentation, pom >Reporter: Duo Zhang >Priority: Major > > spotless maven 2.27.2 is released and it contains > https://github.com/diffplug/spotless/issues/1359, which allows the > replacement to be null, so we can add back the 'Remove unhelpful javadoc > stubs' rule now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27421: -- Description: spotless maven 2.27.2 is released and it contains https://github.com/diffplug/spotless/issues/1359, which allows the replacement to be null, so we can add back the > Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc > stubs' rule > > > Key: HBASE-27421 > URL: https://issues.apache.org/jira/browse/HBASE-27421 > Project: HBase > Issue Type: Sub-task > Components: documentation, pom >Reporter: Duo Zhang >Priority: Major > > spotless maven 2.27.2 is released and it contains > https://github.com/diffplug/spotless/issues/1359, which allows the > replacement to be null, so we can add back the -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27403) Remove 'Remove unhelpful javadoc stubs' spotless rule for now
[ https://issues.apache.org/jira/browse/HBASE-27403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27403: -- Component/s: pom > Remove 'Remove unhelpful javadoc stubs' spotless rule for now > - > > Key: HBASE-27403 > URL: https://issues.apache.org/jira/browse/HBASE-27403 > Project: HBase > Issue Type: Sub-task > Components: documentation, pom >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15 > > > Until we fix the spotless issue: > https://github.com/diffplug/spotless/issues/1359 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27421: -- Component/s: documentation pom > Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc > stubs' rule > > > Key: HBASE-27421 > URL: https://issues.apache.org/jira/browse/HBASE-27421 > Project: HBase > Issue Type: Sub-task > Components: documentation, pom >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
Duo Zhang created HBASE-27421: - Summary: Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule Key: HBASE-27421 URL: https://issues.apache.org/jira/browse/HBASE-27421 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen
Apache-HBase commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1273455845 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 32s | master passed | | +1 :green_heart: | compile | 0m 41s | master passed | | +1 :green_heart: | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 3s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed | | +1 :green_heart: | javac | 0m 44s | the patch passed | | +1 :green_heart: | shadedjars | 4m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 294m 49s | hbase-server in the patch failed. | | | | 315m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4732 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c164fcae4272 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/testReport/ | | Max. process+thread count | 2385 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen
Apache-HBase commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1273434696 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | master passed | | +1 :green_heart: | compile | 0m 52s | master passed | | +1 :green_heart: | shadedjars | 4m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 13s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 4m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 277m 40s | hbase-server in the patch failed. | | | | 299m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4732 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 667e2992e21a 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/testReport/ | | Max. process+thread count | 2461 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2
Apache-HBase commented on PR #4818: URL: https://github.com/apache/hbase/pull/4818#issuecomment-1273395213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 19s | master passed | | +1 :green_heart: | compile | 6m 2s | master passed | | +1 :green_heart: | spotless | 0m 37s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 3s | the patch passed | | +1 :green_heart: | compile | 5m 56s | the patch passed | | -0 :warning: | javac | 5m 56s | root generated 12 new + 691 unchanged - 12 fixed = 703 total (was 703) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 8m 8s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 32m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4818 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux d53c3478ce90 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 140 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-examples . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
2005hithlj commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273319765 > > In this PR please, so in ReplicationLogCleaner we do not need to use TableDescriptors to test whether the table exists, then we do not need to modify some of the UTs? OK. sir. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache-HBase commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273319719 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 2m 17s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 31s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 38s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 18s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 2m 17s | the patch passed | | +1 :green_heart: | javac | 2m 17s | the patch passed | | +1 :green_heart: | checkstyle | 0m 30s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 49s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 27m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4811 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux ed3b7504359e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4811/8/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache9 commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273315904 In this PR please, so in ReplicationLogCleaner we do not need to use TableDescriptors to test whether the table exists, then we do not need to modify some of the UTs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
2005hithlj commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273313026 > > > Maybe we'd better add a method in ReplicationQueueStorage to test whether there are queue data? It could hide the implementation detail. > > > > > > @Apache9 sir, Can you give me some details. > > Just add a hasData method to ReplicationQueueStorage? In the implementation we could check whether the table exists. sir. Do we implement it based on this PR or open a new PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache9 commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273298122 > > Maybe we'd better add a method in ReplicationQueueStorage to test whether there are queue data? It could hide the implementation detail. > > @Apache9 sir, Can you give me some details. Just add a hasData method to ReplicationQueueStorage? In the implementation we could check whether the table exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
2005hithlj commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1273292894 > Maybe we'd better add a method in ReplicationQueueStorage to test whether there are queue data? It could hide the implementation detail. @Apache9 sir, Can you give me some details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
2005hithlj commented on code in PR #4811:
URL: https://github.com/apache/hbase/pull/4811#discussion_r991271572
##
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestLogsCleaner.java:
##
@@ -314,4 +318,24 @@ public ZKWatcher getZooKeeper() {
return null;
}
}
+
+ private static class FSTableDescriptorsTest extends FSTableDescriptors {
Review Comment:
> Do we really need this class? Just use Mockito to mock the return value of
exists method is enough?
Yes, it can be done. And the new implementation is in the new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4788: HBASE-21521 Expose master startup status via web UI
Apache-HBase commented on PR #4788: URL: https://github.com/apache/hbase/pull/4788#issuecomment-1273247018 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 26s | master passed | | +1 :green_heart: | compile | 2m 15s | master passed | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 21s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 2m 14s | the patch passed | | -0 :warning: | javac | 2m 14s | hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193) | | -0 :warning: | checkstyle | 0m 31s | hbase-server: The patch generated 1 new + 6 unchanged - 1 fixed = 7 total (was 7) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 57s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 28m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4788 | | Optional Tests | dupname asflicense javac spotless spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 45ddb843018b 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4788/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected
[
https://issues.apache.org/jira/browse/HBASE-26967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615038#comment-17615038
]
chaijunjie commented on HBASE-26967:
[~zhangduo] hi, I think there are an example to support add a filterRow method.
eg1. we has 3 filters in filterList:
there is one row
f1–has filterRow–>{*}return true{*}
f2–has filterRow–>{*}return true{*}
f3–not has filterRow–not consider
*When we do not consider the filterRow result of f3,* the row will be *dropped*
in FilterListWithOR(see the *filterRow()* in FilterListWithOR).
But if a cell return INCLUDE after f3's filterCell method, we can not drop all
this row, in FilterListWithOR's filterRow method, we need consider f3, only
skip will loss result...
pls check it...thank you.
> FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with
> operator MUST_PASS_ONE doesn't work as expected
> -
>
> Key: HBASE-26967
> URL: https://issues.apache.org/jira/browse/HBASE-26967
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.4.11
>Reporter: Boris
>Priority: Blocker
>
> I created test table with two column families by hbase shell:
>
> {code:java}
> create 'test_table2', 'f1', 'f2'
> put 'test_table2', '1', 'f1:col1', 'a1'
> put 'test_table2', '1', 'f2:col2', 'a2'
> put 'test_table2', '2', 'f1:col1', 'b1'
> put 'test_table2', '2', 'f2:col2', 'b2' {code}
>
>
> The table contains of two rows (rowkeys '1' and '2'), tested FuzzyRowFilter
> selects first row,
> SingleColumnValueFilter selects no rows, combination of both filters
> evaluated with
> MUST_PASS_ONE operator returns surprisingly whole table. I prepared java
> examples to
> show this strange behavior.
>
> Code snippet below doesn't work as expected:
>
> {code:java}
> try (Table table = connection.getTable(TableName.valueOf("test_table2"))) {
> Scan scan = new Scan();
> scan.addFamily(Bytes.toBytes("f1"));
> scan.addFamily(Bytes.toBytes("f2"));
> Filter fuzzyRowFilter = new FuzzyRowFilter(List.of(new
> Pair<>(Bytes.toBytes("1"), new byte[] { 0x00 })));
> scan.setFilter(fuzzyRowFilter);
> System.out.println("result of fuzzy filter:");
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of single column value filter:");
> Filter singleColumnValueFilter = new
> SingleColumnValueFilter(Bytes.toBytes("f2"), Bytes.toBytes("col2"),
> CompareOperator.EQUAL,
> Bytes.toBytes("x"));
> scan.setFilter(singleColumnValueFilter);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of fuzzy or single column value filters:");
> FilterList filterList = new FilterList(Operator.MUST_PASS_ONE);
> filterList.addFilter(fuzzyRowFilter);
> filterList.addFilter(singleColumnValueFilter);
> scan.setFilter(filterList);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> } {code}
> Expected result in my opinion is:
>
> {quote}result of fuzzy filter:
> 1
> result of single column value filter:
> result of fuzzy or single column value filters:
> 1
> {quote}
> But i am getting (NOT OK):
> {quote}result of fuzzy filter:
> 1
> result of single column value filter:
> result of fuzzy or single column value filters:
> 1
> 2
> {quote}
>
> For tables with one column family or commentig out the line
> _{color:#00}scan{color}.addFamily({color:#00}Bytes{color}.toBytes({color:#067d17}"f1"{color}))_
> filter list evaluation is working OK. Similar example with PrefixFilter is
> working like a charm:
>
> {code:java}
> try (Table table = connection.getTable(TableName.valueOf("test_table2"))) {
> Scan scan = new Scan();
> scan.addFamily(Bytes.toBytes("f1"));
> scan.addFamily(Bytes.toBytes("f2"));
> Filter prefixFilter = new PrefixFilter(Bytes.toBytes("1"));
> scan.setFilter(prefixFilter);
> System.out.println("result of prefix filter:");
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of single column value filter:");
> Filter singleColumnValueFilter = new
> SingleColumnValueFilter(Bytes.toBytes("f2"), Bytes.toBytes("col2"),
> CompareOperator.EQUAL,
> Bytes.toBytes("x"));
> scan.setFilter(singleColumnValueFilter);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of prefix or single column value filters");
> FilterList
[jira] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected
[ https://issues.apache.org/jira/browse/HBASE-26967 ]
chaijunjie deleted comment on HBASE-26967:
was (Author: JIRAUSER286971):
[~zhangduo] sure，if we skip filterRow for a filter which do not have a
filterRow method is better, i will change this MR, thank you.
> FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with
> operator MUST_PASS_ONE doesn't work as expected
> -
>
> Key: HBASE-26967
> URL: https://issues.apache.org/jira/browse/HBASE-26967
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.4.11
>Reporter: Boris
>Priority: Blocker
>
> I created test table with two column families by hbase shell:
>
> {code:java}
> create 'test_table2', 'f1', 'f2'
> put 'test_table2', '1', 'f1:col1', 'a1'
> put 'test_table2', '1', 'f2:col2', 'a2'
> put 'test_table2', '2', 'f1:col1', 'b1'
> put 'test_table2', '2', 'f2:col2', 'b2' {code}
>
>
> The table contains of two rows (rowkeys '1' and '2'), tested FuzzyRowFilter
> selects first row,
> SingleColumnValueFilter selects no rows, combination of both filters
> evaluated with
> MUST_PASS_ONE operator returns surprisingly whole table. I prepared java
> examples to
> show this strange behavior.
>
> Code snippet below doesn't work as expected:
>
> {code:java}
> try (Table table = connection.getTable(TableName.valueOf("test_table2"))) {
> Scan scan = new Scan();
> scan.addFamily(Bytes.toBytes("f1"));
> scan.addFamily(Bytes.toBytes("f2"));
> Filter fuzzyRowFilter = new FuzzyRowFilter(List.of(new
> Pair<>(Bytes.toBytes("1"), new byte[] { 0x00 })));
> scan.setFilter(fuzzyRowFilter);
> System.out.println("result of fuzzy filter:");
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of single column value filter:");
> Filter singleColumnValueFilter = new
> SingleColumnValueFilter(Bytes.toBytes("f2"), Bytes.toBytes("col2"),
> CompareOperator.EQUAL,
> Bytes.toBytes("x"));
> scan.setFilter(singleColumnValueFilter);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of fuzzy or single column value filters:");
> FilterList filterList = new FilterList(Operator.MUST_PASS_ONE);
> filterList.addFilter(fuzzyRowFilter);
> filterList.addFilter(singleColumnValueFilter);
> scan.setFilter(filterList);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> } {code}
> Expected result in my opinion is:
>
> {quote}result of fuzzy filter:
> 1
> result of single column value filter:
> result of fuzzy or single column value filters:
> 1
> {quote}
> But i am getting (NOT OK):
> {quote}result of fuzzy filter:
> 1
> result of single column value filter:
> result of fuzzy or single column value filters:
> 1
> 2
> {quote}
>
> For tables with one column family or commentig out the line
> _{color:#00}scan{color}.addFamily({color:#00}Bytes{color}.toBytes({color:#067d17}"f1"{color}))_
> filter list evaluation is working OK. Similar example with PrefixFilter is
> working like a charm:
>
> {code:java}
> try (Table table = connection.getTable(TableName.valueOf("test_table2"))) {
> Scan scan = new Scan();
> scan.addFamily(Bytes.toBytes("f1"));
> scan.addFamily(Bytes.toBytes("f2"));
> Filter prefixFilter = new PrefixFilter(Bytes.toBytes("1"));
> scan.setFilter(prefixFilter);
> System.out.println("result of prefix filter:");
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of single column value filter:");
> Filter singleColumnValueFilter = new
> SingleColumnValueFilter(Bytes.toBytes("f2"), Bytes.toBytes("col2"),
> CompareOperator.EQUAL,
> Bytes.toBytes("x"));
> scan.setFilter(singleColumnValueFilter);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of prefix or single column value filters");
> FilterList filterList = new FilterList(Operator.MUST_PASS_ONE);
> filterList.addFilter(prefixFilter);
> filterList.addFilter(singleColumnValueFilter);
> scan.setFilter(filterList);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> } {code}
>
>
> Result OK{_}:{_}
> {quote}result of prefix filter:
> 1
> result of single column value filter:
> result of prefix or single column value filters
> 1
> {quote}
--
This message was sent by Atlassian Jira
[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen
Apache-HBase commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1273095284 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 27s | master passed | | +1 :green_heart: | compile | 2m 18s | master passed | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 20s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 2m 14s | the patch passed | | +1 :green_heart: | javac | 2m 14s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 58s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 28m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4732 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 2003b5e9aaa5 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4732/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4818: HBASE-27419 Update to hbase-thirdparty 4.1.2
Apache9 commented on code in PR #4818: URL: https://github.com/apache/hbase/pull/4818#discussion_r991109817 ## hbase-protocol-shaded/pom.xml: ## @@ -34,7 +34,7 @@ -3.21.1 +3.21.7 Review Comment: Will open a new issue if I find a way to do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27333) Abort RS when the hostname is different from master seen
[
https://issues.apache.org/jira/browse/HBASE-27333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-27333:
---
Description:
For HRegionServer#handleReportForDutyResponse, when the hostname is different
from the regionserver and master side, both the two conditions should abort RS.
{code:java}
if (
!StringUtils.isBlank(useThisHostnameInstead)
&& !hostnameFromMasterPOV.equals(useThisHostnameInstead)
) {
String msg = "Master passed us a different hostname to use; was="
+ this.useThisHostnameInstead + ", but now=" + hostnameFromMasterPOV;
LOG.error(msg);
throw new IOException(msg);
}
if (
StringUtils.isBlank(useThisHostnameInstead)
&&
!hostnameFromMasterPOV.equals(rpcServices.getSocketAddress().getHostName())
) {
String msg = "Master passed us a different hostname to use; was="
+ rpcServices.getSocketAddress().getHostName() + ", but now=" +
hostnameFromMasterPOV;
LOG.error(msg);
} {code}
was:
For HRegionServer#handleReportForDutyResponse, when the hostname is different
from the regionserver and master side, the condition to use the local hostname
configed on regionserver is opposite.
{code:java}
if (
!StringUtils.isBlank(useThisHostnameInstead)
&& !hostnameFromMasterPOV.equals(useThisHostnameInstead)
) {
String msg = "Master passed us a different hostname to use; was="
+ this.useThisHostnameInstead + ", but now=" + hostnameFromMasterPOV;
LOG.error(msg);
throw new IOException(msg);
}
if (
StringUtils.isBlank(useThisHostnameInstead)
&&
!hostnameFromMasterPOV.equals(rpcServices.getSocketAddress().getHostName())
) {
String msg = "Master passed us a different hostname to use; was="
+ rpcServices.getSocketAddress().getHostName() + ", but now=" +
hostnameFromMasterPOV;
LOG.error(msg);
} {code}
> Abort RS when the hostname is different from master seen
>
>
> Key: HBASE-27333
> URL: https://issues.apache.org/jira/browse/HBASE-27333
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 3.0.0-alpha-3, 2.4.13
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> For HRegionServer#handleReportForDutyResponse, when the hostname is different
> from the regionserver and master side, both the two conditions should abort
> RS.
> {code:java}
> if (
> !StringUtils.isBlank(useThisHostnameInstead)
> && !hostnameFromMasterPOV.equals(useThisHostnameInstead)
> ) {
> String msg = "Master passed us a different hostname to use; was="
> + this.useThisHostnameInstead + ", but now=" + hostnameFromMasterPOV;
> LOG.error(msg);
> throw new IOException(msg);
> }
> if (
> StringUtils.isBlank(useThisHostnameInstead)
> &&
> !hostnameFromMasterPOV.equals(rpcServices.getSocketAddress().getHostName())
> ) {
> String msg = "Master passed us a different hostname to use; was="
> + rpcServices.getSocketAddress().getHostName() + ", but now=" +
> hostnameFromMasterPOV;
> LOG.error(msg);
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27333) Abort RS when the hostname is different from master seen
[
https://issues.apache.org/jira/browse/HBASE-27333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-27333:
---
Summary: Abort RS when the hostname is different from master seen (was:
The condition for using the local hostname is the opposite)
> Abort RS when the hostname is different from master seen
>
>
> Key: HBASE-27333
> URL: https://issues.apache.org/jira/browse/HBASE-27333
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 3.0.0-alpha-3, 2.4.13
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> For HRegionServer#handleReportForDutyResponse, when the hostname is different
> from the regionserver and master side, the condition to use the local
> hostname configed on regionserver is opposite.
> {code:java}
> if (
> !StringUtils.isBlank(useThisHostnameInstead)
> && !hostnameFromMasterPOV.equals(useThisHostnameInstead)
> ) {
> String msg = "Master passed us a different hostname to use; was="
> + this.useThisHostnameInstead + ", but now=" + hostnameFromMasterPOV;
> LOG.error(msg);
> throw new IOException(msg);
> }
> if (
> StringUtils.isBlank(useThisHostnameInstead)
> &&
> !hostnameFromMasterPOV.equals(rpcServices.getSocketAddress().getHostName())
> ) {
> String msg = "Master passed us a different hostname to use; was="
> + rpcServices.getSocketAddress().getHostName() + ", but now=" +
> hostnameFromMasterPOV;
> LOG.error(msg);
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1273012483 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 13s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 54s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 3m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 13s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 12s | the patch passed | | +1 :green_heart: | compile | 1m 55s | the patch passed | | +1 :green_heart: | javac | 1m 55s | the patch passed | | +1 :green_heart: | shadedjars | 3m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 30s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 28s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 1m 23s | hbase-procedure in the patch passed. | | -1 :x: | unit | 234m 40s | hbase-server in the patch failed. | | | | 260m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dd0e6ace05c7 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/testReport/ | | Max. process+thread count | 2464 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1272999452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 39s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 42s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 59s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 4m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 8s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 34s | the patch passed | | +1 :green_heart: | compile | 2m 1s | the patch passed | | +1 :green_heart: | javac | 2m 1s | the patch passed | | +1 :green_heart: | shadedjars | 4m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 35s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 21s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 24s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 1m 26s | hbase-procedure in the patch passed. | | -1 :x: | unit | 221m 9s | hbase-server in the patch failed. | | | | 250m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4df0a06bc2cc 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/testReport/ | | Max. process+thread count | 2762 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1272912381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 22s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 3m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 15s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 3m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 14s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 218m 14s | hbase-server in the patch passed. | | | | 238m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4820 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 34c688685369 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/testReport/ | | Max. process+thread count | 2379 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sunhelly commented on pull request #4732: HBASE-27333 The condition for using the local hostname is the opposite
sunhelly commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1272904771 Thanks, @Apache9 and @apurtell . After looking at [HBASE-12954](https://issues.apache.org/jira/browse/HBASE-12954), I think we should abort the RS when the hostname from master seen is different from RS seen, regardless of whether the hostname has been configured by the RS. The problem I met is that, the `hbase.regionserver.hostname` is not configured, but the master do a reverse DNS resolution failed, and used the ip of the RS as the hostname seen, and then the RS is working using its ip as its name, but there are something wrong about its RSGroup now. I'll change the PR and update the issue name, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1272903581 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 54s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 4m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 35s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 4m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 21s | hbase-client in the patch passed. | | -1 :x: | unit | 210m 14s | hbase-server in the patch failed. | | | | 231m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4820 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e38fe6fa53ee 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 46d37a70d6 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/testReport/ | | Max. process+thread count | 2658 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4820/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected
[
https://issues.apache.org/jira/browse/HBASE-26967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614941#comment-17614941
]
chaijunjie commented on HBASE-26967:
[~zhangduo] sure，if we skip filterRow for a filter which do not have a
filterRow method is better, i will change this MR, thank you.
> FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with
> operator MUST_PASS_ONE doesn't work as expected
> -
>
> Key: HBASE-26967
> URL: https://issues.apache.org/jira/browse/HBASE-26967
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.4.11
>Reporter: Boris
>Priority: Blocker
>
> I created test table with two column families by hbase shell:
>
> {code:java}
> create 'test_table2', 'f1', 'f2'
> put 'test_table2', '1', 'f1:col1', 'a1'
> put 'test_table2', '1', 'f2:col2', 'a2'
> put 'test_table2', '2', 'f1:col1', 'b1'
> put 'test_table2', '2', 'f2:col2', 'b2' {code}
>
>
> The table contains of two rows (rowkeys '1' and '2'), tested FuzzyRowFilter
> selects first row,
> SingleColumnValueFilter selects no rows, combination of both filters
> evaluated with
> MUST_PASS_ONE operator returns surprisingly whole table. I prepared java
> examples to
> show this strange behavior.
>
> Code snippet below doesn't work as expected:
>
> {code:java}
> try (Table table = connection.getTable(TableName.valueOf("test_table2"))) {
> Scan scan = new Scan();
> scan.addFamily(Bytes.toBytes("f1"));
> scan.addFamily(Bytes.toBytes("f2"));
> Filter fuzzyRowFilter = new FuzzyRowFilter(List.of(new
> Pair<>(Bytes.toBytes("1"), new byte[] { 0x00 })));
> scan.setFilter(fuzzyRowFilter);
> System.out.println("result of fuzzy filter:");
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of single column value filter:");
> Filter singleColumnValueFilter = new
> SingleColumnValueFilter(Bytes.toBytes("f2"), Bytes.toBytes("col2"),
> CompareOperator.EQUAL,
> Bytes.toBytes("x"));
> scan.setFilter(singleColumnValueFilter);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of fuzzy or single column value filters:");
> FilterList filterList = new FilterList(Operator.MUST_PASS_ONE);
> filterList.addFilter(fuzzyRowFilter);
> filterList.addFilter(singleColumnValueFilter);
> scan.setFilter(filterList);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> } {code}
> Expected result in my opinion is:
>
> {quote}result of fuzzy filter:
> 1
> result of single column value filter:
> result of fuzzy or single column value filters:
> 1
> {quote}
> But i am getting (NOT OK):
> {quote}result of fuzzy filter:
> 1
> result of single column value filter:
> result of fuzzy or single column value filters:
> 1
> 2
> {quote}
>
> For tables with one column family or commentig out the line
> _{color:#00}scan{color}.addFamily({color:#00}Bytes{color}.toBytes({color:#067d17}"f1"{color}))_
> filter list evaluation is working OK. Similar example with PrefixFilter is
> working like a charm:
>
> {code:java}
> try (Table table = connection.getTable(TableName.valueOf("test_table2"))) {
> Scan scan = new Scan();
> scan.addFamily(Bytes.toBytes("f1"));
> scan.addFamily(Bytes.toBytes("f2"));
> Filter prefixFilter = new PrefixFilter(Bytes.toBytes("1"));
> scan.setFilter(prefixFilter);
> System.out.println("result of prefix filter:");
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of single column value filter:");
> Filter singleColumnValueFilter = new
> SingleColumnValueFilter(Bytes.toBytes("f2"), Bytes.toBytes("col2"),
> CompareOperator.EQUAL,
> Bytes.toBytes("x"));
> scan.setFilter(singleColumnValueFilter);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> System.out.println("result of prefix or single column value filters");
> FilterList filterList = new FilterList(Operator.MUST_PASS_ONE);
> filterList.addFilter(prefixFilter);
> filterList.addFilter(singleColumnValueFilter);
> scan.setFilter(filterList);
> for (Result r : table.getScanner(scan)) {
> System.out.println(Bytes.toString(r.getRow()));
> }
> } {code}
>
>
> Result OK{_}:{_}
> {quote}result of prefix filter:
> 1
> result of single column value filter:
> result of prefix or single column value filters
> 1
> {quote}
