[GitHub] [hbase] 2005hithlj commented on pull request #4810: HBASE-27217 Revisit the DumpReplicationQueues tool

2022-11-06 Thread GitBox


2005hithlj commented on PR #4810:
URL: https://github.com/apache/hbase/pull/4810#issuecomment-1305072174

   > [HBASE-27218](https://issues.apache.org/jira/browse/HBASE-27218) has been 
merged, so you need a rebase here...
   
   OK, sir.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] 2005hithlj commented on pull request #4810: HBASE-27217 Revisit the DumpReplicationQueues tool

2022-11-06 Thread GitBox


2005hithlj commented on PR #4810:
URL: https://github.com/apache/hbase/pull/4810#issuecomment-1305072026

   > HBASE-27218
   
   OK, sir.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #93: HBASE-27427 [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep …

2022-11-06 Thread GitBox


Apache-HBase commented on PR #93:
URL: https://github.com/apache/hbase-thirdparty/pull/93#issuecomment-1305008119

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m 11s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -0 :warning: |  test4tests  |   0m  0s |  The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   0m 35s |  master passed  |
   | +1 :green_heart: |  compile  |   1m  8s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 49s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 25s |  master passed  |
   | +0 :ok: |  mvndep  |   0m 31s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 44s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  7s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  7s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  7s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   0m 47s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 10s |  hbase-shaded-protobuf in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m  6s |  hbase-shaded-netty in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m  5s |  hbase-shaded-gson in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m  4s |  hbase-shaded-miscellaneous in the 
patch passed.  |
   | +1 :green_heart: |  unit  |   0m  5s |  hbase-shaded-jetty in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m  5s |  hbase-shaded-jersey in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m  5s |  
hbase-shaded-jackson-jaxrs-json-provider in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 28s |  hbase-noop-htrace in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   0m  6s |  hbase-unsafe in the patch passed.  
|
   | +1 :green_heart: |  unit  |   0m 35s |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 46s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  12m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-93/1/artifact/yetus-precommit-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/93 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile |
   | uname | Linux 6be56f2dbf24 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 GNU/Linux |
   | Build tool | maven |
   | git revision | master / c776029 |
   | Default Java | Oracle Corporation-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-93/1/testReport/
 |
   | Max. process+thread count | 415 (vs. ulimit of 1000) |
   | modules | C: hbase-shaded-protobuf hbase-shaded-netty hbase-shaded-gson 
hbase-shaded-miscellaneous hbase-shaded-jetty hbase-shaded-jersey 
hbase-shaded-jackson-jaxrs-json-provider hbase-noop-htrace hbase-unsafe . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-93/1/console |
   | versions | git=2.20.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27467) [hbase-thirdparty] Bump thirdparty dependencies

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27467:
--
Fix Version/s: thirdparty-4.1.3

> [hbase-thirdparty] Bump thirdparty dependencies
> ---
>
> Key: HBASE-27467
> URL: https://issues.apache.org/jira/browse/HBASE-27467
> Project: HBase
>  Issue Type: Task
>  Components: dependencies, thirdparty
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: thirdparty-4.1.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-26733) [hbase-thirdparty] Upgrade Netty to 4.1.73.Final

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-26733:
--
Fix Version/s: thirdparty-3.5.2
   (was: hbase-thirdparty-3.5.2)

> [hbase-thirdparty] Upgrade Netty to 4.1.73.Final
> 
>
> Key: HBASE-26733
> URL: https://issues.apache.org/jira/browse/HBASE-26733
> Project: HBase
>  Issue Type: Bug
>  Components: security, thirdparty
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: thirdparty-3.5.2, thirdparty-4.1.0
>
>
> Netty 4.1.71.Final included a fix for 
> [HTTP-request-smuggling|https://github.com/netty/netty/security/advisories/GHSA-wx5j-54mm-rqqq].
>  We are still on 4.1.70.Final. 
> Latest is 4.1.73.Final, use that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-26746) Update protobuf-java to 3.19.4

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-26746:
--
Fix Version/s: thirdparty-3.5.2
   (was: hbase-thirdparty-3.5.2)

> Update protobuf-java to 3.19.4
> --
>
> Key: HBASE-26746
> URL: https://issues.apache.org/jira/browse/HBASE-26746
> Project: HBase
>  Issue Type: Bug
>  Components: Protobufs, thirdparty
>Reporter: Pankaj Kumar
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: thirdparty-3.5.2, thirdparty-4.1.0
>
> Attachments: 
> 0001-CVE-2021-22569-Improve-performance-of-parsing-unknow.patch
>
>
> Refer,
> https://nvd.nist.gov/vuln/detail/CVE-2021-22569



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27468) [hbase-thirdparty] Use $revision as placeholder for maven version

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27468:
--
Fix Version/s: thirdparty-4.1.3

> [hbase-thirdparty] Use $revision as placeholder for maven version
> -
>
> Key: HBASE-27468
> URL: https://issues.apache.org/jira/browse/HBASE-27468
> Project: HBase
>  Issue Type: Improvement
>  Components: build, pom
>Reporter: Duo Zhang
>Priority: Major
> Fix For: thirdparty-4.1.3
>
>
> To align with our main repo.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27468) [hbase-thirdparty] Use $revision as placeholder for maven version

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27468:
--
Component/s: build
 pom

> [hbase-thirdparty] Use $revision as placeholder for maven version
> -
>
> Key: HBASE-27468
> URL: https://issues.apache.org/jira/browse/HBASE-27468
> Project: HBase
>  Issue Type: Improvement
>  Components: build, pom
>Reporter: Duo Zhang
>Priority: Major
>
> To align with our main repo.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27468) [hbase-thirdparty] Use $revision as placeholder for maven version

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27468:
--
Issue Type: Improvement  (was: Task)

> [hbase-thirdparty] Use $revision as placeholder for maven version
> -
>
> Key: HBASE-27468
> URL: https://issues.apache.org/jira/browse/HBASE-27468
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Priority: Major
>
> To align with our main repo.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27468) [hbase-thirdparty] Use $revision as placeholder for maven version

2022-11-06 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27468:
-

 Summary: [hbase-thirdparty] Use $revision as placeholder for maven 
version
 Key: HBASE-27468
 URL: https://issues.apache.org/jira/browse/HBASE-27468
 Project: HBase
  Issue Type: Task
Reporter: Duo Zhang


To align with our main repo.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27427) [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep for the next release

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27427:
--
Fix Version/s: thirdparty-4.1.3

> [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep for the next release
> -
>
> Key: HBASE-27427
> URL: https://issues.apache.org/jira/browse/HBASE-27427
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, pom
>Reporter: Duo Zhang
>Priority: Major
> Fix For: thirdparty-4.1.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27427) [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep for the next release

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27427:
--
Component/s: build

> [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep for the next release
> -
>
> Key: HBASE-27427
> URL: https://issues.apache.org/jira/browse/HBASE-27427
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, pom
>Reporter: Duo Zhang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase-thirdparty] Apache9 opened a new pull request, #93: HBASE-27427 [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep …

2022-11-06 Thread GitBox


Apache9 opened a new pull request, #93:
URL: https://github.com/apache/hbase-thirdparty/pull/93

   …for the next release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27427) [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep for the next release

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27427:
--
Component/s: pom

> [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep for the next release
> -
>
> Key: HBASE-27427
> URL: https://issues.apache.org/jira/browse/HBASE-27427
> Project: HBase
>  Issue Type: Sub-task
>  Components: pom
>Reporter: Duo Zhang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27467) [hbase-thirdparty] Bump thirdparty dependencies

2022-11-06 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27467:
-

 Summary: [hbase-thirdparty] Bump thirdparty dependencies
 Key: HBASE-27467
 URL: https://issues.apache.org/jira/browse/HBASE-27467
 Project: HBase
  Issue Type: Task
  Components: dependencies, thirdparty
Reporter: Duo Zhang
Assignee: Duo Zhang






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27423) Upgrade Jackson for CVE-2022-42003/42004

2022-11-06 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629564#comment-17629564
 ] 

Duo Zhang commented on HBASE-27423:
---

Jackson 2.14.0 is out. Let's make a new hbase-thirdparty release and upgrade 
our jackson dependencies.

> Upgrade Jackson for CVE-2022-42003/42004
> 
>
> Key: HBASE-27423
> URL: https://issues.apache.org/jira/browse/HBASE-27423
> Project: HBase
>  Issue Type: Bug
>  Components: security
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes 
> CVE-2022-42004. 
> Move jackson.version to 2.13.4.
> Move jackson.databind.version to 2.14.0-rc1. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4864: HBASE-27429 Add exponential retry backoff support for MigrateReplicat…

2022-11-06 Thread GitBox


Apache-HBase commented on PR #4864:
URL: https://github.com/apache/hbase/pull/4864#issuecomment-1304922924

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  2s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ HBASE-27109/table_based_rqs Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  8s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 23s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  compile  |   0m 54s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  shadedjars  |   3m 54s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  HBASE-27109/table_based_rqs 
passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 23s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 57s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 57s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 12s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 35s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 262m 10s |  hbase-server in the patch failed.  |
   |  |   | 288m 11s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4864 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 004dd0ecb095 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-27109/table_based_rqs / c5196d72fd |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/testReport/
 |
   | Max. process+thread count | 3454 (vs. ulimit of 3) |
   | modules | C: hbase-procedure hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4864: HBASE-27429 Add exponential retry backoff support for MigrateReplicat…

2022-11-06 Thread GitBox


Apache-HBase commented on PR #4864:
URL: https://github.com/apache/hbase/pull/4864#issuecomment-1304912984

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   4m  2s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ HBASE-27109/table_based_rqs Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 32s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  compile  |   1m  4s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  shadedjars  |   3m 59s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 39s |  HBASE-27109/table_based_rqs 
passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 32s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  3s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  3s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 48s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 38s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 23s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 219m 43s |  hbase-server in the patch failed.  |
   |  |   | 247m 42s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4864 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 0244f7cf23d7 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-27109/table_based_rqs / c5196d72fd |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/testReport/
 |
   | Max. process+thread count | 2466 (vs. ulimit of 3) |
   | modules | C: hbase-procedure hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink

2022-11-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629535#comment-17629535
 ] 

Hudson commented on HBASE-27414:


Results for branch branch-2.5
[build #239 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Search order for locations in  HFileLink
> 
>
> Key: HBASE-27414
> URL: https://issues.apache.org/jira/browse/HBASE-27414
> Project: HBase
>  Issue Type: Improvement
>  Components: Performance
>Reporter: Huaxiang Sun
>Assignee: ruanhui
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Found that search order for locations is following the order of these 
> locations added to HFileLink object. 
>  
> setLocations(originPath, tempPath, mobPath, archivePath);
> archivePath is the last one to be searched. For most cases, hfile exists in 
> archivePath, so we can move archivePath to the first parameter to avoid 
> unnecessary NN query.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27444) Add tool commands list_enabled_tables and list_disabled_tables

2022-11-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629533#comment-17629533
 ] 

Hudson commented on HBASE-27444:


Results for branch master
[build #715 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add tool commands list_enabled_tables and list_disabled_tables
> --
>
> Key: HBASE-27444
> URL: https://issues.apache.org/jira/browse/HBASE-27444
> Project: HBase
>  Issue Type: New Feature
>  Components: master
>Affects Versions: 3.0.0-alpha-4
>Reporter: LiangJun He
>Assignee: LiangJun He
>Priority: Minor
>
> Currently, there is no command line tool to get the all enabled or disabled 
> tables, which can only be seen through the HMaster UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink

2022-11-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629532#comment-17629532
 ] 

Hudson commented on HBASE-27414:


Results for branch master
[build #715 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Search order for locations in  HFileLink
> 
>
> Key: HBASE-27414
> URL: https://issues.apache.org/jira/browse/HBASE-27414
> Project: HBase
>  Issue Type: Improvement
>  Components: Performance
>Reporter: Huaxiang Sun
>Assignee: ruanhui
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Found that search order for locations is following the order of these 
> locations added to HFileLink object. 
>  
> setLocations(originPath, tempPath, mobPath, archivePath);
> archivePath is the last one to be searched. For most cases, hfile exists in 
> archivePath, so we can move archivePath to the first parameter to avoid 
> unnecessary NN query.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4864: HBASE-27429 Add exponential retry backoff support for MigrateReplicat…

2022-11-06 Thread GitBox


Apache-HBase commented on PR #4864:
URL: https://github.com/apache/hbase/pull/4864#issuecomment-1304869473

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ HBASE-27109/table_based_rqs Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m  3s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  compile  |   2m 34s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  checkstyle  |   0m 35s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  spotless  |   0m 36s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 28s |  HBASE-27109/table_based_rqs 
passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  1s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 36s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 33s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   7m 52s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 37s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 43s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 14s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  29m 15s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4864 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux eed40dbc65df 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 
17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-27109/table_based_rqs / c5196d72fd |
   | Default Java | Temurin-1.8.0_352-b08 |
   | Max. process+thread count | 60 (vs. ulimit of 3) |
   | modules | C: hbase-procedure hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4864: HBASE-27429 Add exponential retry backoff support for MigrateReplicat…

2022-11-06 Thread GitBox


Apache-HBase commented on PR #4864:
URL: https://github.com/apache/hbase/pull/4864#issuecomment-1304863906

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ HBASE-27109/table_based_rqs Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 24s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  compile  |   1m 26s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  shadedjars  |   5m 10s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  5s |  HBASE-27109/table_based_rqs 
passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 28s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 55s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 15s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 37s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 26s |  hbase-procedure in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 259m 16s |  hbase-server in the patch passed.  
|
   |  |   | 287m 47s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4864 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 02a7e7218b1b 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 
02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-27109/table_based_rqs / c5196d72fd |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/testReport/
 |
   | Max. process+thread count | 2538 (vs. ulimit of 3) |
   | modules | C: hbase-procedure hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #4864: HBASE-27429 Add exponential retry backoff support for MigrateReplicat…

2022-11-06 Thread GitBox


Apache-HBase commented on PR #4864:
URL: https://github.com/apache/hbase/pull/4864#issuecomment-1304852367

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   3m 18s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ HBASE-27109/table_based_rqs Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  compile  |   0m 54s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  shadedjars  |   3m 54s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 33s |  HBASE-27109/table_based_rqs 
passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 30s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 53s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 53s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 54s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 32s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 24s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 206m  7s |  hbase-server in the patch failed.  |
   |  |   | 231m 13s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4864 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux f82a9a9dbbbf 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 
31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-27109/table_based_rqs / c5196d72fd |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/testReport/
 |
   | Max. process+thread count | 3159 (vs. ulimit of 3) |
   | modules | C: hbase-procedure hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] frostruan commented on a diff in pull request #4863: HBASE-27463 Reset sizeOfLogQueue when refresh replication source

2022-11-06 Thread GitBox


frostruan commented on code in PR #4863:
URL: https://github.com/apache/hbase/pull/4863#discussion_r1014855628


##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:
##
@@ -467,6 +467,9 @@ public void refreshSources(String peerId) throws 
IOException {
   ReplicationSourceInterface toRemove = this.sources.put(peerId, src);
   if (toRemove != null) {
 LOG.info("Terminate replication source for " + toRemove.getPeerId());
+// Reset sizeOfLogQueue, log will re enqueue to the created new source.
+toRemove.getSourceMetrics()

Review Comment:
   Thanks for review Duo.@Apache9
   
   Sorry, currently have no idea about the rule you mentioned, maybe the rule 
is a little complicated.
   
   I think what makes the rule complicated is that we first create the new 
ReplicationSource, then replace the old ReplicationSource with the new one, and 
then if the old ReplicationSource exists,  terminate it. And since HBASE-23231, 
we will not clear the old metrics when terminate the old ReplicationSource to 
avoid the metric for the new ReplicationSource being cleared. Then it's a 
little complicated to keep the new ReplicationSourceMetric and the 
GlobalReplicationSourceMetric  right and consistent.
   
   If we adjust the order, first terminate the old ReplicationSource if it 
exists and then create and register the new ReplicationSource, the logic of 
metric here maybe will be much simpler, and of course we can clear the metric 
when terminate the old ReplicationSource. But I'm not sure yet,  still need to 
confirm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] frostruan commented on a diff in pull request #4863: HBASE-27463 Reset sizeOfLogQueue when refresh replication source

2022-11-06 Thread GitBox


frostruan commented on code in PR #4863:
URL: https://github.com/apache/hbase/pull/4863#discussion_r1014855628


##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:
##
@@ -467,6 +467,9 @@ public void refreshSources(String peerId) throws 
IOException {
   ReplicationSourceInterface toRemove = this.sources.put(peerId, src);
   if (toRemove != null) {
 LOG.info("Terminate replication source for " + toRemove.getPeerId());
+// Reset sizeOfLogQueue, log will re enqueue to the created new source.
+toRemove.getSourceMetrics()

Review Comment:
   Thanks for review Duo.@Apache9
   
   Sorry, currently have no idea about the rule you mentioned, maybe the rule 
is a little complicated.
   
   I think what makes the rule complicated is that we first create the new 
ReplicationSource, then replace the old ReplicationSource with the new one, and 
then if the old ReplicationSource exists,  terminate it. And since HBASE-23231, 
we will not clear the old metrics when terminate the old ReplicationSource.
   
   If we adjust the order, first terminate the old ReplicationSource if it 
exists and then create and register the new ReplicationSource, the logic of 
metric here maybe will be much simpler, and of course we can clear the metric 
when terminate the old ReplicationSource. But I'm not sure yet,  still need to 
confirm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] frostruan commented on a diff in pull request #4863: HBASE-27463 Reset sizeOfLogQueue when refresh replication source

2022-11-06 Thread GitBox


frostruan commented on code in PR #4863:
URL: https://github.com/apache/hbase/pull/4863#discussion_r1014855628


##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:
##
@@ -467,6 +467,9 @@ public void refreshSources(String peerId) throws 
IOException {
   ReplicationSourceInterface toRemove = this.sources.put(peerId, src);
   if (toRemove != null) {
 LOG.info("Terminate replication source for " + toRemove.getPeerId());
+// Reset sizeOfLogQueue, log will re enqueue to the created new source.
+toRemove.getSourceMetrics()

Review Comment:
   Thanks for review Duo.@Apache9
   
   Sorry, currently have no idea about the rule you mentioned, maybe the rule 
is a little complicated.
   
   I think what makes the rule complicated is that we first create the new 
ReplicationSource, then replace the old ReplicationSource with the new one, and 
then if the old ReplicationSource exists,  terminate it. And since HBASE-23231, 
we will not clear the old metrics when terminate the old ReplicationSource.
   
   If we adjust the order, first terminate the old ReplicationSource if it 
exists and then create and register the new ReplicationSource, the logic of 
metric here maybe will be simpler, and of course we can clear the metric when 
terminate the old ReplicationSource. But I'm not sure yet,  still need to 
confirm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] frostruan commented on a diff in pull request #4863: HBASE-27463 Reset sizeOfLogQueue when refresh replication source

2022-11-06 Thread GitBox


frostruan commented on code in PR #4863:
URL: https://github.com/apache/hbase/pull/4863#discussion_r1014855628


##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:
##
@@ -467,6 +467,9 @@ public void refreshSources(String peerId) throws 
IOException {
   ReplicationSourceInterface toRemove = this.sources.put(peerId, src);
   if (toRemove != null) {
 LOG.info("Terminate replication source for " + toRemove.getPeerId());
+// Reset sizeOfLogQueue, log will re enqueue to the created new source.
+toRemove.getSourceMetrics()

Review Comment:
   Thanks for review Duo.@Apache9
   
   Sorry, currently have no idea about the rule you mentioned, maybe the rule 
is a little complicated.
   
   I think what makes the rule complicated is that we first create the new 
ReplicationSource, then replace the old ReplicationSource with the new one, and 
then if the old ReplicationSource exists,  terminate it. And since HBASE-23231, 
we will not clear the old metrics.
   
   If we adjust the order, first terminate the old ReplicationSource if exists 
and then create and register the new ReplicationSource, the logic of metric 
here maybe will be simpler, and of course we can clear the metric when 
terminate the old ReplicationSource. But I'm not sure yet,  still need to 
confirm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache9 commented on pull request #4810: HBASE-27217 Revisit the DumpReplicationQueues tool

2022-11-06 Thread GitBox


Apache9 commented on PR #4810:
URL: https://github.com/apache/hbase/pull/4810#issuecomment-1304829766

   HBASE-27218 has been merged, so you need a rebase here...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27429) Add exponential retry backoff support for MigrateReplicationQueueFromZkToTableProcedure

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27429:
--
Status: Patch Available  (was: Open)

> Add exponential retry backoff support for 
> MigrateReplicationQueueFromZkToTableProcedure
> ---
>
> Key: HBASE-27429
> URL: https://issues.apache.org/jira/browse/HBASE-27429
> Project: HBase
>  Issue Type: Sub-task
>  Components: master, proc-v2, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #4864: HBASE-27429 Add exponential retry backoff support for MigrateReplicat…

2022-11-06 Thread GitBox


Apache-HBase commented on PR #4864:
URL: https://github.com/apache/hbase/pull/4864#issuecomment-1304811218

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   3m 19s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ HBASE-27109/table_based_rqs Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 28s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  compile  |   2m 41s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  checkstyle  |   0m 36s |  HBASE-27109/table_based_rqs 
passed  |
   | +1 :green_heart: |  spotless  |   0m 39s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 34s |  HBASE-27109/table_based_rqs 
passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  5s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 40s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 40s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 28s |  hbase-server: The patch 
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   7m 56s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 37s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 44s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 15s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  32m 55s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4864 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux a59dbc64f880 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 
17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | HBASE-27109/table_based_rqs / c5196d72fd |
   | Default Java | Temurin-1.8.0_352-b08 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | Max. process+thread count | 60 (vs. ulimit of 3) |
   | modules | C: hbase-procedure hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4864/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27016) when “zookeeper.session.timeout” is set to a negative number, HMaster cannot stop normally

2022-11-06 Thread ECFuzz (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ECFuzz updated HBASE-27016:
---
Component/s: master
 (was: shutdown)

> when “zookeeper.session.timeout” is set to a negative number, HMaster cannot 
> stop normally
> --
>
> Key: HBASE-27016
> URL: https://issues.apache.org/jira/browse/HBASE-27016
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.2.2
> Environment: HBase 2.2.2
> os.name=Linux
> os.arch=amd64
> os.version=5.4.0-72-generic
> java.version=1.8.0_211
> java.vendor=Oracle Corporation
>Reporter: ECFuzz
>Assignee: ECFuzz
>Priority: Major
>
> In hbase- default.xml
> {code:java}
> 
>   zookeeper.session.timeout
>   9
>   ZooKeeper session timeout in milliseconds. It is used in two 
> different ways.
>       First, this value is used in the ZK client that HBase uses to connect 
> to the ensemble.
>       It is also used by HBase when it starts a ZK server and it is passed as 
> the 'maxSessionTimeout'.
>       See 
> https://zookeeper.apache.org/doc/current/zookeeperProgrammers.html#ch_zkSessions.
>       For example, if an HBase region server connects to a ZK ensemble that's 
> also managed
>       by HBase, then the session timeout will be the one specified by this 
> configuration.
>       But, a region server that connects to an ensemble managed with a 
> different configuration
>       will be subjected that ensemble's maxSessionTimeout. So, even though 
> HBase might propose
>       using 90 seconds, the ensemble can have a max timeout lower than this 
> and it will take
>       precedence. The current default maxSessionTimeout that ZK ships with is 
> 40 seconds, which is lower than
>       HBase's.
>   
> {code}
> The impact caused by setting zookeeper.session.timeout to negative number is 
> different in local mode and pseudo-distributed mode.
>  
> After starting hbase in local mode, hmaster will replace the sessiontimeout 
> configured in this start master() with the default value of 1 when it is 
> judged as local mode, so setting zookeeper.session.timeout to a negative 
> number in hbase-site.xml will have no effect on the hbase startup process.
> {code:java}
> private int startMaster() {
>   Configuration conf = getConf();
>   TraceUtil.initTracer(conf);
>   try {
>     // If 'local', defer to LocalHBaseCluster instance.  Starts master
>     // and regionserver both in the one JVM.
>     if (LocalHBaseCluster.isLocal(conf)) {
>       ...
>       int localZKClusterSessionTimeout;
>       localZKClusterSessionTimeout = 
> conf.getInt(HConstants.ZK_SESSION_TIMEOUT + ".localHBaseCluster", 10*1000);
>       conf.setInt(HConstants.ZK_SESSION_TIMEOUT, 
> localZKClusterSessionTimeout);
>       LOG.info("Starting a zookeeper cluster");
>       ...
>       }
> {code}
> Take the example of setting zookeeper.session.timeout to -1 in hbase-site.xml 
> to start hbase in local mode normally.
> {code:java}
> hadoop@ljq1:~/hbase-2.2.2-ori/bin$ ./start-hbase.sh 
> running master, logging to 
> /home/hadoop/hbase-2.2.2-ori/bin/../logs/hbase-hadoop-master-ljq1.out
> hadoop@ljq1:~/hbase-2.2.2-ori/bin$ jps
> 25667 HMaster
> 21859 Jps{code}
> {code:java}
> 2022-05-09 11:16:57,571 INFO [master/ljq1:16000:becomeActiveMaster] 
> master.HMaster: Master has completed initialization 8.179sec{code}
> However, next, when the hbase shell as a client initiates a request for basic 
> database operations to the started HBase, the zookeeper.session.timeout is 
> negative causing a ConnectionLoss error and any requested operation is 
> invalid as it recreates the conf to load the configuration.
> {code:java}
> hadoop@ljq1:~/hbase-2.2.2-ori/bin$ ./hbase shell
> Use "help" to get list of supported commands.
> Use "exit" to quit this interactive shell.
> For Reference, please visit: http://hbase.apache.org/2.0/book.html#shell
> Version 2.2.2, re6513a76c91cceda95dad7af246ac81d46fa2589, Sat Oct 19 10:10:12 
> UTC 2019
> Took 0.0212 seconds                                                           
>    hbase(main):001:0> status
> ERROR: KeeperErrorCode = ConnectionLoss for /hbase/master
> For usage try 'help "status"'
> Took 34.2850 seconds                                                          
>   hbase(main):002:0> create 'a','a1','a22'
> ERROR: KeeperErrorCode = ConnectionLoss for /hbase/master
> For usage try 'help "create"'
> Took 33.2029 seconds{code}
> The log shows that a socket connection was received, but consistently throws 
> a warning that no additional data could be read from the client session and 
> that the client may have closed the socket.
>  
> Next, use the official termination method . /stop-hbase.sh to shut down 
> hbase, it will also 

[jira] [Updated] (HBASE-27016) when “zookeeper.session.timeout” is set to a negative number, HMaster cannot stop normally

2022-11-06 Thread ECFuzz (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ECFuzz updated HBASE-27016:
---
Component/s: shutdown

> when “zookeeper.session.timeout” is set to a negative number, HMaster cannot 
> stop normally
> --
>
> Key: HBASE-27016
> URL: https://issues.apache.org/jira/browse/HBASE-27016
> Project: HBase
>  Issue Type: Bug
>  Components: shutdown
>Affects Versions: 2.2.2
> Environment: HBase 2.2.2
> os.name=Linux
> os.arch=amd64
> os.version=5.4.0-72-generic
> java.version=1.8.0_211
> java.vendor=Oracle Corporation
>Reporter: ECFuzz
>Assignee: ECFuzz
>Priority: Major
>
> In hbase- default.xml
> {code:java}
> 
>   zookeeper.session.timeout
>   9
>   ZooKeeper session timeout in milliseconds. It is used in two 
> different ways.
>       First, this value is used in the ZK client that HBase uses to connect 
> to the ensemble.
>       It is also used by HBase when it starts a ZK server and it is passed as 
> the 'maxSessionTimeout'.
>       See 
> https://zookeeper.apache.org/doc/current/zookeeperProgrammers.html#ch_zkSessions.
>       For example, if an HBase region server connects to a ZK ensemble that's 
> also managed
>       by HBase, then the session timeout will be the one specified by this 
> configuration.
>       But, a region server that connects to an ensemble managed with a 
> different configuration
>       will be subjected that ensemble's maxSessionTimeout. So, even though 
> HBase might propose
>       using 90 seconds, the ensemble can have a max timeout lower than this 
> and it will take
>       precedence. The current default maxSessionTimeout that ZK ships with is 
> 40 seconds, which is lower than
>       HBase's.
>   
> {code}
> The impact caused by setting zookeeper.session.timeout to negative number is 
> different in local mode and pseudo-distributed mode.
>  
> After starting hbase in local mode, hmaster will replace the sessiontimeout 
> configured in this start master() with the default value of 1 when it is 
> judged as local mode, so setting zookeeper.session.timeout to a negative 
> number in hbase-site.xml will have no effect on the hbase startup process.
> {code:java}
> private int startMaster() {
>   Configuration conf = getConf();
>   TraceUtil.initTracer(conf);
>   try {
>     // If 'local', defer to LocalHBaseCluster instance.  Starts master
>     // and regionserver both in the one JVM.
>     if (LocalHBaseCluster.isLocal(conf)) {
>       ...
>       int localZKClusterSessionTimeout;
>       localZKClusterSessionTimeout = 
> conf.getInt(HConstants.ZK_SESSION_TIMEOUT + ".localHBaseCluster", 10*1000);
>       conf.setInt(HConstants.ZK_SESSION_TIMEOUT, 
> localZKClusterSessionTimeout);
>       LOG.info("Starting a zookeeper cluster");
>       ...
>       }
> {code}
> Take the example of setting zookeeper.session.timeout to -1 in hbase-site.xml 
> to start hbase in local mode normally.
> {code:java}
> hadoop@ljq1:~/hbase-2.2.2-ori/bin$ ./start-hbase.sh 
> running master, logging to 
> /home/hadoop/hbase-2.2.2-ori/bin/../logs/hbase-hadoop-master-ljq1.out
> hadoop@ljq1:~/hbase-2.2.2-ori/bin$ jps
> 25667 HMaster
> 21859 Jps{code}
> {code:java}
> 2022-05-09 11:16:57,571 INFO [master/ljq1:16000:becomeActiveMaster] 
> master.HMaster: Master has completed initialization 8.179sec{code}
> However, next, when the hbase shell as a client initiates a request for basic 
> database operations to the started HBase, the zookeeper.session.timeout is 
> negative causing a ConnectionLoss error and any requested operation is 
> invalid as it recreates the conf to load the configuration.
> {code:java}
> hadoop@ljq1:~/hbase-2.2.2-ori/bin$ ./hbase shell
> Use "help" to get list of supported commands.
> Use "exit" to quit this interactive shell.
> For Reference, please visit: http://hbase.apache.org/2.0/book.html#shell
> Version 2.2.2, re6513a76c91cceda95dad7af246ac81d46fa2589, Sat Oct 19 10:10:12 
> UTC 2019
> Took 0.0212 seconds                                                           
>    hbase(main):001:0> status
> ERROR: KeeperErrorCode = ConnectionLoss for /hbase/master
> For usage try 'help "status"'
> Took 34.2850 seconds                                                          
>   hbase(main):002:0> create 'a','a1','a22'
> ERROR: KeeperErrorCode = ConnectionLoss for /hbase/master
> For usage try 'help "create"'
> Took 33.2029 seconds{code}
> The log shows that a socket connection was received, but consistently throws 
> a warning that no additional data could be read from the client session and 
> that the client may have closed the socket.
>  
> Next, use the official termination method . /stop-hbase.sh to shut down 
> hbase, it will also recreate the conf and load the 

[jira] [Updated] (HBASE-27341) when “hbase.regionserver.logroll.period” is set to a negative number, Log cannot run normally

2022-11-06 Thread ECFuzz (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ECFuzz updated HBASE-27341:
---
Component/s: logging
 (was: regionserver)

> when “hbase.regionserver.logroll.period” is set to a negative number, Log 
> cannot run normally
> -
>
> Key: HBASE-27341
> URL: https://issues.apache.org/jira/browse/HBASE-27341
> Project: HBase
>  Issue Type: Bug
>  Components: logging
>Reporter: ECFuzz
>Assignee: ECFuzz
>Priority: Major
>
> In hbase- default.xml
> {code:java}
> 
>    hbase.regionserver.logroll.period
>    360
>    Period at which we will roll the commit log regardless
>   of how many edits it has.
>  {code}
> Taking hbase.regionserver.logroll.period set to -1 in hbase-site.xml as an 
> example, it is normal to start hbase.
> However, {*}there are a large number of repeated wal rolling operation 
> records in the log file{*}.
> {code:java}
> 2022-08-06 15:39:37,172 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
> 2022-08-06 15:39:37,172 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
> 2022-08-06 15:39:37,177 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
> 2022-08-06 15:39:37,177 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
> 2022-08-06 15:39:37,182 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
> 2022-08-06 15:39:37,182 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
> 2022-08-06 15:39:37,188 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577182.meta
> 2022-08-06 15:39:37,188 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
> 2022-08-06 15:39:37,196 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577188
> 2022-08-06 15:39:37,197 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
> 

[jira] [Updated] (HBASE-27341) when “hbase.regionserver.logroll.period” is set to a negative number, Log cannot run normally

2022-11-06 Thread ECFuzz (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ECFuzz updated HBASE-27341:
---
Component/s: regionserver

> when “hbase.regionserver.logroll.period” is set to a negative number, Log 
> cannot run normally
> -
>
> Key: HBASE-27341
> URL: https://issues.apache.org/jira/browse/HBASE-27341
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Reporter: ECFuzz
>Assignee: ECFuzz
>Priority: Major
>
> In hbase- default.xml
> {code:java}
> 
>    hbase.regionserver.logroll.period
>    360
>    Period at which we will roll the commit log regardless
>   of how many edits it has.
>  {code}
> Taking hbase.regionserver.logroll.period set to -1 in hbase-site.xml as an 
> example, it is normal to start hbase.
> However, {*}there are a large number of repeated wal rolling operation 
> records in the log file{*}.
> {code:java}
> 2022-08-06 15:39:37,172 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
> 2022-08-06 15:39:37,172 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156
> 2022-08-06 15:39:37,177 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
> 2022-08-06 15:39:37,177 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta
> 2022-08-06 15:39:37,182 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
> 2022-08-06 15:39:37,182 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167
> 2022-08-06 15:39:37,188 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577182.meta
> 2022-08-06 15:39:37,188 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta
> 2022-08-06 15:39:37,196 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Rolled WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
>  with entries=0, filesize=83 B; new WAL 
> /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577188
> 2022-08-06 15:39:37,197 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] 
> wal.AbstractFSWAL: Archiving 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
>  to 
> file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177
> 2022-08-06 15:39:37,201 INFO  

[GitHub] [hbase] Apache9 opened a new pull request, #4864: HBASE-27429 Add exponential retry backoff support for MigrateReplicat…

2022-11-06 Thread GitBox


Apache9 opened a new pull request, #4864:
URL: https://github.com/apache/hbase/pull/4864

   …ionQueueFromZkToTableProcedure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27218) Support rolling upgrading

2022-11-06 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27218:
--
Fix Version/s: HBASE-27109
 Hadoop Flags: Reviewed
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

Merged to branch HBASE-27109.

Thanks [~liyu] for reviewing!

> Support rolling upgrading
> -
>
> Key: HBASE-27218
> URL: https://issues.apache.org/jira/browse/HBASE-27218
> Project: HBase
>  Issue Type: Sub-task
>  Components: migration, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: HBASE-27109
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache9 merged pull request #4808: HBASE-27218 Support rolling upgrading

2022-11-06 Thread GitBox


Apache9 merged PR #4808:
URL: https://github.com/apache/hbase/pull/4808


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache9 commented on a diff in pull request #4863: HBASE-27463 Reset sizeOfLogQueue when refresh replication source

2022-11-06 Thread GitBox


Apache9 commented on code in PR #4863:
URL: https://github.com/apache/hbase/pull/4863#discussion_r1014792000


##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:
##
@@ -467,6 +467,9 @@ public void refreshSources(String peerId) throws 
IOException {
   ReplicationSourceInterface toRemove = this.sources.put(peerId, src);
   if (toRemove != null) {
 LOG.info("Terminate replication source for " + toRemove.getPeerId());
+// Reset sizeOfLogQueue, log will re enqueue to the created new source.
+toRemove.getSourceMetrics()

Review Comment:
   Are there any rules about which metrics should be reset while others should 
not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table

2022-11-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629430#comment-17629430
 ] 

Hudson commented on HBASE-27109:


Results for branch HBASE-27109/table_based_rqs
[build #33 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/33/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/33/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/33/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/33/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move replication queue storage from zookeeper to a separated HBase table
> 
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in 
> HBASE-15867.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)