[GitHub] [hbase] Apache-HBase commented on pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
Apache-HBase commented on PR #4874: URL: https://github.com/apache/hbase/pull/4874#issuecomment-1319636213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 14s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 3m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 12s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 3m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 0s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 213m 10s | hbase-server in the patch passed. | | | | 235m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4874 | | JIRA Issue | HBASE-27466 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 676702c1c2e5 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7b0ac6451d | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/testReport/ | | Max. process+thread count | 2542 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
Apache-HBase commented on PR #4874: URL: https://github.com/apache/hbase/pull/4874#issuecomment-1319633259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 41s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 4m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 41s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 4m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 28s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 207m 38s | hbase-server in the patch passed. | | | | 231m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4874 | | JIRA Issue | HBASE-27466 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8957647b57ff 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7b0ac6451d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/testReport/ | | Max. process+thread count | 2683 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27492) Hbase cannot support offpeak periods throughout all the day when hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted
[ https://issues.apache.org/jira/browse/HBASE-27492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635682#comment-17635682 ] Liuhe Tian commented on HBASE-27492: I just want all day 0-24 offpeak, I cannot just change my configuration to achieve it, no peak configuration here. I cannot set hbase.offpeak.end.hour=24, not vailded. can you tell me how to config all day offpeak? [~zhangduo] !image-2022-11-18-14-24-18-569.png! > Hbase cannot support offpeak periods throughout all the day when > hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted > > > Key: HBASE-27492 > URL: https://issues.apache.org/jira/browse/HBASE-27492 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 3.0.0-alpha-3, 2.5.1, 2.4.15 >Reporter: Liuhe Tian >Assignee: Liuhe Tian >Priority: Major > Attachments: image-2022-11-17-10-33-11-330.png, > image-2022-11-17-10-37-10-989.png, image-2022-11-18-14-24-18-569.png > > > Hbase cannot support offpeak periods throughout all the day when > hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted > > !image-2022-11-17-10-37-10-989.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27492) Hbase cannot support offpeak periods throughout all the day when hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted
[ https://issues.apache.org/jira/browse/HBASE-27492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liuhe Tian updated HBASE-27492: --- Attachment: image-2022-11-18-14-24-18-569.png > Hbase cannot support offpeak periods throughout all the day when > hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted > > > Key: HBASE-27492 > URL: https://issues.apache.org/jira/browse/HBASE-27492 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 3.0.0-alpha-3, 2.5.1, 2.4.15 >Reporter: Liuhe Tian >Assignee: Liuhe Tian >Priority: Major > Attachments: image-2022-11-17-10-33-11-330.png, > image-2022-11-17-10-37-10-989.png, image-2022-11-18-14-24-18-569.png > > > Hbase cannot support offpeak periods throughout all the day when > hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted > > !image-2022-11-17-10-37-10-989.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27492) Hbase cannot support offpeak periods throughout all the day when hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted
[ https://issues.apache.org/jira/browse/HBASE-27492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635653#comment-17635653 ] Duo Zhang commented on HBASE-27492: --- The endHour is exclusive, so startHour = 0 and endHour = 23 means 0-23, not 0-24. And alll day off peak just means all day peak? You could just change your configuration for peak hours? > Hbase cannot support offpeak periods throughout all the day when > hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted > > > Key: HBASE-27492 > URL: https://issues.apache.org/jira/browse/HBASE-27492 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 3.0.0-alpha-3, 2.5.1, 2.4.15 >Reporter: Liuhe Tian >Assignee: Liuhe Tian >Priority: Major > Attachments: image-2022-11-17-10-33-11-330.png, > image-2022-11-17-10-37-10-989.png > > > Hbase cannot support offpeak periods throughout all the day when > hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted > > !image-2022-11-17-10-37-10-989.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27464) In memory compaction 'COMPACT' may cause data corruption when adding cells large than maxAlloc(default 256k) size
[ https://issues.apache.org/jira/browse/HBASE-27464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635647#comment-17635647 ] chenglei commented on HBASE-27464: -- [~zhangduo]，sorry for later response, I was a little busy these two days so didn't merge to master in time. Thank you very much for helping merge. > In memory compaction 'COMPACT' may cause data corruption when adding cells > large than maxAlloc(default 256k) size > - > > Key: HBASE-27464 > URL: https://issues.apache.org/jira/browse/HBASE-27464 > Project: HBase > Issue Type: Bug > Components: in-memory-compaction >Reporter: zhuobin zheng >Assignee: chenglei >Priority: Critical > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16 > > Attachments: image-2022-11-04-15-46-21-645.png > > > When init 'CellChunkImmutableSegment' for 'COMPACT' action, we not force copy > to current MSLab. > When cell size bigger than maxAlloc, cell will stay in previous chunk which > will recycle after segment replace, and we may read wrong data when these > chunk reused by others. > !image-2022-11-04-15-46-21-645.png! > > Timeline: > # add a cell 'A' bigger than 256K > # cell 'A' will copy to a chunk 'A' when first compact > # cell 'A' will retain in chunk 'A' when second compact > # chunk 'A' recycled after segment swap and close -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
Apache-HBase commented on PR #4874: URL: https://github.com/apache/hbase/pull/4874#issuecomment-1319511892 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 2m 58s | master passed | | +1 :green_heart: | checkstyle | 0m 50s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 31s | the patch passed | | +1 :green_heart: | compile | 3m 0s | the patch passed | | +1 :green_heart: | javac | 3m 0s | the patch passed | | -0 :warning: | checkstyle | 0m 15s | hbase-client: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 41s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 34m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4874 | | JIRA Issue | HBASE-27466 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 73b7f00f5f20 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7b0ac6451d | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/8/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
Apache-HBase commented on PR #4874: URL: https://github.com/apache/hbase/pull/4874#issuecomment-1319495082 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 11s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | shadedjars | 3m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 3m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 0s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 213m 50s | hbase-server in the patch passed. | | | | 236m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4874 | | JIRA Issue | HBASE-27466 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6342adb307b0 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7b0ac6451d | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/testReport/ | | Max. process+thread count | 2543 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
Apache-HBase commented on PR #4874: URL: https://github.com/apache/hbase/pull/4874#issuecomment-1319492226 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 3m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 28s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 3m 58s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 24s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 206m 41s | hbase-server in the patch passed. | | | | 229m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4874 | | JIRA Issue | HBASE-27466 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 447474895b5f 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7b0ac6451d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/testReport/ | | Max. process+thread count | 2651 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27492) Hbase cannot support offpeak periods throughout all the day when hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted
[ https://issues.apache.org/jira/browse/HBASE-27492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635607#comment-17635607 ] Liuhe Tian commented on HBASE-27492: [~zhangduo] can you help me review this > Hbase cannot support offpeak periods throughout all the day when > hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted > > > Key: HBASE-27492 > URL: https://issues.apache.org/jira/browse/HBASE-27492 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 3.0.0-alpha-3, 2.5.1, 2.4.15 >Reporter: Liuhe Tian >Assignee: Liuhe Tian >Priority: Major > Attachments: image-2022-11-17-10-33-11-330.png, > image-2022-11-17-10-37-10-989.png > > > Hbase cannot support offpeak periods throughout all the day when > hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted > > !image-2022-11-17-10-37-10-989.png! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] d-c-manning commented on a diff in pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
d-c-manning commented on code in PR #4874:
URL: https://github.com/apache/hbase/pull/4874#discussion_r1025888411
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -54,6 +58,37 @@
@InterfaceAudience.Private
public class MetricsConnection implements StatisticTrackable {
+ static final Map METRICS_INSTANCES =
+new HashMap();
+
+ static MetricsConnection getMetricsConnection(final String scope,
Review Comment:
The comment on line 55-56 about "be sure to call shutdown()" could be
removed, and replaced by "Calling `getMetricsConnection` implicity creates and
"starts" instances of these classes; be sure to call `deleteMetricsConnection`
to terminate the thread pools they allocate. You could also add a comment about
the ref counting model now being used for these objects.
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -331,30 +371,53 @@ public Counter newMetric(Class clazz, String name,
String scope) {
protected final ConcurrentMap rpcCounters =
new ConcurrentHashMap<>(CAPACITY, LOAD_FACTOR, CONCURRENCY_LEVEL);
- MetricsConnection(String scope, Supplier batchPool,
+ private MetricsConnection(String scope, Supplier
batchPool,
Supplier metaPool) {
this.scope = scope;
+this.batchPools.add(batchPool);
+this.metaPools.add(metaPool);
Review Comment:
nit: could reuse the same method used in the get call
```suggestion
addThreadPools(batchPool, metaPool);
```
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java:
##
@@ -118,6 +118,7 @@ public class AsyncConnectionImpl implements AsyncConnection
{
private final AtomicBoolean closed = new AtomicBoolean(false);
+ private final String clusterId;
Review Comment:
Instead of storing `clusterId` to recompute the `scope` in `close()`, should
we store the `scope` we receive from `getScope` in the constructor?
```suggestion
private final String metricsScope;
```
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -334,27 +381,48 @@ public Counter newMetric(Class clazz, String name,
String scope) {
MetricsConnection(String scope, Supplier batchPool,
Supplier metaPool) {
this.scope = scope;
+this.batchPools.add(batchPool);
Review Comment:
yeah I think if we change it, it should be outside the scope of this PR for
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
Apache-HBase commented on PR #4874: URL: https://github.com/apache/hbase/pull/4874#issuecomment-1319368473 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 33s | master passed | | +1 :green_heart: | compile | 3m 0s | master passed | | +1 :green_heart: | checkstyle | 0m 51s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 30s | the patch passed | | +1 :green_heart: | compile | 2m 58s | the patch passed | | +1 :green_heart: | javac | 2m 58s | the patch passed | | -0 :warning: | checkstyle | 0m 16s | hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 41s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 35m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4874 | | JIRA Issue | HBASE-27466 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux b2ac1ceaa324 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7b0ac6451d | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/7/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27479) Flaky Test testClone in TestTaskMonitor
[
https://issues.apache.org/jira/browse/HBASE-27479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635570#comment-17635570
]
Hudson commented on HBASE-27479:
Results for branch branch-2.4
[build #462 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Flaky Test testClone in TestTaskMonitor
> ---
>
> Key: HBASE-27479
> URL: https://issues.apache.org/jira/browse/HBASE-27479
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Yiwei Li
>Assignee: Yiwei Li
>Priority: Trivial
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> {{`testClone`}} is detected as flaky by
> [[NonDex|https://github.com/TestingResearchIllinois/NonDex]|https://github.com/TestingResearchIllinois/NonDex]
> since the origin task monitor and the cloned one are represented as JSON
> objects, which are in a non-deterministic order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27423) Upgrade hbase-thirdparty to 4.1.3 and upgrade Jackson for CVE-2022-42003/42004
[
https://issues.apache.org/jira/browse/HBASE-27423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635569#comment-17635569
]
Hudson commented on HBASE-27423:
Results for branch branch-2.4
[build #462 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade hbase-thirdparty to 4.1.3 and upgrade Jackson for CVE-2022-42003/42004
> --
>
> Key: HBASE-27423
> URL: https://issues.apache.org/jira/browse/HBASE-27423
> Project: HBase
> Issue Type: Bug
> Components: security
>Reporter: Andrew Kyle Purtell
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes
> CVE-2022-42004.
> Move jackson.version to 2.13.4.
> Move jackson.databind.version to 2.14.0-rc1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27464) In memory compaction 'COMPACT' may cause data corruption when adding cells large than maxAlloc(default 256k) size
[
https://issues.apache.org/jira/browse/HBASE-27464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635571#comment-17635571
]
Hudson commented on HBASE-27464:
Results for branch branch-2.4
[build #462 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/462/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> In memory compaction 'COMPACT' may cause data corruption when adding cells
> large than maxAlloc(default 256k) size
> -
>
> Key: HBASE-27464
> URL: https://issues.apache.org/jira/browse/HBASE-27464
> Project: HBase
> Issue Type: Bug
> Components: in-memory-compaction
>Reporter: zhuobin zheng
>Assignee: chenglei
>Priority: Critical
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
> Attachments: image-2022-11-04-15-46-21-645.png
>
>
> When init 'CellChunkImmutableSegment' for 'COMPACT' action, we not force copy
> to current MSLab.
> When cell size bigger than maxAlloc, cell will stay in previous chunk which
> will recycle after segment replace, and we may read wrong data when these
> chunk reused by others.
> !image-2022-11-04-15-46-21-645.png!
>
> Timeline:
> # add a cell 'A' bigger than 256K
> # cell 'A' will copy to a chunk 'A' when first compact
> # cell 'A' will retain in chunk 'A' when second compact
> # chunk 'A' recycled after segment swap and close
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-26913) Replication Observability Framework
[
https://issues.apache.org/jira/browse/HBASE-26913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635568#comment-17635568
]
Viraj Jasani commented on HBASE-26913:
--
{quote}In the first proposal, we were re-using an existing table we created for
this framework instead of creating yet another table.
{quote}
[~zhangduo] WDYT?
> Replication Observability Framework
> ---
>
> Key: HBASE-26913
> URL: https://issues.apache.org/jira/browse/HBASE-26913
> Project: HBase
> Issue Type: New Feature
> Components: regionserver, Replication
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> In our production clusters, we have seen cases where data is present in
> source cluster but not in the sink cluster and 1 case where data is present
> in sink cluster but not in source cluster.
> We have internal tools where we take incremental backup every day on both
> source and sink clusters and we compare the hash of the data in both the
> backups. We have seen many cases where hash doesn't match which means data is
> not consistent between source and sink for that given day. The Mean Time To
> Detect (MTTD) these inconsistencies is atleast 2 days and requires lot of
> manual debugging.
> We need some tool where we can reduce MTTD and requires less manual debugging.
> I have attached design doc. Huge thanks to [~bharathv] to come up with this
> design at my work place.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27423) Upgrade hbase-thirdparty to 4.1.3 and upgrade Jackson for CVE-2022-42003/42004
[
https://issues.apache.org/jira/browse/HBASE-27423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635563#comment-17635563
]
Hudson commented on HBASE-27423:
Results for branch branch-2
[build #684 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade hbase-thirdparty to 4.1.3 and upgrade Jackson for CVE-2022-42003/42004
> --
>
> Key: HBASE-27423
> URL: https://issues.apache.org/jira/browse/HBASE-27423
> Project: HBase
> Issue Type: Bug
> Components: security
>Reporter: Andrew Kyle Purtell
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes
> CVE-2022-42004.
> Move jackson.version to 2.13.4.
> Move jackson.databind.version to 2.14.0-rc1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27464) In memory compaction 'COMPACT' may cause data corruption when adding cells large than maxAlloc(default 256k) size
[
https://issues.apache.org/jira/browse/HBASE-27464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635565#comment-17635565
]
Hudson commented on HBASE-27464:
Results for branch branch-2
[build #684 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> In memory compaction 'COMPACT' may cause data corruption when adding cells
> large than maxAlloc(default 256k) size
> -
>
> Key: HBASE-27464
> URL: https://issues.apache.org/jira/browse/HBASE-27464
> Project: HBase
> Issue Type: Bug
> Components: in-memory-compaction
>Reporter: zhuobin zheng
>Assignee: chenglei
>Priority: Critical
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
> Attachments: image-2022-11-04-15-46-21-645.png
>
>
> When init 'CellChunkImmutableSegment' for 'COMPACT' action, we not force copy
> to current MSLab.
> When cell size bigger than maxAlloc, cell will stay in previous chunk which
> will recycle after segment replace, and we may read wrong data when these
> chunk reused by others.
> !image-2022-11-04-15-46-21-645.png!
>
> Timeline:
> # add a cell 'A' bigger than 256K
> # cell 'A' will copy to a chunk 'A' when first compact
> # cell 'A' will retain in chunk 'A' when second compact
> # chunk 'A' recycled after segment swap and close
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27479) Flaky Test testClone in TestTaskMonitor
[
https://issues.apache.org/jira/browse/HBASE-27479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635564#comment-17635564
]
Hudson commented on HBASE-27479:
Results for branch branch-2
[build #684 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/684/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Flaky Test testClone in TestTaskMonitor
> ---
>
> Key: HBASE-27479
> URL: https://issues.apache.org/jira/browse/HBASE-27479
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Yiwei Li
>Assignee: Yiwei Li
>Priority: Trivial
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> {{`testClone`}} is detected as flaky by
> [[NonDex|https://github.com/TestingResearchIllinois/NonDex]|https://github.com/TestingResearchIllinois/NonDex]
> since the origin task monitor and the cloned one are represented as JSON
> objects, which are in a non-deterministic order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
Apache-HBase commented on PR #4874: URL: https://github.com/apache/hbase/pull/4874#issuecomment-1319341783 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 20s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 19s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 3m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 15s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 0s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 213m 13s | hbase-server in the patch passed. | | | | 237m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4874 | | JIRA Issue | HBASE-27466 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5546b93e26e4 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7b0ac6451d | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/6/testReport/ | | Max. process+thread count | 2611 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/6/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] vli02 commented on a diff in pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
vli02 commented on code in PR #4874:
URL: https://github.com/apache/hbase/pull/4874#discussion_r1020627589
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -54,6 +58,38 @@
@InterfaceAudience.Private
public class MetricsConnection implements StatisticTrackable {
+ static final Map METRICS_INSTANCES =
+new HashMap();
+
+ static MetricsConnection getMetricsConnection(final AsyncConnection conn,
+Supplier batchPool, Supplier
metaPool) {
+String scope = getScope(conn);
+MetricsConnection metrics;
+synchronized (METRICS_INSTANCES) {
Review Comment:
I am not sure if a synchronized or concurrent map can protect the entire
block, I want this entire block to run in single thread mode. Especially in the
deletion method below, the decrementing count, getting count, and remove it
from the map have to be single threaded. @apurtell @d-c-manning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
Apache-HBase commented on PR #4874: URL: https://github.com/apache/hbase/pull/4874#issuecomment-1319140018 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 35s | master passed | | +1 :green_heart: | compile | 2m 55s | master passed | | +1 :green_heart: | checkstyle | 0m 50s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 9s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 27s | the patch passed | | +1 :green_heart: | compile | 2m 56s | the patch passed | | +1 :green_heart: | javac | 2m 56s | the patch passed | | -0 :warning: | checkstyle | 0m 16s | hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 38s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 1m 6s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 3m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 36m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4874 | | JIRA Issue | HBASE-27466 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 313601c28cfc 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 7b0ac6451d | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4874/6/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-27253) Make slow log configs updatable with configuration observer
[ https://issues.apache.org/jira/browse/HBASE-27253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault reassigned HBASE-27253: - Assignee: Ray Mattingly > Make slow log configs updatable with configuration observer > --- > > Key: HBASE-27253 > URL: https://issues.apache.org/jira/browse/HBASE-27253 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Ray Mattingly >Priority: Major > > It would be very useful to be able to turn slow log on or off, change > thresholds, etc on demand as needed when diagnosing a traffic issue. Should > be a simple matter of moving the configs into RpcServer#onConfigurationChange -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] vli02 commented on a diff in pull request #4874: HBASE-27466: Add an option for user to specify an identity for:
vli02 commented on code in PR #4874:
URL: https://github.com/apache/hbase/pull/4874#discussion_r1025599118
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -334,27 +381,48 @@ public Counter newMetric(Class clazz, String name,
String scope) {
MetricsConnection(String scope, Supplier batchPool,
Supplier metaPool) {
this.scope = scope;
+this.batchPools.add(batchPool);
Review Comment:
I kept this code as I was guessing it might be a place holder for passing
non-null pools in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635482#comment-17635482
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #37 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/37/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/37/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/37/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/37/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-25576) Should not use a byte array as a key of HashMap or an element of HashSet
[
https://issues.apache.org/jira/browse/HBASE-25576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635470#comment-17635470
]
Jitendra Sahu commented on HBASE-25576:
---
[~brfrn169] Can I take this up? [~swaroopa] , are you working on this?
> Should not use a byte array as a key of HashMap or an element of HashSet
>
>
> Key: HBASE-25576
> URL: https://issues.apache.org/jira/browse/HBASE-25576
> Project: HBase
> Issue Type: Bug
>Reporter: Toshihiro Suzuki
>Assignee: Sourabh Dhanotia
>Priority: Major
> Labels: beginner
>
> I sometimes face the code where we use a byte array as a key of HashMap
> (ConcurrentHashMap) or an element of HashSet, which could cause very
> confusing bugs.
> The following code is an example where we use a byte array as a key of
> HashMap:
> https://github.com/apache/hbase/blob/326835e8372cc83092e0ec127650438ff153476a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceIdAccounting.java#L94
> In Java, we can't use a byte array as a key of HashMap or an element of
> HashSet directly. One solution for it is to use TreeMap
> (ConcurrentSkipListMap) or TreeSet (ConcurrentSkipListSet) with
> Bytes.BYTES_COMPARATOR instead of HashMap and HashSet as follows:
> {code}
> Map map1 = new TreeMap<>(Bytes.BYTES_COMPARATOR);
> Map map2 = new
> ConcurrentSkipListMap<>(Bytes.BYTES_COMPARATOR);
> Set set1 = new TreeSet<>(Bytes.BYTES_COMPARATOR);
> Set set2 = new ConcurrentSkipListSet<>(Bytes.BYTES_COMPARATOR);
> {code}
> We should fix the existing ones in this Jira.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27464) In memory compaction 'COMPACT' may cause data corruption when adding cells large than maxAlloc(default 256k) size
[ https://issues.apache.org/jira/browse/HBASE-27464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27464: -- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.5.2 2.4.16 Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2.4+. Thanks [~comnetwork]! > In memory compaction 'COMPACT' may cause data corruption when adding cells > large than maxAlloc(default 256k) size > - > > Key: HBASE-27464 > URL: https://issues.apache.org/jira/browse/HBASE-27464 > Project: HBase > Issue Type: Bug > Components: in-memory-compaction >Reporter: zhuobin zheng >Assignee: chenglei >Priority: Critical > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16 > > Attachments: image-2022-11-04-15-46-21-645.png > > > When init 'CellChunkImmutableSegment' for 'COMPACT' action, we not force copy > to current MSLab. > When cell size bigger than maxAlloc, cell will stay in previous chunk which > will recycle after segment replace, and we may read wrong data when these > chunk reused by others. > !image-2022-11-04-15-46-21-645.png! > > Timeline: > # add a cell 'A' bigger than 256K > # cell 'A' will copy to a chunk 'A' when first compact > # cell 'A' will retain in chunk 'A' when second compact > # chunk 'A' recycled after segment swap and close -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27464) In memory compaction 'COMPACT' may cause data corruption when adding cells large than maxAlloc(default 256k) size
[ https://issues.apache.org/jira/browse/HBASE-27464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27464: - Assignee: chenglei > In memory compaction 'COMPACT' may cause data corruption when adding cells > large than maxAlloc(default 256k) size > - > > Key: HBASE-27464 > URL: https://issues.apache.org/jira/browse/HBASE-27464 > Project: HBase > Issue Type: Bug > Components: in-memory-compaction >Reporter: zhuobin zheng >Assignee: chenglei >Priority: Critical > Attachments: image-2022-11-04-15-46-21-645.png > > > When init 'CellChunkImmutableSegment' for 'COMPACT' action, we not force copy > to current MSLab. > When cell size bigger than maxAlloc, cell will stay in previous chunk which > will recycle after segment replace, and we may read wrong data when these > chunk reused by others. > !image-2022-11-04-15-46-21-645.png! > > Timeline: > # add a cell 'A' bigger than 256K > # cell 'A' will copy to a chunk 'A' when first compact > # cell 'A' will retain in chunk 'A' when second compact > # chunk 'A' recycled after segment swap and close -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4881: HBASE-27464 In memory compaction 'COMPACT' may cause data corruption …
Apache9 merged PR #4881: URL: https://github.com/apache/hbase/pull/4881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-27479) Flaky Test testClone in TestTaskMonitor
[
https://issues.apache.org/jira/browse/HBASE-27479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-27479:
-
Assignee: Yiwei Li
> Flaky Test testClone in TestTaskMonitor
> ---
>
> Key: HBASE-27479
> URL: https://issues.apache.org/jira/browse/HBASE-27479
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Yiwei Li
>Assignee: Yiwei Li
>Priority: Trivial
>
> {{`testClone`}} is detected as flaky by
> [[NonDex|https://github.com/TestingResearchIllinois/NonDex]|https://github.com/TestingResearchIllinois/NonDex]
> since the origin task monitor and the cloned one are represented as JSON
> objects, which are in a non-deterministic order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HBASE-27479) Flaky Test testClone in TestTaskMonitor
[
https://issues.apache.org/jira/browse/HBASE-27479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-27479.
---
Fix Version/s: 2.6.0
3.0.0-alpha-4
2.5.2
2.4.16
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.4+.
Thanks [~TracyLi__] for contributing!
> Flaky Test testClone in TestTaskMonitor
> ---
>
> Key: HBASE-27479
> URL: https://issues.apache.org/jira/browse/HBASE-27479
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Yiwei Li
>Assignee: Yiwei Li
>Priority: Trivial
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> {{`testClone`}} is detected as flaky by
> [[NonDex|https://github.com/TestingResearchIllinois/NonDex]|https://github.com/TestingResearchIllinois/NonDex]
> since the origin task monitor and the cloned one are represented as JSON
> objects, which are in a non-deterministic order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27479) Flaky Test testClone in TestTaskMonitor
[
https://issues.apache.org/jira/browse/HBASE-27479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-27479:
--
Component/s: test
> Flaky Test testClone in TestTaskMonitor
> ---
>
> Key: HBASE-27479
> URL: https://issues.apache.org/jira/browse/HBASE-27479
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Yiwei Li
>Priority: Trivial
>
> {{`testClone`}} is detected as flaky by
> [[NonDex|https://github.com/TestingResearchIllinois/NonDex]|https://github.com/TestingResearchIllinois/NonDex]
> since the origin task monitor and the cloned one are represented as JSON
> objects, which are in a non-deterministic order.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HBASE-27423) Upgrade hbase-thirdparty to 4.1.3 and upgrade Jackson for CVE-2022-42003/42004
[ https://issues.apache.org/jira/browse/HBASE-27423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27423. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4+. Thanks [~sunxin] for reviewing! > Upgrade hbase-thirdparty to 4.1.3 and upgrade Jackson for CVE-2022-42003/42004 > -- > > Key: HBASE-27423 > URL: https://issues.apache.org/jira/browse/HBASE-27423 > Project: HBase > Issue Type: Bug > Components: security >Reporter: Andrew Kyle Purtell >Assignee: Duo Zhang >Priority: Major > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16 > > > Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes > CVE-2022-42004. > Move jackson.version to 2.13.4. > Move jackson.databind.version to 2.14.0-rc1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27359) Publish binaries and maven artifacts for both hadoop2 and hadoop3
[ https://issues.apache.org/jira/browse/HBASE-27359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27359: -- Fix Version/s: (was: 2.5.2) (was: 2.4.16) > Publish binaries and maven artifacts for both hadoop2 and hadoop3 > - > > Key: HBASE-27359 > URL: https://issues.apache.org/jira/browse/HBASE-27359 > Project: HBase > Issue Type: Improvement > Components: build, community, pom, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > As per the discussion in this thread > https://lists.apache.org/thread/y05gspk4mnxsz6nk7hc5ots8wt50366b > And this is possible after we land HBASE-27340. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] dependabot[bot] closed pull request #4835: Bump jackson-databind from 2.13.4 to 2.13.4.1
dependabot[bot] closed pull request #4835: Bump jackson-databind from 2.13.4 to 2.13.4.1 URL: https://github.com/apache/hbase/pull/4835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] dependabot[bot] commented on pull request #4835: Bump jackson-databind from 2.13.4 to 2.13.4.1
dependabot[bot] commented on PR #4835: URL: https://github.com/apache/hbase/pull/4835#issuecomment-1318628145 Looks like com.fasterxml.jackson.core:jackson-databind is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4863: HBASE-27463 Reset sizeOfLogQueue when refresh replication source
Apache9 commented on PR #4863: URL: https://github.com/apache/hbase/pull/4863#issuecomment-1318618109 So the fix here is to create the new replication source after terminating the old replication source. First, how could this fix the problem? Second, I guess why we create the replication source outside the lock is to reduce the locking time, but anyway, IIRC the start up of a replication source is asynchronous, so probably it is OK to move it into the lock protection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4846: HBASE-27445 fix the result of DirectMemoryUtils#getDirectMemorySize
Apache9 commented on code in PR #4846:
URL: https://github.com/apache/hbase/pull/4846#discussion_r1025171207
##
hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java:
##
@@ -77,36 +76,13 @@ public class DirectMemoryUtils {
HAS_MEMORY_USED_ATTRIBUTE = a != null;
}
- /**
- * @return the setting of -XX:MaxDirectMemorySize as a long. Returns 0 if
-XX:MaxDirectMemorySize
- * is not set.
- */
+ /** Returns the direct memory limit of the current progress */
public static long getDirectMemorySize() {
Review Comment:
Will this method be called by multiple threads? Let's initialize it while
loading the class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4876: HBASE-27479 fix flaky test testClone in TestTaskMonitor
Apache9 merged PR #4876: URL: https://github.com/apache/hbase/pull/4876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4878: HBASE-27423 Upgrade Jackson for CVE-2022-42003/42004
Apache9 merged PR #4878: URL: https://github.com/apache/hbase/pull/4878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-connectors] Apache-HBase commented on pull request #105: HBASE-27397 Spark-hbase support for 'startWith' predicate
Apache-HBase commented on PR #105: URL: https://github.com/apache/hbase-connectors/pull/105#issuecomment-1318588680 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 35s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | scaladoc | 0m 49s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 47s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | scalac | 0m 38s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | scaladoc | 0m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 1s | hbase-spark in the patch passed. | | | | 16m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-105/2/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-connectors/pull/105 | | Optional Tests | dupname scalac scaladoc unit compile | | uname | Linux e0be62915d72 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 GNU/Linux | | Build tool | hb_maven | | Personality | dev-support/jenkins/hbase-personality.sh | | git revision | master / 496cd58 | | Test Results | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-105/2/testReport/ | | Max. process+thread count | 943 (vs. ulimit of 12500) | | modules | C: spark/hbase-spark U: spark/hbase-spark | | Console output | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-105/2/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sunhelly commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen
sunhelly commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1318324760 @2005hithlj Good. By the way, the UTs failed in this PR are relevent to changes in [HBASE-27489](https://issues.apache.org/jira/browse/HBASE-27489), they ran smoothly without this PR, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27475) Use different jdks when running hadoopcheck in personality scripts
[
https://issues.apache.org/jira/browse/HBASE-27475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635228#comment-17635228
]
Hudson commented on HBASE-27475:
Results for branch HBASE-27475
[build #8 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27475/8/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27475/8/General_20Nightly_20Build_20Report/]
> Use different jdks when running hadoopcheck in personality scripts
> --
>
> Key: HBASE-27475
> URL: https://issues.apache.org/jira/browse/HBASE-27475
> Project: HBase
> Issue Type: Sub-task
> Components: jenkins, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] 2005hithlj commented on pull request #4864: HBASE-27429 Add exponential retry backoff support for MigrateReplicat…
2005hithlj commented on PR #4864: URL: https://github.com/apache/hbase/pull/4864#issuecomment-1318286810 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
