[jira] [Commented] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[
https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702212#comment-17702212
]
Hudson commented on HBASE-27671:
Results for branch branch-2
[build #771 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/771/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/771/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/771/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/771/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/771/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Client should not be able to restore/clone a snapshot after it's TTL has
> expired
>
>
> Key: HBASE-27671
> URL: https://issues.apache.org/jira/browse/HBASE-27671
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.2
> Environment: ENV- HBase 2.5.2
>Reporter: Ashok shetty
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4
>
> Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png
>
>
> Steps:
> precondition : base.master.cleaner.snapshot.interval to 5 min in
> hbase-site.xml
> 1. create a table t1 , put some data
> 2. create a snapshot 'snapt1' with TTL 1 mins
> let the TTL expries
> 3. disable and drop table t1
> 4. restore snapshot t1
> Actual : restore snapshot successful
> Expected : restore operation should fail and throw specified snapshot TTL
> expried cant restore
> Note : its can consider as improvement point
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1474974614 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 16s | branch-2 passed | | +1 :green_heart: | compile | 1m 9s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 4m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 5s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 211m 21s | hbase-server in the patch passed. | | | | 244m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5081 | | JIRA Issue | HBASE-27684 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 68d5e47c7f2c 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / b1a00be1bc | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/10/testReport/ | | Max. process+thread count | 2716 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/10/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1474970956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 20s | branch-2 passed | | +1 :green_heart: | compile | 0m 53s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 41s | the patch passed | | +1 :green_heart: | compile | 0m 52s | the patch passed | | +1 :green_heart: | javac | 0m 52s | the patch passed | | +1 :green_heart: | shadedjars | 4m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 37s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 199m 29s | hbase-server in the patch passed. | | | | 230m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/10/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5081 | | JIRA Issue | HBASE-27684 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 176d69da9710 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / b1a00be1bc | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/10/testReport/ | | Max. process+thread count | 2644 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/10/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27710) ByteBuff ref counting is too expensive for on-heap buffers
[
https://issues.apache.org/jira/browse/HBASE-27710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702169#comment-17702169
]
Hudson commented on HBASE-27710:
Results for branch branch-2.5
[build #320 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ByteBuff ref counting is too expensive for on-heap buffers
> --
>
> Key: HBASE-27710
> URL: https://issues.apache.org/jira/browse/HBASE-27710
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> We recently were upgrading an internal project's hbase client from 1.2 to
> 2.5. The project does raw HFile.Reader reading of some hfiles. We noticed an
> over 4x performance regression with the new client. Profiling showed that the
> majority of the time was spent in SingleByteBuff.checkRefCount. That ref
> counting is necessary for off-heap reads, but this case was using on-heap.
> Removing checkRefCount eliminated the regression.
> I asked on the dev list and we agreed to remove checkRefCount calls for
> on-heap buffers:
> https://lists.apache.org/thread/2qm0g8fbxb0no4ozfx7bw8xmkryt4zz0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[
https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702170#comment-17702170
]
Hudson commented on HBASE-27671:
Results for branch branch-2.5
[build #320 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/320/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Client should not be able to restore/clone a snapshot after it's TTL has
> expired
>
>
> Key: HBASE-27671
> URL: https://issues.apache.org/jira/browse/HBASE-27671
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.2
> Environment: ENV- HBase 2.5.2
>Reporter: Ashok shetty
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4
>
> Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png
>
>
> Steps:
> precondition : base.master.cleaner.snapshot.interval to 5 min in
> hbase-site.xml
> 1. create a table t1 , put some data
> 2. create a snapshot 'snapt1' with TTL 1 mins
> let the TTL expries
> 3. disable and drop table t1
> 4. restore snapshot t1
> Actual : restore snapshot successful
> Expected : restore operation should fail and throw specified snapshot TTL
> expried cant restore
> Note : its can consider as improvement point
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (HBASE-27732) NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
[
https://issues.apache.org/jira/browse/HBASE-27732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702165#comment-17702165
]
Viraj Jasani edited comment on HBASE-27732 at 3/18/23 7:23 PM:
---
Interesting! Btw the initial rollout of hbase 2.4 that we are doing still has
FSHLog implementation (just to keep diff as minimal with hbase 1.x as possible
to help debug any major regression in production).
But yeah for this issue it seems cleanOldLogs after writer close would be good.
was (Author: vjasani):
Interesting! Btw the initial rollout of hbase 2.4 that we are doing still has
FSHLog implementation (just to keep diff as minimal with hbase 1.x as possible
to help debug any major regression in production).
But yeah for this issue it seems cleanOldLogs after writer close would be good
(in finally maybe?).
> NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
> ---
>
> Key: HBASE-27732
> URL: https://issues.apache.org/jira/browse/HBASE-27732
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/master/7985/testReport/junit/org.apache.hadoop.hbase.replication.regionserver/TestBasicWALEntryStreamFSHLog/testEOFExceptionInOldWALsDirectory_1__isCompressionEnabled_true_/
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.findArchivedLog(AbstractFSWALProvider.java:488)
> at
> org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testEOFExceptionInOldWALsDirectory(TestBasicWALEntryStream.java:771)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at
> org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.lang.Thread.run(Thread.java:750)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27732) NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
[
https://issues.apache.org/jira/browse/HBASE-27732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702165#comment-17702165
]
Viraj Jasani commented on HBASE-27732:
--
Interesting! Btw the initial rollout of hbase 2.4 that we are doing still has
FSHLog implementation (just to keep diff as minimal with hbase 1.x as possible
to help debug any major regression in production).
But yeah for this issue it seems cleanOldLogs after writer close would be good
(in finally maybe?).
> NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
> ---
>
> Key: HBASE-27732
> URL: https://issues.apache.org/jira/browse/HBASE-27732
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/master/7985/testReport/junit/org.apache.hadoop.hbase.replication.regionserver/TestBasicWALEntryStreamFSHLog/testEOFExceptionInOldWALsDirectory_1__isCompressionEnabled_true_/
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.findArchivedLog(AbstractFSWALProvider.java:488)
> at
> org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testEOFExceptionInOldWALsDirectory(TestBasicWALEntryStream.java:771)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at
> org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.lang.Thread.run(Thread.java:750)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27710) ByteBuff ref counting is too expensive for on-heap buffers
[
https://issues.apache.org/jira/browse/HBASE-27710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702162#comment-17702162
]
Hudson commented on HBASE-27710:
Results for branch master
[build #799 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/799/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/799/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/799/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/799/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ByteBuff ref counting is too expensive for on-heap buffers
> --
>
> Key: HBASE-27710
> URL: https://issues.apache.org/jira/browse/HBASE-27710
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> We recently were upgrading an internal project's hbase client from 1.2 to
> 2.5. The project does raw HFile.Reader reading of some hfiles. We noticed an
> over 4x performance regression with the new client. Profiling showed that the
> majority of the time was spent in SingleByteBuff.checkRefCount. That ref
> counting is necessary for off-heap reads, but this case was using on-heap.
> Removing checkRefCount eliminated the regression.
> I asked on the dev list and we agreed to remove checkRefCount calls for
> on-heap buffers:
> https://lists.apache.org/thread/2qm0g8fbxb0no4ozfx7bw8xmkryt4zz0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[
https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702163#comment-17702163
]
Hudson commented on HBASE-27671:
Results for branch master
[build #799 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/799/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/799/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/799/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/799/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Client should not be able to restore/clone a snapshot after it's TTL has
> expired
>
>
> Key: HBASE-27671
> URL: https://issues.apache.org/jira/browse/HBASE-27671
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.5.2
> Environment: ENV- HBase 2.5.2
>Reporter: Ashok shetty
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4
>
> Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png
>
>
> Steps:
> precondition : base.master.cleaner.snapshot.interval to 5 min in
> hbase-site.xml
> 1. create a table t1 , put some data
> 2. create a snapshot 'snapt1' with TTL 1 mins
> let the TTL expries
> 3. disable and drop table t1
> 4. restore snapshot t1
> Actual : restore snapshot successful
> Expected : restore operation should fail and throw specified snapshot TTL
> expried cant restore
> Note : its can consider as improvement point
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5118: HBASE-27671 Client should not be able to restore/clone a snapshot aft…
Apache-HBase commented on PR #5118: URL: https://github.com/apache/hbase/pull/5118#issuecomment-1474952737 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 3s | branch-2.4 passed | | +1 :green_heart: | compile | 1m 2s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 3m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 52s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 3m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 13s | hbase-client in the patch passed. | | -1 :x: | unit | 176m 57s | hbase-server in the patch failed. | | | | 201m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5118 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 016a4ea6c473 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / acda5b7f73 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/testReport/ | | Max. process+thread count | 2595 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #5099: HBASE-27704 Quotas can drastically overflow configured limit
bbeaudreault commented on PR #5099: URL: https://github.com/apache/hbase/pull/5099#issuecomment-1474951767 @infraio any chance you might have time to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5118: HBASE-27671 Client should not be able to restore/clone a snapshot aft…
Apache-HBase commented on PR #5118: URL: https://github.com/apache/hbase/pull/5118#issuecomment-1474939535 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 35s | branch-2.4 passed | | +1 :green_heart: | compile | 0m 46s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 3m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 3m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 0s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 162m 10s | hbase-server in the patch passed. | | | | 184m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5118 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 178a2058a3e6 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / acda5b7f73 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/testReport/ | | Max. process+thread count | 2553 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1474914922 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 8s | branch-2 passed | | +1 :green_heart: | compile | 5m 16s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 27s | branch-2 passed | | +1 :green_heart: | spotless | 1m 11s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 4m 2s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 25s | the patch passed | | +1 :green_heart: | compile | 4m 9s | the patch passed | | +1 :green_heart: | javac | 4m 9s | the patch passed | | +1 :green_heart: | checkstyle | 1m 27s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 28m 0s | Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 1m 3s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 4m 2s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 64m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5081 | | JIRA Issue | HBASE-27684 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 2b006cfb2370 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / b1a00be1bc | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/10/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5118: HBASE-27671 Client should not be able to restore/clone a snapshot aft…
Apache-HBase commented on PR #5118: URL: https://github.com/apache/hbase/pull/5118#issuecomment-1474889536 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 2s | branch-2.4 passed | | +1 :green_heart: | compile | 3m 1s | branch-2.4 passed | | +1 :green_heart: | checkstyle | 0m 52s | branch-2.4 passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 13s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 3m 0s | the patch passed | | +1 :green_heart: | javac | 3m 0s | the patch passed | | +1 :green_heart: | checkstyle | 0m 48s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 27s | Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 43m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5118 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux ef7f0b4cf39b 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / acda5b7f73 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5118/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27732) NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
[
https://issues.apache.org/jira/browse/HBASE-27732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702130#comment-17702130
]
Duo Zhang commented on HBASE-27732:
---
I think the problem is that, as now we will close the WAL file asynchronously,
it is possible when calling cleanOldLogs after rolling, the WAL file has not
been closed yet so the rename operation will fail.
Let me think how to fix this. In general, I think we should call cleanOldLogs
right after the writer has been successfully closed.
[~vjasani] FYI.
> NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
> ---
>
> Key: HBASE-27732
> URL: https://issues.apache.org/jira/browse/HBASE-27732
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/master/7985/testReport/junit/org.apache.hadoop.hbase.replication.regionserver/TestBasicWALEntryStreamFSHLog/testEOFExceptionInOldWALsDirectory_1__isCompressionEnabled_true_/
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.findArchivedLog(AbstractFSWALProvider.java:488)
> at
> org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testEOFExceptionInOldWALsDirectory(TestBasicWALEntryStream.java:771)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at
> org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.lang.Thread.run(Thread.java:750)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702129#comment-17702129 ] Nihal Jain commented on HBASE-27671: Thanks [~vjasani] . I have created a PR for branch-2.4, see [https://github.com/apache/hbase/pull/5118] > Client should not be able to restore/clone a snapshot after it's TTL has > expired > > > Key: HBASE-27671 > URL: https://issues.apache.org/jira/browse/HBASE-27671 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.2 > Environment: ENV- HBase 2.5.2 >Reporter: Ashok shetty >Assignee: Nihal Jain >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4 > > Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png > > > Steps: > precondition : base.master.cleaner.snapshot.interval to 5 min in > hbase-site.xml > 1. create a table t1 , put some data > 2. create a snapshot 'snapt1' with TTL 1 mins > let the TTL expries > 3. disable and drop table t1 > 4. restore snapshot t1 > Actual : restore snapshot successful > Expected : restore operation should fail and throw specified snapshot TTL > expried cant restore > Note : its can consider as improvement point -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] NihalJain opened a new pull request, #5118: HBASE-27671 Client should not be able to restore/clone a snapshot aft…
NihalJain opened a new pull request, #5118: URL: https://github.com/apache/hbase/pull/5118 …er it has TTL expired it's TTL has expired -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27732) NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
[
https://issues.apache.org/jira/browse/HBASE-27732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702119#comment-17702119
]
Duo Zhang commented on HBASE-27732:
---
The error is
{noformat}
2023-03-17T03:42:54,025 WARN [Listener at localhost.localdomain/33967]
wal.AbstractFSWALProvider(418): Cannot parse a server name from
path=hdfs://localhost.localdomain:43341/home/jenkins/jenkins-home/workspace/HBase-Flaky-Tests_master/hbase-server/target/test-data/2f21d1db-c0f9-6ebc-17f1-124f110a5427/WALs/testEOFExceptionInOldWALsDirectory_1_
isCompressionEnabled=true]/testEOFExceptionInOldWALsDirectory_1_+isCompressionEnabled%3Dtrue%5D.1679024573986;
null
{noformat}
I think first we need to find out the reason why it can not parse, and second
we should guard against this error so at least usrs can know the reason is
parsing server name error, instead of getting a runtime exception.
> NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
> ---
>
> Key: HBASE-27732
> URL: https://issues.apache.org/jira/browse/HBASE-27732
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/master/7985/testReport/junit/org.apache.hadoop.hbase.replication.regionserver/TestBasicWALEntryStreamFSHLog/testEOFExceptionInOldWALsDirectory_1__isCompressionEnabled_true_/
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.findArchivedLog(AbstractFSWALProvider.java:488)
> at
> org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testEOFExceptionInOldWALsDirectory(TestBasicWALEntryStream.java:771)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at
> org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.lang.Thread.run(Thread.java:750)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-27732) NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
Duo Zhang created HBASE-27732:
-
Summary: NPE in
TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory
Key: HBASE-27732
URL: https://issues.apache.org/jira/browse/HBASE-27732
Project: HBase
Issue Type: Bug
Components: Replication
Reporter: Duo Zhang
Assignee: Duo Zhang
https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/master/7985/testReport/junit/org.apache.hadoop.hbase.replication.regionserver/TestBasicWALEntryStreamFSHLog/testEOFExceptionInOldWALsDirectory_1__isCompressionEnabled_true_/
{noformat}
java.lang.NullPointerException
at
org.apache.hadoop.hbase.wal.AbstractFSWALProvider.findArchivedLog(AbstractFSWALProvider.java:488)
at
org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testEOFExceptionInOldWALsDirectory(TestBasicWALEntryStream.java:771)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at
org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:750)
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HBASE-27709) Fix UT failures after HBASE-27632 goes in
[
https://issues.apache.org/jira/browse/HBASE-27709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-27709.
---
Assignee: (was: Duo Zhang)
Resolution: Duplicate
The replication related failures are back to normal on flaky tests dashboard.
Resolve.
> Fix UT failures after HBASE-27632 goes in
> -
>
> Key: HBASE-27709
> URL: https://issues.apache.org/jira/browse/HBASE-27709
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Duo Zhang
>Priority: Critical
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Need to fix this.
> {noformat}
> 2023-03-13T04:16:20,762 ERROR
> [RS_REFRESH_PEER-regionserver/df65750736d7:0-0.replicationSource,2.replicationSource.wal-reader.df65750736d7%2C35391%2C1678680878451,2]
> regionserver.HRegionServer(2747): * ABORTING region server
> df65750736d7,35391,1678680878451: Unexpected exception in
> RS_REFRESH_PEER-regionserver/df65750736d7:0-0.replicationSource,2.replicationSource.wal-reader.df65750736d7%2C35391%2C1678680878451,2
> *
> java.lang.NullPointerException: null
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.switched(ReplicationSourceWALReader.java:224)
> ~[classes/:?]
> at
> org.apache.hadoop.hbase.replication.regionserver.SerialReplicationSourceWALReader.readWALEntries(SerialReplicationSourceWALReader.java:114)
> ~[classes/:?]
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:178)
> ~[classes/:?]
> at
> org.apache.hadoop.hbase.replication.regionserver.SerialReplicationSourceWALReader.run(SerialReplicationSourceWALReader.java:35)
> ~[classes/:?]
> {noformat}
> And this
> {noformat}
> java.io.EOFException: EOF while reading message size
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.parseDelimitedFrom(ProtobufUtil.java:3730)
> at
> org.apache.hadoop.hbase.regionserver.wal.ProtobufWALStreamReader.next(ProtobufWALStreamReader.java:56)
> at
> org.apache.hadoop.hbase.wal.WALStreamReader.next(WALStreamReader.java:42)
> at
> org.apache.hadoop.hbase.wal.TestWALOpenAfterDNRollingStart.test(TestWALOpenAfterDNRollingStart.java:126)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at
>
[jira] [Assigned] (HBASE-27216) Revisit the ReplicationSyncUp tool
[ https://issues.apache.org/jira/browse/HBASE-27216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27216: - Assignee: Duo Zhang (was: Liangjun He) > Revisit the ReplicationSyncUp tool > -- > > Key: HBASE-27216 > URL: https://issues.apache.org/jira/browse/HBASE-27216 > Project: HBase > Issue Type: Sub-task > Components: Replication, tooling >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27216) Revisit the ReplicationSyncUp tool
[ https://issues.apache.org/jira/browse/HBASE-27216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27216. --- Fix Version/s: HBASE-27109 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch HBASE-27109. Thanks [~heliangjun] for reviewing! > Revisit the ReplicationSyncUp tool > -- > > Key: HBASE-27216 > URL: https://issues.apache.org/jira/browse/HBASE-27216 > Project: HBase > Issue Type: Sub-task > Components: Replication, tooling >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: HBASE-27109 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool
Apache9 merged PR #4966: URL: https://github.com/apache/hbase/pull/4966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool
Apache9 commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1474853892 The jdk11 build passed so it should be some flaky tests. https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4966/17/testReport/ Here the only one failed UT is TestClusterScopeQuotaThrottle, should not be related. Let me merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1474810954 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 36s | branch-2 passed | | +1 :green_heart: | compile | 1m 8s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 4m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 10s | hbase-client in the patch passed. | | -1 :x: | unit | 206m 57s | hbase-server in the patch failed. | | | | 241m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5081 | | JIRA Issue | HBASE-27684 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fc8a2b24fe35 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5de1e4f88e | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/testReport/ | | Max. process+thread count | 2612 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1474807788 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 43s | branch-2 passed | | +1 :green_heart: | compile | 0m 51s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 4m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 36s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 194m 1s | hbase-server in the patch passed. | | | | 223m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5081 | | JIRA Issue | HBASE-27684 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0bc8b9eaa965 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5de1e4f88e | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/testReport/ | | Max. process+thread count | 2512 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
Apache-HBase commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1474760657 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 23s | branch-2 passed | | +1 :green_heart: | compile | 3m 7s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 53s | branch-2 passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 13s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 3m 6s | the patch passed | | +1 :green_heart: | javac | 3m 6s | the patch passed | | +1 :green_heart: | checkstyle | 0m 53s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 33s | Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 41m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5081 | | JIRA Issue | HBASE-27684 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux f5badc6cfc39 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 5de1e4f88e | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27671. -- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.5.4 Hadoop Flags: Reviewed Resolution: Fixed > Client should not be able to restore/clone a snapshot after it's TTL has > expired > > > Key: HBASE-27671 > URL: https://issues.apache.org/jira/browse/HBASE-27671 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.2 > Environment: ENV- HBase 2.5.2 >Reporter: Ashok shetty >Assignee: Nihal Jain >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4 > > Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png > > > Steps: > precondition : base.master.cleaner.snapshot.interval to 5 min in > hbase-site.xml > 1. create a table t1 , put some data > 2. create a snapshot 'snapt1' with TTL 1 mins > let the TTL expries > 3. disable and drop table t1 > 4. restore snapshot t1 > Actual : restore snapshot successful > Expected : restore operation should fail and throw specified snapshot TTL > expried cant restore > Note : its can consider as improvement point -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702075#comment-17702075 ] Viraj Jasani commented on HBASE-27671: -- Let me mark the Jira resolved in the meanwhile, will reopen for branch-2.4 backport once 2.4 PR is ready for merging, and update the fix version to include 2.4 as well. > Client should not be able to restore/clone a snapshot after it's TTL has > expired > > > Key: HBASE-27671 > URL: https://issues.apache.org/jira/browse/HBASE-27671 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.2 > Environment: ENV- HBase 2.5.2 >Reporter: Ashok shetty >Assignee: Nihal Jain >Priority: Minor > Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png > > > Steps: > precondition : base.master.cleaner.snapshot.interval to 5 min in > hbase-site.xml > 1. create a table t1 , put some data > 2. create a snapshot 'snapt1' with TTL 1 mins > let the TTL expries > 3. disable and drop table t1 > 4. restore snapshot t1 > Actual : restore snapshot successful > Expected : restore operation should fail and throw specified snapshot TTL > expried cant restore > Note : its can consider as improvement point -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702074#comment-17702074 ] Viraj Jasani commented on HBASE-27671: -- Thanks [~nihaljain.cs]. branch-2 backport cleanly applied to branch-2.5 but branch-2.4 has bit of merge conflict. Since 2.4.x releases are still active, could you also create one PR for branch-2.4? Thank you > Client should not be able to restore/clone a snapshot after it's TTL has > expired > > > Key: HBASE-27671 > URL: https://issues.apache.org/jira/browse/HBASE-27671 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.2 > Environment: ENV- HBase 2.5.2 >Reporter: Ashok shetty >Assignee: Nihal Jain >Priority: Minor > Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png > > > Steps: > precondition : base.master.cleaner.snapshot.interval to 5 min in > hbase-site.xml > 1. create a table t1 , put some data > 2. create a snapshot 'snapt1' with TTL 1 mins > let the TTL expries > 3. disable and drop table t1 > 4. restore snapshot t1 > Actual : restore snapshot successful > Expected : restore operation should fail and throw specified snapshot TTL > expried cant restore > Note : its can consider as improvement point -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] virajjasani merged pull request #5117: HBASE-27671 Client should not be able to restore/clone a snapshot aft…
virajjasani merged PR #5117: URL: https://github.com/apache/hbase/pull/5117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani merged pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…
virajjasani merged PR #5109: URL: https://github.com/apache/hbase/pull/5109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
virajjasani commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1474751480 Triggered new Jenkins run https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5081/9/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
