[GitHub] [hbase] Apache-HBase commented on pull request #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

2023-04-18 Thread via GitHub


Apache-HBase commented on PR #5189:
URL: https://github.com/apache/hbase/pull/5189#issuecomment-1514160554

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 26s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 39s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 17s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 56s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 18s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  7s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 21s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 21s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 56s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 16s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 35s |  hbase-common in the patch passed.  
|
   | -1 :x: |  unit  | 217m 27s |  hbase-server in the patch failed.  |
   |  |   | 245m  6s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5189/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5189 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux f9ac1086ae6b 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 
13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 94a8f319bc |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5189/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5189/1/testReport/
 |
   | Max. process+thread count | 2539 (vs. ulimit of 3) |
   | modules | C: hbase-common U: hbase-common |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5189/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27791) Upgrade vega and its related js libraries

2023-04-18 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713904#comment-17713904
 ] 

Hudson commented on HBASE-27791:


Results for branch branch-2
[build #795 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Upgrade vega and its related js libraries
> -
>
> Key: HBASE-27791
> URL: https://issues.apache.org/jira/browse/HBASE-27791
> Project: HBase
>  Issue Type: Task
>  Components: UI
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-4
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> HBase is using Vega, v5.19.1, which was released on 21 Jan, 2021 and is 
> vulnerable to cross-site scripting (XSS), CVE IDs:
>  * [CVE-2023-26486|https://nvd.nist.gov/vuln/detail/CVE-2023-26486]
>  * [CVE-2023-26487|https://nvd.nist.gov/vuln/detail/CVE-2023-26487]
> This Jira is to upgrade to latest releases:
>  * [https://github.com/vega/vega/releases/tag/v5.24.0]
>  * [https://github.com/vega/vega-lite/releases/tag/v5.6.1]
>  * [https://github.com/vega/vega-embed/releases/tag/v6.21.3]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27787) Downgrade noisy info log in NettyRpcConnection when TLS enabled

2023-04-18 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713905#comment-17713905
 ] 

Hudson commented on HBASE-27787:


Results for branch branch-2
[build #795 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Downgrade noisy info log in NettyRpcConnection when TLS enabled
> ---
>
> Key: HBASE-27787
> URL: https://issues.apache.org/jira/browse/HBASE-27787
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: tls
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Log: SSL handler added with handshake timeout
> This logs for every server, so can cause quite a lot of spam for large 
> clusters. I'm not sure it's worth it, we can downgrade to debug.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27796) Improve MemcachedBlockCache

2023-04-18 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713903#comment-17713903
 ] 

Hudson commented on HBASE-27796:


Results for branch branch-2
[build #795 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/795/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Improve MemcachedBlockCache
> ---
>
> Key: HBASE-27796
> URL: https://issues.apache.org/jira/browse/HBASE-27796
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.5.4
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> MemcachedBlockCache is apparently not used, given the bugs I have found, but 
> provides some useful functionality that we are investigating at $dayjob. Fix 
> it.
>  - Track and log better stats
> - Fix use of memcached API such that we are not accidentally immediately 
> expiring keys.
> - Use a default retention period of 30 days, the max per memcached spec
> - Use set instead of add to store keys
> - Gracefully handle failures to cache and read timeouts
> - Add unit tests using jmemcached as a test dependency



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5182: HBASE-27783 Implement a shell command to disable all peer modification

2023-04-18 Thread via GitHub


Apache-HBase commented on PR #5182:
URL: https://github.com/apache/hbase/pull/5182#issuecomment-1514107087

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 22s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  1s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 18s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 15s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 21s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 38s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   4m 51s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 16s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 14s |  the patch passed  |
   | +1 :green_heart: |  cc  |   4m 14s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 14s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m  5s |  The patch passed checkstyle 
in hbase-protocol-shaded  |
   | +1 :green_heart: |  checkstyle  |   0m 13s |  The patch passed checkstyle 
in hbase-client  |
   | +1 :green_heart: |  checkstyle  |   0m 33s |  hbase-server: The patch 
generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)  |
   | +1 :green_heart: |  checkstyle  |   0m 28s |  The patch passed checkstyle 
in hbase-thrift  |
   | +1 :green_heart: |  checkstyle  |   0m  5s |  The patch passed checkstyle 
in hbase-shell  |
   | -0 :warning: |  rubocop  |   0m 10s |  The patch generated 10 new + 499 
unchanged - 8 fixed = 509 total (was 507)  |
   | -0 :warning: |  whitespace  |   0m  0s |  The patch has 1 line(s) that end 
in whitespace. Use git apply --whitespace=fix <>. Refer 
https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  hadoopcheck  |  12m 38s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 58s |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 37s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   5m 24s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 35s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  53m 30s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/4/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5182 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux 642ecf8cf785 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 
17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 94a8f319bc |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | rubocop | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
 |
   | whitespace | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/4/artifact/yetus-general-check/output/whitespace-eol.txt
 |
   | Max. process+thread count | 80 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift 
hbase-shell U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/4/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27740) Support Ozone as a WAL backing storage

2023-04-18 Thread Tak-Lon (Stephen) Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tak-Lon (Stephen) Wu updated HBASE-27740:
-
Fix Version/s: 2.6.0
   3.0.0-alpha-4

> Support Ozone as a WAL backing storage
> --
>
> Key: HBASE-27740
> URL: https://issues.apache.org/jira/browse/HBASE-27740
> Project: HBase
>  Issue Type: New Feature
>Reporter: Wei-Chiu Chuang
>Assignee: Tak-Lon (Stephen) Wu
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> As discussed in the 
> [thread|https://lists.apache.org/thread/tcrp8vxxs3z12y36mpzx35txhpp7tvxv], 
> we'd like to make HBase workloads possible on Ozone.
> This feature is to be built on top of 
> # HDDS-7593 (support hsync and lease recovery in Ozone), and
> # HADOOP-18671 (Add recoverLease(), setSafeMode(), isFileClosed() APIs to 
> FileSystem).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

2023-04-18 Thread via GitHub


Apache-HBase commented on PR #5189:
URL: https://github.com/apache/hbase/pull/5189#issuecomment-1514034351

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  3s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 34s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 47s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 33s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 37s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 32s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 32s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 12s |  hbase-common: The patch 
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  14m 16s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | -1 :x: |  spotless  |   0m 13s |  patch has 30 errors when running 
spotless:check, run spotless:apply to fix.  |
   | +1 :green_heart: |  spotbugs  |   0m 37s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  34m 21s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5189/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5189 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 078dc94c8c37 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 
10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 94a8f319bc |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5189/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
 |
   | spotless | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5189/1/artifact/yetus-general-check/output/patch-spotless.txt
 |
   | Max. process+thread count | 86 (vs. ulimit of 3) |
   | modules | C: hbase-common U: hbase-common |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5189/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] jojochuang opened a new pull request, #5189: HBASE-27746 Check if the file system supports storage policy before invoking setStoragePolicy()

2023-04-18 Thread via GitHub


jojochuang opened a new pull request, #5189:
URL: https://github.com/apache/hbase/pull/5189

   Simply check and ignore silently if the underlying FS does not support 
storage policy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27796) Improve MemcachedBlockCache

2023-04-18 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713744#comment-17713744
 ] 

Hudson commented on HBASE-27796:


Results for branch branch-2.5
[build #340 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/340/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/340/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/340/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/340/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/340/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Improve MemcachedBlockCache
> ---
>
> Key: HBASE-27796
> URL: https://issues.apache.org/jira/browse/HBASE-27796
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.5.4
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> MemcachedBlockCache is apparently not used, given the bugs I have found, but 
> provides some useful functionality that we are investigating at $dayjob. Fix 
> it.
>  - Track and log better stats
> - Fix use of memcached API such that we are not accidentally immediately 
> expiring keys.
> - Use a default retention period of 30 days, the max per memcached spec
> - Use set instead of add to store keys
> - Gracefully handle failures to cache and read timeouts
> - Add unit tests using jmemcached as a test dependency



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5182: HBASE-27783 Implement a shell command to disable all peer modification

2023-04-18 Thread via GitHub


Apache-HBase commented on PR #5182:
URL: https://github.com/apache/hbase/pull/5182#issuecomment-1513696376

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 52s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 23s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 22s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 33s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 18s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 24s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 24s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 24s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 30s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 37s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 16s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 209m 43s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  unit  |   6m 48s |  hbase-thrift in the patch passed.  
|
   | -1 :x: |  unit  |   3m  2s |  hbase-shell in the patch failed.  |
   |  |   | 251m 16s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5182 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 317f1a88a5a8 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 
14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / d56e7f291f |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/testReport/
 |
   | Max. process+thread count | 2589 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift 
hbase-shell U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5182: HBASE-27783 Implement a shell command to disable all peer modification

2023-04-18 Thread via GitHub


Apache-HBase commented on PR #5182:
URL: https://github.com/apache/hbase/pull/5182#issuecomment-1513691801

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 35s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  8s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 47s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 46s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 36s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  9s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 26s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 13s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 208m 50s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  unit  |   6m 46s |  hbase-thrift in the patch passed.  
|
   | -1 :x: |  unit  |   2m 46s |  hbase-shell in the patch failed.  |
   |  |   | 246m 47s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5182 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 567a19e100fa 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 
13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / d56e7f291f |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/testReport/
 |
   | Max. process+thread count | 2643 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift 
hbase-shell U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27728) Implement a tool to migrate replication peer data between different storage implementation

2023-04-18 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713731#comment-17713731
 ] 

Hudson commented on HBASE-27728:


Results for branch master
[build #820 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Implement a tool to migrate replication peer data between different storage 
> implementation
> --
>
> Key: HBASE-27728
> URL: https://issues.apache.org/jira/browse/HBASE-27728
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Replication peer data is usually stable unless you manually modify it, so it 
> is OK to not migrate automatically. Instead, we could provide a tool to 
> migrate the replication peer data.
> And after migration, users can use online configuration change or via a 
> cluster a restart to load the new configuration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27796) Improve MemcachedBlockCache

2023-04-18 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713732#comment-17713732
 ] 

Hudson commented on HBASE-27796:


Results for branch master
[build #820 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Improve MemcachedBlockCache
> ---
>
> Key: HBASE-27796
> URL: https://issues.apache.org/jira/browse/HBASE-27796
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.5.4
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> MemcachedBlockCache is apparently not used, given the bugs I have found, but 
> provides some useful functionality that we are investigating at $dayjob. Fix 
> it.
>  - Track and log better stats
> - Fix use of memcached API such that we are not accidentally immediately 
> expiring keys.
> - Use a default retention period of 30 days, the max per memcached spec
> - Use set instead of add to store keys
> - Gracefully handle failures to cache and read timeouts
> - Add unit tests using jmemcached as a test dependency



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC

2023-04-18 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713730#comment-17713730
 ] 

Hudson commented on HBASE-27762:


Results for branch master
[build #820 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Include EventType and ProcedureV2 pid in logging via MDC
> 
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution 
> is painful. We are pretty good about logging the {{proc_id}} most of the 
> time, but we don't catch them all. Now that we're up on log4j2, let's use the 
> MDC feature to include some basic information universally.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27791) Upgrade vega and its related js libraries

2023-04-18 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713729#comment-17713729
 ] 

Hudson commented on HBASE-27791:


Results for branch master
[build #820 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Upgrade vega and its related js libraries
> -
>
> Key: HBASE-27791
> URL: https://issues.apache.org/jira/browse/HBASE-27791
> Project: HBase
>  Issue Type: Task
>  Components: UI
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-4
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> HBase is using Vega, v5.19.1, which was released on 21 Jan, 2021 and is 
> vulnerable to cross-site scripting (XSS), CVE IDs:
>  * [CVE-2023-26486|https://nvd.nist.gov/vuln/detail/CVE-2023-26486]
>  * [CVE-2023-26487|https://nvd.nist.gov/vuln/detail/CVE-2023-26487]
> This Jira is to upgrade to latest releases:
>  * [https://github.com/vega/vega/releases/tag/v5.24.0]
>  * [https://github.com/vega/vega-lite/releases/tag/v5.6.1]
>  * [https://github.com/vega/vega-embed/releases/tag/v6.21.3]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-27787) Downgrade noisy info log in NettyRpcConnection when TLS enabled

2023-04-18 Thread Bryan Beaudreault (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault resolved HBASE-27787.
---
Fix Version/s: 2.6.0
   3.0.0-alpha-4
 Assignee: Bryan Beaudreault
   Resolution: Fixed

> Downgrade noisy info log in NettyRpcConnection when TLS enabled
> ---
>
> Key: HBASE-27787
> URL: https://issues.apache.org/jira/browse/HBASE-27787
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: tls
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Log: SSL handler added with handshake timeout
> This logs for every server, so can cause quite a lot of spam for large 
> clusters. I'm not sure it's worth it, we can downgrade to debug.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] bbeaudreault merged pull request #5169: HBASE-27787 Downgrade noisy info log in NettyRpcConnection when TLS enabled

2023-04-18 Thread via GitHub


bbeaudreault merged PR #5169:
URL: https://github.com/apache/hbase/pull/5169


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5182: HBASE-27783 Implement a shell command to disable all peer modification

2023-04-18 Thread via GitHub


Apache-HBase commented on PR #5182:
URL: https://github.com/apache/hbase/pull/5182#issuecomment-1513473587

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 29s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 38s |  master passed  |
   | +1 :green_heart: |  compile  |   5m 15s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 45s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 48s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   6m 20s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  8s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m  9s |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 10s |  the patch passed  |
   | +1 :green_heart: |  cc  |   5m 10s |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 10s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m  6s |  The patch passed checkstyle 
in hbase-protocol-shaded  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  The patch passed checkstyle 
in hbase-client  |
   | +1 :green_heart: |  checkstyle  |   0m 42s |  hbase-server: The patch 
generated 0 new + 9 unchanged - 1 fixed = 9 total (was 10)  |
   | +1 :green_heart: |  checkstyle  |   0m 32s |  The patch passed checkstyle 
in hbase-thrift  |
   | +1 :green_heart: |  checkstyle  |   0m  7s |  The patch passed checkstyle 
in hbase-shell  |
   | -0 :warning: |  rubocop  |   0m 27s |  The patch generated 8 new + 499 
unchanged - 8 fixed = 507 total (was 507)  |
   | -0 :warning: |  whitespace  |   0m  0s |  The patch has 1 line(s) that end 
in whitespace. Use git apply --whitespace=fix <>. Refer 
https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  hadoopcheck  |  15m 21s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  hbaseprotoc  |   2m 32s |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 48s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   7m  0s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 42s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  67m 49s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5182 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux bad66fdab9cf 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 
17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / d56e7f291f |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | rubocop | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
 |
   | whitespace | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/artifact/yetus-general-check/output/whitespace-eol.txt
 |
   | Max. process+thread count | 81 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift 
hbase-shell U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5182/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (HBASE-27803) Update ref guide about the changes of the replication storage related concepts

2023-04-18 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27803:
-

 Summary: Update ref guide about the changes of the replication 
storage related concepts
 Key: HBASE-27803
 URL: https://issues.apache.org/jira/browse/HBASE-27803
 Project: HBase
  Issue Type: Sub-task
  Components: documentation
Reporter: Duo Zhang


In the replication internal section, we still list zk as the only storage and 
do not mention that now we have a peer storage and a queue storage abstraction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27803) Update ref guide about the changes of the replication storage related concepts

2023-04-18 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang updated HBASE-27803:
--
Component/s: Replication

> Update ref guide about the changes of the replication storage related concepts
> --
>
> Key: HBASE-27803
> URL: https://issues.apache.org/jira/browse/HBASE-27803
> Project: HBase
>  Issue Type: Sub-task
>  Components: documentation, Replication
>Reporter: Duo Zhang
>Priority: Major
>
> In the replication internal section, we still list zk as the only storage and 
> do not mention that now we have a peer storage and a queue storage 
> abstraction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] NihalJain commented on pull request #5173: HBASE-27791 Upgrade vega and its related js libraries

2023-04-18 Thread via GitHub


NihalJain commented on PR #5173:
URL: https://github.com/apache/hbase/pull/5173#issuecomment-1513390860

   > ld pull in these javascript dependencies automatically? I think it would 
be better for everyone if these were
   
   
   
   > Looks good to me @NihalJain .
   > 
   > One follow-up question: do you have a suggestion as to how HBase build 
could pull in these javascript dependencies automatically? I think it would be 
better for everyone if these were not managed by hand.
   
   Created https://issues.apache.org/jira/browse/HBASE-27802 to discuss same


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (HBASE-27802) Manage static javascript resources programatically

2023-04-18 Thread Nihal Jain (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713633#comment-17713633
 ] 

Nihal Jain edited comment on HBASE-27802 at 4/18/23 3:41 PM:
-

Have been looking into [https://bower.io/] for a possible solution. I have done 
a small PoC to try the same. Would like to hear what others think of this.

Steps to reproduce PoC:
 * Install NPM:
 ** [https://docs.npmjs.com/downloading-and-installing-node-js-and-npm]
 * Install bower:
 ** npm install -g bower

 * PoC Steps
 ** 
{code:java}
## CREATE .bowerrc with following content
➜  cat .bowerrc
{
  "directory": "public",
  "analytics": false,
  "registry": "https://registry.bower.io;
}

## CREATE bower.json with following content
➜  cat bower.json
{
  "name": "hbase-ui",
  "dependencies": {
"bootstrap": 
"https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/js/bootstrap.min.js;,
"jquery": "https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js;,
"jquery-tablesortable": 
"https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/jquery.tablesorter.min.js;,
"parser-date-iso8601": 
"https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/parsers/parser-date-iso8601.min.js;,
"vega": "https://cdn.jsdelivr.net/npm/vega@5.24.0/build/vega.min.js;,
"vega-lite": 
"https://cdn.jsdelivr.net/npm/vega-lite@5.6.1/build/vega-lite.min.js;,
"vega-embed": 
"https://cdn.jsdelivr.net/npm/vega-embed@6.21.3/build/vega-embed.min.js;
  }
}

## LIST CONTENT OF DIRECTORY
➜  ll -a
total 32
drwxr-xr-x  5 nihjain  staff   160B Apr 18 21:03 .
drwxr-xr-x  6 nihjain  staff   192B Apr 18 12:09 ..
-rw-r--r--@ 1 nihjain  staff   6.0K Apr 18 20:59 .DS_Store
-rw-r--r--  1 nihjain  staff93B Apr 18 12:56 .bowerrc
-rw-r--r--@ 1 nihjain  staff   729B Apr 18 16:31 bower.json

## RUN BOWER INSTALL
➜  bower install
bower bootstrap#*   cached 
https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/js/bootstrap.min.js#e-tag:W/"9b00-sW
bower bootstrap#* validate e-tag:W/"9b00-sW against 
https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/js/bootstrap.min.js#*
bower jquery-tablesortable#*cached 
https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/jquery.tablesorter.min.js#e-tag:5eb03ec4-
bower jquery-tablesortable#*  validate e-tag:5eb03ec4- against 
https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/jquery.tablesorter.min.js#*
bower jquery#*  cached 
https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js#e-tag:W/"15d84-y
bower jquery#*validate e-tag:W/"15d84-y against 
https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js#*
bower parser-date-iso8601#* cached 
https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/parsers/parser-date-iso8601.min.js#e-tag:5eb03ec4-
bower parser-date-iso8601#*   validate e-tag:5eb03ec4- against 
https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/parsers/parser-date-iso8601.min.js#*
bower vega-lite#*   cached 
https://cdn.jsdelivr.net/npm/vega-lite@5.6.1/build/vega-lite.min.js#e-tag:W/"3bb90-H
bower vega-lite#* validate e-tag:W/"3bb90-H against 
https://cdn.jsdelivr.net/npm/vega-lite@5.6.1/build/vega-lite.min.js#*
bower vega#*cached 
https://cdn.jsdelivr.net/npm/vega@5.24.0/build/vega.min.js#e-tag:W/"7cad0-K
bower vega#*  validate e-tag:W/"7cad0-K against 
https://cdn.jsdelivr.net/npm/vega@5.24.0/build/vega.min.js#*
bower vega-embed#*  cached 
https://cdn.jsdelivr.net/npm/vega-embed@6.21.3/build/vega-embed.min.js#e-tag:W/"fb7f-46
bower vega-embed#*validate e-tag:W/"fb7f-46 against 
https://cdn.jsdelivr.net/npm/vega-embed@6.21.3/build/vega-embed.min.js#*
bower jquery#* install jquery#e-tag:W/"15d84-y
bower bootstrap#*  install bootstrap#e-tag:W/"9b00-sW
bower vega-embed#* install vega-embed#e-tag:W/"fb7f-46
bower vega#*   install vega#e-tag:W/"7cad0-K
bower jquery-tablesortable#*   install jquery-tablesortable#e-tag:5eb03ec4-
bower parser-date-iso8601#*install parser-date-iso8601#e-tag:5eb03ec4-
bower vega-lite#*  install vega-lite#e-tag:W/"3bb90-H

jquery#e-tag:W/"15d84-y public/jquery

bootstrap#e-tag:W/"9b00-sW public/bootstrap

vega-embed#e-tag:W/"fb7f-46 public/vega-embed

vega#e-tag:W/"7cad0-K public/vega

jquery-tablesortable#e-tag:5eb03ec4- public/jquery-tablesortable

parser-date-iso8601#e-tag:5eb03ec4- public/parser-date-iso8601

vega-lite#e-tag:W/"3bb90-H public/vega-lite

## LIST CONTENT OF DIRECTORY
➜  ls -aR
.  .. .DS_Store  .bowerrc   bower.json public

./public:
.bootstrapjquery-tablesortable vega 
vega-lite
..   jquery   parser-date-iso8601  vega-embed

./public/bootstrap:
.   .. 

[jira] [Commented] (HBASE-27802) Manage static javascript resources programatically

2023-04-18 Thread Nihal Jain (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713633#comment-17713633
 ] 

Nihal Jain commented on HBASE-27802:


Have been looking into [https://bower.io/] to a possible solution. I have done 
a small PoC to try the same. Would like to hear what others think of this.

Steps to reproduce PoC:
 * Install NPM:
 ** [https://docs.npmjs.com/downloading-and-installing-node-js-and-npm]
 * Install bower:
 ** npm install -g bower

 * PoC Steps
 ** 
{code:java}
## CREATE .bowerrc with following content
➜  cat .bowerrc
{
  "directory": "public",
  "analytics": false,
  "registry": "https://registry.bower.io;
}

## CREATE bower.json with following content
➜  cat bower.json
{
  "name": "hbase-ui",
  "dependencies": {
"bootstrap": 
"https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/js/bootstrap.min.js;,
"jquery": "https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js;,
"jquery-tablesortable": 
"https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/jquery.tablesorter.min.js;,
"parser-date-iso8601": 
"https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/parsers/parser-date-iso8601.min.js;,
"vega": "https://cdn.jsdelivr.net/npm/vega@5.24.0/build/vega.min.js;,
"vega-lite": 
"https://cdn.jsdelivr.net/npm/vega-lite@5.6.1/build/vega-lite.min.js;,
"vega-embed": 
"https://cdn.jsdelivr.net/npm/vega-embed@6.21.3/build/vega-embed.min.js;
  }
}

## LIST CONTENT OF DIRECTORY
➜  ll -a
total 32
drwxr-xr-x  5 nihjain  staff   160B Apr 18 21:03 .
drwxr-xr-x  6 nihjain  staff   192B Apr 18 12:09 ..
-rw-r--r--@ 1 nihjain  staff   6.0K Apr 18 20:59 .DS_Store
-rw-r--r--  1 nihjain  staff93B Apr 18 12:56 .bowerrc
-rw-r--r--@ 1 nihjain  staff   729B Apr 18 16:31 bower.json

## RUN BOWER INSTALL
➜  bower install
bower bootstrap#*   cached 
https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/js/bootstrap.min.js#e-tag:W/"9b00-sW
bower bootstrap#* validate e-tag:W/"9b00-sW against 
https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/js/bootstrap.min.js#*
bower jquery-tablesortable#*cached 
https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/jquery.tablesorter.min.js#e-tag:5eb03ec4-
bower jquery-tablesortable#*  validate e-tag:5eb03ec4- against 
https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/jquery.tablesorter.min.js#*
bower jquery#*  cached 
https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js#e-tag:W/"15d84-y
bower jquery#*validate e-tag:W/"15d84-y against 
https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js#*
bower parser-date-iso8601#* cached 
https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/parsers/parser-date-iso8601.min.js#e-tag:5eb03ec4-
bower parser-date-iso8601#*   validate e-tag:5eb03ec4- against 
https://cdnjs.cloudflare.com/ajax/libs/jquery.tablesorter/2.31.3/js/parsers/parser-date-iso8601.min.js#*
bower vega-lite#*   cached 
https://cdn.jsdelivr.net/npm/vega-lite@5.6.1/build/vega-lite.min.js#e-tag:W/"3bb90-H
bower vega-lite#* validate e-tag:W/"3bb90-H against 
https://cdn.jsdelivr.net/npm/vega-lite@5.6.1/build/vega-lite.min.js#*
bower vega#*cached 
https://cdn.jsdelivr.net/npm/vega@5.24.0/build/vega.min.js#e-tag:W/"7cad0-K
bower vega#*  validate e-tag:W/"7cad0-K against 
https://cdn.jsdelivr.net/npm/vega@5.24.0/build/vega.min.js#*
bower vega-embed#*  cached 
https://cdn.jsdelivr.net/npm/vega-embed@6.21.3/build/vega-embed.min.js#e-tag:W/"fb7f-46
bower vega-embed#*validate e-tag:W/"fb7f-46 against 
https://cdn.jsdelivr.net/npm/vega-embed@6.21.3/build/vega-embed.min.js#*
bower jquery#* install jquery#e-tag:W/"15d84-y
bower bootstrap#*  install bootstrap#e-tag:W/"9b00-sW
bower vega-embed#* install vega-embed#e-tag:W/"fb7f-46
bower vega#*   install vega#e-tag:W/"7cad0-K
bower jquery-tablesortable#*   install jquery-tablesortable#e-tag:5eb03ec4-
bower parser-date-iso8601#*install parser-date-iso8601#e-tag:5eb03ec4-
bower vega-lite#*  install vega-lite#e-tag:W/"3bb90-H

jquery#e-tag:W/"15d84-y public/jquery

bootstrap#e-tag:W/"9b00-sW public/bootstrap

vega-embed#e-tag:W/"fb7f-46 public/vega-embed

vega#e-tag:W/"7cad0-K public/vega

jquery-tablesortable#e-tag:5eb03ec4- public/jquery-tablesortable

parser-date-iso8601#e-tag:5eb03ec4- public/parser-date-iso8601

vega-lite#e-tag:W/"3bb90-H public/vega-lite

## LIST CONTENT OF DIRECTORY
➜  ls -aR
.  .. .DS_Store  .bowerrc   bower.json public

./public:
.bootstrapjquery-tablesortable vega 
vega-lite
..   jquery   parser-date-iso8601  vega-embed

./public/bootstrap:
.   ..  .bower.json index.js

./public/jquery:
. 

[jira] [Commented] (HBASE-27795) Define RPC API for cache cleaning

2023-04-18 Thread Wellington Chevreuil (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713627#comment-17713627
 ] 

Wellington Chevreuil commented on HBASE-27795:
--

Hello [~bbeaudreault], yes sir, contributions/new ideas are very welcome! So 
let me explain a bit where we are with this. 

Context: We try to cache as much of our data from object store into local file 
based bucket cache. Once we have the cache warmed up, we don't want to 
unnecessary have to cache it again. Even if a RS restarts (gracefully or 
crash), we want it to be able to recover its cache from before, and avoid 
having to go back to read those blocks from the object store. That's why we did 
HBASE-27750/HBASE-27551 (we also have HBASE-27389 ongoing).

Problems: 
1) CACHE RECOVERY: We already had a map of the files->blocks persisted into a 
local file, however we were always prefetching all the files again on region 
opening. HBASE-27313/HBASE-27686 implemented the functionality to save a list 
of files whose blocks have been cached, so that we don't need to cache those 
again. Then the next problem was to make sure we don't evict blocks for the 
hosted regions.
2) EVICT WISELY: We don't want to evict blocks for files that are still 
relevant (not compacted away and from regions the given RS is hosting). For 
that, we needed to turn hbase.rs.evictblocksonclose from default of false, to 
true. Now the problem is what to do with regions moves?
3) AVOID MOVING REGIONS: RSes restarts take longer than AM does to triggers 
SCPs and reassign regions from the crash/restarted RSes on the remaining online 
RSes. This nullifies the feature implemented in #1. So we thought to compromise 
on region availability by introducing a delay on SCPs to wait for the original 
server to come online (HBASE-27551). Delaying reassignment is not only 
sub-optimal, but there's still the problem of regions moving due to region 
balancer. We have to disable the balancer, until we can get it also taking the 
cache into consideration (HBASE-27389 ongoing). But regions may still move, say 
if the delay threshold for reassignment is expired, or if new RSes are added 
and regions are moved manually, or with the balancer after HBASE-27389 , now 
the cache will have blocks for regions the RS no longer hosts.
4) EVICT IF REGION MOVE, KEEP IF RS RESTART: That's what we want to do in 
HBASE-27752. We know when region is closed because of a RS restart. We could 
change CloseRegionHandler so that when the prefetch persistence is enabled, we 
never evict. Then we could leave hbase.rs.evictblocksonclose set to true 
globally, so that blocks would get evicted on regions moves triggered by the 
balancer or manually. But crashes may still be a problem, if the crashed server 
comes back after the assignment delay. That's what motivated the cache cleaning 
feature described in this jira. And yeah, I guess the cleaning logic might well 
be invoked by some scheduled chore as well, not only manually via API.

> Define RPC API for cache cleaning
> -
>
> Key: HBASE-27795
> URL: https://issues.apache.org/jira/browse/HBASE-27795
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Priority: Major
>
> We should add an RPC API to allow for a "limited manual" cache cleaning. If 
> hbase.rs.evictblocksonclose is set to false, blocks may hang in the cache 
> upon regions move between RSes. 
> The method at the RS level, should compare the files from its online regions 
> against the files in the prefetch list file, evicting blocks from the files 
> in the prefetch list file that are not in any of the online regions for the 
> given RS.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27802) Manage static javascript resources programatically

2023-04-18 Thread Nihal Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated HBASE-27802:
---
Description: 
Currently, the static JavaScript resources need to be manually managed. That 
is, if any of these has to be updated, we will be required to download them 
from web and place them under the appropriate path. This can be cumbersome.

See list of JS under hbase-server at 
[https://github.com/apache/hbase/tree/master/hbase-server/src/main/resources/hbase-webapps/static/js]

Need to find a way to manage them with minimal manual effort. Best case would 
be to manage them as part of build.

 

> Manage static javascript resources programatically
> --
>
> Key: HBASE-27802
> URL: https://issues.apache.org/jira/browse/HBASE-27802
> Project: HBase
>  Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Currently, the static JavaScript resources need to be manually managed. That 
> is, if any of these has to be updated, we will be required to download them 
> from web and place them under the appropriate path. This can be cumbersome.
> See list of JS under hbase-server at 
> [https://github.com/apache/hbase/tree/master/hbase-server/src/main/resources/hbase-webapps/static/js]
> Need to find a way to manage them with minimal manual effort. Best case would 
> be to manage them as part of build.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (HBASE-27795) Define RPC API for cache cleaning

2023-04-18 Thread Wellington Chevreuil (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713627#comment-17713627
 ] 

Wellington Chevreuil edited comment on HBASE-27795 at 4/18/23 3:27 PM:
---

Hello [~bbeaudreault], yes sir, contributions/new ideas are very welcome! So 
let me explain a bit where we are with this. 

Context: We try to cache as much of our data from object store into local file 
based bucket cache. Once we have the cache warmed up, we don't want to 
unnecessary have to cache it again. Even if a RS restarts (gracefully or 
crash), we want it to be able to recover its cache from before, and avoid 
having to go back to read those blocks from the object store. That's why we did 
HBASE-27750/HBASE-27551 (we also have HBASE-27389 ongoing).

Problems: 
1) CACHE RECOVERY: We already had a map of the files->blocks persisted into a 
local file, however we were always prefetching all the files again on region 
opening. HBASE-27313/HBASE-27686 implemented the functionality to save a list 
of files whose blocks have been cached, so that we don't need to cache those 
again. Then the next problem was to make sure we don't evict blocks for the 
hosted regions.

2) EVICT WISELY: We don't want to evict blocks for files that are still 
relevant (not compacted away and from regions the given RS is hosting). For 
that, we needed to turn hbase.rs.evictblocksonclose from default of false, to 
true. Now the problem is what to do with regions moves?

3) AVOID MOVING REGIONS: RSes restarts take longer than AM does to triggers 
SCPs and reassign regions from the crash/restarted RSes on the remaining online 
RSes. This nullifies the feature implemented in #1. So we thought to compromise 
on region availability by introducing a delay on SCPs to wait for the original 
server to come online (HBASE-27551). Delaying reassignment is not only 
sub-optimal, but there's still the problem of regions moving due to region 
balancer. We have to disable the balancer, until we can get it also taking the 
cache into consideration (HBASE-27389 ongoing). But regions may still move, say 
if the delay threshold for reassignment is expired, or if new RSes are added 
and regions are moved manually, or with the balancer after HBASE-27389 , now 
the cache will have blocks for regions the RS no longer hosts.

4) EVICT IF REGION MOVE, KEEP IF RS RESTART: That's what we want to do in 
HBASE-27752. We know when region is closed because of a RS restart. We could 
change CloseRegionHandler so that when the prefetch persistence is enabled, we 
never evict. Then we could leave hbase.rs.evictblocksonclose set to true 
globally, so that blocks would get evicted on regions moves triggered by the 
balancer or manually. But crashes may still be a problem, if the crashed server 
comes back after the assignment delay. That's what motivated the cache cleaning 
feature described in this jira. And yeah, I guess the cleaning logic might well 
be invoked by some scheduled chore as well, not only manually via API.


was (Author: wchevreuil):
Hello [~bbeaudreault], yes sir, contributions/new ideas are very welcome! So 
let me explain a bit where we are with this. 

Context: We try to cache as much of our data from object store into local file 
based bucket cache. Once we have the cache warmed up, we don't want to 
unnecessary have to cache it again. Even if a RS restarts (gracefully or 
crash), we want it to be able to recover its cache from before, and avoid 
having to go back to read those blocks from the object store. That's why we did 
HBASE-27750/HBASE-27551 (we also have HBASE-27389 ongoing).

Problems: 
1) CACHE RECOVERY: We already had a map of the files->blocks persisted into a 
local file, however we were always prefetching all the files again on region 
opening. HBASE-27313/HBASE-27686 implemented the functionality to save a list 
of files whose blocks have been cached, so that we don't need to cache those 
again. Then the next problem was to make sure we don't evict blocks for the 
hosted regions.
2) EVICT WISELY: We don't want to evict blocks for files that are still 
relevant (not compacted away and from regions the given RS is hosting). For 
that, we needed to turn hbase.rs.evictblocksonclose from default of false, to 
true. Now the problem is what to do with regions moves?
3) AVOID MOVING REGIONS: RSes restarts take longer than AM does to triggers 
SCPs and reassign regions from the crash/restarted RSes on the remaining online 
RSes. This nullifies the feature implemented in #1. So we thought to compromise 
on region availability by introducing a delay on SCPs to wait for the original 
server to come online (HBASE-27551). Delaying reassignment is not only 
sub-optimal, but there's still the problem of regions moving due to region 
balancer. We have to disable the balancer, until we can get it also taking the 
cache into consideration 

[GitHub] [hbase] 2005hithlj commented on pull request #5178: HBASE-27274 Re-enable the disabled tests when implementing HBASE-27212

2023-04-18 Thread via GitHub


2005hithlj commented on PR #5178:
URL: https://github.com/apache/hbase/pull/5178#issuecomment-1513359430

   
   
   
   
   > > In my local environment, TestReplicationValueCompressedWAL will still 
fail, but TestReplicationDroppedTables will succeed.
   > 
   > Oh, you can reproduce the failure of TestReplicationValueCompressedWAL 
locally? It has been flaky for a long time but it is really hard to reproduce 
the failure locally so no big progress on the fixing... If you can reproduce it 
locally, could you please try to find out the root cause?
   > 
   > Thanks.
   
   OK, I will try to find out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (HBASE-27802) Manage static javascript resources programatically

2023-04-18 Thread Nihal Jain (Jira)
Nihal Jain created HBASE-27802:
--

 Summary: Manage static javascript resources programatically
 Key: HBASE-27802
 URL: https://issues.apache.org/jira/browse/HBASE-27802
 Project: HBase
  Issue Type: Improvement
Reporter: Nihal Jain
Assignee: Nihal Jain






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27535) Separate slowlog thresholds for scans vs other requests

2023-04-18 Thread Ray Mattingly (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713615#comment-17713615
 ] 

Ray Mattingly commented on HBASE-27535:
---

[https://github.com/apache/hbase/pull/5188] is ready for review

> Separate slowlog thresholds for scans vs other requests
> ---
>
> Key: HBASE-27535
> URL: https://issues.apache.org/jira/browse/HBASE-27535
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Ray Mattingly
>Priority: Major
>  Labels: slowlog
>
> Scans by their nature are able to more efficiently pull back larger response 
> sizes than gets. They also may take longer to execute than other request 
> types. We should make it possible to configure a separate threshold for 
> response time and response time for scans. This will allow us to tune down 
> the thresholds for others without adding unnecessary noise for requests which 
> are known to be slower/bigger.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27795) Define RPC API for cache cleaning

2023-04-18 Thread Bryan Beaudreault (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713600#comment-17713600
 ] 

Bryan Beaudreault commented on HBASE-27795:
---

How would you plan to use this? I think you guys are working hard on HBaseOnS3 
and imagine this is related. Is it possible to contribute whatever you plan to 
use this for directly into hbase, rather than just the API? I imagine many 
others will be interested in this over time. Just a thought.

> Define RPC API for cache cleaning
> -
>
> Key: HBASE-27795
> URL: https://issues.apache.org/jira/browse/HBASE-27795
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Wellington Chevreuil
>Priority: Major
>
> We should add an RPC API to allow for a "limited manual" cache cleaning. If 
> hbase.rs.evictblocksonclose is set to false, blocks may hang in the cache 
> upon regions move between RSes. 
> The method at the RS level, should compare the files from its online regions 
> against the files in the prefetch list file, evicting blocks from the files 
> in the prefetch list file that are not in any of the online regions for the 
> given RS.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-27274) Re-enable the disabled tests when implementing HBASE-27212

2023-04-18 Thread Duo Zhang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-27274.
---
Fix Version/s: HBASE-27109
 Hadoop Flags: Reviewed
   Resolution: Fixed

Merged to branch HBASE-27109.

Thanks [~heliangjun]!

> Re-enable the disabled tests when implementing HBASE-27212
> --
>
> Key: HBASE-27274
> URL: https://issues.apache.org/jira/browse/HBASE-27274
> Project: HBase
>  Issue Type: Sub-task
>  Components: test
>Reporter: Duo Zhang
>Assignee: Liangjun He
>Priority: Major
> Fix For: HBASE-27109
>
>
> For landing the first basic framework of the new replication queue storage 
> implementation, we have to disable several UTs. This issue is used to track 
> these tests to make sure we finally re-enabled them all.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache9 merged pull request #5178: HBASE-27274 Re-enable the disabled tests when implementing HBASE-27212

2023-04-18 Thread via GitHub


Apache9 merged PR #5178:
URL: https://github.com/apache/hbase/pull/5178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache9 commented on pull request #5178: HBASE-27274 Re-enable the disabled tests when implementing HBASE-27212

2023-04-18 Thread via GitHub


Apache9 commented on PR #5178:
URL: https://github.com/apache/hbase/pull/5178#issuecomment-1513184132

   > In my local environment, TestReplicationValueCompressedWAL will still 
fail, but TestReplicationDroppedTables will succeed.
   
   Oh, you can reproduce the failure of TestReplicationValueCompressedWAL 
locally? It has been flaky for a long time but it is really hard to reproduce 
the failure locally so no big progress on the fixing...
   If you can reproduce it locally, could you please try to find out the root 
cause?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] bsglz commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store

2023-04-18 Thread via GitHub


bsglz commented on PR #5171:
URL: https://github.com/apache/hbase/pull/5171#issuecomment-1513011277

   Rerun the tests in another way that run  the three compare methods one by 
one, and the results are different from above, not sure why, it seems to be 
some mutual interference.
   
   **1: Tested by PerfTestCellComparator2.java(the code shows below), used for 
region level to comping cells among stores.**
   
   
   
   compareMethod | leftFam | rightFam | comparator | cost(ms) | diff
   -- | -- | -- | -- | -- | --
   compareKV | fam | fam1 | CellComparatorOld | 21916 |  
   compareKV | fam | fam1 | CellComparatorImpl | 21612 | -1.00%
   compareKV | fam1 | fam2 | CellComparatorOld | 21970 |  
   compareKV | fam1 | fam2 | CellComparatorImpl | 21515 | -2.00%
   compareBBKV | fam | fam1 | CellComparatorOld | 22829 |  
   compareBBKV | fam | fam1 | CellComparatorImpl | 21821 | -4.00%
   compareBBKV | fam1 | fam2 | CellComparatorOld | 22659 |  
   compareBBKV | fam1 | fam2 | CellComparatorImpl | 21586 | -5.00%
   compareKVVsBBKV | fam | fam1 | CellComparatorOld | 19844 |  
   compareKVVsBBKV | fam | fam1 | CellComparatorImpl | 20020 | 1.00%
   compareKVVsBBKV | fam1 | fam2 | CellComparatorOld | 20140 |  
   compareKVVsBBKV | fam1 | fam2 | CellComparatorImpl | 19433 | -4.00%
   
   
   
   **2: Tested by PerfTestCellComparator.java(the code included in this PR), 
used for inner store comparing.**
   
   
   
   compareMethod | leftFam | rightFam | comparator | cost(ms) | diff
   -- | -- | -- | -- | -- | --
   compareKV | 0 | 0 | CellComparatorOld | 27251 |  
   compareKV | 0 | 0 | InnerStoreCellComparator | 25836 | -5.00%
   compareKV | 0 | 4 | CellComparatorOld | 17925 |  
   compareKV | 0 | 4 | InnerStoreCellComparator | 16482 | -8.00%
   compareKV | 4 | 0 | CellComparatorOld | 18043 |  
   compareKV | 4 | 0 | InnerStoreCellComparator | 16403 | -9.00%
   compareKV | 4 | 4 | CellComparatorOld | 30335 |  
   compareKV | 4 | 4 | InnerStoreCellComparator | 25700 | -15.00%
   compareBBKV | 0 | 0 | CellComparatorOld | 27888 |  
   compareBBKV | 0 | 0 | InnerStoreCellComparator | 26236 | -6.00%
   compareBBKV | 0 | 4 | CellComparatorOld | 19251 |  
   compareBBKV | 0 | 4 | InnerStoreCellComparator | 16870 | -12.00%
   compareBBKV | 4 | 0 | CellComparatorOld | 19290 |  
   compareBBKV | 4 | 0 | InnerStoreCellComparator | 16827 | -13.00%
   compareBBKV | 4 | 4 | CellComparatorOld | 31851 |  
   compareBBKV | 4 | 4 | InnerStoreCellComparator | 27387 | -14.00%
   compareKVVsBBKV | 0 | 0 | CellComparatorOld | 27563 |  
   compareKVVsBBKV | 0 | 0 | InnerStoreCellComparator | 28869 | 5.00%
   compareKVVsBBKV | 0 | 4 | CellComparatorOld | 18620 |  
   compareKVVsBBKV | 0 | 4 | InnerStoreCellComparator | 16031 | -14.00%
   compareKVVsBBKV | 4 | 0 | CellComparatorOld | 17629 |  
   compareKVVsBBKV | 4 | 0 | InnerStoreCellComparator | 16433 | -7.00%
   compareKVVsBBKV | 4 | 4 | CellComparatorOld | 30590 |  
   compareKVVsBBKV | 4 | 4 | InnerStoreCellComparator | 26643 | -13.00%
   
   
   
   Attach the other perf test class here, for one who interesting to test local:
   ```
   /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements.  See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership.  The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License.  You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
   package org.apache.hadoop.hbase.regionserver;
   
   import java.nio.ByteBuffer;
   import java.util.ArrayList;
   import java.util.Collection;
   import java.util.List;
   import org.apache.hadoop.hbase.ByteBufferKeyValue;
   import org.apache.hadoop.hbase.Cell;
   import org.apache.hadoop.hbase.CellComparator;
   import org.apache.hadoop.hbase.CellComparatorOld;
   import org.apache.hadoop.hbase.HBaseClassTestRule;
   import org.apache.hadoop.hbase.KeyValue;
   import 

[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC

2023-04-18 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713560#comment-17713560
 ] 

Duo Zhang commented on HBASE-27762:
---

At least let's mention this in the release note?

> Include EventType and ProcedureV2 pid in logging via MDC
> 
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution 
> is painful. We are pretty good about logging the {{proc_id}} most of the 
> time, but we don't catch them all. Now that we're up on log4j2, let's use the 
> MDC feature to include some basic information universally.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (HBASE-27667) Normalizer can skip picking presplit regions while preparing merge plans

2023-04-18 Thread Rajeshbabu Chintaguntla (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajeshbabu Chintaguntla resolved HBASE-27667.
-
Fix Version/s: (was: 2.6.0)
   (was: 3.0.0-alpha-4)
   (was: 2.5.5)
   Resolution: Won't Fix

As [~ndimiduk] mentioned at PR it would be better to not to check the 
storefiles count and size as a metric of considering presplit region. Hence 
closing as won't fix as there is no alternative meta data checks to find the 
presplit regions. Will reopen if any fix possible.

> Normalizer can skip picking presplit regions while preparing merge plans
> 
>
> Key: HBASE-27667
> URL: https://issues.apache.org/jira/browse/HBASE-27667
> Project: HBase
>  Issue Type: Improvement
>  Components: Normalizer
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
>
> Normalizer can be used to merge the regions which become emtpy post TTL 
> expiry.
> But it's picking the presplit regions as well. We can skip picking presplit 
> regions while preparing the merge plans by looking at the number of 
> storefiles along with size. Presplit regions have zero storefiles where as 
> the TTL expired regions have 1 storefile with zero size.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work stopped] (HBASE-27667) Normalizer can skip picking presplit regions while preparing merge plans

2023-04-18 Thread Rajeshbabu Chintaguntla (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-27667 stopped by Rajeshbabu Chintaguntla.
---
> Normalizer can skip picking presplit regions while preparing merge plans
> 
>
> Key: HBASE-27667
> URL: https://issues.apache.org/jira/browse/HBASE-27667
> Project: HBase
>  Issue Type: Improvement
>  Components: Normalizer
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> Normalizer can be used to merge the regions which become emtpy post TTL 
> expiry.
> But it's picking the presplit regions as well. We can skip picking presplit 
> regions while preparing the merge plans by looking at the number of 
> storefiles along with size. Presplit regions have zero storefiles where as 
> the TTL expired regions have 1 storefile with zero size.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] chrajeshbabu commented on a diff in pull request #5170: HBASE-27667 Normalizer can skip picking presplit regions while prepar…

2023-04-18 Thread via GitHub


chrajeshbabu commented on code in PR #5170:
URL: https://github.com/apache/hbase/pull/5170#discussion_r1169853503


##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
##
@@ -474,6 +494,11 @@ private boolean isLargeEnoughForMerge(final 
NormalizerConfiguration normalizerCo
 return getRegionSizeMB(regionInfo) >= 
normalizerConfiguration.getMergeMinRegionSizeMb(ctx);
   }
 
+  private boolean isPresplitEmptyRegion(final NormalizerConfiguration 
normalizerConfiguration,
+final NormalizeContext ctx, final RegionInfo regionInfo) {
+return getStoreFileCount(regionInfo) == 0 &&

Review Comment:
   @ndimiduk agree with you. Will close this PR as of now as there is no other 
means to detect the presplit regions from meta data and reopen in case of any 
best option. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] chrajeshbabu closed pull request #5170: HBASE-27667 Normalizer can skip picking presplit regions while prepar…

2023-04-18 Thread via GitHub


chrajeshbabu closed pull request #5170: HBASE-27667 Normalizer can skip picking 
presplit regions while prepar…
URL: https://github.com/apache/hbase/pull/5170


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] chrajeshbabu commented on a diff in pull request #5172: HBASE-27663 ChaosMonkey documentation enhancements

2023-04-18 Thread via GitHub


chrajeshbabu commented on code in PR #5172:
URL: https://github.com/apache/hbase/pull/5172#discussion_r1169839524


##
src/main/asciidoc/_chapters/developer.adoc:
##
@@ -1801,6 +1801,58 @@ $ bin/hbase org.apache.hadoop.hbase.util.ChaosMonkey
 The output indicates that ChaosMonkey started the default 
`PeriodicRandomActionPolicy`
 policy, which is configured with all the available actions. It chose to run 
`RestartActiveMaster` and `RestartRandomRs` actions.
 
+ ChaosMonkey without SSH
+
+Chaos monkey can be run without SSH using the Chaos service and ZNode cluster 
manager. HBase ships
+with many cluster managers, available in the 
`hbase-it/src/test/java/org/apache/hadoop/hbase/` directory.
+
+Set the following property in hbase configuration to switch to 
`ZNodeClusterManager`:
+`hbase.it.clustermanager.class=org.apache.hadoop.hbase.ZNodeClusterManager`
+
+Start chaos service on all hosts where you want to test chaos scenarios.
+
+[source,bash]
+
+$ bin/hbase org.apache.hadoop.hbase.chaos.ChaosService
+
+Start chaos monkey from any one host.

Review Comment:
   Change it to "Start chaos monkey runner from any host preferably from edge 
node"



##
src/main/asciidoc/_chapters/developer.adoc:
##
@@ -1801,6 +1801,58 @@ $ bin/hbase org.apache.hadoop.hbase.util.ChaosMonkey
 The output indicates that ChaosMonkey started the default 
`PeriodicRandomActionPolicy`
 policy, which is configured with all the available actions. It chose to run 
`RestartActiveMaster` and `RestartRandomRs` actions.
 
+ ChaosMonkey without SSH
+
+Chaos monkey can be run without SSH using the Chaos service and ZNode cluster 
manager. HBase ships
+with many cluster managers, available in the 
`hbase-it/src/test/java/org/apache/hadoop/hbase/` directory.
+
+Set the following property in hbase configuration to switch to 
`ZNodeClusterManager`:
+`hbase.it.clustermanager.class=org.apache.hadoop.hbase.ZNodeClusterManager`
+
+Start chaos service on all hosts where you want to test chaos scenarios.

Review Comment:
   "chaos service"-> "chaos agent"



##
src/main/asciidoc/_chapters/developer.adoc:
##
@@ -1801,6 +1801,58 @@ $ bin/hbase org.apache.hadoop.hbase.util.ChaosMonkey
 The output indicates that ChaosMonkey started the default 
`PeriodicRandomActionPolicy`
 policy, which is configured with all the available actions. It chose to run 
`RestartActiveMaster` and `RestartRandomRs` actions.
 
+ ChaosMonkey without SSH
+
+Chaos monkey can be run without SSH using the Chaos service and ZNode cluster 
manager. HBase ships
+with many cluster managers, available in the 
`hbase-it/src/test/java/org/apache/hadoop/hbase/` directory.
+
+Set the following property in hbase configuration to switch to 
`ZNodeClusterManager`:
+`hbase.it.clustermanager.class=org.apache.hadoop.hbase.ZNodeClusterManager`
+
+Start chaos service on all hosts where you want to test chaos scenarios.
+
+[source,bash]
+
+$ bin/hbase org.apache.hadoop.hbase.chaos.ChaosService

Review Comment:
   Would be better to provide the options accepted to start the chaosagent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27791) Upgrade vega and its related js libraries

2023-04-18 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-27791:
-
Affects Version/s: 2.5.0
   (was: 2.5.4)

> Upgrade vega and its related js libraries
> -
>
> Key: HBASE-27791
> URL: https://issues.apache.org/jira/browse/HBASE-27791
> Project: HBase
>  Issue Type: Task
>  Components: UI
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-4
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> HBase is using Vega, v5.19.1, which was released on 21 Jan, 2021 and is 
> vulnerable to cross-site scripting (XSS), CVE IDs:
>  * [CVE-2023-26486|https://nvd.nist.gov/vuln/detail/CVE-2023-26486]
>  * [CVE-2023-26487|https://nvd.nist.gov/vuln/detail/CVE-2023-26487]
> This Jira is to upgrade to latest releases:
>  * [https://github.com/vega/vega/releases/tag/v5.24.0]
>  * [https://github.com/vega/vega-lite/releases/tag/v5.6.1]
>  * [https://github.com/vega/vega-embed/releases/tag/v6.21.3]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27791) Upgrade vega and its related js libraries

2023-04-18 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-27791:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Thanks [~nihaljain.cs].

> Upgrade vega and its related js libraries
> -
>
> Key: HBASE-27791
> URL: https://issues.apache.org/jira/browse/HBASE-27791
> Project: HBase
>  Issue Type: Task
>  Components: UI
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.4
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> HBase is using Vega, v5.19.1, which was released on 21 Jan, 2021 and is 
> vulnerable to cross-site scripting (XSS), CVE IDs:
>  * [CVE-2023-26486|https://nvd.nist.gov/vuln/detail/CVE-2023-26486]
>  * [CVE-2023-26487|https://nvd.nist.gov/vuln/detail/CVE-2023-26487]
> This Jira is to upgrade to latest releases:
>  * [https://github.com/vega/vega/releases/tag/v5.24.0]
>  * [https://github.com/vega/vega-lite/releases/tag/v5.6.1]
>  * [https://github.com/vega/vega-embed/releases/tag/v6.21.3]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27791) Upgrade vega and its related js libraries

2023-04-18 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-27791:
-
Fix Version/s: 2.5.5

> Upgrade vega and its related js libraries
> -
>
> Key: HBASE-27791
> URL: https://issues.apache.org/jira/browse/HBASE-27791
> Project: HBase
>  Issue Type: Task
>  Components: UI
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.4
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> HBase is using Vega, v5.19.1, which was released on 21 Jan, 2021 and is 
> vulnerable to cross-site scripting (XSS), CVE IDs:
>  * [CVE-2023-26486|https://nvd.nist.gov/vuln/detail/CVE-2023-26486]
>  * [CVE-2023-26487|https://nvd.nist.gov/vuln/detail/CVE-2023-26487]
> This Jira is to upgrade to latest releases:
>  * [https://github.com/vega/vega/releases/tag/v5.24.0]
>  * [https://github.com/vega/vega-lite/releases/tag/v5.6.1]
>  * [https://github.com/vega/vega-embed/releases/tag/v6.21.3]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] ndimiduk merged pull request #5184: Backport "HBASE-27791 Upgrade vega and its related js libraries (#5173)" to branch-2.5

2023-04-18 Thread via GitHub


ndimiduk merged PR #5184:
URL: https://github.com/apache/hbase/pull/5184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27791) Upgrade vega and its related js libraries

2023-04-18 Thread Nick Dimiduk (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-27791:
-
Fix Version/s: 2.6.0

> Upgrade vega and its related js libraries
> -
>
> Key: HBASE-27791
> URL: https://issues.apache.org/jira/browse/HBASE-27791
> Project: HBase
>  Issue Type: Task
>  Components: UI
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.4
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> HBase is using Vega, v5.19.1, which was released on 21 Jan, 2021 and is 
> vulnerable to cross-site scripting (XSS), CVE IDs:
>  * [CVE-2023-26486|https://nvd.nist.gov/vuln/detail/CVE-2023-26486]
>  * [CVE-2023-26487|https://nvd.nist.gov/vuln/detail/CVE-2023-26487]
> This Jira is to upgrade to latest releases:
>  * [https://github.com/vega/vega/releases/tag/v5.24.0]
>  * [https://github.com/vega/vega-lite/releases/tag/v5.6.1]
>  * [https://github.com/vega/vega-embed/releases/tag/v6.21.3]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] ndimiduk merged pull request #5183: Backport "HBASE-27791 Upgrade vega and its related js libraries (#5173)" to branch-2

2023-04-18 Thread via GitHub


ndimiduk merged PR #5183:
URL: https://github.com/apache/hbase/pull/5183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27764) scan table is slow when enter hbase shell first time

2023-04-18 Thread chaijunjie (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaijunjie updated HBASE-27764:
---
Description: 
When we test HBase 2.4.14 on our cluster...

I find we  scan a table is slow when enter hbase shell first time.

step like this:

hbase shell

scan 'hbase:meta',\{LIMIT=>1}

the cost time is more than HBase 1.3

Any one can help compare the two versions(HBase 2.x vs HBase 1.x) in first scan 
process?

thanks~

 

---

I find the the “Future f = cs.poll(timeBeforeReplicas, 
TimeUnit.MICROSECONDS);” in 
org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas#call 

cost above 200+ms

 

  was:
When we test HBase 2.4.14 on our cluster...

I find we  scan a table is slow when enter hbase shell first time.

step like this:

hbase shell

scan 't1',\{LIMIT=>1}

the cost time is more than HBase 1.3

Any one can help compare the two versions(HBase 2.x vs HBase 1.x) in first scan 
process?

thanks~

 

---

I find the the “Future f = cs.poll(timeBeforeReplicas, 
TimeUnit.MICROSECONDS);” in 
org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas#call 

cost above 200+ms

 


> scan table is slow when enter hbase shell first time
> 
>
> Key: HBASE-27764
> URL: https://issues.apache.org/jira/browse/HBASE-27764
> Project: HBase
>  Issue Type: Bug
>  Components: Client, shell
>Affects Versions: 2.4.14
>Reporter: chaijunjie
>Priority: Major
>
> When we test HBase 2.4.14 on our cluster...
> I find we  scan a table is slow when enter hbase shell first time.
> step like this:
> hbase shell
> scan 'hbase:meta',\{LIMIT=>1}
> the cost time is more than HBase 1.3
> Any one can help compare the two versions(HBase 2.x vs HBase 1.x) in first 
> scan process?
> thanks~
>  
> ---
> I find the the “Future f = cs.poll(timeBeforeReplicas, 
> TimeUnit.MICROSECONDS);” in 
> org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas#call 
> cost above 200+ms
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27764) scan table is slow when enter hbase shell first time

2023-04-18 Thread chaijunjie (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaijunjie updated HBASE-27764:
---
Description: 
When we test HBase 2.4.14 on our cluster...

I find we  scan a table is slow when enter hbase shell first time.

step like this:

hbase shell

scan 't1',\{LIMIT=>1}

the cost time is more than HBase 1.3

Any one can help compare the two versions(HBase 2.x vs HBase 1.x) in first scan 
process?

thanks~

 

---

I find the the “Future f = cs.poll(timeBeforeReplicas, 
TimeUnit.MICROSECONDS);” in 
org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas#call 

cost above 200+ms

 

  was:
When we test HBase 2.4.14 on our cluster...

I find we  scan a table is slow when enter hbase shell first time.

step like this:

hbase shell

scan 't1',\{LIMIT=>1}

the cost time is more than HBase 1.3

Any one can help compare the two versions(HBase 2.x vs HBase 1.x) in first scan 
process?

thanks~


> scan table is slow when enter hbase shell first time
> 
>
> Key: HBASE-27764
> URL: https://issues.apache.org/jira/browse/HBASE-27764
> Project: HBase
>  Issue Type: Bug
>  Components: Client, shell
>Affects Versions: 2.4.14
>Reporter: chaijunjie
>Priority: Major
>
> When we test HBase 2.4.14 on our cluster...
> I find we  scan a table is slow when enter hbase shell first time.
> step like this:
> hbase shell
> scan 't1',\{LIMIT=>1}
> the cost time is more than HBase 1.3
> Any one can help compare the two versions(HBase 2.x vs HBase 1.x) in first 
> scan process?
> thanks~
>  
> ---
> I find the the “Future f = cs.poll(timeBeforeReplicas, 
> TimeUnit.MICROSECONDS);” in 
> org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas#call 
> cost above 200+ms
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC

2023-04-18 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713464#comment-17713464
 ] 

Nick Dimiduk commented on HBASE-27762:
--

This doesn't work. The MDC is always considered as {{nonEmpty}} ("non-null", I 
guess), even when it contains no elements.

> Include EventType and ProcedureV2 pid in logging via MDC
> 
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution 
> is painful. We are pretty good about logging the {{proc_id}} most of the 
> time, but we don't catch them all. Now that we're up on log4j2, let's use the 
> MDC feature to include some basic information universally.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC

2023-04-18 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713449#comment-17713449
 ] 

Nick Dimiduk commented on HBASE-27762:
--

Oh, hang on. Let me try this {{%notEmpty}} pattern.

> Include EventType and ProcedureV2 pid in logging via MDC
> 
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
>  Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution 
> is painful. We are pretty good about logging the {{proc_id}} most of the 
> time, but we don't catch them all. Now that we're up on log4j2, let's use the 
> MDC feature to include some basic information universally.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)