[jira] [Commented] (HBASE-27535) Separate slowlog thresholds for scans vs other requests

2023-04-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715369#comment-17715369
 ] 

Hudson commented on HBASE-27535:


Results for branch branch-2
[build #797 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/797/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/797/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/797/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/797/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/797/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Separate slowlog thresholds for scans vs other requests
> ---
>
> Key: HBASE-27535
> URL: https://issues.apache.org/jira/browse/HBASE-27535
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Ray Mattingly
>Priority: Major
>  Labels: slowlog
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Scans by their nature are able to more efficiently pull back larger response 
> sizes than gets. They also may take longer to execute than other request 
> types. We should make it possible to configure a separate threshold for 
> response time and response time for scans. This will allow us to tune down 
> the thresholds for others without adding unnecessary noise for requests which 
> are known to be slower/bigger.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (HBASE-27788) Skip family comparing when compare cells inner the store

2023-04-22 Thread Zheng Wang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712226#comment-17712226
 ] 

Zheng Wang edited comment on HBASE-27788 at 4/23/23 4:01 AM:
-

Test Env:
linux5.4, jdk8, jmh1.36, 8c16g

Test Cmd:
java -jar benchmarks.jar -i 5 -r 10 -wi 5 -w 10 -o result.out

Test Mode:
throughput, the more the better

 
|Benchmark|(p1)|(p2)|Mode|Cnt|Score|Error|Units|Diff|
|BenchmarkForInnerStore.new_compareBBKV| | |thrpt|5|28025769|± 
85837.894|ops/s|1.00%|
|BenchmarkForInnerStore.new_compareBBKV| |fam1|thrpt|5|45988795|± 
743418.588|ops/s|14.00%|
|BenchmarkForInnerStore.new_compareBBKV|fam1| |thrpt|5|46169746|± 
313848.117|ops/s|15.00%|
|BenchmarkForInnerStore.new_compareBBKV|fam1|fam1|thrpt|5|28340570|± 
110743.597|ops/s|19.00%|
|BenchmarkForInnerStore.new_compareKV| | |thrpt|5|28555080|± 
137117.752|ops/s|1.00%|
|BenchmarkForInnerStore.new_compareKV| |fam1|thrpt|5|48428310|± 
457635.029|ops/s|12.00%|
|BenchmarkForInnerStore.new_compareKV|fam1| |thrpt|5|48493949|± 
251767.842|ops/s|12.00%|
|BenchmarkForInnerStore.new_compareKV|fam1|fam1|thrpt|5|28550667|± 
115741.387|ops/s|27.00%|
|BenchmarkForInnerStore.new_compareKVVsBBKV| | |thrpt|5|29217290|± 
101649.947|ops/s|6.00%|
|BenchmarkForInnerStore.new_compareKVVsBBKV| |fam1|thrpt|5|46949029|± 
215794.996|ops/s|7.00%|
|BenchmarkForInnerStore.new_compareKVVsBBKV|fam1| |thrpt|5|46946670|± 
146710.467|ops/s|7.00%|
|BenchmarkForInnerStore.new_compareKVVsBBKV|fam1|fam1|thrpt|5|29148782|± 
206963.662|ops/s|20.00%|
|BenchmarkForInnerStore.old_compareBBKV| | |thrpt|5|27675873|± 
276983.891|ops/s| |
|BenchmarkForInnerStore.old_compareBBKV| |fam1|thrpt|5|40225985|± 
333777.174|ops/s| |
|BenchmarkForInnerStore.old_compareBBKV|fam1| |thrpt|5|40187512|± 
242635.903|ops/s| |
|BenchmarkForInnerStore.old_compareBBKV|fam1|fam1|thrpt|5|23719010|± 
78500.923|ops/s| |
|BenchmarkForInnerStore.old_compareKV| | |thrpt|5|28263508|± 80403.361|ops/s| |
|BenchmarkForInnerStore.old_compareKV| |fam1|thrpt|5|43253529|± 
227223.861|ops/s| |
|BenchmarkForInnerStore.old_compareKV|fam1| |thrpt|5|43251637|± 
370669.972|ops/s| |
|BenchmarkForInnerStore.old_compareKV|fam1|fam1|thrpt|5|22556530|± 
131922.278|ops/s| |
|BenchmarkForInnerStore.old_compareKVVsBBKV| | |thrpt|5|27607601|± 
181466.155|ops/s| |
|BenchmarkForInnerStore.old_compareKVVsBBKV| |fam1|thrpt|5|43838946|± 
147828.804|ops/s| |
|BenchmarkForInnerStore.old_compareKVVsBBKV|fam1| |thrpt|5|43853799|± 
159898.926|ops/s| |
|BenchmarkForInnerStore.old_compareKVVsBBKV|fam1|fam1|thrpt|5|24349838|± 
233577.807|ops/s| |
|BenchmarkForNormal.new_compareBBKV|fam|fam1|thrpt|5|35397671|± 
87148.764|ops/s|-3.00%|
|BenchmarkForNormal.new_compareBBKV|fam1|fam|thrpt|5|34853758|± 
181728.193|ops/s|-4.00%|
|BenchmarkForNormal.new_compareKV|fam|fam1|thrpt|5|36379792|± 
103787.745|ops/s|0.00%|
|BenchmarkForNormal.new_compareKV|fam1|fam|thrpt|5|36389642|± 
215220.231|ops/s|0.00%|
|BenchmarkForNormal.new_compareKVVsBBKV|fam|fam1|thrpt|5|39477917|± 
116925.262|ops/s|0.00%|
|BenchmarkForNormal.new_compareKVVsBBKV|fam1|fam|thrpt|5|39381461|± 
196771.635|ops/s|0.00%|
|BenchmarkForNormal.old_compareBBKV|fam|fam1|thrpt|5|36419133|± 
159715.504|ops/s| |
|BenchmarkForNormal.old_compareBBKV|fam1|fam|thrpt|5|36422202|± 
86247.635|ops/s| |
|BenchmarkForNormal.old_compareKV|fam|fam1|thrpt|5|36247387|± 95109.893|ops/s| |
|BenchmarkForNormal.old_compareKV|fam1|fam|thrpt|5|36260304|± 63266.840|ops/s| |
|BenchmarkForNormal.old_compareKVVsBBKV|fam|fam1|thrpt|5|39326233|± 
218927.739|ops/s| |
|BenchmarkForNormal.old_compareKVVsBBKV|fam1|fam|thrpt|5|39297932|± 
487026.618|ops/s| |


was (Author: filtertip):
Test Env:
linux5.4, jdk8, jmh1.36, 8c16g

Test Cmd:
java -jar benchmarks.jar -i 5 -r 10 -wi 5 -w 10 -o result.out

Test Mode:
throughput, the more the better

 
|Benchmark|(p1)|(p2)|Mode|Cnt|Score|Error|Units|Diff|
|BenchmarkForInnerStore.new_compareBBKV| | |thrpt|5|28025769|± 
85837.894|ops/s|1.00%|
|BenchmarkForInnerStore.new_compareBBKV| |fam1|thrpt|5|45988795|± 
743418.588|ops/s|14.00%|
|BenchmarkForInnerStore.new_compareBBKV|fam1| |thrpt|5|46169746|± 
313848.117|ops/s|15.00%|
|BenchmarkForInnerStore.new_compareBBKV|fam1|fam1|thrpt|5|28340570|± 
110743.597|ops/s|19.00%|
|BenchmarkForInnerStore.new_compareKV| | |thrpt|5|28555080|± 
137117.752|ops/s|1.00%|
|BenchmarkForInnerStore.new_compareKV| |fam1|thrpt|5|48428310|± 
457635.029|ops/s|12.00%|
|BenchmarkForInnerStore.new_compareKV|fam1| |thrpt|5|48493949|± 
251767.842|ops/s|12.00%|
|BenchmarkForInnerStore.new_compareKV|fam1|fam1|thrpt|5|28550667|± 
115741.387|ops/s|27.00%|
|BenchmarkForInnerStore.new_compareKVVsBBKV| | |thrpt|5|29217290|± 
101649.947|ops/s|6.00%|
|BenchmarkForInnerStore.new_compareKVVsBBKV| |fam1|thrpt|5|46949029|± 
215794.996|ops/s|7.00%|
|BenchmarkForInnerStore.new_compareKVVsBBKV|fam1| |thrpt|5|46946670|± 
146710.467|ops/s|7.00%|

[jira] [Resolved] (HBASE-20429) Support for mixed or write-heavy workloads on non-HDFS filesystems

2023-04-22 Thread Andrew Kyle Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-20429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-20429.
-
Resolution: Implemented

> Support for mixed or write-heavy workloads on non-HDFS filesystems
> --
>
> Key: HBASE-20429
> URL: https://issues.apache.org/jira/browse/HBASE-20429
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Andrew Kyle Purtell
>Priority: Major
>  Labels: s3
>
> We can support reasonably well use cases on non-HDFS filesystems, like S3, 
> where an external writer has loaded (and continues to load) HFiles via the 
> bulk load mechanism, and then we serve out a read only workload at the HBase 
> API.
> Mixed workloads or write-heavy workloads won't fare as well. In fact, data 
> loss seems certain. It will depend in the specific filesystem, but all of the 
> S3 backed Hadoop filesystems suffer from a couple of obvious problems, 
> notably a lack of atomic rename. 
> This umbrella will serve to collect some related ideas for consideration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27535) Separate slowlog thresholds for scans vs other requests

2023-04-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715315#comment-17715315
 ] 

Hudson commented on HBASE-27535:


Results for branch master
[build #823 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Separate slowlog thresholds for scans vs other requests
> ---
>
> Key: HBASE-27535
> URL: https://issues.apache.org/jira/browse/HBASE-27535
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Ray Mattingly
>Priority: Major
>  Labels: slowlog
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Scans by their nature are able to more efficiently pull back larger response 
> sizes than gets. They also may take longer to execute than other request 
> types. We should make it possible to configure a separate threshold for 
> response time and response time for scans. This will allow us to tune down 
> the thresholds for others without adding unnecessary noise for requests which 
> are known to be slower/bigger.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager

2023-04-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715314#comment-17715314
 ] 

Hudson commented on HBASE-27785:


Results for branch master
[build #823 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> --
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
>  Issue Type: Improvement
>  Components: Replication
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
>  {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to 
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and 
> {{ReplicationSourceWALReader}}, which makes the logic about 
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout 
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
>  and {{ReplicationSourceShipper}}. It causes duplicated code and would make 
> tracing the buffer usage somewhat difficult when there is problem about 
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in 
> {{ReplicationSourceManager}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5198: HBASE-27807 PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-22 Thread via GitHub


Apache-HBase commented on PR #5198:
URL: https://github.com/apache/hbase/pull/5198#issuecomment-1518709979

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  6s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 36s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 36s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 45s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 34s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 206m 58s |  hbase-server in the patch passed.  
|
   |  |   | 228m 25s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5198 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux fca5b851474c 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 
13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / ced4ff1804 |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/testReport/
 |
   | Max. process+thread count | 2656 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5198: HBASE-27807 PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-22 Thread via GitHub


Apache-HBase commented on PR #5198:
URL: https://github.com/apache/hbase/pull/5198#issuecomment-1518708969

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 24s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 38s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 39s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 15s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 42s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 36s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 200m 29s |  hbase-server in the patch failed.  |
   |  |   | 223m  1s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5198 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux e5d980d9f45b 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 
17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / ced4ff1804 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/testReport/
 |
   | Max. process+thread count | 2449 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5198: HBASE-27807 PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-22 Thread via GitHub


Apache-HBase commented on PR #5198:
URL: https://github.com/apache/hbase/pull/5198#issuecomment-1518667666

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 55s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 38s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 26s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 36s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 44s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 30s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 29s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 29s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m 43s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.4.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 38s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 12s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  38m 58s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.42 ServerAPI=1.42 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5198 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 65e50028e6cb 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 
17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / ced4ff1804 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 84 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5198: HBASE-27807 PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-22 Thread via GitHub


Apache-HBase commented on PR #5198:
URL: https://github.com/apache/hbase/pull/5198#issuecomment-1518638594

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m  0s |  Docker mode activated.  |
   | -1 :x: |  patch  |   0m  3s |  https://github.com/apache/hbase/pull/5198 
does not apply to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help.  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/5198 |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/1/console 
|
   | versions | git=2.25.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5198: HBASE-27807 PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-22 Thread via GitHub


Apache-HBase commented on PR #5198:
URL: https://github.com/apache/hbase/pull/5198#issuecomment-1518638565

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m  0s |  Docker mode activated.  |
   | -1 :x: |  patch  |   0m  2s |  https://github.com/apache/hbase/pull/5198 
does not apply to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help.  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/5198 |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/1/console 
|
   | versions | git=2.17.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5198: HBASE-27807 PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-22 Thread via GitHub


Apache-HBase commented on PR #5198:
URL: https://github.com/apache/hbase/pull/5198#issuecomment-1518638559

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m  0s |  Docker mode activated.  |
   | -1 :x: |  patch  |   0m  2s |  https://github.com/apache/hbase/pull/5198 
does not apply to master. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help.  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/5198 |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5198/1/console 
|
   | versions | git=2.17.1 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] haosenchen opened a new pull request, #5198: HBASE-27807 PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario

2023-04-22 Thread via GitHub


haosenchen opened a new pull request, #5198:
URL: https://github.com/apache/hbase/pull/5198

   HBASE-27807 PressureAwareCompactionThroughputController#tune log the 
opposite of the actual scenario
   Correct the condition of the if statement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table

2023-04-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715241#comment-17715241
 ] 

Hudson commented on HBASE-27109:


Results for branch HBASE-27109/table_based_rqs
[build #61 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/61/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/61/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/61/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/61/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move replication queue storage from zookeeper to a separated HBase table
> 
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in 
> HBASE-15867.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager

2023-04-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715235#comment-17715235
 ] 

Hudson commented on HBASE-27785:


Results for branch branch-2
[build #796 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> --
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
>  Issue Type: Improvement
>  Components: Replication
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
>  {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to 
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and 
> {{ReplicationSourceWALReader}}, which makes the logic about 
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout 
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
>  and {{ReplicationSourceShipper}}. It causes duplicated code and would make 
> tracing the buffer usage somewhat difficult when there is problem about 
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in 
> {{ReplicationSourceManager}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27783) Implement a shell command to disable all peer modification

2023-04-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715234#comment-17715234
 ] 

Hudson commented on HBASE-27783:


Results for branch branch-2
[build #796 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Implement a shell command to disable all peer modification
> --
>
> Key: HBASE-27783
> URL: https://issues.apache.org/jira/browse/HBASE-27783
> Project: HBase
>  Issue Type: Sub-task
>  Components: Replication, shell
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> This is used to switch peer storage implementation online.
> We can switch the peer storage like this:
> 1. Disable all peer modification.
> 2. Run the migration tool to migrate peer data from one storage to another.
> 3. Change all the hbase-site.xml files in the cluster.
> 4. Trigger online configuration change.
> 5. Enable peer modification.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)