[jira] [Commented] (HBASE-27811) Enable cache control for logs endpoint and set max age as 0
[ https://issues.apache.org/jira/browse/HBASE-27811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716980#comment-17716980 ] Yash Dodeja commented on HBASE-27811: - Made changes in addNoCacheFilter, added logic to read the config and pass it on. Also, added no cache filter to the logs app context. In NoCacheFilter, there is a check for hadoop.http.filter.no-store.enable and if it is true, max age is set as 0 for backward compatibility. > Enable cache control for logs endpoint and set max age as 0 > --- > > Key: HBASE-27811 > URL: https://issues.apache.org/jira/browse/HBASE-27811 > Project: HBase > Issue Type: Improvement >Reporter: Yash Dodeja >Assignee: Yash Dodeja >Priority: Minor > > Not setting the proper header values may cause browsers to store pages within > their respective caches. On public, shared, or any other non-private > computers, a malicious person may search through the browser cache to locate > sensitive information cached during another user's session. > /logs endpoint contains sensitive information that an attacker can exploit. > Any page with sensitive information needs to have the following headers in > response: > Cache-Control: no-cache, no-store, max-age=0 > Pragma: no-cache > Expires: -1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1524575075 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 54s | master passed | | +1 :green_heart: | compile | 3m 2s | master passed | | +1 :green_heart: | checkstyle | 0m 43s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 57s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | compile | 2m 59s | the patch passed | | -0 :warning: | javac | 2m 30s | hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195) | | +1 :green_heart: | checkstyle | 0m 43s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 38s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 9s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 43m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/14/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5171 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux a60293dc2ed5 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/14/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/14/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on a diff in pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
bsglz commented on code in PR #5171:
URL: https://github.com/apache/hbase/pull/5171#discussion_r1178543080
##
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java:
##
@@ -448,6 +451,33 @@ public final int compareFamilies(Cell left, Cell right) {
right.getFamilyArray(), right.getFamilyOffset(),
right.getFamilyLength());
}
+ /**
+ * This method will be overridden when we compare cells inner store to
bypass family comparing.
+ */
+ protected int compareFamilies(KeyValue left, KeyValue right, int
leftFamilyLength,
Review Comment:
> Can you use more similar signature to existing methods? I find this
ordering confusing, because everyone is used to doing left, leftOffset,
leftLength, right, rightOffset, rightLenght.
>
> This goes for all the new methods.
Make sense, will fix it later.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bsglz commented on a diff in pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
bsglz commented on code in PR #5171:
URL: https://github.com/apache/hbase/pull/5171#discussion_r1178540982
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##
@@ -277,14 +277,6 @@ public class HRegion implements HeapSize,
PropagatingConfigurationObserver, Regi
public static final String RECOVERED_EDITS_IGNORE_EOF =
"hbase.hregion.recovered.edits.ignore.eof";
- /**
- * Whether to use {@link MetaCellComparator} even if we are not meta region.
Used when creating
- * master local region.
- */
- public static final String USE_META_CELL_COMPARATOR =
"hbase.region.use.meta.cell.comparator";
Review Comment:
> Not a huge deal, but why move this constant in this PR? Doesn't seem
related?
Because the new InnerStoreCellComparator which placed in hbase-common module
reference it too, and the hbase-common should not depend on hbase-server.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524174027 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | checkstyle | 0m 16s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | checkstyle | 0m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 25s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 8s | The patch does not generate ASF License warnings. | | | | 32m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 40055c42fe07 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 85 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/10/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524151820 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 17s | master passed | | +1 :green_heart: | compile | 0m 16s | master passed | | +1 :green_heart: | shadedjars | 4m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | +1 :green_heart: | compile | 0m 16s | the patch passed | | +1 :green_heart: | javac | 0m 16s | the patch passed | | +1 :green_heart: | shadedjars | 4m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 19s | hbase-client in the patch passed. | | | | 19m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c506ef4cf0b2 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/10/testReport/ | | Max. process+thread count | 189 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/10/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524149914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 48s | master passed | | +1 :green_heart: | compile | 0m 19s | master passed | | +1 :green_heart: | shadedjars | 4m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 0m 18s | the patch passed | | +1 :green_heart: | javac | 0m 18s | the patch passed | | +1 :green_heart: | shadedjars | 4m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 2s | hbase-client in the patch passed. | | | | 18m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fd413780652d 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/10/testReport/ | | Max. process+thread count | 162 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/10/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524130669 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | master passed | | +1 :green_heart: | compile | 0m 38s | master passed | | +1 :green_heart: | checkstyle | 0m 16s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | checkstyle | 0m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 26s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 32m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 0618379358b4 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 85 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/9/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524122314 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | master passed | | +1 :green_heart: | compile | 0m 16s | master passed | | +1 :green_heart: | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 15s | the patch passed | | +1 :green_heart: | compile | 0m 16s | the patch passed | | +1 :green_heart: | javac | 0m 16s | the patch passed | | +1 :green_heart: | shadedjars | 4m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 22s | hbase-client in the patch passed. | | | | 19m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cd35a515bb78 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/9/testReport/ | | Max. process+thread count | 184 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/9/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524121621 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 45s | master passed | | +1 :green_heart: | compile | 0m 18s | master passed | | +1 :green_heart: | shadedjars | 4m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 0m 19s | the patch passed | | +1 :green_heart: | javac | 0m 19s | the patch passed | | +1 :green_heart: | shadedjars | 4m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 2s | hbase-client in the patch passed. | | | | 18m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b34ce333d42a 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/9/testReport/ | | Max. process+thread count | 160 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/9/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on a diff in pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
rmdmattingly commented on code in PR #5192:
URL: https://github.com/apache/hbase/pull/5192#discussion_r1178455997
##
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java:
##
@@ -130,29 +129,60 @@ public static void throwWriteCapacityUnitExceeded(final
long waitInterval)
private static void throwThrottlingException(final Type type, final long
waitInterval)
throws RpcThrottlingException {
-String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT +
StringUtils.formatTime(waitInterval);
+String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT +
stringFromMillis(waitInterval);
throw new RpcThrottlingException(type, waitInterval, msg);
}
- private static long timeFromString(String timeDiff) {
-Pattern[] patterns = new Pattern[] {
Pattern.compile("^(\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)mins, (\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)hrs, (\\d+)mins, (\\d+\\.\\d\\d)sec") };
+ // Visible for TestRpcThrottlingException
+ protected static String stringFromMillis(long millis) {
+StringBuilder buf = new StringBuilder();
+long hours = millis / (60 * 60 * 1000);
+long rem = (millis % (60 * 60 * 1000));
+long minutes = rem / (60 * 1000);
+rem = rem % (60 * 1000);
+long seconds = rem / 1000;
+long milliseconds = rem % 1000;
-for (int i = 0; i < patterns.length; ++i) {
- Matcher m = patterns[i].matcher(timeDiff);
- if (m.find()) {
-long time = Math.round(Float.parseFloat(m.group(1 + i)) * 1000);
-if (i > 0) {
- time += Long.parseLong(m.group(i)) * (60 * 1000);
-}
-if (i > 1) {
- time += Long.parseLong(m.group(i - 1)) * (60 * 60 * 1000);
+if (hours != 0) {
+ buf.append(hours);
+ buf.append("hrs, ");
+}
+if (minutes != 0) {
+ buf.append(minutes);
+ buf.append("mins, ");
+}
+if (seconds != 0) {
+ buf.append(seconds);
+ buf.append("sec, ");
+}
+buf.append(milliseconds);
+buf.append("ms");
+return buf.toString();
+ }
+
+ // Visible for TestRpcThrottlingException
+ protected static long timeFromString(String timeDiff) {
+Pattern pattern;
+if (timeDiff.contains("ms")) {
+ pattern = Pattern.compile("^(?:(\\d+)hrs, )?(?:(\\d+)mins,
)?(?:(\\d+)sec, )?(?:(\\d+)ms)?");
+} else {
+ // legacy pattern. see HBASE-27799 which added millis to this String
+ pattern = Pattern.compile("^(?:(\\d+)hrs, )?(?:(\\d+)mins,
)?(?:(\\d+)sec)?");
+}
Review Comment:
nevermind, this was bothering me so I learned a little bit and have written
a single pattern solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on a diff in pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
rmdmattingly commented on code in PR #5192:
URL: https://github.com/apache/hbase/pull/5192#discussion_r1178439786
##
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java:
##
@@ -130,29 +129,60 @@ public static void throwWriteCapacityUnitExceeded(final
long waitInterval)
private static void throwThrottlingException(final Type type, final long
waitInterval)
throws RpcThrottlingException {
-String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT +
StringUtils.formatTime(waitInterval);
+String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT +
stringFromMillis(waitInterval);
throw new RpcThrottlingException(type, waitInterval, msg);
}
- private static long timeFromString(String timeDiff) {
-Pattern[] patterns = new Pattern[] {
Pattern.compile("^(\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)mins, (\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)hrs, (\\d+)mins, (\\d+\\.\\d\\d)sec") };
+ // Visible for TestRpcThrottlingException
+ protected static String stringFromMillis(long millis) {
+StringBuilder buf = new StringBuilder();
+long hours = millis / (60 * 60 * 1000);
+long rem = (millis % (60 * 60 * 1000));
+long minutes = rem / (60 * 1000);
+rem = rem % (60 * 1000);
+long seconds = rem / 1000;
+long milliseconds = rem % 1000;
-for (int i = 0; i < patterns.length; ++i) {
- Matcher m = patterns[i].matcher(timeDiff);
- if (m.find()) {
-long time = Math.round(Float.parseFloat(m.group(1 + i)) * 1000);
-if (i > 0) {
- time += Long.parseLong(m.group(i)) * (60 * 1000);
-}
-if (i > 1) {
- time += Long.parseLong(m.group(i - 1)) * (60 * 60 * 1000);
+if (hours != 0) {
+ buf.append(hours);
+ buf.append("hrs, ");
+}
+if (minutes != 0) {
+ buf.append(minutes);
+ buf.append("mins, ");
+}
+if (seconds != 0) {
+ buf.append(seconds);
+ buf.append("sec, ");
+}
+buf.append(milliseconds);
+buf.append("ms");
+return buf.toString();
+ }
+
+ // Visible for TestRpcThrottlingException
+ protected static long timeFromString(String timeDiff) {
+Pattern pattern;
+if (timeDiff.contains("ms")) {
+ pattern = Pattern.compile("^(?:(\\d+)hrs, )?(?:(\\d+)mins,
)?(?:(\\d+)sec, )?(?:(\\d+)ms)?");
+} else {
+ // legacy pattern. see HBASE-27799 which added millis to this String
+ pattern = Pattern.compile("^(?:(\\d+)hrs, )?(?:(\\d+)mins,
)?(?:(\\d+)sec)?");
+}
Review Comment:
the `sec,` vs `sec` distinction across the two formats was confounding for
my pretty basic regex knowledge — if anyone has a better suggestion then please
feel free to let me know. That said, I don't think it's particularly bad to
differentiate between the two formats while still executing a single match
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524085476 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | master passed | | +1 :green_heart: | compile | 0m 41s | master passed | | +1 :green_heart: | checkstyle | 0m 15s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | checkstyle | 0m 16s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 29s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 32m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 272870f66f4e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 85 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/8/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524073379 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 32s | master passed | | +1 :green_heart: | compile | 0m 16s | master passed | | +1 :green_heart: | shadedjars | 4m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | compile | 0m 16s | the patch passed | | +1 :green_heart: | javac | 0m 16s | the patch passed | | +1 :green_heart: | shadedjars | 4m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 25s | hbase-client in the patch passed. | | | | 19m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2459a0e8e98e 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/8/testReport/ | | Max. process+thread count | 186 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/8/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524072244 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 46s | master passed | | +1 :green_heart: | compile | 0m 19s | master passed | | +1 :green_heart: | shadedjars | 4m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 0m 18s | the patch passed | | +1 :green_heart: | javac | 0m 18s | the patch passed | | +1 :green_heart: | shadedjars | 4m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 3s | hbase-client in the patch passed. | | | | 18m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 03f3cc6f8bf0 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/8/testReport/ | | Max. process+thread count | 167 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/8/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on a diff in pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
rmdmattingly commented on code in PR #5192:
URL: https://github.com/apache/hbase/pull/5192#discussion_r1178409247
##
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java:
##
@@ -130,29 +129,64 @@ public static void throwWriteCapacityUnitExceeded(final
long waitInterval)
private static void throwThrottlingException(final Type type, final long
waitInterval)
throws RpcThrottlingException {
-String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT +
StringUtils.formatTime(waitInterval);
+String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT +
stringFromMillis(waitInterval);
throw new RpcThrottlingException(type, waitInterval, msg);
}
- private static long timeFromString(String timeDiff) {
-Pattern[] patterns = new Pattern[] {
Pattern.compile("^(\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)mins, (\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)hrs, (\\d+)mins, (\\d+\\.\\d\\d)sec") };
+ // Visible for TestRpcThrottlingException
+ protected static String stringFromMillis(long millis) {
+StringBuilder buf = new StringBuilder();
+long hours = millis / (60 * 60 * 1000);
+long rem = (millis % (60 * 60 * 1000));
+long minutes = rem / (60 * 1000);
+rem = rem % (60 * 1000);
+long seconds = rem / 1000;
+long milliseconds = rem % 1000;
+if (hours != 0) {
+ buf.append(hours);
+ buf.append("hrs, ");
+}
+if (minutes != 0) {
+ buf.append(minutes);
+ buf.append("mins, ");
+}
+if (seconds != 0) {
+ buf.append(seconds);
+ buf.append("sec, ");
+}
+buf.append(milliseconds);
+buf.append("ms");
+return buf.toString();
+ }
+
+ // Visible for TestRpcThrottlingException
+ protected static long timeFromString(String timeDiff) {
+Pattern[] patterns = new Pattern[] { Pattern.compile("^(\\d+)ms"),
+ Pattern.compile("^(\\d+)sec, (\\d+)ms"), Pattern.compile("^(\\d+)mins,
(\\d+)sec, (\\d+)ms"),
Review Comment:
yeah, good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
bbeaudreault commented on code in PR #5192:
URL: https://github.com/apache/hbase/pull/5192#discussion_r1178405138
##
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java:
##
@@ -130,29 +129,64 @@ public static void throwWriteCapacityUnitExceeded(final
long waitInterval)
private static void throwThrottlingException(final Type type, final long
waitInterval)
throws RpcThrottlingException {
-String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT +
StringUtils.formatTime(waitInterval);
+String msg = MSG_TYPE[type.ordinal()] + MSG_WAIT +
stringFromMillis(waitInterval);
throw new RpcThrottlingException(type, waitInterval, msg);
}
- private static long timeFromString(String timeDiff) {
-Pattern[] patterns = new Pattern[] {
Pattern.compile("^(\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)mins, (\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)hrs, (\\d+)mins, (\\d+\\.\\d\\d)sec") };
+ // Visible for TestRpcThrottlingException
+ protected static String stringFromMillis(long millis) {
+StringBuilder buf = new StringBuilder();
+long hours = millis / (60 * 60 * 1000);
+long rem = (millis % (60 * 60 * 1000));
+long minutes = rem / (60 * 1000);
+rem = rem % (60 * 1000);
+long seconds = rem / 1000;
+long milliseconds = rem % 1000;
+if (hours != 0) {
+ buf.append(hours);
+ buf.append("hrs, ");
+}
+if (minutes != 0) {
+ buf.append(minutes);
+ buf.append("mins, ");
+}
+if (seconds != 0) {
+ buf.append(seconds);
+ buf.append("sec, ");
+}
+buf.append(milliseconds);
+buf.append("ms");
+return buf.toString();
+ }
+
+ // Visible for TestRpcThrottlingException
+ protected static long timeFromString(String timeDiff) {
+Pattern[] patterns = new Pattern[] { Pattern.compile("^(\\d+)ms"),
+ Pattern.compile("^(\\d+)sec, (\\d+)ms"), Pattern.compile("^(\\d+)mins,
(\\d+)sec, (\\d+)ms"),
Review Comment:
The last thing I'd say here is that the original approach here seems like
someone who doesn't know regex. It seems like we could make this use just one
pattern by just wrapping the individual components with `(?:)?`. I.e.
`(?:(\\d)sec, )?`
Thoughts? Probably would be faster than having to run up to 6 matches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1524010037 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | master passed | | +1 :green_heart: | compile | 0m 38s | master passed | | +1 :green_heart: | checkstyle | 0m 16s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 45s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | checkstyle | 0m 16s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 31s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 32m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 6a321208d226 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/7/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1523997489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | compile | 0m 16s | master passed | | +1 :green_heart: | shadedjars | 4m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 0m 16s | the patch passed | | +1 :green_heart: | javac | 0m 16s | the patch passed | | +1 :green_heart: | shadedjars | 4m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 20s | hbase-client in the patch passed. | | | | 19m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ac2d0235670a 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/7/testReport/ | | Max. process+thread count | 196 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/7/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1523995051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | master passed | | +1 :green_heart: | compile | 0m 19s | master passed | | +1 :green_heart: | shadedjars | 4m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 0m 18s | the patch passed | | +1 :green_heart: | javac | 0m 18s | the patch passed | | +1 :green_heart: | shadedjars | 4m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 2s | hbase-client in the patch passed. | | | | 18m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fdad90fc9167 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/7/testReport/ | | Max. process+thread count | 165 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/7/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1523938997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 27s | master passed | | +1 :green_heart: | compile | 0m 38s | master passed | | +1 :green_heart: | checkstyle | 0m 16s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | checkstyle | 0m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 23s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 32m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 03084bbd883a 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/6/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1523926030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 17s | master passed | | +1 :green_heart: | compile | 0m 17s | master passed | | +1 :green_heart: | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 0m 17s | the patch passed | | +1 :green_heart: | javac | 0m 17s | the patch passed | | +1 :green_heart: | shadedjars | 4m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 26s | hbase-client in the patch passed. | | | | 19m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d246c05cf24b 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/6/testReport/ | | Max. process+thread count | 185 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/6/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
Apache-HBase commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1523924547 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 4s | master passed | | +1 :green_heart: | compile | 0m 19s | master passed | | +1 :green_heart: | shadedjars | 4m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 50s | the patch passed | | +1 :green_heart: | compile | 0m 18s | the patch passed | | +1 :green_heart: | javac | 0m 18s | the patch passed | | +1 :green_heart: | shadedjars | 4m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 3s | hbase-client in the patch passed. | | | | 18m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5192 | | JIRA Issue | HBASE-27799 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ed1c02a6df3b 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/6/testReport/ | | Max. process+thread count | 160 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5192/6/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27803) Update ref guide about the changes of the replication storage related concepts
[
https://issues.apache.org/jira/browse/HBASE-27803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716872#comment-17716872
]
Hudson commented on HBASE-27803:
Results for branch master
[build #826 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/826/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/826/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/826/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/826/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update ref guide about the changes of the replication storage related concepts
> --
>
> Key: HBASE-27803
> URL: https://issues.apache.org/jira/browse/HBASE-27803
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> In the replication internal section, we still list zk as the only storage and
> do not mention that now we have a peer storage and a queue storage
> abstraction.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
bbeaudreault commented on code in PR #5192:
URL: https://github.com/apache/hbase/pull/5192#discussion_r1178286955
##
hbase-client/src/test/java/org/apache/hadoop/hbase/quotas/TestRpcThrottlingException.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.quotas;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.testclassification.SmallTests;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+@Category({ SmallTests.class })
+public class TestRpcThrottlingException {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestRpcThrottlingException.class);
+
+ @Test
+ public void itHandlesSecWaitIntervalMessage() {
Review Comment:
We should also test that it still works for the old format. We need to make
sure it doesn't break if someone deploys the updated client side with old
servers or vice versa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on a diff in pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
rmdmattingly commented on code in PR #5192:
URL: https://github.com/apache/hbase/pull/5192#discussion_r1178264992
##
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java:
##
@@ -159,20 +160,33 @@ private static String stringFromMillis(long millis) {
return buf.toString();
}
- private static long timeFromString(String timeDiff) {
-Pattern[] patterns = new Pattern[] {
Pattern.compile("^(\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)mins, (\\d+\\.\\d\\d)sec"),
- Pattern.compile("^(\\d+)hrs, (\\d+)mins, (\\d+\\.\\d\\d)sec") };
+ // Visible for TestRpcThrottlingException
+ protected static long timeFromString(String timeDiff) {
+Pattern[] patterns = new Pattern[] { Pattern.compile("^(\\d+)ms"),
+ Pattern.compile("^(\\d+)sec, (\\d+)ms"), Pattern.compile("^(\\d+)mins,
(\\d+)sec, (\\d+)ms"),
+ Pattern.compile("^(\\d+)hrs, (\\d+)mins, (\\d+)sec, (\\d+)ms"), };
for (int i = 0; i < patterns.length; ++i) {
Matcher m = patterns[i].matcher(timeDiff);
if (m.find()) {
-long time = Math.round(Float.parseFloat(m.group(1 + i)) * 1000);
-if (i > 0) {
- time += Long.parseLong(m.group(i)) * (60 * 1000);
+if (i == 0) {
+ return Math.round(Float.parseFloat(m.group(1))); // ms
}
-if (i > 1) {
- time += Long.parseLong(m.group(i - 1)) * (60 * 60 * 1000);
+long time = 0;
+if (i == 1) {
+ time += Math.round(Float.parseFloat(m.group(1)) * 1000); // sec
+ time += Math.round(Float.parseFloat(m.group(2))); // ms
+}
+if (i == 2) {
+ time += Math.round(Float.parseFloat(m.group(1)) * 60 * 1000); // mins
+ time += Math.round(Float.parseFloat(m.group(2)) * 1000); // sec
+ time += Math.round(Float.parseFloat(m.group(3))); // ms
+}
+if (i == 3) {
+ time += Math.round(Float.parseFloat(m.group(1)) * 60 * 60 * 1000);
// hrs
+ time += Math.round(Float.parseFloat(m.group(2)) * 60 * 1000); // mins
+ time += Math.round(Float.parseFloat(m.group(3)) * 1000); // sec
+ time += Math.round(Float.parseFloat(m.group(4))); // ms
}
Review Comment:
admittedly we could clean this up a bit via some sort of loop, but I think
the initial implementation suffered from trying to be a little too clever and
this both works and is straightforward imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] rmdmattingly commented on pull request #5192: HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s
rmdmattingly commented on PR #5192: URL: https://github.com/apache/hbase/pull/5192#issuecomment-1523884400 @bbeaudreault while working on https://issues.apache.org/jira/browse/HBASE-27798 I realized that there's an extra change that I want to make here. These changes would break https://github.com/apache/hbase/blob/e87b3ed72e32e8988366ee23007b98e500ce9706/hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java#L162-L183 Though notably, `timeFromString` doesn't actually work in its current form. I'm going to push a fixed iteration on the function that includes support for our ms specificity, and add a unit test for this conversion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5194: HBASE-27752: Update the block cache and list of prefetched files upon region movement
Apache-HBase commented on PR #5194: URL: https://github.com/apache/hbase/pull/5194#issuecomment-1523879199 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 53s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | master passed | | +1 :green_heart: | compile | 2m 23s | master passed | | +1 :green_heart: | checkstyle | 0m 35s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 27s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 20s | the patch passed | | +1 :green_heart: | compile | 2m 21s | the patch passed | | +1 :green_heart: | javac | 2m 21s | the patch passed | | +1 :green_heart: | checkstyle | 0m 32s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 16s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 38m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5194/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5194 | | JIRA Issue | HBASE-27752 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 4354e0a70e96 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 83 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5194/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27817) Migrate javax.el:3.0.1-b08 to jakarta.el-4.0.2
[ https://issues.apache.org/jira/browse/HBASE-27817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716855#comment-17716855 ] Geoffrey Jacoby commented on HBASE-27817: - This was also something we wanted to do in Phoenix recently, but decided to postpone so we stayed in sync with HBase's dependencies. So HBase upgrading would also allow Phoenix to upgrade as well. > Migrate javax.el:3.0.1-b08 to jakarta.el-4.0.2 > -- > > Key: HBASE-27817 > URL: https://issues.apache.org/jira/browse/HBASE-27817 > Project: HBase > Issue Type: Task >Affects Versions: 3.0.0-alpha-4, 2.5.5, 2.4.18 >Reporter: Wes Schuitema >Priority: Trivial > > The javax.el artifact contains a CVE: [CVE-2021-28170. > |https://nvd.nist.gov/vuln/detail/CVE-2021-28170]The CVE itself is not a big > issue since we're pre-compiling our JSP pages when building HBase, no user > input is parsed which reduces the risk considerably. > The org.glassfish:javax.el artifact was moved to org.glassfish:jakarta.el, > which means a migration to get rid of the CVE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5203: HBASE-27516 Document the table based replication queue storage in ref guide
Apache-HBase commented on PR #5203: URL: https://github.com/apache/hbase/pull/5203#issuecomment-1523642094 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 12m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5203/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5203 | | Optional Tests | | | uname | Linux e2eb5704e152 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / b5535c98a3 | | Max. process+thread count | 29 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5203/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #5203: HBASE-27516 Document the table based replication queue storage in ref guide
Apache9 commented on code in PR #5203: URL: https://github.com/apache/hbase/pull/5203#discussion_r1178051368 ## src/main/asciidoc/_chapters/ops_mgt.adoc: ## @@ -2521,93 +2517,38 @@ NOTE: WALs are saved when replication is enabled or disabled as long as peers ex [[rs.failover.details]] Region Server Failover -When no region servers are failing, keeping track of the logs in ZooKeeper adds no value. -Unfortunately, region servers do fail, and since ZooKeeper is highly available, it is useful for managing the transfer of the queues in the event of a failure. +When no region servers are failing, keeping track of the logs in hbase:replication table adds no value. +However, in case of region server failure, we will manage the transfer of the queues based on hbase:replication. -Each of the master cluster region servers keeps a watcher on every other region server, in order to be notified when one dies (just as the master does). When a failure happens, they all race to create a znode called `lock` inside the dead region server's znode that contains its queues. -The region server that creates it successfully then transfers all the queues to its own znode, one at a time since ZooKeeper does not support renaming queues. -After queues are all transferred, they are deleted from the old location. -The znodes that were recovered are renamed with the ID of the slave cluster appended with the name of the dead server. +When a region server fails, the HMaster of master cluster will trigger the SCP, and all replication queues on the failed region server will be claimed in the SCP. Review Comment: OK, I think the current ref guide also need to be updated... I'm not sure which is the accruate version, but starting from a minor release for 2.x, we do not watch on the region server's znode any more, we use SCP to schedule claim queue operations... ## src/main/asciidoc/_chapters/ops_mgt.adoc: ## @@ -2521,93 +2517,38 @@ NOTE: WALs are saved when replication is enabled or disabled as long as peers ex [[rs.failover.details]] Region Server Failover -When no region servers are failing, keeping track of the logs in ZooKeeper adds no value. -Unfortunately, region servers do fail, and since ZooKeeper is highly available, it is useful for managing the transfer of the queues in the event of a failure. +When no region servers are failing, keeping track of the logs in hbase:replication table adds no value. +However, in case of region server failure, we will manage the transfer of the queues based on hbase:replication. -Each of the master cluster region servers keeps a watcher on every other region server, in order to be notified when one dies (just as the master does). When a failure happens, they all race to create a znode called `lock` inside the dead region server's znode that contains its queues. -The region server that creates it successfully then transfers all the queues to its own znode, one at a time since ZooKeeper does not support renaming queues. -After queues are all transferred, they are deleted from the old location. -The znodes that were recovered are renamed with the ID of the slave cluster appended with the name of the dead server. +When a region server fails, the HMaster of master cluster will trigger the SCP, and all replication queues on the failed region server will be claimed in the SCP. +The claim queue operation is just to remove the row of a replication queue, and insert a new row, where we change the server name to the region server which claims the queue. Review Comment: We need to mention that we use multi row mutate endpoint here, so the data for a single peer must be in the same region. ## src/main/asciidoc/_chapters/ops_mgt.adoc: ## @@ -2475,14 +2471,14 @@ When nodes are removed from the slave cluster, or if nodes go down or come back Keeping Track of Logs -Each master cluster region server has its own znode in the replication znodes hierarchy. -It contains one znode per peer cluster (if 5 slave clusters, 5 znodes are created), and each of these contain a queue of WALs to process. +Each master cluster region server has its queue state in the hbase:replication table. +It contains one row per peer cluster (if 5 slave clusters, 5 rows are created), and each of these contain a queue of WALs to process. Review Comment: Here things are a bit different. For zookeeper, it is like a tree, we have a znode for a peer cluster, but under the znode we have lots of files. But for table based implementation, we have server name in row key, which means we will have lots of rows for a given peer... ## src/main/asciidoc/_chapters/ops_mgt.adoc: ## @@ -2433,26 +2433,22 @@ Replication State Storage:: `ReplicationPeerStorage` and `ReplicationQueueStorage`. The former one is for storing the replication peer related states, and the latter one is for storing the
[GitHub] [hbase] Apache-HBase commented on pull request #5203: HBASE-27516 Document the table based replication queue storage in ref guide
Apache-HBase commented on PR #5203: URL: https://github.com/apache/hbase/pull/5203#issuecomment-1523626663 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +1 :green_heart: | spotless | 0m 50s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 35s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 3m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5203/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5203 | | Optional Tests | dupname asflicense spotless | | uname | Linux fcd1cb661364 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / b5535c98a3 | | Max. process+thread count | 44 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5203/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5203: HBASE-27516 Document the table based replication queue storage in ref guide
Apache-HBase commented on PR #5203: URL: https://github.com/apache/hbase/pull/5203#issuecomment-1523623420 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5203/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5203 | | Optional Tests | | | uname | Linux 3d0519aed80e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / b5535c98a3 | | Max. process+thread count | 37 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5203/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] 2005hithlj opened a new pull request, #5203: HBASE-27516 Document the table based replication queue storage in ref guide
2005hithlj opened a new pull request, #5203: URL: https://github.com/apache/hbase/pull/5203 https://issues.apache.org/jira/browse/HBASE-27516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27817) Migrate javax.el:3.0.1-b08 to jakarta.el-4.0.2
[ https://issues.apache.org/jira/browse/HBASE-27817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716727#comment-17716727 ] Duo Zhang commented on HBASE-27817: --- We shade glassfish in hbase-thirdparty, so this requires modifying hbase-thirdparty? > Migrate javax.el:3.0.1-b08 to jakarta.el-4.0.2 > -- > > Key: HBASE-27817 > URL: https://issues.apache.org/jira/browse/HBASE-27817 > Project: HBase > Issue Type: Task >Affects Versions: 3.0.0-alpha-4, 2.5.5, 2.4.18 >Reporter: Wes Schuitema >Priority: Trivial > > The javax.el artifact contains a CVE: [CVE-2021-28170. > |https://nvd.nist.gov/vuln/detail/CVE-2021-28170]The CVE itself is not a big > issue since we're pre-compiling our JSP pages when building HBase, no user > input is parsed which reduces the risk considerably. > The org.glassfish:javax.el artifact was moved to org.glassfish:jakarta.el, > which means a migration to get rid of the CVE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27817) Migrate javax.el:3.0.1-b08 to jakarta.el-4.0.2
Wes Schuitema created HBASE-27817: - Summary: Migrate javax.el:3.0.1-b08 to jakarta.el-4.0.2 Key: HBASE-27817 URL: https://issues.apache.org/jira/browse/HBASE-27817 Project: HBase Issue Type: Task Affects Versions: 3.0.0-alpha-4, 2.5.5, 2.4.18 Reporter: Wes Schuitema The javax.el artifact contains a CVE: [CVE-2021-28170. |https://nvd.nist.gov/vuln/detail/CVE-2021-28170]The CVE itself is not a big issue since we're pre-compiling our JSP pages when building HBase, no user input is parsed which reduces the risk considerably. The org.glassfish:javax.el artifact was moved to org.glassfish:jakarta.el, which means a migration to get rid of the CVE. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5202: HBASE-27109 Move replication queue storage from zookeeper to a separated HBase table
Apache-HBase commented on PR #5202: URL: https://github.com/apache/hbase/pull/5202#issuecomment-1523263776 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 40s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | compile | 2m 4s | master passed | | +1 :green_heart: | shadedjars | 5m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 4s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 2m 14s | the patch passed | | +1 :green_heart: | javac | 2m 14s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 48s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 453m 54s | root in the patch failed. | | | | 491m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5202/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5202 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 27a5cd8ecf46 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5202/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5202/2/testReport/ | | Max. process+thread count | 2326 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5202/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27816) Support option to auto bind to an available port for REST Info Server
[ https://issues.apache.org/jira/browse/HBASE-27816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27816: --- Component/s: REST > Support option to auto bind to an available port for REST Info Server > - > > Key: HBASE-27816 > URL: https://issues.apache.org/jira/browse/HBASE-27816 > Project: HBase > Issue Type: Sub-task > Components: REST >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27813) REST Info Server improvements
[ https://issues.apache.org/jira/browse/HBASE-27813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27813: --- Component/s: REST > REST Info Server improvements > - > > Key: HBASE-27813 > URL: https://issues.apache.org/jira/browse/HBASE-27813 > Project: HBase > Issue Type: Umbrella > Components: REST >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27815) Add support for process metrics servlet in REST InfoServer
[ https://issues.apache.org/jira/browse/HBASE-27815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27815: --- Component/s: REST > Add support for process metrics servlet in REST InfoServer > -- > > Key: HBASE-27815 > URL: https://issues.apache.org/jira/browse/HBASE-27815 > Project: HBase > Issue Type: Sub-task > Components: REST >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > > Unlike other HBase Master/RS Info Servers, REST Server UI does not provide a > way to get process metrics like threads, gc collectors etc. This task is add > same in HBase REST. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27814) Add support for dump servlet in REST InfoServer
[ https://issues.apache.org/jira/browse/HBASE-27814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27814: --- Component/s: REST > Add support for dump servlet in REST InfoServer > --- > > Key: HBASE-27814 > URL: https://issues.apache.org/jira/browse/HBASE-27814 > Project: HBase > Issue Type: Sub-task > Components: REST >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > > Unlike other HBase Master/RS Info Servers, HBase REST Server does not provide > a way to get debug dump for quick access to stacks, logs etc. This task is > add same in HBase REST. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27816) Support option to auto bind to an available port for REST Info Server
[ https://issues.apache.org/jira/browse/HBASE-27816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27816: --- Priority: Minor (was: Major) > Support option to auto bind to an available port for REST Info Server > - > > Key: HBASE-27816 > URL: https://issues.apache.org/jira/browse/HBASE-27816 > Project: HBase > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27815) Add support for process metrics servlet in REST InfoServer
[ https://issues.apache.org/jira/browse/HBASE-27815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27815: --- Description: Unlike other HBase Master/RS Info Servers, REST Server UI does not provide a way to get process metrics like threads, gc collectors etc. This task is add same in HBase REST. > Add support for process metrics servlet in REST InfoServer > -- > > Key: HBASE-27815 > URL: https://issues.apache.org/jira/browse/HBASE-27815 > Project: HBase > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > > Unlike other HBase Master/RS Info Servers, REST Server UI does not provide a > way to get process metrics like threads, gc collectors etc. This task is add > same in HBase REST. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27815) Add support for process metrics servlet in REST InfoServer
[ https://issues.apache.org/jira/browse/HBASE-27815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27815: --- Priority: Minor (was: Major) > Add support for process metrics servlet in REST InfoServer > -- > > Key: HBASE-27815 > URL: https://issues.apache.org/jira/browse/HBASE-27815 > Project: HBase > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27814) Add support for dump servlet in REST InfoServer
[ https://issues.apache.org/jira/browse/HBASE-27814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27814: --- Description: Unlike other HBase Master/RS Info Servers, HBase REST Server does not provide a way to get debug dump for quick access to stacks, logs etc. This task is add same in HBase REST. > Add support for dump servlet in REST InfoServer > --- > > Key: HBASE-27814 > URL: https://issues.apache.org/jira/browse/HBASE-27814 > Project: HBase > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > > Unlike other HBase Master/RS Info Servers, HBase REST Server does not provide > a way to get debug dump for quick access to stacks, logs etc. This task is > add same in HBase REST. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27814) Add support for dump servlet in REST InfoServer
[ https://issues.apache.org/jira/browse/HBASE-27814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27814: --- Priority: Minor (was: Major) > Add support for dump servlet in REST InfoServer > --- > > Key: HBASE-27814 > URL: https://issues.apache.org/jira/browse/HBASE-27814 > Project: HBase > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-20714) Document REST curl commands for supported (but missing in docs) operations
[ https://issues.apache.org/jira/browse/HBASE-20714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716651#comment-17716651 ] Nihal Jain commented on HBASE-20714: I see docs for append and increment for REST is still missing. > Document REST curl commands for supported (but missing in docs) operations > -- > > Key: HBASE-20714 > URL: https://issues.apache.org/jira/browse/HBASE-20714 > Project: HBase > Issue Type: Sub-task > Components: REST >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > While going through some recent REST JIRAs, I found REST supports row > operations like delete, append, increment etc. > I think we should document all such missing ops. > Others can give some input regarding other missing ops apart from the > above-mentioned ones. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-20714) Document REST curl commands for supported (but missing in docs) operations
[ https://issues.apache.org/jira/browse/HBASE-20714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-20714: --- Parent: HBASE-27813 Issue Type: Sub-task (was: Task) > Document REST curl commands for supported (but missing in docs) operations > -- > > Key: HBASE-20714 > URL: https://issues.apache.org/jira/browse/HBASE-20714 > Project: HBase > Issue Type: Sub-task > Components: REST >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > While going through some recent REST JIRAs, I found REST supports row > operations like delete, append, increment etc. > I think we should document all such missing ops. > Others can give some input regarding other missing ops apart from the > above-mentioned ones. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-20714) Document REST curl commands for supported (but missing in docs) operations
[ https://issues.apache.org/jira/browse/HBASE-20714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain reassigned HBASE-20714: -- Assignee: Nihal Jain > Document REST curl commands for supported (but missing in docs) operations > -- > > Key: HBASE-20714 > URL: https://issues.apache.org/jira/browse/HBASE-20714 > Project: HBase > Issue Type: Task > Components: REST >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > While going through some recent REST JIRAs, I found REST supports row > operations like delete, append, increment etc. > I think we should document all such missing ops. > Others can give some input regarding other missing ops apart from the > above-mentioned ones. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27815) Add support for process metrics servlet in REST InfoServer
Nihal Jain created HBASE-27815: -- Summary: Add support for process metrics servlet in REST InfoServer Key: HBASE-27815 URL: https://issues.apache.org/jira/browse/HBASE-27815 Project: HBase Issue Type: Sub-task Reporter: Nihal Jain Assignee: Nihal Jain -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27816) Support option to auto bind to an available port for REST Info Server
Nihal Jain created HBASE-27816: -- Summary: Support option to auto bind to an available port for REST Info Server Key: HBASE-27816 URL: https://issues.apache.org/jira/browse/HBASE-27816 Project: HBase Issue Type: Sub-task Reporter: Nihal Jain Assignee: Nihal Jain -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27814) Add support for dump servlet in REST InfoServer
Nihal Jain created HBASE-27814: -- Summary: Add support for dump servlet in REST InfoServer Key: HBASE-27814 URL: https://issues.apache.org/jira/browse/HBASE-27814 Project: HBase Issue Type: Sub-task Reporter: Nihal Jain Assignee: Nihal Jain -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27813) REST Info Server improvements
Nihal Jain created HBASE-27813: -- Summary: REST Info Server improvements Key: HBASE-27813 URL: https://issues.apache.org/jira/browse/HBASE-27813 Project: HBase Issue Type: Umbrella Reporter: Nihal Jain Assignee: Nihal Jain -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27812) Provide option in HBase UI to disable stack trace for security
[
https://issues.apache.org/jira/browse/HBASE-27812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716632#comment-17716632
]
Wellington Chevreuil commented on HBASE-27812:
--
{quote}Applications should always fail safe in their designs. If an application
fails to an unknown state, it is likely that an attacker may be able to exploit
this indeterminate state to access unauthorized functionality, or worse,
create, modify or destroy data. Error messages may also aid in the
identification of other attacks such as buffer overflows and SQL injection, and
can generally contribute to an overall weaker security posture.
{quote}
HBase UI doesn't provide any functionality for altering data. There's no
authorization feature either, so I believe none of the above is applicable.
That said, it can be daunting to argue against infosec groups running templated
security vulnerability reports in many organizations, so I guess we should
still have some way of address this, I just don't see it as a major priority.
> Provide option in HBase UI to disable stack trace for security
> --
>
> Key: HBASE-27812
> URL: https://issues.apache.org/jira/browse/HBASE-27812
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Yash Dodeja
>Assignee: Yash Dodeja
>Priority: Minor
>
> Uncaught server exceptions occur when providing parameter values that the
> server or servlet does not understand.
> Physical paths, versioning information, stack traces' content, and other data
> can be gathered and used to help further an attack when improper error
> handling is present.
> Applications should always fail safe in their designs. If an application
> fails to an unknown state, it is likely that an attacker may be able to
> exploit this indeterminate state to access unauthorized functionality, or
> worse, create, modify or destroy data. Error messages may also aid in the
> identification of other attacks such as buffer overflows and SQL injection,
> and can generally contribute to an overall weaker security posture.
> For example, if we use a HTTPS web server and explicitly provide Host header
> with a wrong value, say attackers.com, we get the following response in UI:
> {code:java}
>
>
>
> Error 400 Host does not match SNI
>
> HTTP ERROR 400 Host does not match SNI
>
> URI:/tablesDetailed.jsp
> STATUS:400
> MESSAGE:Host does not match SNI
> SERVLET:-
> CAUSED
> BY:org.apache.hbase.thirdparty.org.eclipse.jetty.http.BadMessageException:
> 400: Host does not match SNI
>
> Caused
> by:org.apache.hbase.thirdparty.org.eclipse.jetty.http.BadMessageException:
> 400: Host does not match SNI
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.SecureRequestCustomizer.customize(SecureRequestCustomizer.java:279)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.SecureRequestCustomizer.customize(SecureRequestCustomizer.java:210)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:483)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.run(HttpChannel.java:439)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
>at java.lang.Thread.run(Thread.java:750)
>
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5202: HBASE-27109 Move replication queue storage from zookeeper to a separated HBase table
Apache-HBase commented on PR #5202: URL: https://github.com/apache/hbase/pull/5202#issuecomment-1523091897 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 41s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 23s | master passed | | +1 :green_heart: | compile | 2m 21s | master passed | | +1 :green_heart: | shadedjars | 5m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 55s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 45s | the patch passed | | +1 :green_heart: | compile | 2m 12s | the patch passed | | +1 :green_heart: | javac | 2m 12s | the patch passed | | +1 :green_heart: | shadedjars | 5m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 53s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 326m 10s | root in the patch failed. | | | | 368m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5202/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5202 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a0c81cdf21f5 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3593288d60 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5202/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5202/2/testReport/ | | Max. process+thread count | 2705 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5202/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27812) Provide option in HBase UI to disable stack trace for security
[
https://issues.apache.org/jira/browse/HBASE-27812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-27812:
-
Priority: Minor (was: Major)
> Provide option in HBase UI to disable stack trace for security
> --
>
> Key: HBASE-27812
> URL: https://issues.apache.org/jira/browse/HBASE-27812
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: Yash Dodeja
>Assignee: Yash Dodeja
>Priority: Minor
>
> Uncaught server exceptions occur when providing parameter values that the
> server or servlet does not understand.
> Physical paths, versioning information, stack traces' content, and other data
> can be gathered and used to help further an attack when improper error
> handling is present.
> Applications should always fail safe in their designs. If an application
> fails to an unknown state, it is likely that an attacker may be able to
> exploit this indeterminate state to access unauthorized functionality, or
> worse, create, modify or destroy data. Error messages may also aid in the
> identification of other attacks such as buffer overflows and SQL injection,
> and can generally contribute to an overall weaker security posture.
> For example, if we use a HTTPS web server and explicitly provide Host header
> with a wrong value, say attackers.com, we get the following response in UI:
> {code:java}
>
>
>
> Error 400 Host does not match SNI
>
> HTTP ERROR 400 Host does not match SNI
>
> URI:/tablesDetailed.jsp
> STATUS:400
> MESSAGE:Host does not match SNI
> SERVLET:-
> CAUSED
> BY:org.apache.hbase.thirdparty.org.eclipse.jetty.http.BadMessageException:
> 400: Host does not match SNI
>
> Caused
> by:org.apache.hbase.thirdparty.org.eclipse.jetty.http.BadMessageException:
> 400: Host does not match SNI
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.SecureRequestCustomizer.customize(SecureRequestCustomizer.java:279)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.SecureRequestCustomizer.customize(SecureRequestCustomizer.java:210)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:483)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.run(HttpChannel.java:439)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
>at
> org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
>at java.lang.Thread.run(Thread.java:750)
>
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27811) Enable cache control for logs endpoint and set max age as 0
[ https://issues.apache.org/jira/browse/HBASE-27811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27811: - Priority: Minor (was: Major) > Enable cache control for logs endpoint and set max age as 0 > --- > > Key: HBASE-27811 > URL: https://issues.apache.org/jira/browse/HBASE-27811 > Project: HBase > Issue Type: Improvement >Reporter: Yash Dodeja >Assignee: Yash Dodeja >Priority: Minor > > Not setting the proper header values may cause browsers to store pages within > their respective caches. On public, shared, or any other non-private > computers, a malicious person may search through the browser cache to locate > sensitive information cached during another user's session. > /logs endpoint contains sensitive information that an attacker can exploit. > Any page with sensitive information needs to have the following headers in > response: > Cache-Control: no-cache, no-store, max-age=0 > Pragma: no-cache > Expires: -1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716606#comment-17716606
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #65 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/65/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/65/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/65/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/65/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
