[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1528938887 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 18s | master passed | | +1 :green_heart: | compile | 1m 2s | master passed | | +1 :green_heart: | shadedjars | 4m 25s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 32s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 4m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 5s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 213m 2s | hbase-server in the patch passed. | | | | 240m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5171 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 44f303de323d 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1f605cc642 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/testReport/ | | Max. process+thread count | 2810 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1528938229 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 48s | master passed | | +1 :green_heart: | compile | 0m 49s | master passed | | +1 :green_heart: | shadedjars | 4m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 41s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 209m 5s | hbase-server in the patch passed. | | | | 233m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5171 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3e5670b9f66c 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1f605cc642 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/testReport/ | | Max. process+thread count | 2749 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1528915569 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 22s | master passed | | +1 :green_heart: | compile | 3m 9s | master passed | | +1 :green_heart: | checkstyle | 0m 49s | master passed | | -1 :x: | spotless | 0m 44s | branch has 1 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 2m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 3m 12s | the patch passed | | +1 :green_heart: | javac | 3m 12s | the patch passed | | +1 :green_heart: | checkstyle | 0m 49s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 35s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 44s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 47m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5171 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux c69f74fc1d8d 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1f605cc642 | | Default Java | Eclipse Adoptium-11.0.17+8 | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/artifact/yetus-general-check/output/branch-spotless.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/16/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-26797) HBase 1.x clients will choke on rep_barrier rows when scanning hbase 2.x meta
[
https://issues.apache.org/jira/browse/HBASE-26797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717999#comment-17717999
]
Viraj Jasani edited comment on HBASE-26797 at 4/30/23 1:10 AM:
---
[~bbeaudreault] we also came across this issue, thank you again for this fix!!
:)
Do you recall any other similar fixes done in branch-1 specifically for the
similar 1.x client <-> 2.x server compatibility?
Mostly our 2.x codebase is quite up-to-date with latest branch-2.4 however due
to EOL, we might have missed some imp patches from branch-1, and this Jira is
definitely imp one.
was (Author: vjasani):
[~bbeaudreault] we also came across this issue, thank you again for this fix!!
:)
Do you recall any other similar fixes done in branch-1 specifically for the
similar 1.x client <-> 2.x server compatibility?
> HBase 1.x clients will choke on rep_barrier rows when scanning hbase 2.x meta
> -
>
> Key: HBASE-26797
> URL: https://issues.apache.org/jira/browse/HBASE-26797
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.7.1
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Labels: patch-available
> Fix For: 1.7.2
>
>
> In hbase 2.x, support for serial replication included adding a new CF to meta
> called rep_barrier. When regions are split or merged, these rep_barrier rows
> will not be cleaned up. Instead there's a ReplicationBarrierCleaner chore
> which runs every 12 hours. HBase 2.x clients will ignore these rep_barrier
> rows, per the [addFamily call in
> locateRegionInMeta|[https://github.com/apache/hbase/blob/branch-2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L929].]
> Encountering these orphan rep_barrier rows causes the hbase 1.x client to
> fail when it [tries to extract the region location from the meta
> row|[https://github.com/apache/hbase/blob/branch-1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java#L1340-L1344].]
> This is a non-recoverable exception, so retries will fail and it will
> eventually bubble up.
> The immediate fix when encountering this is to run {{{}hbck2 fixMeta{}}}, but
> we should fix the hbase 1.x client to similarly filter on the CATALOG_FAMILY
> to avoid these issues altogether.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-26797) HBase 1.x clients will choke on rep_barrier rows when scanning hbase 2.x meta
[
https://issues.apache.org/jira/browse/HBASE-26797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717999#comment-17717999
]
Viraj Jasani commented on HBASE-26797:
--
[~bbeaudreault] we also came across this issue, thank you again for this fix!!
:)
Do you recall any other similar fixes done in branch-1 specifically for the
similar 1.x client <-> 2.x server compatibility?
> HBase 1.x clients will choke on rep_barrier rows when scanning hbase 2.x meta
> -
>
> Key: HBASE-26797
> URL: https://issues.apache.org/jira/browse/HBASE-26797
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.7.1
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Labels: patch-available
> Fix For: 1.7.2
>
>
> In hbase 2.x, support for serial replication included adding a new CF to meta
> called rep_barrier. When regions are split or merged, these rep_barrier rows
> will not be cleaned up. Instead there's a ReplicationBarrierCleaner chore
> which runs every 12 hours. HBase 2.x clients will ignore these rep_barrier
> rows, per the [addFamily call in
> locateRegionInMeta|[https://github.com/apache/hbase/blob/branch-2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L929].]
> Encountering these orphan rep_barrier rows causes the hbase 1.x client to
> fail when it [tries to extract the region location from the meta
> row|[https://github.com/apache/hbase/blob/branch-1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java#L1340-L1344].]
> This is a non-recoverable exception, so retries will fail and it will
> eventually bubble up.
> The immediate fix when encountering this is to run {{{}hbck2 fixMeta{}}}, but
> we should fix the hbase 1.x client to similarly filter on the CATALOG_FAMILY
> to avoid these issues altogether.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27792) Guard Master/RS Dump Servlet behind admin walls
[
https://issues.apache.org/jira/browse/HBASE-27792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717976#comment-17717976
]
Hudson commented on HBASE-27792:
Results for branch branch-2.5
[build #344 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Guard Master/RS Dump Servlet behind admin walls
> ---
>
> Key: HBASE-27792
> URL: https://issues.apache.org/jira/browse/HBASE-27792
> Project: HBase
> Issue Type: Improvement
> Components: security, UI
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Currently RSDumpServlet and MasterDumpServlet do not require any check for
> whether the user has privileges to access to instrumentation servlets.
> This is unlike other servlets like ProfileServlet, ConfServlet,
> JMXJsonServlet etc. which are guarded by admin checks.
> Goal of this JIRA is to add similar check for RS and Master Dump Servlet.
> Post this change only admins will be able to access RSDumpServlet and
> MasterDumpServlet, if _hadoop.security.instrumentation.requires.admin_ is
> enabled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27810) HBCK throws RejectedExecutionException when closing ZooKeeper resources
[
https://issues.apache.org/jira/browse/HBASE-27810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717977#comment-17717977
]
Hudson commented on HBASE-27810:
Results for branch branch-2.5
[build #344 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/344/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBCK throws RejectedExecutionException when closing ZooKeeper resources
> ---
>
> Key: HBASE-27810
> URL: https://issues.apache.org/jira/browse/HBASE-27810
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 2.6.0, 3.0.0-alpha-3, 2.4.17, 2.5.4
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> HBCK throws RejectedExecutionException at the end of run, because the order
> of closing ZooKeeper resources has been swapped in HBASE-27426.
> In ZKWatcher.java close() method first it shuts down the zkEventProcessor and
> when it fully shut down, it closes the RecoverableZooKeeper (the ZK client).
> The watcher receives the close event which cannot be submitted to the event
> processor and throws exception.
> I think we need to check whether the executor is able to receive jobs before
> submitting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27693) Support for Hadoop's LDAP Authentication mechanism (Web UI only)
[
https://issues.apache.org/jira/browse/HBASE-27693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717969#comment-17717969
]
Hudson commented on HBASE-27693:
Results for branch master
[build #828 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/828/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/828/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/828/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/828/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Support for Hadoop's LDAP Authentication mechanism (Web UI only)
>
>
> Key: HBASE-27693
> URL: https://issues.apache.org/jira/browse/HBASE-27693
> Project: HBase
> Issue Type: New Feature
>Reporter: Yash Dodeja
>Assignee: Yash Dodeja
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
> Attachments: Screenshot 2023-03-27 at 10.53.26 AM.png
>
>
> Hadoop's AuthenticationFilter has changed and now has support for ldap
> mechanism too. HBase still uses an older version tightly coupled with
> kerberos and spnego as the only auth mechanisms. HADOOP-12082 has added
> support for multiple auth handlers including LDAP. On trying to use Hadoop's
> AuthenticationFilterInitializer in hbase.http.filter.initializers, there is a
> casting exception as HBase requires it to extend
> org.apache.hadoop.hbase.http.FilterInitializer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27810) HBCK throws RejectedExecutionException when closing ZooKeeper resources
[
https://issues.apache.org/jira/browse/HBASE-27810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717968#comment-17717968
]
Hudson commented on HBASE-27810:
Results for branch master
[build #828 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/828/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/828/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/828/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/828/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> HBCK throws RejectedExecutionException when closing ZooKeeper resources
> ---
>
> Key: HBASE-27810
> URL: https://issues.apache.org/jira/browse/HBASE-27810
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Affects Versions: 2.6.0, 3.0.0-alpha-3, 2.4.17, 2.5.4
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5
>
>
> HBCK throws RejectedExecutionException at the end of run, because the order
> of closing ZooKeeper resources has been swapped in HBASE-27426.
> In ZKWatcher.java close() method first it shuts down the zkEventProcessor and
> when it fully shut down, it closes the RecoverableZooKeeper (the ZK client).
> The watcher receives the close event which cannot be submitted to the event
> processor and throws exception.
> I think we need to check whether the executor is able to receive jobs before
> submitting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1528827387 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 27s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 4m 26s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 4m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 6s | hbase-common in the patch passed. | | -1 :x: | unit | 214m 17s | hbase-server in the patch failed. | | | | 241m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5171 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 38ee24ee4d9f 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1f605cc642 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/testReport/ | | Max. process+thread count | 2598 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1528826159 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 52s | master passed | | +1 :green_heart: | compile | 0m 49s | master passed | | +1 :green_heart: | shadedjars | 4m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 4m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 41s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 209m 44s | hbase-server in the patch passed. | | | | 234m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5171 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f2b358612951 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1f605cc642 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/testReport/ | | Max. process+thread count | 2836 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
Apache-HBase commented on PR #5171: URL: https://github.com/apache/hbase/pull/5171#issuecomment-1528789770 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 59s | master passed | | +1 :green_heart: | compile | 3m 0s | master passed | | +1 :green_heart: | checkstyle | 0m 46s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 57s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | +1 :green_heart: | compile | 2m 57s | the patch passed | | +1 :green_heart: | javac | 2m 57s | the patch passed | | +1 :green_heart: | checkstyle | 0m 46s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 52s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 44m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5171 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux bc692e84d4ad 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1f605cc642 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5171/15/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on a diff in pull request #5171: HBASE-27788 Skip family comparing when compare cells inner the store
bsglz commented on code in PR #5171:
URL: https://github.com/apache/hbase/pull/5171#discussion_r1181051570
##
hbase-common/src/main/java/org/apache/hadoop/hbase/InnerStoreCellComparator.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * Compare two HBase cells inner store, skip compare family for better
performance. Important!!! we
+ * should not make fake cell with fake family which length greater than zero
inner store, otherwise
+ * this optimization cannot be used.
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public class InnerStoreCellComparator extends CellComparatorImpl {
+
+ private static final long serialVersionUID = 8186411895799094989L;
+
+ public static final InnerStoreCellComparator INNER_STORE_COMPARATOR =
+new InnerStoreCellComparator();
+
+ @Override
+ protected int compareFamilies(Cell left, int leftFamilyLength, Cell right,
+int rightFamilyLength) {
+return leftFamilyLength - rightFamilyLength;
+ }
+
+ @Override
+ protected int compareFamilies(KeyValue left, int leftFamilyPosition, int
leftFamilyLength,
+KeyValue right, int rightFamilyPosition, int rightFamilyLength) {
+return leftFamilyLength - rightFamilyLength;
+ }
+
+ @Override
+ protected int compareFamilies(ByteBufferKeyValue left, int
leftFamilyPosition,
+int leftFamilyLength, ByteBufferKeyValue right, int rightFamilyPosition,
+int rightFamilyLength) {
+return leftFamilyLength - rightFamilyLength;
+ }
+
+ @Override
+ protected int compareFamilies(KeyValue left, int leftFamilyPosition, int
leftFamilyLength,
+ByteBufferKeyValue right, int rightFamilyPosition, int rightFamilyLength) {
+return leftFamilyLength - rightFamilyLength;
+ }
+
+ /**
+ * Utility method that makes a guess at comparator to use based off passed
tableName. Use in
+ * extreme when no comparator specified.
+ * @return CellComparator to use going off the {@code tableName} passed.
+ */
+ public static CellComparator getInnerStoreCellComparator(Configuration conf,
+TableName tableName) {
+return getInnerStoreCellComparator(conf, tableName.toBytes());
+ }
+
+ /**
+ * Utility method that makes a guess at comparator to use based off passed
tableName. Use in
+ * extreme when no comparator specified.
+ * @return CellComparator to use going off the {@code tableName} passed.
+ */
+ public static CellComparator getInnerStoreCellComparator(byte[] tableName) {
+return getInnerStoreCellComparator(null, tableName);
+ }
+
+ public static CellComparator getInnerStoreCellComparator(Configuration conf,
byte[] tableName) {
+if (
+ conf != null && conf.getBoolean(HConstants.USE_META_CELL_COMPARATOR,
Review Comment:
Let me try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717896#comment-17717896
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #67 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/67/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/67/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/67/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/67/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
