[jira] [Commented] (HBASE-27920) Skipping compact for this region if the table disable compaction

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740881#comment-17740881
 ] 

Hudson commented on HBASE-27920:


Results for branch branch-2
[build #845 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Skipping compact for this region if the table disable compaction
> 
>
> Key: HBASE-27920
> URL: https://issues.apache.org/jira/browse/HBASE-27920
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 2.3.7, 2.4.13
> Environment: HBase 2.3.7
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> CompactionChecker.chore() is called periodically for compacting. as follow:
> {code:java}
> //代码占位符
> protected void chore() {
>     for (Region r : this.instance.onlineRegions.values()) {
>         // Skip compaction if region is read only
>         if (r == null || r.isReadOnly()) {
>             continue;
>         }
>         HRegion hr = (HRegion) r;
>         for (HStore s : hr.stores.values()) {
>             // ...
>         }
>     }
> } {code}
> Just skip compact for the region if table disable compaction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27859) HMaster.getCompactionState can happen NPE when region state is closed

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740882#comment-17740882
 ] 

Hudson commented on HBASE-27859:


Results for branch branch-2
[build #845 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HMaster.getCompactionState can happen NPE when region state is closed
> -
>
> Key: HBASE-27859
> URL: https://issues.apache.org/jira/browse/HBASE-27859
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.7, 2.4.13
> Environment: hbase 2.4.13
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> Following steps to reproduce:
> 1 create table 
> {code:java}
> create 'hbase_region_test', 'info', SPLITS => ['3', '7']  {code}
>  
> 2 write data
> {code:java}
> //代码占位符
> put 'hbase_region_test', '10010', 'info:name', 'Tom'
> put 'hbase_region_test', '20010', 'info:name', 'Tom'
> put 'hbase_region_test', '30010', 'info:name', 'Tom'
> put 'hbase_region_test', '40010', 'info:name', 'Tom'
> put 'hbase_region_test', '50010', 'info:name', 'Tom'
> put 'hbase_region_test', '60010', 'info:name', 'Tom'
> put 'hbase_region_test', '70010', 'info:name', 'Tom'
> put 'hbase_region_test', '80010', 'info:name', 'Tom'
> put 'hbase_region_test', '90010', 'info:name', 'Tom' {code}
>  
> 3 closed a region of hbase_region_test by unassign 
>  
> 4 calling method HMaster.getCompactionState:    
> At this step, we can trigger this method to be called by opening hbase UI 
> page about 'hbase_region_test' table detailes and getting the compaction 
> state of 'hbase_region_test' samply
>  
> 5 HMaster print NPE logs about HMaster.getCompactionState



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27845) Distinguish the mutate types of rpc error in MetricsConnection

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740883#comment-17740883
 ] 

Hudson commented on HBASE-27845:


Results for branch branch-2
[build #845 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/845/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Distinguish the mutate types of rpc error in MetricsConnection
> --
>
> Key: HBASE-27845
> URL: https://issues.apache.org/jira/browse/HBASE-27845
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
>Reporter: zhuyaogai
>Assignee: zhuyaogai
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-beta-1
>
>
> There are four mutate types in HBase, including {_}Append{_}, {_}Delete{_}, 
> {_}Increment{_}, and _Put._ However, when rpc error occurs on the client, 
> mutate types are not distinguished in MetricsConnection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5318:
URL: https://github.com/apache/hbase/pull/5318#issuecomment-1624776414

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 28s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 40s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 30s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 16s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 39s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 39s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 31s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 224m 43s |  hbase-server in the patch passed.  
|
   |  |   | 245m 29s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5318 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 5247599faac7 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 
08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/3/testReport/
 |
   | Max. process+thread count | 4173 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27928) listTableNames has different criteria for judging the regular matching of tables in the default namespace

2023-07-06 Thread wenhao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wenhao updated HBASE-27928:
---
Summary: listTableNames has different criteria for judging the regular 
matching of tables in the default namespace  (was: listTableNames has different 
criteria for judging the regular matching of tables in the default library)

> listTableNames has different criteria for judging the regular matching of 
> tables in the default namespace
> -
>
> Key: HBASE-27928
> URL: https://issues.apache.org/jira/browse/HBASE-27928
> Project: HBase
>  Issue Type: Bug
>  Components: Admin
>Affects Versions: 2.0.0
>Reporter: wenhao
>Assignee: wenhao
>Priority: Minor
>
> There are the following tables under default: order_info, test123 
> When I execute the following logic (get the table that starts with test), 
> test123 is returned
> {code:java}
> String tableNameRegex = "^(test).*";
> TableName[] tns = admin.listTableNames(Pattern.compile(tableNameRegex));{code}
> When I execute the following logic (get a table that doesn't start with 
> test), the return is order_info, test123
> {code:java}
> String tableNameRegex = "^(?!test).*";
> TableName[] tns = admin.listTableNames(Pattern.compile(tableNameRegex));{code}
> As you can see, table test123 is returned both times.
>  
> When I look at the source code, I find that when I perform a regular match 
> for the table in the default namespace, I perform one step more judgment, 
> resulting in a table starting with test being returned both times.
> {code:java}
> boolean matched = pattern.matcher(tableName).matches();
> if (!matched && htd.getTableName().getNamespaceAsString().equals(defaultNS)) {
> matched = pattern.matcher(defaultNS + TableName.NAMESPACE_DELIM + 
> tableName).matches();
> }{code}
>  
> I think there are problems with this regular matching logic
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5318:
URL: https://github.com/apache/hbase/pull/5318#issuecomment-1624775293

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 42s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 48s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 38s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 38s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 48s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 48s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 40s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 221m 52s |  hbase-server in the patch passed.  
|
   |  |   | 243m 42s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5318 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 9e27f820d48e 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 
22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/3/testReport/
 |
   | Max. process+thread count | 4178 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5294: HBASE-27904: A random data generator tool leveraging hbase bulk load

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5294:
URL: https://github.com/apache/hbase/pull/5294#issuecomment-1624690259

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 42s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 21s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 27s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 39s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 35s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  9s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  8s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 28s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 28s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 37s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 35s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 367m  4s |  root in the patch passed.  |
   |  |   | 393m 32s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5294 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 71f3c5b02715 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 
17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / c82cf47354 |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/testReport/
 |
   | Max. process+thread count | 8064 (vs. ulimit of 3) |
   | modules | C: hbase-mapreduce . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (HBASE-27965) Change the label from InterfaceAudience.Private to InterfaceAudience.LimitedPrivate for org.apache.hadoop.hbase.Server.java

2023-07-06 Thread Shubham Roy (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shubham Roy updated HBASE-27965:

Description: 
Currently the class org.apache.hadoop.hbase.Server.java is marked 
InterfaceAudience.Private.

{{{}This prevents in getting shared zookeeper watcher (ZKWatcher) instances 
from org.apache.hadoop.hbase.regionserver.RegionServerServices.java (extends 
org.apache.hadoop.hbase.Server.java{}}}{{{}) using the method 
getZooKeeper().{}}}

 

{{This creates a problem in writing custom Coprocessors because now we don't 
have a shared ZKWatcher instance.}}

 

{{The proposed solution is to use the InterfaceAudience.LimitedPrivate. }}

  was:
{{Currently the class org.apache.hadoop.hbase.Server.java is marked 
InterfaceAudience.Private. }}

{{This prevents in getting shared zookeeper watcher (ZKWatcher) instances from 
org.apache.hadoop.hbase.regionserver.RegionServerServices.java (extends 
}}{{{}org.apache.hadoop.hbase.Server.java{}}}{{{}) using the method 
getZooKeeper().{}}}

 

{{This creates a problem in writing custom Coprocessors because now we don't 
have a shared ZKWatcher instance.}}

 

{{The proposed solution is to use the InterfaceAudience.LimitedPrivate. }}


> Change the label from InterfaceAudience.Private to 
> InterfaceAudience.LimitedPrivate for org.apache.hadoop.hbase.Server.java 
> 
>
> Key: HBASE-27965
> URL: https://issues.apache.org/jira/browse/HBASE-27965
> Project: HBase
>  Issue Type: Task
>  Components: Coprocessors
>Affects Versions: 2.4.4
>Reporter: Shubham Roy
>Priority: Minor
>
> Currently the class org.apache.hadoop.hbase.Server.java is marked 
> InterfaceAudience.Private.
> {{{}This prevents in getting shared zookeeper watcher (ZKWatcher) instances 
> from org.apache.hadoop.hbase.regionserver.RegionServerServices.java (extends 
> org.apache.hadoop.hbase.Server.java{}}}{{{}) using the method 
> getZooKeeper().{}}}
>  
> {{This creates a problem in writing custom Coprocessors because now we don't 
> have a shared ZKWatcher instance.}}
>  
> {{The proposed solution is to use the InterfaceAudience.LimitedPrivate. }}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27965) Change the label from InterfaceAudience.Private to InterfaceAudience.LimitedPrivate for org.apache.hadoop.hbase.Server.java

2023-07-06 Thread Shubham Roy (Jira)
Shubham Roy created HBASE-27965:
---

 Summary: Change the label from InterfaceAudience.Private to 
InterfaceAudience.LimitedPrivate for org.apache.hadoop.hbase.Server.java 
 Key: HBASE-27965
 URL: https://issues.apache.org/jira/browse/HBASE-27965
 Project: HBase
  Issue Type: Task
  Components: Coprocessors
Affects Versions: 2.4.4
Reporter: Shubham Roy


{{Currently the class org.apache.hadoop.hbase.Server.java is marked 
InterfaceAudience.Private. }}

{{This prevents in getting shared zookeeper watcher (ZKWatcher) instances from 
org.apache.hadoop.hbase.regionserver.RegionServerServices.java (extends 
}}{{{}org.apache.hadoop.hbase.Server.java{}}}{{{}) using the method 
getZooKeeper().{}}}

 

{{This creates a problem in writing custom Coprocessors because now we don't 
have a shared ZKWatcher instance.}}

 

{{The proposed solution is to use the InterfaceAudience.LimitedPrivate. }}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27859) HMaster.getCompactionState can happen NPE when region state is closed

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740859#comment-17740859
 ] 

Hudson commented on HBASE-27859:


Results for branch branch-2.4
[build #584 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HMaster.getCompactionState can happen NPE when region state is closed
> -
>
> Key: HBASE-27859
> URL: https://issues.apache.org/jira/browse/HBASE-27859
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.7, 2.4.13
> Environment: hbase 2.4.13
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> Following steps to reproduce:
> 1 create table 
> {code:java}
> create 'hbase_region_test', 'info', SPLITS => ['3', '7']  {code}
>  
> 2 write data
> {code:java}
> //代码占位符
> put 'hbase_region_test', '10010', 'info:name', 'Tom'
> put 'hbase_region_test', '20010', 'info:name', 'Tom'
> put 'hbase_region_test', '30010', 'info:name', 'Tom'
> put 'hbase_region_test', '40010', 'info:name', 'Tom'
> put 'hbase_region_test', '50010', 'info:name', 'Tom'
> put 'hbase_region_test', '60010', 'info:name', 'Tom'
> put 'hbase_region_test', '70010', 'info:name', 'Tom'
> put 'hbase_region_test', '80010', 'info:name', 'Tom'
> put 'hbase_region_test', '90010', 'info:name', 'Tom' {code}
>  
> 3 closed a region of hbase_region_test by unassign 
>  
> 4 calling method HMaster.getCompactionState:    
> At this step, we can trigger this method to be called by opening hbase UI 
> page about 'hbase_region_test' table detailes and getting the compaction 
> state of 'hbase_region_test' samply
>  
> 5 HMaster print NPE logs about HMaster.getCompactionState



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27920) Skipping compact for this region if the table disable compaction

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740858#comment-17740858
 ] 

Hudson commented on HBASE-27920:


Results for branch branch-2.4
[build #584 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/584/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Skipping compact for this region if the table disable compaction
> 
>
> Key: HBASE-27920
> URL: https://issues.apache.org/jira/browse/HBASE-27920
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 2.3.7, 2.4.13
> Environment: HBase 2.3.7
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> CompactionChecker.chore() is called periodically for compacting. as follow:
> {code:java}
> //代码占位符
> protected void chore() {
>     for (Region r : this.instance.onlineRegions.values()) {
>         // Skip compaction if region is read only
>         if (r == null || r.isReadOnly()) {
>             continue;
>         }
>         HRegion hr = (HRegion) r;
>         for (HStore s : hr.stores.values()) {
>             // ...
>         }
>     }
> } {code}
> Just skip compact for the region if table disable compaction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5294: HBASE-27904: A random data generator tool leveraging hbase bulk load

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5294:
URL: https://github.com/apache/hbase/pull/5294#issuecomment-1624557057

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 47s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  9s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 53s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 21s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m  1s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 49s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 50s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 50s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 14s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 57s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 252m 20s |  root in the patch passed.  |
   |  |   | 283m  7s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5294 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 192de932150a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / c82cf47354 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/testReport/
 |
   | Max. process+thread count | 8497 (vs. ulimit of 3) |
   | modules | C: hbase-mapreduce . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5318:
URL: https://github.com/apache/hbase/pull/5318#issuecomment-1624539542

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 32s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 32s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 43s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 32s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 40s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 30s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 30s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 36s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  10m 21s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.5.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 37s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  33m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5318 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 640fae2b5039 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 
24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5294: HBASE-27904: A random data generator tool leveraging hbase bulk load

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5294:
URL: https://github.com/apache/hbase/pull/5294#issuecomment-1624402493

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 43s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 42s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   5m 11s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 15s |  branch-2 passed  |
   | -0 :warning: |  mvnsite  |   2m  6s |  root in branch-2 failed.  |
   | +1 :green_heart: |  spotless  |   0m 43s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   7m 55s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  9s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 11s |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 11s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 14s |  the patch passed  |
   | -0 :warning: |  mvnsite  |   2m  8s |  root in the patch failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  15m  6s |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.2.4 3.3.5.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   8m 10s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 18s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  60m 23s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5294 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile mvnsite |
   | uname | Linux 98c82f8a6403 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / c82cf47354 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | mvnsite | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/artifact/yetus-general-check/output/branch-mvnsite-root.txt
 |
   | mvnsite | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/artifact/yetus-general-check/output/patch-mvnsite-root.txt
 |
   | Max. process+thread count | 179 (vs. ulimit of 3) |
   | modules | C: hbase-mapreduce . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/7/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5294: HBASE-27904: A random data generator tool leveraging hbase bulk load

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5294:
URL: https://github.com/apache/hbase/pull/5294#issuecomment-1624348216

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 50s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 11s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 46s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 13s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m  3s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 27s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 51s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 51s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 14s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m  0s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 403m 10s |  root in the patch failed.  |
   |  |   | 435m 12s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5294 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux d9d71447f05e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / c82cf47354 |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/testReport/
 |
   | Max. process+thread count | 7963 (vs. ulimit of 3) |
   | modules | C: hbase-mapreduce . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27942) The description about hbase.hstore.comactionThreshold is not accurate

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740810#comment-17740810
 ] 

Hudson commented on HBASE-27942:


Results for branch branch-2.5
[build #377 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The description about hbase.hstore.comactionThreshold is not accurate
> -
>
> Key: HBASE-27942
> URL: https://issues.apache.org/jira/browse/HBASE-27942
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.3.7, 2.4.17
> Environment: Centos7
> HBase master
>Reporter: guluo
>Assignee: guluo
>Priority: Minor
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
> Attachments: 2023-06-20_221700.png, 2023-06-20_221821.png
>
>
> In document hbase-default.xml, The  description about 
> [hbase.hstore.comactionThreshold|http://hbase.hstore.comactionthreshold/] is 
> not accurate,as follow:
> !2023-06-20_221700.png!
> Actually,hbase will run compaction when the number of store files greater 
> than or equal to 
> [hbase.hstore.comactionThreshold|http://hbase.hstore.comactionthreshold/], as 
> follow
> !2023-06-20_221821.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27920) Skipping compact for this region if the table disable compaction

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740811#comment-17740811
 ] 

Hudson commented on HBASE-27920:


Results for branch branch-2.5
[build #377 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Skipping compact for this region if the table disable compaction
> 
>
> Key: HBASE-27920
> URL: https://issues.apache.org/jira/browse/HBASE-27920
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 2.3.7, 2.4.13
> Environment: HBase 2.3.7
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> CompactionChecker.chore() is called periodically for compacting. as follow:
> {code:java}
> //代码占位符
> protected void chore() {
>     for (Region r : this.instance.onlineRegions.values()) {
>         // Skip compaction if region is read only
>         if (r == null || r.isReadOnly()) {
>             continue;
>         }
>         HRegion hr = (HRegion) r;
>         for (HStore s : hr.stores.values()) {
>             // ...
>         }
>     }
> } {code}
> Just skip compact for the region if table disable compaction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27859) HMaster.getCompactionState can happen NPE when region state is closed

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740812#comment-17740812
 ] 

Hudson commented on HBASE-27859:


Results for branch branch-2.5
[build #377 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/377/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HMaster.getCompactionState can happen NPE when region state is closed
> -
>
> Key: HBASE-27859
> URL: https://issues.apache.org/jira/browse/HBASE-27859
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.7, 2.4.13
> Environment: hbase 2.4.13
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> Following steps to reproduce:
> 1 create table 
> {code:java}
> create 'hbase_region_test', 'info', SPLITS => ['3', '7']  {code}
>  
> 2 write data
> {code:java}
> //代码占位符
> put 'hbase_region_test', '10010', 'info:name', 'Tom'
> put 'hbase_region_test', '20010', 'info:name', 'Tom'
> put 'hbase_region_test', '30010', 'info:name', 'Tom'
> put 'hbase_region_test', '40010', 'info:name', 'Tom'
> put 'hbase_region_test', '50010', 'info:name', 'Tom'
> put 'hbase_region_test', '60010', 'info:name', 'Tom'
> put 'hbase_region_test', '70010', 'info:name', 'Tom'
> put 'hbase_region_test', '80010', 'info:name', 'Tom'
> put 'hbase_region_test', '90010', 'info:name', 'Tom' {code}
>  
> 3 closed a region of hbase_region_test by unassign 
>  
> 4 calling method HMaster.getCompactionState:    
> At this step, we can trigger this method to be called by opening hbase UI 
> page about 'hbase_region_test' table detailes and getting the compaction 
> state of 'hbase_region_test' samply
>  
> 5 HMaster print NPE logs about HMaster.getCompactionState



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27942) The description about hbase.hstore.comactionThreshold is not accurate

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740773#comment-17740773
 ] 

Hudson commented on HBASE-27942:


Results for branch branch-3
[build #15 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The description about hbase.hstore.comactionThreshold is not accurate
> -
>
> Key: HBASE-27942
> URL: https://issues.apache.org/jira/browse/HBASE-27942
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.3.7, 2.4.17
> Environment: Centos7
> HBase master
>Reporter: guluo
>Assignee: guluo
>Priority: Minor
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
> Attachments: 2023-06-20_221700.png, 2023-06-20_221821.png
>
>
> In document hbase-default.xml, The  description about 
> [hbase.hstore.comactionThreshold|http://hbase.hstore.comactionthreshold/] is 
> not accurate,as follow:
> !2023-06-20_221700.png!
> Actually,hbase will run compaction when the number of store files greater 
> than or equal to 
> [hbase.hstore.comactionThreshold|http://hbase.hstore.comactionthreshold/], as 
> follow
> !2023-06-20_221821.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27920) Skipping compact for this region if the table disable compaction

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740774#comment-17740774
 ] 

Hudson commented on HBASE-27920:


Results for branch branch-3
[build #15 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Skipping compact for this region if the table disable compaction
> 
>
> Key: HBASE-27920
> URL: https://issues.apache.org/jira/browse/HBASE-27920
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 2.3.7, 2.4.13
> Environment: HBase 2.3.7
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> CompactionChecker.chore() is called periodically for compacting. as follow:
> {code:java}
> //代码占位符
> protected void chore() {
>     for (Region r : this.instance.onlineRegions.values()) {
>         // Skip compaction if region is read only
>         if (r == null || r.isReadOnly()) {
>             continue;
>         }
>         HRegion hr = (HRegion) r;
>         for (HStore s : hr.stores.values()) {
>             // ...
>         }
>     }
> } {code}
> Just skip compact for the region if table disable compaction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27845) Distinguish the mutate types of rpc error in MetricsConnection

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740776#comment-17740776
 ] 

Hudson commented on HBASE-27845:


Results for branch branch-3
[build #15 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Distinguish the mutate types of rpc error in MetricsConnection
> --
>
> Key: HBASE-27845
> URL: https://issues.apache.org/jira/browse/HBASE-27845
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
>Reporter: zhuyaogai
>Assignee: zhuyaogai
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-beta-1
>
>
> There are four mutate types in HBase, including {_}Append{_}, {_}Delete{_}, 
> {_}Increment{_}, and _Put._ However, when rpc error occurs on the client, 
> mutate types are not distinguished in MetricsConnection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27859) HMaster.getCompactionState can happen NPE when region state is closed

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740775#comment-17740775
 ] 

Hudson commented on HBASE-27859:


Results for branch branch-3
[build #15 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/15/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HMaster.getCompactionState can happen NPE when region state is closed
> -
>
> Key: HBASE-27859
> URL: https://issues.apache.org/jira/browse/HBASE-27859
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.7, 2.4.13
> Environment: hbase 2.4.13
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> Following steps to reproduce:
> 1 create table 
> {code:java}
> create 'hbase_region_test', 'info', SPLITS => ['3', '7']  {code}
>  
> 2 write data
> {code:java}
> //代码占位符
> put 'hbase_region_test', '10010', 'info:name', 'Tom'
> put 'hbase_region_test', '20010', 'info:name', 'Tom'
> put 'hbase_region_test', '30010', 'info:name', 'Tom'
> put 'hbase_region_test', '40010', 'info:name', 'Tom'
> put 'hbase_region_test', '50010', 'info:name', 'Tom'
> put 'hbase_region_test', '60010', 'info:name', 'Tom'
> put 'hbase_region_test', '70010', 'info:name', 'Tom'
> put 'hbase_region_test', '80010', 'info:name', 'Tom'
> put 'hbase_region_test', '90010', 'info:name', 'Tom' {code}
>  
> 3 closed a region of hbase_region_test by unassign 
>  
> 4 calling method HMaster.getCompactionState:    
> At this step, we can trigger this method to be called by opening hbase UI 
> page about 'hbase_region_test' table detailes and getting the compaction 
> state of 'hbase_region_test' samply
>  
> 5 HMaster print NPE logs about HMaster.getCompactionState



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27845) Distinguish the mutate types of rpc error in MetricsConnection

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740770#comment-17740770
 ] 

Hudson commented on HBASE-27845:


Results for branch master
[build #869 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Distinguish the mutate types of rpc error in MetricsConnection
> --
>
> Key: HBASE-27845
> URL: https://issues.apache.org/jira/browse/HBASE-27845
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
>Reporter: zhuyaogai
>Assignee: zhuyaogai
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-beta-1
>
>
> There are four mutate types in HBase, including {_}Append{_}, {_}Delete{_}, 
> {_}Increment{_}, and _Put._ However, when rpc error occurs on the client, 
> mutate types are not distinguished in MetricsConnection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27859) HMaster.getCompactionState can happen NPE when region state is closed

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740771#comment-17740771
 ] 

Hudson commented on HBASE-27859:


Results for branch master
[build #869 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HMaster.getCompactionState can happen NPE when region state is closed
> -
>
> Key: HBASE-27859
> URL: https://issues.apache.org/jira/browse/HBASE-27859
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.7, 2.4.13
> Environment: hbase 2.4.13
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> Following steps to reproduce:
> 1 create table 
> {code:java}
> create 'hbase_region_test', 'info', SPLITS => ['3', '7']  {code}
>  
> 2 write data
> {code:java}
> //代码占位符
> put 'hbase_region_test', '10010', 'info:name', 'Tom'
> put 'hbase_region_test', '20010', 'info:name', 'Tom'
> put 'hbase_region_test', '30010', 'info:name', 'Tom'
> put 'hbase_region_test', '40010', 'info:name', 'Tom'
> put 'hbase_region_test', '50010', 'info:name', 'Tom'
> put 'hbase_region_test', '60010', 'info:name', 'Tom'
> put 'hbase_region_test', '70010', 'info:name', 'Tom'
> put 'hbase_region_test', '80010', 'info:name', 'Tom'
> put 'hbase_region_test', '90010', 'info:name', 'Tom' {code}
>  
> 3 closed a region of hbase_region_test by unassign 
>  
> 4 calling method HMaster.getCompactionState:    
> At this step, we can trigger this method to be called by opening hbase UI 
> page about 'hbase_region_test' table detailes and getting the compaction 
> state of 'hbase_region_test' samply
>  
> 5 HMaster print NPE logs about HMaster.getCompactionState



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27663) ChaosMonkey documentation enhancements

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740768#comment-17740768
 ] 

Hudson commented on HBASE-27663:


Results for branch master
[build #869 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> ChaosMonkey documentation enhancements
> --
>
> Key: HBASE-27663
> URL: https://issues.apache.org/jira/browse/HBASE-27663
> Project: HBase
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Yash Dodeja
>Assignee: Yash Dodeja
>Priority: Minor
> Fix For: 4.0.0-alpha-1
>
>
> Post refactoring the code to org.apache.hadoop.hbase.chaos package, new 
> references need to be updated in the 
> [https://hbase.apache.org/book.html#maven.build.commands.integration.tests.destructive]
>  doc. The sample command given also is stale.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27920) Skipping compact for this region if the table disable compaction

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740769#comment-17740769
 ] 

Hudson commented on HBASE-27920:


Results for branch master
[build #869 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Skipping compact for this region if the table disable compaction
> 
>
> Key: HBASE-27920
> URL: https://issues.apache.org/jira/browse/HBASE-27920
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Affects Versions: 2.3.7, 2.4.13
> Environment: HBase 2.3.7
>Reporter: guluo
>Assignee: guluo
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
>
> CompactionChecker.chore() is called periodically for compacting. as follow:
> {code:java}
> //代码占位符
> protected void chore() {
>     for (Region r : this.instance.onlineRegions.values()) {
>         // Skip compaction if region is read only
>         if (r == null || r.isReadOnly()) {
>             continue;
>         }
>         HRegion hr = (HRegion) r;
>         for (HStore s : hr.stores.values()) {
>             // ...
>         }
>     }
> } {code}
> Just skip compact for the region if table disable compaction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27942) The description about hbase.hstore.comactionThreshold is not accurate

2023-07-06 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740767#comment-17740767
 ] 

Hudson commented on HBASE-27942:


Results for branch master
[build #869 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/869/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The description about hbase.hstore.comactionThreshold is not accurate
> -
>
> Key: HBASE-27942
> URL: https://issues.apache.org/jira/browse/HBASE-27942
> Project: HBase
>  Issue Type: Bug
>  Components: documentation
>Affects Versions: 2.3.7, 2.4.17
> Environment: Centos7
> HBase master
>Reporter: guluo
>Assignee: guluo
>Priority: Minor
> Fix For: 2.6.0, 2.4.18, 2.5.6, 3.0.0-beta-1
>
> Attachments: 2023-06-20_221700.png, 2023-06-20_221821.png
>
>
> In document hbase-default.xml, The  description about 
> [hbase.hstore.comactionThreshold|http://hbase.hstore.comactionthreshold/] is 
> not accurate,as follow:
> !2023-06-20_221700.png!
> Actually,hbase will run compaction when the number of store files greater 
> than or equal to 
> [hbase.hstore.comactionThreshold|http://hbase.hstore.comactionthreshold/], as 
> follow
> !2023-06-20_221821.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5318:
URL: https://github.com/apache/hbase/pull/5318#issuecomment-1624097411

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 33s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 54s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 11s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 54s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 20s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 217m 42s |  hbase-server in the patch passed.  
|
   |  |   | 238m 33s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5318 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 61c2f030d5da 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 
17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/2/testReport/
 |
   | Max. process+thread count | 4621 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5294: HBASE-27904: A random data generator tool leveraging hbase bulk load

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5294:
URL: https://github.com/apache/hbase/pull/5294#issuecomment-1623881913

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 44s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 29s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  8s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   5m  5s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m  5s |  branch-2 passed  |
   | -0 :warning: |  mvnsite  |   2m 19s |  root in branch-2 failed.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   8m  7s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 43s |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m  6s |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m  6s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 11s |  the patch passed  |
   | -0 :warning: |  mvnsite  |   2m  7s |  root in the patch failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  14m 36s |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.2.4 3.3.5.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   8m  5s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 17s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  58m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5294 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile mvnsite |
   | uname | Linux 3c7bc2a49ce0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / c82cf47354 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | mvnsite | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/artifact/yetus-general-check/output/branch-mvnsite-root.txt
 |
   | mvnsite | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/artifact/yetus-general-check/output/patch-mvnsite-root.txt
 |
   | Max. process+thread count | 179 (vs. ulimit of 3) |
   | modules | C: hbase-mapreduce . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27963) Replication stuck when switch to new reader

2023-07-06 Thread Rushabh Shah (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740668#comment-17740668
 ] 

Rushabh Shah commented on HBASE-27963:
--

We are also seeing similar errors in our production environment. We are running 
some version of 1.7 version. As a work around we restart the regionserver and 
the new regionserver is able to replicate. So some in-memory data structure is 
out of sync.

> Replication stuck when switch to new reader
> ---
>
> Key: HBASE-27963
> URL: https://issues.apache.org/jira/browse/HBASE-27963
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0-alpha-4, 2.4.17, 2.5.5
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> After creating new reader for next WAL, it immediately seek() to the  
> currentPositionOfEntry, but this position may be spill over the length of 
> current WAL.
> {code:java}
> WARN  
> [RpcServer.default.FPRWQ.Fifo.read.handler=101,queue=1,port=16020.replicationSource.wal-reader.XXX]
>  regionserver.ReplicationSourceWALReader: Failed to read stream of 
> replication entries
> java.io.EOFException: Cannot seek after EOF
>         at 
> org.apache.hadoop.hdfs.DFSInputStream.seek(DFSInputStream.java:1488)
>         at 
> org.apache.hadoop.fs.FSDataInputStream.seek(FSDataInputStream.java:62)
>         at 
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.seekOnFs(ProtobufLogReader.java:495)
>         at 
> org.apache.hadoop.hbase.regionserver.wal.ReaderBase.seek(ReaderBase.java:138)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.seek(WALEntryStream.java:399)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:341)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.handleFileNotFound(WALEntryStream.java:328)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:347)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openNextLog(WALEntryStream.java:310)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.checkReader(WALEntryStream.java:300)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:176)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:102)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.tryAdvanceStreamAndCreateWALBatch(ReplicationSourceWALReader.java:260)
>         at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:142)
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5294: HBASE-27904: A random data generator tool leveraging hbase bulk load

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5294:
URL: https://github.com/apache/hbase/pull/5294#issuecomment-1623871316

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 35s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 42s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 51s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 45s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 10s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 51s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 51s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 45s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m  8s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  25m  9s |  root in the patch failed.  |
   |  |   |  51m 24s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5294 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 8c55b3f1a2b7 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 
22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / c82cf47354 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/testReport/
 |
   | Max. process+thread count | 2610 (vs. ulimit of 3) |
   | modules | C: hbase-mapreduce . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/6/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5318:
URL: https://github.com/apache/hbase/pull/5318#issuecomment-1623800220

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 28s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 57s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 42s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 54s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 54s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 28s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 56s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 56s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 38s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m  0s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.5.  |
   | +1 :green_heart: |  spotless  |   0m 53s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m  0s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  40m  8s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5318 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 5a9f4888dfc7 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 
24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 84 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5318:
URL: https://github.com/apache/hbase/pull/5318#issuecomment-1623725205

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 36s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 49s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 46s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 45s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 45s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 46s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 31s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 269m 42s |  hbase-server in the patch failed.  |
   |  |   | 294m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5318 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 003d0b77b6d0 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 
08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/testReport/
 |
   | Max. process+thread count | 4179 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5318:
URL: https://github.com/apache/hbase/pull/5318#issuecomment-1623724555

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 36s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 17s |  master passed  |
   | +1 :green_heart: |  compile  |   1m  1s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 37s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 47s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  2s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 11s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 11s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 41s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 265m 27s |  hbase-server in the patch passed.  
|
   |  |   | 294m 10s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5318 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux c53fc029ba6e 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 
22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/testReport/
 |
   | Max. process+thread count | 4548 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5294: HBASE-27904: A random data generator tool leveraging hbase bulk load

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5294:
URL: https://github.com/apache/hbase/pull/5294#issuecomment-1623603878

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   2m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m  8s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 26s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 42s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 34s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  4s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 27s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 27s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 43s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 35s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 365m  6s |  root in the patch passed.  |
   |  |   | 394m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5294 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 3ce32ea8e4fd 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 
17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / c82cf47354 |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/5/testReport/
 |
   | Max. process+thread count | 7749 (vs. ulimit of 3) |
   | modules | C: hbase-mapreduce . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/5/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (HBASE-27964) Adds a switch for compaction's delay selection feature

2023-07-06 Thread Zheng Wang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740578#comment-17740578
 ] 

Zheng Wang commented on HBASE-27964:


Here is a test.

I write data to a cluster which has two regionServers, and limit the compaction 
throughput, the node9(10.0.0.9) apply the patch and disable delayed selection, 
we can see the store_file_count and store_file_size grows similar, but the 
compaction_queue_length has big difference, the node23(10.0.0.23) obviously 
incorrect.

!image-2023-07-06-19-51-21-354.png|width=503,height=192!

!image-2023-07-06-20-00-21-587.png|width=502,height=190!

!image-2023-07-06-20-00-41-933.png|width=501,height=192!

> Adds a switch for compaction's delay selection feature
> --
>
> Key: HBASE-27964
> URL: https://issues.apache.org/jira/browse/HBASE-27964
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
> Attachments: image-2023-07-06-19-51-21-354.png, 
> image-2023-07-06-20-00-21-587.png, image-2023-07-06-20-00-41-933.png
>
>
> When the compact pressure is high, delayed selection can cause the metric of 
> compact queue length to continuously increase incorrectly. We should provide 
> an option to disable this feature if the user values metric accuracy more.
> See HBASE-26987 for more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27964) Adds a switch for compaction's delay selection feature

2023-07-06 Thread Zheng Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Wang updated HBASE-27964:
---
Attachment: image-2023-07-06-20-00-21-587.png

> Adds a switch for compaction's delay selection feature
> --
>
> Key: HBASE-27964
> URL: https://issues.apache.org/jira/browse/HBASE-27964
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
> Attachments: image-2023-07-06-19-51-21-354.png, 
> image-2023-07-06-20-00-21-587.png, image-2023-07-06-20-00-41-933.png
>
>
> When the compact pressure is high, delayed selection can cause the metric of 
> compact queue length to continuously increase incorrectly. We should provide 
> an option to disable this feature if the user values metric accuracy more.
> See HBASE-26987 for more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27964) Adds a switch for compaction's delay selection feature

2023-07-06 Thread Zheng Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Wang updated HBASE-27964:
---
Attachment: image-2023-07-06-20-00-41-933.png

> Adds a switch for compaction's delay selection feature
> --
>
> Key: HBASE-27964
> URL: https://issues.apache.org/jira/browse/HBASE-27964
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
> Attachments: image-2023-07-06-19-51-21-354.png, 
> image-2023-07-06-20-00-21-587.png, image-2023-07-06-20-00-41-933.png
>
>
> When the compact pressure is high, delayed selection can cause the metric of 
> compact queue length to continuously increase incorrectly. We should provide 
> an option to disable this feature if the user values metric accuracy more.
> See HBASE-26987 for more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (HBASE-27964) Adds a switch for compaction's delay selection feature

2023-07-06 Thread Zheng Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-27964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Wang updated HBASE-27964:
---
Attachment: image-2023-07-06-19-51-21-354.png

> Adds a switch for compaction's delay selection feature
> --
>
> Key: HBASE-27964
> URL: https://issues.apache.org/jira/browse/HBASE-27964
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
> Attachments: image-2023-07-06-19-51-21-354.png
>
>
> When the compact pressure is high, delayed selection can cause the metric of 
> compact queue length to continuously increase incorrectly. We should provide 
> an option to disable this feature if the user values metric accuracy more.
> See HBASE-26987 for more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] sunhelly commented on pull request #5288: HBASE-27926 DBB release too early for replication

2023-07-06 Thread via GitHub


sunhelly commented on PR #5288:
URL: https://github.com/apache/hbase/pull/5288#issuecomment-1623506393

   I will close this PR and try UT reproduce this issue in another. Any one 
intresting in this issue can try reproduce and fix it too. Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] sunhelly closed pull request #5288: HBASE-27926 DBB release too early for replication

2023-07-06 Thread via GitHub


sunhelly closed pull request #5288: HBASE-27926 DBB release too early for 
replication
URL: https://github.com/apache/hbase/pull/5288


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5316: HBASE-27962 Introduce an AdaptiveFastPathRWRpcExecutor to make the W/R/S separations fit various workloads

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5316:
URL: https://github.com/apache/hbase/pull/5316#issuecomment-1623504903

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 40s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 33s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 20s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 40s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 40s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 29s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 232m 38s |  hbase-server in the patch failed.  |
   |  |   | 253m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5316 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux d0ad587bba08 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 
22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Temurin-1.8.0_352-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/testReport/
 |
   | Max. process+thread count | 4441 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5316: HBASE-27962 Introduce an AdaptiveFastPathRWRpcExecutor to make the W/R/S separations fit various workloads

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5316:
URL: https://github.com/apache/hbase/pull/5316#issuecomment-1623494054

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 47s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 47s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 36s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 33s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 47s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 47s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 35s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 223m 36s |  hbase-server in the patch passed.  
|
   |  |   | 245m 27s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5316 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 1572d9248cca 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 
22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/testReport/
 |
   | Max. process+thread count | 4484 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] bbeaudreault commented on pull request #5288: HBASE-27926 DBB release too early for replication

2023-07-06 Thread via GitHub


bbeaudreault commented on PR #5288:
URL: https://github.com/apache/hbase/pull/5288#issuecomment-1623419517

   Is this repeatable for you? If so can you add logging to try to get a more 
exact trace of when the problem occurs? Otherwise add a unit test?
   
   It’s really painful tracking down leaks, so I’m not excited to remove a 
release/cleanup without very clear evidence or other options ruled out. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5318: HBASE-27964 Adds a switch for compaction's delay selection feature

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5318:
URL: https://github.com/apache/hbase/pull/5318#issuecomment-1623362492

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 37s |  master passed  |
   | +1 :green_heart: |  compile  |   3m 10s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 42s |  master passed  |
   | +1 :green_heart: |  spotless  |   1m  3s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m 15s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 20s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 10s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 10s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  11m 24s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.5.  |
   | +1 :green_heart: |  spotless  |   0m 54s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   2m  8s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 12s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  41m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5318 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 6d8b65381afe 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 
24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5318/1/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (HBASE-27964) Adds a switch for compaction's delay selection feature

2023-07-06 Thread Zheng Wang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740515#comment-17740515
 ] 

Zheng Wang edited comment on HBASE-27964 at 7/6/23 9:27 AM:


Yeah, I think so.  Consider this patch not fix it, just add a switch, so i set 
the type as improvement.

[~zhangduo] 


was (Author: filtertip):
Yeah, I think so.  [~zhangduo] 

> Adds a switch for compaction's delay selection feature
> --
>
> Key: HBASE-27964
> URL: https://issues.apache.org/jira/browse/HBASE-27964
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
>
> When the compact pressure is high, delayed selection can cause the metric of 
> compact queue length to continuously increase incorrectly. We should provide 
> an option to disable this feature if the user values metric accuracy more.
> See HBASE-26987 for more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27964) Adds a switch for compaction's delay selection feature

2023-07-06 Thread Zheng Wang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740515#comment-17740515
 ] 

Zheng Wang commented on HBASE-27964:


Yeah, I think so.  [~zhangduo] 

> Adds a switch for compaction's delay selection feature
> --
>
> Key: HBASE-27964
> URL: https://issues.apache.org/jira/browse/HBASE-27964
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
>
> When the compact pressure is high, delayed selection can cause the metric of 
> compact queue length to continuously increase incorrectly. We should provide 
> an option to disable this feature if the user values metric accuracy more.
> See HBASE-26987 for more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27964) Adds a switch for compaction's delay selection feature

2023-07-06 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740504#comment-17740504
 ] 

Duo Zhang commented on HBASE-27964:
---

{quote}
delayed selection can cause the metric of compact queue length to continuously 
increase incorrectly
{quote}

This should be a bug?

> Adds a switch for compaction's delay selection feature
> --
>
> Key: HBASE-27964
> URL: https://issues.apache.org/jira/browse/HBASE-27964
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
>
> When the compact pressure is high, delayed selection can cause the metric of 
> compact queue length to continuously increase incorrectly. We should provide 
> an option to disable this feature if the user values metric accuracy more.
> See HBASE-26987 for more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (HBASE-27964) Adds a switch for compaction's delay selection feature

2023-07-06 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-27964:
--

 Summary: Adds a switch for compaction's delay selection feature
 Key: HBASE-27964
 URL: https://issues.apache.org/jira/browse/HBASE-27964
 Project: HBase
  Issue Type: Improvement
  Components: Compaction
Reporter: Zheng Wang
Assignee: Zheng Wang


When the compact pressure is high, delayed selection can cause the metric of 
compact queue length to continuously increase incorrectly. We should provide an 
option to disable this feature if the user values metric accuracy more.

See HBASE-26987 for more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [hbase] Apache-HBase commented on pull request #5316: HBASE-27962 Introduce an AdaptiveFastPathRWRpcExecutor to make the W/R/S separations fit various workloads

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5316:
URL: https://github.com/apache/hbase/pull/5316#issuecomment-1623151174

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 12s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 46s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 28s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 36s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 43s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 29s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 35s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 25s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 25s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   8m 58s |  Patch does not cause any 
errors with Hadoop 3.2.4 3.3.5.  |
   | +1 :green_heart: |  spotless  |   0m 41s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 35s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 12s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  30m 58s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5316 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux b77a4a936e95 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 
08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | Max. process+thread count | 78 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/3/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5316: HBASE-27962 Introduce an AdaptiveFastPathRWRpcExecutor to make the W/R/S separations fit various workloads

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5316:
URL: https://github.com/apache/hbase/pull/5316#issuecomment-1623111903

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 54s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 50s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 46s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 35s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 31s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 43s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 48s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 48s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 22s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 248m 27s |  hbase-server in the patch passed.  
|
   |  |   | 272m 59s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5316 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 4186ab2367cd 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 
22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / b2e2abe64b |
   | Default Java | Temurin-1.8.0_352-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/2/testReport/
 |
   | Max. process+thread count | 4417 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5316/2/console 
|
   | versions | git=2.34.1 maven=3.8.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #5294: HBASE-27904: A random data generator tool leveraging hbase bulk load

2023-07-06 Thread via GitHub


Apache-HBase commented on PR #5294:
URL: https://github.com/apache/hbase/pull/5294#issuecomment-1623103838

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 43s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   5m  6s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 11s |  branch-2 passed  |
   | +1 :green_heart: |  mvnsite  |   4m 41s |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 48s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   8m 41s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m  4s |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m  4s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m  8s |  the patch passed  |
   | -0 :warning: |  mvnsite  |   2m  5s |  root in the patch failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  14m 28s |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.2.4 3.3.5.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   8m  4s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 19s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  62m  9s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/5/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5294 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile mvnsite |
   | uname | Linux 7fe09a6e5085 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / c82cf47354 |
   | Default Java | Eclipse Adoptium-11.0.17+8 |
   | mvnsite | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/5/artifact/yetus-general-check/output/patch-mvnsite-root.txt
 |
   | Max. process+thread count | 180 (vs. ulimit of 3) |
   | modules | C: hbase-mapreduce . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5294/5/console 
|
   | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org