[jira] [Commented] (HBASE-28221) Introduce regionserver metric for delayed flushes
[
https://issues.apache.org/jira/browse/HBASE-28221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816282#comment-17816282
]
David Manning commented on HBASE-28221:
---
Alerting on {{flushQueueLength}} is not really the same. You will capture every
delayed flush from {{PeriodicMemstoreFlusher}} as well. So it will capture both
cases where you enqueue a delayed flush: either for a very busy region beyond
{{blockingStoreFiles}} limit or for a region which is mostly idle and flushing
after memstore edits are an hour old.
Alerting on {{blockedRequestsCount}} will give you a stronger signal, because
this is when you have a {{RegionTooBusyException}} due to the memstore being
full, waiting on a delayed flush.
But if you want to alert on a delayed flush without a full memstore, I don't
know that it could be done today without adding a new metric. If you have
site-wide settings for {{blockingStoreFiles}}, you could alert when
{{maxStoreFileCount}} is above, or near, {{blockingStoreFiles}}. But if it
varies by table, you would have to alert per-table.
So there could still be some value in adding this type of metric (but consider
whether alerting on client impact, i.e. {{RegionTooBusyException}} and
{{blockedRequestsCount}} would be sufficient first.) [~rkrahul324] [~vjasani]
> Introduce regionserver metric for delayed flushes
> -
>
> Key: HBASE-28221
> URL: https://issues.apache.org/jira/browse/HBASE-28221
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.4.17, 2.5.6
>Reporter: Viraj Jasani
>Assignee: Rahul Kumar
>Priority: Major
> Fix For: 2.4.18, 2.7.0, 2.5.8, 3.0.0-beta-2, 2.6.1
>
>
> If compaction is disabled temporarily to allow stabilizing hdfs load, we can
> forget re-enabling the compaction. This can result into flushes getting
> delayed for "hbase.hstore.blockingWaitTime" time (90s). While flushes do
> happen eventually after waiting for max blocking time, it is important to
> realize that any cluster cannot function well with compaction disabled for
> significant amount of time.
>
> We would also block any write requests until region is flushed (90+ sec, by
> default):
> {code:java}
> 2023-11-27 20:40:52,124 WARN [,queue=18,port=60020] regionserver.HRegion -
> Region is too busy due to exceeding memstore size limit.
> org.apache.hadoop.hbase.RegionTooBusyException: Above memstore limit,
> regionName=table1,1699923733811.4fd5e52e2133df1e347f32c646f23ab4.,
> server=server-1,60020,1699421714454, memstoreSize=1073820928,
> blockingMemStoreSize=1073741824
> at
> org.apache.hadoop.hbase.regionserver.HRegion.checkResources(HRegion.java:4200)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3264)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3215)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:967)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:895)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2524)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36812)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2432)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291)
> {code}
>
> Delayed flush logs:
> {code:java}
> LOG.warn("{} has too many store files({}); delaying flush up to {} ms",
> region.getRegionInfo().getEncodedName(), getStoreFileCount(region),
> this.blockingWaitTime); {code}
> Suggestion: Introduce regionserver metric (MetricsRegionServerSource) for the
> num of flushes getting delayed due to too many store files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers [hbase]
d-c-manning commented on code in PR #5675:
URL: https://github.com/apache/hbase/pull/5675#discussion_r1484986773
##
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java:
##
@@ -510,19 +510,38 @@ public Void call() {
private Void readColumnFamily(Table table, ColumnFamilyDescriptor column) {
byte[] startKey = null;
- Get get = null;
Scan scan = null;
ResultScanner rs = null;
StopWatch stopWatch = new StopWatch();
startKey = region.getStartKey();
// Can't do a get on empty start row so do a Scan of first element if
any instead.
if (startKey.length > 0) {
-get = new Get(startKey);
+Get get = new Get(startKey);
get.setCacheBlocks(false);
get.setFilter(new FirstKeyOnlyFilter());
get.addFamily(column.getName());
+// Converting get object to scan to enable RAW SCAN.
+// This will work for all the regions of the HBase tables except first
region of the table.
+scan = new Scan(get);
+scan.setRaw(rawScanEnabled);
} else {
scan = new Scan();
+// In case of first region of the HBase Table, we do not have
start-key for the region.
+// For Region Canary, we only need scan a single row/cell in the
region to make sure that
+// region is accessible.
+//
+// When HBase table has more than 1 empty regions at start of the
row-key space, Canary will
+// create multiple scan object to find first available row in the
table by scanning all the
+// regions in sequence until it can find first available row.
+//
+// This could result in multiple millions of scans based on the size
of table and number of
+// empty regions in sequence. In test environment, A table no data and
1000 empty regions,
+// Single canary run was creating close to half million to 1 million
scans to successfully
+// do canary run for the table.
+//
+// Since First region of the table doesn't have any start key, We
should set End Key as
+// stop row and set inclusive=false to limit scan to single region
only.
Review Comment:
We could even add a comment that we think this would be the better approach
for all regions (not only the first region of the table), but who knows what
performance people may expect from the canary, and whether they are counting on
most Get requests (now Scans) not returning any data, and therefore performing
extra fast (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936880717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 50s | branch-2 passed | | +1 :green_heart: | compile | 3m 10s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 51s | branch-2 passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 11s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 3m 11s | the patch passed | | +1 :green_heart: | javac | 3m 11s | the patch passed | | +1 :green_heart: | checkstyle | 0m 50s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 9m 26s | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml | | uname | Linux e18eeeae0fc4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/5/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936866780 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 14s | branch-2 passed | | +1 :green_heart: | compile | 1m 1s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 23s | hbase-client in the patch passed. | | -1 :x: | unit | 220m 45s | hbase-server in the patch failed. | | | | 251m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 70015767739b 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/testReport/ | | Max. process+thread count | 4166 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936866875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 10s | branch-2 passed | | +1 :green_heart: | compile | 1m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 6s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 5m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 13s | hbase-client in the patch passed. | | -1 :x: | unit | 215m 59s | hbase-server in the patch failed. | | | | 251m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux febd74e4d67f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/testReport/ | | Max. process+thread count | 4503 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers [hbase]
Apache-HBase commented on PR #5675: URL: https://github.com/apache/hbase/pull/5675#issuecomment-1936863167 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 1s | master passed | | +1 :green_heart: | compile | 2m 33s | master passed | | +1 :green_heart: | checkstyle | 0m 38s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 33s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 44s | the patch passed | | +1 :green_heart: | compile | 2m 27s | the patch passed | | +1 :green_heart: | javac | 2m 27s | the patch passed | | +1 :green_heart: | checkstyle | 0m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 49s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 28m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5675/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5675 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux c623837cefdc 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b3ffc4acb6 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5675/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28204 : Canary can take lot more time If any region (except the first region) starts with delete markers [hbase]
virajjasani commented on code in PR #5675:
URL: https://github.com/apache/hbase/pull/5675#discussion_r1484947970
##
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java:
##
@@ -510,19 +510,38 @@ public Void call() {
private Void readColumnFamily(Table table, ColumnFamilyDescriptor column) {
byte[] startKey = null;
- Get get = null;
Scan scan = null;
ResultScanner rs = null;
StopWatch stopWatch = new StopWatch();
startKey = region.getStartKey();
// Can't do a get on empty start row so do a Scan of first element if
any instead.
if (startKey.length > 0) {
-get = new Get(startKey);
+Get get = new Get(startKey);
get.setCacheBlocks(false);
get.setFilter(new FirstKeyOnlyFilter());
get.addFamily(column.getName());
+// Converting get object to scan to enable RAW SCAN.
+// This will work for all the regions of the HBase tables except first
region of the table.
+scan = new Scan(get);
+scan.setRaw(rawScanEnabled);
} else {
scan = new Scan();
+// In case of first region of the HBase Table, we do not have
start-key for the region.
+// For Region Canary, we only need scan a single row/cell in the
region to make sure that
+// region is accessible.
+//
+// When HBase table has more than 1 empty regions at start of the
row-key space, Canary will
+// create multiple scan object to find first available row in the
table by scanning all the
+// regions in sequence until it can find first available row.
+//
+// This could result in multiple millions of scans based on the size
of table and number of
+// empty regions in sequence. In test environment, A table no data and
1000 empty regions,
Review Comment:
nit: A table with no data
##
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java:
##
@@ -510,19 +510,38 @@ public Void call() {
private Void readColumnFamily(Table table, ColumnFamilyDescriptor column) {
byte[] startKey = null;
- Get get = null;
Scan scan = null;
ResultScanner rs = null;
StopWatch stopWatch = new StopWatch();
startKey = region.getStartKey();
// Can't do a get on empty start row so do a Scan of first element if
any instead.
if (startKey.length > 0) {
-get = new Get(startKey);
+Get get = new Get(startKey);
get.setCacheBlocks(false);
get.setFilter(new FirstKeyOnlyFilter());
get.addFamily(column.getName());
+// Converting get object to scan to enable RAW SCAN.
+// This will work for all the regions of the HBase tables except first
region of the table.
+scan = new Scan(get);
+scan.setRaw(rawScanEnabled);
} else {
scan = new Scan();
+// In case of first region of the HBase Table, we do not have
start-key for the region.
+// For Region Canary, we only need scan a single row/cell in the
region to make sure that
Review Comment:
nit: we only need to scan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-28204) Canary can take lot more time If any region (except the first region) starts with delete markers
[ https://issues.apache.org/jira/browse/HBASE-28204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28204: --- Labels: pull-request-available (was: ) > Canary can take lot more time If any region (except the first region) starts > with delete markers > > > Key: HBASE-28204 > URL: https://issues.apache.org/jira/browse/HBASE-28204 > Project: HBase > Issue Type: Bug > Components: canary >Reporter: Mihir Monani >Assignee: Mihir Monani >Priority: Major > Labels: pull-request-available > Fix For: 2.4.18, 2.7.0, 2.5.8, 3.0.0-beta-2 > > > In CanaryTool.java, Canary reads only the first row of the region using > [Get|https://github.com/apache/hbase/blob/23c41560d58cc1353b8a466deacd02dfee9e6743/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L520C33-L520C33] > for any region of the table. Canary uses [Scan with FirstRowKeyFilter for > table > scan|https://github.com/apache/hbase/blob/23c41560d58cc1353b8a466deacd02dfee9e6743/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L530] > If the said region has empty start key (This will only happen when region is > the first region for a table) > With -[HBASE-16091|https://issues.apache.org/jira/browse/HBASE-16091]- > RawScan was > [implemented|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L519-L534] > to improve performance for regions which can have high number of delete > markers. Based on currently implementation, [RawScan is only > enabled|https://github.com/apache/hbase/blob/23c41560d58cc1353b8a466deacd02dfee9e6743/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L519] > if region has empty start-key (or region is first region for the table). > RawScan doesn't work for rest of the regions in the table except first > region. Also If the region has all the rows or majority of the rows with > delete markers, Get Operation can take a lot of time. This is can cause > timeouts for CanaryTool. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-28355) Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit
[ https://issues.apache.org/jira/browse/HBASE-28355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28355. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. > Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit > -- > > Key: HBASE-28355 > URL: https://issues.apache.org/jira/browse/HBASE-28355 > Project: HBase > Issue Type: Task > Components: dependabot, scripts, security >Reporter: Duo Zhang >Priority: Major > Labels: pull-request-available > Fix For: 3.0.0-beta-2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28355) Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit
[ https://issues.apache.org/jira/browse/HBASE-28355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28355: --- Labels: pull-request-available (was: ) > Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit > -- > > Key: HBASE-28355 > URL: https://issues.apache.org/jira/browse/HBASE-28355 > Project: HBase > Issue Type: Task > Components: dependabot, scripts, security >Reporter: Duo Zhang >Priority: Major > Labels: pull-request-available > Fix For: 3.0.0-beta-2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28355 Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit [hbase]
Apache9 merged PR #5663: URL: https://github.com/apache/hbase/pull/5663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-28355) Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit
Duo Zhang created HBASE-28355: - Summary: Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit Key: HBASE-28355 URL: https://issues.apache.org/jira/browse/HBASE-28355 Project: HBase Issue Type: Task Components: dependabot, scripts, security Reporter: Duo Zhang Fix For: 3.0.0-beta-2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache9 commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936828829 AsyncProcess is a nightmare... Hope we could get 3.0.0 out soon and start to use the new client implementation... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28340 Add trust/key store type to ZK TLS settings handled by HBase [hbase]
Apache9 commented on PR #5669: URL: https://github.com/apache/hbase/pull/5669#issuecomment-1936826387 Seems OK. Is this just a POC or it is nearly the final workable PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26849) NPE caused by WAL Compression and Replication
[ https://issues.apache.org/jira/browse/HBASE-26849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816268#comment-17816268 ] tianhang tang commented on HBASE-26849: --- Hi [~bbeaudreault] thank you for ping me. AFAIK yes, last year duo has done some refactor and this issue was solved. +1 to remove the warning. > NPE caused by WAL Compression and Replication > - > > Key: HBASE-26849 > URL: https://issues.apache.org/jira/browse/HBASE-26849 > Project: HBase > Issue Type: Bug > Components: Replication, wal >Affects Versions: 1.7.1, 3.0.0-alpha-2, 2.4.11 >Reporter: tianhang tang >Assignee: tianhang tang >Priority: Critical > Attachments: image-2022-03-16-14-25-49-276.png, > image-2022-03-16-14-30-15-247.png > > > My cluster uses HBase 1.4.12, opened WAL compression and replication. > I could found replication sizeOfLogQueue backlog, and after some debugs, > found the NPE throwed by > [https://github.com/apache/hbase/blob/branch-1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/LRUDictionary.java#L109:] > !image-2022-03-16-14-25-49-276.png! > > The root cause for this problem is: > WALEntryStream#checkAllBytesParsed: > !image-2022-03-16-14-30-15-247.png! > resetReader does not create a new reader, the original CompressionContext and > the dict in it will still be retained. > However, at this time, the position is reset to 0, which means that the HLog > needs to be read from the beginning, but the cache that has not been cleared > is still used, so there will be problems: the same data has already in the > LRUCache, and it will be directly added to the cache again. > Recreate a new reader here, the problem is solved. > I will open a PR later. But, there are some other places in the current code > to resetReader or seekOnFs. I guess these codes doesn't take into account the > wal compression case at all... > > In theory, as long as the file is read again, the LRUCache should also be > rolled back, otherwise there will be inconsistent behavior of READ and WRITE > links. > But the position can be roll back to any intermediate position at will, but > LRUCache can't... -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936793996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 41s | branch-2 passed | | +1 :green_heart: | compile | 3m 15s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 49s | branch-2 passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 11s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 3m 14s | the patch passed | | +1 :green_heart: | javac | 3m 14s | the patch passed | | +1 :green_heart: | checkstyle | 0m 47s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 9m 27s | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml | | uname | Linux efdaaf055a2b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/4/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936779261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 8s | branch-2 passed | | +1 :green_heart: | compile | 1m 11s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 47s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 1m 13s | the patch passed | | +1 :green_heart: | javac | 1m 13s | the patch passed | | +1 :green_heart: | shadedjars | 5m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 17s | hbase-client in the patch passed. | | -1 :x: | unit | 264m 7s | hbase-server in the patch failed. | | | | 299m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9b37f247ca35 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/testReport/ | | Max. process+thread count | 4339 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28341 [JDK17] Fix Failure TestLdapHttpServer [hbase]
Apache-HBase commented on PR #5672: URL: https://github.com/apache/hbase/pull/5672#issuecomment-1936771668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 49s | master passed | | +1 :green_heart: | compile | 1m 42s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 29s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 1m 40s | the patch passed | | +1 :green_heart: | javac | 1m 40s | the patch passed | | +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 25s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 372m 59s | root in the patch failed. | | | | 401m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5672 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6753cce2f303 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/testReport/ | | Max. process+thread count | 5263 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: Add support for decommissioning RegionServers by hostname only [hbase]
Apache-HBase commented on PR #5667: URL: https://github.com/apache/hbase/pull/5667#issuecomment-1936766888 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 44s | master passed | | +1 :green_heart: | compile | 2m 8s | master passed | | +1 :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 25s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 27s | the patch passed | | +1 :green_heart: | compile | 2m 9s | the patch passed | | +1 :green_heart: | javac | 2m 9s | the patch passed | | +1 :green_heart: | shadedjars | 5m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 30s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 20s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 37s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 240m 11s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 6m 40s | hbase-thrift in the patch passed. | | | | 277m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5667 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2bfd4c65381e 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/4/testReport/ | | Max. process+thread count | 5208 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server hbase-thrift U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: Add support for decommissioning RegionServers by hostname only [hbase]
Apache-HBase commented on PR #5667: URL: https://github.com/apache/hbase/pull/5667#issuecomment-1936757334 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 55s | master passed | | +1 :green_heart: | compile | 2m 8s | master passed | | +1 :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 22s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 2m 10s | the patch passed | | +1 :green_heart: | javac | 2m 10s | the patch passed | | +1 :green_heart: | shadedjars | 5m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 34s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 26s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 40s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 222m 21s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 7m 21s | hbase-thrift in the patch passed. | | | | 261m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5667 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 92feb36adbbd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/4/testReport/ | | Max. process+thread count | 5008 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server hbase-thrift U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/4/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936756380 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 14s | branch-2 passed | | +1 :green_heart: | compile | 1m 2s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 4m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 30s | hbase-client in the patch passed. | | -1 :x: | unit | 223m 54s | hbase-server in the patch failed. | | | | 254m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d3704dc0641f 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/testReport/ | | Max. process+thread count | 4025 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28341 [JDK17] Fix Failure TestLdapHttpServer [hbase]
Apache-HBase commented on PR #5672: URL: https://github.com/apache/hbase/pull/5672#issuecomment-1936724970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | master passed | | +1 :green_heart: | compile | 1m 59s | master passed | | +1 :green_heart: | shadedjars | 5m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 54s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 43s | the patch passed | | +1 :green_heart: | compile | 1m 58s | the patch passed | | +1 :green_heart: | javac | 1m 58s | the patch passed | | +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 293m 1s | root in the patch passed. | | | | 323m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5672 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 393f10cb7ccf 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/testReport/ | | Max. process+thread count | 8451 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test
[
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816215#comment-17816215
]
Hudson commented on HBASE-28329:
Results for branch branch-2
[build #984 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
> Issue Type: Task
> Components: jenkins, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> So we can see them in the job artifacts, currently it will be logged to hbase
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not
> start hbase cluster, we need the logs to find out the root cause.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28337) Positive connection test in TestShadeSaslAuthenticationProvider runs with Kerberos instead of Shade authentication
[
https://issues.apache.org/jira/browse/HBASE-28337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816214#comment-17816214
]
Hudson commented on HBASE-28337:
Results for branch branch-2.6
[build #52 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Positive connection test in TestShadeSaslAuthenticationProvider runs with
> Kerberos instead of Shade authentication
> --
>
> Key: HBASE-28337
> URL: https://issues.apache.org/jira/browse/HBASE-28337
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 2.5.7, 2.7.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 2.5.8, 3.0.0-beta-2
>
>
> The positive test (testPositiveAuthentication) in
> TestShadeSaslAuthenticationProvider doesn't create a new user in
> user1.doAs(), so it will use the already Kerberos authenticated user instead
> of re-authenticating with the token.
> As a consequence it doesn't reveal a problem introduced with HBASE-23881
> which will cause clients to timeout if authenticated with a SASL mech which
> doesn't create a reply token in case of successful authentication.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test
[
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816213#comment-17816213
]
Hudson commented on HBASE-28329:
Results for branch branch-2.6
[build #52 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/52//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
> Issue Type: Task
> Components: jenkins, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> So we can see them in the job artifacts, currently it will be logged to hbase
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not
> start hbase cluster, we need the logs to find out the root cause.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28337) Positive connection test in TestShadeSaslAuthenticationProvider runs with Kerberos instead of Shade authentication
[
https://issues.apache.org/jira/browse/HBASE-28337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816216#comment-17816216
]
Hudson commented on HBASE-28337:
Results for branch branch-2
[build #984 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/984//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Positive connection test in TestShadeSaslAuthenticationProvider runs with
> Kerberos instead of Shade authentication
> --
>
> Key: HBASE-28337
> URL: https://issues.apache.org/jira/browse/HBASE-28337
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 2.5.7, 2.7.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 2.5.8, 3.0.0-beta-2
>
>
> The positive test (testPositiveAuthentication) in
> TestShadeSaslAuthenticationProvider doesn't create a new user in
> user1.doAs(), so it will use the already Kerberos authenticated user instead
> of re-authenticating with the token.
> As a consequence it doesn't reveal a problem introduced with HBASE-23881
> which will cause clients to timeout if authenticated with a SASL mech which
> doesn't create a reply token in case of successful authentication.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] WIP: Add support for decommissioning RegionServers by hostname only [hbase]
Apache-HBase commented on PR #5667: URL: https://github.com/apache/hbase/pull/5667#issuecomment-1936563852 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 56s | master passed | | +1 :green_heart: | compile | 4m 22s | master passed | | +1 :green_heart: | checkstyle | 1m 26s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 21s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 42s | the patch passed | | +1 :green_heart: | compile | 4m 48s | the patch passed | | +1 :green_heart: | cc | 4m 48s | the patch passed | | +1 :green_heart: | javac | 4m 48s | the patch passed | | +1 :green_heart: | checkstyle | 1m 59s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 28s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | hbaseprotoc | 1m 39s | the patch passed | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 6m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. | | | | 46m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5667 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux 6455a6298e7c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 81 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server hbase-thrift U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/4/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28349) Atomic requests should increment read usage in quotas
[
https://issues.apache.org/jira/browse/HBASE-28349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816210#comment-17816210
]
Hudson commented on HBASE-28349:
Results for branch master
[build #1009 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1009/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1009/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1009/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1009/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Atomic requests should increment read usage in quotas
> -
>
> Key: HBASE-28349
> URL: https://issues.apache.org/jira/browse/HBASE-28349
> Project: HBase
> Issue Type: Improvement
>Reporter: Ray Mattingly
>Assignee: Ray Mattingly
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> Right now atomic operations are just treated as a single write from the quota
> perspective. Since an atomic operation also encompasses a read, it would make
> sense to increment readNum and readSize counts appropriately.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-26849) NPE caused by WAL Compression and Replication
[ https://issues.apache.org/jira/browse/HBASE-26849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816207#comment-17816207 ] Bryan Beaudreault commented on HBASE-26849: --- [~tangtianhang] I have been looking at this again. I don't think this bug applies to branch-2 today, at least not in the way you describe. Back in HBASE-27632, Duo did a bunch of refactoring. There is a new flow now, where we set state to ERROR_AND_RESET_COMPRESSION when setting position back to 0. This state is handled and a call to reader.resetTo is made, which includes a boolean (true when the above state is set) which ensures that the CompressionContext is cleared. I have not run this myself yet, but hope to work through it soon. I think we should probably remove the warning from our guide > NPE caused by WAL Compression and Replication > - > > Key: HBASE-26849 > URL: https://issues.apache.org/jira/browse/HBASE-26849 > Project: HBase > Issue Type: Bug > Components: Replication, wal >Affects Versions: 1.7.1, 3.0.0-alpha-2, 2.4.11 >Reporter: tianhang tang >Assignee: tianhang tang >Priority: Critical > Attachments: image-2022-03-16-14-25-49-276.png, > image-2022-03-16-14-30-15-247.png > > > My cluster uses HBase 1.4.12, opened WAL compression and replication. > I could found replication sizeOfLogQueue backlog, and after some debugs, > found the NPE throwed by > [https://github.com/apache/hbase/blob/branch-1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/LRUDictionary.java#L109:] > !image-2022-03-16-14-25-49-276.png! > > The root cause for this problem is: > WALEntryStream#checkAllBytesParsed: > !image-2022-03-16-14-30-15-247.png! > resetReader does not create a new reader, the original CompressionContext and > the dict in it will still be retained. > However, at this time, the position is reset to 0, which means that the HLog > needs to be read from the beginning, but the cache that has not been cleared > is still used, so there will be problems: the same data has already in the > LRUCache, and it will be directly added to the cache again. > Recreate a new reader here, the problem is solved. > I will open a PR later. But, there are some other places in the current code > to resetReader or seekOnFs. I guess these codes doesn't take into account the > wal compression case at all... > > In theory, as long as the file is read again, the LRUCache should also be > rolled back, otherwise there will be inconsistent behavior of READ and WRITE > links. > But the position can be roll back to any intermediate position at will, but > LRUCache can't... -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936553556 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 47s | branch-2 passed | | +1 :green_heart: | compile | 3m 14s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 47s | branch-2 passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 13s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 52s | the patch passed | | +1 :green_heart: | compile | 3m 12s | the patch passed | | +1 :green_heart: | javac | 3m 12s | the patch passed | | +1 :green_heart: | checkstyle | 0m 49s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 9m 33s | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml | | uname | Linux 46c513fa1f88 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936505204 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 33s | branch-2 passed | | +1 :green_heart: | compile | 0m 38s | branch-2 passed | | +1 :green_heart: | shadedjars | 8m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 0m 29s | the patch passed | | +1 :green_heart: | javac | 0m 29s | the patch passed | | +1 :green_heart: | shadedjars | 7m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 3s | hbase-client in the patch passed. | | | | 38m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 939af9484810 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/testReport/ | | Max. process+thread count | 366 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: Add support for decommissioning RegionServers by hostname only [hbase]
Apache-HBase commented on PR #5667: URL: https://github.com/apache/hbase/pull/5667#issuecomment-1936503671 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 25s | master passed | | +1 :green_heart: | compile | 2m 58s | master passed | | +1 :green_heart: | shadedjars | 7m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 45s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 17s | the patch passed | | +1 :green_heart: | compile | 2m 49s | the patch passed | | +1 :green_heart: | javac | 2m 49s | the patch passed | | +1 :green_heart: | shadedjars | 6m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 51s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 2m 16s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 243m 15s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 7m 24s | hbase-thrift in the patch passed. | | | | 291m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5667 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c0c2ebe68d1e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/testReport/ | | Max. process+thread count | 5527 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936487929 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 26s | branch-2 passed | | +1 :green_heart: | compile | 0m 20s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 18s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | shadedjars | 4m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 25s | hbase-client in the patch passed. | | | | 24m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 22e92c1f3565 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/testReport/ | | Max. process+thread count | 354 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
Apache-HBase commented on PR #5671: URL: https://github.com/apache/hbase/pull/5671#issuecomment-1936486053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 10s | branch-2 passed | | +1 :green_heart: | compile | 0m 43s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 18s | branch-2 passed | | +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 48s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 0m 42s | the patch passed | | -0 :warning: | javac | 0m 42s | hbase-client generated 1 new + 108 unchanged - 0 fixed = 109 total (was 108) | | +1 :green_heart: | checkstyle | 0m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 9m 31s | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 23m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5671 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux c7c9d15e9ece 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / d5aefbc352 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt | | Max. process+thread count | 76 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5671/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: Add support for decommissioning RegionServers by hostname only [hbase]
Apache-HBase commented on PR #5667: URL: https://github.com/apache/hbase/pull/5667#issuecomment-1936485736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 1m 54s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 11s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 31s | the patch passed | | +1 :green_heart: | compile | 1m 55s | the patch passed | | +1 :green_heart: | javac | 1m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 31s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 19s | hbase-client in the patch passed. | | -1 :x: | unit | 242m 4s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 6m 36s | hbase-thrift in the patch passed. | | | | 277m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5667 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6f2c02657c13 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/testReport/ | | Max. process+thread count | 5163 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28352 HTable batch does not honor RpcThrottlingException waitInterval [hbase]
bbeaudreault commented on code in PR #5671:
URL: https://github.com/apache/hbase/pull/5671#discussion_r1484706528
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -842,6 +849,18 @@ private void resubmit(ServerName oldServer, List
toReplay, int numAttemp
backOffTime, true, null, -1, -1));
}
+long remainingTime = getRemainingTime();
+// 1 is a special value meaning exceeded and 0 means no timeout
+if (remainingTime > 1 && backOffTime > remainingTime) {
Review Comment:
I added this handling here as well. We have similar logic in
RpcRetryingCallerImpl. I think it's important to add when adding throttling
wait interval, because depending on the level of quota saturation the wait time
could easily be higher than operation timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-28349) Atomic requests should increment read usage in quotas
[
https://issues.apache.org/jira/browse/HBASE-28349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816185#comment-17816185
]
Hudson commented on HBASE-28349:
Results for branch branch-3
[build #144 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/144/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/144/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/144/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/144/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Atomic requests should increment read usage in quotas
> -
>
> Key: HBASE-28349
> URL: https://issues.apache.org/jira/browse/HBASE-28349
> Project: HBase
> Issue Type: Improvement
>Reporter: Ray Mattingly
>Assignee: Ray Mattingly
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> Right now atomic operations are just treated as a single write from the quota
> perspective. Since an atomic operation also encompasses a read, it would make
> sense to increment readNum and readSize counts appropriately.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28341 [JDK17] Fix Failure TestLdapHttpServer [hbase]
Apache-HBase commented on PR #5672: URL: https://github.com/apache/hbase/pull/5672#issuecomment-1936401979 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | master passed | | +1 :green_heart: | compile | 5m 11s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 57s | the patch passed | | +1 :green_heart: | compile | 5m 1s | the patch passed | | +1 :green_heart: | javac | 5m 1s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 5m 24s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 30m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5672 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux c6149651c536 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 77 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28344) Flush journal logs are missing from 2.x
[ https://issues.apache.org/jira/browse/HBASE-28344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816173#comment-17816173 ] Viraj Jasani commented on HBASE-28344: -- Applicable to master branch also? > Flush journal logs are missing from 2.x > > > Key: HBASE-28344 > URL: https://issues.apache.org/jira/browse/HBASE-28344 > Project: HBase > Issue Type: Improvement >Reporter: Prathyusha >Assignee: Prathyusha >Priority: Minor > > After refactoring of TaskMonitor from branch > [1|https://git.soma.salesforce.com/bigdata-packaging/hbase/blob/efc1e0bb2bdfe46d07b1ae38692d616c02efe85d/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87] > to > [2|https://git.soma.salesforce.com/bigdata-packaging/hbase/blob/efc1e0bb2bdfe46d07b1ae38692d616c02efe85d/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87] > Flush journal logs are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
Apache-HBase commented on PR #5674: URL: https://github.com/apache/hbase/pull/5674#issuecomment-1936375106 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | branch-2.5 passed | | +1 :green_heart: | compile | 0m 31s | branch-2.5 passed | | +1 :green_heart: | shadedjars | 7m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 0m 29s | the patch passed | | +1 :green_heart: | javac | 0m 29s | the patch passed | | +1 :green_heart: | shadedjars | 6m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 9s | hbase-it in the patch passed. | | | | 26m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5674/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5674 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3ace97fe0228 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / e4ec37d11d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5674/1/testReport/ | | Max. process+thread count | 841 (vs. ulimit of 3) | | modules | C: hbase-it U: hbase-it | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5674/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
Apache-HBase commented on PR #5674: URL: https://github.com/apache/hbase/pull/5674#issuecomment-1936368226 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.5 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 52s | branch-2.5 passed | | +1 :green_heart: | compile | 0m 27s | branch-2.5 passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 14m 12s | Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 24m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5674/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5674 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux 3f9c134a0f6e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / e4ec37d11d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-it U: hbase-it | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5674/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
Apache-HBase commented on PR #5674: URL: https://github.com/apache/hbase/pull/5674#issuecomment-1936352998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 32s | branch-2.5 passed | | +1 :green_heart: | compile | 0m 15s | branch-2.5 passed | | +1 :green_heart: | shadedjars | 4m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 11s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 0m 15s | the patch passed | | +1 :green_heart: | javac | 0m 15s | the patch passed | | +1 :green_heart: | shadedjars | 4m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 49s | hbase-it in the patch passed. | | | | 18m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5674/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5674 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7ff770b26c05 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / e4ec37d11d | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5674/1/testReport/ | | Max. process+thread count | 798 (vs. ulimit of 3) | | modules | C: hbase-it U: hbase-it | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5674/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28028) Read all compressed bytes to a byte array before submitting them to decompressor
[ https://issues.apache.org/jira/browse/HBASE-28028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816167#comment-17816167 ] Bryan Beaudreault commented on HBASE-28028: --- [~Xiaolin Ha] I know it's been a while – any update on your tests in your clusters? I'm looking to start enabling in mine as well, where we also use replication. > Read all compressed bytes to a byte array before submitting them to > decompressor > > > Key: HBASE-28028 > URL: https://issues.apache.org/jira/browse/HBASE-28028 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.6.0, 2.5.6, 3.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28341 [JDK17] Fix Failure TestLdapHttpServer [hbase]
chrajeshbabu commented on PR #5672: URL: https://github.com/apache/hbase/pull/5672#issuecomment-1936325123 Fixed spotless errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
NihalJain commented on PR #5674: URL: https://github.com/apache/hbase/pull/5674#issuecomment-1936316251 Backport #5625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
NihalJain opened a new pull request, #5674: URL: https://github.com/apache/hbase/pull/5674 … due to NCDFE: com/sun/jersey/core/util/FeaturesAndProperties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28311) Few ITs (using MiniMRYarnCluster on hadoop-2) are failing due to NCDFE: com/sun/jersey/core/util/FeaturesAndProperties
[
https://issues.apache.org/jira/browse/HBASE-28311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28311:
---
Fix Version/s: 2.6.0
> Few ITs (using MiniMRYarnCluster on hadoop-2) are failing due to NCDFE:
> com/sun/jersey/core/util/FeaturesAndProperties
> --
>
> Key: HBASE-28311
> URL: https://issues.apache.org/jira/browse/HBASE-28311
> Project: HBase
> Issue Type: Bug
> Components: integration tests, test
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.7.0
>
>
> Found this while trying to run tests for HBASE-28301 locally, On branch-2
> where hadoop 2 is default, the specified tests don't even run as
> MiniMRYarnCluster itself fails to start.
> For example saw this while trying to run IntegrationTestImportTsv:
> {code:java}
> 2024-01-12T01:10:13,486 ERROR [Thread-221 {}] log.Slf4jLog(87): Error
> starting handlers
> java.lang.NoClassDefFoundError: com/sun/jersey/core/util/FeaturesAndProperties
> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]
> at java.security.AccessController.doPrivileged(Native Method)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]
> at java.security.AccessController.doPrivileged(Native Method)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]
> at java.security.AccessController.doPrivileged(Native Method)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]
> at java.lang.Class.getDeclaredConstructors0(Native Method) ~[?:1.8.0_381]
> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
> ~[?:1.8.0_381]
> at java.lang.Class.getDeclaredConstructors(Class.java:2020) ~[?:1.8.0_381]
> at
> com.google.inject.spi.InjectionPoint.forConstructorOf(InjectionPoint.java:243)
> ~[guice-3.0.jar:?]
> at
> com.google.inject.internal.ConstructorBindingImpl.create(ConstructorBindingImpl.java:96)
> ~[guice-3.0.jar:?]
> at
> com.google.inject.internal.InjectorImpl.createUninitializedBinding(InjectorImpl.java:629)
> ~[guice-3.0.jar:?]
> at
> com.google.inject.internal.InjectorImpl.createJustInT
Re: [PR] WIP: Add support for decommissioning RegionServers by hostname only [hbase]
Apache-HBase commented on PR #5667: URL: https://github.com/apache/hbase/pull/5667#issuecomment-1936143809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 1s | master passed | | +1 :green_heart: | compile | 4m 7s | master passed | | +1 :green_heart: | checkstyle | 1m 24s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 1s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 45s | the patch passed | | +1 :green_heart: | compile | 4m 58s | the patch passed | | +1 :green_heart: | cc | 4m 58s | the patch passed | | +1 :green_heart: | javac | 4m 58s | the patch passed | | +1 :green_heart: | checkstyle | 1m 21s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 4s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | hbaseprotoc | 1m 30s | the patch passed | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 45m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5667 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux 0bc7a2f55460 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5667/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]
Apache9 commented on code in PR #5607: URL: https://github.com/apache/hbase/pull/5607#discussion_r1484456548 ## hbase-assembly/src/main/assembly/hadoop-three-compat.xml: ## @@ -115,6 +115,13 @@ junit:junit org.hamcrest:hamcrest-core org.mockito:mockito-core + Review Comment: Then we could just exclude them in the dependencyManagement or dependencies section in our pom file? We need to them in tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-28349) Atomic requests should increment read usage in quotas
[ https://issues.apache.org/jira/browse/HBASE-28349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-28349. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Release Note: Conditional atomic mutations which involve a read-modify-write (increment/append) or check-and-mutate, will now count as both a read and write when evaluating quotas. Previously they would just count as a write, despite involving a read as well. Resolution: Fixed > Atomic requests should increment read usage in quotas > - > > Key: HBASE-28349 > URL: https://issues.apache.org/jira/browse/HBASE-28349 > Project: HBase > Issue Type: Improvement >Reporter: Ray Mattingly >Assignee: Ray Mattingly >Priority: Major > Labels: pull-request-available > Fix For: 2.6.0, 3.0.0-beta-2 > > > Right now atomic operations are just treated as a single write from the quota > perspective. Since an atomic operation also encompasses a read, it would make > sense to increment readNum and readSize counts appropriately. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28354) RegionSizeCalculator throws NPE when regions are in transition
Bryan Beaudreault created HBASE-28354: - Summary: RegionSizeCalculator throws NPE when regions are in transition Key: HBASE-28354 URL: https://issues.apache.org/jira/browse/HBASE-28354 Project: HBase Issue Type: Bug Reporter: Bryan Beaudreault When a region is in transition, it may briefly have a null ServerName in meta. The RegionSizeCalculator calls RegionLocator.getAllRegionLocations() and does not handle the possibility that a RegionLocation.getServerName() could be null. The ServerName is eventually passed into an Admin call, which results in an NPE. This has come up in other contexts. For example, taking a look at getAllRegionLocations() impl, we have checks to ensure that we don't call null server names. We need to similarly handle the possibility of nulls in RegionSizeCalculator. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Backport "HBASE-28349 Count atomic operations against read quotas" to branch-2 [hbase]
bbeaudreault merged PR #5670: URL: https://github.com/apache/hbase/pull/5670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28341 [JDK17] Fix Failure TestLdapHttpServer [hbase]
Apache-HBase commented on PR #5672: URL: https://github.com/apache/hbase/pull/5672#issuecomment-1935749725 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | master passed | | +1 :green_heart: | compile | 2m 25s | master passed | | +1 :green_heart: | shadedjars | 7m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 48s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 1s | the patch passed | | +1 :green_heart: | compile | 1m 54s | the patch passed | | +1 :green_heart: | javac | 1m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 21s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 359m 26s | root in the patch failed. | | | | 392m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5672 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e09b25114639 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/1/testReport/ | | Max. process+thread count | 5475 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28311) Few ITs (using MiniMRYarnCluster on hadoop-2) are failing due to NCDFE: com/sun/jersey/core/util/FeaturesAndProperties
[
https://issues.apache.org/jira/browse/HBASE-28311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nihal Jain updated HBASE-28311:
---
Fix Version/s: 2.7.0
> Few ITs (using MiniMRYarnCluster on hadoop-2) are failing due to NCDFE:
> com/sun/jersey/core/util/FeaturesAndProperties
> --
>
> Key: HBASE-28311
> URL: https://issues.apache.org/jira/browse/HBASE-28311
> Project: HBase
> Issue Type: Bug
> Components: integration tests, test
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.0
>
>
> Found this while trying to run tests for HBASE-28301 locally, On branch-2
> where hadoop 2 is default, the specified tests don't even run as
> MiniMRYarnCluster itself fails to start.
> For example saw this while trying to run IntegrationTestImportTsv:
> {code:java}
> 2024-01-12T01:10:13,486 ERROR [Thread-221 {}] log.Slf4jLog(87): Error
> starting handlers
> java.lang.NoClassDefFoundError: com/sun/jersey/core/util/FeaturesAndProperties
> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]
> at java.security.AccessController.doPrivileged(Native Method)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]
> at java.security.AccessController.doPrivileged(Native Method)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]
> at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]
> at java.security.AccessController.doPrivileged(Native Method)
> ~[?:1.8.0_381]
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)
> ~[?:1.8.0_381]
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]
> at java.lang.Class.getDeclaredConstructors0(Native Method) ~[?:1.8.0_381]
> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
> ~[?:1.8.0_381]
> at java.lang.Class.getDeclaredConstructors(Class.java:2020) ~[?:1.8.0_381]
> at
> com.google.inject.spi.InjectionPoint.forConstructorOf(InjectionPoint.java:243)
> ~[guice-3.0.jar:?]
> at
> com.google.inject.internal.ConstructorBindingImpl.create(ConstructorBindingImpl.java:96)
> ~[guice-3.0.jar:?]
> at
> com.google.inject.internal.InjectorImpl.createUninitializedBinding(InjectorImpl.java:629)
> ~[guice-3.0.jar:?]
> at
> com.google.inject.internal.InjectorImpl.createJustInTimeBind
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
NihalJain merged PR #5625: URL: https://github.com/apache/hbase/pull/5625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]
NihalJain commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1935681283 Ping @Apache9, any thoughts on this change/approach? Failures are not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-28344) Flush journal logs are missing from 2.x
[ https://issues.apache.org/jira/browse/HBASE-28344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranganath Govardhanagiri reassigned HBASE-28344: Assignee: Prathyusha (was: Ranganath Govardhanagiri) > Flush journal logs are missing from 2.x > > > Key: HBASE-28344 > URL: https://issues.apache.org/jira/browse/HBASE-28344 > Project: HBase > Issue Type: Improvement >Reporter: Prathyusha >Assignee: Prathyusha >Priority: Minor > > After refactoring of TaskMonitor from branch > [1|https://git.soma.salesforce.com/bigdata-packaging/hbase/blob/efc1e0bb2bdfe46d07b1ae38692d616c02efe85d/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87] > to > [2|https://git.soma.salesforce.com/bigdata-packaging/hbase/blob/efc1e0bb2bdfe46d07b1ae38692d616c02efe85d/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87] > Flush journal logs are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28353 Close HBase connection on implicit exit from HBase shell [hbase]
Apache-HBase commented on PR #5673: URL: https://github.com/apache/hbase/pull/5673#issuecomment-1935645263 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | master passed | | +1 :green_heart: | javadoc | 0m 10s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 56s | the patch passed | | +1 :green_heart: | javadoc | 0m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 42s | hbase-shell in the patch passed. | | | | 15m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5673 | | Optional Tests | javac javadoc unit | | uname | Linux 336b4c4e0092 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/testReport/ | | Max. process+thread count | 2010 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28353 Close HBase connection on implicit exit from HBase shell [hbase]
Apache-HBase commented on PR #5673: URL: https://github.com/apache/hbase/pull/5673#issuecomment-1935644854 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 12s | master passed | | +1 :green_heart: | javadoc | 0m 12s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 44s | the patch passed | | +1 :green_heart: | javadoc | 0m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 7m 21s | hbase-shell in the patch passed. | | | | 15m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5673 | | Optional Tests | javac javadoc unit | | uname | Linux 633dfba2f517 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/testReport/ | | Max. process+thread count | 1983 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28341 [JDK17] Fix Failure TestLdapHttpServer [hbase]
Apache-HBase commented on PR #5672: URL: https://github.com/apache/hbase/pull/5672#issuecomment-1935641424 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 1s | master passed | | +1 :green_heart: | compile | 1m 57s | master passed | | +1 :green_heart: | shadedjars | 5m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 56s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 42s | the patch passed | | +1 :green_heart: | compile | 1m 57s | the patch passed | | +1 :green_heart: | javac | 1m 57s | the patch passed | | +1 :green_heart: | shadedjars | 5m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 53s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 283m 4s | root in the patch failed. | | | | 313m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5672 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f3315be84566 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/1/testReport/ | | Max. process+thread count | 7420 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5672/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28353 Close HBase connection on implicit exit from HBase shell [hbase]
Apache-HBase commented on PR #5673: URL: https://github.com/apache/hbase/pull/5673#issuecomment-1935639421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 51s | master passed | | +1 :green_heart: | spotless | 0m 56s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | the patch passed | | -0 :warning: | rubocop | 0m 5s | The patch generated 3 new + 31 unchanged - 2 fixed = 34 total (was 33) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 50s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 11m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5673 | | Optional Tests | dupname asflicense javac spotless rubocop | | uname | Linux ecd4deb35f9d 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 98eb3e01b3 | | Default Java | Eclipse Adoptium-11.0.17+8 | | rubocop | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 72 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console | | versions | git=2.34.1 maven=3.8.6 rubocop=1.37.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28353) Close HBase connection on implicit exit from HBase shell
[ https://issues.apache.org/jira/browse/HBASE-28353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28353: --- Labels: pull-request-available (was: ) > Close HBase connection on implicit exit from HBase shell > > > Key: HBASE-28353 > URL: https://issues.apache.org/jira/browse/HBASE-28353 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Labels: pull-request-available > > The fix in HBASE-28345 only works when the exit function is explicitly called. > It does not work when scripts are piped in in non-interactive mode. > Hook the connection close into Ruby at_exit instead of the exit shell command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] HBASE-28353 Close HBase connection on implicit exit from HBase shell [hbase]
stoty opened a new pull request, #5673: URL: https://github.com/apache/hbase/pull/5673 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28353) Close HBase connection on implicit exit from HBase shell
[ https://issues.apache.org/jira/browse/HBASE-28353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815990#comment-17815990 ] Istvan Toth commented on HBASE-28353: - I played around with this some more: Ctrl-C does not do anything in HBase shell. When I send a SIGINT by the "kill" command, at_exit does get called. So using at_exit does seem to fix all the ways I can think of for exiting hbase shell after all. > Close HBase connection on implicit exit from HBase shell > > > Key: HBASE-28353 > URL: https://issues.apache.org/jira/browse/HBASE-28353 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > The fix in HBASE-28345 only works when the exit function is explicitly called. > It does not work when scripts are piped in in non-interactive mode. > Hook the connection close into Ruby at_exit instead of the exit shell command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (HBASE-28353) Close HBase connection on implicit exit from HBase shell
[ https://issues.apache.org/jira/browse/HBASE-28353 ] Istvan Toth deleted comment on HBASE-28353: - was (Author: stoty): Never mind, hbase shell seems to be ignoring SIGINT anyway. > Close HBase connection on implicit exit from HBase shell > > > Key: HBASE-28353 > URL: https://issues.apache.org/jira/browse/HBASE-28353 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > The fix in HBASE-28345 only works when the exit function is explicitly called. > It does not work when scripts are piped in in non-interactive mode. > Hook the connection close into Ruby at_exit instead of the exit shell command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28353) Close HBase connection on implicit exit from HBase shell
[ https://issues.apache.org/jira/browse/HBASE-28353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815987#comment-17815987 ] Istvan Toth commented on HBASE-28353: - Never mind, hbase shell seems to be ignoring SIGINT anyway. > Close HBase connection on implicit exit from HBase shell > > > Key: HBASE-28353 > URL: https://issues.apache.org/jira/browse/HBASE-28353 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > The fix in HBASE-28345 only works when the exit function is explicitly called. > It does not work when scripts are piped in in non-interactive mode. > Hook the connection close into Ruby at_exit instead of the exit shell command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (HBASE-28353) Close HBase connection on implicit exit from HBase shell
[ https://issues.apache.org/jira/browse/HBASE-28353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815985#comment-17815985 ] Istvan Toth edited comment on HBASE-28353 at 2/9/24 9:27 AM: - at_exit works for non-interactive scripts, and ctrl-D, but it still hangs on Ctrl-C / SIGINT. Maybe we could fix that by registering a JVM shutdown hook from from ReadOnlyZKClient, but it would probably better to fix the SIGINT case in ZK. was (Author: stoty): at_exit works for non-interactive scripts, and ctrl-D, but it still hangs on Ctrl-C / SIGINT. Maybe we could fix that by registering a JVM shutdown hook from from ReadOnylZKClient, but it would probably better to fix this that ZK. > Close HBase connection on implicit exit from HBase shell > > > Key: HBASE-28353 > URL: https://issues.apache.org/jira/browse/HBASE-28353 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > The fix in HBASE-28345 only works when the exit function is explicitly called. > It does not work when scripts are piped in in non-interactive mode. > Hook the connection close into Ruby at_exit instead of the exit shell command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28353) Close HBase connection on implicit exit from HBase shell
[ https://issues.apache.org/jira/browse/HBASE-28353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815985#comment-17815985 ] Istvan Toth commented on HBASE-28353: - at_exit works for non-interactive scripts, and ctrl-D, but it still hangs on Ctrl-C / SIGINT. Maybe we could fix that by registering a JVM shutdown hook from from ReadOnylZKClient, but it would probably better to fix this that ZK. > Close HBase connection on implicit exit from HBase shell > > > Key: HBASE-28353 > URL: https://issues.apache.org/jira/browse/HBASE-28353 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > The fix in HBASE-28345 only works when the exit function is explicitly called. > It does not work when scripts are piped in in non-interactive mode. > Hook the connection close into Ruby at_exit instead of the exit shell command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28353) Close HBase connection on implicit exit from HBase shell
Istvan Toth created HBASE-28353: --- Summary: Close HBase connection on implicit exit from HBase shell Key: HBASE-28353 URL: https://issues.apache.org/jira/browse/HBASE-28353 Project: HBase Issue Type: Bug Components: shell Reporter: Istvan Toth Assignee: Istvan Toth The fix in HBASE-28345 only works when the exit function is explicitly called. It does not work when scripts are piped in in non-interactive mode. Hook the connection close into Ruby at_exit instead of the exit shell command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-28344) Flush journal logs are missing from 2.x
[ https://issues.apache.org/jira/browse/HBASE-28344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ranganath Govardhanagiri reassigned HBASE-28344: Assignee: Ranganath Govardhanagiri > Flush journal logs are missing from 2.x > > > Key: HBASE-28344 > URL: https://issues.apache.org/jira/browse/HBASE-28344 > Project: HBase > Issue Type: Improvement >Reporter: Prathyusha >Assignee: Ranganath Govardhanagiri >Priority: Minor > > After refactoring of TaskMonitor from branch > [1|https://git.soma.salesforce.com/bigdata-packaging/hbase/blob/efc1e0bb2bdfe46d07b1ae38692d616c02efe85d/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87] > to > [2|https://git.soma.salesforce.com/bigdata-packaging/hbase/blob/efc1e0bb2bdfe46d07b1ae38692d616c02efe85d/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87] > Flush journal logs are missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28337) Positive connection test in TestShadeSaslAuthenticationProvider runs with Kerberos instead of Shade authentication
[
https://issues.apache.org/jira/browse/HBASE-28337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815968#comment-17815968
]
Hudson commented on HBASE-28337:
Results for branch branch-3
[build #143 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/143/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/143/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/143/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/143/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Positive connection test in TestShadeSaslAuthenticationProvider runs with
> Kerberos instead of Shade authentication
> --
>
> Key: HBASE-28337
> URL: https://issues.apache.org/jira/browse/HBASE-28337
> Project: HBase
> Issue Type: Test
>Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 2.5.7, 2.7.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.6.0, 2.4.18, 4.0.0-alpha-1, 2.7.0, 2.5.8, 3.0.0-beta-2
>
>
> The positive test (testPositiveAuthentication) in
> TestShadeSaslAuthenticationProvider doesn't create a new user in
> user1.doAs(), so it will use the already Kerberos authenticated user instead
> of re-authenticating with the token.
> As a consequence it doesn't reveal a problem introduced with HBASE-23881
> which will cause clients to timeout if authenticated with a SASL mech which
> doesn't create a reply token in case of successful authentication.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28329) Output hbase logs to working directory in client integration test
[
https://issues.apache.org/jira/browse/HBASE-28329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815967#comment-17815967
]
Hudson commented on HBASE-28329:
Results for branch branch-3
[build #143 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/143/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/143/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/143/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/143/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Output hbase logs to working directory in client integration test
> -
>
> Key: HBASE-28329
> URL: https://issues.apache.org/jira/browse/HBASE-28329
> Project: HBase
> Issue Type: Task
> Components: jenkins, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> So we can see them in the job artifacts, currently it will be logged to hbase
> install directory which is outside the working dir so we can not see them.
> The client integration test for master branch is failing because can not
> start hbase cluster, we need the logs to find out the root cause.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
