[jira] [Commented] (HBASE-21853) update copyright notices to 2019
[ https://issues.apache.org/jira/browse/HBASE-21853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762393#comment-16762393 ] AMIT VIRMANI commented on HBASE-21853: -- LGTM. > update copyright notices to 2019 > > > Key: HBASE-21853 > URL: https://issues.apache.org/jira/browse/HBASE-21853 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-21853.0.patch > > > we've had copyrightable changes put in place since the new year, so update > the date range. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20187) Shell startup fails with IncompatibleClassChangeError
[
https://issues.apache.org/jira/browse/HBASE-20187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397214#comment-16397214
]
AMIT VIRMANI commented on HBASE-20187:
--
Thanks [~balazs.meszaros],
could you update the code comment also, pls
{code:java}
if ! $in_dev_env; then # in dev environment{code}
> Shell startup fails with IncompatibleClassChangeError
> -
>
> Key: HBASE-20187
> URL: https://issues.apache.org/jira/browse/HBASE-20187
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Peter Somogyi
>Assignee: Balazs Meszaros
>Priority: Blocker
> Attachments: HBASE-20187.branch-2.001.patch
>
>
> Starting shell fails with a jline exception.
> Before {{2402f1fd43 - HBASE-20108 Remove jline exclusion from ZooKeeper}} the
> shell starts up.
> {noformat}
> $ ./bin/hbase shell
> 2018-03-13 13:56:58,975 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> HBase Shell
> Use "help" to get list of supported commands.
> Use "exit" to quit this interactive shell.
> Version 2.0.0-beta-2, rc998e8d5f9ca3013d175ed447116c0734192f36c, Tue Mar 13
> 13:49:59 CET 2018
> [ERROR] Terminal initialization failed; falling back to unsupported
> java.lang.IncompatibleClassChangeError: Found class jline.Terminal, but
> interface was expected
> at jline.TerminalFactory.create(TerminalFactory.java:101)
> at jline.TerminalFactory.get(TerminalFactory.java:159)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(JavaMethod.java:438)
> at
> org.jruby.javasupport.JavaMethod.invokeStaticDirect(JavaMethod.java:360)
> at
> org.jruby.java.invokers.StaticMethodInvoker.call(StaticMethodInvoker.java:40)
> at
> org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:318)
> at
> org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:131)
> at
> org.jruby.ir.interpreter.InterpreterEngine.processCall(InterpreterEngine.java:339)
> at
> org.jruby.ir.interpreter.StartupInterpreterEngine.interpret(StartupInterpreterEngine.java:73)
> at
> org.jruby.ir.interpreter.InterpreterEngine.interpret(InterpreterEngine.java:77)
> at
> org.jruby.internal.runtime.methods.MixedModeIRMethod.INTERPRET_METHOD(MixedModeIRMethod.java:144)
> at
> org.jruby.internal.runtime.methods.MixedModeIRMethod.call(MixedModeIRMethod.java:130)
> at
> org.jruby.internal.runtime.methods.DynamicMethod.call(DynamicMethod.java:192)
> at
> org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:318)
> at
> org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:131)
> at
> org.jruby.ir.interpreter.InterpreterEngine.processCall(InterpreterEngine.java:339)
> at
> org.jruby.ir.interpreter.StartupInterpreterEngine.interpret(StartupInterpreterEngine.java:73)
> at
> org.jruby.ir.interpreter.InterpreterEngine.interpret(InterpreterEngine.java:77)
> at
> org.jruby.internal.runtime.methods.MixedModeIRMethod.INTERPRET_METHOD(MixedModeIRMethod.java:144)
> at
> org.jruby.internal.runtime.methods.MixedModeIRMethod.call(MixedModeIRMethod.java:130)
> at
> org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:328)
> at
> org.jruby.runtime.callsite.CachingCallSite.callBlock(CachingCallSite.java:141)
> at
> org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:145)
> at org.jruby.RubyClass.newInstance(RubyClass.java:994)
> at
> org.jruby.RubyClass$INVOKER$i$newInstance.call(RubyClass$INVOKER$i$newInstance.gen)
> at
> org.jruby.internal.runtime.methods.DynamicMethod.call(DynamicMethod.java:192)
> at
> org.jruby.runtime.callsite.CachingCallSite.cacheAndCall(CachingCallSite.java:318)
> at
> org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:131)
> at
> org.jruby.ir.interpreter.InterpreterEngine.processCall(InterpreterEngine.java:339)
> at
> org.jruby.ir.interpreter.StartupInterpreterEngine.interpret(StartupInterpreterEngine.java:73)
> at
> org.jruby.ir.interpreter.InterpreterEngine.interpret(InterpreterEngine.java:77)
> at
> org.jruby.internal.runtime.methods.MixedModeIRMethod.INTERPRET_METHOD(MixedModeIRMethod.java:144)
> at
>
[jira] [Assigned] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AMIT VIRMANI reassigned HBASE-18829: Assignee: Ted Yu (was: AMIT VIRMANI) > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Attachments: 18829.v1.txt, HBASE-18829.patch > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AMIT VIRMANI reassigned HBASE-18829: Assignee: AMIT VIRMANI (was: Ted Yu) > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: AMIT VIRMANI >Priority: Major > Attachments: 18829.v1.txt, HBASE-18829.patch > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-18970) The version of jruby we use now can't get interactive input from prompt
[
https://issues.apache.org/jira/browse/HBASE-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AMIT VIRMANI updated HBASE-18970:
-
Status: Patch Available (was: Open)
> The version of jruby we use now can't get interactive input from prompt
> ---
>
> Key: HBASE-18970
> URL: https://issues.apache.org/jira/browse/HBASE-18970
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Chia-Ping Tsai
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBase-18970.branch-2.001.patch, samplecmd.txt,
> test_shell-Output.txt, test_shell.sh
>
>
> case 1: press enter
> {code}
> hbase(main):002:0> disable_all 'chia(.*)'
> chia_1
>
>
> Disable the above 1 tables (y/n)?
> y^M
> {code}
> case 2: press ctrl-j
> {code}
> hbase(main):001:0> disable_all 'chia(.*)'
> chia_1
>
>
> Disable the above 1 tables (y/n)?
> y^J1 tables successfully disabled
> Took 5.0059 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18970) The version of jruby we use now can't get interactive input from prompt
[
https://issues.apache.org/jira/browse/HBASE-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
AMIT VIRMANI updated HBASE-18970:
-
Attachment: test_shell-Output.txt
test_shell.sh
samplecmd.txt
HBase-18970.branch-2.001.patch
I tried [~mdrob]'s suggestion of calling the command from init - it seems to
work.
Here are the things that I tried -
case 1: press enter
{code}
hbase(main):001:0> disable_all 'test*'
test
testt
Disable the above 2 tables (y/n)?
y
2 tables successfully disabled
Took 3.5838 seconds
{code}
case 2: press ctrl-j
{code}
hbase(main):002:0> enable_all 'test*'
test
testt
Enable the above 2 tables (y/n)?
y
2 tables successfully enabled
Took 5.8780 seconds
{code}
case 3: I also tried with noninteractive mode -
{code}
dhcp-10-16-2-161:hbase amitvirmani$ echo "describe 'test'" | ./bin/hbase shell
-n
Table test is ENABLED
test
COLUMN FAMILIES DESCRIPTION
{NAME => 'cf', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', NEW_VERSION_BE
HAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE', CACHE_DATA_ON_WRITE => 'false'
, DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICAT
ION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMO
RY => 'false', CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'fal
se', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'}
1 row(s)
Took 0.5099 seconds
{code}
case 4: run with text file as an input - samplecmd.txt attached, output below
{code}
dhcp-10-16-2-161:hbase amitvirmani$ ./bin/hbase shell
/Users/amitvirmani/Downloads/samplecmd.txt
2017-12-19 10:43:48,865 WARN [main] util.NativeCodeLoader: Unable to load
native-hadoop library for your platform... using builtin-java classes where
applicable
Created table newtest
Took 1.3773 seconds
TABLE
newtest
1 row(s)
Took 0.0250 seconds
Took 0.1705 seconds
Took 0.0033 seconds
Took 0.0027 seconds
Took 0.0027 seconds
ROW COLUMN+CELL
row1 column=cf:a, timestamp=1513709031217, value=value1
row2 column=cf:b, timestamp=1513709031242, value=value2
row3 column=cf:c, timestamp=1513709031246, value=value3
row4 column=cf:d, timestamp=1513709031250, value=value4
4 row(s)
Took 0.0278 seconds
COLUMNCELL
cf:a timestamp=1513709031217, value=value1
1 row(s)
Took 0.0302 seconds
Took 0.4487 seconds
Took 0.7322 seconds
{code}
case 5: ran the attached test_shell.sh to run interactive and non-interactive
list to output proper status codes - output also attached
Also ran the shell tests locally and they passed - mvn clean test
-Dtest=TestShell* -pl hbase-shell -am
Please let us know if anything else needs to be run.
> The version of jruby we use now can't get interactive input from prompt
> ---
>
> Key: HBASE-18970
> URL: https://issues.apache.org/jira/browse/HBASE-18970
> Project: HBase
> Issue Type: Task
> Components: shell
>Reporter: Chia-Ping Tsai
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBase-18970.branch-2.001.patch, samplecmd.txt,
> test_shell-Output.txt, test_shell.sh
>
>
> case 1: press enter
> {code}
> hbase(main):002:0> disable_all 'chia(.*)'
> chia_1
>
>
> Disable the above 1 tables (y/n)?
> y^M
> {code}
> case 2: press ctrl-j
> {code}
> hbase(main):001:0> disable_all 'chia(.*)'
> chia_1
>
>
> Disable the above 1 tables (y/n)?
> y^J1 tables successfully disabled
> Took 5.0059 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
