[jira] [Updated] (HBASE-25815) RSGroupBasedLoadBalancer online status never updates after being set to true for the first time

2021-04-26 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-25815:
-
Description: 
Once the RSGroupBasedLoadBalancer is “online” (it has found the hbase:meta and 
hbase:rsgroup tables), it will never update the status again. That means if 
hbase:meta or hbase:rsgroup ever go offline, the balancer doesn’t update its 
status to “offline,” so some of the code paths will go through the “online” 
code path even though the catalog tables aren’t available to be read from or 
written to (in particular, anything that calls 
RSGroupInfoManagerImpl#flushConfig).

Also, in the RSGroupInfoManagerImpl#flushConfig code path, the call to write to 
hbase:rsgroup comes before the update to the rsGroupMap and tableMap which are 
stored in memory (see order of [these lines of 
code|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java#L664-L670]),
 so if hbase:rsgroup goes offline after the RSGroupBasedLoadBalancer is already 
marked as “online,” exceptions thrown while trying to write to an offline 
hbase:rsgroup table prevent the in-memory rsGroupMap and tableMap from being 
updated. In terms of the order just mentioned, in-memory state should be 
updated first.

  was:
Once the RSGroupBasedLoadBalancer is “online” (it has found the hbase:meta and 
hbase:rsgroup tables), it will never update the status again. ** That means if 
hbase:meta or hbase:rsgroup ever go offline, the balancer doesn’t update its 
status to “offline,” so some of the code paths will go through the “online” 
code path even though the catalog tables aren’t available to be read from or 
written to (in particular, anything that calls 
RSGroupInfoManagerImpl#flushConfig).

Also, in the RSGroupInfoManagerImpl#flushConfig code path, the call to write to 
hbase:rsgroup comes before the update to the rsGroupMap and tableMap which are 
stored in memory (see order of [these lines of 
code|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java#L664-L670]),
 so if hbase:rsgroup goes offline after the RSGroupBasedLoadBalancer is already 
marked as “online,” exceptions thrown while trying to write to an offline 
hbase:rsgroup table prevent the in-memory rsGroupMap and tableMap from being 
updated. In terms of the order just mentioned, in-memory state should be 
updated first.


> RSGroupBasedLoadBalancer online status never updates after being set to true 
> for the first time
> ---
>
> Key: HBASE-25815
> URL: https://issues.apache.org/jira/browse/HBASE-25815
> Project: HBase
>  Issue Type: Bug
>Reporter: Caroline
>Priority: Minor
>
> Once the RSGroupBasedLoadBalancer is “online” (it has found the hbase:meta 
> and hbase:rsgroup tables), it will never update the status again. That means 
> if hbase:meta or hbase:rsgroup ever go offline, the balancer doesn’t update 
> its status to “offline,” so some of the code paths will go through the 
> “online” code path even though the catalog tables aren’t available to be read 
> from or written to (in particular, anything that calls 
> RSGroupInfoManagerImpl#flushConfig).
> Also, in the RSGroupInfoManagerImpl#flushConfig code path, the call to write 
> to hbase:rsgroup comes before the update to the rsGroupMap and tableMap which 
> are stored in memory (see order of [these lines of 
> code|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java#L664-L670]),
>  so if hbase:rsgroup goes offline after the RSGroupBasedLoadBalancer is 
> already marked as “online,” exceptions thrown while trying to write to an 
> offline hbase:rsgroup table prevent the in-memory rsGroupMap and tableMap 
> from being updated. In terms of the order just mentioned, in-memory state 
> should be updated first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25815) RSGroupBasedLoadBalancer online status never updates after being set to true for the first time

2021-04-26 Thread Caroline (Jira)
Caroline created HBASE-25815:


 Summary: RSGroupBasedLoadBalancer online status never updates 
after being set to true for the first time
 Key: HBASE-25815
 URL: https://issues.apache.org/jira/browse/HBASE-25815
 Project: HBase
  Issue Type: Bug
Reporter: Caroline


Once the RSGroupBasedLoadBalancer is “online” (it has found the hbase:meta and 
hbase:rsgroup tables), it will never update the status again. ** That means if 
hbase:meta or hbase:rsgroup ever go offline, the balancer doesn’t update its 
status to “offline,” so some of the code paths will go through the “online” 
code path even though the catalog tables aren’t available to be read from or 
written to (in particular, anything that calls 
RSGroupInfoManagerImpl#flushConfig).

Also, in the RSGroupInfoManagerImpl#flushConfig code path, the call to write to 
hbase:rsgroup comes before the update to the rsGroupMap and tableMap which are 
stored in memory (see order of [these lines of 
code|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java#L664-L670]),
 so if hbase:rsgroup goes offline after the RSGroupBasedLoadBalancer is already 
marked as “online,” exceptions thrown while trying to write to an offline 
hbase:rsgroup table prevent the in-memory rsGroupMap and tableMap from being 
updated. In terms of the order just mentioned, in-memory state should be 
updated first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23080) Purge LoadBalancer.BOGUS_SERVER_NAME in rsgroup

2021-04-15 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322541#comment-17322541
 ] 

Caroline commented on HBASE-23080:
--

[~Xiaolin Ha] Do you still intend to take up this one? I agree with what you 
said in your comment that we can randomly choose default group servers to 
assign (for example when rsgroup table isn't available) and have the balancer 
correct it later. However, this would be a design change to the current 
implementation right? It would no longer be strict isolation between rsgroups 
but rather best effort. It would probably be good for availability though.

FYI [~apurtell] [~vjasani] [~bharathv] [~dmanning] – any thoughts/input?

> Purge LoadBalancer.BOGUS_SERVER_NAME in rsgroup
> ---
>
> Key: HBASE-23080
> URL: https://issues.apache.org/jira/browse/HBASE-23080
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25730) HBase RegionServer Canary reports failure if an online regionserver is hosting 0 regions

2021-04-02 Thread Caroline (Jira)
Caroline created HBASE-25730:


 Summary: HBase RegionServer Canary reports failure if an online 
regionserver is hosting 0 regions
 Key: HBASE-25730
 URL: https://issues.apache.org/jira/browse/HBASE-25730
 Project: HBase
  Issue Type: Bug
  Components: canary
Reporter: Caroline
Assignee: Caroline


The probability of this happening increases with system rsgroup enabled (i.e. 
an rsgroup dedicated to system tables, which have few regions) and paired with 
table-level load balancing. As long as the server is alive and able to 
accept/serve regions, we should not consider it an error case if it is 
currently serving no regions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2021-03-27 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310102#comment-17310102
 ] 

Caroline commented on HBASE-25032:
--

Thanks everyone for the discussion + feedback helping drive this to completion 
:)

> Wait for region server to become online before adding it to online servers in 
> Master
> 
>
> Key: HBASE-25032
> URL: https://issues.apache.org/jira/browse/HBASE-25032
> Project: HBase
>  Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Caroline
>Priority: Major
>  Labels: master, regionserver
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.3
>
>
> As part of RS start up, RS reports for duty to Master . Master acknowledges 
> the request and adds it to the onlineServers list for further assigning any 
> regions to the RS
> Once Master acknowledges the reportForDuty and sends back the response, RS 
> does a bunch of stuff like initializing replication sources etc before 
> becoming online. However, sometimes there could be an issue with initializing 
> replication sources when it is unable to connect to peer clusters because of 
> some kerberos configuration and there would be a delay of around 20 mins in 
> becoming online.
>  
> Since master considers it online, it tries to assign regions and which fails 
> with ServerNotRunningYet exception, then the master tries to unassign which 
> again fails with the same exception leading the region to FAILED_CLOSE state.
>  
> It would be good to have a check to see if the RS is ready to accept the 
> assignment requests before adding it to online servers list which would 
> account for any such delays as described above



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264369#comment-17264369
 ] 

Caroline commented on HBASE-25329:
--

Thanks [~vjasani]

> Dump region hashes in logs for the regions that are stuck in transition for 
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.1
>
> Attachments: HBASE-25329.branch-1.000.patch, 
> HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch
>
>
> We have metrics for number of RITs as well as number of RITs above a certain 
> threshold, but we don't have any way of keeping track of the region hashes of 
> those RITs. It would be beneficial to emit those region hashes as a metric, 
> as well as log them, so that we don't accidentally lose this information for 
> debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-12 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263962#comment-17263962
 ] 

Caroline commented on HBASE-25329:
--

Thanks [~vjasani] for merging the patch into master. I've updated the branch-1 
PR as well; feel free to take a look: 
[https://github.com/apache/hbase/pull/2762/files]

Can you explain how the change has been merged into branch-2? Isn't the 
branch-2 PR still open? (The one that was merged had a base branch of master, 
right?)

> Dump region hashes in logs for the regions that are stuck in transition for 
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
> Attachments: HBASE-25329.branch-1.000.patch, 
> HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch
>
>
> We have metrics for number of RITs as well as number of RITs above a certain 
> threshold, but we don't have any way of keeping track of the region hashes of 
> those RITs. It would be beneficial to emit those region hashes as a metric, 
> as well as log them, so that we don't accidentally lose this information for 
> debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2021-01-07 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260986#comment-17260986
 ] 

Caroline commented on HBASE-25032:
--

[~bharathv] Thanks for the explanation, I think that makes sense. I looked at 
the code some more and it seems that we only need to remove the call to 
checkAndRecordNewServer() (this line 
[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L230)]
 within ServerManager's regionServerStartup() function and the rest of what you 
suggested is covered. This is because HRegionServer's run() method calls 
tryRegionServerReport() (this line 
[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1086)]
 after the reportForDuty/handleReportForDuty logic is done, and the 
tryRegionServerReport() function contains a call to master's 
regionServerReport() function (here 
[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L278)]
 which contains a call to checkAndRecordNewServer() already. Please correct me 
if I misunderstood anything.

> Wait for region server to become online before adding it to online servers in 
> Master
> 
>
> Key: HBASE-25032
> URL: https://issues.apache.org/jira/browse/HBASE-25032
> Project: HBase
>  Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Caroline
>Priority: Major
>
> As part of RS start up, RS reports for duty to Master . Master acknowledges 
> the request and adds it to the onlineServers list for further assigning any 
> regions to the RS
> Once Master acknowledges the reportForDuty and sends back the response, RS 
> does a bunch of stuff like initializing replication sources etc before 
> becoming online. However, sometimes there could be an issue with initializing 
> replication sources when it is unable to connect to peer clusters because of 
> some kerberos configuration and there would be a delay of around 20 mins in 
> becoming online.
>  
> Since master considers it online, it tries to assign regions and which fails 
> with ServerNotRunningYet exception, then the master tries to unassign which 
> again fails with the same exception leading the region to FAILED_CLOSE state.
>  
> It would be good to have a check to see if the RS is ready to accept the 
> assignment requests before adding it to online servers list which would 
> account for any such delays as described above



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-06 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260132#comment-17260132
 ] 

Caroline edited comment on HBASE-25329 at 1/7/21, 12:47 AM:


[~apurtell] [~vjasani] [~bharathv] Thanks for the feedback. I'll remove the 
metrics additions from the patches since this particular Jira concerns dumping 
RITs into the logs. Do you have any suggestions on how often we should be 
logging the RITs? 

For the idea of adding a /rit endpoint in master, I've created a Jira 
(https://issues.apache.org/jira/browse/HBASE-25469) to track it. Would love to 
hear suggestions about what info to expose on the endpoint. If someone could 
provide a servlet code example that would also be helpful, since I'm unfamiliar 
with them in this code base. Thanks!


was (Author: caroliney14):
[~apurtell] [~vjasani] [~bharathv] Thanks for the feedback. I'll remove the 
metrics additions from the patches since this particular Jira concerns dumping 
RITs into the logs. Do you have any suggestions on how often we should be 
logging the RITs? 

For the idea of adding a /rit endpoint in master, I've created a Jira to track 
it. Would love to hear suggestions about what info to expose on the endpoint. 
If someone could provide a servlet code example that would also be helpful, 
since I'm unfamiliar with them in this code base. Thanks!

> Dump region hashes in logs for the regions that are stuck in transition for 
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Attachments: HBASE-25329.branch-1.000.patch, 
> HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch
>
>
> We have metrics for number of RITs as well as number of RITs above a certain 
> threshold, but we don't have any way of keeping track of the region hashes of 
> those RITs. It would be beneficial to emit those region hashes as a metric, 
> as well as log them, so that we don't accidentally lose this information for 
> debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-06 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260132#comment-17260132
 ] 

Caroline commented on HBASE-25329:
--

[~apurtell] [~vjasani] [~bharathv] Thanks for the feedback. I'll remove the 
metrics additions from the patches since this particular Jira concerns dumping 
RITs into the logs. Do you have any suggestions on how often we should be 
logging the RITs? 

For the idea of adding a /rit endpoint in master, I've created a Jira to track 
it. Would love to hear suggestions about what info to expose on the endpoint. 
If someone could provide a servlet code example that would also be helpful, 
since I'm unfamiliar with them in this code base. Thanks!

> Dump region hashes in logs for the regions that are stuck in transition for 
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Attachments: HBASE-25329.branch-1.000.patch, 
> HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch
>
>
> We have metrics for number of RITs as well as number of RITs above a certain 
> threshold, but we don't have any way of keeping track of the region hashes of 
> those RITs. It would be beneficial to emit those region hashes as a metric, 
> as well as log them, so that we don't accidentally lose this information for 
> debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-06 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260132#comment-17260132
 ] 

Caroline edited comment on HBASE-25329 at 1/7/21, 12:46 AM:


[~apurtell] [~vjasani] [~bharathv] Thanks for the feedback. I'll remove the 
metrics additions from the patches since this particular Jira concerns dumping 
RITs into the logs. Do you have any suggestions on how often we should be 
logging the RITs? 

For the idea of adding a /rit endpoint in master, I've created a Jira to track 
it. Would love to hear suggestions about what info to expose on the endpoint. 
If someone could provide a servlet code example that would also be helpful, 
since I'm unfamiliar with them in this code base. Thanks!


was (Author: caroliney14):
[~apurtell] [~vjasani] [~bharathv] Thanks for the feedback. I'll remove the 
metrics additions from the patches since this particular Jira concerns dumping 
RITs into the logs. Do you have any suggestions on how often we should be 
logging the RITs? 

For the idea of adding a /rit endpoint in master, I've created a Jira to track 
it. Would love to hear suggestions about what info to expose on the endpoint. 
If someone could provide a servlet code example that would also be helpful, 
since I'm unfamiliar with them in this code base. Thanks!

> Dump region hashes in logs for the regions that are stuck in transition for 
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Attachments: HBASE-25329.branch-1.000.patch, 
> HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch
>
>
> We have metrics for number of RITs as well as number of RITs above a certain 
> threshold, but we don't have any way of keeping track of the region hashes of 
> those RITs. It would be beneficial to emit those region hashes as a metric, 
> as well as log them, so that we don't accidentally lose this information for 
> debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25469) Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics

2021-01-06 Thread Caroline (Jira)
Caroline created HBASE-25469:


 Summary: Create RIT servlet in HMaster to track more detailed RIT 
info not captured in metrics
 Key: HBASE-25469
 URL: https://issues.apache.org/jira/browse/HBASE-25469
 Project: HBase
  Issue Type: Improvement
Reporter: Caroline






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2020-12-15 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250035#comment-17250035
 ] 

Caroline commented on HBASE-25032:
--

[~anoop.hbase] Once Master acknowledges the reportForDuty and sends the 
response back to the RS, RS performs all the actions within [this 
handleReportForDuty() 
method|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1494].
 Aside from setting up WAL and replication, this method also sets up an 
ephemeral znode, initializes file system, sets up metrics, starts service 
threads, starts heap memory manager, and sets the RS internal 'online' boolean 
to true, among other tasks. So, it seems that RS is doing a lot of vital and 
time-consuming setup after reporting for duty to master. 

Therefore, I believe it makes sense for Master to delay placing the RS into its 
onlineServers list until after the RS has completed all of above tasks. The 
approach taken in the PRs is to leave the RS reportForDuty/handleReportForDuty 
logic as is, and change the Master-side logic so that Master asynchronously 
polls for the RS's internal 'online' boolean to be set to true before placing 
the RS into its onlineServers list (this will happen at the end of RS's 
handleReportForDuty method).

The flow looks something like this:

RS starts up -> RS sends reportForDuty to Master -> Master acknowledges 
reportForDuty, sends response to RS; at the same time, Master spawns thread to 
poll for RS 'online' flag (i.e. RS setup complete) -> RS receives 
'reportForDuty received' acknowledgement from Master -> RS finishes setup, sets 
its 'online' flag to true -> Master sees RS has finished setup -> Master adds 
RS to Master's onlineServers list.

> Wait for region server to become online before adding it to online servers in 
> Master
> 
>
> Key: HBASE-25032
> URL: https://issues.apache.org/jira/browse/HBASE-25032
> Project: HBase
>  Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Caroline
>Priority: Major
>
> As part of RS start up, RS reports for duty to Master . Master acknowledges 
> the request and adds it to the onlineServers list for further assigning any 
> regions to the RS
> Once Master acknowledges the reportForDuty and sends back the response, RS 
> does a bunch of stuff like initializing replication sources etc before 
> becoming online. However, sometimes there could be an issue with initializing 
> replication sources when it is unable to connect to peer clusters because of 
> some kerberos configuration and there would be a delay of around 20 mins in 
> becoming online.
>  
> Since master considers it online, it tries to assign regions and which fails 
> with ServerNotRunningYet exception, then the master tries to unassign which 
> again fails with the same exception leading the region to FAILED_CLOSE state.
>  
> It would be good to have a check to see if the RS is ready to accept the 
> assignment requests before adding it to online servers list which would 
> account for any such delays as described above



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2020-12-11 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248186#comment-17248186
 ] 

Caroline commented on HBASE-25032:
--

Made a few PRs that are ready for review:

[https://github.com/apache/hbase/pull/2769]

[https://github.com/apache/hbase/pull/2770]

[https://github.com/apache/hbase/pull/2771]

> Wait for region server to become online before adding it to online servers in 
> Master
> 
>
> Key: HBASE-25032
> URL: https://issues.apache.org/jira/browse/HBASE-25032
> Project: HBase
>  Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Caroline
>Priority: Major
>
> As part of RS start up, RS reports for duty to Master . Master acknowledges 
> the request and adds it to the onlineServers list for further assigning any 
> regions to the RS
> Once Master acknowledges the reportForDuty and sends back the response, RS 
> does a bunch of stuff like initializing replication sources etc before 
> becoming online. However, sometimes there could be an issue with initializing 
> replication sources when it is unable to connect to peer clusters because of 
> some kerberos configuration and there would be a delay of around 20 mins in 
> becoming online.
>  
> Since master considers it online, it tries to assign regions and which fails 
> with ServerNotRunningYet exception, then the master tries to unassign which 
> again fails with the same exception leading the region to FAILED_CLOSE state.
>  
> It would be good to have a check to see if the RS is ready to accept the 
> assignment requests before adding it to online servers list which would 
> account for any such delays as described above



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2020-12-10 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247088#comment-17247088
 ] 

Caroline commented on HBASE-25329:
--

[~vjasani] Thanks for the heads-up, didn't know patch support was being 
deprecated. I've created 3 PRs:

[https://github.com/apache/hbase/pull/2761]

[https://github.com/apache/hbase/pull/2762]

[https://github.com/apache/hbase/pull/2763]

> Dump region hashes in logs for the regions that are stuck in transition for 
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Attachments: HBASE-25329.branch-1.000.patch, 
> HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch
>
>
> We have metrics for number of RITs as well as number of RITs above a certain 
> threshold, but we don't have any way of keeping track of the region hashes of 
> those RITs. It would be beneficial to emit those region hashes as a metric, 
> as well as log them, so that we don't accidentally lose this information for 
> debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2020-12-09 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-25329:
-
Attachment: HBASE-25329.branch-1.000.patch
HBASE-25329.branch-2.000.patch
HBASE-25329.master.000.patch
Status: Patch Available  (was: Open)

> Dump region hashes in logs for the regions that are stuck in transition for 
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Attachments: HBASE-25329.branch-1.000.patch, 
> HBASE-25329.branch-2.000.patch, HBASE-25329.master.000.patch
>
>
> We have metrics for number of RITs as well as number of RITs above a certain 
> threshold, but we don't have any way of keeping track of the region hashes of 
> those RITs. It would be beneficial to emit those region hashes as a metric, 
> as well as log them, so that we don't accidentally lose this information for 
> debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2020-12-01 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241847#comment-17241847
 ] 

Caroline edited comment on HBASE-25032 at 12/1/20, 8:41 PM:


[~anoop.hbase] [~apurtell]

Had some discussion with [~sandeep.guggilam] about possible fixes for this 
issue:
 # Move `reportForDuty()` after replication setup in `HRegionServer.java`. I 
think it would be moving [this 
line|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1546]
 out of the `handleReportForDutyResponse()` method and above the 
`reportForDuty()` line 
[here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1033].
 # Postpone adding the regionserver to master's online servers list until the 
regionserver's `online` flag has been set to true (i.e. all of the 
regionserver's initialization steps have completed). I believe that would be 
replacing [this 
line|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L280]
 with a thread or thread pool executor which asynchronously polls regionserver 
info (call 
[ServerManager.isServerReachable()|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L998]),
 and only calls `ServerManager.checkAndRecordNewServer()` after a response is 
received. We could create a new single thread pool executor every time 
`ServerManager.regionServerStartup()` is called, use the 
`MASTER_SERVER_OPERATIONS` service thread, or create a new executor 
service/thread pool/something else with configured x number of threads for this 
kind of task. Any thoughts on how we should configure the thread pool here?
 # Do not force region state to offline in the bulk assign method 
[here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java#L1762].
 I haven't investigated the implications of this.


was (Author: caroliney14):
[~anoop.hbase] [~apurtell]

Had some discussion with [~sandeep.guggilam] about possible fixes for this 
issue:
 # Move `reportForDuty()` after replication setup in `HRegionServer.java`. I 
think it would be moving [this 
line|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1546]
 out of the `handleReportForDutyResponse()` method and above the 
`reportForDuty()` line 
[here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1033].
 # Postpone adding the regionserver to master's online servers list until the 
regionserver's `online` flag has been set to true (i.e. all of the 
regionserver's initialization steps have completed). I believe that would be 
replacing [this 
line|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L280]
 with a thread or thread pool executor which asynchronously polls regionserver 
info (call 
[ServerManager.isServerReachable()|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L998]),
 and only calls `checkAndRecordNewServer()` after a response is received. We 
could create a new single thread pool executor every time 
`regionServerStartup()` is called, use the `MASTER_SERVER_OPERATIONS` service 
thread, or create a new executor service/thread pool/something else with 
configured x number of threads for this kind of task. Any thoughts on how we 
should configure the thread pool here?
 # Do not force region state to offline in the bulk assign method 
[here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java#L1762].
 I haven't investigated the implications of this.

> Wait for region server to become online before adding it to online servers in 
> Master
> 
>
> Key: HBASE-25032
> URL: https://issues.apache.org/jira/browse/HBASE-25032
> Project: HBase
>  Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Caroline
>Priority: Major
>
> As part of RS start up, RS reports for duty to Master . Master acknowledges 
> the request and adds it to the onlineServers list for further assigning any 
> regions to the RS
> Once Master acknowledges the reportForDuty and sends back the response, RS 
> does a bunch of stuff like initializing replication sources etc before 
> becoming online. However, sometimes there could be an issue with initializing 
> replication 

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2020-12-01 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241847#comment-17241847
 ] 

Caroline commented on HBASE-25032:
--

[~anoop.hbase] [~apurtell]

Had some discussion with [~sandeep.guggilam] about possible fixes for this 
issue:
 # Move `reportForDuty()` after replication setup in `HRegionServer.java`. I 
think it would be moving [this 
line|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1546]
 out of the `handleReportForDutyResponse()` method and above the 
`reportForDuty()` line 
[here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1033].
 # Postpone adding the regionserver to master's online servers list until the 
regionserver's `online` flag has been set to true (i.e. all of the 
regionserver's initialization steps have completed). I believe that would be 
replacing [this 
line|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L280]
 with a thread or thread pool executor which asynchronously polls regionserver 
info (call 
[ServerManager.isServerReachable()|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L998]),
 and only calls `checkAndRecordNewServer()` after a response is received. We 
could create a new single thread pool executor every time 
`regionServerStartup()` is called, use the `MASTER_SERVER_OPERATIONS` service 
thread, or create a new executor service/thread pool/something else with 
configured x number of threads for this kind of task. Any thoughts on how we 
should configure the thread pool here?
 # Do not force region state to offline in the bulk assign method 
[here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java#L1762].
 I haven't investigated the implications of this.

> Wait for region server to become online before adding it to online servers in 
> Master
> 
>
> Key: HBASE-25032
> URL: https://issues.apache.org/jira/browse/HBASE-25032
> Project: HBase
>  Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Caroline
>Priority: Major
>
> As part of RS start up, RS reports for duty to Master . Master acknowledges 
> the request and adds it to the onlineServers list for further assigning any 
> regions to the RS
> Once Master acknowledges the reportForDuty and sends back the response, RS 
> does a bunch of stuff like initializing replication sources etc before 
> becoming online. However, sometimes there could be an issue with initializing 
> replication sources when it is unable to connect to peer clusters because of 
> some kerberos configuration and there would be a delay of around 20 mins in 
> becoming online.
>  
> Since master considers it online, it tries to assign regions and which fails 
> with ServerNotRunningYet exception, then the master tries to unassign which 
> again fails with the same exception leading the region to FAILED_CLOSE state.
>  
> It would be good to have a check to see if the RS is ready to accept the 
> assignment requests before adding it to online servers list which would 
> account for any such delays as described above



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2020-12-01 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline reassigned HBASE-25032:


Assignee: Caroline  (was: Sandeep Guggilam)

> Wait for region server to become online before adding it to online servers in 
> Master
> 
>
> Key: HBASE-25032
> URL: https://issues.apache.org/jira/browse/HBASE-25032
> Project: HBase
>  Issue Type: Bug
>Reporter: Sandeep Guggilam
>Assignee: Caroline
>Priority: Major
>
> As part of RS start up, RS reports for duty to Master . Master acknowledges 
> the request and adds it to the onlineServers list for further assigning any 
> regions to the RS
> Once Master acknowledges the reportForDuty and sends back the response, RS 
> does a bunch of stuff like initializing replication sources etc before 
> becoming online. However, sometimes there could be an issue with initializing 
> replication sources when it is unable to connect to peer clusters because of 
> some kerberos configuration and there would be a delay of around 20 mins in 
> becoming online.
>  
> Since master considers it online, it tries to assign regions and which fails 
> with ServerNotRunningYet exception, then the master tries to unassign which 
> again fails with the same exception leading the region to FAILED_CLOSE state.
>  
> It would be good to have a check to see if the RS is ready to accept the 
> assignment requests before adding it to online servers list which would 
> account for any such delays as described above



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2020-11-24 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline reassigned HBASE-25329:


Assignee: Caroline

> Dump region hashes in logs for the regions that are stuck in transition for 
> more than a configured amount of time
> -
>
> Key: HBASE-25329
> URL: https://issues.apache.org/jira/browse/HBASE-25329
> Project: HBase
>  Issue Type: Improvement
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>
> We have metrics for number of RITs as well as number of RITs above a certain 
> threshold, but we don't have any way of keeping track of the region hashes of 
> those RITs. It would be beneficial to emit those region hashes as a metric, 
> as well as log them, so that we don't accidentally lose this information for 
> debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2020-11-24 Thread Caroline (Jira)
Caroline created HBASE-25329:


 Summary: Dump region hashes in logs for the regions that are stuck 
in transition for more than a configured amount of time
 Key: HBASE-25329
 URL: https://issues.apache.org/jira/browse/HBASE-25329
 Project: HBase
  Issue Type: Improvement
Reporter: Caroline


We have metrics for number of RITs as well as number of RITs above a certain 
threshold, but we don't have any way of keeping track of the region hashes of 
those RITs. It would be beneficial to emit those region hashes as a metric, as 
well as log them, so that we don't accidentally lose this information for 
debugging the RIT at a later tiime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23172) HBase Canary region success count metrics reflect column family successes, not region successes

2019-10-21 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-23172:
-
Release Note: 
Added a comment to make clear that read/write success counts are tallying 
column family success counts, not region success counts. 

Additionally, the region read and write latencies previously only stored the 
latencies of the last column family of the region read. This has been fixed by 
using a map of each region to a list of read and write latency values.

> HBase Canary region success count metrics reflect column family successes, 
> not region successes
> ---
>
> Key: HBASE-23172
> URL: https://issues.apache.org/jira/browse/HBASE-23172
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23172.branch-1.000.patch, 
> HBASE-23172.branch-2.000.patch, HBASE-23172.master.000.patch, 
> HBASE-23172.master.000.patch, HBASE-23172.master.000.patch
>
>
> HBase Canary reads once per column family per region. The current "region 
> success count" should actually be "column family success count," which means 
> we need another metric that actually reflects region success count. 
> Additionally, the region read and write latencies only store the latencies of 
> the last column family of the region read. Instead of a map of regions to a 
> single latency value and success value, we should map each region to a list 
> of such values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HBASE-23172) HBase Canary region success count metrics reflect column family successes, not region successes

2019-10-21 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956280#comment-16956280
 ] 

Caroline edited comment on HBASE-23172 at 10/21/19 6:54 PM:


Thanks for reviewing and pushing this fix on all branches, [~stack]! I also 
updated the release note as you suggested.


was (Author: caroliney14):
Thanks for reviewing and pushing this fix on all branches, [~stack]!

> HBase Canary region success count metrics reflect column family successes, 
> not region successes
> ---
>
> Key: HBASE-23172
> URL: https://issues.apache.org/jira/browse/HBASE-23172
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23172.branch-1.000.patch, 
> HBASE-23172.branch-2.000.patch, HBASE-23172.master.000.patch, 
> HBASE-23172.master.000.patch, HBASE-23172.master.000.patch
>
>
> HBase Canary reads once per column family per region. The current "region 
> success count" should actually be "column family success count," which means 
> we need another metric that actually reflects region success count. 
> Additionally, the region read and write latencies only store the latencies of 
> the last column family of the region read. Instead of a map of regions to a 
> single latency value and success value, we should map each region to a list 
> of such values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23172) HBase Canary region success count metrics reflect column family successes, not region successes

2019-10-21 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-23172:
-
Release Note: 
Added a comment to make clear that read/write success counts are tallying 
column family success counts, not region success counts. 

Additionally, the region read and write latencies previously only stored the 
latencies of the last column family of the region reads/writes. This has been 
fixed by using a map of each region to a list of read and write latency values.

  was:
Added a comment to make clear that read/write success counts are tallying 
column family success counts, not region success counts. 

Additionally, the region read and write latencies previously only stored the 
latencies of the last column family of the region read. This has been fixed by 
using a map of each region to a list of read and write latency values.


> HBase Canary region success count metrics reflect column family successes, 
> not region successes
> ---
>
> Key: HBASE-23172
> URL: https://issues.apache.org/jira/browse/HBASE-23172
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23172.branch-1.000.patch, 
> HBASE-23172.branch-2.000.patch, HBASE-23172.master.000.patch, 
> HBASE-23172.master.000.patch, HBASE-23172.master.000.patch
>
>
> HBase Canary reads once per column family per region. The current "region 
> success count" should actually be "column family success count," which means 
> we need another metric that actually reflects region success count. 
> Additionally, the region read and write latencies only store the latencies of 
> the last column family of the region read. Instead of a map of regions to a 
> single latency value and success value, we should map each region to a list 
> of such values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23172) HBase Canary region success count metrics reflect column family successes, not region successes

2019-10-21 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956280#comment-16956280
 ] 

Caroline commented on HBASE-23172:
--

Thanks for reviewing and pushing this fix on all branches, [~stack]!

> HBase Canary region success count metrics reflect column family successes, 
> not region successes
> ---
>
> Key: HBASE-23172
> URL: https://issues.apache.org/jira/browse/HBASE-23172
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23172.branch-1.000.patch, 
> HBASE-23172.branch-2.000.patch, HBASE-23172.master.000.patch, 
> HBASE-23172.master.000.patch, HBASE-23172.master.000.patch
>
>
> HBase Canary reads once per column family per region. The current "region 
> success count" should actually be "column family success count," which means 
> we need another metric that actually reflects region success count. 
> Additionally, the region read and write latencies only store the latencies of 
> the last column family of the region read. Instead of a map of regions to a 
> single latency value and success value, we should map each region to a list 
> of such values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23172) HBase Canary region success count metrics reflect column family successes, not region successes

2019-10-18 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-23172:
-
Attachment: HBASE-23172.master.000.patch

> HBase Canary region success count metrics reflect column family successes, 
> not region successes
> ---
>
> Key: HBASE-23172
> URL: https://issues.apache.org/jira/browse/HBASE-23172
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Attachments: HBASE-23172.branch-1.000.patch, 
> HBASE-23172.branch-2.000.patch, HBASE-23172.master.000.patch, 
> HBASE-23172.master.000.patch
>
>
> HBase Canary reads once per column family per region. The current "region 
> success count" should actually be "column family success count," which means 
> we need another metric that actually reflects region success count. 
> Additionally, the region read and write latencies only store the latencies of 
> the last column family of the region read. Instead of a map of regions to a 
> single latency value and success value, we should map each region to a list 
> of such values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23172) HBase Canary region success count metrics reflect column family successes, not region successes

2019-10-17 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-23172:
-
Attachment: HBASE-23172.branch-1.000.patch
HBASE-23172.branch-2.000.patch
HBASE-23172.master.000.patch
Status: Patch Available  (was: Open)

> HBase Canary region success count metrics reflect column family successes, 
> not region successes
> ---
>
> Key: HBASE-23172
> URL: https://issues.apache.org/jira/browse/HBASE-23172
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 2.2.1, 2.1.5, 2.0.0, 1.5.0, 1.4.0, 1.3.0, 3.0.0
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Attachments: HBASE-23172.branch-1.000.patch, 
> HBASE-23172.branch-2.000.patch, HBASE-23172.master.000.patch
>
>
> HBase Canary reads once per column family per region. The current "region 
> success count" should actually be "column family success count," which means 
> we need another metric that actually reflects region success count. 
> Additionally, the region read and write latencies only store the latencies of 
> the last column family of the region read. Instead of a map of regions to a 
> single latency value and success value, we should map each region to a list 
> of such values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (HBASE-23172) HBase Canary region success count metrics reflect column family successes, not region successes

2019-10-14 Thread Caroline (Jira)
Caroline created HBASE-23172:


 Summary: HBase Canary region success count metrics reflect column 
family successes, not region successes
 Key: HBASE-23172
 URL: https://issues.apache.org/jira/browse/HBASE-23172
 Project: HBase
  Issue Type: Improvement
  Components: canary
Affects Versions: 2.2.1, 2.1.5, 2.0.0, 1.5.0, 1.4.0, 1.3.0, 3.0.0
Reporter: Caroline
Assignee: Caroline


HBase Canary reads once per column family per region. The current "region 
success count" should actually be "column family success count," which means we 
need another metric that actually reflects region success count. Additionally, 
the region read and write latencies only store the latencies of the last column 
family of the region read. Instead of a map of regions to a single latency 
value and success value, we should map each region to a list of such values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-13 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.010.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Fix For: 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1, master
>
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-1.009.patch, HBASE-22804.branch-1.010.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-13 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Fix Version/s: 1.3.0
   1.4.0
   2.0.0
   2.1.5
   master
   2.2.1
   1.5.0

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Fix For: 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1, master
>
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-13 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-13 Thread Caroline (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929520#comment-16929520
 ] 

Caroline commented on HBASE-22804:
--

[~psomogyi] we already committed this, since the tests passed for branch-1 when 
I made a PR on Github. Will mark this issue as resolved. Thanks!

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-10 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.009.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-10 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.009.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-10 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.009.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-10 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.009.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-09 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.009.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-09 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.008.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-09 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.007.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-09 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.007.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-09 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.007.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-06 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.007.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-1.007.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-04 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.007.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-04 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.006.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-09-03 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.006.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.006.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, 
> HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, 
> HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, 
> HBASE-22804.master.005.patch, HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-19 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-2.006.patch
HBASE-22804.branch-1.006.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-19 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-2.006.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-19 Thread Caroline (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.006.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-16 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-2.006.patch
HBASE-22804.branch-1.006.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, 
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-15 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.006.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, 
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-15 Thread Caroline (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908483#comment-16908483
 ] 

Caroline commented on HBASE-22804:
--

Fixed... hopefully there aren't any more checkstyle problems. [~xucang]

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-15 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.005.patch
HBASE-22804.branch-2.005.patch
HBASE-22804.branch-1.005.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, 
> HBASE-22804.branch-2.005.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22823) Mark Canary as Public/Evolving

2019-08-14 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22823:
-
Attachment: HBASE-22823.branch-1.000.patch
HBASE-22823.branch-2.000.patch
HBASE-22823.master.000.patch
Status: Patch Available  (was: Open)

> Mark Canary as Public/Evolving
> --
>
> Key: HBASE-22823
> URL: https://issues.apache.org/jira/browse/HBASE-22823
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Caroline
>Priority: Minor
> Attachments: HBASE-22823.branch-1.000.patch, 
> HBASE-22823.branch-2.000.patch, HBASE-22823.master.000.patch
>
>
> Canary is marked as a Private class. Its interfaces could change at any time. 
> Should we change the annotation on Canary to Public/Evolving? Or add 
> annotations on some of these subtypes? I think it depends on how we think 
> Canary results should be consumed.
> In our production we find that scraping logs and parsing them is brittle and 
> not scalable. Although the scalability issue is more to do with the totality 
> of logs from a Hadoopish stack, if you run HBase then you have this problem, 
> and you wouldn't be using the canary if you didn't run HBase. We have a tool 
> that embeds the Canary and calls various methods and takes actions without 
> needing a round trip to the logs and whatever aggregates them.
> I propose we promote Canary to Public/Evolving. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-14 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.004.patch
HBASE-22804.branch-2.004.patch
HBASE-22804.branch-1.004.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, 
> HBASE-22804.branch-2.004.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, 
> HBASE-22804.master.004.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-14 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-2.003.patch
HBASE-22804.branch-1.003.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, 
> HBASE-22804.branch-2.003.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-14 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.master.002.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-14 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.003.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Assigned] (HBASE-22823) Mark Canary as Public/Evolving

2019-08-12 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline reassigned HBASE-22823:


Assignee: Caroline

> Mark Canary as Public/Evolving
> --
>
> Key: HBASE-22823
> URL: https://issues.apache.org/jira/browse/HBASE-22823
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Caroline
>Priority: Minor
>
> Canary is marked as a Private class. Its interfaces could change at any time. 
> Should we change the annotation on Canary to Public/Evolving? Or add 
> annotations on some of these subtypes? I think it depends on how we think 
> Canary results should be consumed.
> In our production we find that scraping logs and parsing them is brittle and 
> not scalable. Although the scalability issue is more to do with the totality 
> of logs from a Hadoopish stack, if you run HBase then you have this problem, 
> and you wouldn't be using the canary if you didn't run HBase. We have a tool 
> that embeds the Canary and calls various methods and takes actions without 
> needing a round trip to the logs and whatever aggregates them.
> I propose we promote Canary to Public/Evolving. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-12 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.002.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch, HBASE-22804.master.002.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-12 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.002.patch
HBASE-22804.branch-2.002.patch
HBASE-22804.branch-1.002.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-2.001.patch, 
> HBASE-22804.branch-2.002.patch, HBASE-22804.master.001.patch, 
> HBASE-22804.master.002.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-12 Thread Caroline (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905424#comment-16905424
 ] 

Caroline commented on HBASE-22804:
--

Thanks Andrew, stack, and Mingliang for reviewing. 

@[~apurtell]:

_>_ Therefore I propose that there be a follow up patch which makes Canary 
Public/Evolving.

I can make this change after this one has been committed.

@[~stack]:

> ... see how avoid direct reference to guava and instead use a shaded internal 
>version at org.apache.hbase.thirdparty. That is probably what the above 
>shadedjars complaints are about.

 Thanks for the suggestion. As Mingliang pointed out, I can replace that line 
with private Map regionMap = new 
ConcurrentHashMap<>().

> Should this be an Interface so we can add more methods to it w/o breaking it 
>(using 'default' implementations?) given it looks like you have to embed the 
>Canary to get access to these new APIs?

Only region mode would use this API.. so I'm not sure there's a need for an 
interface.

> Oh, maybe say a bit on how you intend to use this new API? Would help. Thanks.

We hope to address two concerns here: 1) was the region reachable (did 
read/write succeed)? This will allow us to derive a more accurate HBase 
availability metric by calculating a percentage of regions which are 
responsive; and 2) did the request complete in time to meet the use case SLO? 
(To determine this, we need read/write latencies for each region.) 

@[~liuml07]:

 

I generally agree with your suggestions.

> {{TableName tableName = TableName.valueOf("testTable");}} Test table name can 
>be a variable and be referenced later. The value can be the test method name 
>to avoid potential conflict.

While this is a good suggestion, I will not change the other test cases already 
present in order to conform to this strategy, because it seems irrelevant to 
this patch. I will use a different table name for the new unit test.

> {{private Map regionMap = 
>Maps.newConcurrentMap();}} can be replaced with {{private MapRegionTaskResult> regionMap = new ConcurrentHashMap<>();}} to not use guava? 
>Actually I'm thinking do we need it to be concurrent Map? We populate all 
>regions before the sniff and then all other places simply get the individual 
>item to update. Thoughts?

I think it's safer to use a Concurrent Map because there are 16 threads to 
contact the regions, and they each need to access the map whenever they 
publishReadTiming() or publishWriteTiming(). Although I highly doubt they will 
try to access the same key, I think it's better to use a thread-safe 
implementation when there are multiple threads. It should not have a 
performance issue since the locking is at hashmap bucket level, not object 
level.

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-2.001.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.001.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.branch-1.001.patch
HBASE-22804.branch-2.001.patch
HBASE-22804.master.001.patch
Status: Patch Available  (was: Open)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 2.1.5, 2.0.0, 1.4.0, 1.3.0, 3.0.0, 1.5.0, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.master.001.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-2.000.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.master.000.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.000.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.001.patch
HBASE-22804.branch-2.001.patch
HBASE-22804.branch-1.001.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-07 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.000.patch
HBASE-22804.branch-2.000.patch
HBASE-22804.branch-1.000.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.000.patch, 
> HBASE-22804.branch-2.000.patch, HBASE-22804.master.000.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-07 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-2.000.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-07 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.branch-1.000.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-2.000.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-07 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: (was: HBASE-22804.master.000.patch)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-2.000.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-07 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Attachment: HBASE-22804.master.000.patch
HBASE-22804.branch-2.000.patch
HBASE-22804.branch-1.000.patch

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22804.branch-1.000.patch, 
> HBASE-22804.branch-2.000.patch, HBASE-22804.master.000.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-06 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Description: 
At present HBase Canary tool only prints the successes as part of logs. 
Providing an API to get the list of successes, as well as total number of 
expected regions, will make it easier to get a more accurate availability 
estimate.
  

  was:
At present HBase Canary tool only prints the successes as part of logs. 
Providing an API to get the number of successes, as well as total number of 
expected regions, will make it easier to get a more accurate availability 
estimate.
  


> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-06 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Summary: Provide an API to get list of successful regions and total 
expected regions in Canary  (was: Provide an API to get number of successful 
regions and total expected regions in Canary)

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the number of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get number of successful regions and total expected regions in Canary

2019-08-06 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Labels: Canary  (was: )

> Provide an API to get number of successful regions and total expected regions 
> in Canary
> ---
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the number of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get number of successful regions and total expected regions in Canary

2019-08-06 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Description: 
At present HBase Canary tool only prints the successes as part of logs. 
Providing an API to get the number of successes, as well as total number of 
expected regions, will make it easier to get a more accurate availability 
estimate.
  

  was:
At present HBase Canary tool only prints the successes as part of logs. 
Providing an API to get the list of successes, as well as total number of 
expected regions, will make it easier to get a more accurate availability 
estimate.
 


> Provide an API to get number of successful regions and total expected regions 
> in Canary
> ---
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the number of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22804) Provide an API to get number of successful regions and total expected regions in Canary

2019-08-06 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22804:
-
Summary: Provide an API to get number of successful regions and total 
expected regions in Canary  (was: Provide an API to get list of successful 
regions and total expected regions in Canary)

> Provide an API to get number of successful regions and total expected regions 
> in Canary
> ---
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
>  Issue Type: Improvement
>  Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary

2019-08-06 Thread Caroline (JIRA)
Caroline created HBASE-22804:


 Summary: Provide an API to get list of successful regions and 
total expected regions in Canary
 Key: HBASE-22804
 URL: https://issues.apache.org/jira/browse/HBASE-22804
 Project: HBase
  Issue Type: Improvement
  Components: canary
Affects Versions: 2.1.5, 2.0.0, 1.4.0, 1.3.0, 3.0.0, 1.5.0, 2.2.1
Reporter: Caroline
Assignee: Caroline


At present HBase Canary tool only prints the successes as part of logs. 
Providing an API to get the list of successes, as well as total number of 
expected regions, will make it easier to get a more accurate availability 
estimate.
 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (HBASE-22378) HBase Canary fails with TableNotFoundException when table deleted during Canary run

2019-05-10 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22378:
-
Attachment: HBASE-22378.master.000.patch

> HBase Canary fails with TableNotFoundException when table deleted during 
> Canary run
> ---
>
> Key: HBASE-22378
> URL: https://issues.apache.org/jira/browse/HBASE-22378
> Project: HBase
>  Issue Type: Bug
>  Components: canary
>Affects Versions: 1.3.0, 1.4.0, 1.5.0
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22378.000.patch, HBASE-22378.branch-1.001.patch, 
> HBASE-22378.branch-2.001.patch, HBASE-22378.master.000.patch
>
>
> In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions 
> thrown by HBase Canary. We traced the issue back to Canary trying to call 
> isTableEnabled() on temporary tables that were deleted in the middle of the 
> Canary run.
> In this version of HBase Canary, Canary throws TableNotFoundException (and 
> then fails) if a table is deleted between admin.listTables() and 
> admin.tableEnabled() function calls in RegionMonitor's sniff() method. 
> Following the goal of RegionMonitor.sniff(), which is to query all existing 
> tables, in order to reduce noise we should skip over a table (i.e. don't 
> check if it was enabled, or do anything else with it at all) if it was 
> returned in listTables() but deleted before Canary can query it. Temporary 
> tables which are not meant to be kept should not throw 
> TableNotFoundExceptions which fail the Canary.
> Patch in progress:
> Add a call to admin.tableExists() before tableEnabled() on line 1244 in 
> RegionMonitor.sniff().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-22378) HBase Canary fails with TableNotFoundException when table deleted during Canary run

2019-05-08 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22378:
-
Attachment: HBASE-22378.000.patch
HBASE-22378.branch-1.001.patch
HBASE-22378.branch-2.001.patch
Status: Patch Available  (was: Open)

> HBase Canary fails with TableNotFoundException when table deleted during 
> Canary run
> ---
>
> Key: HBASE-22378
> URL: https://issues.apache.org/jira/browse/HBASE-22378
> Project: HBase
>  Issue Type: Bug
>  Components: canary
>Affects Versions: 1.4.0, 1.3.0, 1.5.0
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
>  Labels: Canary
> Attachments: HBASE-22378.000.patch, HBASE-22378.branch-1.001.patch, 
> HBASE-22378.branch-2.001.patch
>
>
> In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions 
> thrown by HBase Canary. We traced the issue back to Canary trying to call 
> isTableEnabled() on temporary tables that were deleted in the middle of the 
> Canary run.
> In this version of HBase Canary, Canary throws TableNotFoundException (and 
> then fails) if a table is deleted between admin.listTables() and 
> admin.tableEnabled() function calls in RegionMonitor's sniff() method. 
> Following the goal of RegionMonitor.sniff(), which is to query all existing 
> tables, in order to reduce noise we should skip over a table (i.e. don't 
> check if it was enabled, or do anything else with it at all) if it was 
> returned in listTables() but deleted before Canary can query it. Temporary 
> tables which are not meant to be kept should not throw 
> TableNotFoundExceptions which fail the Canary.
> Patch in progress:
> Add a call to admin.tableExists() before tableEnabled() on line 1244 in 
> RegionMonitor.sniff().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-22378) HBase Canary fails with TableNotFoundException when table deleted during Canary run

2019-05-07 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22378:
-
Description: 
In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions thrown 
by HBase Canary. We traced the issue back to Canary trying to call 
isTableEnabled() on temporary tables that were deleted in the middle of the 
Canary run.

In this version of HBase Canary, Canary throws TableNotFoundException (and then 
fails) if a table is deleted between admin.listTables() and 
admin.tableEnabled() function calls in RegionMonitor's sniff() method. 
Following the goal of RegionMonitor.sniff(), which is to query all existing 
tables, in order to reduce noise we should skip over a table (i.e. don't check 
if it was enabled, or do anything else with it at all) if it was returned in 
listTables() but deleted before Canary can query it. Temporary tables which are 
not meant to be kept should not throw TableNotFoundExceptions which fail the 
Canary.

 

GUS work item: 
[https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B006RzxzIAC/view]

Patch in progress:

Add a call to admin.tableExists() before tableEnabled() on line 1244 in 
RegionMonitor.sniff().

  was:
In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions thrown 
by HBase Canary. We traced the issue back to Canary trying to call 
isTableEnabled() on temporary tables that were deleted in the middle of the 
Canary run.

In this version of HBase Canary, Canary throws TableNotFoundException (and then 
fails) if a table is deleted between admin.listTables() and 
admin.tableEnabled() function calls in RegionMonitor's sniff() method. 
Following the goal of sniff(), which is to query all existing tables, in order 
to reduce noise we should skip over a table (i.e. don't check if it was 
enabled, or do anything else with it at all) if it was returned in listTables() 
but deleted before Canary can query it. Temporary tables which are not meant to 
be kept should not throw TableNotFoundExceptions which fail the Canary.

 

Patch in progress:

Add a call to admin.tableExists() before tableEnabled() on line 1244 in 
RegionMonitor.sniff().


> HBase Canary fails with TableNotFoundException when table deleted during 
> Canary run
> ---
>
> Key: HBASE-22378
> URL: https://issues.apache.org/jira/browse/HBASE-22378
> Project: HBase
>  Issue Type: Bug
>  Components: canary
>Affects Versions: 1.3.0, 1.4.0, 1.5.0
>Reporter: Caroline
>Priority: Minor
>  Labels: Canary
>
> In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions 
> thrown by HBase Canary. We traced the issue back to Canary trying to call 
> isTableEnabled() on temporary tables that were deleted in the middle of the 
> Canary run.
> In this version of HBase Canary, Canary throws TableNotFoundException (and 
> then fails) if a table is deleted between admin.listTables() and 
> admin.tableEnabled() function calls in RegionMonitor's sniff() method. 
> Following the goal of RegionMonitor.sniff(), which is to query all existing 
> tables, in order to reduce noise we should skip over a table (i.e. don't 
> check if it was enabled, or do anything else with it at all) if it was 
> returned in listTables() but deleted before Canary can query it. Temporary 
> tables which are not meant to be kept should not throw 
> TableNotFoundExceptions which fail the Canary.
>  
> GUS work item: 
> [https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B006RzxzIAC/view]
> Patch in progress:
> Add a call to admin.tableExists() before tableEnabled() on line 1244 in 
> RegionMonitor.sniff().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (HBASE-22378) HBase Canary fails with TableNotFoundException when table deleted during Canary run

2019-05-07 Thread Caroline (JIRA)


 [ 
https://issues.apache.org/jira/browse/HBASE-22378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caroline updated HBASE-22378:
-
Description: 
In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions thrown 
by HBase Canary. We traced the issue back to Canary trying to call 
isTableEnabled() on temporary tables that were deleted in the middle of the 
Canary run.

In this version of HBase Canary, Canary throws TableNotFoundException (and then 
fails) if a table is deleted between admin.listTables() and 
admin.tableEnabled() function calls in RegionMonitor's sniff() method. 
Following the goal of sniff(), which is to query all existing tables, in order 
to reduce noise we should skip over a table (i.e. don't check if it was 
enabled, or do anything else with it at all) if it was returned in listTables() 
but deleted before Canary can query it. Temporary tables which are not meant to 
be kept should not throw TableNotFoundExceptions which fail the Canary.

 

Patch in progress:

Add a call to admin.tableExists() before tableEnabled() on line 1244 in 
RegionMonitor.sniff().

  was:
In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions thrown 
by HBase Canary. We traced the issue back to Canary trying to call 
isTableEnabled() on temporary tables that were deleted in the middle of the 
Canary run.

In this version of HBase Canary, Canary throws TableNotFoundException (and then 
fails) if a table is deleted between admin.listTables() and admin.tableExists() 
function calls in RegionMonitor's sniff() method. Following the goal of 
sniff(), which is to query all existing tables, in order to reduce noise we 
should skip over a table (i.e. don't check if it was enabled, or do anything 
else with it at all) if it was returned in listTables() but deleted before 
Canary can query it. Temporary tables which are not meant to be kept should not 
throw TableNotFoundExceptions which fail the Canary.


> HBase Canary fails with TableNotFoundException when table deleted during 
> Canary run
> ---
>
> Key: HBASE-22378
> URL: https://issues.apache.org/jira/browse/HBASE-22378
> Project: HBase
>  Issue Type: Bug
>  Components: canary
>Affects Versions: 1.3.0, 1.4.0, 1.5.0
>Reporter: Caroline
>Priority: Minor
>  Labels: Canary
>
> In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions 
> thrown by HBase Canary. We traced the issue back to Canary trying to call 
> isTableEnabled() on temporary tables that were deleted in the middle of the 
> Canary run.
> In this version of HBase Canary, Canary throws TableNotFoundException (and 
> then fails) if a table is deleted between admin.listTables() and 
> admin.tableEnabled() function calls in RegionMonitor's sniff() method. 
> Following the goal of sniff(), which is to query all existing tables, in 
> order to reduce noise we should skip over a table (i.e. don't check if it was 
> enabled, or do anything else with it at all) if it was returned in 
> listTables() but deleted before Canary can query it. Temporary tables which 
> are not meant to be kept should not throw TableNotFoundExceptions which fail 
> the Canary.
>  
> Patch in progress:
> Add a call to admin.tableExists() before tableEnabled() on line 1244 in 
> RegionMonitor.sniff().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (HBASE-22378) HBase Canary fails with TableNotFoundException when table deleted during Canary run

2019-05-07 Thread Caroline (JIRA)
Caroline created HBASE-22378:


 Summary: HBase Canary fails with TableNotFoundException when table 
deleted during Canary run
 Key: HBASE-22378
 URL: https://issues.apache.org/jira/browse/HBASE-22378
 Project: HBase
  Issue Type: Bug
  Components: canary
Affects Versions: 1.4.0, 1.3.0, 1.5.0
Reporter: Caroline


In 1.3.2 branch-1, we saw a drastic increase in TableNotFoundExceptions thrown 
by HBase Canary. We traced the issue back to Canary trying to call 
isTableEnabled() on temporary tables that were deleted in the middle of the 
Canary run.

In this version of HBase Canary, Canary throws TableNotFoundException (and then 
fails) if a table is deleted between admin.listTables() and admin.tableExists() 
function calls in RegionMonitor's sniff() method. Following the goal of 
sniff(), which is to query all existing tables, in order to reduce noise we 
should skip over a table (i.e. don't check if it was enabled, or do anything 
else with it at all) if it was returned in listTables() but deleted before 
Canary can query it. Temporary tables which are not meant to be kept should not 
throw TableNotFoundExceptions which fail the Canary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)