[jira] [Commented] (HBASE-20610) Procedure V2 - Distributed Log Splitting
[ https://issues.apache.org/jira/browse/HBASE-20610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138045#comment-17138045 ] Jingyun Tian commented on HBASE-20610: -- [~stack] Looks good to me for the split manager part. Sorry that I didn't follow HBase for a while, I don't know the context of getProcName(). > Procedure V2 - Distributed Log Splitting > > > Key: HBASE-20610 > URL: https://issues.apache.org/jira/browse/HBASE-20610 > Project: HBase > Issue Type: Umbrella > Components: proc-v2 >Reporter: Guanghao Zhang >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0-alpha-1 > > Attachments: HBASE-20610.master.001.patch > > > Now master and regionserver use zk to coordinate log split tasks. The split > log manager manages all log files which need to be scanned and split. Then > the split log manager places all the logs into the ZooKeeper splitWAL node > (/hbase/splitWAL) as tasks and monitors these task nodes and waits for them > to be processed. Each regionserver watch splitWAL znode and grab task when > node children changed. And regionserver does the work to split the logs. > Open this umbrella issue to move this "coordinate" work to use new procedure > v2 framework and reduce zk depencency. Plan to finish this before 3.0 > release. Any suggestions are welcomed. Thanks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Resolution: Fixed Status: Resolved (was: Patch Available) > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.branch-2.001.patch, > HBASE-22454.branch-2.001.patch, HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851484#comment-16851484 ] Jingyun Tian commented on HBASE-22454: -- pushed to branch-2. > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.branch-2.001.patch, > HBASE-22454.branch-2.001.patch, HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851450#comment-16851450 ] Jingyun Tian commented on HBASE-22454: -- These failed UTs are flaky, they all passed on my own desktop. > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.branch-2.001.patch, > HBASE-22454.branch-2.001.patch, HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: HBASE-22454.branch-2.001.patch > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.branch-2.001.patch, > HBASE-22454.branch-2.001.patch, HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850330#comment-16850330 ] Jingyun Tian commented on HBASE-22454: -- pushed to master. Branch-2 has some conflicts with this patch, thus I uploaded a patch for it. > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.branch-2.001.patch, > HBASE-22454.master.001.patch, HBASE-22454.master.002.patch, > HBASE-22454.master.003.patch, HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: HBASE-22454.branch-2.001.patch > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.branch-2.001.patch, > HBASE-22454.master.001.patch, HBASE-22454.master.002.patch, > HBASE-22454.master.003.patch, HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850321#comment-16850321 ] Jingyun Tian commented on HBASE-22454: -- Sure. [~zghaobac] Thanks for your review. > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: (was: HBASE-22454.master.003.patch) > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: HBASE-22454.master.003.patch > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: HBASE-22454.master.003.patch > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch, > HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: HBASE-22454.master.003.patch > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch, HBASE-22454.master.003.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: HBASE-22454.master.002.patch > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch, > HBASE-22454.master.002.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Status: Patch Available (was: Open) > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22454) refactor WALSplitter
[ https://issues.apache.org/jira/browse/HBASE-22454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22454: - Attachment: HBASE-22454.master.001.patch > refactor WALSplitter > > > Key: HBASE-22454 > URL: https://issues.apache.org/jira/browse/HBASE-22454 > Project: HBase > Issue Type: Improvement >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22454.master.001.patch > > > WALSplitter is more than 2000 lines right now. It's hard to read and > understand. There are multiple inner classes which are not simple and many > static methods. > My plan is to separate these classes and move these static methods to a new > util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22454) refactor WALSplitter
Jingyun Tian created HBASE-22454: Summary: refactor WALSplitter Key: HBASE-22454 URL: https://issues.apache.org/jira/browse/HBASE-22454 Project: HBase Issue Type: Improvement Reporter: Jingyun Tian Assignee: Jingyun Tian WALSplitter is more than 2000 lines right now. It's hard to read and understand. There are multiple inner classes which are not simple and many static methods. My plan is to separate these classes and move these static methods to a new util class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817278#comment-16817278 ] Jingyun Tian commented on HBASE-21965: -- [~busbey] [~Apache9], This patch could go to different hbase versions, since it only find these problematic regions by scan meta or compare regioninfos on FS. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch, HBASE-21965.master.014.patch, > HBASE-21965.master.014.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22234) Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
Jingyun Tian created HBASE-22234: Summary: Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated Key: HBASE-22234 URL: https://issues.apache.org/jira/browse/HBASE-22234 Project: HBase Issue Type: Bug Reporter: Jingyun Tian -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-22234) Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated
[ https://issues.apache.org/jira/browse/HBASE-22234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian reassigned HBASE-22234: Assignee: Jingyun Tian > Fix flaky TestHbck#testRecoverSplitAfterMetaUpdated > --- > > Key: HBASE-22234 > URL: https://issues.apache.org/jira/browse/HBASE-22234 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813316#comment-16813316 ] Jingyun Tian commented on HBASE-21965: -- These tests are not related to my patch and they all passed on my own desktop except TestReplicationSyncUpToolWithMultipleWAL, there may be some problem with it. Pushed to master and branch-2. Thanks [~Apache9] for reviewing. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch, HBASE-21965.master.014.patch, > HBASE-21965.master.014.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.014.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch, HBASE-21965.master.014.patch, > HBASE-21965.master.014.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.014.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch, HBASE-21965.master.014.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.013.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch, > HBASE-21965.master.013.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Resolution: Fixed Status: Resolved (was: Patch Available) > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3., 2. > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Fix Version/s: 3. 2. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3., 2. > > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798844#comment-16798844 ] Jingyun Tian commented on HBASE-21965: -- pushed to master and branch-2. Thanks [~zghaobac] for reviewing. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.012.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch, HBASE-21965.master.012.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22049) RegionStateStore cannot recover SPLIT state from Meta for split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Attachment: HBASE-22049.master.005.patch
> RegionStateStore cannot recover SPLIT state from Meta for split parent region
> -
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.004.patch,
> HBASE-22049.master.005.patch
>
>
>
> Now the split procedure is to unassign the split parent region, thus the
> state is CLOSED. And it only modify the regionInfo column during meta
> updating.
> {code}
> Put putParent = makePutFromRegionInfo(RegionInfoBuilder.newBuilder(parent)
> .setOffline(true)
> .setSplit(true).build(), time);
> {code}
> Thus if we want to recover the state from meta for a split parent region, its
> state is CLOSED instead of SPLIT.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.011.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch, > HBASE-21965.master.011.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.010.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch, HBASE-21965.master.010.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.009.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch, > HBASE-21965.master.009.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.008.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: (was: HBASE-21965.master.008.patch) > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.008.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch, HBASE-21965.master.008.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.007.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch, > HBASE-21965.master.007.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.007.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch, HBASE-21965.master.007.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22049) RegionStateStore cannot recover SPLIT state from Meta for split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Description:
Now the split procedure is to unassign the split parent region, thus the state
is CLOSED. And it only modify the regionInfo column during meta updating.
{code}
Put putParent = makePutFromRegionInfo(RegionInfoBuilder.newBuilder(parent)
.setOffline(true)
.setSplit(true).build(), time);
{code}
Thus if we want to recover the state from meta for a split parent region, its
state is CLOSED instead of SPLIT.
was:
After we modify some attributes of table, hbaseAdmin will getAlterStatus to
check if all region's attributes updated. It will skip opened region and split
region as the following code shows.
{code}
for (RegionState regionState: states) {
if (!regionState.isOpened() && !regionState.isSplit()) {
ritCount++;
}
}
{code}
But since now the split procedure is to unassign the split parent region, thus
the state is CLOSED， and the check will hang there until timeout.
> RegionStateStore cannot recover SPLIT state from Meta for split parent region
> -
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.004.patch
>
>
>
> Now the split procedure is to unassign the split parent region, thus the
> state is CLOSED. And it only modify the regionInfo column during meta
> updating.
> {code}
> Put putParent = makePutFromRegionInfo(RegionInfoBuilder.newBuilder(parent)
> .setOffline(true)
> .setSplit(true).build(), time);
> {code}
> Thus if we want to recover the state from meta for a split parent region, its
> state is CLOSED instead of SPLIT.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22049) RegionStateStore cannot recover SPLIT state from Meta for split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Summary: RegionStateStore cannot recover SPLIT state from Meta for split
parent region (was: getReopenStatus() didn't skip counting split parent region)
> RegionStateStore cannot recover SPLIT state from Meta for split parent region
> -
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch,
> HBASE-22049.master.002.patch, HBASE-22049.master.003.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22049) RegionStateStore cannot recover SPLIT state from Meta for split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Attachment: (was: HBASE-22049.master.001.patch)
> RegionStateStore cannot recover SPLIT state from Meta for split parent region
> -
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.004.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22049) RegionStateStore cannot recover SPLIT state from Meta for split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Attachment: (was: HBASE-22049.master.003.patch)
> RegionStateStore cannot recover SPLIT state from Meta for split parent region
> -
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.004.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22049) RegionStateStore cannot recover SPLIT state from Meta for split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Attachment: (was: HBASE-22049.master.002.patch)
> RegionStateStore cannot recover SPLIT state from Meta for split parent region
> -
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.004.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22049) RegionStateStore cannot recover SPLIT state from Meta for split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Attachment: HBASE-22049.master.004.patch
> RegionStateStore cannot recover SPLIT state from Meta for split parent region
> -
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch,
> HBASE-22049.master.002.patch, HBASE-22049.master.003.patch,
> HBASE-22049.master.004.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.006.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch, > HBASE-21965.master.006.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796842#comment-16796842
]
Jingyun Tian commented on HBASE-22049:
--
After HBASE-22002, the problem of this issue doesn't exist any more. But the
region state issue still exist, I'll update a new patch to add an UT for this.
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch,
> HBASE-22049.master.002.patch, HBASE-22049.master.003.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796838#comment-16796838 ] Jingyun Tian commented on HBASE-22061: -- Pushed to master, branch-2 and branch-2.2, thanks [~allan163] for reviewing. > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.1, 2.2 > > Attachments: HBASE-22061.master.001.patch, > HBASE-22061.master.002.patch > > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure holding the lock of > merged region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22061: - Resolution: Fixed Status: Resolved (was: Patch Available) > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.1, 2.2 > > Attachments: HBASE-22061.master.001.patch, > HBASE-22061.master.002.patch > > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure holding the lock of > merged region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22061: - Fix Version/s: 2.2 2.1 3.0.0 > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Fix For: 3.0.0, 2.1, 2.2 > > Attachments: HBASE-22061.master.001.patch, > HBASE-22061.master.002.patch > > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure holding the lock of > merged region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796748#comment-16796748
]
Jingyun Tian commented on HBASE-22049:
--
[~stack] why we doesn't write the state SPLIT to column state now? When Master
restart the RegionStateStore cannot recover the state SPLIT based on the
information in meta currently.
Maybe the best way to solve this problem is to add the state SPLIT to meta as
how we did before?
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch,
> HBASE-22049.master.002.patch, HBASE-22049.master.003.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.005.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch, HBASE-21965.master.005.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22061: - Attachment: HBASE-22061.master.002.patch > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22061.master.001.patch, > HBASE-22061.master.002.patch > > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure holding the lock of > merged region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795858#comment-16795858
]
Jingyun Tian commented on HBASE-22049:
--
These failed UTs are not related to my patch. They all passed at local.
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch,
> HBASE-22049.master.002.patch, HBASE-22049.master.003.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.004.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch, > HBASE-21965.master.004.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22061: - Attachment: HBASE-22061.master.001.patch > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22061.master.001.patch > > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure holding the lock of > merged region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22061: - Status: Patch Available (was: Open) > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-22061.master.001.patch > > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure holding the lock of > merged region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian reassigned HBASE-22061: Assignee: Jingyun Tian > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure holding the lock of > merged region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-22061: - Description: Currently SplitTableRegionProcedure only hold the region of parent region. But during processing of this procedure, after the daughter regions are updated to meta, other procedures can grab the lock of them, which is the situation we don't want to see. So I think SplitTableRegionProcedure should hold the lock of parent region and its daughter regions like MergeTableRegionsProcedure holding the lock of merged region. was: Currently SplitTableRegionProcedure only hold the region of parent region. But during processing of this procedure, after the daughter regions are updated to meta, other procedures can grab the lock of them, which is the situation we don't want to see. So I think SplitTableRegionProcedure should hold the lock of parent region and its daughter regions like MergeTableRegionsProcedure. > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Priority: Major > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure holding the lock of > merged region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[ https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795731#comment-16795731 ] Jingyun Tian commented on HBASE-22061: -- Yes. It's not daughter region. It's merged region. > SplitTableRegionProcedure should hold the lock of its daughter regions > -- > > Key: HBASE-22061 > URL: https://issues.apache.org/jira/browse/HBASE-22061 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Priority: Major > > Currently SplitTableRegionProcedure only hold the region of parent region. > But during processing of this procedure, after the daughter regions are > updated to meta, other procedures can grab the lock of them, which is the > situation we don't want to see. > So I think SplitTableRegionProcedure should hold the lock of parent region > and its daughter regions like MergeTableRegionsProcedure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
[
https://issues.apache.org/jira/browse/HBASE-22061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795727#comment-16795727
]
Jingyun Tian commented on HBASE-22061:
--
[~Apache9] Yes.
{code}
protected LockState acquireLock(final MasterProcedureEnv env) {
if (env.getProcedureScheduler().waitRegions(this, getTableName(),
mergedRegion, regionsToMerge[0], regionsToMerge[1])) {
try {
LOG.debug(LockState.LOCK_EVENT_WAIT + " " +
env.getProcedureScheduler().dumpLocks());
} catch (IOException e) {
// Ignore, just for logging
}
return LockState.LOCK_EVENT_WAIT;
}
return LockState.LOCK_ACQUIRED;
}
{code}
> SplitTableRegionProcedure should hold the lock of its daughter regions
> --
>
> Key: HBASE-22061
> URL: https://issues.apache.org/jira/browse/HBASE-22061
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Priority: Major
>
> Currently SplitTableRegionProcedure only hold the region of parent region.
> But during processing of this procedure, after the daughter regions are
> updated to meta, other procedures can grab the lock of them, which is the
> situation we don't want to see.
> So I think SplitTableRegionProcedure should hold the lock of parent region
> and its daughter regions like MergeTableRegionsProcedure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22061) SplitTableRegionProcedure should hold the lock of its daughter regions
Jingyun Tian created HBASE-22061: Summary: SplitTableRegionProcedure should hold the lock of its daughter regions Key: HBASE-22061 URL: https://issues.apache.org/jira/browse/HBASE-22061 Project: HBase Issue Type: Bug Reporter: Jingyun Tian Currently SplitTableRegionProcedure only hold the region of parent region. But during processing of this procedure, after the daughter regions are updated to meta, other procedures can grab the lock of them, which is the situation we don't want to see. So I think SplitTableRegionProcedure should hold the lock of parent region and its daughter regions like MergeTableRegionsProcedure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.003.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch, HBASE-21965.master.003.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Attachment: HBASE-22049.master.003.patch
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch,
> HBASE-22049.master.002.patch, HBASE-22049.master.003.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.002.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch, > HBASE-21965.master.002.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Attachment: HBASE-22049.master.002.patch
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch,
> HBASE-22049.master.002.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793432#comment-16793432
]
Jingyun Tian commented on HBASE-22049:
--
[~Apache9] Failed test is not related to my patch. But the root cause is when
master restart, the flag of isSplit cannot be restore. Maybe we should try to
fix this?
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Status: Patch Available (was: Reopened) > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Attachment: HBASE-21965.master.001.patch > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > Attachments: HBASE-21965.master.001.patch > > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Comment: was deleted (was: Checking region consistency in hbck-1 should be able to fix this problem and HBASE-21966. Let me migrate it to hbck-2 and merge these 2 issues.) > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Status: Patch Available (was: Open)
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-22049:
-
Attachment: HBASE-22049.master.001.patch
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
> Attachments: HBASE-22049.master.001.patch
>
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792300#comment-16792300
]
Jingyun Tian commented on HBASE-22049:
--
The problem is still exist. Because current procedure didn't update state=split
to META. Once Master restart, this check will still failed until CatalogJanitor
clean the parent region.
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
[
https://issues.apache.org/jira/browse/HBASE-22049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791561#comment-16791561
]
Jingyun Tian commented on HBASE-22049:
--
HBASE-21795, Found this patch, I think we are facing the same problem. But I
think that patch can not solve the problem. Let me check the code.
> getReopenStatus() didn't skip counting split parent region
> --
>
> Key: HBASE-22049
> URL: https://issues.apache.org/jira/browse/HBASE-22049
> Project: HBase
> Issue Type: Bug
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Major
>
> After we modify some attributes of table, hbaseAdmin will getAlterStatus to
> check if all region's attributes updated. It will skip opened region and
> split region as the following code shows.
> {code}
> for (RegionState regionState: states) {
> if (!regionState.isOpened() && !regionState.isSplit()) {
> ritCount++;
> }
> }
> {code}
> But since now the split procedure is to unassign the split parent region,
> thus the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22049) getReopenStatus() didn't skip counting split parent region
Jingyun Tian created HBASE-22049:
Summary: getReopenStatus() didn't skip counting split parent region
Key: HBASE-22049
URL: https://issues.apache.org/jira/browse/HBASE-22049
Project: HBase
Issue Type: Bug
Reporter: Jingyun Tian
Assignee: Jingyun Tian
After we modify some attributes of table, hbaseAdmin will getAlterStatus to
check if all region's attributes updated. It will skip opened region and split
region as the following code shows.
{code}
for (RegionState regionState: states) {
if (!regionState.isOpened() && !regionState.isSplit()) {
ritCount++;
}
}
{code}
But since now the split procedure is to unassign the split parent region, thus
the state is CLOSED， and the check will hang there until timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786477#comment-16786477 ] Jingyun Tian commented on HBASE-21965: -- Checking region consistency in hbck-1 should be able to fix this problem and HBASE-21966. Let me migrate it to hbck-2 and merge these 2 issues. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785444#comment-16785444 ] Jingyun Tian edited comment on HBASE-21965 at 3/6/19 9:51 AM: -- After checking the code, I think there are 2 situations we need to handle: # daughter regions are created but not updated to meta yet: Parent region is in state of CLOSED right now. For this situation, If daughter directories are still under the parent directories, simply open the parent region should solve the problem. Because during region opening, split directories will be deleted. But if daughter directories is already moved out from parent split directory, then we need to find and delete them. # daughter regions are created and updated to meta already: Parent region is in state CLOSED and there are informations about daughters in meta. I think we can consider split succeed at this time. What we should do is try to assign the daughters. And Merge procedure should have the similar story. [~Apache9] [~zghaobac] Please take a look. was (Author: tianjingyun): After checking the code, I think there are 2 situations we need to handle: # daughter regions are created but not updated to meta yet: Parent region is in state of CLOSED right now. For this situation, simply open the parent region should solve the problem. Because during region opening, all daughter directories will be removed. # daughter regions are created and updated to meta already: Parent region is in state CLOSED and there are informations about daughters in meta. I think we can consider split succeed at this time. What we should do is try to assign the daughters. And Merge procedure should have the similar story. [~Apache9] [~zghaobac] Please take a look. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785444#comment-16785444 ] Jingyun Tian edited comment on HBASE-21965 at 3/6/19 9:42 AM: -- After checking the code, I think there are 2 situations we need to handle: # daughter regions are created but not updated to meta yet: Parent region is in state of CLOSED right now. For this situation, simply open the parent region should solve the problem. Because during region opening, all daughter directories will be removed. # daughter regions are created and updated to meta already: Parent region is in state CLOSED and there are informations about daughters in meta. I think we can consider split succeed at this time. What we should do is try to assign the daughters. And Merge procedure should have the similar story. [~Apache9] [~zghaobac] Please take a look. was (Author: tianjingyun): After checking the code, I think there are 2 situations we need to handle: # daughter regions are created but not updated to meta yet: Parent region is in state of CLOSED right now. For this situation, simply open the parent region should solve the problem. Because during region opening, all daughter directories will be removed. # daughter regions are created and updated to meta already: Parent region is in state CLOSED and there are informations about daughters in meta. I think we can consider split succeed at this time. What we should do is try to assign the daughters. And Merge procedure should have the similar story. [~Apache9] Please take a look. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785444#comment-16785444 ] Jingyun Tian commented on HBASE-21965: -- After checking the code, I think there are 2 situations we need to handle: # daughter regions are created but not updated to meta yet: Parent region is in state of CLOSED right now. For this situation, simply open the parent region should solve the problem. Because during region opening, all daughter directories will be removed. # daughter regions are created and updated to meta already: Parent region is in state CLOSED and there are informations about daughters in meta. I think we can consider split succeed at this time. What we should do is try to assign the daughters. And Merge procedure should have the similar story. [~Apache9] Please take a look. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Resolution: Fixed Status: Resolved (was: Patch Available) > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.1.001.patch, > HBASE-21934.branch-2.1.002.patch, HBASE-21934.branch-2.1.003.patch, > HBASE-21934.branch-2.2.001.patch, HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch, > HBASE-21934.master.008.patch, HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.branch-2.1.003.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.1.001.patch, > HBASE-21934.branch-2.1.002.patch, HBASE-21934.branch-2.1.003.patch, > HBASE-21934.branch-2.2.001.patch, HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch, > HBASE-21934.master.008.patch, HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782922#comment-16782922 ] Jingyun Tian commented on HBASE-21934: -- New patch is uploaded, failed tests all passed locally. Thanks [~Apache9] for help review. > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.1.001.patch, > HBASE-21934.branch-2.1.002.patch, HBASE-21934.branch-2.2.001.patch, > HBASE-21934.master.001.patch, HBASE-21934.master.002.patch, > HBASE-21934.master.003.patch, HBASE-21934.master.004.patch, > HBASE-21934.master.005.patch, HBASE-21934.master.006.patch, > HBASE-21934.master.007.patch, HBASE-21934.master.008.patch, > HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.branch-2.1.002.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.1.001.patch, > HBASE-21934.branch-2.1.002.patch, HBASE-21934.branch-2.2.001.patch, > HBASE-21934.master.001.patch, HBASE-21934.master.002.patch, > HBASE-21934.master.003.patch, HBASE-21934.master.004.patch, > HBASE-21934.master.005.patch, HBASE-21934.master.006.patch, > HBASE-21934.master.007.patch, HBASE-21934.master.008.patch, > HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782419#comment-16782419 ] Jingyun Tian commented on HBASE-21934: -- These are tests failed with patch for branch-2.1, let me check. > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.1.001.patch, > HBASE-21934.branch-2.2.001.patch, HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch, > HBASE-21934.master.008.patch, HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.branch-2.1.001.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.1.001.patch, > HBASE-21934.branch-2.2.001.patch, HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch, > HBASE-21934.master.008.patch, HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781521#comment-16781521 ] Jingyun Tian commented on HBASE-21934: -- These failed test can pass on my own desktop, and they are mostly Replicas related tests. It should be no related to my patch. Pushed to branch-2 and branch-2.2. Waiting for the QA report of branch-2.1. > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.2.001.patch, > HBASE-21934.master.001.patch, HBASE-21934.master.002.patch, > HBASE-21934.master.003.patch, HBASE-21934.master.004.patch, > HBASE-21934.master.005.patch, HBASE-21934.master.006.patch, > HBASE-21934.master.007.patch, HBASE-21934.master.008.patch, > HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781261#comment-16781261 ] Jingyun Tian commented on HBASE-21934: -- Yes. The code are same. I just rename the patch for branch-2... > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.2.001.patch, > HBASE-21934.master.001.patch, HBASE-21934.master.002.patch, > HBASE-21934.master.003.patch, HBASE-21934.master.004.patch, > HBASE-21934.master.005.patch, HBASE-21934.master.006.patch, > HBASE-21934.master.007.patch, HBASE-21934.master.008.patch, > HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.branch-2.2.001.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.2.001.patch, > HBASE-21934.master.001.patch, HBASE-21934.master.002.patch, > HBASE-21934.master.003.patch, HBASE-21934.master.004.patch, > HBASE-21934.master.005.patch, HBASE-21934.master.006.patch, > HBASE-21934.master.007.patch, HBASE-21934.master.008.patch, > HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781249#comment-16781249 ] Jingyun Tian commented on HBASE-21934: -- Pushed to Master and submit patch for branch-2 and branch-2.1. Thanks [~Apache9] and [~zghaobac] for helping review. > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch, > HBASE-21934.master.008.patch, HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781254#comment-16781254 ] Jingyun Tian commented on HBASE-21934: -- [~zghaobac] patch for branch-2.2 is uploaded too. > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.branch-2.2.001.patch, > HBASE-21934.master.001.patch, HBASE-21934.master.002.patch, > HBASE-21934.master.003.patch, HBASE-21934.master.004.patch, > HBASE-21934.master.005.patch, HBASE-21934.master.006.patch, > HBASE-21934.master.007.patch, HBASE-21934.master.008.patch, > HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.branch-2.1.001.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.branch-2.1.001.patch, HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch, > HBASE-21934.master.008.patch, HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.branch-2.001.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.branch-2.001.patch, > HBASE-21934.master.001.patch, HBASE-21934.master.002.patch, > HBASE-21934.master.003.patch, HBASE-21934.master.004.patch, > HBASE-21934.master.005.patch, HBASE-21934.master.006.patch, > HBASE-21934.master.007.patch, HBASE-21934.master.008.patch, > HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.master.009.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch, > HBASE-21934.master.008.patch, HBASE-21934.master.009.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.master.008.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch, > HBASE-21934.master.008.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.master.007.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: (was: HBASE-21934.master.007.patch) > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21934) RemoteProcedureDispatcher should track the ongoing dispatched calls
[ https://issues.apache.org/jira/browse/HBASE-21934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21934: - Attachment: HBASE-21934.master.007.patch > RemoteProcedureDispatcher should track the ongoing dispatched calls > --- > > Key: HBASE-21934 > URL: https://issues.apache.org/jira/browse/HBASE-21934 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.x >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Blocker > Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.4 > > Attachments: HBASE-21934.master.001.patch, > HBASE-21934.master.002.patch, HBASE-21934.master.003.patch, > HBASE-21934.master.004.patch, HBASE-21934.master.005.patch, > HBASE-21934.master.006.patch, HBASE-21934.master.007.patch > > > I encounter the problem that when master assign a splitWALRemoteProcedure to > a region server. The log of this region server says it failed to recover the > lease of this file. Then this region server is killed by chaosMonkey. As the > result, this procedure is not timeout and hang there forever. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21966) Fix region holes, overlaps, and other region related errors
Jingyun Tian created HBASE-21966: Summary: Fix region holes, overlaps, and other region related errors Key: HBASE-21966 URL: https://issues.apache.org/jira/browse/HBASE-21966 Project: HBase Issue Type: Sub-task Reporter: Jingyun Tian Assignee: Jingyun Tian -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Description: Make HBCK2 be able to fix failed split and merge transactions that have failed to roll back. > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > > Make HBCK2 be able to fix failed split and merge transactions that have > failed to roll back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian reopened HBASE-21965: -- > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian updated HBASE-21965: - Issue Type: Sub-task (was: Task) Parent: HBASE-21745 > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Sub-task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
[ https://issues.apache.org/jira/browse/HBASE-21965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingyun Tian resolved HBASE-21965. -- Resolution: Invalid > Fix failed split and merge transactions that have failed to roll back > - > > Key: HBASE-21965 > URL: https://issues.apache.org/jira/browse/HBASE-21965 > Project: HBase > Issue Type: Task >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-21965) Fix failed split and merge transactions that have failed to roll back
Jingyun Tian created HBASE-21965: Summary: Fix failed split and merge transactions that have failed to roll back Key: HBASE-21965 URL: https://issues.apache.org/jira/browse/HBASE-21965 Project: HBase Issue Type: Task Reporter: Jingyun Tian Assignee: Jingyun Tian -- This message was sent by Atlassian JIRA (v7.6.3#76005)
