[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158381#comment-15158381
]
Rick Moritz commented on HBASE-15247:
-
Thanks for the quick fix, Amal!
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 2.0.0, 1.1.1
>Reporter: Rick Moritz
>Assignee: Amal Joshy
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15247-branch-1.1.patch, HBASE-15247.patch
>
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
Rick Moritz created HBASE-15247:
---
Summary: InclusiveStopFilter does not respect reverse Filter
property
Key: HBASE-15247
URL: https://issues.apache.org/jira/browse/HBASE-15247
Project: HBase
Issue Type: Bug
Components: Filters
Affects Versions: 1.1.1
Reporter: Rick Moritz
InclusiveStopFilter only works with non-reversed Scans, it will not filter for
reversed Scans, because it doesn't flip the cmp-operand in the reversed case.
In fact, it doesn't even use the Filter.reverse flag.
it should be something like this:
if (reversed) {
if (cmp > 0) {
done = true;
}
}
else {
if (cmp < 0) {
done = true;
}
}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15247) InclusiveStopFilter does not respect reverse Filter property
[
https://issues.apache.org/jira/browse/HBASE-15247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141076#comment-15141076
]
Rick Moritz commented on HBASE-15247:
-
I'd rather leave this as a "noobie"-level issue for someone wanting to get into
HBase. The bit of code itself is pretty simple, but I'm not too keen to figure
out the project structure, test design etc. at this point.
Still, if no one picks it up by end of this month, I'll give it a go myself.
> InclusiveStopFilter does not respect reverse Filter property
>
>
> Key: HBASE-15247
> URL: https://issues.apache.org/jira/browse/HBASE-15247
> Project: HBase
> Issue Type: Bug
> Components: Filters
>Affects Versions: 1.1.1
>Reporter: Rick Moritz
>
> InclusiveStopFilter only works with non-reversed Scans, it will not filter
> for reversed Scans, because it doesn't flip the cmp-operand in the reversed
> case. In fact, it doesn't even use the Filter.reverse flag.
> it should be something like this:
> if (reversed) {
> if (cmp > 0) {
> done = true;
> }
> }
> else {
> if (cmp < 0) {
> done = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14532) [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config and not described in section 7
[ https://issues.apache.org/jira/browse/HBASE-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952623#comment-14952623 ] Rick Moritz commented on HBASE-14532: - Looks good, many thanks. > [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config > and not described in section 7 > - > > Key: HBASE-14532 > URL: https://issues.apache.org/jira/browse/HBASE-14532 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Rick Moritz >Assignee: Misty Stanley-Jones >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14532.patch > > > After trying to figure out whether shortcircuit reads would work on my > system, I studied the book and found conflicting information. > It's suggested in section 92.2, that dfs.client.read.shortcircuit is an > option in hbase-site.xml, but the supposedly complete default configuration > in section 7 does not include this setting. This leads to confusion on > whether it's sufficient to enable this setting in hdfs-site.xml, or whether > it needs to be added to both configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14532) [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config and not described in section 7
Rick Moritz created HBASE-14532: --- Summary: [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config and not described in section 7 Key: HBASE-14532 URL: https://issues.apache.org/jira/browse/HBASE-14532 Project: HBase Issue Type: Bug Components: documentation Reporter: Rick Moritz Priority: Minor After trying to figure out whether shortcircuit reads would work on my system, I studied the book and found conflicting information. It's suggested in section 92.2, that dfs.client.read.shortcircuit is an option in hbase-site.xml, but the supposedly complete default configuration in section 7 does not include this setting. This leads to confusion on whether it's sufficient to enable this setting in hdfs-site.xml, or whether it needs to be added to both configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14532) [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config and not described in section 7
[ https://issues.apache.org/jira/browse/HBASE-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939937#comment-14939937 ] Rick Moritz commented on HBASE-14532: - I'll also abuse this issue to note, that in Section 33, the link to [compaction] has been broken -- probably not worth its own issue. > [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config > and not described in section 7 > - > > Key: HBASE-14532 > URL: https://issues.apache.org/jira/browse/HBASE-14532 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Rick Moritz >Priority: Minor > > After trying to figure out whether shortcircuit reads would work on my > system, I studied the book and found conflicting information. > It's suggested in section 92.2, that dfs.client.read.shortcircuit is an > option in hbase-site.xml, but the supposedly complete default configuration > in section 7 does not include this setting. This leads to confusion on > whether it's sufficient to enable this setting in hdfs-site.xml, or whether > it needs to be added to both configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14532) [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config and not described in section 7
[ https://issues.apache.org/jira/browse/HBASE-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939851#comment-14939851 ] Rick Moritz commented on HBASE-14532: - Never mind, I finished reading the issue, and it's only for testing currently. > [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config > and not described in section 7 > - > > Key: HBASE-14532 > URL: https://issues.apache.org/jira/browse/HBASE-14532 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Rick Moritz >Priority: Minor > > After trying to figure out whether shortcircuit reads would work on my > system, I studied the book and found conflicting information. > It's suggested in section 92.2, that dfs.client.read.shortcircuit is an > option in hbase-site.xml, but the supposedly complete default configuration > in section 7 does not include this setting. This leads to confusion on > whether it's sufficient to enable this setting in hdfs-site.xml, or whether > it needs to be added to both configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14532) [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config and not described in section 7
[ https://issues.apache.org/jira/browse/HBASE-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939940#comment-14939940 ] Rick Moritz commented on HBASE-14532: - idem in 9.2.8 > [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config > and not described in section 7 > - > > Key: HBASE-14532 > URL: https://issues.apache.org/jira/browse/HBASE-14532 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Rick Moritz >Priority: Minor > > After trying to figure out whether shortcircuit reads would work on my > system, I studied the book and found conflicting information. > It's suggested in section 92.2, that dfs.client.read.shortcircuit is an > option in hbase-site.xml, but the supposedly complete default configuration > in section 7 does not include this setting. This leads to confusion on > whether it's sufficient to enable this setting in hdfs-site.xml, or whether > it needs to be added to both configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14532) [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config and not described in section 7
[ https://issues.apache.org/jira/browse/HBASE-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939838#comment-14939838 ] Rick Moritz commented on HBASE-14532: - Additionally, HBASE-6783 should be documented as well - currently the documentation does not indicate that short circuit reads are default. > [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config > and not described in section 7 > - > > Key: HBASE-14532 > URL: https://issues.apache.org/jira/browse/HBASE-14532 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Rick Moritz >Priority: Minor > > After trying to figure out whether shortcircuit reads would work on my > system, I studied the book and found conflicting information. > It's suggested in section 92.2, that dfs.client.read.shortcircuit is an > option in hbase-site.xml, but the supposedly complete default configuration > in section 7 does not include this setting. This leads to confusion on > whether it's sufficient to enable this setting in hdfs-site.xml, or whether > it needs to be added to both configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
