[jira] [Updated] (HBASE-28514) HBase web console automatically listing directories in static/css directory
[ https://issues.apache.org/jira/browse/HBASE-28514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-28514: - Summary: HBase web console automatically listing directories in static/css directory (was: HBase web console automatically listing directories in static/css) > HBase web console automatically listing directories in static/css directory > --- > > Key: HBASE-28514 > URL: https://issues.apache.org/jira/browse/HBASE-28514 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > Labels: pull-request-available > Attachments: image-2024-04-24-12-15-56-959.png > > > HBase web console automatically lists directories present in > \{link-to-master-ui}/static/css. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28514) HBase web console automatically listing directories in static/css
[ https://issues.apache.org/jira/browse/HBASE-28514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-28514: - Attachment: image-2024-04-24-12-15-56-959.png Description: HBase web console automatically lists directories present in \{link-to-master-ui}/static/css. !image-2024-04-24-12-15-56-959.png! was:HBase web console automatically lists directories present in \{link-to-master-ui}/static/css. > HBase web console automatically listing directories in static/css > - > > Key: HBASE-28514 > URL: https://issues.apache.org/jira/browse/HBASE-28514 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > Labels: pull-request-available > Attachments: image-2024-04-24-12-15-56-959.png > > > HBase web console automatically lists directories present in > \{link-to-master-ui}/static/css. > > !image-2024-04-24-12-15-56-959.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28514) HBase web console automatically listing directories in static/css
[ https://issues.apache.org/jira/browse/HBASE-28514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-28514: - Description: HBase web console automatically lists directories present in \{link-to-master-ui}/static/css. was: HBase web console automatically lists directories present in \{link-to-master-ui}/static/css. !image-2024-04-24-12-15-56-959.png! > HBase web console automatically listing directories in static/css > - > > Key: HBASE-28514 > URL: https://issues.apache.org/jira/browse/HBASE-28514 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > Labels: pull-request-available > Attachments: image-2024-04-24-12-15-56-959.png > > > HBase web console automatically lists directories present in > \{link-to-master-ui}/static/css. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28514) HBase web console automatically listing directories in static/css
[ https://issues.apache.org/jira/browse/HBASE-28514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-28514: - Status: Patch Available (was: In Progress) > HBase web console automatically listing directories in static/css > - > > Key: HBASE-28514 > URL: https://issues.apache.org/jira/browse/HBASE-28514 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > Labels: pull-request-available > > HBase web console automatically lists directories present in > \{link-to-master-ui}/static/css. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-28514) HBase web console automatically listing directories in static/css
[ https://issues.apache.org/jira/browse/HBASE-28514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28514 started by Shanmukha Haripriya Kota. > HBase web console automatically listing directories in static/css > - > > Key: HBASE-28514 > URL: https://issues.apache.org/jira/browse/HBASE-28514 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > HBase web console automatically lists directories present in > \{link-to-master-ui}/static/css. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28514) HBase web console automatically listing directories in static/css
Shanmukha Haripriya Kota created HBASE-28514: Summary: HBase web console automatically listing directories in static/css Key: HBASE-28514 URL: https://issues.apache.org/jira/browse/HBASE-28514 Project: HBase Issue Type: Bug Components: UI Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota HBase web console automatically lists directories present in \{link-to-master-ui}/static/css. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27795) Define RPC API for cache cleaning
[ https://issues.apache.org/jira/browse/HBASE-27795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27795: - Status: Patch Available (was: In Progress) > Define RPC API for cache cleaning > - > > Key: HBASE-27795 > URL: https://issues.apache.org/jira/browse/HBASE-27795 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Shanmukha Haripriya Kota >Priority: Major > > We should add an RPC API to allow for a "limited manual" cache cleaning. If > hbase.rs.evictblocksonclose is set to false, blocks may hang in the cache > upon regions move between RSes. > The method at the RS level, should compare the files from its online regions > against the files in the prefetch list file, evicting blocks from the files > in the prefetch list file that are not in any of the online regions for the > given RS. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27794) Tooling for parsing/reading the prefetch files list file
[ https://issues.apache.org/jira/browse/HBASE-27794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27794: - Status: Patch Available (was: Open) > Tooling for parsing/reading the prefetch files list file > > > Key: HBASE-27794 > URL: https://issues.apache.org/jira/browse/HBASE-27794 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > The content of the file defined by hbase.prefetch.file.list.path is encoded. > It would be nice to have some extra tool for properly parsing it and print > the list in human readable format, for easy of troubleshooting. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27795) Define RPC API for cache cleaning
[ https://issues.apache.org/jira/browse/HBASE-27795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27795 started by Shanmukha Haripriya Kota. > Define RPC API for cache cleaning > - > > Key: HBASE-27795 > URL: https://issues.apache.org/jira/browse/HBASE-27795 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Shanmukha Haripriya Kota >Priority: Major > > We should add an RPC API to allow for a "limited manual" cache cleaning. If > hbase.rs.evictblocksonclose is set to false, blocks may hang in the cache > upon regions move between RSes. > The method at the RS level, should compare the files from its online regions > against the files in the prefetch list file, evicting blocks from the files > in the prefetch list file that are not in any of the online regions for the > given RS. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27852) Interrupt BucketCachePersister thread when BucketCache is shutdown
[ https://issues.apache.org/jira/browse/HBASE-27852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27852: - Status: Patch Available (was: In Progress) > Interrupt BucketCachePersister thread when BucketCache is shutdown > -- > > Key: HBASE-27852 > URL: https://issues.apache.org/jira/browse/HBASE-27852 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Affects Versions: 3.0.0-alpha-3, 2.6.0 >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Recent changes with BucketCachePersister caused this unit test > [TestVerifyBucketCacheFile.testRetrieveFromFile()|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5222/3/testReport/org.apache.hadoop.hbase.io.hfile.bucket/TestVerifyBucketCacheFile/precommit_checks___yetus_jdk8_Hadoop2_checks___testRetrieveFromFile_1__blockSize_16_384__bucketSizes__I_1151e434_/] > to become flaky. > The BucketCachePersister thread keeps running even after > BucketCache.shutdown() is run and we do not clear the contents of the > backingMap during the shutdown if cache persistence is enabled causing this > test to fail. BucketCachePersister should be interrupted in > BucketCache.shutdown(). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27852) Interrupt BucketCachePersister thread when BucketCache is shutdown
[ https://issues.apache.org/jira/browse/HBASE-27852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27852 started by Shanmukha Haripriya Kota. > Interrupt BucketCachePersister thread when BucketCache is shutdown > -- > > Key: HBASE-27852 > URL: https://issues.apache.org/jira/browse/HBASE-27852 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Affects Versions: 2.6.0, 3.0.0-alpha-3 >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Recent changes with BucketCachePersister caused this unit test > [TestVerifyBucketCacheFile.testRetrieveFromFile()|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5222/3/testReport/org.apache.hadoop.hbase.io.hfile.bucket/TestVerifyBucketCacheFile/precommit_checks___yetus_jdk8_Hadoop2_checks___testRetrieveFromFile_1__blockSize_16_384__bucketSizes__I_1151e434_/] > to become flaky. > The BucketCachePersister thread keeps running even after > BucketCache.shutdown() is run and we do not clear the contents of the > backingMap during the shutdown if cache persistence is enabled causing this > test to fail. BucketCachePersister should be interrupted in > BucketCache.shutdown(). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27852) Interrupt BucketCachePersister thread when BucketCache is shutdown
[ https://issues.apache.org/jira/browse/HBASE-27852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27852: - Affects Version/s: 2.6.0 (was: 2.5.5) > Interrupt BucketCachePersister thread when BucketCache is shutdown > -- > > Key: HBASE-27852 > URL: https://issues.apache.org/jira/browse/HBASE-27852 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Affects Versions: 2.6.0, 3.0.0-alpha-3 >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Recent changes with BucketCachePersister caused this unit test > [TestVerifyBucketCacheFile.testRetrieveFromFile()|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5222/3/testReport/org.apache.hadoop.hbase.io.hfile.bucket/TestVerifyBucketCacheFile/precommit_checks___yetus_jdk8_Hadoop2_checks___testRetrieveFromFile_1__blockSize_16_384__bucketSizes__I_1151e434_/] > to become flaky. > The BucketCachePersister thread keeps running even after > BucketCache.shutdown() is run and we do not clear the contents of the > backingMap during the shutdown if cache persistence is enabled causing this > test to fail. BucketCachePersister should be interrupted in > BucketCache.shutdown(). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27852) Interrupt BucketCachePersister thread when BucketCache is shutdown
[ https://issues.apache.org/jira/browse/HBASE-27852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27852: - Description: Recent changes with BucketCachePersister caused this unit test [TestVerifyBucketCacheFile.testRetrieveFromFile()|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5222/3/testReport/org.apache.hadoop.hbase.io.hfile.bucket/TestVerifyBucketCacheFile/precommit_checks___yetus_jdk8_Hadoop2_checks___testRetrieveFromFile_1__blockSize_16_384__bucketSizes__I_1151e434_/] to become flaky. The BucketCachePersister thread keeps running even after BucketCache.shutdown() is run and we do not clear the contents of the backingMap during the shutdown if cache persistence is enabled causing this test to fail. BucketCachePersister should be interrupted in BucketCache.shutdown(). > Interrupt BucketCachePersister thread when BucketCache is shutdown > -- > > Key: HBASE-27852 > URL: https://issues.apache.org/jira/browse/HBASE-27852 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Affects Versions: 3.0.0-alpha-3, 2.5.5 >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Recent changes with BucketCachePersister caused this unit test > [TestVerifyBucketCacheFile.testRetrieveFromFile()|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5222/3/testReport/org.apache.hadoop.hbase.io.hfile.bucket/TestVerifyBucketCacheFile/precommit_checks___yetus_jdk8_Hadoop2_checks___testRetrieveFromFile_1__blockSize_16_384__bucketSizes__I_1151e434_/] > to become flaky. > The BucketCachePersister thread keeps running even after > BucketCache.shutdown() is run and we do not clear the contents of the > backingMap during the shutdown if cache persistence is enabled causing this > test to fail. BucketCachePersister should be interrupted in > BucketCache.shutdown(). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27852) Interrupt BucketCachePersister thread when BucketCache is shutdown
[ https://issues.apache.org/jira/browse/HBASE-27852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-27852: Assignee: Shanmukha Haripriya Kota > Interrupt BucketCachePersister thread when BucketCache is shutdown > -- > > Key: HBASE-27852 > URL: https://issues.apache.org/jira/browse/HBASE-27852 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Affects Versions: 3.0.0-alpha-3, 2.5.5 >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27852) Interrupt BucketCachePersister thread when BucketCache is shutdown
[ https://issues.apache.org/jira/browse/HBASE-27852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27852: - Affects Version/s: 2.5.5 3.0.0-alpha-3 > Interrupt BucketCachePersister thread when BucketCache is shutdown > -- > > Key: HBASE-27852 > URL: https://issues.apache.org/jira/browse/HBASE-27852 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Affects Versions: 3.0.0-alpha-3, 2.5.5 >Reporter: Shanmukha Haripriya Kota >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27852) Interrupt BucketCachePersister thread when BucketCache is shutdown
[ https://issues.apache.org/jira/browse/HBASE-27852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27852: - Parent: HBASE-27743 Issue Type: Sub-task (was: Bug) > Interrupt BucketCachePersister thread when BucketCache is shutdown > -- > > Key: HBASE-27852 > URL: https://issues.apache.org/jira/browse/HBASE-27852 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27852) Interrupt BucketCachePersister thread when BucketCache is shutdown
Shanmukha Haripriya Kota created HBASE-27852: Summary: Interrupt BucketCachePersister thread when BucketCache is shutdown Key: HBASE-27852 URL: https://issues.apache.org/jira/browse/HBASE-27852 Project: HBase Issue Type: Bug Components: BucketCache Reporter: Shanmukha Haripriya Kota -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27795) Define RPC API for cache cleaning
[ https://issues.apache.org/jira/browse/HBASE-27795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-27795: Assignee: Shanmukha Haripriya Kota > Define RPC API for cache cleaning > - > > Key: HBASE-27795 > URL: https://issues.apache.org/jira/browse/HBASE-27795 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Shanmukha Haripriya Kota >Priority: Major > > We should add an RPC API to allow for a "limited manual" cache cleaning. If > hbase.rs.evictblocksonclose is set to false, blocks may hang in the cache > upon regions move between RSes. > The method at the RS level, should compare the files from its online regions > against the files in the prefetch list file, evicting blocks from the files > in the prefetch list file that are not in any of the online regions for the > given RS. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27794) Tooling for parsing/reading the prefetch files list file
[ https://issues.apache.org/jira/browse/HBASE-27794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-27794: Assignee: Shanmukha Haripriya Kota > Tooling for parsing/reading the prefetch files list file > > > Key: HBASE-27794 > URL: https://issues.apache.org/jira/browse/HBASE-27794 > Project: HBase > Issue Type: Sub-task >Reporter: Wellington Chevreuil >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > The content of the file defined by hbase.prefetch.file.list.path is encoded. > It would be nice to have some extra tool for properly parsing it and print > the list in human readable format, for easy of troubleshooting. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27752) Update the list of prefetched files upon region movement
[ https://issues.apache.org/jira/browse/HBASE-27752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27752: - Status: Patch Available (was: In Progress) > Update the list of prefetched files upon region movement > > > Key: HBASE-27752 > URL: https://issues.apache.org/jira/browse/HBASE-27752 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Currently, we maintain a list of Hfiles on disk for which prefetch is > complete and avoid prefetching those files after a restart. But we don't > handle cases where blocks are evicted from the cache. This ticket is for > updating the list of prefetched files when the region is moved but the blocks > from that region are not evicted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27752) Update the list of prefetched files upon region movement
[ https://issues.apache.org/jira/browse/HBASE-27752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27752 started by Shanmukha Haripriya Kota. > Update the list of prefetched files upon region movement > > > Key: HBASE-27752 > URL: https://issues.apache.org/jira/browse/HBASE-27752 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Currently, we maintain a list of Hfiles on disk for which prefetch is > complete and avoid prefetching those files after a restart. But we don't > handle cases where blocks are evicted from the cache. This ticket is for > updating the list of prefetched files when the region is moved but the blocks > from that region are not evicted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27750) Update the list of prefetched hfiles upon simple block eviction
[ https://issues.apache.org/jira/browse/HBASE-27750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705369#comment-17705369 ] Shanmukha Haripriya Kota commented on HBASE-27750: -- Thank you, [~wchevreuil] > Update the list of prefetched hfiles upon simple block eviction > --- > > Key: HBASE-27750 > URL: https://issues.apache.org/jira/browse/HBASE-27750 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Affects Versions: 2.6.0, 3.0.0-alpha-4 >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > Fix For: 2.6.0, 3.0.0-alpha-4 > > > Currently, we maintain a list of Hfiles on disk for which prefetch is > complete and avoid prefetching those files after a restart. But we don't > handle cases where blocks are evicted from the cache. This ticket is for > updating the list of prefetched files upon simple block eviction. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27686) Recovery of BucketCache and Prefetched data after RS Crash
[ https://issues.apache.org/jira/browse/HBASE-27686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704710#comment-17704710 ] Shanmukha Haripriya Kota commented on HBASE-27686: -- I have included a fix for the flaky test in this [PR|[https://github.com/apache/hbase/pull/5140|https://github.com/apache/hbase/pull/5140)]] for HBASE-27750 > Recovery of BucketCache and Prefetched data after RS Crash > -- > > Key: HBASE-27686 > URL: https://issues.apache.org/jira/browse/HBASE-27686 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > HBASE-27313 introduced the ability to persist a list of hfiles for which > prefetch has already been completed, so the we can avoid prefetching those > files again in the event of a graceful restart, but it doesn't cover crash > scenarios, as if the RS is killed or abnormally stopped, the list wouldn't be > saved. > This change aims to persist the list of already prefetched from a background > thread that periodically checks cache state and persists the list if updates > have happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (HBASE-27686) Recovery of BucketCache and Prefetched data after RS Crash
[ https://issues.apache.org/jira/browse/HBASE-27686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704710#comment-17704710 ] Shanmukha Haripriya Kota edited comment on HBASE-27686 at 3/24/23 4:53 PM: --- I have included a fix for the flaky test in this PR ([https://github.com/apache/hbase/pull/5140) |https://github.com/apache/hbase/pull/5140)] for HBASE-27750 was (Author: sk...@cloudera.com): I have included a fix for the flaky test in this [PR|[https://github.com/apache/hbase/pull/5140|https://github.com/apache/hbase/pull/5140)]] for HBASE-27750 > Recovery of BucketCache and Prefetched data after RS Crash > -- > > Key: HBASE-27686 > URL: https://issues.apache.org/jira/browse/HBASE-27686 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > HBASE-27313 introduced the ability to persist a list of hfiles for which > prefetch has already been completed, so the we can avoid prefetching those > files again in the event of a graceful restart, but it doesn't cover crash > scenarios, as if the RS is killed or abnormally stopped, the list wouldn't be > saved. > This change aims to persist the list of already prefetched from a background > thread that periodically checks cache state and persists the list if updates > have happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27743) Update the list of prefetched Hfiles upon block eviction
[ https://issues.apache.org/jira/browse/HBASE-27743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27743: - Description: Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache or when the region is moved and the blocks from that region are evicted (or not evicted). The Hfile is kept in the prefetch list forever and over time the prefetch list would have all the files of the cluster and the prefetch would never be executed. This change aims to update the prefetched list of HFiles upon block eviction. was: Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache or when the region is moved and the blocks from that region are evicted. The Hfile is kept in the prefetch list forever and over time the prefetch list would have all the files of the cluster and the prefetch would never be executed. This change aims to update the prefetched list of HFiles upon block eviction. > Update the list of prefetched Hfiles upon block eviction > > > Key: HBASE-27743 > URL: https://issues.apache.org/jira/browse/HBASE-27743 > Project: HBase > Issue Type: Bug > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Currently, we maintain a list of Hfiles on disk for which prefetch is > complete and avoid prefetching those files after a restart. But we don't > handle cases where blocks are evicted from the cache or when the region is > moved and the blocks from that region are evicted (or not evicted). The Hfile > is kept in the prefetch list forever and over time the prefetch list would > have all the files of the cluster and the prefetch would never be executed. > This change aims to update the prefetched list of HFiles upon block eviction. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27752) Update the list of prefetched files upon region movement
[ https://issues.apache.org/jira/browse/HBASE-27752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27752: - Description: Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache. This ticket is for updating the list of prefetched files when the region is moved but the blocks from that region are not evicted. (was: Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache. This ticket is for updating the list of prefetched files when the region is moved and the blocks from that region are not evicted.) > Update the list of prefetched files upon region movement > > > Key: HBASE-27752 > URL: https://issues.apache.org/jira/browse/HBASE-27752 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Currently, we maintain a list of Hfiles on disk for which prefetch is > complete and avoid prefetching those files after a restart. But we don't > handle cases where blocks are evicted from the cache. This ticket is for > updating the list of prefetched files when the region is moved but the blocks > from that region are not evicted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27752) Update the list of prefetched files upon region movement
[ https://issues.apache.org/jira/browse/HBASE-27752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27752: - Description: Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache. This ticket is for updating the list of prefetched files when the region is moved and the blocks from that region are not evicted. > Update the list of prefetched files upon region movement > > > Key: HBASE-27752 > URL: https://issues.apache.org/jira/browse/HBASE-27752 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Currently, we maintain a list of Hfiles on disk for which prefetch is > complete and avoid prefetching those files after a restart. But we don't > handle cases where blocks are evicted from the cache. This ticket is for > updating the list of prefetched files when the region is moved and the blocks > from that region are not evicted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27752) Update the list of prefetched files upon region movement
Shanmukha Haripriya Kota created HBASE-27752: Summary: Update the list of prefetched files upon region movement Key: HBASE-27752 URL: https://issues.apache.org/jira/browse/HBASE-27752 Project: HBase Issue Type: Sub-task Components: BucketCache Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27750) Update the list of prefetched hfiles upon simple block eviction
[ https://issues.apache.org/jira/browse/HBASE-27750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27750: - Description: Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache. This ticket is for updating the list of prefetched files upon simple block eviction. > Update the list of prefetched hfiles upon simple block eviction > --- > > Key: HBASE-27750 > URL: https://issues.apache.org/jira/browse/HBASE-27750 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Currently, we maintain a list of Hfiles on disk for which prefetch is > complete and avoid prefetching those files after a restart. But we don't > handle cases where blocks are evicted from the cache. This ticket is for > updating the list of prefetched files upon simple block eviction. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27750) Update the list of prefetched hfiles upon simple block eviction
Shanmukha Haripriya Kota created HBASE-27750: Summary: Update the list of prefetched hfiles upon simple block eviction Key: HBASE-27750 URL: https://issues.apache.org/jira/browse/HBASE-27750 Project: HBase Issue Type: Sub-task Components: BucketCache Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27750) Update the list of prefetched hfiles upon simple block eviction
[ https://issues.apache.org/jira/browse/HBASE-27750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27750 started by Shanmukha Haripriya Kota. > Update the list of prefetched hfiles upon simple block eviction > --- > > Key: HBASE-27750 > URL: https://issues.apache.org/jira/browse/HBASE-27750 > Project: HBase > Issue Type: Sub-task > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27743) Update the list of prefetched Hfiles upon block eviction
[ https://issues.apache.org/jira/browse/HBASE-27743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27743 started by Shanmukha Haripriya Kota. > Update the list of prefetched Hfiles upon block eviction > > > Key: HBASE-27743 > URL: https://issues.apache.org/jira/browse/HBASE-27743 > Project: HBase > Issue Type: Bug > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Currently, we maintain a list of Hfiles on disk for which prefetch is > complete and avoid prefetching those files after a restart. But we don't > handle cases where blocks are evicted from the cache or when the region is > moved and the blocks from that region are evicted. The Hfile is kept in the > prefetch list forever and over time the prefetch list would have all the > files of the cluster and the prefetch would never be executed. This change > aims to update the prefetched list of HFiles upon block eviction. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27743) Update the list of prefetched Hfiles upon block eviction
Shanmukha Haripriya Kota created HBASE-27743: Summary: Update the list of prefetched Hfiles upon block eviction Key: HBASE-27743 URL: https://issues.apache.org/jira/browse/HBASE-27743 Project: HBase Issue Type: Bug Components: BucketCache Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache or when the region is moved and the blocks from that region are evicted. The Hfile is kept in the prefetch list forever and over time the prefetch list would have all the files of the cluster and the prefetch would never be executed. This change aims to update the prefetched list of HFiles upon block eviction. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27686) Recovery of BucketCache and Prefetched data after RS Crash
[ https://issues.apache.org/jira/browse/HBASE-27686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701269#comment-17701269 ] Shanmukha Haripriya Kota commented on HBASE-27686: -- Thanks, [~wchevreuil] > Recovery of BucketCache and Prefetched data after RS Crash > -- > > Key: HBASE-27686 > URL: https://issues.apache.org/jira/browse/HBASE-27686 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > HBASE-27313 introduced the ability to persist a list of hfiles for which > prefetch has already been completed, so the we can avoid prefetching those > files again in the event of a graceful restart, but it doesn't cover crash > scenarios, as if the RS is killed or abnormally stopped, the list wouldn't be > saved. > This change aims to persist the list of already prefetched from a background > thread that periodically checks cache state and persists the list if updates > have happened. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27686) Recovery of BucketCache and Prefetched data after RS Crash
Shanmukha Haripriya Kota created HBASE-27686: Summary: Recovery of BucketCache and Prefetched data after RS Crash Key: HBASE-27686 URL: https://issues.apache.org/jira/browse/HBASE-27686 Project: HBase Issue Type: Improvement Components: BucketCache Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27422) Support replication for hbase:acl
[ https://issues.apache.org/jira/browse/HBASE-27422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27422: - Status: Patch Available (was: In Progress) > Support replication for hbase:acl > - > > Key: HBASE-27422 > URL: https://issues.apache.org/jira/browse/HBASE-27422 > Project: HBase > Issue Type: Improvement > Components: acl, Replication >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > As of now, we allow replication only for user tables. > We should support replication for hbase:acl as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27422) Support replication for hbase:acl
[ https://issues.apache.org/jira/browse/HBASE-27422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27422 started by Shanmukha Haripriya Kota. > Support replication for hbase:acl > - > > Key: HBASE-27422 > URL: https://issues.apache.org/jira/browse/HBASE-27422 > Project: HBase > Issue Type: Improvement > Components: acl, Replication >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > As of now, we allow replication only for user tables. > We should support replication for hbase:acl as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27422) Support replication for hbase:acl
Shanmukha Haripriya Kota created HBASE-27422: Summary: Support replication for hbase:acl Key: HBASE-27422 URL: https://issues.apache.org/jira/browse/HBASE-27422 Project: HBase Issue Type: Improvement Components: acl, Replication Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota As of now, we allow replication only for user tables. We should support replication for hbase:acl as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27363) Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY
[ https://issues.apache.org/jira/browse/HBASE-27363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27363: - Status: Patch Available (was: In Progress) > Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY > - > > Key: HBASE-27363 > URL: https://issues.apache.org/jira/browse/HBASE-27363 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Trivial > > Change the config key for PREFETCH_PERSISTENCE_PATH_KEY to > hbase.prefetch.file.list.path -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27363) Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY
[ https://issues.apache.org/jira/browse/HBASE-27363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602432#comment-17602432 ] Shanmukha Haripriya Kota commented on HBASE-27363: -- Sure, I will address the spotbugs warning as well. > Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY > - > > Key: HBASE-27363 > URL: https://issues.apache.org/jira/browse/HBASE-27363 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Trivial > > Change the config key for PREFETCH_PERSISTENCE_PATH_KEY to > hbase.prefetch.file.list.path -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27363) Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY
[ https://issues.apache.org/jira/browse/HBASE-27363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27363 started by Shanmukha Haripriya Kota. > Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY > - > > Key: HBASE-27363 > URL: https://issues.apache.org/jira/browse/HBASE-27363 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Trivial > > Change the config key for PREFETCH_PERSISTENCE_PATH_KEY to > hbase.prefetch.file.list.path -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27363) Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY
Shanmukha Haripriya Kota created HBASE-27363: Summary: Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY Key: HBASE-27363 URL: https://issues.apache.org/jira/browse/HBASE-27363 Project: HBase Issue Type: Improvement Components: BucketCache Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota Change the config key for PREFETCH_PERSISTENCE_PATH_KEY to hbase.prefetch.file.list.path -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27313) Persist list of Hfiles names for which prefetch is done
[ https://issues.apache.org/jira/browse/HBASE-27313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601828#comment-17601828 ] Shanmukha Haripriya Kota commented on HBASE-27313: -- [~wchevreuil] Thank you for merging it. I will provide a PR for branch-2. > Persist list of Hfiles names for which prefetch is done > --- > > Key: HBASE-27313 > URL: https://issues.apache.org/jira/browse/HBASE-27313 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Affects Versions: 3.0.0-alpha-3 >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > Fix For: 3.0.0-alpha-4 > > > Persist list of Hfiles names for which prefetch is completed when persist for > in-memory bucket cache mapping state is enabled. > We need to persist the Set, which contains a list of all the HFiles for which > the prefetch has completed along with the In-memory state of the bucket cache > so that when we restart and if any prefetch is scheduled again for the same > HFile and we already have the in-memory state retrieved, we can skip the > prefetch for it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27313) Persist list of Hfiles names for which prefetch is done
[ https://issues.apache.org/jira/browse/HBASE-27313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-27313: - Status: Patch Available (was: In Progress) > Persist list of Hfiles names for which prefetch is done > --- > > Key: HBASE-27313 > URL: https://issues.apache.org/jira/browse/HBASE-27313 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Persist list of Hfiles names for which prefetch is completed when persist for > in-memory bucket cache mapping state is enabled. > We need to persist the Set, which contains a list of all the HFiles for which > the prefetch has completed along with the In-memory state of the bucket cache > so that when we restart and if any prefetch is scheduled again for the same > HFile and we already have the in-memory state retrieved, we can skip the > prefetch for it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27313) Persist list of Hfiles names for which prefetch is done
Shanmukha Haripriya Kota created HBASE-27313: Summary: Persist list of Hfiles names for which prefetch is done Key: HBASE-27313 URL: https://issues.apache.org/jira/browse/HBASE-27313 Project: HBase Issue Type: Improvement Components: BucketCache Reporter: Shanmukha Haripriya Kota Persist list of Hfiles names for which prefetch is completed when persist for in-memory bucket cache mapping state is enabled. We need to persist the Set, which contains a list of all the HFiles for which the prefetch has completed along with the In-memory state of the bucket cache so that when we restart and if any prefetch is scheduled again for the same HFile and we already have the in-memory state retrieved, we can skip the prefetch for it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27313) Persist list of Hfiles names for which prefetch is done
[ https://issues.apache.org/jira/browse/HBASE-27313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-27313: Assignee: Shanmukha Haripriya Kota > Persist list of Hfiles names for which prefetch is done > --- > > Key: HBASE-27313 > URL: https://issues.apache.org/jira/browse/HBASE-27313 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Persist list of Hfiles names for which prefetch is completed when persist for > in-memory bucket cache mapping state is enabled. > We need to persist the Set, which contains a list of all the HFiles for which > the prefetch has completed along with the In-memory state of the bucket cache > so that when we restart and if any prefetch is scheduled again for the same > HFile and we already have the in-memory state retrieved, we can skip the > prefetch for it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27313) Persist list of Hfiles names for which prefetch is done
[ https://issues.apache.org/jira/browse/HBASE-27313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27313 started by Shanmukha Haripriya Kota. > Persist list of Hfiles names for which prefetch is done > --- > > Key: HBASE-27313 > URL: https://issues.apache.org/jira/browse/HBASE-27313 > Project: HBase > Issue Type: Improvement > Components: BucketCache >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Major > > Persist list of Hfiles names for which prefetch is completed when persist for > in-memory bucket cache mapping state is enabled. > We need to persist the Set, which contains a list of all the HFiles for which > the prefetch has completed along with the In-memory state of the bucket cache > so that when we restart and if any prefetch is scheduled again for the same > HFile and we already have the in-memory state retrieved, we can skip the > prefetch for it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-25150) Metrics recording a time duration should use System.nanoTime()
[ https://issues.apache.org/jira/browse/HBASE-25150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-25150: Assignee: Shanmukha Haripriya Kota > Metrics recording a time duration should use System.nanoTime() > -- > > Key: HBASE-25150 > URL: https://issues.apache.org/jira/browse/HBASE-25150 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Nick Dimiduk >Assignee: Shanmukha Haripriya Kota >Priority: Major > > I was looking around in our table metrics and noticed that scan time is > collected using {{EnvironmentEdgeManager.currentTime()}}. This isn't a stable > way to measure a duration of time on the jvm. We should convert all these > occurrences to use {{TimeUnit.NANOSECONDS.toMillis(System.nanoTime())}} > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-25866) RESTServer should implement Hadoop's Tool interface
[ https://issues.apache.org/jira/browse/HBASE-25866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-25866: Assignee: Shanmukha Haripriya Kota > RESTServer should implement Hadoop's Tool interface > --- > > Key: HBASE-25866 > URL: https://issues.apache.org/jira/browse/HBASE-25866 > Project: HBase > Issue Type: Task > Components: REST >Reporter: Nick Dimiduk >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > The class that provides the main entry point for the REST gateway appears to > be entirely hand-constructed. Instead, this should probably use the common > {{Tool}} support provided by Hadoop, so that it can do things like parse > command line configuration parameters. For example, it could extend from > {{AbstractHBaseTool}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25866) RESTServer should implement Hadoop's Tool interface
[ https://issues.apache.org/jira/browse/HBASE-25866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347144#comment-17347144 ] Shanmukha Haripriya Kota commented on HBASE-25866: -- Hi, If this task is still open, I would like to work on this. Thank you. > RESTServer should implement Hadoop's Tool interface > --- > > Key: HBASE-25866 > URL: https://issues.apache.org/jira/browse/HBASE-25866 > Project: HBase > Issue Type: Task > Components: REST >Reporter: Nick Dimiduk >Priority: Minor > > The class that provides the main entry point for the REST gateway appears to > be entirely hand-constructed. Instead, this should probably use the common > {{Tool}} support provided by Hadoop, so that it can do things like parse > command line configuration parameters. For example, it could extend from > {{AbstractHBaseTool}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25794) Fix checkstyle violations in hbase-table-reporter module
[ https://issues.apache.org/jira/browse/HBASE-25794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-25794: - Status: Patch Available (was: Open) > Fix checkstyle violations in hbase-table-reporter module > > > Key: HBASE-25794 > URL: https://issues.apache.org/jira/browse/HBASE-25794 > Project: HBase > Issue Type: Task > Components: hbase-operator-tools >Reporter: Peter Somogyi >Assignee: Shanmukha Haripriya Kota >Priority: Trivial > Labels: beginner > > The hbase-table-reporter module in hbase-operator-tools has a bunch of > checkstyle violations. > {noformat} > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[22] > (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.Option' import. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[23] > (imports) ImportOrder: Wrong order for > 'org.apache.commons.cli.CommandLineParser' import. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[24] > (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.CommandLine' > import. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[34,8] > (imports) UnusedImports: Unused import - org.apache.hadoop.hbase.HRegionInfo. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[37] > (imports) AvoidStarImport: Using the '.*' form of import should be avoided - > org.apache.hadoop.hbase.client.*. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[41] > (imports) ImportOrder: Wrong order for 'java.io.BufferedWriter' import. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[66,1] > (design) HideUtilityClassConstructor: Utility classes should not have a > public or default constructor. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[94] > (sizes) LineLength: Line is longer than 100 characters (found 120). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[126] > (sizes) LineLength: Line is longer than 100 characters (found 105). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[132] > (sizes) LineLength: Line is longer than 100 characters (found 106). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[247] > (indentation) Indentation: 'throws' has incorrect indentation level 2, > expected level should be 4. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[275] > (sizes) LineLength: Line is longer than 100 characters (found 112). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[279] > (sizes) LineLength: Line is longer than 100 characters (found 105). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[308] > (sizes) LineLength: Line is longer than 100 characters (found 101). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[370] > (sizes) LineLength: Line is longer than 100 characters (found 121). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[371] > (sizes) LineLength: Line is longer than 100 characters (found 108). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[375] > (sizes) LineLength: Line is longer than 100 characters (found 102). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[401] > (sizes) LineLength: Line is longer than 100 characters (found 113). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[407] > (sizes) LineLength: Line is longer than 100 characters (found 112). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[410] > (sizes) LineLength: Line is longer than 100 characters (found 107). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[437] > (sizes) LineLength: Line is longer than 100 characters (found 114). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[438] > (sizes) LineLength: Line is longer than 100 characters (found 109). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[445] > (indentation) Indentation: 'throws' has incorrect indentation level 2, > expected level should be 4. > [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[27] > (imports) ImportOrder: Wrong order for 'java.util.ArrayList' import. > [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[30] > (imports) ImportOrder: Wrong order for > 'org.apache.hadoop.hbase.shaded.junit.framework.TestCase.assertEquals' import. > [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[59] > (sizes) LineLength: Line is longer than 100 characters (found 110). > [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.
[jira] [Commented] (HBASE-25816) Improve the documentation of "Architecture" section of reference guide
[ https://issues.apache.org/jira/browse/HBASE-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335833#comment-17335833 ] Shanmukha Haripriya Kota commented on HBASE-25816: -- I have created a [PR|https://github.com/apache/hbase/pull/3211] for this. Please review. Thanks, Shanmukha K > Improve the documentation of "Architecture" section of reference guide > -- > > Key: HBASE-25816 > URL: https://issues.apache.org/jira/browse/HBASE-25816 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > While going through the reference guide, I found these small changes that can > be made to the documentation of the "Architecture" part of it. Hence I'm > filing this Jira to track those changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25816) Improve the documentation of "Architecture" section of reference guide
[ https://issues.apache.org/jira/browse/HBASE-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-25816: - Status: Patch Available (was: Open) > Improve the documentation of "Architecture" section of reference guide > -- > > Key: HBASE-25816 > URL: https://issues.apache.org/jira/browse/HBASE-25816 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > While going through the reference guide, I found these small changes that can > be made to the documentation of the "Architecture" part of it. Hence I'm > filing this Jira to track those changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25816) Improve the documentation of "Architecture" section of reference guide
[ https://issues.apache.org/jira/browse/HBASE-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-25816: - Status: Patch Available (was: Open) > Improve the documentation of "Architecture" section of reference guide > -- > > Key: HBASE-25816 > URL: https://issues.apache.org/jira/browse/HBASE-25816 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > While going through the reference guide, I found these small changes that can > be made to the documentation of the "Architecture" part of it. Hence I'm > filing this Jira to track those changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25816) Improve the documentation of "Architecture" section of reference guide
[ https://issues.apache.org/jira/browse/HBASE-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota updated HBASE-25816: - Status: Open (was: Patch Available) > Improve the documentation of "Architecture" section of reference guide > -- > > Key: HBASE-25816 > URL: https://issues.apache.org/jira/browse/HBASE-25816 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > While going through the reference guide, I found these small changes that can > be made to the documentation of the "Architecture" part of it. Hence I'm > filing this Jira to track those changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work stopped] (HBASE-25816) Improve the documentation of "Architecture" section of reference guide
[ https://issues.apache.org/jira/browse/HBASE-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25816 stopped by Shanmukha Haripriya Kota. > Improve the documentation of "Architecture" section of reference guide > -- > > Key: HBASE-25816 > URL: https://issues.apache.org/jira/browse/HBASE-25816 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > While going through the reference guide, I found these small changes that can > be made to the documentation of the "Architecture" part of it. Hence I'm > filing this Jira to track those changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-25816) Improve the documentation of "Architecture" section of reference guide
[ https://issues.apache.org/jira/browse/HBASE-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25816 started by Shanmukha Haripriya Kota. > Improve the documentation of "Architecture" section of reference guide > -- > > Key: HBASE-25816 > URL: https://issues.apache.org/jira/browse/HBASE-25816 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > While going through the reference guide, I found these small changes that can > be made to the documentation of the "Architecture" part of it. Hence I'm > filing this Jira to track those changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-25794) Fix checkstyle violations in hbase-table-reporter module
[ https://issues.apache.org/jira/browse/HBASE-25794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-25794: Assignee: Shanmukha Haripriya Kota > Fix checkstyle violations in hbase-table-reporter module > > > Key: HBASE-25794 > URL: https://issues.apache.org/jira/browse/HBASE-25794 > Project: HBase > Issue Type: Task > Components: hbase-operator-tools >Reporter: Peter Somogyi >Assignee: Shanmukha Haripriya Kota >Priority: Trivial > Labels: beginner > > The hbase-table-reporter module in hbase-operator-tools has a bunch of > checkstyle violations. > {noformat} > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[22] > (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.Option' import. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[23] > (imports) ImportOrder: Wrong order for > 'org.apache.commons.cli.CommandLineParser' import. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[24] > (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.CommandLine' > import. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[34,8] > (imports) UnusedImports: Unused import - org.apache.hadoop.hbase.HRegionInfo. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[37] > (imports) AvoidStarImport: Using the '.*' form of import should be avoided - > org.apache.hadoop.hbase.client.*. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[41] > (imports) ImportOrder: Wrong order for 'java.io.BufferedWriter' import. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[66,1] > (design) HideUtilityClassConstructor: Utility classes should not have a > public or default constructor. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[94] > (sizes) LineLength: Line is longer than 100 characters (found 120). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[126] > (sizes) LineLength: Line is longer than 100 characters (found 105). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[132] > (sizes) LineLength: Line is longer than 100 characters (found 106). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[247] > (indentation) Indentation: 'throws' has incorrect indentation level 2, > expected level should be 4. > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[275] > (sizes) LineLength: Line is longer than 100 characters (found 112). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[279] > (sizes) LineLength: Line is longer than 100 characters (found 105). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[308] > (sizes) LineLength: Line is longer than 100 characters (found 101). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[370] > (sizes) LineLength: Line is longer than 100 characters (found 121). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[371] > (sizes) LineLength: Line is longer than 100 characters (found 108). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[375] > (sizes) LineLength: Line is longer than 100 characters (found 102). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[401] > (sizes) LineLength: Line is longer than 100 characters (found 113). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[407] > (sizes) LineLength: Line is longer than 100 characters (found 112). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[410] > (sizes) LineLength: Line is longer than 100 characters (found 107). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[437] > (sizes) LineLength: Line is longer than 100 characters (found 114). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[438] > (sizes) LineLength: Line is longer than 100 characters (found 109). > [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[445] > (indentation) Indentation: 'throws' has incorrect indentation level 2, > expected level should be 4. > [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[27] > (imports) ImportOrder: Wrong order for 'java.util.ArrayList' import. > [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[30] > (imports) ImportOrder: Wrong order for > 'org.apache.hadoop.hbase.shaded.junit.framework.TestCase.assertEquals' import. > [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[59] > (sizes) LineLength: Line is longer than 100 characters (found 110). > [ERROR] src/test/java/org/apache/hbase/reporter/TestTableRepo
[jira] [Created] (HBASE-25816) Improve the documentation of "Architecture" section of reference guide
Shanmukha Haripriya Kota created HBASE-25816: Summary: Improve the documentation of "Architecture" section of reference guide Key: HBASE-25816 URL: https://issues.apache.org/jira/browse/HBASE-25816 Project: HBase Issue Type: Improvement Components: documentation Reporter: Shanmukha Haripriya Kota Assignee: Shanmukha Haripriya Kota While going through the reference guide, I found these small changes that can be made to the documentation of the "Architecture" part of it. Hence I'm filing this Jira to track those changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-25795) Provide utility to validate a snapshot
[ https://issues.apache.org/jira/browse/HBASE-25795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shanmukha Haripriya Kota reassigned HBASE-25795: Assignee: Shanmukha Haripriya Kota > Provide utility to validate a snapshot > -- > > Key: HBASE-25795 > URL: https://issues.apache.org/jira/browse/HBASE-25795 > Project: HBase > Issue Type: Task > Components: snapshots >Reporter: Shanmukha Haripriya Kota >Assignee: Shanmukha Haripriya Kota >Priority: Minor > > Validate if there is a verify snapshot option present. If not, provide > utility to invoke the validation. > Currently, we are verifying snapshots in the ExportSnapshot utility. It will > be good to move that out to be used on its own as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25795) Provide utility to validate a snapshot
Shanmukha Haripriya Kota created HBASE-25795: Summary: Provide utility to validate a snapshot Key: HBASE-25795 URL: https://issues.apache.org/jira/browse/HBASE-25795 Project: HBase Issue Type: Task Components: snapshots Reporter: Shanmukha Haripriya Kota Validate if there is a verify snapshot option present. If not, provide utility to invoke the validation. Currently, we are verifying snapshots in the ExportSnapshot utility. It will be good to move that out to be used on its own as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)