[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-06-23 Thread Tim Sell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054036#comment-13054036
 ] 

Tim Sell commented on HBASE-1744:
-

I have been working on this, continuing work I did at the berlin buzzwords 
hbase hackday.
https://github.com/tims/hbase-thrift

I'll make a patch the fixes I made to Lars stuff and upload it here asap.

 Thrift server to match the new java api.
 

 Key: HBASE-1744
 URL: https://issues.apache.org/jira/browse/HBASE-1744
 Project: HBase
  Issue Type: Improvement
  Components: thrift
Reporter: Tim Sell
Assignee: Lars Francke
Priority: Critical
 Fix For: 0.92.0

 Attachments: HBASE-1744.2.patch, HBASE-1744.preview.1.patch, 
 thriftexperiment.patch


 This mutateRows, etc.. is a little confusing compared to the new cleaner java 
 client.
 Thinking of ways to make a thrift client that is just as elegant. something 
 like:
 void put(1:Bytes table, 2:TPut put) throws (1:IOError io)
 with:
 struct TColumn {
   1:Bytes family,
   2:Bytes qualifier,
   3:i64 timestamp
 }
 struct TPut {
   1:Bytes row,
   2:mapTColumn, Bytes values
 }
 This creates more verbose rpc  than if the columns in TPut were just 
 mapBytes, mapBytes, Bytes, but that is harder to fit timestamps into and 
 still be intuitive from say python.
 Presumably the goal of a thrift gateway is to be easy first.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-3561) OPTS arguments are duplicated

2011-02-28 Thread Tim Sell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13000233#comment-13000233
 ] 

Tim Sell commented on HBASE-3561:
-

Hi stack,
thanks for the quick fix. 

Just one minor note, the commented out lines in hbase-env should be reverted 
too. I've attached a patch to show the lines I mean.

 OPTS arguments are duplicated
 -

 Key: HBASE-3561
 URL: https://issues.apache.org/jira/browse/HBASE-3561
 Project: HBase
  Issue Type: Bug
  Components: scripts
Reporter: Tim Sell
Assignee: stack
 Fix For: 0.90.2

 Attachments: HelloWorldAgent.jar, config.txt


 Some of the command line arguments constructed in the bash scripts are 
 getting duplicated
 Here is what my HMaster process looks like with a ps aux | grep java.
 {code}
 /Library/Java/Home/bin/java 
 -Xmx1000m 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
 -Dhbase.log.file=hbase-tims-master-grassmann.local.log 
 -Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
 -Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
 -classpath blablablablabla
 org.apache.hadoop.hbase.master.HMaster start
 {code}
 This wouldn't really be a problem except if you try to add a java agent in 
 the hbase-env.sh like so:
 {code}
 export HBASE_MASTER_OPTS=$HBASE_MASTER_OPTS $HBASE_JMX_BASE 
 -Dcom.sun.management.jmxremote.port=10101 -javaagent:lib/HelloWorldAgent.jar
 {code}
 It adds the option 3 times and it starts three java agents. My example agent 
 print hello world once per second, but I end up with three hello world lines 
 per second.
 I attached my HelloWorldAgent.jar to demonstrate.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HBASE-3561) OPTS arguments are duplicated

2011-02-28 Thread Tim Sell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Sell updated HBASE-3561:


Attachment: hbase-env-commented.diff

 OPTS arguments are duplicated
 -

 Key: HBASE-3561
 URL: https://issues.apache.org/jira/browse/HBASE-3561
 Project: HBase
  Issue Type: Bug
  Components: scripts
Reporter: Tim Sell
Assignee: stack
 Fix For: 0.90.2

 Attachments: HelloWorldAgent.jar, config.txt, hbase-env-commented.diff


 Some of the command line arguments constructed in the bash scripts are 
 getting duplicated
 Here is what my HMaster process looks like with a ps aux | grep java.
 {code}
 /Library/Java/Home/bin/java 
 -Xmx1000m 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
 -Dhbase.log.file=hbase-tims-master-grassmann.local.log 
 -Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
 -Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
 -classpath blablablablabla
 org.apache.hadoop.hbase.master.HMaster start
 {code}
 This wouldn't really be a problem except if you try to add a java agent in 
 the hbase-env.sh like so:
 {code}
 export HBASE_MASTER_OPTS=$HBASE_MASTER_OPTS $HBASE_JMX_BASE 
 -Dcom.sun.management.jmxremote.port=10101 -javaagent:lib/HelloWorldAgent.jar
 {code}
 It adds the option 3 times and it starts three java agents. My example agent 
 print hello world once per second, but I end up with three hello world lines 
 per second.
 I attached my HelloWorldAgent.jar to demonstrate.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Created: (HBASE-3561) OPTS arguments are duplicated

2011-02-24 Thread Tim Sell (JIRA) 
OPTS arguments are duplicated
-

 Key: HBASE-3561
 URL: https://issues.apache.org/jira/browse/HBASE-3561
 Project: HBase
  Issue Type: Bug
  Components: scripts
Reporter: Tim Sell
Priority: Trivial


Some of the command line arguments constructed in the bash scripts are getting 
duplicated

Here is what my HMaster process looks like with a ps aux | grep java.

{code}
/Library/Java/Home/bin/java 
-Xmx1000m 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
-Dhbase.log.file=hbase-tims-master-grassmann.local.log 
-Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
-Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
-classpath blablablablabla
org.apache.hadoop.hbase.master.HMaster start
{code}

This wouldn't really be a problem except if you try to add a java agent in the 
hbase-env.sh like so:
{code}
export HBASE_MASTER_OPTS=$HBASE_MASTER_OPTS $HBASE_JMX_BASE 
-Dcom.sun.management.jmxremote.port=10101 -javaagent:HelloWorldAgent.jar
{code}
It adds the option 3 times and it starts three java agents. My example agent 
print hello world once per second, but I end up with three hello world lines 
per second.

I attached my HelloWorldAgent.jar to demonstrate.




-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HBASE-3561) OPTS arguments are duplicated

2011-02-24 Thread Tim Sell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Sell updated HBASE-3561:


Description: 
Some of the command line arguments constructed in the bash scripts are getting 
duplicated

Here is what my HMaster process looks like with a ps aux | grep java.

{code}
/Library/Java/Home/bin/java 
-Xmx1000m 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
-Dhbase.log.file=hbase-tims-master-grassmann.local.log 
-Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
-Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
-classpath blablablablabla
org.apache.hadoop.hbase.master.HMaster start
{code}

This wouldn't really be a problem except if you try to add a java agent in the 
hbase-env.sh like so:
{code}
export HBASE_MASTER_OPTS=$HBASE_MASTER_OPTS $HBASE_JMX_BASE 
-Dcom.sun.management.jmxremote.port=10101 -javaagent:lib/HelloWorldAgent.jar
{code}
It adds the option 3 times and it starts three java agents. My example agent 
print hello world once per second, but I end up with three hello world lines 
per second.

I attached my HelloWorldAgent.jar to demonstrate.




  was:
Some of the command line arguments constructed in the bash scripts are getting 
duplicated

Here is what my HMaster process looks like with a ps aux | grep java.

{code}
/Library/Java/Home/bin/java 
-Xmx1000m 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
-XX:+CMSIncrementalMode 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dcom.sun.management.jmxremote.ssl=false 
-Dcom.sun.management.jmxremote.authenticate=false 
-Dcom.sun.management.jmxremote.port=10101 
-Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
-Dhbase.log.file=hbase-tims-master-grassmann.local.log 
-Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
-Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
-classpath blablablablabla
org.apache.hadoop.hbase.master.HMaster start
{code}

This wouldn't really be a problem except if you try to add a java agent in the 
hbase-env.sh like so:
{code}
export HBASE_MASTER_OPTS=$HBASE_MASTER_OPTS $HBASE_JMX_BASE 
-Dcom.sun.management.jmxremote.port=10101 -javaagent:HelloWorldAgent.jar
{code}
It adds the option 3 times and it starts three java agents. My example agent 
print hello world once per second, but I end up with three hello world lines 
per second.

I attached my HelloWorldAgent.jar to demonstrate.





 OPTS arguments are duplicated
 -

 Key: HBASE-3561
 URL: https://issues.apache.org/jira/browse/HBASE-3561
 Project: HBase
  Issue Type: Bug
  Components: scripts
Reporter: Tim Sell
Priority: Trivial

 Some of the command line arguments constructed in the bash scripts are 
 getting duplicated
 Here is what my HMaster process looks like with a ps aux | grep java.
 {code}
 /Library/Java/Home/bin/java 
 -Xmx1000m 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
 -Dhbase.log.file=hbase-tims-master-grassmann.local.log 
 -Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
 -Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
 -classpath

[jira] Updated: (HBASE-3561) OPTS arguments are duplicated

2011-02-24 Thread Tim Sell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Sell updated HBASE-3561:


Attachment: HelloWorldAgent.jar

https://github.com/tims/HelloWorldAgent

 OPTS arguments are duplicated
 -

 Key: HBASE-3561
 URL: https://issues.apache.org/jira/browse/HBASE-3561
 Project: HBase
  Issue Type: Bug
  Components: scripts
Reporter: Tim Sell
Priority: Trivial
 Attachments: HelloWorldAgent.jar


 Some of the command line arguments constructed in the bash scripts are 
 getting duplicated
 Here is what my HMaster process looks like with a ps aux | grep java.
 {code}
 /Library/Java/Home/bin/java 
 -Xmx1000m 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
 -Dhbase.log.file=hbase-tims-master-grassmann.local.log 
 -Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
 -Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
 -classpath blablablablabla
 org.apache.hadoop.hbase.master.HMaster start
 {code}
 This wouldn't really be a problem except if you try to add a java agent in 
 the hbase-env.sh like so:
 {code}
 export HBASE_MASTER_OPTS=$HBASE_MASTER_OPTS $HBASE_JMX_BASE 
 -Dcom.sun.management.jmxremote.port=10101 -javaagent:lib/HelloWorldAgent.jar
 {code}
 It adds the option 3 times and it starts three java agents. My example agent 
 print hello world once per second, but I end up with three hello world lines 
 per second.
 I attached my HelloWorldAgent.jar to demonstrate.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS incorrectly.

2011-02-24 Thread Tim Sell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998899#comment-12998899
 ] 

Tim Sell commented on HBASE-3423:
-

This caused HBASE-3561, by duplicating options. 
Presumably this is needed for some reason, is there some other way to inject 
OPTIONS that wont cause duplicates?

 hbase-env.sh over-rides HBASE_OPTS incorrectly.
 ---

 Key: HBASE-3423
 URL: https://issues.apache.org/jira/browse/HBASE-3423
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.0
Reporter: Ted Dunning
 Fix For: 0.90.0, 0.92.0


 conf/hbase-env.sh has the following line:
export HBASE_OPTS=-ea -XX:+HeapDumpOnOutOfMemoryError 
 -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode
 This should be
export HBASE_OPTS=$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError 
 -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-3561) OPTS arguments are duplicated

2011-02-24 Thread Tim Sell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998963#comment-12998963
 ] 

Tim Sell commented on HBASE-3561:
-

awesome trivial fixes are the best! :)

 OPTS arguments are duplicated
 -

 Key: HBASE-3561
 URL: https://issues.apache.org/jira/browse/HBASE-3561
 Project: HBase
  Issue Type: Bug
  Components: scripts
Reporter: Tim Sell
Priority: Trivial
 Attachments: HelloWorldAgent.jar, config.txt


 Some of the command line arguments constructed in the bash scripts are 
 getting duplicated
 Here is what my HMaster process looks like with a ps aux | grep java.
 {code}
 /Library/Java/Home/bin/java 
 -Xmx1000m 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
 -Dhbase.log.file=hbase-tims-master-grassmann.local.log 
 -Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
 -Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
 -classpath blablablablabla
 org.apache.hadoop.hbase.master.HMaster start
 {code}
 This wouldn't really be a problem except if you try to add a java agent in 
 the hbase-env.sh like so:
 {code}
 export HBASE_MASTER_OPTS=$HBASE_MASTER_OPTS $HBASE_JMX_BASE 
 -Dcom.sun.management.jmxremote.port=10101 -javaagent:lib/HelloWorldAgent.jar
 {code}
 It adds the option 3 times and it starts three java agents. My example agent 
 print hello world once per second, but I end up with three hello world lines 
 per second.
 I attached my HelloWorldAgent.jar to demonstrate.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-3561) OPTS arguments are duplicated

2011-02-24 Thread Tim Sell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998974#comment-12998974
 ] 

Tim Sell commented on HBASE-3561:
-

hmm, unless I missed something, this doesn't work with the start-hbase.sh 
script it doesn't seem to load hbase-env.sh at all. Not in standalone mode 
anyway.

 OPTS arguments are duplicated
 -

 Key: HBASE-3561
 URL: https://issues.apache.org/jira/browse/HBASE-3561
 Project: HBase
  Issue Type: Bug
  Components: scripts
Reporter: Tim Sell
 Fix For: 0.90.2

 Attachments: HelloWorldAgent.jar, config.txt


 Some of the command line arguments constructed in the bash scripts are 
 getting duplicated
 Here is what my HMaster process looks like with a ps aux | grep java.
 {code}
 /Library/Java/Home/bin/java 
 -Xmx1000m 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC 
 -XX:+CMSIncrementalMode 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dcom.sun.management.jmxremote.ssl=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.port=10101 
 -Dhbase.log.dir=/Users/tims/workspace/hbase-trunk/bin/../logs 
 -Dhbase.log.file=hbase-tims-master-grassmann.local.log 
 -Dhbase.home.dir=/Users/tims/workspace/hbase-trunk/bin/.. 
 -Dhbase.id.str=tims -Dhbase.root.logger=INFO,DRFA 
 -classpath blablablablabla
 org.apache.hadoop.hbase.master.HMaster start
 {code}
 This wouldn't really be a problem except if you try to add a java agent in 
 the hbase-env.sh like so:
 {code}
 export HBASE_MASTER_OPTS=$HBASE_MASTER_OPTS $HBASE_JMX_BASE 
 -Dcom.sun.management.jmxremote.port=10101 -javaagent:lib/HelloWorldAgent.jar
 {code}
 It adds the option 3 times and it starts three java agents. My example agent 
 print hello world once per second, but I end up with three hello world lines 
 per second.
 I attached my HelloWorldAgent.jar to demonstrate.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira