[jira] [Commented] (HBASE-14111) Enable HBase ACL in REST operations
[ https://issues.apache.org/jira/browse/HBASE-14111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994397#comment-15994397 ] Weizhan Zeng commented on HBASE-14111: -- Hi , [~andrew.purt...@gmail.com] I notice REST isn't support grant api yet , should we provide ？ > Enable HBase ACL in REST operations > --- > > Key: HBASE-14111 > URL: https://issues.apache.org/jira/browse/HBASE-14111 > Project: HBase > Issue Type: Improvement > Components: REST, security >Reporter: Roberto Arias-Yacupoma >Priority: Minor > Labels: patch, security > > Currently for any operations performed by users through REST service, the > internal HBase ACL is bypassed and users can perform any operation without > security restrictions (they can view and insert data to any location). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965423#comment-15965423 ] Weizhan Zeng commented on HBASE-17816: -- thanks [~jerryhe] > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-17816.branch-1.patch, > HBASE-17816.master.001.patch, HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964494#comment-15964494 ] Weizhan Zeng commented on HBASE-17816: -- failed seen not about the patch > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.branch-1.patch, > HBASE-17816.master.001.patch, HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weizhan Zeng updated HBASE-17816: - Attachment: HBASE-17816.branch-1.patch rename patch file > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.branch-1.patch, > HBASE-17816.master.001.patch, HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weizhan Zeng updated HBASE-17816: - Attachment: (was: HBASE-17816.branch1.patch) > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weizhan Zeng updated HBASE-17816: - Attachment: HBASE-17816.branch1.patch Upload branch-1 patch > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.branch1.patch, HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962337#comment-15962337 ] Weizhan Zeng commented on HBASE-17816: -- [~jerryhe] I can upload later > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958695#comment-15958695 ] Weizhan Zeng commented on HBASE-17816: -- [~busbey] Should I resolve this issue? > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951856#comment-15951856 ] Weizhan Zeng commented on HBASE-17816: -- [~busbey] [~jerryhe] [~chia7712] [~ashu210890] thanks guys ! > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-16222) fix RegionServer Host Name
[ https://issues.apache.org/jira/browse/HBASE-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weizhan Zeng updated HBASE-16222: - Component/s: (was: Balancer) (was: Region Assignment) (was: Client) rsgroup > fix RegionServer Host Name > -- > > Key: HBASE-16222 > URL: https://issues.apache.org/jira/browse/HBASE-16222 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.0.0, 1.1.2, 1.2.2 >Reporter: weizhan Zeng >Priority: Minor > Attachments: HBASE-16222.patch > > > RegionServer Host Name was not equa meta table'r regionserver hostName. > For example, host BeiJIN.98.100.hbase.com In zk or master is > beijin.98.100.hbase.com , but in meter table is BeiJIN.98.199.hbase.com. > Because of this , when rsgroup balance compare host , that cause problem .The > reason is when regionserver report host to master , it will make the > hostname to lowcase。 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Issue Comment Deleted] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weizhan Zeng updated HBASE-17816: - Comment: was deleted (was: [~ashu210890] please help me do review on that patch ?) > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949127#comment-15949127 ] Weizhan Zeng commented on HBASE-17816: -- [~ashu210890] Please have a look is that test OK ? > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949126#comment-15949126 ] Weizhan Zeng commented on HBASE-17816: -- [~ashu210890] please help me do review on that patch ? > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948611#comment-15948611 ] Weizhan Zeng commented on HBASE-17816: -- please use HBASE-17816.master.002.patch ！ > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug > Components: metrics >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Work stopped] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-17816 stopped by Weizhan Zeng. > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weizhan Zeng updated HBASE-17816: - Attachment: HBASE-17816.master.002.patch I add a test TestHRegion#testMutateRow_WriteRequestCount , can you help review it is ok ? > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch, > HBASE-17816.master.002.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948280#comment-15948280 ] Weizhan Zeng commented on HBASE-17816: -- [~busbey] I had closed it! > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug >Reporter: Ashu Pachauri >Assignee: Weizhan Zeng > Attachments: HBASE-17816.master.001.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947457#comment-15947457 ] Weizhan Zeng commented on HBASE-17816: -- [~ashu210890] Got it ! sorry , busy for other thing . do you know how can i upload my test code ? i an newer . > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug >Reporter: Ashu Pachauri >Assignee: Ashu Pachauri > Attachments: HBASE-17816.master.001.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[
https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938547#comment-15938547
]
Weizhan Zeng commented on HBASE-17816:
--
{code:none}
MultiRowMutationProcessor proc = new MultiRowMutationProcessor(mutations,
rowsToLock);
processRowsWithLocks(proc, -1, nonceGroup, nonce);
+writeRequestsCount.add(mutations.size());
{code}
[~ashu210890] I think we should add requests after process. How do you think?
> HRegion#mutateRowWithLocks should update writeRequestCount metric
> -
>
> Key: HBASE-17816
> URL: https://issues.apache.org/jira/browse/HBASE-17816
> Project: HBase
> Issue Type: Bug
>Reporter: Ashu Pachauri
>Assignee: Ashu Pachauri
> Attachments: HBASE-17816.master.001.patch
>
>
> Currently, all the calls that use HRegion#mutateRowWithLocks miss
> writeRequestCount metric. The mutateRowWithLocks base method should update
> the metric.
> Examples are checkAndMutate calls through RSRpcServices#multi,
> Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17816) HRegion#mutateRowWithLocks should update writeRequestCount metric
[ https://issues.apache.org/jira/browse/HBASE-17816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936557#comment-15936557 ] Weizhan Zeng commented on HBASE-17816: -- [~ashu210890] I would like to upload a test , do you mind ? > HRegion#mutateRowWithLocks should update writeRequestCount metric > - > > Key: HBASE-17816 > URL: https://issues.apache.org/jira/browse/HBASE-17816 > Project: HBase > Issue Type: Bug >Reporter: Ashu Pachauri >Assignee: Ashu Pachauri > Attachments: HBASE-17816.master.001.patch > > > Currently, all the calls that use HRegion#mutateRowWithLocks miss > writeRequestCount metric. The mutateRowWithLocks base method should update > the metric. > Examples are checkAndMutate calls through RSRpcServices#multi, > Region#mutateRow api , MultiRowMutationProcessor coprocessor endpoint. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17817) Make Regionservers log which tables it removed coprocessors from when aborting
[
https://issues.apache.org/jira/browse/HBASE-17817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936500#comment-15936500
]
Weizhan Zeng commented on HBASE-17817:
--
Do you mean when RegionCoprocessorHost#execOperation appear exception , we
should do some log ?
> Make Regionservers log which tables it removed coprocessors from when aborting
> --
>
> Key: HBASE-17817
> URL: https://issues.apache.org/jira/browse/HBASE-17817
> Project: HBase
> Issue Type: Improvement
> Components: Coprocessors, regionserver
>Affects Versions: 1.1.2
>Reporter: Steen Manniche
> Labels: logging
>
> When a coprocessor throws a runtime exception (e.g. NPE), the regionserver
> handles this according to {{hbase.coprocessor.abortonerror}}.
> The output in the logs give no indication as to which table the coprocessor
> was removed from (or which version, or jarfile is the culprit). This causes
> longer debugging and recovery times.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (HBASE-17472) Correct the semantic of permission grant
[
https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823684#comment-15823684
]
Weizhan Zeng edited comment on HBASE-17472 at 1/16/17 9:36 AM:
---
+ 1
bq.1. Grant command add (not replace) one or more action(s) for a user;
bq. 2. Revoke command remove one or more action(s) for a user.
look more reasonable
was (Author: weizhan zeng):
+ 1
>1. Grant command add (not replace) one or more action(s) for a user;
> 2. Revoke command remove one or more action(s) for a user.
look more reasonable
> Correct the semantic of permission grant
> -
>
> Key: HBASE-17472
> URL: https://issues.apache.org/jira/browse/HBASE-17472
> Project: HBase
> Issue Type: Improvement
> Components: Admin
>Reporter: huzheng
>Assignee: huzheng
>
> Currently, HBase grant operation has following semantic:
> {code}
> hbase(main):019:0> grant 'hbase_tst', 'RW', 'ycsb'
> 0 row(s) in 0.0960 seconds
> hbase(main):020:0> user_permission 'ycsb'
> User
> Namespace,Table,Family,Qualifier:Permission
>
>
>
> hbase_tst default,ycsb,,:
> [Permission:actions=READ,WRITE]
>
>
> 1 row(s) in 0.0550 seconds
> hbase(main):021:0> grant 'hbase_tst', 'CA', 'ycsb'
> 0 row(s) in 0.0820 seconds
> hbase(main):022:0> user_permission 'ycsb'
> User
> Namespace,Table,Family,Qualifier:Permission
>
>
> hbase_tst default,ycsb,,:
> [Permission: actions=CREATE,ADMIN]
>
>
> 1 row(s) in 0.0490 seconds
> {code}
> Later permission will replace previous granted permissions, which confused
> most of HBase administrator.
> It's seems more reasonable that HBase merge multiple granted permission.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HBASE-17472) Correct the semantic of permission grant
[
https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823684#comment-15823684
]
Weizhan Zeng edited comment on HBASE-17472 at 1/16/17 9:33 AM:
---
+ 1
>1. Grant command add (not replace) one or more action(s) for a user;
> 2. Revoke command remove one or more action(s) for a user.
look more reasonable
was (Author: weizhan zeng):
+1
> 1. Grant command add (not replace) one or more action(s) for a user;
2. Revoke command remove one or more action(s) for a user.
look more reasonable
> Correct the semantic of permission grant
> -
>
> Key: HBASE-17472
> URL: https://issues.apache.org/jira/browse/HBASE-17472
> Project: HBase
> Issue Type: Improvement
> Components: Admin
>Reporter: huzheng
>Assignee: huzheng
>
> Currently, HBase grant operation has following semantic:
> {code}
> hbase(main):019:0> grant 'hbase_tst', 'RW', 'ycsb'
> 0 row(s) in 0.0960 seconds
> hbase(main):020:0> user_permission 'ycsb'
> User
> Namespace,Table,Family,Qualifier:Permission
>
>
>
> hbase_tst default,ycsb,,:
> [Permission:actions=READ,WRITE]
>
>
> 1 row(s) in 0.0550 seconds
> hbase(main):021:0> grant 'hbase_tst', 'CA', 'ycsb'
> 0 row(s) in 0.0820 seconds
> hbase(main):022:0> user_permission 'ycsb'
> User
> Namespace,Table,Family,Qualifier:Permission
>
>
> hbase_tst default,ycsb,,:
> [Permission: actions=CREATE,ADMIN]
>
>
> 1 row(s) in 0.0490 seconds
> {code}
> Later permission will replace previous granted permissions, which confused
> most of HBase administrator.
> It's seems more reasonable that HBase merge multiple granted permission.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17472) Correct the semantic of permission grant
[
https://issues.apache.org/jira/browse/HBASE-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823684#comment-15823684
]
Weizhan Zeng commented on HBASE-17472:
--
+1
> 1. Grant command add (not replace) one or more action(s) for a user;
2. Revoke command remove one or more action(s) for a user.
look more reasonable
> Correct the semantic of permission grant
> -
>
> Key: HBASE-17472
> URL: https://issues.apache.org/jira/browse/HBASE-17472
> Project: HBase
> Issue Type: Improvement
> Components: Admin
>Reporter: huzheng
>Assignee: huzheng
>
> Currently, HBase grant operation has following semantic:
> {code}
> hbase(main):019:0> grant 'hbase_tst', 'RW', 'ycsb'
> 0 row(s) in 0.0960 seconds
> hbase(main):020:0> user_permission 'ycsb'
> User
> Namespace,Table,Family,Qualifier:Permission
>
>
>
> hbase_tst default,ycsb,,:
> [Permission:actions=READ,WRITE]
>
>
> 1 row(s) in 0.0550 seconds
> hbase(main):021:0> grant 'hbase_tst', 'CA', 'ycsb'
> 0 row(s) in 0.0820 seconds
> hbase(main):022:0> user_permission 'ycsb'
> User
> Namespace,Table,Family,Qualifier:Permission
>
>
> hbase_tst default,ycsb,,:
> [Permission: actions=CREATE,ADMIN]
>
>
> 1 row(s) in 0.0490 seconds
> {code}
> Later permission will replace previous granted permissions, which confused
> most of HBase administrator.
> It's seems more reasonable that HBase merge multiple granted permission.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Issue Comment Deleted] (HBASE-11501) Metrics from JMX cache are not cleared
[
https://issues.apache.org/jira/browse/HBASE-11501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weizhan Zeng updated HBASE-11501:
-
Comment: was deleted
(was: @Virag Kothari I add this patch to our online cluster ,but it still
not clear. My hbase version is 1.1.6 . here is my code is change
- if (fut == null || (!fut.isDone() &&
fut.getDelay(TimeUnit.MILLISECONDS) > 100)) return;
+ if (fut != null && !fut.isDone() && fut.getDelay(TimeUnit.MILLISECONDS)
> 100){
+return;
+ }
fut = executor.getExecutor().schedule(new JmxCacheBusterRunnable(), 5,
TimeUnit.SECONDS);
)
> Metrics from JMX cache are not cleared
> --
>
> Key: HBASE-11501
> URL: https://issues.apache.org/jira/browse/HBASE-11501
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 2.0.0
>Reporter: Virag Kothari
>Assignee: Virag Kothari
> Attachments: HBASE-11501.patch, HBASE-11501.patch
>
>
> In JmxCacheBuster, clearJmxCache() has incorrect condition for starting
> JmxCacheBusterRunnable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HBASE-11501) Metrics from JMX cache are not cleared
[
https://issues.apache.org/jira/browse/HBASE-11501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784806#comment-15784806
]
Weizhan Zeng edited comment on HBASE-11501 at 12/29/16 8:03 AM:
@Virag Kothari I add this patch to our online cluster ,but it still not
clear. My hbase version is 1.1.6 . here is my code is change
- if (fut == null || (!fut.isDone() &&
fut.getDelay(TimeUnit.MILLISECONDS) > 100)) return;
+ if (fut != null && !fut.isDone() && fut.getDelay(TimeUnit.MILLISECONDS)
> 100){
+return;
+ }
fut = executor.getExecutor().schedule(new JmxCacheBusterRunnable(), 5,
TimeUnit.SECONDS);
was (Author: weizhan zeng):
@Virag Kothari I add this patch to our online cluster ,but it still not
clear. My hbase version is 1.1.6 .my code is
>>
- if (fut == null || (!fut.isDone() &&
fut.getDelay(TimeUnit.MILLISECONDS) > 100)) return;
+ if (fut != null && !fut.isDone() && fut.getDelay(TimeUnit.MILLISECONDS)
> 100){
+return;
+ }
fut = executor.getExecutor().schedule(new JmxCacheBusterRunnable(), 5,
TimeUnit.SECONDS);
> Metrics from JMX cache are not cleared
> --
>
> Key: HBASE-11501
> URL: https://issues.apache.org/jira/browse/HBASE-11501
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 2.0.0
>Reporter: Virag Kothari
>Assignee: Virag Kothari
> Attachments: HBASE-11501.patch, HBASE-11501.patch
>
>
> In JmxCacheBuster, clearJmxCache() has incorrect condition for starting
> JmxCacheBusterRunnable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11501) Metrics from JMX cache are not cleared
[
https://issues.apache.org/jira/browse/HBASE-11501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784806#comment-15784806
]
Weizhan Zeng commented on HBASE-11501:
--
@Virag Kothari I add this patch to our online cluster ,but it still not
clear. My hbase version is 1.1.6 .my code is
```
- if (fut == null || (!fut.isDone() &&
fut.getDelay(TimeUnit.MILLISECONDS) > 100)) return;
+ if (fut != null && !fut.isDone() && fut.getDelay(TimeUnit.MILLISECONDS)
> 100){
+return;
+ }
fut = executor.getExecutor().schedule(new JmxCacheBusterRunnable(), 5,
TimeUnit.SECONDS);
```
> Metrics from JMX cache are not cleared
> --
>
> Key: HBASE-11501
> URL: https://issues.apache.org/jira/browse/HBASE-11501
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 2.0.0
>Reporter: Virag Kothari
>Assignee: Virag Kothari
> Attachments: HBASE-11501.patch, HBASE-11501.patch
>
>
> In JmxCacheBuster, clearJmxCache() has incorrect condition for starting
> JmxCacheBusterRunnable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HBASE-11501) Metrics from JMX cache are not cleared
[
https://issues.apache.org/jira/browse/HBASE-11501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784806#comment-15784806
]
Weizhan Zeng edited comment on HBASE-11501 at 12/29/16 8:02 AM:
@Virag Kothari I add this patch to our online cluster ,but it still not
clear. My hbase version is 1.1.6 .my code is
>>
- if (fut == null || (!fut.isDone() &&
fut.getDelay(TimeUnit.MILLISECONDS) > 100)) return;
+ if (fut != null && !fut.isDone() && fut.getDelay(TimeUnit.MILLISECONDS)
> 100){
+return;
+ }
fut = executor.getExecutor().schedule(new JmxCacheBusterRunnable(), 5,
TimeUnit.SECONDS);
was (Author: weizhan zeng):
@Virag Kothari I add this patch to our online cluster ,but it still not
clear. My hbase version is 1.1.6 .my code is
```
- if (fut == null || (!fut.isDone() &&
fut.getDelay(TimeUnit.MILLISECONDS) > 100)) return;
+ if (fut != null && !fut.isDone() && fut.getDelay(TimeUnit.MILLISECONDS)
> 100){
+return;
+ }
fut = executor.getExecutor().schedule(new JmxCacheBusterRunnable(), 5,
TimeUnit.SECONDS);
```
> Metrics from JMX cache are not cleared
> --
>
> Key: HBASE-11501
> URL: https://issues.apache.org/jira/browse/HBASE-11501
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 2.0.0
>Reporter: Virag Kothari
>Assignee: Virag Kothari
> Attachments: HBASE-11501.patch, HBASE-11501.patch
>
>
> In JmxCacheBuster, clearJmxCache() has incorrect condition for starting
> JmxCacheBusterRunnable
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HBASE-17382) Give RegionLocateType a better name
[ https://issues.apache.org/jira/browse/HBASE-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784566#comment-15784566 ] Weizhan Zeng edited comment on HBASE-17382 at 12/29/16 5:48 AM: Sorry ! Since "It is a type of the locating operation", what about "LocateRegionOperationType"? was (Author: weizhan zeng): Sorry ! Since "It is a type of the locating operation", what about "RegionLocateOperationType"? > Give RegionLocateType a better name > --- > > Key: HBASE-17382 > URL: https://issues.apache.org/jira/browse/HBASE-17382 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Jan Hentschel > Attachments: HBASE-17382.master.001.patch > > > Pointed out by [~tedyu] that 'Locate' is a verb and usually we need a noun > here. 'Locating' or 'Location'? > Suggestion are welcomed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17382) Give RegionLocateType a better name
[ https://issues.apache.org/jira/browse/HBASE-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784566#comment-15784566 ] Weizhan Zeng commented on HBASE-17382: -- Sorry ! Since "It is a type of the locating operation", what about "RegionLocateOperationType"? > Give RegionLocateType a better name > --- > > Key: HBASE-17382 > URL: https://issues.apache.org/jira/browse/HBASE-17382 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Jan Hentschel > Attachments: HBASE-17382.master.001.patch > > > Pointed out by [~tedyu] that 'Locate' is a verb and usually we need a noun > here. 'Locating' or 'Location'? > Suggestion are welcomed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17382) Give RegionLocateType a better name
[ https://issues.apache.org/jira/browse/HBASE-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782928#comment-15782928 ] Weizhan Zeng commented on HBASE-17382: -- Location is good. > Give RegionLocateType a better name > --- > > Key: HBASE-17382 > URL: https://issues.apache.org/jira/browse/HBASE-17382 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: Jan Hentschel > > Pointed out by [~tedyu] that 'Locate' is a verb and usually we need a noun > here. 'Locating' or 'Location'? > Suggestion are welcomed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
