[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125785#comment-16125785 ] brandboat commented on HBASE-8518: -- And I don't know this solution is okay or not. > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: brandboat >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125782#comment-16125782 ] brandboat commented on HBASE-8518: -- To keep this test "testRecoveredEditsReplayCompaction()", there must have a way to let compaction not complete. What I have already thought now is add another TestHRegion extends from HRegion, overriding all method which uses HStore and replace all HStore to TestHStore which has a method that we can trigger compaction not complete. But the problem is if HRegion has something changed inside the mehtod that I have already overrided, this patch would lose efficacy. > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Assignee: brandboat >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125746#comment-16125746 ] brandboat commented on HBASE-17980: --- [~chia7712] Let me take over this issue. > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai > Labels: beginner > Fix For: 2.0.0 > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18582) Correct the docs for Mutation#setCellVisibility
[ https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-18582: -- Affects Version/s: 1.2.7 1.5.0 1.3.2 1.4.0 2.0.0 Status: Patch Available (was: Open) remove stale comment > Correct the docs for Mutation#setCellVisibility > --- > > Key: HBASE-18582 > URL: https://issues.apache.org/jira/browse/HBASE-18582 > Project: HBase > Issue Type: Task > Components: documentation >Affects Versions: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 >Reporter: Chia-Ping Tsai >Assignee: brandboat >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18582.master.v0.patch > > > {code} > /** >* Sets the visibility expression associated with cells in this Mutation. >* It is illegal to set CellVisibility on Delete > mutation. >* @param expression >*/ > {code} > HBASE-10885 enable Delete to be specified with Cell Visibility, so we should > remove the comment " It is illegal to set..." -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18582) Correct the docs for Mutation#setCellVisibility
[ https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-18582: -- Attachment: HBASE-18582.master.v0.patch remove stale comment. > Correct the docs for Mutation#setCellVisibility > --- > > Key: HBASE-18582 > URL: https://issues.apache.org/jira/browse/HBASE-18582 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Chia-Ping Tsai >Assignee: brandboat >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18582.master.v0.patch > > > {code} > /** >* Sets the visibility expression associated with cells in this Mutation. >* It is illegal to set CellVisibility on Delete > mutation. >* @param expression >*/ > {code} > HBASE-10885 enable Delete to be specified with Cell Visibility, so we should > remove the comment " It is illegal to set..." -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18582) Correct the docs for Mutation#setCellVisibility
[ https://issues.apache.org/jira/browse/HBASE-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat reassigned HBASE-18582: - Assignee: brandboat > Correct the docs for Mutation#setCellVisibility > --- > > Key: HBASE-18582 > URL: https://issues.apache.org/jira/browse/HBASE-18582 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Chia-Ping Tsai >Assignee: brandboat >Priority: Minor > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > > {code} > /** >* Sets the visibility expression associated with cells in this Mutation. >* It is illegal to set CellVisibility on Delete > mutation. >* @param expression >*/ > {code} > HBASE-10885 enable Delete to be specified with Cell Visibility, so we should > remove the comment " It is illegal to set..." -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-8518) Get rid of hbase.hstore.compaction.complete setting
[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113045#comment-16113045 ] brandboat commented on HBASE-8518: -- [~sershe], [~chia7712] , may I take over this issue ? It seems that samar has already removed the hbase.hstore.compaction.complete in the CompactTool.java and HStore.java in patch. The remaining is refactor the test code, right ? > Get rid of hbase.hstore.compaction.complete setting > --- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement >Reporter: Sergey Shelukhin >Priority: Minor > Labels: beginner > Attachments: HBASE-8518-1.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Attachment: HBASE-16014.master.001.patch resubmit patch > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014.master.001.patch, HBASE-16014_v0.patch, > HBASE-16014_v1.patch, HBASE-16014_v2.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Attachment: HBASE-16014_v2.patch resubmit patch > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch, HBASE-16014_v1.patch, > HBASE-16014_v2.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15727851#comment-15727851 ] brandboat commented on HBASE-16014: --- Hello,I've already solved this issue. If there is any question, please let me know. Thanks a lot. > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch, HBASE-16014_v1.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576258#comment-15576258 ] brandboat commented on HBASE-16014: --- I am not going to do more tests. Thanks for reviewing it. > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch, HBASE-16014_v1.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Attachment: HBASE-16014_v1.patch use git diff, not git format-patch > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch, HBASE-16014_v1.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Attachment: (was: HBASE-16014_v1.patch) > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Attachment: HBASE-16014_v1.patch > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch, HBASE-16014_v1.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Attachment: (was: HBASE-16014_v1.patch) > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch, HBASE-16014_v1.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Attachment: HBASE-16014_v1.patch > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch, HBASE-16014_v1.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Fix Version/s: 2.0.0 Release Note: Add 2 constructors fot API Get 1. Get(byte[], int, int) 2. Get(ByteBuffer) Affects Version/s: 2.0.0 Status: Patch Available (was: Open) > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Nick Dimiduk >Assignee: brandboat > Fix For: 2.0.0 > > Attachments: HBASE-16014_v0.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] brandboat updated HBASE-16014: -- Attachment: HBASE-16014_v0.patch > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Reporter: Nick Dimiduk >Assignee: brandboat > Attachments: HBASE-16014_v0.patch > > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16014) Get and Put constructor argument lists are divergent
[ https://issues.apache.org/jira/browse/HBASE-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369214#comment-15369214 ] brandboat commented on HBASE-16014: --- Hello Nick, I am not authorized to assign this issue to myself. Could you assign it for me ? Thanks. > Get and Put constructor argument lists are divergent > > > Key: HBASE-16014 > URL: https://issues.apache.org/jira/browse/HBASE-16014 > Project: HBase > Issue Type: Bug >Reporter: Nick Dimiduk > > API for construing Get and Put objects for a specific rowkey is quite > different. > [Put|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Put.html#constructor_summary] > supports many more variations for specifying the target rowkey and timestamp > compared to > [Get|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Get.html#constructor_summary]. > Notably lacking are {{Get(byte[], int, int)}} and {{Get(ByteBuffer)}} > variations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)