[GitHub] [hbase] Apache9 commented on a change in pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-23 Thread GitBox 


Apache9 commented on a change in pull request #1955:
URL: https://github.com/apache/hbase/pull/1955#discussion_r444314587



##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java
##
@@ -191,50 +186,22 @@ public boolean keepRegionEvent(Entry entry) {
 return false;
   }
 
+  /**
+   * @return Returns a base HFile without compressions or encodings; good 
enough for recovery

Review comment:
   Actually the timeout can be set per rpc request on the same connection.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a change in pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-22 Thread GitBox 


Apache9 commented on a change in pull request #1955:
URL: https://github.com/apache/hbase/pull/1955#discussion_r443946747



##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java
##
@@ -191,50 +186,22 @@ public boolean keepRegionEvent(Entry entry) {
 return false;
   }
 
+  /**
+   * @return Returns a base HFile without compressions or encodings; good 
enough for recovery

Review comment:
   Should we try to get the TableDescriptor first? If it is not possible, 
then we fallback to write generic HFiles.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org