[GitHub] [hbase] Apache9 commented on a change in pull request #3444: HBASE-26049 Remove DfsBuilderUtility
Apache9 commented on a change in pull request #3444: URL: https://github.com/apache/hbase/pull/3444#discussion_r670476089 ## File path: hbase-procedure/pom.xml ## @@ -144,6 +144,10 @@ log4j-slf4j-impl test + Review comment: The indent is incorrect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3444: HBASE-26049 Remove DfsBuilderUtility
Apache9 commented on a change in pull request #3444:
URL: https://github.com/apache/hbase/pull/3444#discussion_r669294478
##
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
##
@@ -1070,7 +1072,13 @@ boolean rollWriter(long logId) throws IOException {
long startPos = -1;
newLogFile = getLogFilePath(logId);
try {
- newStream = CommonFSUtils.createForWal(fs, newLogFile, false);
+ FSDataOutputStreamBuilder builder =
fs.createFile(newLogFile).overwrite(false);
+ if (builder instanceof
DistributedFileSystem.HdfsDataOutputStreamBuilder) {
Review comment:
OK, could leave it as is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3444: HBASE-26049 Remove DfsBuilderUtility
Apache9 commented on a change in pull request #3444:
URL: https://github.com/apache/hbase/pull/3444#discussion_r667967586
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##
@@ -54,7 +51,8 @@
* https://issues.apache.org/jira/browse/HBASE-20838;>HBASE-20838
for more details.
*/
@InterfaceAudience.Private
-public final class CommonFSUtils {
+public final class
+CommonFSUtils {
Review comment:
Typo? We do not need a new line here...
##
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
##
@@ -1070,7 +1072,13 @@ boolean rollWriter(long logId) throws IOException {
long startPos = -1;
newLogFile = getLogFilePath(logId);
try {
- newStream = CommonFSUtils.createForWal(fs, newLogFile, false);
+ FSDataOutputStreamBuilder builder =
fs.createFile(newLogFile).overwrite(false);
+ if (builder instanceof
DistributedFileSystem.HdfsDataOutputStreamBuilder) {
Review comment:
We could add a replicate(FSDataOutputStreamBuilder) method in
CommonFSUtils to abstract the instance of logic? Otherwise we need to write
instanceof at difference place multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
