[GitHub] [hbase] Apache9 commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…

2020-03-23 Thread GitBox
Apache9 commented on issue #1323: HBASE-23981 PBType which is marked as 
IA.Public references protobuf M…
URL: https://github.com/apache/hbase/pull/1323#issuecomment-603001960
 
 
   > everything in hbase-examples should be IA.Public, right?
   
   In my opinion, No. For me, example means you can copy the code, but not 
depend on the code...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache9 commented on issue #1323: HBASE-23981 PBType which is marked as IA.Public references protobuf M…

2020-03-23 Thread GitBox
Apache9 commented on issue #1323: HBASE-23981 PBType which is marked as 
IA.Public references protobuf M…
URL: https://github.com/apache/hbase/pull/1323#issuecomment-602985556
 
 
   In general, the rule is to mark it as deprecated first, and keep it through 
a whole major release, and then delete it.
   
   So by the rule we should not move this class in 3.0.0. But it is a bit 
different is that, this is a broken behavior, where we expose protobuf in our 
public API, so I prefer we just remove it 3.0.0 release, and will open a sub 
task to mark it as deprecated on branch-2 and branch-2.3.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services