[GitHub] [hbase] Apache9 commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache9 commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-894324707 Pushed to branch HBASE-26067. Closed this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache9 commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-894215554 > > Ping @wchevreuil @saintstack @z-york Any other concerns on this approach? If worth a try, I will merge this to a feature branch and start to implement file based tracking. Thanks. > > I think this is good to go, @Apache9 . Are you planning to merge this on a separate feature branch, or the one created in [HBASE-24749](https://issues.apache.org/jira/browse/HBASE-24749)? It might conflict with the works I had made there for flushes and compactions, but I think this refactoring basically dismisses those. The splits/merges one (still open), may still apply. Better on another feature branch, I think this is another abstraction way comparing to HBASE-24749. We could work together on the following issues on how to better implement merge and split, with this abstraction way, and also how to integrate the region based tracking way which has already been implemented on branch HBASE-24749. If these things all work, then I think we could unify these two feature branches. If not, I think we need to go back to the design doc to discuss again. The goal of this issue is to make the store file tracking way pluggable so we will all be happy. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache9 commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-893426689 Ping @wchevreuil @saintstack @z-york Any other concerns on this approach? If worth a try, I will merge this to a feature branch and start to implement file based tracking. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache9 commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-02510 @saintstack @wchevreuil @z-york I've modified the patch. PTAL. Now most storefile relate operations are moved to StoreEngine, and we will not expose StoreFileTracker to upper layer any more. In HStore we just need to call the methods in StoreEngine, and inside StoreEngine we will update StoreFileTracker and then StoreFileManager. The store lock is also moved into StoreEngine to allow we do fine-grained lock in StoreEngine. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache9 commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-879196037 Moved StoreFileTracker to StoreEngine, per @z-york and @saintstack 's suggestion on the design doc. And the root reason is I found that there is already a DateTieredStoreEngine, where we just make use DefaultStoreFileManager, so when switching StoreEngine, it does not mean that you need to change all the components. So I think make all StoreEngine use the same StoreFileTracker abstraction is also workable here. And I also moved the createWriterInTmp method to StoreFileTracker, to hide the requireCreateInTmp method. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…
Apache9 commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-876465025 https://docs.google.com/document/d/16Nr1Fn3VaXuz1g1FTiME-bnGR3qVK5B-raXshOkDLcY/edit?usp=sharing I've finish the first version of the design doc. PTAL. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org