[GitHub] [hbase] EungsopYoo commented on pull request #4942: HBASE-27547 Close store file readers after region warmup
EungsopYoo commented on PR #4942: URL: https://github.com/apache/hbase/pull/4942#issuecomment-1379938945 How about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] EungsopYoo commented on pull request #4942: HBASE-27547 Close store file readers after region warmup
EungsopYoo commented on PR #4942: URL: https://github.com/apache/hbase/pull/4942#issuecomment-1378620034 > > > > OK, it is https://issues.apache.org/jira/browse/HBASE-15441. > > > > I think for warmup, the region should be opened as read only so it should not write any markers to WAL. > > > > And [HBASE-15441](https://issues.apache.org/jira/browse/HBASE-15441) should have been included in 1.4.13, so this should not be the root cause of too many FDs? > > > > WDYT? @EungsopYoo > > > > Thanks. > > > > > > > > > Right. In 1.4.13, the warmed up region is not closed too. It's not the cause. https://github.com/apache/hbase/blob/rel/1.4.13/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L7163-L7164 > > > > > > I misunderstood your question. > > There are two points. The first is the leakage of open FDs during region moving(due to warmup), and the second is that HBase 2.4 opens much more FDs than HBase 1.4. > > In this PR, I fixed the first. The second is still in question. > > So I mean we should try to restore the old behavior, to close the warm up region? Now we support open a region in read only mode so when closing the region, we will not write any wal out, so it will not mess up wal splitting. WDYT? > > Thanks. I think it's good to close warmed up region. Is it enough just to close the region? ```diff --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java @@ -7773,6 +7773,7 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver, Regi } HRegion r = HRegion.newHRegion(tableDir, wal, fs, conf, info, htd, null); r.initializeWarmup(reporter); +r.close(); } /** ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] EungsopYoo commented on pull request #4942: HBASE-27547 Close store file readers after region warmup
EungsopYoo commented on PR #4942: URL: https://github.com/apache/hbase/pull/4942#issuecomment-1377109033 > > OK, it is https://issues.apache.org/jira/browse/HBASE-15441. > > I think for warmup, the region should be opened as read only so it should not write any markers to WAL. > > And [HBASE-15441](https://issues.apache.org/jira/browse/HBASE-15441) should have been included in 1.4.13, so this should not be the root cause of too many FDs? > > WDYT? @EungsopYoo > > Thanks. > > Right. In 1.4.13, the warmed up region is not closed too. It's not the cause. https://github.com/apache/hbase/blob/rel/1.4.13/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L7163-L7164 I misunderstood your question. There are two points. The first is the leakage of open FDs during region moving(due to warmup), and the second is that HBase 2.4 opens much more FDs than HBase 1.4. In this PR, I fixed the first. The second is still in question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] EungsopYoo commented on pull request #4942: HBASE-27547 Close store file readers after region warmup
EungsopYoo commented on PR #4942: URL: https://github.com/apache/hbase/pull/4942#issuecomment-1376732392 @Apache9 This PR does not close the warmed up region. It just closes the store file reader in the region. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] EungsopYoo commented on pull request #4942: HBASE-27547 Close store file readers after region warmup
EungsopYoo commented on PR #4942: URL: https://github.com/apache/hbase/pull/4942#issuecomment-1367813344 > OK, it is https://issues.apache.org/jira/browse/HBASE-15441. > > I think for warmup, the region should be opened as read only so it should not write any markers to WAL. > > And [HBASE-15441](https://issues.apache.org/jira/browse/HBASE-15441) should have been included in 1.4.13, so this should not be the root cause of too many FDs? > > WDYT? @EungsopYoo > > Thanks. Right. In 1.4.13, the warmed up region is not closed too. It's not the cause. https://github.com/apache/hbase/blob/rel/1.4.13/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L7163-L7164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
