[GitHub] [hbase] HorizonNet commented on a change in pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-23 Thread GitBox 


HorizonNet commented on a change in pull request #1953:
URL: https://github.com/apache/hbase/pull/1953#discussion_r444078893



##
File path: 
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java
##
@@ -137,6 +137,103 @@ public Job createSubmittableJob(Configuration conf) 
throws IOException {
 return job;
   }
 
+  /**
+   * Sets up the actual job.
+   *
+   * @param conf  The current configuration.
+   * @param args  The command line parameters.
+   * @return The newly created job.
+   * @throws IOException When setting up the job fails.
+   * @deprecated please use main method instead.

Review comment:
   If it is deprecated in 2.3.0 we need a whole major release cycle to 
remove it. The next one then would be 4.0.0.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] HorizonNet commented on a change in pull request #1953: HBASE-21773 - Addendum - Bring back "public static Job createSubmitta…

2020-06-22 Thread GitBox 


HorizonNet commented on a change in pull request #1953:
URL: https://github.com/apache/hbase/pull/1953#discussion_r443755808



##
File path: 
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java
##
@@ -137,6 +137,103 @@ public Job createSubmittableJob(Configuration conf) 
throws IOException {
 return job;
   }
 
+  /**
+   * Sets up the actual job.
+   *
+   * @param conf  The current configuration.
+   * @param args  The command line parameters.
+   * @return The newly created job.
+   * @throws IOException When setting up the job fails.
+   * @deprecated please use main method instead.

Review comment:
   Please also include since which release it is deprecated. We had this 
case just now that we had a deprecation comment, which was not in line with our 
ref documentation.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org