[GitHub] [hbase] YutSean commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor
YutSean commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-997885255 Refined the variable name in the latest commit. I think this is more readable then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor
YutSean commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994250531 Left some comments to explain in the corresponding ticket. @Reidd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor
YutSean commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-994250198 Left comments > LGTM. Can you explain more about the pics in the ticket you upload? I don't quite catch what it tells -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor
YutSean commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-990925914 The failed UT is not related with the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor
YutSean commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-990532276 Reconstructed the code and extracted the RpcHandler to avoid the redundant coding of fastpath handler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #3929: HBASE-26551 Add FastPath feature to HBase RWQueueRpcExecutor
YutSean commented on pull request #3929: URL: https://github.com/apache/hbase/pull/3929#issuecomment-989577939 I have two considerations. 1. Wether we should make the fastpath as a new config that user can turn on or off alternatively (Because it seems that when the number of handlers is really small, fastpath does not has such good performance). 2. I copy the fastpath handler from FastPathBalancedRpcExecutor. This looks a little bit ugly. Should we extract the fastpath mechanism in a new file and just import it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
