[GitHub] [hbase] ZhaoBQ commented on a change in pull request #3042: HBASE-25655 Add a new option in PE to indicate the current number of rows in the test table

2021-04-09 Thread GitBox 


ZhaoBQ commented on a change in pull request #3042:
URL: https://github.com/apache/hbase/pull/3042#discussion_r610438585



##
File path: 
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
##
@@ -2637,19 +2648,17 @@ protected static void printUsage(final String 
shortName, final String message) {
 "'valueSize'; set on read for stats on size: Default: Not set.");
 System.err.println(" blockEncoding   Block encoding to use. Value should 
be one of "
 + Arrays.toString(DataBlockEncoding.values()) + ". Default: NONE");
+System.err.println(" initRowsThe total rows currently in the 
table. When initRows "
++ "is less than totalRows(perClientRunRows * nclients), initRows will 
be set equal to "
++ "totalRows. Default: -1");

Review comment:
   Sir, sorry to bother you, are there any questions here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] ZhaoBQ commented on a change in pull request #3042: HBASE-25655 Add a new option in PE to indicate the current number of rows in the test table

2021-03-18 Thread GitBox 


ZhaoBQ commented on a change in pull request #3042:
URL: https://github.com/apache/hbase/pull/3042#discussion_r597385188



##
File path: 
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
##
@@ -2637,19 +2648,17 @@ protected static void printUsage(final String 
shortName, final String message) {
 "'valueSize'; set on read for stats on size: Default: Not set.");
 System.err.println(" blockEncoding   Block encoding to use. Value should 
be one of "
 + Arrays.toString(DataBlockEncoding.values()) + ". Default: NONE");
+System.err.println(" initRowsThe total rows currently in the 
table. When initRows "
++ "is less than totalRows(perClientRunRows * nclients), initRows will 
be set equal to "
++ "totalRows. Default: -1");

Review comment:
   Added some descriptions




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org