[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

[GitBox]

apurtell commented on pull request #2576:
URL: https://github.com/apache/hbase/pull/2576#issuecomment-721353246


   Last commit on PR branch addresses remaining feedback, going to commit 
shortly. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

[GitBox]

apurtell commented on pull request #2576:
URL: https://github.com/apache/hbase/pull/2576#issuecomment-718871541


   Unit test failure seems unrelated, probable flaky test
   
   [ERROR]   TestDurability.testDurability:132->verifyWALCount:242 
expected:<10> but was:<9>



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

[GitBox]

apurtell commented on pull request #2576:
URL: https://github.com/apache/hbase/pull/2576#issuecomment-718239306


   Rebase and address review feedback



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

[GitBox]

apurtell commented on pull request #2576:
URL: https://github.com/apache/hbase/pull/2576#issuecomment-716802337


   Rebase. Sync with updates to master branch patch.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

[GitBox]

apurtell commented on pull request #2576:
URL: https://github.com/apache/hbase/pull/2576#issuecomment-715627619


   Test failure is unrelated
   
   > [ERROR]   
TestSlowLogAccessor.testSlowLogRecords:112->waitForSlowLogTableCreation:174 
Waiting timed out after [2,000] msec
   
   @virajjasani Maybe this test has too short a timeout given sometimes public 
CI resources are loaded up?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

[GitBox]

apurtell commented on pull request #2576:
URL: https://github.com/apache/hbase/pull/2576#issuecomment-715487408


   Rebase and fix checkstyle nits



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

[GitBox]

apurtell commented on pull request #2576:
URL: https://github.com/apache/hbase/pull/2576#issuecomment-715453309


   Will push up fixes for the checkstyle nits in a bit.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org