[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

2020-11-24 Thread GitBox 


apurtell commented on pull request #2695:
URL: https://github.com/apache/hbase/pull/2695#issuecomment-733398228


   Pushed checkstyle fixes
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

2020-11-24 Thread GitBox 


apurtell commented on pull request #2695:
URL: https://github.com/apache/hbase/pull/2695#issuecomment-733274059


   Aha, now the checkstyle warns show up here as in the branch-1 precommit. 
These are expected and legacy and related to import order. Let me make a pass 
over them. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

2020-11-24 Thread GitBox 


apurtell commented on pull request #2695:
URL: https://github.com/apache/hbase/pull/2695#issuecomment-733239058


   Thanks @Reidd !



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #2695: HBASE-24640 Purge use of VisibleForTesting

2020-11-24 Thread GitBox 


apurtell commented on pull request #2695:
URL: https://github.com/apache/hbase/pull/2695#issuecomment-733097251


   @Reidd Mind adding your +1 here as well so I can merge down the line? 
Sorry to bother.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org