arshadmohammad commented on a change in pull request #2361:
URL: https://github.com/apache/hbase/pull/2361#discussion_r485344280



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java
##########
@@ -231,16 +235,18 @@ private static RegionInfo buildRegionInfo(TableName tn, 
byte [] start, byte [] e
   /**
    * Fix overlaps noted in CJ consistency report.
    */
-  void fixOverlaps(CatalogJanitor.Report report) throws IOException {
+  List<Long> fixOverlaps(CatalogJanitor.Report report) throws IOException {
+    List<Long> pidList = new ArrayList<>();

Review comment:
       Yes, to make the fix more testable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to