[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-573888707 > @apurtell, @saintstack no further comments? I'd like to merge this one today. Just had an offline chat with @apurtell about this. He mentioned he has no objections for the patch to go in today. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-572742767 Rebased on top of my other patch that was merged few minutes ago. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-572699482 I was mentioning this to @ndimiduk offline but just wanted to update here too, for the record. JUnit BeforeParam does not work for us as expected because it runs **before** the test class constructor is called and does not have access to the test parameters. I've clarified this in the test comments. Also rebased and squashed commits. Thanks for the reviews. At this point we are waiting for @apurtell to take another look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-572324821 Works for me. Try re-running? I noticed the mini cluster in cluster is very flaky, especially when you run it in a dev setup. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-571830020 > [ERROR] org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor.testCheckAndDeleteWithCompareOp[0] Time elapsed: 0.142 s <<< ERROR! @ndimiduk I think I figured out the flaky test problem. I pushed another commit that deflakes the test and all of these TestClient* now pass in my IDE too. To summarize, JUnit parameterization (with test class hiearchy) is a PITA. Without my last commit, *every* unit test of *every parameterized test* run was reseting the cluster state. JUnit does not yet provide of a way to execute a hook at the end of each parameterized test run. So, I hacked my way around it. I'm hoping it should pass now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-570749954 Fixed the check style issues and rebased on the latest tip of the feature branch (and squashed all the commits). Test failures seem to be flakes and run fine for me locally. I think this is good to go for another round of review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-569974349 @saintstack / @apurtell Any thoughts on the new design? Happy to address any concerns. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #954: HBASE-23305: Master based registry implementation
bharathv commented on issue #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954#issuecomment-569152093 Fixed all the test failures from the last run in the latest push. One of the fixes comes in as a separate PR to master https://github.com/apache/hbase/pull/963 . To pull that in, the current feature branch needs a rebase on master. Also, from the last test run, the thread usage has substantially dropped due to the test cleanup. I think this is in a good shape for 2nd round of review. Appreciate any feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
