[GitHub] [hbase] bharathv commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.
bharathv commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-659540298 Agree that the indents can be fixed separately in the interest of keeping the patch smaller. +1 from my side on the patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.
bharathv commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-65804 > Just a question: The speed is inline with 1.3? Its within 5-10% bounds based on my preliminary analysis (on my local box, **if this optimization kicks in**). Will have to do a detailed cluster based perf run to dig deeper. As discussed in the jira, there is scope for further optimization for general use cases (specifically when versions=1, arbitrary bloom filters types etc) but that might need a bigger refactor of code. My point being that we cannot generally compare with 1.3 until we fix those issues too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.
bharathv commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-658879791 Looks like branch-1 pre-commit is broken. @Reidd has a patch at #2065. Let me take a look at that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
