[GitHub] [hbase] bsglz commented on a diff in pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…

2022-06-02 Thread GitBox 


bsglz commented on code in PR #4390:
URL: https://github.com/apache/hbase/pull/4390#discussion_r888213692


##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:
##
@@ -2042,6 +2043,22 @@ public void abort() throws IOException {
 
   @Override
   public boolean needsCompaction() {
+// For some system compacting, we set selectNow to false, and the files do 
not

Review Comment:
   The current logic is an improvement introduced by HBASE-8665, which could 
get better store file selection.
   I think that patch is useful, just bring some side effect, and this patch 
want to fix it.
   BTW, skimming that patch maybe helpful to understand.
   Thanks a lot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] bsglz commented on a diff in pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…

2022-05-19 Thread GitBox 


bsglz commented on code in PR #4390:
URL: https://github.com/apache/hbase/pull/4390#discussion_r876727305


##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##
@@ -347,7 +347,6 @@ public class HRegion implements HeapSize, 
PropagatingConfigurationObserver, Regi
   final LongAdder compactionsFailed = new LongAdder();
   final LongAdder compactionNumFilesCompacted = new LongAdder();
   final LongAdder compactionNumBytesCompacted = new LongAdder();
-  final LongAdder compactionsQueued = new LongAdder();

Review Comment:
   > I think moving compaction metrics to HStore would be better.
   
   I can move the other compaction metrics in a follow-on issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] bsglz commented on a diff in pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…

2022-05-06 Thread GitBox 


bsglz commented on code in PR #4390:
URL: https://github.com/apache/hbase/pull/4390#discussion_r866444359


##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##
@@ -347,7 +347,6 @@ public class HRegion implements HeapSize, 
PropagatingConfigurationObserver, Regi
   final LongAdder compactionsFailed = new LongAdder();
   final LongAdder compactionNumFilesCompacted = new LongAdder();
   final LongAdder compactionNumBytesCompacted = new LongAdder();
-  final LongAdder compactionsQueued = new LongAdder();

Review Comment:
   Yeah, you are right, i thought about it too, but did not find a better way, 
maybe all that metrics should be moved to HStore?
   Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] bsglz commented on a diff in pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…

2022-05-05 Thread GitBox 


bsglz commented on code in PR #4390:
URL: https://github.com/apache/hbase/pull/4390#discussion_r866444359


##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##
@@ -347,7 +347,6 @@ public class HRegion implements HeapSize, 
PropagatingConfigurationObserver, Regi
   final LongAdder compactionsFailed = new LongAdder();
   final LongAdder compactionNumFilesCompacted = new LongAdder();
   final LongAdder compactionNumBytesCompacted = new LongAdder();
-  final LongAdder compactionsQueued = new LongAdder();

Review Comment:
   Yeah, you are right, i thought about it too, but did not find a better way, 
maybe all that metrics should be moved to HStore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org