[GitHub] [hbase] bsglz commented on pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…
bsglz commented on PR #4390: URL: https://github.com/apache/hbase/pull/4390#issuecomment-1711391714 Ping @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…
bsglz commented on PR #4390: URL: https://github.com/apache/hbase/pull/4390#issuecomment-1138214609 @Apache9 Can i have +1 from you, or any more issues? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…
bsglz commented on PR #4390: URL: https://github.com/apache/hbase/pull/4390#issuecomment-1132545150 > +1 overall, also the idea seems good. @bsglz let's wait for one more review? No prob, thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…
bsglz commented on PR #4390: URL: https://github.com/apache/hbase/pull/4390#issuecomment-1131363792 > The idea looks good overall. @bsglz do you have any recommendation on the max files to compact value? Do you mean the value for hbase.hstore.compaction.max? The default value is 10, i think its ok. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…
bsglz commented on PR #4390: URL: https://github.com/apache/hbase/pull/4390#issuecomment-1119225852 > Mind explaining more about your solution? Yeah, the problem here is we put too many compactions to queue, so i think the solution for it is to find how many is suitable. Consider the CompactionRunner will try its best to select more hfiles when running but limited by hbase.hstore.compaction.max, so seems let (allFilesInStore-filesCompating)/hbase.hstore.compaction.max as upper limit is enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…
bsglz commented on PR #4390: URL: https://github.com/apache/hbase/pull/4390#issuecomment-1119203753 > Mind explaining more about your solution? No problem, will add more info in issue desc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…
bsglz commented on PR #4390: URL: https://github.com/apache/hbase/pull/4390#issuecomment-1116098457 rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
