[GitHub] [hbase] busbey commented on a change in pull request #1714: HBASE-24373 Implement JvmMetrics in HBase instead of using the one in hadoop
busbey commented on a change in pull request #1714: URL: https://github.com/apache/hbase/pull/1714#discussion_r431527682 ## File path: hbase-logging/src/main/java/org/apache/log4j/Logger.java ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.log4j; + +import org.apache.yetus.audience.InterfaceAudience; + +/** + * Just for making hadoop work without log4j Review comment: If these are for making Hadoop work, they should be in the hadoop-compat module? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1714: HBASE-24373 Implement JvmMetrics in HBase instead of using the one in hadoop
busbey commented on a change in pull request #1714:
URL: https://github.com/apache/hbase/pull/1714#discussion_r431527371
##
File path: hbase-logging/src/main/java/org/apache/log4j/Logger.java
##
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.log4j;
+
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Just for making hadoop work without log4j
+ */
+@InterfaceAudience.Private
+public class Logger {
Review comment:
This doesn't end up in our client facing artifacts right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
